Here cmd is int so I haven't made any changes. for listit I used qWarning()
followed by abort(). Please review it.
On Wed, Jan 9, 2013 at 5:16 PM, David Faure wrote:
> On Wednesday 09 January 2013 16:45:08 Jignesh Kakadiya wrote:
> > Hi David,
> >
> > I have ported all kError calls to qWarning
On Saturday 5 January 2013 16:24:46 Chusslove Illich wrote:
> Well it does prevent us from calling it, because Ki18n should depend on
> KLocale in the future. That's the technical reason not to do this, but there
> is also a principal one.
>
> The locale should provide user's language preference, t
On Wednesday, January 9, 2013 16:42:25 Mark wrote:
> KDirLister ends up high in the stack because it parses a massive QByteArray
> that comes from kio_file. I wasn't actually talking about the stat call but
> more about the massive data (as a result of that stat call) that gets send
> back.
On Wed
On Wednesday, January 9, 2013 16:42:25 Mark wrote:
> Show data as early as possible even if it's incomplete. Defer the
imho, one place that dolphin currently fails in going too far in this
direction is that folders do not get a folder icon until thumbnails start
dribbling in. using the generic m
On Wed, Jan 9, 2013 at 2:51 PM, David Faure wrote:
> On Wednesday 09 January 2013 11:15:20 Mark wrote:
>> A little more in depth questions for KDirLister and KFileItem. In my
>> profiling KFileItem ends up high due to various reasons, but
>> KDirLister is also a bit of a heavy resource hog due to
On Wednesday 09 January 2013 11:15:20 Mark wrote:
> A little more in depth questions for KDirLister and KFileItem. In my
> profiling KFileItem ends up high due to various reasons, but
> KDirLister is also a bit of a heavy resource hog due to it's default
> behavior of fetching all file information
On Tue, Jan 08, 2013 at 03:05:25PM +0100, Chusslove Illich wrote:
> >> [: Chusslove Illich :]
> >> I'm not opposed to some additional bureaucracy in order to make the
> >> framework more accessible to potential users. [...]
> >
> > [: Oswald Buddenhagen :]
> > [...] i'd hate it to see my thoroughly
On Wednesday 09 January 2013 16:45:08 Jignesh Kakadiya wrote:
> Hi David,
>
> I have ported all kError calls to qWarning and kFatal to qFatal in
> kdelibs/kio/kio directory. Compiles successfully. Please review it.
>
> Next patch will be removal of kdebug.h include from kio/kio.
qFatal("Fatal Er
Hi David,
I have ported all kError calls to qWarning and kFatal to qFatal in
kdelibs/kio/kio directory. Compiles successfully. Please review it.
Next patch will be removal of kdebug.h include from kio/kio.
Thanks,
Jignesh
kError_and_kFatal.patch
Description: Binary data
___
On Tue, Jan 8, 2013 at 5:41 PM, David Faure wrote:
> On Tuesday 08 January 2013 15:52:23 Aurélien Gâteau wrote:
>> Le lundi 31 décembre 2012 11:43:47 David Faure a écrit :
>> [snip]
>>
>> > If you want to think "bigger redesign", one could consider adding the
>> > necessary API to KDirModel so tha
On Wednesday 09 January 2013 14:03:25 Jignesh Kakadiya wrote:
> Hi,
>
> I have ported all kWarning calls to qWarning in kdelibs/kio/kio directory.
> Please review it.
Looks ok, thanks.
Next step, removing kdebug.h includes?
--
David Faure, fa...@kde.org, http://www.davidfaure.fr
Working on KDE
Hi,
I have ported all kWarning calls to qWarning in kdelibs/kio/kio directory.
Please review it.
Thanks,
Jignesh
kWarning_to_qWarning.patch
Description: Binary data
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.or
On Wednesday 09 January 2013 11:26:35 Jignesh Kakadiya wrote:
> Hi David,
>
> I have fixed the above changes and also there are few >=2 liner kDebug
> calls. I have replaced it with /* qDebug. And yes it compiles successfully.
> Please review it.
Looks good, please apply. Thanks!
--
David Faure
13 matches
Mail list logo
