On Thursday 29 November 2012, David Faure wrote:
> On Thursday 29 November 2012 09:36:33 Alexander Neundorf wrote:
> > On Thursday 29 November 2012, David Faure wrote:
> > > On Thursday 29 November 2012 09:08:05 Alexander Neundorf wrote:
> > > > In KDE4 we do it this way because we did it this way
At Thursday 13 December 2012 11:40:15 David Faure wrote:
> Hi Jon,
>
> Glad to see you committing to frameworks again :-)
>
> Just one question though: do you need the Qt4 compatibility?
No, I just did some cleanup I needed in order to test that other changes I'm
still playing around with works
On Wednesday 12 December 2012 09:54:21 Treeve Jelbert wrote:
> I would suggest applying it to KDE/4.9 branch and then forward porting
> to master, KDE/4.10 , frameworks.
I don't think we should touch 4.9 for this, it doesn't fix a bug there, let's
start at 4.10.
> It also reduces the number of e
> On Dec. 13, 2012, 9:12 a.m., John Layt wrote:
> > No. This is very very wrong. Week day name *does* depend on both calendar
> > and language, as does month name. This is for a very specific and widely
> > used case for religious calendars in particular where they are used in
> > parallel
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107687/#review23398
---
> won't this prevent the french revolutionary calendar to ever
Treeve Jelbert wrote:
> Qt5 has now removed some functions which were previously deprecated.
>
> the attached script will scan an entire git branch and fix any use of
> the following cases:
Thanks. Actually most of those things are still there, but deprecated and
wrapped in #if QT_DEPRECATED_SI
On 2012-12-13, Jon Severinsson wrote:
> Week length depends on the week system (i.e. KLocale::WeekNumberSystem) use=
> d,
> not the calendar used, and is 7 for all week systems supported by KDE.
won't this prevent the french revolutionary calendar to ever be
supported?
/Sune
___
Qt5 has now removed some functions which were previously deprecated.
the attached script will scan an entire git branch and fix any use of
the following cases:
{To,From}Ascii
Qt::WFlags
I have used this script locally an all my kde repos, applying it to
4.9/master/4.10/frameworks branches a
> On Dec. 13, 2012, 9:01 a.m., John Layt wrote:
> > I personally don't see the need for this. It's not making things faster,
> > and restricting future options. Changing the public api method from
> > virtual to inline is not very future-proof.
> >
> > On the whole virtual vs inline thing, I
> On Dec. 13, 2012, 8:48 a.m., John Layt wrote:
> > Please do not replace named variables or method calls with "Magic Numbers",
> > this is bad coding practise as it makes the code harder to read and
> > understand and maintain. If you must optimise the code, please use a
> > "#define DAYS_IN
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107696/#review23392
---
No. This is very very wrong. Week day name *does* depend on b
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107688/#review23391
---
I personally don't see the need for this. It's not making thin
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107688/#review23390
---
I personally don't see the need for this. It's not making thin
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107688/#review23389
---
I personally don't see the need for this. It's not making thin
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107687/#review23388
---
Please do not replace named variables or method calls with "Mag
15 matches
Mail list logo
