Review Request: Port from KApplication KCmdLineArgs to QApplication in unit tests. Remove KAboutData where no longer needed.

2012-08-09 Thread Jeremy Paul Whiting
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105955/ --- Review request for KDE Frameworks. Description --- Port from KApplica

Re: KColorScheme

2012-08-09 Thread Matthew Woehlke
On 2012-08-09 07:43, David Faure wrote: On Friday 20 July 2012 14:19:47 Matthew Woehlke wrote: I think going with flags is probably a good idea; I would probably do that by keeping the existing sets, roles and shades as distinct, but allow combining them into one variable, e.g.: QPalette::ViewS

Re: Review Request: Don't lose the original CMAKE_MODULE_PATH

2012-08-09 Thread Alexander Neundorf
On Wednesday 08 August 2012, Patrick Spendrin wrote: > Am 08.08.2012 22:52, schrieb Alexander Neundorf: > > On Tuesday 07 August 2012, Patrick Spendrin wrote: > >> Am 07.08.2012 22:42, schrieb Alexander Neundorf: > > ... > > > >> > Setting CMAKE_REQUIRED_INCLUDES and CMAKE_REQUIRED_LIBRARIES withi

Re: Review Request: do translation correctly in solid

2012-08-09 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105944/#review17152 --- This review has been submitted with commit 2d9b923ab34714359b9

Re: Review Request: do translation correctly in solid

2012-08-09 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105944/#review17151 --- Ship it! Thanks. kupnpdevice.cpp is weird (translate never ca

Review Request: do translation correctly in solid

2012-08-09 Thread George Goldberg
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105944/ --- Review request for KDE Frameworks and David Faure. Description --- us

Re: Review Request: Make kcodecs framework build standalone

2012-08-09 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105860/#review17148 --- This review has been submitted with commit f6c3868f9a2c5f8a96f

Re: KColorScheme

2012-08-09 Thread David Faure
On Friday 20 July 2012 14:19:47 Matthew Woehlke wrote: > I think going with flags is probably a good idea; I would probably do > that by keeping the existing sets, roles and shades as distinct, but > allow combining them into one variable, e.g.: > > QPalette::ViewSet | QPalette::Background | QPa

Re: Review Request: Make kcodecs framework build standalone

2012-08-09 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105860/#review17136 --- Ship it! Ship It! - David Faure On Aug. 8, 2012, 7:20 p.m.,

Re: Review Request: Make kcodecs framework build standalone

2012-08-09 Thread George Goldberg
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105860/ --- (Updated Aug. 8, 2012, 7:20 p.m.) Review request for KDE Frameworks and Da

Re: Review Request: Make kcodecs framework build standalone

2012-08-09 Thread George Goldberg
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105860/ --- (Updated Aug. 8, 2012, 2:07 p.m.) Review request for KDE Frameworks and Da