Re: Request to bump QT_MIN_VERSION to 5.15.2 for whole Plasma

2022-06-27 Thread Heiko Becker
Hello, On Sunday, 26 June 2022 13:52:23 CEST, Ömer Fadıl USTA wrote: Right now plasma projects' minimum depends on KF >5.90 and after KF5.86 its REQUIRED_QT_VERSION is 5.15.2 thus keeping QT_MIN_VERSION as 5.15.0 is meaningless and it also causes problems such as in this merge : https://invent.k

Re: Request to bump QT_MIN_VERSION to 5.15.2 for whole Plasma

2022-06-27 Thread Jonathan Riddell
I've now bumped all of Plasma to depend on Qt 5.15.2 as we had agreed that some time ago but I seem not to have made the change. It's not clear from your post that you really did mean Plasma though, Plasma is only our desktop, other apps are separate and have their own dependencies. Jonathan On

Re: Request to bump QT_MIN_VERSION to 5.15.2 for whole Plasma

2022-06-27 Thread Ömer Fadıl USTA
Thank you for deciding to bump to 5.15.2 . That `Konsole` MR example was just a living example. I know that Konsole is not part of Plasma projects but KDE Gears but i give it as an example how might new contributors think that 5.15.0 and 5.15.2 api compatible but actually aren't. [ adding new meth

What happened to "Allow commits from members who can merge to the target branch."?

2022-06-27 Thread Simon Redman
Hi all, Previously when making a PR, I was able to select a checkbox to allow others to merge to my PR branch: Now, that box seems to have vanished. Did I miss a discussion about removing this feature? It's super useful so that I can do small fixups to a stale PR and then merge it. Thanks

Re: What happened to "Allow commits from members who can merge to the target branch."?

2022-06-27 Thread Nicolás Alvarez
El lun, 27 jun 2022 a la(s) 19:09, Simon Redman (si...@ergotech.com) escribió: > Hi all, > > Previously when making a PR, I was able to select a checkbox to allow > others to merge to my PR branch: > > > Now, that box seems to have vanished. > > Did I miss a discussion about removing this feature?