Re: Proposal: make squash-merging the default behavior for gitlab MRs

2020-10-03 Thread Boudewijn Rempt
On Friday, 2 October 2020 19:39:37 CEST Nate Graham wrote: > Thoughts? Like others have said, please, no. Squashed commits are the worst things to have in a git history. They make it hard to use git blame, they make it hard to read the history... And the whole argument about making life easier

Announcing MyKDE

2020-10-03 Thread Carl Schwan
Hello folks, I'm happy to announce the successful deployment of the new identity system in KDE, codename MyKDE. The new identity system is now available in https://my.kde.org. You should be able to login into the my.kde.org website with your normal KDE credential. For the moment, only the wikis ar

Re: Proposal: make squash-merging the default behavior for gitlab MRs

2020-10-03 Thread David Hurka
> That doesn't prevent me from having a clean history when I finally git-push > to an opened MR, so my colleagues could easily review my code. I know that > if I'd push some "dirty" commits to my "merge request", my colleagues would > unnecessarily spend time navigating these commits, and reviewing

Re: Proposal: make squash-merging the default behavior for gitlab MRs

2020-10-03 Thread Johan Ouwerkerk
On Sat, Oct 3, 2020 at 12:26 AM David Hurka wrote: > > > > However, it remains a fairly advanced workflow which is challenging for > > > newcomers, drive-by-developers, and people not as familiar with git. For > > > these people, squash-merging makes much more sense, [...] > > This workflow is too

Re: Proposal: make squash-merging the default behavior for gitlab MRs

2020-10-03 Thread Johan Ouwerkerk
On Sat, Oct 3, 2020 at 10:15 AM Boudewijn Rempt wrote: > > On Friday, 2 October 2020 19:39:37 CEST Nate Graham wrote: > > > Thoughts? > > Like others have said, please, no. Squashed commits are the worst things to > have in a git history. They make it hard to use git blame, they make it hard > t

Re: Proposal: make squash-merging the default behavior for gitlab MRs

2020-10-03 Thread David Edmundson
> > your_merge_request_commit_history > > . > > However, it remains a fairly advanced workflow which is challenging for > newcomers, drive-by-developers, and people not as familiar with git. For > these peo

Re: Proposal: make squash-merging the default behavior for gitlab MRs

2020-10-03 Thread Johan Ouwerkerk
On Sat, Oct 3, 2020 at 12:19 PM David Hurka wrote: > > Why should colleagues navigate through any commits, when the MR is intended to > be squashed? Wouldn’t squash merge make it easier to review an MR? > No because squashing happens only when merging, i.e. *after* reviewing. So if you review com

Re: Proposal: make squash-merging the default behavior for gitlab MRs

2020-10-03 Thread Elvis Angelaccio
On 02/10/20 19:39, Nate Graham wrote: > Hello folks, Hi > I've been told that our Sysadmins have developed some tooling capable of > checking the "Squash when merging" checkbox by default for new Merge > Requests. This would be a downstream solution to > https://gitlab.com/gitlab-org/gitlab/-/iss

Re: Announcing MyKDE

2020-10-03 Thread Nate Graham
Super cool stuff! Great work, Carl. Nate On 10/3/20 3:56 AM, Carl Schwan wrote: Hello folks, I'm happy to announce the successful deployment of the new identity system in KDE, codename MyKDE. The new identity system is now available in https://my.kde.org. You should be able to login into the

Re: Announcing MyKDE

2020-10-03 Thread Uli Klinkhammer
Hey Carl. Great work!! Many thanks for that. Uli On 2020-10-03 11:56, Carl Schwan wrote: > Hello folks, > I'm happy to announce the successful deployment of the new identity system > in KDE, codename MyKDE. The new identity system is now available in > https://my.kde.org. You should be able to

Re: Announcing MyKDE

2020-10-03 Thread Piyush Aggarwal
Amazing work! Best Piyush Aggarwal On Sat, 3 Oct, 2020, 3:26 pm Carl Schwan, wrote: > Hello folks, > I'm happy to announce the successful deployment of the new identity system > in KDE, codename MyKDE. The new identity system is now available in > https://my.kde.org. You should be able to login