RFC: Running clang-format across all Plasma (and more?) repos

2019-07-11 Thread David Edmundson
One topic discussed at the recent Plasma sprint was that we should run a code formatting tool (clang-format) over all our repos to ease all future review comments about whitespace. All new contributions simply have to run the same tool and we get consistent code without having to comment on every

Re: RFC: Running clang-format across all Plasma (and more?) repos

2019-07-11 Thread Hugo Pereira Da Costa
Hi David, On 7/11/19 4:18 PM, David Edmundson wrote: One topic discussed at the recent Plasma sprint was that we should run a code formatting tool (clang-format) over all our repos to ease all future review comments about whitespace. All new contributions simply have to run the same tool and w

Re: RFC: Running clang-format across all Plasma (and more?) repos

2019-07-11 Thread Carl Schwan
Hi, I like the idea a lot and I would love to do the same for the websites. Probably using tools like [PHP Coding Standards Fixer](https://cs.symfony.com/). Cheers, Carl ‐‐‐ Original Message ‐‐‐ On Thursday 11 July 2019 16:18, David Edmundson wrote: > One topic discussed at the recent

Re: RFC: Running clang-format across all Plasma (and more?) repos

2019-07-11 Thread alcinos
Hi, Just to mention that we have a .clang-format in Kdenlive as well ( https://invent.kde.org/kde/kdenlive/blob/master/.clang-format) I designed it so that it would be consistent but match rather closely the dominant style in the code-base at the time I wrote it. Unfortunately, we don't currently

Re: RFC: Running clang-format across all Plasma (and more?) repos

2019-07-11 Thread David Edmundson
On Thu, Jul 11, 2019 at 3:32 PM alcinos wrote: > > Hi, > > Just to mention that we have a .clang-format in Kdenlive as well > (https://invent.kde.org/kde/kdenlive/blob/master/.clang-format) Oh awesome, do you mind if I ask some questions? Did running it across the base cause any issues? Did it

Re: RFC: Running clang-format across all Plasma (and more?) repos

2019-07-11 Thread Martin Flöser
Am 2019-07-11 16:18, schrieb David Edmundson: One topic discussed at the recent Plasma sprint was that we should run a code formatting tool (clang-format) over all our repos to ease all future review comments about whitespace. All new contributions simply have to run the same tool and we get con