On Thu, Mar 28, 2019 at 7:56 PM Konstantin Kharlamov wrote:
>
>
>
> On Чт, Mar 28, 2019 at 19:40, Ben Cooksley wrote:
> > Hi all,
> >
> > We currently have a rather substantial issue, in that the CI system
> > has been once again left in a position where it isn't possible to make
> > any changes
Hello,
On Thursday, 28 March 2019 09:16:11 CET Ben Cooksley wrote:
> Please note that the commits in this instance were pushed without
> review, so restrictions on merge requests wouldn't make a difference
> in this case unfortunately.
Maybe it's about time to make reviews mandatory... I know it'
In data giovedì 28 marzo 2019 09:29:22 CET, Kevin Ottens ha scritto:
> at your screen or pair with you" in the past. Clearly this compromise gets
> somewhat exploited and that's especially bad in the case of a fragile and
> central component like KDE PIM.
I'm not sure I agree. I can't speak for s
Hello,
On Thursday, 28 March 2019 09:41:29 CET Luca Beltrame wrote:
> In data giovedì 28 marzo 2019 09:29:22 CET, Kevin Ottens ha scritto:
> > at your screen or pair with you" in the past. Clearly this compromise gets
> > somewhat exploited and that's especially bad in the case of a fragile and
>
On Thu, Mar 28, 2019 at 10:09 AM Luca Beltrame wrote:
>
> In data giovedì 28 marzo 2019 09:50:47 CET, Kevin Ottens ha scritto:
> > I'd argue we're loosing more with the current state of PIM than we'd loose
> > with mandatory reviews.
>
> Perhaps, instead of an all-or-nothing approach, why not a mi
Hello,
On Thursday, 28 March 2019 10:08:54 CET Luca Beltrame wrote:
> In data giovedì 28 marzo 2019 09:50:47 CET, Kevin Ottens ha scritto:
> > I'd argue we're loosing more with the current state of PIM than we'd loose
> > with mandatory reviews.
>
> Perhaps, instead of an all-or-nothing approach,
Hello,
On Thursday, 28 March 2019 10:35:37 CET Luca Beltrame wrote:
> In data giovedì 28 marzo 2019 10:32:39 CET, Kevin Ottens ha scritto:
> > OK, to be fair not 100% today's situation because of the above. It was
> > based on best judgment maybe we're missing such a set of guidelines. I
> > admit
On Thursday, 28 March 2019 09:50:47 CET Kevin Ottens wrote:
> Hello,
>
> On Thursday, 28 March 2019 09:41:29 CET Luca Beltrame wrote:
> > In data giovedì 28 marzo 2019 09:29:22 CET, Kevin Ottens ha scritto:
> > > at your screen or pair with you" in the past. Clearly this compromise
> > > gets
> >
On Thursday, March 28, 2019 9:50:47 AM CET Kevin Ottens wrote:
> Hello,
>
> On Thursday, 28 March 2019 09:41:29 CET Luca Beltrame wrote:
> > In data giovedì 28 marzo 2019 09:29:22 CET, Kevin Ottens ha scritto:
> > > at your screen or pair with you" in the past. Clearly this compromise
> > > gets
>
Am Donnerstag, 28. März 2019, 09:29:22 CET schrieb Kevin Ottens:
> Hello,
>
> On Thursday, 28 March 2019 09:16:11 CET Ben Cooksley wrote:
> > Please note that the commits in this instance were pushed without
> > review, so restrictions on merge requests wouldn't make a difference
> > in this case
Hello,
On Thursday, 28 March 2019 11:27:44 CET Daniel Vrátil wrote:
> I'm completely fine with mandatory code review for everything and I'd be
> happy to have this in PIM. I think the biggest problem in PIM to overcome
> will be finding the reviewers - I dare say I'm currently the only one who
> h
Le jeudi 28 mars 2019, 09:29:22 CET Kevin Ottens a écrit :
> Hello,
>
> On Thursday, 28 March 2019 09:16:11 CET Ben Cooksley wrote:
> > Please note that the commits in this instance were pushed without
> > review, so restrictions on merge requests wouldn't make a difference
> > in this case unfort
With regards to the discussion about mandatory code review, I think it's
important to avoid immediately rushing to create new policy as a result of a
particular event or abuse. It's always tempting to try to put in place a rule
that would have avoided the problem if it had existed and was being
Hello,
On Thursday, 28 March 2019 14:33:59 CET laurent Montel wrote:
> I am against to force mandatory review, as it will create a lot of lose of
> time,
As I said, unpopular.
> and we will not be sure that review is correct (see comment from
> Volker about "transaction lock regression")
This a
Am Donnerstag, 28. März 2019, 11:27:44 CET schrieb Daniel Vrátil:
> I'm completely fine with mandatory code review for everything and I'd be
> happy to have this in PIM. I think the biggest problem in PIM to overcome
> will be finding the reviewers - I dare say I'm currently the only one who
> has
On 28 March 2019 13:33:59 GMT, laurent Montel wrote:
> Le jeudi 28 mars 2019, 09:29:22 CET Kevin Ottens a écrit :
> > Hello,
> >
> > On Thursday, 28 March 2019 09:16:11 CET Ben Cooksley wrote:
> > > Please note that the commits in this instance were pushed without
> > > review, so restrictions
Hi Laurent,
Am Donnerstag, 28. März 2019, 14:33:59 CET schrieb laurent Montel:
> For example I works all days on kde (pim or other) when I wake up, or at
> noon after my lunch or the evening, I will not wait several days for a
> review because nobody has time to do it.
>
> (For example I make ~ 1
Hello,
On Thursday, 28 March 2019 16:11:12 CET Friedrich W. H. Kossebau wrote:
> Am Donnerstag, 28. März 2019, 14:33:59 CET schrieb laurent Montel:
> > For example I works all days on kde (pim or other) when I wake up, or at
> > noon after my lunch or the evening, I will not wait several days for
On Thursday, March 28, 2019 3:39:54 PM CET Friedrich W. H. Kossebau wrote:
> Am Donnerstag, 28. März 2019, 11:27:44 CET schrieb Daniel Vrátil:
> > I'm completely fine with mandatory code review for everything and I'd be
> > happy to have this in PIM. I think the biggest problem in PIM to overcome
>
Le jeudi 28 mars 2019, 16:11:12 CET Friedrich W. H. Kossebau a écrit :
> Hi Laurent,
>
> Am Donnerstag, 28. März 2019, 14:33:59 CET schrieb laurent Montel:
> > For example I works all days on kde (pim or other) when I wake up, or at
> > noon after my lunch or the evening, I will not wait several d
On Thursday, 28 March 2019 16:32:34 CET Luca Beltrame wrote:
> In data giovedì 28 marzo 2019 15:15:23 CET, Nate Graham ha scritto:
> > In this case, it seems like the problem is that there are certain
> > individuals or teams that are pushing risky, breaking changes without code
> > review, and the
On Thu, Mar 28, 2019 at 3:57 PM David Jarvie wrote:
> I agree. Mandatory reviews might work if there is a team of active people
> working on a project, but if there is only one person with real knowledge of
> the code
We do have common ownership of code, so if there is only one person
with real
On Thursday, 28 March 2019 16:11:12 CET Friedrich W. H. Kossebau wrote:
> Am Donnerstag, 28. März 2019, 14:33:59 CET schrieb laurent Montel:
> > For example I works all days on kde (pim or other) when I wake up, or at
> > noon after my lunch or the evening, I will not wait several days for a
> > re
Am Donnerstag, 28. März 2019, 16:04:01 CET schrieb Boudhayan Gupta:
> I don't care if you lose time. I don't want the guys building my house to
> cut corners mixing my concrete because it's going to save time.
There is a difference here though, no? The people building your house will
not live in
Thanks for reply. More below:
Am Donnerstag, 28. März 2019, 16:56:33 CET schrieb laurent Montel:
> Le jeudi 28 mars 2019, 16:11:12 CET Friedrich W. H. Kossebau a écrit :
> > Hi Laurent,
> >
> > Am Donnerstag, 28. März 2019, 14:33:59 CET schrieb laurent Montel:
> > > For example I works all days o
In data giovedì 28 marzo 2019 09:50:47 CET, Kevin Ottens ha scritto:
> I'd argue we're loosing more with the current state of PIM than we'd loose
> with mandatory reviews.
Perhaps, instead of an all-or-nothing approach, why not a minimal set of
"requirements" that would require a review? Yes, it
In data giovedì 28 marzo 2019 10:32:39 CET, Kevin Ottens ha scritto:
> OK, to be fair not 100% today's situation because of the above. It was based
> on best judgment maybe we're missing such a set of guidelines. I admit I'm
> slightly doubtful though.
I can't claim it may work 100%, but I've see
Hi,
(Sorry for top-posting)
I fear that a mandatory reviews would add too juch strain on smaller teams. If
there's just one person with an intimate knowledge of the code-base, plus two
co-developers, then who should do the reviews?
How about a distinction based on importance of a project inste
In data giovedì 28 marzo 2019 16:04:01 CET, Boudhayan Gupta ha scritto:
> I don't get why mandatory code reviews are so unpopular.
It's not "unpopular". As far as the discussion goes, the opinions (from
several parties) say that they're not a silver bullet, and that some projects
benefit from t
On Thu, Mar 28, 2019, 6:36 AM Friedrich W. H. Kossebau
wrote:
> Am Donnerstag, 28. März 2019, 09:29:22 CET schrieb Kevin Ottens:
> > Hello,
> >
> > On Thursday, 28 March 2019 09:16:11 CET Ben Cooksley wrote:
> > > Please note that the commits in this instance were pushed without
> > > review, so
In data giovedì 28 marzo 2019 15:15:23 CET, Nate Graham ha scritto:
> In this case, it seems like the problem is that there are certain
> individuals or teams that are pushing risky, breaking changes without code
> review, and then ignoring failures in the CI. I think we might do well to
> try to
In data giovedì 28 marzo 2019 10:17:18 CET, Tomaz Canabrava ha scritto:
> The problem is that a git comit is a git commit, there's no way that a
> typo will be treated differently then another commit.
It's a "social" problem and not a technical one: you can see it across
repositories managed by
Hi,
On Thu, 28 Mar 2019 at 15:21, Kevin Ottens wrote:
> Hello,
>
> On Thursday, 28 March 2019 14:33:59 CET laurent Montel wrote:
> > I am against to force mandatory review, as it will create a lot of lose
> of
> > time,
>
> As I said, unpopular.
>
I don't get why mandatory code reviews are so u
Kevin Ottens schrieb am Do., 28. März 2019, 09:29:
> Hello,
>
> On Thursday, 28 March 2019 09:16:11 CET Ben Cooksley wrote:
> > Please note that the commits in this instance were pushed without
> > review, so restrictions on merge requests wouldn't make a difference
> > in this case unfortunately
Hi Juan Carlos,
Le mercredi 27 mars 2019, 14:03:54 CET Juan Carlos Torres a écrit :
> Greetings KDE Community!
>
> I'm Juan Carlos Torres (Jucato on IRC) and I've recently been hired as a
> contractor to get the ball rolling on updating our developer documentation.
> Over the years, our community
Hi,
On 2019 M03 28, Thu 16:04:01 CET Boudhayan Gupta wrote:
> Hi,
>
> On Thu, 28 Mar 2019 at 15:21, Kevin Ottens wrote:
> > Hello,
> >
> > On Thursday, 28 March 2019 14:33:59 CET laurent Montel wrote:
> > > I am against to force mandatory review, as it will create a lot of lose
> >
> > of
> >
Hi,
> Hi,
>
> On Thu, 28 Mar 2019 at 15:21, Kevin Ottens wrote:
>
>> Hello,
>>
>> On Thursday, 28 March 2019 14:33:59 CET laurent Montel wrote:
>> > I am against to force mandatory review, as it will create a lot of lose
>> of
>> > time,
>>
>> As I said, unpopular.
>>
>
> I don't get why manda
On Fri, Mar 29, 2019 at 3:11 AM Olivier Churlaud
wrote:
> I started porting some tutorials to the repos where they belongs as
> examples (for instance KWallet (https://phabricator.kde.org/D14955) and
> KMessageBox (https://phabricator.kde.org/D14957).
That's awesome! Thanks for getting this st
Le jeudi 28 mars 2019, 18:27:42 CET Friedrich W. H. Kossebau a écrit :
> Thanks for reply. More below:
>
> Am Donnerstag, 28. März 2019, 16:56:33 CET schrieb laurent Montel:
> > Le jeudi 28 mars 2019, 16:11:12 CET Friedrich W. H. Kossebau a écrit :
> > > Hi Laurent,
> > >
> > > Am Donnerstag, 28.
39 matches
Mail list logo
