Re: QT_DEPRECATED_BEFORE/KF_DISABLE_DEPRECATED_BEFORE_AND_AT=0x060000 considered harmful

2019-10-24 Thread Volker Krause
On Thursday, 24 October 2019 21:59:02 CEST David Faure wrote: > On jeudi 24 octobre 2019 18:49:02 CEST Volker Krause wrote: > > On Thursday, 24 October 2019 16:41:58 CEST David Faure wrote: > > > On jeudi 24 octobre 2019 16:32:32 CEST Volker Krause wrote: > > > > Maybe we should look at this separa

Re: QT_DEPRECATED_BEFORE/KF_DISABLE_DEPRECATED_BEFORE_AND_AT=0x060000 considered harmful

2019-10-24 Thread David Faure
On jeudi 24 octobre 2019 18:49:02 CEST Volker Krause wrote: > On Thursday, 24 October 2019 16:41:58 CEST David Faure wrote: > > On jeudi 24 octobre 2019 16:32:32 CEST Volker Krause wrote: > > > Maybe we should look at this separately for stable branches and master? > > > > Makes sense for Applicat

Re: QT_DEPRECATED_BEFORE/KF_DISABLE_DEPRECATED_BEFORE_AND_AT=0x060000 considered harmful

2019-10-24 Thread Allan Sandfeld Jensen
On Thursday, 24 October 2019 18:52:34 CEST laurent Montel wrote: > > For example I rebuild all kde each week. > And I think that other guys do the same. > So perhaps CI will not catch at the moment. > Not with the lastest Qt. These macros break lastest and future Qt build every single time. I ha

Re: QT_DEPRECATED_BEFORE/KF_DISABLE_DEPRECATED_BEFORE_AND_AT=0x060000 considered harmful

2019-10-24 Thread Allan Sandfeld Jensen
On Thursday, 24 October 2019 02:26:15 CEST Friedrich W. H. Kossebau wrote: > Hi, > > happy to see people starting to adapt the new deprecation macros available > with KDE Frameworks (and any other library using ECMGenerateExportHeader, > coming with ECM 5.64). > > Just, I see commits adding thing

Re: QT_DEPRECATED_BEFORE/KF_DISABLE_DEPRECATED_BEFORE_AND_AT=0x060000 considered harmful

2019-10-24 Thread laurent Montel
Le jeudi 24 octobre 2019, 18:22:07 CEST Friedrich W. H. Kossebau a écrit : > Am Donnerstag, 24. Oktober 2019, 17:40:51 CEST schrieb laurent Montel: > > Le jeudi 24 octobre 2019, 16:53:04 CEST Friedrich W. H. Kossebau a écrit : > > > Am Donnerstag, 24. Oktober 2019, 16:32:32 CEST schrieb Volker Krau

Re: QT_DEPRECATED_BEFORE/KF_DISABLE_DEPRECATED_BEFORE_AND_AT=0x060000 considered harmful

2019-10-24 Thread Volker Krause
On Thursday, 24 October 2019 16:41:58 CEST David Faure wrote: > On jeudi 24 octobre 2019 16:32:32 CEST Volker Krause wrote: > > Maybe we should look at this separately for stable branches and master? > > Makes sense for Applications (assuming we lower down from 0x06 to > latest- tested when ma

Re: QT_DEPRECATED_BEFORE/KF_DISABLE_DEPRECATED_BEFORE_AND_AT=0x060000 considered harmful

2019-10-24 Thread Friedrich W. H. Kossebau
Am Donnerstag, 24. Oktober 2019, 17:40:51 CEST schrieb laurent Montel: > Le jeudi 24 octobre 2019, 16:53:04 CEST Friedrich W. H. Kossebau a écrit : > > Am Donnerstag, 24. Oktober 2019, 16:32:32 CEST schrieb Volker Krause: > > > For master however this is less of an issue, as you say we actively por

Re: QT_DEPRECATED_BEFORE/KF_DISABLE_DEPRECATED_BEFORE_AND_AT=0x060000 considered harmful

2019-10-24 Thread laurent Montel
Le jeudi 24 octobre 2019, 16:53:04 CEST Friedrich W. H. Kossebau a écrit : > Am Donnerstag, 24. Oktober 2019, 16:32:32 CEST schrieb Volker Krause: > > On Thursday, 24 October 2019 10:50:07 CEST laurent Montel wrote: > > > Hi, > > > As discussed with David previously for QT_DEPRECATED, I am against

Re: QT_DEPRECATED_BEFORE/KF_DISABLE_DEPRECATED_BEFORE_AND_AT=0x060000 considered harmful

2019-10-24 Thread Friedrich W. H. Kossebau
Am Donnerstag, 24. Oktober 2019, 16:32:32 CEST schrieb Volker Krause: > On Thursday, 24 October 2019 10:50:07 CEST laurent Montel wrote: > > Hi, > > As discussed with David previously for QT_DEPRECATED, I am against it, > > because if we fix a QT/KF_DEPRECATED version we can be sure that nobody > >

Re: QT_DEPRECATED_BEFORE/KF_DISABLE_DEPRECATED_BEFORE_AND_AT=0x060000 considered harmful

2019-10-24 Thread David Faure
On jeudi 24 octobre 2019 16:32:32 CEST Volker Krause wrote: > Maybe we should look at this separately for stable branches and master? Makes sense for Applications (assuming we lower down from 0x06 to latest- tested when master itself is branched into a stable branch). No such separation in KF

Re: QT_DEPRECATED_BEFORE/KF_DISABLE_DEPRECATED_BEFORE_AND_AT=0x060000 considered harmful

2019-10-24 Thread Volker Krause
On Thursday, 24 October 2019 10:50:07 CEST laurent Montel wrote: > Hi, > As discussed with David previously for QT_DEPRECATED, I am against it, > because if we fix a QT/KF_DEPRECATED version we can be sure that nobody > will work for fixing deprecated method until kf6. > If we can"t see that it bre

Re: QT_DEPRECATED_BEFORE/KF_DISABLE_DEPRECATED_BEFORE_AND_AT=0x060000 considered harmful

2019-10-24 Thread Friedrich W. H. Kossebau
Am Donnerstag, 24. Oktober 2019, 10:50:07 CEST schrieb laurent Montel: > Hi, > As discussed with David previously for QT_DEPRECATED, I am against it, > because if we fix a QT/KF_DEPRECATED version we can be sure that nobody > will work for fixing deprecated method until kf6. > If we can"t see that

Re: QT_DEPRECATED_BEFORE/KF_DISABLE_DEPRECATED_BEFORE_AND_AT=0x060000 considered harmful

2019-10-24 Thread laurent Montel
Hi, As discussed with David previously for QT_DEPRECATED, I am against it, because if we fix a QT/KF_DEPRECATED version we can be sure that nobody will work for fixing deprecated method until kf6. If we can"t see that it breaks, everybody will wait for sure (otherwise it was already fixed). When

Re: QT_DEPRECATED_BEFORE/KF_DISABLE_DEPRECATED_BEFORE_AND_AT=0x060000 considered harmful

2019-10-24 Thread David Faure
On jeudi 24 octobre 2019 02:26:15 CEST Friedrich W. H. Kossebau wrote: > Hi, > > happy to see people starting to adapt the new deprecation macros available > with KDE Frameworks (and any other library using ECMGenerateExportHeader, > coming with ECM 5.64). > > Just, I see commits adding things li

QT_DEPRECATED_BEFORE/KF_DISABLE_DEPRECATED_BEFORE_AND_AT=0x060000 considered harmful

2019-10-24 Thread Friedrich W. H. Kossebau
Hi, happy to see people starting to adapt the new deprecation macros available with KDE Frameworks (and any other library using ECMGenerateExportHeader, coming with ECM 5.64). Just, I see commits adding things like --- 8< --- add_definitions(-DKF_DISABLE_DEPRECATED_BEFORE_AND_AT=0x06 --- 8<