Re: Feature matrix for future infrastructure

2015-01-23 Thread Martin Klapetek
load them, apply and then push). But I'm unsure of these features on either side, so I left it blank and would like to ask someone in more knowledge to fill those in. Cheers -- Martin Klapetek | KDE Developer

Re: Another proposal for modernization of our infrastructure

2015-01-28 Thread Martin Klapetek
is the subject of this proposal. I would be quite interested to hear those experiences and opinions - guys, can you please write something up? Cheers -- Martin Klapetek | KDE Developer

Moving KDE Telepathy to kdenetwork

2015-02-02 Thread Martin Klapetek
ktp-filetransfer-handler ktp-kded-module ktp-send-file ktp-text-ui [2] - https://techbase.kde.org/Policies/Application_Lifecycle *) ktp-call-ui is not yet ported and will most probably be dropped from the 15.04 release Cheers -- Martin Klapetek | KDE Developer

Re: Moving KDE Telepathy to kdenetwork

2015-02-04 Thread Martin Klapetek
On Wed, Feb 4, 2015 at 1:51 AM, Albert Astals Cid wrote: > El Dimarts, 3 de febrer de 2015, a les 00:49:17, Martin Klapetek va > escriure: > > Hi, > > > > so we decided with KDE Telepathy to join the big guys and become > > part of KDE Applications 15.04. So I'

Re: Moving KDE Telepathy to kdenetwork

2015-02-06 Thread Martin Klapetek
On Thu, Feb 5, 2015 at 10:24 PM, Sune Vuorela wrote: > On 2015-02-02, Martin Klapetek wrote: > > Another part that KDE Telepathy needs is KAccounts and we'd like > > to move that one too, probably to kde-runtime but there seems to be > > some disagreements of

Re: Moving KDE Telepathy to kdenetwork

2015-02-06 Thread Martin Klapetek
On Thu, Feb 5, 2015 at 11:33 PM, Albert Astals Cid wrote: > El Dijous, 5 de febrer de 2015, a les 21:24:10, Sune Vuorela va escriure: > > On 2015-02-02, Martin Klapetek wrote: > > > Another part that KDE Telepathy needs is KAccounts and we'd like > > > to mo

Re: Moving KDE Telepathy to kdenetwork

2015-02-06 Thread Martin Klapetek
mpathy for audio/video calls, for example). Cheers -- Martin Klapetek | KDE Developer

Re: Moving KDE Telepathy to kdenetwork

2015-02-08 Thread Martin Klapetek
On Sat, Feb 7, 2015 at 5:04 PM, Albert Astals Cid wrote: > > Speaking of releases, you guys understand you'll be in a bigger release > schedule and will have to follow its rules, right? > Yes, obviously. Cheers -- Martin Klapetek | KDE Developer

Re: Applications/libraries that want to be in KDE Applications 15.04

2015-02-17 Thread Martin Klapetek
095618592&w=2 > * KDE Telepathy to kdenetwork >http://lists.kde.org/?l=kde-core-devel&m=142292100526542&w=2 And also KAccounts (kaccounts-integration, kaccounts-providers, signon-kwallet-extension) to kdenetwork. Cheers -- Martin Klapetek | KDE Developer

Re: Moving KDE Telepathy to kdenetwork

2015-02-19 Thread Martin Klapetek
(we should also keep this on kde-core-devel) On Fri, Feb 20, 2015 at 1:49 AM, Scott Lerman wrote: > > On Thu, Feb 19, 2015 at 5:49 PM, Martin Klapetek < > martin.klape...@gmail.com> wrote: > >> Hey, >> >> As was said in the main thread already, KDE Telepa

Re: Moving KDE Telepathy to kdenetwork

2015-02-24 Thread Martin Klapetek
On Mon, Feb 23, 2015 at 11:29 PM, Albert Astals Cid wrote: > El Dilluns, 23 de febrer de 2015, a les 17:31:47, Martin Klapetek va > escriure: > > Follow up: as there were no objections, I've just requested a move of > these > > repos: > > Can you please g

Re: Moving KDE Telepathy to kdenetwork

2015-02-24 Thread Martin Klapetek
ck > building > > on jenkins (which I was told to wait for jenkins revamping, I'm not sure > > what's the > > state of that though). > > Well let's have the build in even if it's red, as a reminder that stuff > needs > fixing. > Ok. Cheers -- Martin Klapetek | KDE Developer

Re: KDE Telepathy has an unreleased dependency

2015-02-25 Thread Martin Klapetek
On Wed, Feb 25, 2015 at 9:15 AM, David Faure wrote: > On Wednesday 25 February 2015 02:04:58 Albert Astals Cid wrote: > > El Dimarts, 24 de febrer de 2015, a les 11:52:55, Martin Klapetek va > escriure: > > > I just realized that one of the main dependencies, KPeople, will b

Re: KDE Telepathy has an unreleased dependency

2015-02-25 Thread Martin Klapetek
issue > keeps > popping up. > > If you want a short term solution, I'd say the plugin should stay in > playground somewhere. > I don't like the optional dependency thing because it will still show up in > dependency diagrams, making a mess with baloo being in the mid

Re: KDE Telepathy has an unreleased dependency

2015-02-26 Thread Martin Klapetek
On Thu, Feb 26, 2015 at 4:22 PM, Vishesh Handa wrote: > > On Wed, Feb 25, 2015 at 6:39 PM, Martin Klapetek < > martin.klape...@gmail.com> wrote: > >> As I said it's not even being used right now, so imho would be fine if it >> got >> removed/disabled al

Re: KDE Telepathy has an unreleased dependency

2015-02-27 Thread Martin Klapetek
the release (and mind you that the number of KTp developers pretty much reduced to one). I'm sorry that nobody caught this in the review period for about a month. We're clearly all just people with just enough free time. If you feel like it should not be part of KDE Apps 15.04, fine, just s

Re: Help please with some builds in the new jenkins-ci for KDE Cont..

2015-04-09 Thread Martin Klapetek
On Apr 9, 2015 6:31 AM, wrote: > > On Thursday, April 09, 2015 12:54:40 AM Martin Klapetek wrote: > > Hey, > > > > On Wed, Apr 8, 2015 at 10:08 PM, Scarlett Clark > wrote: > > > Hello all, > > > I am to the point now with my ci that I just need help

Re: Help please with some builds in the new jenkins-ci for KDE Cont..

2015-04-08 Thread Martin Klapetek
s-integration and given the current status of KF5 Akonadi (unreleased with no plans), I would just not bother with trying fix this particular issue. Cheers -- Martin Klapetek | KDE Developer

Re: The Future or KDE PIM Releases

2015-04-13 Thread Martin Klapetek
use for having a resource for it. The only useful bit I see is to have the posts synced but there's no app that would take advantage of that data so even that has no real use... Cheers -- Martin Klapetek | KDE Developer

Re: KF5-QT5 branchgroup - jobs that need developeer attention

2015-04-15 Thread Martin Klapetek
It's trying to build branch frameworks, which should not happen, everything for ktp* is in master. Where does it get the branch info from? Cheers -- Martin Klapetek | KDE Developer

Re: KF5-QT5 branchgroup - jobs that need developeer attention

2015-04-15 Thread Martin Klapetek
On Wed, Apr 15, 2015 at 12:02 PM, Ben Cooksley wrote: > On Wed, Apr 15, 2015 at 9:58 PM, Martin Klapetek > wrote: > > On Wed, Apr 15, 2015 at 9:44 AM, Scarlett Clark > wrote: > >> > >> Here is a list of mostly compile failures and other tid bits that need

Re: branchGroup stable-qt4 Compile failures. Need dev assistance please.

2015-04-21 Thread Martin Klapetek
emoved it from kde-build-metadata, please discard this job. Cheers -- Martin Klapetek | KDE Developer

Re: KDE Applications Versioning

2015-06-09 Thread Martin Klapetek
15.08 or..?"). So I for one would also welcome such feature, but can absolutely relate to David's position too; the versioning should not be forced on Applications. So this could be easily made opt-in by using some predefined CMake variable and projects having such var would get the versio

PSA: KDE Telepathy master now must have new plugin installed

2015-06-10 Thread Martin Klapetek
2/telepathy-accounts-signon Cheers -- Martin Klapetek | KDE Developer

Re: KDE Applications Versioning

2015-07-08 Thread Martin Klapetek
As the KDE Apps release is getting near, is this being considered/deployed? Should we be setting some CMake variables? Cheers -- Martin Klapetek | KDE Developer

Re: KDE Applications Versioning

2015-07-08 Thread Martin Klapetek
On Wed, Jul 8, 2015 at 1:24 PM, Aleix Pol wrote: > On Wed, Jul 8, 2015 at 11:43 AM, Martin Klapetek > wrote: > > As the KDE Apps release is getting near, is this being > considered/deployed? > > Should we be setting some CMake variables? > > > > Cheers > >

Re: [Development] Please help me get my pending review count down

2015-07-29 Thread Martin Klapetek
Can you perhaps create a single diff against 5.5/dev/master which could be easily applied? That should make things much easier to help :) Cheers -- Martin Klapetek | KDE Developer

Re: [Development] Please help me get my pending review count down

2015-07-29 Thread Martin Klapetek
On Wed, Jul 29, 2015 at 11:47 AM, Marc Mutz wrote: > On Wednesday 29 July 2015 09:04:42 Martin Klapetek wrote: > > Can you perhaps create a single diff against 5.5/dev/master > > which could be easily applied? That should make things > > much easier to help :) > > As

Re: RFC: KDE Bugzilla Bugs Expiration

2015-07-31 Thread Martin Klapetek
> Then this script could ignore the tagged ones. > Yeah, this would be great. > Comments? Strong objections? ;) > Personally I prefer the Dan's version with the EOL, but in general +1 to the idea. Cheers -- Martin Klapetek | KDE Developer

Re: Notes from the Phabricator BoF

2015-07-31 Thread Martin Klapetek
s clear to which project/repo it belongs. Cheers -- Martin Klapetek | KDE Developer

Re: Replacement for KDateTime

2015-08-02 Thread Martin Klapetek
be worth bringing KLocale back in some limited form as an intermediate solution? Alternatively, do you John have any roadmap about QLocale? Perhaps we could help with filling the missing bits into QLocale directly too. Cheers -- Martin Klapetek | KDE Developer

Re: Replacement for KDateTime

2015-08-02 Thread Martin Klapetek
function which would add/remove the "ap"/"AP" strings for the clock. I imagine. > > Alternatively, do you John have any roadmap about QLocale? Perhaps > > we could help with filling the missing bits into QLocale directly too. > > The roadmap currently stands as follows: > > Does this mean there is no roadmap? :) Cheers -- Martin Klapetek | KDE Developer

Re: Replacement for KDateTime

2015-08-03 Thread Martin Klapetek
On Mon, Aug 3, 2015 at 6:34 PM, Thiago Macieira wrote: > On Monday 03 August 2015 08:33:54 Martin Klapetek wrote: > > > If the format you're looking for requires support from translators, > please > > > add > > > a new class to QtCore. > > > >

Re: Plasma Applet for Audio Volume for kdereview

2015-08-06 Thread Martin Klapetek
datory? > > It is still not working for me in all cases (stuttering sound with > PlaneShift > OpenAL sound output as one of the last issues) and am I happy that Plasma 5 > and KMix still work without it. > You can still use kmix with Plasma, there is even a port to kf5 though I&#x

Re: Moving KScreenGenie out of Review and replacing KSnapshot

2015-08-24 Thread Martin Klapetek
Team#Module_Coordinators Cheers -- Martin Klapetek | KDE Developer

Re: Review Request 125043: expose the WheelMouseZooms global setting through the input ("mouse") KCM

2015-09-04 Thread Martin Klapetek
> On Sept. 4, 2015, 3:38 p.m., Martin Gräßlin wrote: > > You are aware that this is a dead repo and that this is a new feature for a > > repository that has been feature frozen for years? > > > > Given that I think this should not and never be merged. If you want to keep > > the repo going for

Re: Review Request 125056: Fix build on OS X

2015-09-05 Thread Martin Klapetek
tps://git.reviewboard.kde.org/r/125056/#comment58729> This change is already preceeded with https://git.reviewboard.kde.org/r/124962/ - Martin Klapetek On Sept. 5, 2015, 1:47 a.m., Samuel Gaist wrote: > > --- > This is an automatica

Re: Spectacle moved to KDE Graphics, future of KSnapshot?

2015-09-24 Thread Martin Klapetek
d then inform the xdg list about it, maybe others would join with the idea. Or you can just start with org.kde.screenshot and add it to KSnapshot (tho that would require another release of it). Cheers -- Martin Klapetek | KDE Developer

Re: Spectacle moved to KDE Graphics, future of KSnapshot?

2015-09-25 Thread Martin Klapetek
is there a more > genetic dbus command that I can invoke? > I don't know about khotkeys, but are QDbus* classes not an option? Seems better than depending on qdbus (or any other command for that matter). Cheers -- Martin Klapetek | KDE Developer

Re: Spectacle moved to KDE Graphics, future of KSnapshot?

2015-09-25 Thread Martin Klapetek
k the interface through and then propose it on a correct list (xdg), not on dbus list". Far from disaster :P Cheers -- Martin Klapetek | KDE Developer

Re: Review Request 125452: This is a patch for KImgIO that handles xcfgz / xcfbz2 (compressed GIMP) images in KDE (read-only).

2015-09-29 Thread Martin Klapetek
new features and is in maintenance mode only. You'd need to port your code to Qt5 and include it in KImageFormats framework to get it released. - Martin Klapetek On Sept. 29, 2015, 7:56 p.m., Tudor PRISTAVU wrote: > > --- &

Re: Review Request 125539: [kio-mtp] Add file system freespace retrieval to mtp kioslave

2015-10-16 Thread Martin Klapetek
tps://git.reviewboard.kde.org/r/125539/#comment59804> This doesn't seem useful? - Martin Klapetek On Oct. 6, 2015, 9:15 a.m., Emmanuel Pescosta wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://

Re: Review Request 125910: Fix for Bug 334525 - Gwenview hangs when switching from normal to full screen mode

2015-11-03 Thread Martin Klapetek
he previous line. This is not an issue, I'm just explaining why it was at the beginning of the line (or why I think it was) :) - Martin Klapetek On Nov. 1, 2015, 10:50 p.m., Johannes Stefan wrote: > > --- > This is an

Re: Please review Snorenotify (Finish Incubating)

2015-11-20 Thread Martin Klapetek
s because it's leaner and > more straightforward to our notifications use-case. Can you be more specific? Could help improving KNotification for other users, perhaps. Cheers -- Martin Klapetek | KDE Developer

Re: Move ktp-call-ui to kdenetwork

2015-12-14 Thread Martin Klapetek
hat's what beta releases are for. We could however release it say a month before KDE Apps 16.04 beta to give it more testing time, call it an alpha release. Cheers -- Martin Klapetek | KDE Developer

Re: Move ktp-call-ui to kdenetwork

2015-12-28 Thread Martin Klapetek
that it must have an active maintainer. Which it now has. Cheers -- Martin Klapetek | KDE Developer

Re: Review Request 125910: Fix for Bug 334525 - Gwenview hangs when switching from normal to full screen mode

2015-12-30 Thread Martin Klapetek
o reply, visit: > https://git.reviewboard.kde.org/r/125910/ > --- > > (Updated Dec. 29, 2015, 9:54 p.m.) > > > Review request for kdelibs and Martin Klapetek. > > > Bugs: 334525 > http://bugs.kd

Re: Review Request 125910: Fix for Bug 334525 - Gwenview hangs when switching from normal to full screen mode

2015-12-30 Thread Martin Klapetek
; https://git.reviewboard.kde.org/r/125910/ > --- > > (Updated Dec. 29, 2015, 9:54 p.m.) > > > Review request for kdelibs and Martin Klapetek. > > > Bugs: 334525 > http://bugs.kde.org/show_bug.cgi?id=334525 > > > Repository: kdelibs > &

Re: Review Request 125910: Fix for Bug 334525 - Gwenview hangs when switching from normal to full screen mode

2015-12-30 Thread Martin Klapetek
o reply, visit: > https://git.reviewboard.kde.org/r/125910/ > --- > > (Updated Dec. 29, 2015, 9:54 p.m.) > > > Review request for kdelibs and Martin Klapetek. > > > Bugs: 334525 > http://bugs.kde.org/show_bug.cgi?id=3

Re: Review Request 125910: Fix for Bug 334525 - Gwenview hangs when switching from normal to full screen mode

2015-12-30 Thread Martin Klapetek
> On Dec. 30, 2015, 3:48 p.m., Luigi Toscano wrote: > > For the record: this was submitted to the knotifications frameworks, not to > > kdelibs. > > Martin Klapetek wrote: > Yes, sorry, I wrote it as a message here but now I see that it didn't get > through

Re: Review Request 125910: Fix for Bug 334525 - Gwenview hangs when switching from normal to full screen mode

2015-12-30 Thread Martin Klapetek
e do this in Battery > > Monitor), so it should be a translatable proper string. > > Martin Klapetek wrote: > Is there a value for "no reason" that will not print any reason? > > Kai Uwe Broulik wrote: > No. This would defy the whole point of having

Re: Review Request 126627: Replace screensaver inhibition by direct dbus calls

2016-01-04 Thread Martin Klapetek
Testing --- PowerDevil correctly shows that Gwenview is inhibitting the PM because "Full Screen Presentation". Thanks, Martin Klapetek

Re: Review Request 126627: Replace screensaver inhibition by direct dbus calls

2016-01-04 Thread Martin Klapetek
iewboard.kde.org/r/126627/#review90590 --- On Jan. 4, 2016, 9:07 p.m., Martin Klapetek wrote: > > --- > This is an automatically generated e-mail. To reply, vi

PSA: KAccounts now requires two env vars set

2016-01-18 Thread Martin Klapetek
will affect the Applications 16.04 release. [1] - https://bugs.kde.org/show_bug.cgi?id=347219 Cheers -- Martin Klapetek | KDE Developer

Re: PSA: KAccounts now requires two env vars set

2016-01-20 Thread Martin Klapetek
on't need to bother packagers to figure out how to make it > work. > Yeah, that could be done. I'll have a look. Cheers -- Martin Klapetek | KDE Developer

Re: Review Request 127102: Use fixed width for digital clock applet

2016-02-18 Thread Martin Klapetek
> On Feb. 18, 2016, 1:05 a.m., David Edmundson wrote: > > applets/digital-clock/package/contents/ui/DigitalClock.qml, line 555 > > > > > > rather than looping, can we use FontMetric's maximumCharacterWidth > >

Re: Review Request 127102: Use fixed width for digital clock applet

2016-02-18 Thread Martin Klapetek
r all fonts, this loop really > needs to go > > Daniel Faust wrote: > As far as I understand maximumCharacterWidth returns the width of the > widest character of the font - which can be ridiculously wide given that the > font supports some wild unicode characters. >

Re: [Kde-pim] PIM dependency metadata

2016-02-29 Thread Martin Klapetek
. > > How are non-plasma users supposed to get correct timezones in e.g. PIM > apps otherwise? > Note that this daemon is used these days only to signal a timezone change iirc, you can get current/any timezone by using QTimeZone. Cheers -- Martin Klapetek | KDE Developer

Re: Google Summer of Code 2016 - C# bindings for Qt

2016-03-05 Thread Martin Klapetek
is > mandatory for this proposal. > While I cannot really co-mentor on the technical level for lack of knowledge of C#, I'm happy to be the KDE "guide-mentor" for this task if nobody with better knowledge of C# steps up. Cheers -- Martin Klapetek | KDE Developer

Re: remove khelpcenter from next Plasma release?

2016-03-09 Thread Martin Klapetek
ng to maintain the code as part of plasma-the-code while Yuri probably thought this is about removing it from plasma-the-shell, ie. from kicker/kickoff etc. Cheers -- Martin Klapetek | KDE Developer

Re: Review Request 127102: Use fixed width for digital clock applet

2016-03-15 Thread Martin Klapetek
;A" and "P" width's and use that? Would spare creating two Date objects and two calls to Qt.formatTime - Martin Klapetek On March 8, 2016, 6:53 p.m., Daniel Faust wrote: > > --- > This is an automatically generated

Re: Review Request 127102: Use fixed width for digital clock applet

2016-03-15 Thread Martin Klapetek
> On March 15, 2016, 5:48 p.m., Martin Klapetek wrote: > > I've tested it extensively and it works great. Thanks a lot! > > > > There's one more issue - http://paste.opensuse.org/view/raw/f8ba5d0d - the > > same font size should also be applied to the

Re: Review Request 127393: digital-clock: Fix font size of date label in small panels

2016-03-18 Thread Martin Klapetek
> On March 16, 2016, 9:31 p.m., Martin Klapetek wrote: > > applets/digital-clock/package/contents/ui/DigitalClock.qml, lines 382-383 > > <https://git.reviewboard.kde.org/r/127393/diff/1/?file=453347#file453347line382> > > > > You can't set both, it will

Re: Review Request 127393: digital-clock: Fix font size of date label in small panels

2016-03-18 Thread Martin Klapetek
ets/digital-clock/package/contents/ui/DigitalClock.qml (line 400) <https://git.reviewboard.kde.org/r/127393/#comment63839> Have you tried dateLabelLeft.paintedHeight? - Martin Klapetek On March 16, 2016, 4:53 p.m., Daniel Fa

Re: Review Request 127393: digital-clock: Fix font size of date label in small panels

2016-03-19 Thread Martin Klapetek
> On March 16, 2016, 6:19 p.m., Martin Klapetek wrote: > > applets/digital-clock/package/contents/ui/DigitalClock.qml, line 400 > > <https://git.reviewboard.kde.org/r/127393/diff/1/?file=453347#file453347line400> > > > > Have you tried dateLabelLeft.paint

Re: Review Request 127393: digital-clock: Fix font size of date label in small panels

2016-03-19 Thread Martin Klapetek
> On March 16, 2016, 6:19 p.m., Martin Klapetek wrote: > > applets/digital-clock/package/contents/ui/DigitalClock.qml, line 400 > > <https://git.reviewboard.kde.org/r/127393/diff/1/?file=453347#file453347line400> > > > > Have you tried dateLabelLeft.paint

Re: Review Request 127102: Use fixed width for digital clock applet

2016-03-19 Thread Martin Klapetek
> On March 15, 2016, 5:48 p.m., Martin Klapetek wrote: > > applets/digital-clock/package/contents/ui/DigitalClock.qml, lines 565-568 > > <https://git.reviewboard.kde.org/r/127102/diff/3/?file=448492#file448492line565> > > > > Can't we just compare &

Re: Review Request 127393: digital-clock: Fix font size of date label in small panels

2016-03-19 Thread Martin Klapetek
> On March 16, 2016, 6:19 p.m., Martin Klapetek wrote: > > applets/digital-clock/package/contents/ui/DigitalClock.qml, line 400 > > <https://git.reviewboard.kde.org/r/127393/diff/1/?file=453347#file453347line400> > > > > Have you tried dateLabelLeft.paint

Re: Review Request 127393: digital-clock: Fix font size of date label in small panels

2016-03-19 Thread Martin Klapetek
gnored Also leave this in the font { } format please - Martin Klapetek On March 16, 2016, 4:53 p.m., Daniel Faust wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > ht

Re: Review Request 127102: Use fixed width for digital clock applet

2016-03-20 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127102/#review93603 --- Ship it! Ship It! - Martin Klapetek On March 16, 2016

Re: Review Request 127393: digital-clock: Fix font size of date label in small panels

2016-03-21 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127393/#review93821 --- Ship it! Thanks! - Martin Klapetek On March 19, 2016

Re: [Kde-pim] Qt 4 Builds

2016-03-27 Thread Martin Klapetek
ding the log upstream I see qt4 is not supported now. > KTp is Qt5-only for quite some time now. There is nothing needing libaccounts-qt4 afaik. Cheers -- Martin Klapetek | KDE Developer

Re: Review Request 129644: i10n: update Czech Republic to Czechia

2016-12-12 Thread Martin Klapetek
rence I guess and so I won't block this if anyone gives it a Ship It. - Martin Klapetek On Dec. 13, 2016, 12:36 a.m., Jiri Bohac wrote: > > --- > This is an automatically generated e-m

Re: Taking over maintainership of the kaccounts-* repos

2019-09-15 Thread Martin Klapetek
is, let me know. > Yes please, go ahead! Cheers -- Martin Klapetek

Re: Acquiring Google Mock libraries for tests

2013-10-03 Thread Martin Klapetek
corner of it) and recently KDE Frameworks and couple others) use Google Mock. I, for one, also never heard of it before. Cheers -- Martin Klapetek | KDE Developer

Re: Review Request 113189: lower (a lot) warning noise caused by undefined macros

2013-10-10 Thread Martin Klapetek
https://git.reviewboard.kde.org/r/113173/diff/ I'm not sure if the frameworks branch is still being merged to master or not, but you might want to just cherry-pick that. - Martin Klapetek On Oct. 10, 2013, 10:52 a.m., Jiří Pinkava

Re: Review Request 113260: Port KTimeZoned to Qt5/KF5

2013-10-15 Thread Martin Klapetek
ktimezoned/ktimezonedbase.h ca00aca ktimezoned/org.kde.KTimeZoned.xml daaa0b7 Diff: http://git.reviewboard.kde.org/r/113260/diff/ Testing --- Tested by changing the timezone in different ways, change was detected and signalled out. Thanks, Martin Klapetek

Review Request 113260: Port KTimeZoned to Qt5/KF5

2013-10-15 Thread Martin Klapetek
21cc ktimezoned/ktimezoned_win.cpp cadfe3a ktimezoned/ktimezonedbase.h ca00aca ktimezoned/org.kde.KTimeZoned.xml daaa0b7 Diff: http://git.reviewboard.kde.org/r/113260/diff/ Testing --- Tested by changing the timezone in different ways, change was detected and signalled out. Thanks, Martin Klapetek

Re: Review Request 113298: KDirWatch code style: cleanup whitespace.

2013-10-17 Thread Martin Klapetek
oard.kde.org/r/113298/#comment30557> Pointer signs to the variable -> KDirWatch *instance etc tier1/kcoreaddons/src/lib/io/kdirwatch.cpp <http://git.reviewboard.kde.org/r/113298/#comment30558> Should be at the "if" line, eg. "if () {" tier1/kcoreaddons/

Re: Review Request 113298: KDirWatch code style: cleanup whitespace.

2013-10-17 Thread Martin Klapetek
rwatch_p.h <http://git.reviewboard.kde.org/r/113298/#comment30578> why did you choose "_path" instead of just "path"? - Martin Klapetek On Oct. 17, 2013, 7:05 p.m., Nicolás Alvarez wrote: > > --- >

Re: Review Request 113298: KDirWatch code style: cleanup whitespace.

2013-10-17 Thread Martin Klapetek
> On Oct. 17, 2013, 7:27 p.m., Martin Klapetek wrote: > > tier1/kcoreaddons/src/lib/io/kdirwatch_p.h, line 199 > > <http://git.reviewboard.kde.org/r/113298/diff/3/?file=202349#file202349line199> > > > > why did you choose "_path" instead

Re: Review Request 113260: Port KTimeZoned to Qt5/KF5

2013-10-17 Thread Martin Klapetek
t, so we could use non-qt/-kde apps still supporting timezone changes, but oh well). [1] - http://qt-project.org/doc/qt-5.1/qtdoc/supported-platforms.html [2] - http://qt.digia.com/Product/Supported-Platforms/ - Martin --- This is

Re: Review Request 113260: Port KTimeZoned to Qt5/KF5

2013-10-17 Thread Martin Klapetek
hanging the timezone in different ways, change was detected and signalled out. Thanks, Martin Klapetek

Re: Review Request 113260: Port KTimeZoned to Qt5/KF5

2013-10-18 Thread Martin Klapetek
bafc85e ktimezoned/ktimezoned_win.h 26e21cc ktimezoned/ktimezoned_win.cpp cadfe3a ktimezoned/ktimezonedbase.h ca00aca ktimezoned/org.kde.KTimeZoned.xml daaa0b7 Diff: http://git.reviewboard.kde.org/r/113260/diff/ Testing --- Tested by changing the timezone in different ways, change was detected and signalled out. Thanks, Martin Klapetek

Re: Review Request 113260: Port KTimeZoned to Qt5/KF5

2013-10-21 Thread Martin Klapetek
t; signal from "configChanged" to your new "timeZoneChanged" signal. > > > > With regards the signal name change, does it need to go in the porting > > guide or somewhere so people know it has changed? > > > > In Qt 5.3 I will try adding a QEvent for

Re: Review Request 113260: Port KTimeZoned to Qt5/KF5

2013-10-22 Thread Martin Klapetek
e in different ways, change was detected and signalled out. Thanks, Martin Klapetek

Review Request 113415: Port KSplashQML to Qt5 + remove XLib stuff + replace x11eventFilter with DBus interface (Wayland++)

2013-10-24 Thread Martin Klapetek
sting --- Theme successfully loads, displays fullscreen (Plasma panels are not covered, not sure why), all stages passes, then it terminates itself. Thanks, Martin Klapetek

Re: Review Request 113415: Port KSplashQML to Qt5 + remove XLib stuff + replace x11eventFilter with DBus interface (Wayland++)

2013-10-24 Thread Martin Klapetek
ksplashqml/themes/Minimalistic/main.qml e4fb8b8 Diff: http://git.reviewboard.kde.org/r/113415/diff/ Testing --- Theme successfully loads, displays fullscreen (Plasma panels are not covered, not sure why), all stages passes, then it terminates itself. Thanks, Martin Klapetek

Review Request 113419: Remove the upper-half white gradient from KSplash Minimalistic theme

2013-10-24 Thread Martin Klapetek
hanks, Martin Klapetek

Re: Review Request 113419: Remove the upper-half white gradient from KSplash Minimalistic theme

2013-10-24 Thread Martin Klapetek
- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113419/#review42286 --- On Oct. 24, 2013, 2:32 p.m., Martin Klapetek wrote: > >

Re: Review Request 113419: Remove the upper-half white gradient from KSplash Minimalistic theme

2013-10-24 Thread Martin Klapetek
http://git.reviewboard.kde.org/media/uploaded/files/2013/10/24/d494e4b4-6e13-4ee8-934c-6ff7ac21bc33__ksp_new.png Thanks, Martin Klapetek

Re: Review Request 113415: Port KSplashQML to Qt5 + remove XLib stuff + replace x11eventFilter with DBus interface (Wayland++)

2013-10-24 Thread Martin Klapetek
http://git.reviewboard.kde.org/r/113415/#review42299 --- On Oct. 24, 2013, 2:19 p.m., Martin Klapetek wrote: > > --- > This is an automatically generated e-mail. To reply

Re: Review Request 113413: Improved Keyboard Layout Preview

2013-10-25 Thread Martin Klapetek
;) (Update -> Add File) - Martin Klapetek On Oct. 24, 2013, 8:51 p.m., shivam makkar wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.k

Re: KF5 Update Meeting Minutes 2013-w44

2013-10-29 Thread Martin Klapetek
On Tue, Oct 29, 2013 at 4:59 PM, Kevin Ottens wrote: * dfaure is making progress toward killing libkio; > * he's waiting on mck182 to deal with KImageIO; > That's probably not me, I've not been doing anything around KImageIO :) Cheers -- Martin Klapetek | KDE Developer

Re: Review Request 113260: Port KTimeZoned to Qt5/KF5

2013-10-31 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113260/#review42743 --- Ping, this seems forgotten :) - Martin Klapetek On Oct. 22

Review Request 113533: Adapt KCMInit to use DBus to communicate with KSplash

2013-11-01 Thread Martin Klapetek
/ Testing --- KCMInit is still disabled for building, not much to test yet, but it works elsewhere, no reason to not work here. Thanks, Martin Klapetek

Review Request 113534: Adapt ksmserver to use DBus to communicate with KSplash

2013-11-01 Thread Martin Klapetek
much to test yet, but it works elsewhere, no reason to not work here. Thanks, Martin Klapetek

Re: Review Request 113534: Adapt ksmserver to use DBus to communicate with KSplash

2013-11-04 Thread Martin Klapetek
://git.reviewboard.kde.org/r/113534/diff/ Testing --- Ksmserver is still disabled for building, not much to test yet, but it works elsewhere, no reason to not work here. Thanks, Martin Klapetek

Re: Review Request 113533: Adapt KCMInit to use DBus to communicate with KSplash

2013-11-04 Thread Martin Klapetek
). Diffs - kcminit/main.cpp 856d8b7 Diff: http://git.reviewboard.kde.org/r/113533/diff/ Testing --- KCMInit is still disabled for building, not much to test yet, but it works elsewhere, no reason to not work here. Thanks, Martin Klapetek

Re: Review Request 113260: Port KTimeZoned to Qt5/KF5

2013-11-04 Thread Martin Klapetek
ldn't push it (only) to the smallest component in the workspace, it makes no sense at this time. - Martin --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113260/#review42961

  1   2   3   >