[valgrind] [Bug 399355] Add callgrind_diff

2019-04-11 Thread Philippe Waroquiers
https://bugs.kde.org/show_bug.cgi?id=399355 --- Comment #14 from Philippe Waroquiers --- Note that at work, I am busy discussing to have someone working on this bug. So, some progress might happen in the coming weeks (but not for 3.15). -- You are receiving this mail because: You are watching a

[valgrind] [Bug 399355] Add callgrind_diff

2019-03-11 Thread Nick Nethercote
https://bugs.kde.org/show_bug.cgi?id=399355 --- Comment #13 from Nick Nethercote --- I haven't looked into the problems reported in comment 6. I don't see why this shouldn't be able to work, but the Callgrind format does have a lot of bells and whistles that the Cachegrind format does not, so the

[valgrind] [Bug 399355] Add callgrind_diff

2019-03-09 Thread Julian Seward
https://bugs.kde.org/show_bug.cgi?id=399355 --- Comment #12 from Julian Seward --- Nick, what's the situation here? Is it possible to make this work well enough to be worth landing? -- You are receiving this mail because: You are watching all bug changes.

[valgrind] [Bug 399355] Add callgrind_diff

2018-10-27 Thread Philippe Waroquiers
https://bugs.kde.org/show_bug.cgi?id=399355 Bug 399355 depends on bug 399301, which changed state. Bug 399301 Summary: Use inlined frames in Massif XTree output. https://bugs.kde.org/show_bug.cgi?id=399301 What|Removed |Added

[valgrind] [Bug 399355] Add callgrind_diff

2018-10-20 Thread Philippe Waroquiers
https://bugs.kde.org/show_bug.cgi?id=399355 --- Comment #11 from Philippe Waroquiers --- When building, I also see the below error: ./callgrind/Makefile.am:1: error: docs/callgrind_diff-manpage.xml is in EXTRA_DIST but doesn't exist -- You are receiving this mail because: You are watching all

[valgrind] [Bug 399355] Add callgrind_diff

2018-10-20 Thread Philippe Waroquiers
https://bugs.kde.org/show_bug.cgi?id=399355 --- Comment #10 from Philippe Waroquiers --- (In reply to Philippe Waroquiers from comment #6) > Brainstorm idea: if ever the callgrind format allows it, it would be nice > to have a 'delta call' output also, i.e. have for each > 'call A to B' in eac

[valgrind] [Bug 399355] Add callgrind_diff

2018-10-20 Thread Philippe Waroquiers
https://bugs.kde.org/show_bug.cgi?id=399355 --- Comment #9 from Philippe Waroquiers --- Created attachment 115775 --> https://bugs.kde.org/attachment.cgi?id=115775&action=edit Second big callgrind file -- You are receiving this mail because: You are watching all bug changes.

[valgrind] [Bug 399355] Add callgrind_diff

2018-10-20 Thread Philippe Waroquiers
https://bugs.kde.org/show_bug.cgi?id=399355 --- Comment #8 from Philippe Waroquiers --- Created attachment 115774 --> https://bugs.kde.org/attachment.cgi?id=115774&action=edit First big callgrind file -- You are receiving this mail because: You are watching all bug changes.

[valgrind] [Bug 399355] Add callgrind_diff

2018-10-20 Thread Philippe Waroquiers
https://bugs.kde.org/show_bug.cgi?id=399355 --- Comment #7 from Philippe Waroquiers --- (In reply to Philippe Waroquiers from comment #6) > The alternative is to have callgrind_diff producing a file with twice more > events > than the compared files: for each event (e.g. instruction fetch/syscoun

[valgrind] [Bug 399355] Add callgrind_diff

2018-10-20 Thread Philippe Waroquiers
https://bugs.kde.org/show_bug.cgi?id=399355 --- Comment #6 from Philippe Waroquiers --- (In reply to Nick Nethercote from comment #5) > Created attachment 115743 [details] > Updated version > > This fixes the problem that Philippe identified. Thanks for the fix. Here is some more feedback with b

[valgrind] [Bug 399355] Add callgrind_diff

2018-10-18 Thread Nick Nethercote
https://bugs.kde.org/show_bug.cgi?id=399355 Nick Nethercote changed: What|Removed |Added Attachment #115396|0 |1 is obsolete|

[valgrind] [Bug 399355] Add callgrind_diff

2018-10-12 Thread Nick Nethercote
https://bugs.kde.org/show_bug.cgi?id=399355 Nick Nethercote changed: What|Removed |Added Depends on|399322 | Referenced Bugs: https://bugs.kde.org/show

[valgrind] [Bug 399355] Add callgrind_diff

2018-10-12 Thread Nick Nethercote
https://bugs.kde.org/show_bug.cgi?id=399355 Bug 399355 depends on bug 399322, which changed state. Bug 399322 Summary: Improve callgrind_annotate output https://bugs.kde.org/show_bug.cgi?id=399322 What|Removed |Added -

[valgrind] [Bug 399355] Add callgrind_diff

2018-10-11 Thread Nick Nethercote
https://bugs.kde.org/show_bug.cgi?id=399355 --- Comment #4 from Nick Nethercote --- Thank you for the feedback. I will look at the failures next week. -- You are receiving this mail because: You are watching all bug changes.

[valgrind] [Bug 399355] Add callgrind_diff

2018-10-10 Thread Philippe Waroquiers
https://bugs.kde.org/show_bug.cgi?id=399355 Philippe Waroquiers changed: What|Removed |Added CC||philippe.waroquiers@skynet.

[valgrind] [Bug 399355] Add callgrind_diff

2018-10-09 Thread Nick Nethercote
https://bugs.kde.org/show_bug.cgi?id=399355 --- Comment #2 from Nick Nethercote --- Is it really worth splitting the patch? I guess you could put the threshold changes in one patch and everything else in another, but it doesn't seem worth the effort. I did the original threshold changes in Cache

[valgrind] [Bug 399355] Add callgrind_diff

2018-10-04 Thread Josef Weidendorfer
https://bugs.kde.org/show_bug.cgi?id=399355 --- Comment #1 from Josef Weidendorfer --- On a first look, this patch looks fine. I would split the unrelated parts into separate commits (I can do that). -- You are receiving this mail because: You are watching all bug changes.