https://bugs.kde.org/show_bug.cgi?id=370028
Ivo Raisr changed:
What|Removed |Added
Status|ASSIGNED|RESOLVED
Resolution|---
https://bugs.kde.org/show_bug.cgi?id=370028
--- Comment #44 from Ivo Raisr ---
(In reply to Tamara Vlahovic from comment #43)
Thank you for the patch.
Committed in VEX SVN as r3372.
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.kde.org/show_bug.cgi?id=370028
Tamara Vlahovic changed:
What|Removed |Added
Attachment #105474|0 |1
is obsolete|
https://bugs.kde.org/show_bug.cgi?id=370028
--- Comment #42 from Ivo Raisr ---
(In reply to Tamara Vlahovic from comment #41)
Indeed, thank you for spotting it. I think it was caused by a mismerge from
TileGX port removal.
Commited as SVN r16377.
--
You are receiving this mail because:
You are
https://bugs.kde.org/show_bug.cgi?id=370028
--- Comment #41 from Tamara Vlahovic ---
Created attachment 105554
--> https://bugs.kde.org/attachment.cgi?id=105554&action=edit
Patch 2/4 fix
I noticed today that my update of a Patch 2/4 have a mistake that causes build
to crash on 64BE architectur
https://bugs.kde.org/show_bug.cgi?id=370028
--- Comment #40 from Ivo Raisr ---
(In reply to Tamara Vlahovic from comment #38)
I've had a look at patch for x87 stuff. While passing Fpu_State* instead of
UChar* is a good idea, on the other hand changing UChar[80] to UShort[40] is
not a very good i
https://bugs.kde.org/show_bug.cgi?id=370028
--- Comment #39 from Ivo Raisr ---
(In reply to Tamara Vlahovic from comment #37)
Committed in Valgrind SVN as r16368.
Thank you for the patch.
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.kde.org/show_bug.cgi?id=370028
--- Comment #38 from Tamara Vlahovic ---
Created attachment 105474
--> https://bugs.kde.org/attachment.cgi?id=105474&action=edit
Patch for warnings related to x87
This patch fixes "cast-align" warnings related to getting and putting x87 guest
state a
https://bugs.kde.org/show_bug.cgi?id=370028
--- Comment #37 from Tamara Vlahovic ---
Created attachment 105467
--> https://bugs.kde.org/attachment.cgi?id=105467&action=edit
Patch for m_mallocfree.c
This patch fixes "cast-align" warnings in coregind/m_mallocfree.c, using
ASSUME_ALIGNED macro.
https://bugs.kde.org/show_bug.cgi?id=370028
--- Comment #36 from Ivo Raisr ---
(In reply to Tamara Vlahovic from comment #35)
Committed in Valgrind SVN as r16365.
Nice approach, thank you for the patch.
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.kde.org/show_bug.cgi?id=370028
--- Comment #35 from Tamara Vlahovic ---
Created attachment 105439
--> https://bugs.kde.org/attachment.cgi?id=105439&action=edit
Patch 2/4 updated
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.kde.org/show_bug.cgi?id=370028
--- Comment #34 from Ivo Raisr ---
I am afraid I don't see how the latest patch for syswrap-generic.c improves the
situation. On sparc64/Linux, I see the following warnings (line numbers are
approximate but you get the idea):
m_syswrap/syswrap-generic.
https://bugs.kde.org/show_bug.cgi?id=370028
Aleksandar Rikalo changed:
What|Removed |Added
Attachment #101431|0 |1
is obsolete|
https://bugs.kde.org/show_bug.cgi?id=370028
--- Comment #32 from Aleksandar Rikalo ---
(In reply to Ivo Raisr from comment #31)
> Another patch committed in SVN r16348.
Thank You! Please take a look at Tamara's patch for mc_main.c.
--
You are receiving this mail because:
You are watching all b
https://bugs.kde.org/show_bug.cgi?id=370028
Ivo Raisr changed:
What|Removed |Added
Status|CONFIRMED |ASSIGNED
--- Comment #31 from Ivo Raisr ---
Anothe
https://bugs.kde.org/show_bug.cgi?id=370028
Tamara Vlahovic changed:
What|Removed |Added
CC||tamara.vlaho...@imgtec.com
--- Comment #30 fr
https://bugs.kde.org/show_bug.cgi?id=370028
--- Comment #29 from Ivo Raisr ---
Thank you for another patch.
I've modified it slightly in VG_(memset)() and tested successfully on
sparcv9/Linux.
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.kde.org/show_bug.cgi?id=370028
Ivo Raisr changed:
What|Removed |Added
Attachment #105392|0 |1
is obsolete||
https://bugs.kde.org/show_bug.cgi?id=370028
Aleksandar Rikalo changed:
What|Removed |Added
CC||aleksandar.rik...@imgtec.co
https://bugs.kde.org/show_bug.cgi?id=370028
--- Comment #26 from Ivo Raisr ---
Aleksandar, do you have another patch ready?
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.kde.org/show_bug.cgi?id=370028
--- Comment #25 from Aleksandar Rikalo ---
(In reply to Julian Seward from comment #23)
> What's the status of this now? Can it be closed?
No, it shouldn't. This is just the beginning. I'll prepare next few patches
soon.
Also, there are patches 2 and
https://bugs.kde.org/show_bug.cgi?id=370028
--- Comment #24 from Ivo Raisr ---
Patch 1/4 landed in the repo.
I expect that Aleksandar prepares another patch for review.
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.kde.org/show_bug.cgi?id=370028
Julian Seward changed:
What|Removed |Added
CC||jsew...@acm.org
--- Comment #23 from Julian Sew
https://bugs.kde.org/show_bug.cgi?id=370028
--- Comment #22 from Ivo Raisr ---
Remark by Mark Wielaard:
After the number of compiler warnings caused by -Wcast-align is greatly
reduced, the following configure check for arm32 should be removed from
configure.ac:
if test "X$VGCONF_ARCH_PRI" = "Xar
https://bugs.kde.org/show_bug.cgi?id=370028
--- Comment #21 from Ivo Raisr ---
Patch 1/4 committed in SVN r16256.
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.kde.org/show_bug.cgi?id=370028
Ivo Raisr changed:
What|Removed |Added
Attachment #104189|0 |1
is obsolete||
https://bugs.kde.org/show_bug.cgi?id=370028
--- Comment #19 from Aleksandar Rikalo ---
(In reply to Ivo Raisr from comment #17)
> I was also wondering of the impact on other architectures.
> Please could you conduct a quick test to see how the compiler resolves
> ASSUME_ALIGNED on amd64/ppc, for
https://bugs.kde.org/show_bug.cgi?id=370028
Aleksandar Rikalo changed:
What|Removed |Added
Attachment #101429|0 |1
is obsolete|
https://bugs.kde.org/show_bug.cgi?id=370028
--- Comment #17 from Ivo Raisr ---
I was also wondering of the impact on other architectures.
Please could you conduct a quick test to see how the compiler resolves
ASSUME_ALIGNED on amd64/ppc, for example? And mips/arm for comparison?
Perhaps we will s
https://bugs.kde.org/show_bug.cgi?id=370028
--- Comment #16 from Aleksandar Rikalo ---
Thank You for review.
I agree with changes in comment and also You are right about name.
I vote for ASSUME_ALIGNED, in that case, it is clear that there is a
assumption.
(In reply to Ivo Raisr from comment #15
https://bugs.kde.org/show_bug.cgi?id=370028
Ivo Raisr changed:
What|Removed |Added
Assignee|jsew...@acm.org |iv...@ivosh.net
Status|UNCONFIRMED
https://bugs.kde.org/show_bug.cgi?id=370028
--- Comment #14 from Aleksandar Rikalo ---
Ivo, Julian,
Can we do something about this? It would be nice if we could define the
strategy and start to eliminate false warnings. Please take a look on Patch
1/4, if proposed concept is acceptable to you, I
https://bugs.kde.org/show_bug.cgi?id=370028
--- Comment #13 from Aleksandar Rikalo ---
(In reply to Julian Seward from comment #9)
> This feels to me like hiding misalignment problems. I'd prefer to remove
> misaligned
> accesses where possible. Building with --enable-usban at least makes it
>
https://bugs.kde.org/show_bug.cgi?id=370028
Petar Jovanovic changed:
What|Removed |Added
Attachment #102817|0 |1
is obsolete|
https://bugs.kde.org/show_bug.cgi?id=370028
--- Comment #12 from Petar Jovanovic ---
(In reply to Aleksandar Rikalo from comment #11)
> It wouldn't work - (*fpu)[n] are doubles, but arch->vex.guest_f##n are
> ULongs. In this case we need raw memory move, without long2double
> conversions.
Yes, y
https://bugs.kde.org/show_bug.cgi?id=370028
--- Comment #11 from Aleksandar Rikalo ---
> Can we simplify the patch #4 just to
> # define DO(n) (*fpu)[n] = arch->vex.guest_f##n
> ?
> Would that work? (Check the attached patch.)
Hi Petar,
It wouldn't work - (*fpu)[n] are doubles, but arch->vex
https://bugs.kde.org/show_bug.cgi?id=370028
--- Comment #10 from Petar Jovanovic ---
Created attachment 102817
--> https://bugs.kde.org/attachment.cgi?id=102817&action=edit
remove coredump-elf cast warning
(In reply to Aleksandar Rikalo from comment #4)
> Created attachment 101432 [details]
>
https://bugs.kde.org/show_bug.cgi?id=370028
--- Comment #9 from Julian Seward ---
This feels to me like hiding misalignment problems. I'd prefer to remove
misaligned
accesses where possible. Building with --enable-usban at least makes it
possible
to see, on any platform, where the run-time misa
https://bugs.kde.org/show_bug.cgi?id=370028
Ivo Raisr changed:
What|Removed |Added
CC||iv...@ivosh.net
--- Comment #8 from Ivo Raisr ---
https://bugs.kde.org/show_bug.cgi?id=370028
--- Comment #7 from Aleksandar Rikalo ---
Patch 1/4 (warn01.diff) removes 98 "cast-align" warnings caused by including
vki-linux.h from various sources.
PTR_CAST macro from this patch can be used in future, to avoid "cast-align"
warnings.
Patch 2/4 (wa
https://bugs.kde.org/show_bug.cgi?id=370028
--- Comment #6 from Petar Jovanovic ---
Most of these patches are not MIPS-specific, touch common code and
probably remove warnings on different platforms too.
Can others take a look at these as well?
@Aleksandar
Can you write which patch removes what
https://bugs.kde.org/show_bug.cgi?id=370028
Aleksandar Rikalo changed:
What|Removed |Added
CC||mips3...@gmail.com
--
You are receiving th
https://bugs.kde.org/show_bug.cgi?id=370028
--- Comment #5 from Aleksandar Rikalo ---
I propose these four independent patches that reduce number of warnings by
~50%.
Applying patches:
patch -p1 < warn0x.diff
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.kde.org/show_bug.cgi?id=370028
--- Comment #4 from Aleksandar Rikalo ---
Created attachment 101432
--> https://bugs.kde.org/attachment.cgi?id=101432&action=edit
Patch 4/4
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.kde.org/show_bug.cgi?id=370028
--- Comment #3 from Aleksandar Rikalo ---
Created attachment 101431
--> https://bugs.kde.org/attachment.cgi?id=101431&action=edit
Patch 3/4
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.kde.org/show_bug.cgi?id=370028
--- Comment #1 from Aleksandar Rikalo ---
Created attachment 101429
--> https://bugs.kde.org/attachment.cgi?id=101429&action=edit
Patch 1/4
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.kde.org/show_bug.cgi?id=370028
--- Comment #2 from Aleksandar Rikalo ---
Created attachment 101430
--> https://bugs.kde.org/attachment.cgi?id=101430&action=edit
Patch 2/4
--
You are receiving this mail because:
You are watching all bug changes.
47 matches
Mail list logo
