[krita] [Bug 455386] [win] Render animation use-after-free waiting for ffmpeg

https://bugs.kde.org/show_bug.cgi?id=455386 --- Comment #10 from Eoin O'Neill --- Yeah no worries. :) I agree with you that the whole thing needs a bit of a work -- but for now I think this will have to do since 5.1 is coming soon. I have an interest in taking another crack at the animation expo

[krita] [Bug 455386] [win] Render animation use-after-free waiting for ffmpeg

https://bugs.kde.org/show_bug.cgi?id=455386 --- Comment #9 from Alvin Wong --- > Honestly I think the change may not fix the issue Ah sorry, I do take that back. Your fix does work because it sets the process state and call deleteLater, instead of deleting the pipe reader immediately. Skipping p

[krita] [Bug 455386] [win] Render animation use-after-free waiting for ffmpeg

https://bugs.kde.org/show_bug.cgi?id=455386 --- Comment #8 from Alvin Wong --- Thanks for trying to fix it. Honestly I think the change may not fix the issue -- it seems QProcess::state is set to NotRunning only after QProcess has detected the process has died, so the condition may still be true

[krita] [Bug 455386] [win] Render animation use-after-free waiting for ffmpeg

https://bugs.kde.org/show_bug.cgi?id=455386 --- Comment #7 from Eoin O'Neill --- Alvin, I think I may have solved this issue, but I would like you to test it on Windows to see if the problem persists for you (I don't have a windows test environment atm) and if they do, please reopen the bug. D

[krita] [Bug 455386] [win] Render animation use-after-free waiting for ffmpeg

https://bugs.kde.org/show_bug.cgi?id=455386 Eoin O'Neill changed: What|Removed |Added Resolution|--- |FIXED Status|REPORTED

[krita] [Bug 455386] [win] Render animation use-after-free waiting for ffmpeg

https://bugs.kde.org/show_bug.cgi?id=455386 Eoin O'Neill changed: What|Removed |Added CC||eoinoneill1...@gmail.com --- Comment #5 from Eoi

[krita] [Bug 455386] [win] Render animation use-after-free waiting for ffmpeg

https://bugs.kde.org/show_bug.cgi?id=455386 --- Comment #4 from Alvin Wong --- The root of evil seems to be this QApplication::processEvents() call [1]. This will be called from signals activated inside the blocking QProcess::waitForFinished() call. Inside processEvents(), if the child ffmpeg pro

[krita] [Bug 455386] [win] Render animation use-after-free waiting for ffmpeg

https://bugs.kde.org/show_bug.cgi?id=455386 Alvin Wong changed: What|Removed |Added Attachment #149928|0 |1 is obsolete||

[krita] [Bug 455386] [win] Render animation use-after-free waiting for ffmpeg

https://bugs.kde.org/show_bug.cgi?id=455386 --- Comment #2 from Alvin Wong --- Created attachment 149928 --> https://bugs.kde.org/attachment.cgi?id=149928&action=edit ASAN output Use-after free ASAN output from an ASAN+UBSAN build (mangled names, no line numbers) -- You are receiving this ma

[krita] [Bug 455386] [win] Render animation use-after-free waiting for ffmpeg

https://bugs.kde.org/show_bug.cgi?id=455386 Alvin Wong changed: What|Removed |Added Summary|Segfault waiting for ffmpeg |[win] Render animation |