[konsole] [Bug 396435] emoji rendering broken

2018-10-05 Thread Martin Hostettler
https://bugs.kde.org/show_bug.cgi?id=396435 --- Comment #23 from Martin Hostettler --- (In reply to Mariusz Glebocki from comment #22) > (In reply to Martin Hostettler from comment #21) > > tangent: > > I think in the long run we need some way for applications to download the > > actually used wi

[konsole] [Bug 396435] emoji rendering broken

2018-10-05 Thread Mariusz Glebocki
https://bugs.kde.org/show_bug.cgi?id=396435 --- Comment #22 from Mariusz Glebocki --- (In reply to Martin Hostettler from comment #21) > About the hangul: Konsole before this change did display NFD in a way that > looked correct to my untrained eye. After this change decomposed forms are > displa

[konsole] [Bug 396435] emoji rendering broken

2018-10-04 Thread Martin Hostettler
https://bugs.kde.org/show_bug.cgi?id=396435 --- Comment #21 from Martin Hostettler --- About the Surrogates: You are right. I modified my script to ignore those like C0 and C1. They should never reach this code. About the hangul: Konsole before this change did display NFD in a way that looked co

[konsole] [Bug 396435] emoji rendering broken

2018-10-03 Thread Mariusz Glebocki
https://bugs.kde.org/show_bug.cgi?id=396435 --- Comment #20 from Mariusz Glebocki --- (In reply to Martin Hostettler from comment #19) > This seems to be quite close to what vte/gnome-terminal uses. But not quite > the same. Surrogates technically should be invalid; they are intended to be combi

[konsole] [Bug 396435] emoji rendering broken

2018-10-03 Thread Martin Hostettler
https://bugs.kde.org/show_bug.cgi?id=396435 --- Comment #19 from Martin Hostettler --- This seems to be quite close to what vte/gnome-terminal uses. But not quite the same. vte combines hangul clusters so it's correct for them. It seems konsole does so too so maybe it should also list them as co

[konsole] [Bug 396435] emoji rendering broken

2018-10-03 Thread Martin Hostettler
https://bugs.kde.org/show_bug.cgi?id=396435 --- Comment #18 from Martin Hostettler --- Created attachment 115386 --> https://bugs.kde.org/attachment.cgi?id=115386&action=edit Diff in width calculation between vte-glib-2.59.0 and konsole-master -- You are receiving this mail because: You are w

[konsole] [Bug 396435] emoji rendering broken

2018-10-03 Thread Martin Hostettler
https://bugs.kde.org/show_bug.cgi?id=396435 --- Comment #17 from Martin Hostettler --- Created attachment 115385 --> https://bugs.kde.org/attachment.cgi?id=115385&action=edit Diff in width calculation between xterm-335, glibc-2.28, vte-glib-2.59.0 and konsole-master xterm does runtime detectio

[konsole] [Bug 396435] emoji rendering broken

2018-10-03 Thread Kurt Hindenburg
https://bugs.kde.org/show_bug.cgi?id=396435 Kurt Hindenburg changed: What|Removed |Added Latest Commit||https://commits.kde.org/kon

[konsole] [Bug 396435] emoji rendering broken

2018-10-03 Thread Martin Hostettler
https://bugs.kde.org/show_bug.cgi?id=396435 Martin Hostettler changed: What|Removed |Added CC||textshell-dIA3f6@uchuujin.d

[konsole] [Bug 396435] emoji rendering broken

2018-09-30 Thread Kurt Hindenburg
https://bugs.kde.org/show_bug.cgi?id=396435 --- Comment #14 from Kurt Hindenburg --- Git commit 5f32cb3c44f2b1cb3faa2efd2371da4af80dce2e by Kurt Hindenburg, on behalf of Mariusz Glebocki. Committed on 30/09/2018 at 16:22. Pushed by hindenburg into branch 'master'. Add a tool for generating chara

[konsole] [Bug 396435] emoji rendering broken

2018-09-26 Thread Kurt Hindenburg
https://bugs.kde.org/show_bug.cgi?id=396435 --- Comment #13 from Kurt Hindenburg --- Git commit 0f33ee504bc2e7cc8e466093131a15117f3d3460 by Kurt Hindenburg, on behalf of Mariusz Glebocki. Committed on 27/09/2018 at 02:46. Pushed by hindenburg into branch 'master'. Move character width functions

[konsole] [Bug 396435] emoji rendering broken

2018-09-25 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=396435 Nate Graham changed: What|Removed |Added CC||n...@kde.org -- You are receiving this mail beca

[konsole] [Bug 396435] emoji rendering broken

2018-09-07 Thread Mariusz Glebocki
https://bugs.kde.org/show_bug.cgi?id=396435 --- Comment #12 from Mariusz Glebocki --- I can finish it on the weekend, and publish next week. Sorry for huge delay. -- You are receiving this mail because: You are watching all bug changes.

[konsole] [Bug 396435] emoji rendering broken

2018-09-05 Thread Kurt Hindenburg
https://bugs.kde.org/show_bug.cgi?id=396435 --- Comment #11 from Kurt Hindenburg --- Mariusz, are you still working on this? Any ETA? -- You are receiving this mail because: You are watching all bug changes.

[konsole] [Bug 396435] emoji rendering broken

2018-08-20 Thread Achilleas Koutsou
https://bugs.kde.org/show_bug.cgi?id=396435 Achilleas Koutsou changed: What|Removed |Added CC||achillea...@gmail.com -- You are receiving

[konsole] [Bug 396435] emoji rendering broken

2018-07-27 Thread Kurt Hindenburg
https://bugs.kde.org/show_bug.cgi?id=396435 --- Comment #10 from Kurt Hindenburg --- Git commit 9941ac6a5d6fb1c6d78121d48c6c0da1d2dfad73 by Kurt Hindenburg. Committed on 27/07/2018 at 12:34. Pushed by hindenburg into branch 'Applications/18.08'. Revert "Change internal character type size to 32

[konsole] [Bug 396435] emoji rendering broken

2018-07-26 Thread Kurt Hindenburg
https://bugs.kde.org/show_bug.cgi?id=396435 --- Comment #9 from Kurt Hindenburg --- RC is in a week; I'll look at reverting for 18.08 over the weekend. -- You are receiving this mail because: You are watching all bug changes.

[konsole] [Bug 396435] emoji rendering broken

2018-07-25 Thread Kurt Hindenburg
https://bugs.kde.org/show_bug.cgi?id=396435 --- Comment #8 from Kurt Hindenburg --- https://phabricator.kde.org/D12238 failed on FreeBSD; Martin, your patch tests also fails on FreeBSD ( actual -1, expected 2). -- You are receiving this mail because: You are watching all bug changes.

[konsole] [Bug 396435] emoji rendering broken

2018-07-21 Thread Martin Sandsmark
https://bugs.kde.org/show_bug.cgi?id=396435 --- Comment #7 from Martin Sandsmark --- a temporary fix: https://phabricator.kde.org/D14262 would be appreciated if someone with an older glibc (that 2.27) or non-linux system could test this; -- You are receiving this mail because: You are watching

[konsole] [Bug 396435] emoji rendering broken

2018-07-21 Thread Martin Sandsmark
https://bugs.kde.org/show_bug.cgi?id=396435 --- Comment #6 from Martin Sandsmark --- yeah, I tried it myself earlier (using the system wcwidth), but it didn't go further than a discussion on IRC. I don't remember the exact reason I abandoned it, probably because wcwidth() varies so much between s

[konsole] [Bug 396435] emoji rendering broken

2018-07-17 Thread Mariusz Glebocki
https://bugs.kde.org/show_bug.cgi?id=396435 --- Comment #5 from Mariusz Glebocki --- There was an attempt to use wcwidth() https://phabricator.kde.org/D12238 I'll create review request this week with UCD files to width tables converter (for future table updates), Unicode 10 + UTR #51 v5.0 based

[konsole] [Bug 396435] emoji rendering broken

2018-07-16 Thread Martin Sandsmark
https://bugs.kde.org/show_bug.cgi?id=396435 --- Comment #4 from Martin Sandsmark --- this is with a modern glibc on linux, btw, should probably test on other platforms, konsole_wcwidth() might be better. -- You are receiving this mail because: You are watching all bug changes.

[konsole] [Bug 396435] emoji rendering broken

2018-07-16 Thread Martin Sandsmark
https://bugs.kde.org/show_bug.cgi?id=396435 --- Comment #3 from Martin Sandsmark --- it's our wcwidth implementation that isn't updated for using uint32_t stuff. but now that we're using that, we can just use the platform wcwidth(), at least on linux (just putting «return wcwidth(ucs);» at the to

[konsole] [Bug 396435] emoji rendering broken

2018-07-12 Thread Mariusz Glebocki
https://bugs.kde.org/show_bug.cgi?id=396435 Mariusz Glebocki changed: What|Removed |Added Assignee|konsole-de...@kde.org |m...@arccos-1.net --- Comment #2 from Marius

[konsole] [Bug 396435] emoji rendering broken

2018-07-12 Thread Kurt Hindenburg
https://bugs.kde.org/show_bug.cgi?id=396435 Kurt Hindenburg changed: What|Removed |Added Ever confirmed|0 |1 Status|UNCONFIRMED