https://bugs.kde.org/show_bug.cgi?id=372094
Leslie Zhai changed:
What|Removed |Added
Status|CONFIRMED |RESOLVED
Resolution|---
https://bugs.kde.org/show_bug.cgi?id=372094
--- Comment #12 from Kevin Kofler ---
Looks OK to me.
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.kde.org/show_bug.cgi?id=372094
--- Comment #11 from Leslie Zhai ---
Git commit abe673e2f1b9b016d3a9c3aaad42d808a80a0b4a by Leslie Zhai.
Committed on 09/11/2016 at 06:30.
Pushed by lesliezhai into branch 'cdrskin'.
Restore wodim support
Although wodim from cdrkit (CD only, DVD depre
https://bugs.kde.org/show_bug.cgi?id=372094
--- Comment #10 from Kevin Kofler ---
Also, please keep in mind that cdrtools/cdrkit is not only cdrecord/wodim, but
also mkisofs/genisoimage. You will also want to detect and use xorrisofs from
libburnia, which is likely a better mkisofs replacement th
https://bugs.kde.org/show_bug.cgi?id=372094
--- Comment #9 from Kevin Kofler ---
> but I want to ship still-maintaining && BUGFREE product to end-users.
I actually agree with you there. I really think we need to switch to libburnia.
You should just clearly communicate this to packagers when ann
https://bugs.kde.org/show_bug.cgi?id=372094
--- Comment #8 from Leslie Zhai ---
(In reply to Kevin Kofler from comment #7)
> And we will default to libburnia if you add tested support for it. But I
> object to removing wodim support before a replacement is ready. We cannot
> use cdrecord in Fedor
https://bugs.kde.org/show_bug.cgi?id=372094
--- Comment #7 from Kevin Kofler ---
And we will default to libburnia if you add tested support for it. But I object
to removing wodim support before a replacement is ready. We cannot use cdrecord
in Fedora.
--
You are receiving this mail because:
You
https://bugs.kde.org/show_bug.cgi?id=372094
--- Comment #6 from Kevin Kofler ---
Removing working detection code just because you did not understand what it
really does is not helpful. Especially when your "fixes" actually make the code
misbehave on our distribution. And answering a request to re
https://bugs.kde.org/show_bug.cgi?id=372094
Leslie Zhai changed:
What|Removed |Added
CC||xiangzha...@gmail.com
--- Comment #5 from Leslie
https://bugs.kde.org/show_bug.cgi?id=372094
Rex Dieter changed:
What|Removed |Added
Ever confirmed|0 |1
CC||
https://bugs.kde.org/show_bug.cgi?id=372094
--- Comment #3 from Kevin Kofler ---
Also, your change is labeled "Use cdrecord for burning blueray instead of
wodim.", but K3b did not attempt to use wodim to burn BluRay even before your
change. If you look more closely at the code you removed, you wi
https://bugs.kde.org/show_bug.cgi?id=372094
--- Comment #2 from Kevin Kofler ---
And in the long run, to work with something maintained, see wishlist bug
#137436.
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.kde.org/show_bug.cgi?id=372094
--- Comment #1 from Kevin Kofler ---
I will also note that your changes have several logic errors:
-: K3b::AbstractCdrtoolsProgram( QLatin1String( "cdrecord" ),
QLatin1String( "wodim" ) )
+: K3b::AbstractCdrtoolsProgram( QLatin1String( "cdrecor
13 matches
Mail list logo
