https://bugs.kde.org/show_bug.cgi?id=404076
--- Comment #2 from Vadim Barkov ---
(In reply to Andreas Arnez from comment #1)
> The vector decimal instructions are special because Valgrind doesn't even
> support any of the existing decimal instructions (chapter 8) yet. Thus I
> su
https://bugs.kde.org/show_bug.cgi?id=398649
Vadim Barkov changed:
What|Removed |Added
CC||vbr...@gmail.com
Status|REPORTED
https://bugs.kde.org/show_bug.cgi?id=404076
Vadim Barkov changed:
What|Removed |Added
CC||jsew...@acm.org
--
You are receiving this mail
https://bugs.kde.org/show_bug.cgi?id=404076
Vadim Barkov changed:
What|Removed |Added
CC||ar...@linux.ibm.com
--
You are receiving this
https://bugs.kde.org/show_bug.cgi?id=404076
Vadim Barkov changed:
What|Removed |Added
CC||vbr...@gmail.com
--
You are receiving this
https://bugs.kde.org/show_bug.cgi?id=404076
Bug ID: 404076
Summary: s390x: z14 vector instructions not implemented
Product: valgrind
Version: unspecified
Platform: Other
OS: Linux
Status: REPORTED
Severity
https://bugs.kde.org/show_bug.cgi?id=275144
Vadim Barkov changed:
What|Removed |Added
Status|REOPENED|RESOLVED
Resolution
https://bugs.kde.org/show_bug.cgi?id=385411
--- Comment #6 from Vadim Barkov ---
(In reply to Andreas Arnez from comment #5)
Good news! Is any additional work needed on this issue?
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.kde.org/show_bug.cgi?id=385411
--- Comment #3 from Vadim Barkov ---
Created attachment 115427
--> https://bugs.kde.org/attachment.cgi?id=115427&action=edit
z13 vector floating point support (code)
Please take a look
--
You are receiving this mail because:
You are watch
https://bugs.kde.org/show_bug.cgi?id=385411
--- Comment #2 from Vadim Barkov ---
Created attachment 115426
--> https://bugs.kde.org/attachment.cgi?id=115426&action=edit
z13 vector floating point support (tests)
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.kde.org/show_bug.cgi?id=385411
Vadim Barkov changed:
What|Removed |Added
CC||vbr...@gmail.com
--- Comment #1 from Vadim
https://bugs.kde.org/show_bug.cgi?id=385409
--- Comment #67 from Vadim Barkov ---
(In reply to Andreas Arnez from comment #66)
> (In reply to Mark Wielaard from comment #65)
> > The answer to that is (it is actually 8 patches) and they should all be
> > applied in order.
> C
https://bugs.kde.org/show_bug.cgi?id=385409
--- Comment #55 from Vadim Barkov ---
(In reply to Julian Seward from comment #47)
> (In reply to Vadim Barkov from comment #46)
> > Since the issue is solved,
>
> I don't consider it to be solved.
>
> You didn't an
https://bugs.kde.org/show_bug.cgi?id=385409
Vadim Barkov changed:
What|Removed |Added
Attachment #114484|0 |1
is obsolete
https://bugs.kde.org/show_bug.cgi?id=385409
--- Comment #52 from Vadim Barkov ---
Created attachment 114484
--> https://bugs.kde.org/attachment.cgi?id=114484&action=edit
Refactoring
Refactoring
Simplified code for most of vector integer instructions (and some vector basic
ones). Most
https://bugs.kde.org/show_bug.cgi?id=385409
--- Comment #49 from Vadim Barkov ---
(In reply to Florian Weimer from comment #48)
> With the current set of patches, I still see failures for the following
> glibc string function tests:
>
> string/test-memcmp
> string/test-strcasecm
https://bugs.kde.org/show_bug.cgi?id=385409
--- Comment #46 from Vadim Barkov ---
Since the issue is solved, is it ready to merge? Or additional testing is
needed?
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.kde.org/show_bug.cgi?id=385409
--- Comment #45 from Vadim Barkov ---
(In reply to Julian Seward from comment #44)
The new VFENE implementation has no problems. I just want to point you that in
my opinion the memchecks' "Conditional jump or move depends on uninitialis
https://bugs.kde.org/show_bug.cgi?id=385409
--- Comment #43 from Vadim Barkov ---
Generally speaking I think that warning in inline strlen is correct because the
VFENE specification says:
If ZS (zero search) flag is set, then each element in the second operand is
compared for equality with zero
https://bugs.kde.org/show_bug.cgi?id=385409
--- Comment #42 from Vadim Barkov ---
Good news! I've solved the strlen inlining issue.
The old VFENE implementation used the dirty helper, which marked second and
third argument fully read (16 bytes). This is semantically wrong because
https://bugs.kde.org/show_bug.cgi?id=385409
Vadim Barkov changed:
What|Removed |Added
Attachment #114334|0 |1
is obsolete
https://bugs.kde.org/show_bug.cgi?id=385409
--- Comment #38 from Vadim Barkov ---
(In reply to Florian Weimer from comment #30)
Floarian,
I can't reproduce the problem that you describe. Could you take my patch
(attachment 114327) and test against your executable?
--
You are receiving
https://bugs.kde.org/show_bug.cgi?id=385409
Vadim Barkov changed:
What|Removed |Added
Attachment #114305|0 |1
is obsolete
https://bugs.kde.org/show_bug.cgi?id=385409
--- Comment #35 from Vadim Barkov ---
(In reply to Florian Weimer from comment #30)
Are you sure that VLL is the reason of the bug with strlen? If so, I believe
that the conditional load implementation is the most natural. I'll add suppor
https://bugs.kde.org/show_bug.cgi?id=385409
--- Comment #34 from Vadim Barkov ---
(In reply to Julian Seward from comment #32)
> What does VFENEZBS do?
VFENE V1, V2, V3 -- vector find element not equal
It elementwise compares V2 and V3. If an unequal element is found, its index is
stored
https://bugs.kde.org/show_bug.cgi?id=385409
--- Comment #17 from Vadim Barkov ---
(In reply to Julian Seward from comment #14)
Okay, I've refixed that issue without volatile (replaced UChar[6] array with
ULong in union).
Please, check the final version out. It includes the Andreas'
https://bugs.kde.org/show_bug.cgi?id=385409
Vadim Barkov changed:
What|Removed |Added
Attachment #114122|0 |1
is obsolete
https://bugs.kde.org/show_bug.cgi?id=385409
Vadim Barkov changed:
What|Removed |Added
Attachment #114145|0 |1
is obsolete
https://bugs.kde.org/show_bug.cgi?id=385409
--- Comment #13 from Vadim Barkov ---
I've made the union in s390x_dirtyhelper_vec_op volatile and the bug magically
dissapeared.
Fixed.
Now I'll rearrange all stuff into two patches (tests & code) and submit here.
--
You are recei
https://bugs.kde.org/show_bug.cgi?id=385409
--- Comment #12 from Vadim Barkov ---
Andreas, I've reproduced the bug.
This occurs only when compiling valgrind with gcc-8 (I've used "gcc (SUSE
Linux) 8.1.1 20180719") and with default optimisation flags (I guess it is
"
https://bugs.kde.org/show_bug.cgi?id=385409
--- Comment #7 from Vadim Barkov ---
Andreas,
I can't reproduce you test results so I added tests for every possible result
of VTM instruction. Could you apply patch from attachment 114145 and write the
results to me?
I need more informati
https://bugs.kde.org/show_bug.cgi?id=385409
--- Comment #6 from Vadim Barkov ---
Created attachment 114145
--> https://bugs.kde.org/attachment.cgi?id=114145&action=edit
More tests for VTM instruction
Changes:
Added tests for all possible result of VTM instruction.
--
You are receivi
https://bugs.kde.org/show_bug.cgi?id=396839
Vadim Barkov changed:
What|Removed |Added
CC||vbr...@gmail.com
--- Comment #1 from Vadim
https://bugs.kde.org/show_bug.cgi?id=385409
Vadim Barkov changed:
What|Removed |Added
Attachment #110339|0 |1
is obsolete
https://bugs.kde.org/show_bug.cgi?id=385410
Vadim Barkov changed:
What|Removed |Added
Attachment #110181|0 |1
is obsolete
https://bugs.kde.org/show_bug.cgi?id=385412
--- Comment #23 from Vadim Barkov ---
Andreas,
I've just reproduced the problem you get. I had tried to apply this patches
with "--dry-run" and got the same error. But without "--dry-run" everything is
okay. I am not sure wh
https://bugs.kde.org/show_bug.cgi?id=385409
--- Comment #3 from Vadim Barkov ---
(In reply to Christian Borntraeger from comment #2)
> I have not checked if these patches still apply, but for the general patches
> consider these patches acked from my s390x perspective.
I've ensure
https://bugs.kde.org/show_bug.cgi?id=385412
--- Comment #19 from Vadim Barkov ---
(In reply to Julian Seward from comment #18)
> I think this is equivalent:
>
> // getReg(RegisterNumber n) returns the value of GPR number 'n'
>
> // reg1 and reg2 are even
> v
https://bugs.kde.org/show_bug.cgi?id=385412
--- Comment #17 from Vadim Barkov ---
(In reply to Julian Seward from comment #14)
> Can you tell me briefly what PPNO does? Specifically, what inputs and
> what outputs (registers and memory) does it have? Then I can maybe suggest
> an al
https://bugs.kde.org/show_bug.cgi?id=385412
--- Comment #10 from Vadim Barkov ---
Andreas,
I fixed the PPNO implementation so the tests are memcheck clean. I think it's
ready to merge.
Julian,
Could you review and merge it?
--
You are receiving this mail because:
You are watching al
https://bugs.kde.org/show_bug.cgi?id=385412
Vadim Barkov changed:
What|Removed |Added
Assignee|vbr...@gmail.com|jsew...@acm.org
--
You are receiving this mail
https://bugs.kde.org/show_bug.cgi?id=385412
Vadim Barkov changed:
What|Removed |Added
Status|UNCONFIRMED |ASSIGNED
Assignee|jsew...@acm.org
https://bugs.kde.org/show_bug.cgi?id=385412
--- Comment #8 from Vadim Barkov ---
Andreas,
I'll look into this issue on this week. Could you check vector integer&string
patch out?
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.kde.org/show_bug.cgi?id=385409
Vadim Barkov changed:
What|Removed |Added
Ever confirmed|0 |1
Status|UNCONFIRMED
https://bugs.kde.org/show_bug.cgi?id=385410
--- Comment #5 from Vadim Barkov ---
Please not that last attachment 110181 has been merged into "vector integer"
one (located in bug 385409).
The reason to do so is that it's small and code from here is used in "vector
integer&
https://bugs.kde.org/show_bug.cgi?id=385409
Vadim Barkov changed:
What|Removed |Added
CC||vbr...@gmail.com
--- Comment #1 from Vadim
https://bugs.kde.org/show_bug.cgi?id=385412
Vadim Barkov changed:
What|Removed |Added
Attachment #110193|0 |1
is obsolete
https://bugs.kde.org/show_bug.cgi?id=385412
--- Comment #3 from Vadim Barkov ---
It can be applied on master. Please take a look.
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.kde.org/show_bug.cgi?id=385412
--- Comment #2 from Vadim Barkov ---
Created attachment 110193
--> https://bugs.kde.org/attachment.cgi?id=110193&action=edit
Non-vector z13 support
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.kde.org/show_bug.cgi?id=385410
Vadim Barkov changed:
What|Removed |Added
Attachment #109789|0 |1
is obsolete
https://bugs.kde.org/show_bug.cgi?id=385410
--- Comment #3 from Vadim Barkov ---
Since the "support" patch is merged this "string" patch can be applied directly
to master.
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.kde.org/show_bug.cgi?id=385408
--- Comment #37 from Vadim Barkov ---
Thank you for apply. Could you mark this as resolved and close?
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.kde.org/show_bug.cgi?id=385410
--- Comment #2 from Vadim Barkov ---
Created attachment 109789
--> https://bugs.kde.org/attachment.cgi?id=109789&action=edit
Vector string support for s390x z13
Vector string patch:
It is supposed to be applied after this attachment 109672 f
https://bugs.kde.org/show_bug.cgi?id=385408
Vadim Barkov changed:
What|Removed |Added
Attachment #109653|0 |1
is obsolete
https://bugs.kde.org/show_bug.cgi?id=385408
--- Comment #34 from Vadim Barkov ---
Please try use --ignore-whitespaces option while paching (I forgot to mention
it). It works for me (on latest commit from Jan, 3,
0f18cfc986f800b107c7eee063b8b7c04617e0b8).
Anyway I'll try to find problem and
https://bugs.kde.org/show_bug.cgi?id=385408
Vadim Barkov changed:
What|Removed |Added
Attachment #109635|0 |1
is obsolete
https://bugs.kde.org/show_bug.cgi?id=385408
--- Comment #31 from Vadim Barkov ---
Are here other task for me to do?
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.kde.org/show_bug.cgi?id=385408
Vadim Barkov changed:
What|Removed |Added
Attachment #108826|0 |1
is obsolete
https://bugs.kde.org/show_bug.cgi?id=385408
--- Comment #27 from Vadim Barkov ---
Julian, did you check this out? I just want to remind you if you forget about
this issue for some reason.
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.kde.org/show_bug.cgi?id=385408
--- Comment #23 from Vadim Barkov ---
(In reply to Andreas Arnez from comment #12)
> (In reply to Vadim Barkov from comment #10)
> > Created attachment 108579 [details]
> > Initial vector support (chapter 21) (remastered)
&
https://bugs.kde.org/show_bug.cgi?id=385408
--- Comment #22 from Vadim Barkov ---
(In reply to Julian Seward from comment #19)
If the new Iop_Perm8x16x2 handling in memcheck is incorrect I'll remove
Iop_Perm8x16x2 operation and will handle VPERM insn via dirtyhelper. I already
have some
https://bugs.kde.org/show_bug.cgi?id=385408
--- Comment #21 from Vadim Barkov ---
(In reply to Julian Seward from comment #19)
> (In reply to Vadim Barkov from comment #18)
> > Created attachment 108754 [details]
> > Initial vector support (chapter 21) (fixed doc)
>
> This
https://bugs.kde.org/show_bug.cgi?id=385408
Vadim Barkov changed:
What|Removed |Added
Attachment #108754|0 |1
is obsolete
https://bugs.kde.org/show_bug.cgi?id=385408
Vadim Barkov changed:
What|Removed |Added
Attachment #108682|0 |1
is obsolete
https://bugs.kde.org/show_bug.cgi?id=385408
--- Comment #16 from Vadim Barkov ---
(In reply to Julian Seward from comment #8)
> (In reply to Vadim Barkov from comment #6)
> > Created attachment 108482 [details]
> > Initial vector support for z13 (chapter 21)
>
> This
https://bugs.kde.org/show_bug.cgi?id=385408
--- Comment #15 from Vadim Barkov ---
I've fixed all problems you pointed to. Waiting for your verdict
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.kde.org/show_bug.cgi?id=385408
Vadim Barkov changed:
What|Removed |Added
Attachment #108579|0 |1
is obsolete
https://bugs.kde.org/show_bug.cgi?id=385412
Vadim Barkov changed:
What|Removed |Added
CC||vbr...@gmail.com
--- Comment #1 from Vadim
https://bugs.kde.org/show_bug.cgi?id=385408
--- Comment #13 from Vadim Barkov ---
(In reply to Andreas Arnez from comment #12)
> (In reply to Vadim Barkov from comment #10)
> * In /none/tests/s390x/vector.c, you use z13 instructions in __asm__
> directives. This is probably OK if you
https://bugs.kde.org/show_bug.cgi?id=385408
--- Comment #11 from Vadim Barkov ---
(In reply to Julian Seward from comment #8)
> (In reply to Vadim Barkov from comment #6)
> * Divide it up into much smaller pieces, each of which can be reviewed
> independently.
I divided code in logi
https://bugs.kde.org/show_bug.cgi?id=385408
Vadim Barkov changed:
What|Removed |Added
Attachment #108482|0 |1
is obsolete
https://bugs.kde.org/show_bug.cgi?id=385408
--- Comment #7 from Vadim Barkov ---
(In reply to Andreas Arnez from comment #5)
> (In reply to Vadim Barkov from comment #3)
> > The adding of -march=z13 to CFLAGS isn't good aproach however it's the only
> > way to compile
https://bugs.kde.org/show_bug.cgi?id=385408
Vadim Barkov changed:
What|Removed |Added
Attachment #108457|0 |1
is obsolete
https://bugs.kde.org/show_bug.cgi?id=385408
Vadim Barkov changed:
What|Removed |Added
Attachment #108343|0 |1
is obsolete
https://bugs.kde.org/show_bug.cgi?id=385408
--- Comment #3 from Vadim Barkov ---
The adding of -march=z13 to CFLAGS isn't good aproach however it's the only way
to compile condition code helpers in VEX/priv/guest_s390x_helpers.c (I've tried
".insn vrr, ..." aproach but
https://bugs.kde.org/show_bug.cgi?id=385410
Vadim Barkov changed:
What|Removed |Added
CC||vbr...@gmail.com
--- Comment #1 from Vadim
https://bugs.kde.org/show_bug.cgi?id=385408
--- Comment #2 from Vadim Barkov ---
Alternatively to patch you can clone my mirror:
$ git clone https://github.com/barkovv/valgrind
$ git checkout vector_basic_z13
--
You are receiving this mail because:
You are watching all bug changes.
77 matches
Mail list logo
