Re: [JPP-Devel] TaskFrame and WorkbenchContext source code files for review before commit.

2008-07-11 Thread Sunburned Surveyor
Stefan wrote: "a few comments on your changes [personal thoughts]" My responses to your comments are below, inline. Stefan wrote: "I know you may have pointed out why you did that, but why would you do that? What happens then? The mouse pointer changes?" The cancelGesture method allows the Curso

Re: [JPP-Devel] TaskFrame and WorkbenchContext source code files for review before commit.

2008-07-10 Thread Stefan Steiniger
Hei Landon, a few comments on your changes [personal thoughts] > However, I think there is a reasonable solution: > > I'll keep all of my changes in my own fork. I'll regularly present > these changes to the OpenJUMP programming community. I'll clearly > identify those changes that I think are n

Re: [JPP-Devel] TaskFrame and WorkbenchContext source code files for review before commit.

2008-07-07 Thread Sunburned Surveyor
This is great discussion! I always appreciate being part of this global community! Larry wrote: "so I would like to acknowledge that your programming skills have come a long way since you first started working on OJ (in 2005?). " Thanks for the complement. I actually started in around 2004, and J

Re: [JPP-Devel] TaskFrame and WorkbenchContext source code files for review before commit.

2008-07-06 Thread Stefan Steiniger
only on this: > Stefan wrote: "So commit rules will be > more strict in terms of agreement and outlining the absolutely necessity > of those changes and the expected problems with backwards compatibility > [e.g plugins]. I may refer here to emails by Sascha Teichmann. > Up to now there is still th

Re: [JPP-Devel] TaskFrame and WorkbenchContext source code files for review before commit.

2008-07-05 Thread Eric Jarvies
On Jul 5, 2008, at 6:07 PM, Larry Becker wrote:Hi Sunburned,>As long as everyone else has to play by the same rules. If I'm getting>special treatment I should at least know the reason. (I'll gladly>accept suggestions or recommendations that deal with technical issues >in my source code.) As you kno

Re: [JPP-Devel] TaskFrame and WorkbenchContext source code files for review before commit.

2008-07-05 Thread Andreas Schmitz
Larry Becker wrote: Hi, > >As long as everyone else has to play by the same rules. If I'm getting > >special treatment I should at least know the reason. (I'll gladly > >accept suggestions or recommendations that deal with technical issues > >in my source code.) > > As you know, I never mince wo

Re: [JPP-Devel] TaskFrame and WorkbenchContext source code files for review before commit.

2008-07-05 Thread Larry Becker
Hi Sunburned, >As long as everyone else has to play by the same rules. If I'm getting >special treatment I should at least know the reason. (I'll gladly >accept suggestions or recommendations that deal with technical issues >in my source code.) As you know, I never mince words, so I would like to

Re: [JPP-Devel] TaskFrame and WorkbenchContext source code files for review before commit.

2008-07-05 Thread Sunburned Surveyor
I must have forgot the attachments. They are at my computer at work. I'll resend them on Monday. I must clarify that the changes I want to commit to the core have nothing to do with the Docking Window Framework or any other GUI changes. There just some clean-up and improvements of the TaskFrame cl

Re: [JPP-Devel] TaskFrame and WorkbenchContext source code files for review before commit.

2008-07-04 Thread Stefan Steiniger
Landon, before you commit such changes I would like to a) review it (sorry, I have not found the time yet to read all your emails on that subject), which may need some time. b) get an agreement by other programmers [Larry, Paul, Andreas, Michael] that these changes are of benefit. c) know whic

[JPP-Devel] TaskFrame and WorkbenchContext source code files for review before commit.

2008-07-04 Thread Sunburned Surveyor
I've attached the two (2) source code files with some of my recent clean-up/changes. (This doesn't include any of the docking window framework or look-and-feel changes.) Please review my changes to these two (2) classes if you have concerns before I commit to the core. I'll commit next week if the