+1 too :)
Michaël Michaud schrieb:
> my vote : +1
>
> Michael
>
> Sascha L. Teichmann a écrit :
>
>> Okay,
>>
>> I 'grep'ed the sources carefully and could not find any other
>> place were it may come to problems. I've tested the styling stuff
>> quiet intensively now and I feel pretty sure abo
my vote : +1
Michael
Sascha L. Teichmann a écrit :
>Okay,
>
>I 'grep'ed the sources carefully and could not find any other
>place were it may come to problems. I've tested the styling stuff
>quiet intensively now and I feel pretty sure about this patches.
>If no one disapproves I will commit the
Okay,
I 'grep'ed the sources carefully and could not find any other
place were it may come to problems. I've tested the styling stuff
quiet intensively now and I feel pretty sure about this patches.
If no one disapproves I will commit them tomorrow.
- Sascha
Larry Becker schrieb:
> Works great a
Works great and has no side effects that I have found.
Larry
On 6/5/07, Sascha L. Teichmann <[EMAIL PROTECTED]> wrote:
> The NPE comes from BasicStylePanel#findEquivalentItem()
> Therefore it would vote for make this one more bullet proof.
>
> See my new patch. I would leave BasicStyle#getFillPat
The NPE comes from BasicStylePanel#findEquivalentItem()
Therefore it would vote for make this one more bullet proof.
See my new patch. I would leave BasicStyle#getFillPattern()
untouched.
Larry Becker schrieb:
> It seem to work when I modify getFillPattern in BasicStyle to include
> the check fo
It seem to work when I modify getFillPattern in BasicStyle to include
the check for null and then initialize the fillPattern as before.
public Paint getFillPattern() {
if (fillPattern == null) {
fillPattern = WKTFillPattern.createDiagonalStripePattern(4,
Sascha,
I implemented your changes in SkyJUMP to BasicStyle and
BasicStylePanel. It worked when I opened a task with colour theming
already set up, but when I tried to add a new layer and chose Change
Styles, I got:
java.lang.NullPointerException
at
com.vividsolutions.jump.workbench.
Sascha,
In your comments you said you added an if statement but used the ?:
operator, I think in this case a proper if {} else {} statement would be
much more readable. I think that the ?: operator should be used
minimally, for example if you were generating HTML and wanted to
optionally include a
So, that should fix it
Added an 'if (fillPattern == null)' to the GUI and removed
the ultra expensive pattern creation from BasicStyle.
The construction of 100,000 BasicStyle objects now take
0.267 secs. before it took 27.357 seconds.
Find attached patches against BasicStyle and BasicStyleP
I'll try to remove the GUI dependencies for
a preset fill pattern, but I also want to make
BasicStyle more light weighted. I'll have a look at
it later.
- Sascha
Larry Becker schrieb:
> Hi Sascha,
>
>Great work! You have found the cause of another annoying slowdown.
> I first noticed this
Hi Sascha,
Great work! You have found the cause of another annoying slowdown.
I first noticed this doing the burlulc benchark with Colour Theming.
It really needs to be fixed. I noticed that it is fixed in Kosmo
already, however their model is probably different.
Fixing BasicStyle to use
Hi together!
I was wondering why it takes so long to enable
Colour Theming when working with layers with a
higher number of features.
If you open the "Changes Styles", choose tab
"Colour Theming" and check "Enable colour theming".
If I do this with a 36,000+ polygon shape file it
takes about 24(
12 matches
Mail list logo
