Re: [JPP-Devel] Tests in DeleteDuplicateGeometriesTest

2012-01-27 Thread Benjamin Gudehus
Ok, I've got it. It's all clear. The menu entry is actually created, I just missed to call validate on the menu bar... 2012/1/27 Benjamin Gudehus > I tried to add a feature test for the installation of the plugin to the > menubar. > > private void initializeMenuItem(PlugInContext context) { >

Re: [JPP-Devel] Tests in DeleteDuplicateGeometriesTest

2012-01-27 Thread Benjamin Gudehus
I tried to add a feature test for the installation of the plugin to the menubar. private void initializeMenuItem(PlugInContext context) { FeatureInstaller installer = new FeatureInstaller(context.getWorkbenchContext()); String[] menuPath = new String[] { MenuNames.TOOLS, MenuNames.TOOLS_QA

Re: [JPP-Devel] Tests in DeleteDuplicateGeometriesTest

2012-01-25 Thread Benjamin Gudehus
I've pushed my refactorings to improve readability to the repository. For the future we could run a parser over the classes to extract the language/translation strings for the language files: private String langName = "Delete Duplicate Geometries"; private String langDescription = "deletes featur

Re: [JPP-Devel] Tests in DeleteDuplicateGeometriesTest

2012-01-25 Thread Benjamin Gudehus
Here are some ideas/questions for refactoring of the class: 1. List configuration parameters prominently (Layer itemLayer, boolean deleteOnlySameAttributes) So it is easier to see what parameters could be tested or used. 2. List language strings prominently (String langDescription, String langDele

Re: [JPP-Devel] Tests in DeleteDuplicateGeometriesTest

2012-01-15 Thread Benjamin Gudehus
including 8 strict features => including 8 strict duplicates ;) 2012/1/15 Benjamin Gudehus > 2012/1/15 Michaël Michaud >> >> It took me a while to make it work, because in the same time, I tried >> to use Eclipse, then Netbeans that I've never really used for a big >> project. >> It was a hor

Re: [JPP-Devel] Tests in DeleteDuplicateGeometriesTest

2012-01-15 Thread Benjamin Gudehus
2012/1/15 Michaël Michaud > > It took me a while to make it work, because in the same time, I tried > to use Eclipse, then Netbeans that I've never really used for a big > project. > It was a horrible experience. How can Eclipse be so popular ? I'm > really wondering. > But JUnit also works for

Re: [JPP-Devel] Tests in DeleteDuplicateGeometriesTest

2012-01-15 Thread Michaël Michaud
Hi Benjamin, And thank you for your help and information about the unit test framework. It took me a while to make it work, because in the same time, I tried to use Eclipse, then Netbeans that I've never really used for a big project. It was a horrible experience. How can Eclipse be so popular ?

Re: [JPP-Devel] Tests in DeleteDuplicateGeometriesTest

2012-01-14 Thread Benjamin Gudehus
Some more tips for testing: - if there is nothing special with the geometries for shapefile-fixtures just use rectagular geometries snapped to a grid (e.g. with a space with 20 meters) - if you want to keep the workbenchframe open, just add Thread.sleep(Integer.MAX_VALUE); to the end of the test c

[JPP-Devel] Tests in DeleteDuplicateGeometriesTest

2012-01-14 Thread Benjamin Gudehus
Hi Michaël! Here are some ideas for the tests: 1. a fixture "duplicate-geometries.jml" with duplicate geometries. 2. a new test class "DeleteDuplicateGeometriesPlugInTest" copied from UnionByAttributePlugInTests 3. change parameters to "itemlayer" and "deleteOnlyForSameAttributes" 4. write test