Re: Is ReviewBoard a good thing?

2014-09-19 Thread Jesse Meek
On 20/09/14 02:34, Eric Snow wrote: On Thu, Sep 18, 2014 at 6:19 PM, Jesse Meek wrote: We moved to GitHub in the hope of lowering the bar to contributors outside the team. GitHub is *the* platform and process for open source software. This was the logic behind the move. It was deemed to have t

Re: The Pros and Cons of ReviewBoard.

2014-09-19 Thread Jonathan Aquilina
I also suggested in another part of the thread sending an email when a new request is submitted to all those invovled with the reviewing. --- Regards, Jonathan Aquilina Founder Eagle Eye T On 2014-09-19 23:14, Nate Finch wrote: > If we automate the creation of reviewboard reviews whenever a

Re: The Pros and Cons of ReviewBoard.

2014-09-19 Thread Jonathan Aquilina
Thats what im suggesting be it coding somethign from scratch or adapting RB to make it much easier to work with. --- Regards, Jonathan Aquilina Founder Eagle Eye T On 2014-09-19 23:01, Matthew Williams wrote: > At the risk of opening a can of worms: > > Reviewboard doesn't have to be a ba

Re: Is ReviewBoard a good thing?

2014-09-19 Thread David Cheney
On Sat, Sep 20, 2014 at 1:02 AM, Eric Snow wrote: > On Thu, Sep 18, 2014 at 6:32 PM, David Cheney > wrote: >> There were three problem reviewboard was supposed to address, review >> comments are sent immediately, no side by side diffs, and no way to to >> chained proposals. > > It will be worth b

Re: The Pros and Cons of ReviewBoard.

2014-09-19 Thread Nate Finch
If we automate the creation of reviewboard reviews whenever a pull request is made, it would make it trivial even for outsiders. On Sep 19, 2014 5:01 PM, "Matthew Williams" wrote: > At the risk of opening a can of worms: > > Reviewboard doesn't have to be a barrier to contributing. We could allow

Re: The Pros and Cons of ReviewBoard.

2014-09-19 Thread Matthew Williams
At the risk of opening a can of worms: Reviewboard doesn't have to be a barrier to contributing. We could allow new contributors/ drive by fixes to use github. Matty On 19 Sep 2014 17:05, "Eric Snow" wrote: > On Fri, Sep 19, 2014 at 9:48 AM, Jonathan Aquilina > wrote: > > I am more than willin

Juju stable 1.20.8 is proposed for release

2014-09-19 Thread Curtis Hovey-Canonical
juju-core 1.20.8 A new proposed stable release of Juju, juju-core 1.20.8, is now available. This release may replace stable 1.20.7 after a period of evaluation. If no issues are raised about this version, it will released on or after September 24, 2014. Getting Juju juju-core 1.20.8 is availabl

Re: The Pros and Cons of ReviewBoard.

2014-09-19 Thread Eric Snow
On Fri, Sep 19, 2014 at 9:48 AM, Jonathan Aquilina wrote: > I am more than willing to help out wity those modifications Cool. I'll get in touch. -eric -- Juju-dev mailing list Juju-dev@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/juju-dev

Re: The Pros and Cons of ReviewBoard.

2014-09-19 Thread Jonathan Aquilina
I am more than willing to help out wity those modifications Sent from Samsung Mobile Original message From: Eric Snow Date: 19/09/2014 5:41 PM (GMT+01:00) To: juju-dev@lists.ubuntu.com Subject: Re: The Pros and Cons of ReviewBoard. On Fri, Sep 19, 2014 at 9:37 AM, Eric

Re: The Pros and Cons of ReviewBoard.

2014-09-19 Thread Eric Snow
On Fri, Sep 19, 2014 at 9:37 AM, Eric Snow wrote: > Given that I've in some part driven the switch to ReviewBoard, I want > to make sure we are all on the same page and any decision on its > future can be made objectively. This is an outgrowth of the current > discussion on whether or not we shou

The Pros and Cons of ReviewBoard.

2014-09-19 Thread Eric Snow
Given that I've in some part driven the switch to ReviewBoard, I want to make sure we are all on the same page and any decision on its future can be made objectively. This is an outgrowth of the current discussion on whether or not we should ditch reviewboard. Let's look at the pros and cons of u

Re: Is ReviewBoard a good thing?

2014-09-19 Thread Eric Snow
On Thu, Sep 18, 2014 at 6:32 PM, David Cheney wrote: > There were three problem reviewboard was supposed to address, review > comments are sent immediately, no side by side diffs, and no way to to > chained proposals. It will be worth being extra clear on ReviewBoard's pros and cons. I'll open a

Re: Is ReviewBoard a good thing?

2014-09-19 Thread Eric Snow
On Fri, Sep 19, 2014 at 6:11 AM, Gabriel Samfira wrote: > Just a suggestion: > > A git plugin similar to what Gerrit has would simplify things. For example, > Gerrit has a nice little plugin called "Review". Simply doing: > > git review > > In your current branch would push the patchest to gerrit.

Re: Is ReviewBoard a good thing?

2014-09-19 Thread Eric Snow
On Fri, Sep 19, 2014 at 8:34 AM, Eric Snow wrote: > I agree that reviewboard as we currently have it now adds extra work > to our workflow. Not only does this impact the juju team, but it does > add a stumbling block to more community involvement. However, my firm > belief is that the real pain p

Re: Is ReviewBoard a good thing?

2014-09-19 Thread Eric Snow
On Thu, Sep 18, 2014 at 6:19 PM, Jesse Meek wrote: > We moved to GitHub in the hope of lowering the bar to contributors outside > the team. GitHub is *the* platform and process for open source software. > This was the logic behind the move. It was deemed to have the most mindshare > and we sacrifi

Re: Is ReviewBoard a good thing?

2014-09-19 Thread Horacio Duran
We will all be seeing each other in 2 weeks we can discuss it then On Friday, September 19, 2014, Eric Snow wrote: > On Fri, Sep 19, 2014 at 7:55 AM, Matthew Williams > > wrote: > > I do think it's too early to tell though. Why not give it another week > or 2 > > then discuss in the cross teams

Re: Is ReviewBoard a good thing?

2014-09-19 Thread Eric Snow
On Fri, Sep 19, 2014 at 7:55 AM, Matthew Williams wrote: > I do think it's too early to tell though. Why not give it another week or 2 > then discuss in the cross teams if we want to keep it or not +1 -eric -- Juju-dev mailing list Juju-dev@lists.ubuntu.com Modify settings or unsubscribe at:

Re: Is ReviewBoard a good thing?

2014-09-19 Thread Eric Snow
On Fri, Sep 19, 2014 at 7:55 AM, Dimiter Naydenov wrote: > +1, In addition you can always check > https://github.com/juju/juju/pulls to see what's in the queue. For > sub-repositories it's the same, like > https://github.com/juju/names/pulls. While I agree it's not all in one > place, I tend to wo

Re: Is ReviewBoard a good thing?

2014-09-19 Thread Matthew Williams
You can use kanban for a unified view of reviews, but reviewboard is better - you are able to see which reviews are missing comments and which ones are approved but not landed without having to click through multiple windows. Also the kanban board isn't viewable by everyone AFAIK. Everyone else ha

Re: Is ReviewBoard a good thing?

2014-09-19 Thread Dimiter Naydenov
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 19.09.2014 16:44, Richard Harding wrote: > On Fri, 19 Sep 2014, Nate Finch wrote: > >> There's one thing that hasn't been mentioned - reviewboard gives >> us a unified review queue. > > Can I ask how kanban doesn't do this job for you? I've heard

Re: Is ReviewBoard a good thing?

2014-09-19 Thread Richard Harding
On Fri, 19 Sep 2014, Nate Finch wrote: > There's one thing that hasn't been mentioned - reviewboard gives us a > unified review queue. Can I ask how kanban doesn't do this job for you? I've heard this said a couple of times but I realized the way I find out what needs to be looked at is to go to

Re: Is ReviewBoard a good thing?

2014-09-19 Thread Katherine Cox-Buday
I don't yet have a strong opinion either way. I do think that since we invested so much time in getting Review Board set up, we should use it for a bit longer to see if these are growing pains. On Fri, Sep 19, 2014 at 7:11 AM, Gabriel Samfira < gsamf...@cloudbasesolutions.com> wrote: > Just a su

Re: Is ReviewBoard a good thing?

2014-09-19 Thread Gabriel Samfira
Just a suggestion: A git plugin similar to what Gerrit has would simplify things. For example, Gerrit has a nice little plugin called "Review". Simply doing: git review In your current branch would push the patchest to gerrit. Something similar for RB, would probably simplify things a lot. Cha

Re: Is ReviewBoard a good thing?

2014-09-19 Thread Jonathan Aquilina
Im more than willing to help improve the work flow for you guys. As well as fixup issues you giys feel rb has Sent from Samsung Mobile Original message From: Nate Finch Date: 19/09/2014 1:32 PM (GMT+01:00) To: Jonathan Aquilina Cc: juju-dev@lists.ubuntu.com Subject: Re

Re: Is ReviewBoard a good thing?

2014-09-19 Thread Nate Finch
There's one thing that hasn't been mentioned - reviewboard gives us a unified review queue. On github you need to look in 8 places to see all the stuff up for review, and anything not in juju/juju tends to get lost. This is really important since that can have a big effect on our velocity. I thi

Re: Is ReviewBoard a good thing?

2014-09-19 Thread Jonathan Aquilina
Hey guys. Long time lurker with the occasional suggestion. I have an idea for something that might be beneficial to the project as a whole. Has it been considered about custom coding a review system that will interface with github hooks and provide what is needed to all juju dev's and keep t

Re: Is ReviewBoard a good thing?

2014-09-19 Thread Frank Mueller
Right now I'm a bit undecided, the usage of ReviewBoard is too fresh. But Jesse made good points and in general Im always happy when we're using less instead of using more tools. I can live with the number of mails, GMail does grouping them fine. And I started to add my comments after a first pass

Re: Is ReviewBoard a good thing?

2014-09-19 Thread Dimiter Naydenov
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 19.09.2014 03:32, David Cheney wrote: > There were three problem reviewboard was supposed to address, > review comments are sent immediately, no side by side diffs, and no > way to to chained proposals. > > I think that over the last few months we'

Fwd: Is ReviewBoard a good thing?

2014-09-19 Thread roger peppe
On 19 September 2014 01:32, David Cheney wrote: > There were three problem reviewboard was supposed to address, review > comments are sent immediately, no side by side diffs, and no way to to > chained proposals. > > I think that over the last few months we've all learnt to live with > the first i

Re: Is ReviewBoard a good thing?

2014-09-19 Thread roger peppe
On 19 September 2014 01:32, David Cheney wrote: > There were three problem reviewboard was supposed to address, review > comments are sent immediately, no side by side diffs, and no way to to > chained proposals. > > I think that over the last few months we've all learnt to live with > the first i