Re: Juju GUI handling of empty config breaks promulgated charms

2017-03-09 Thread Pete Vander Giessen
Hi All, Just a quick follow-up on this: both the gui and python-libjuju now use the "config-yaml" rather than the "config" parameter when deploying a bundle, which addresses the issue (provided you have an updated GUI or libjuju wherever you're performing the deploy, of course). ~ PeteVG On Thu,

Re: Juju GUI handling of empty config breaks promulgated charms

2017-02-23 Thread Pete Vander Giessen
On Thu, Feb 23, 2017 at 2:31 AM John Meinel wrote: > AFAICT we fixed this in Juju 1.15, but there are 2 places you can pass > config. The old field uses the compatibility of "" means nil, the new field > handles nil vs "" correctly. The Juju CLI should work correctly, it sounds > like the GUI was

Re: Juju GUI handling of empty config breaks promulgated charms

2017-02-22 Thread John Meinel
> > ... > > The ideal solution is of course to fix it in Juju, and have it stop > throwing away perfectly valid configuration data :) > > > AFAICT we fixed this in Juju 1.15, but there are 2 places you can pass config. The old field uses the compatibility of "" means nil, the new field handles nil

Re: Juju GUI handling of empty config breaks promulgated charms

2017-02-22 Thread Stuart Bishop
On 22 February 2017 at 22:45, Merlijn Sebrechts wrote: > This - is - awesome ! > > I guess this hack will still require a rebuild for the affected Charms? Other affected charms could use the same hack (patching charmhelpers.core.hookenv.config to convert nulls to ''), and would need to be rebuilt

Re: Juju GUI handling of empty config breaks promulgated charms

2017-02-22 Thread Merlijn Sebrechts
This - is - awesome ! I guess this hack will still require a rebuild for the affected Charms? 2017-02-22 16:41 GMT+01:00 Stuart Bishop : > On 21 February 2017 at 16:30, Merlijn Sebrechts > wrote: > > Thanks, Stuart! > > > > Now I get a different error. It seems that the charm really can't handl

Re: Juju GUI handling of empty config breaks promulgated charms

2017-02-22 Thread Stuart Bishop
On 21 February 2017 at 16:30, Merlijn Sebrechts wrote: > Thanks, Stuart! > > Now I get a different error. It seems that the charm really can't handle > null as a string value. Rather than comb through the charm updating all the call sites, I've made a hack to ensure config values never get return

Re: Juju GUI handling of empty config breaks promulgated charms

2017-02-21 Thread John Meinel
We have a code snippet in deploy that says this: if len(args.ConfigYAML) > 0 { settings, err = ch.Config().ParseSettingsYAML([]byte(args.ConfigYAML), args.ApplicationName) } else if len(args.Config) > 0 { // Parse config in a compatible way (see function comment). se

Re: Juju GUI handling of empty config breaks promulgated charms

2017-02-21 Thread Pete Vander Giessen
Hi All, There's a bug in core tracking this issue, here: https://bugs.launchpad.net/juju/+bug/1651260 You might want to leave some comments on the ticket, so people know that I'm not the only one running into it :-) (I believe that this affects the gui, matrix, and any other client that talks to

Re: Juju GUI handling of empty config breaks promulgated charms

2017-02-21 Thread Merlijn Sebrechts
Awesome, thanks! 2017-02-21 14:12 GMT+01:00 Stuart Bishop : > On 21 February 2017 at 16:44, Merlijn Sebrechts > wrote: > > PS: This bug was reported a few months ago by one of my colleagues, but > he > > didn't get a reply: https://bugs.launchpad.net/ > cassandra-charm/+bug/1645821 > > > > Is th

Re: Juju GUI handling of empty config breaks promulgated charms

2017-02-21 Thread Stuart Bishop
On 21 February 2017 at 16:44, Merlijn Sebrechts wrote: > PS: This bug was reported a few months ago by one of my colleagues, but he > didn't get a reply: https://bugs.launchpad.net/cassandra-charm/+bug/1645821 > > Is that the correct place to file bugs for the charm? Yes. I'm now correctly subscr

Re: Juju GUI handling of empty config breaks promulgated charms

2017-02-21 Thread Merlijn Sebrechts
PS: This bug was reported a few months ago by one of my colleagues, but he didn't get a reply: https://bugs.launchpad.net/cassandra-charm/+bug/1645821 Is that the correct place to file bugs for the charm? 2017-02-21 10:30 GMT+01:00 Merlijn Sebrechts : > Thanks, Stuart! > > > Now I get a differen

Re: Juju GUI handling of empty config breaks promulgated charms

2017-02-21 Thread Merlijn Sebrechts
Thanks, Stuart! Now I get a different error. It seems that the charm really can't handle null as a string value. unit-cassandra-a-0: 10:28:10 INFO unit.cassandra-a/0.install File "/var/lib/juju/agents/unit-cassandra-a-0/charm/hooks/install", line 20, in unit-cassandra-a-0: 10:28:10 INFO unit.

Re: Juju GUI handling of empty config breaks promulgated charms

2017-02-21 Thread Stuart Bishop
On 21 February 2017 at 00:40, Merlijn Sebrechts wrote: > Deploying cassandra with the GUI. Cassandra installation will fail with the > following error. > > KeyError: 'http_proxy' > > > The Cassandra charm expects config['http_proxy'] to return an empty string. > This is what happens when deploying