Questions/comments about better settings for aws deploys

2015-01-21 Thread Michael Nelson
Hi people, I'm just testing an ec2 juju deployment, and had a few questions about setup and default secgroups, which aren't addressed on the docs afaics [1] First, the docs assume that you'll put your primary (administrator) creds in your environment, which is easiest and works, but it would be s

[Review Queue] mysql x 3

2015-01-21 Thread Adam Israel
mysql - Follow up on changes I requested last week, this MP has added details about the backup feature to the README. +1 https://code.launchpad.net/~jacekn/charms/trusty/mysql/mysql-backups/+merge/245343 mysql - This MP introduces unit tests to the mysql charm. LGTM. +1 https://code.launchpad.

Re: Makefile target names

2015-01-21 Thread Benjamin Saller
While convention is great there is an additional path, you can if your project differs from the de facto standards, include an explicit list of targets in your tests/tests.yaml file makefile: - lint - unit_test - something_else That file allows customization of much of bundletesters p

Makefile target names

2015-01-21 Thread Ryan Beisner
Greetings, I'd like to invite discussion on Makefile target names. I've seen a few different takes on Makefile target naming conventions across charms. For example, in the OpenStack charms, `make test` runs amulet and `make unit_test` performs nose tests. In many/most other charms, `make test`

Re: An Open Question: Charm Dependency Management

2015-01-21 Thread Cory Johns
I think that it's important that we have tooling (i.e., bundletester) that sets up a (consistent) environment that is exactly the same as what the automated test runner uses (i.e., a fresh container or vm in which the tests are run) and that charm authors and reviewers alike use it. With that, the

Re: [Review Queue] wildfly charms

2015-01-21 Thread saurabh
Hi, Thanks for accepting my charms again in the charm store, it's good to see them there. I would like to thank Tim and Matt for their time and reviews, and this entire juju community for always being helpful. Miles to go. Cheers, Saurabh On Wednesday 21 January 2015 12:06 AM, Matt Bruzek wrot