Re: How do I enable -flto for Emacs nativecomp?

2024-03-07 Thread Antoni Boucher
It seems to me that you forgot to enable the lto frontend. Please add it to --enable-languages when configuring the gcc build. Le 2024-03-07 à 12 h 53, StrawberryTea a écrit : Hello libgccjit people, I'm trying to enable -flto for Emacs nativecomp. I have the following Emacs patch I am applying

Re: Frontend access to target features (was Re: [PATCH] libgccjit: Add ability to get CPU features)

2024-03-18 Thread Antoni Boucher
David: Ping. Le 2024-03-10 à 07 h 05, Iain Buclaw a écrit : Excerpts from David Malcolm's message of März 5, 2024 4:09 pm: On Thu, 2023-11-09 at 19:33 -0500, Antoni Boucher wrote: Hi. See answers below. On Thu, 2023-11-09 at 18:04 -0500, David Malcolm wrote: On Thu, 2023-11-09 at

Re: Frontend access to target features (was Re: [PATCH] libgccjit: Add ability to get CPU features)

2024-04-01 Thread Antoni Boucher
David: Ping. Le 2024-03-19 à 07 h 03, Arthur Cohen a écrit : Hi, On 3/5/24 16:09, David Malcolm wrote: On Thu, 2023-11-09 at 19:33 -0500, Antoni Boucher wrote: Hi. See answers below. On Thu, 2023-11-09 at 18:04 -0500, David Malcolm wrote: On Thu, 2023-11-09 at 17:27 -0500, Antoni Boucher

[PATCH] libgccjit: Add ability to get the alignment of a type

2024-04-04 Thread Antoni Boucher
Hi. This patch adds a new API to produce an rvalue representing the alignment of a type. Thanks for the review.From 12d8e57ca2313002da42672dc86b167baf812ff3 Mon Sep 17 00:00:00 2001 From: Antoni Boucher Date: Thu, 4 Apr 2024 18:57:07 -0400 Subject: [PATCH] libgccjit: Add ability to get the

Re: Frontend access to target features (was Re: [PATCH] libgccjit: Add ability to get CPU features)

2024-04-09 Thread Antoni Boucher
David: Ping. Le 2024-04-01 à 08 h 20, Antoni Boucher a écrit : David: Ping. Le 2024-03-19 à 07 h 03, Arthur Cohen a écrit : Hi, On 3/5/24 16:09, David Malcolm wrote: On Thu, 2023-11-09 at 19:33 -0500, Antoni Boucher wrote: Hi. See answers below. On Thu, 2023-11-09 at 18:04 -0500, David

Re: Frontend access to target features (was Re: [PATCH] libgccjit: Add ability to get CPU features)

2024-04-19 Thread Antoni Boucher
David: Ping. Le 2024-04-09 à 09 h 21, Antoni Boucher a écrit : David: Ping. Le 2024-04-01 à 08 h 20, Antoni Boucher a écrit : David: Ping. Le 2024-03-19 à 07 h 03, Arthur Cohen a écrit : Hi, On 3/5/24 16:09, David Malcolm wrote: On Thu, 2023-11-09 at 19:33 -0500, Antoni Boucher wrote: Hi

Re: [PATCH] libgccjit: Add support for machine-dependent builtins

2024-04-19 Thread Antoni Boucher
David: Ping. Le 2024-02-29 à 10 h 34, Antoni Boucher a écrit : David: Ping. On Thu, 2024-02-15 at 09:32 -0500, Antoni Boucher wrote: David: Ping On Thu, 2024-02-08 at 08:59 -0500, Antoni Boucher wrote: David: Ping. On Wed, 2024-01-10 at 18:58 -0500, Antoni Boucher wrote: Here it is: https

Re: [PATCH] Add rvalue::get_name method (and its C equivalent)

2024-04-22 Thread Antoni Boucher
Please move the function to be on lvalue since there are no rvalue types that are not lvalues that have a name. Le 2024-04-22 à 09 h 04, Guillaume Gomez a écrit : Hey Arthur :) Is there any reason for that getter to return a mutable pointer to the name? Would something like this work instead

Re: [PATCH] Add rvalue::get_name method (and its C equivalent)

2024-04-22 Thread Antoni Boucher
oint! New patch attached. Le lun. 22 avr. 2024 à 15:13, Antoni Boucher a écrit : Please move the function to be on lvalue since there are no rvalue types that are not lvalues that have a name. Le 2024-04-22 à 09 h 04, Guillaume Gomez a écrit : Hey Arthur :) Is there any reason for that getter to

Re: [PATCH] Add rvalue::get_name method (and its C equivalent)

2024-04-22 Thread Antoni Boucher
I believe you forgot to regenerate the ChangeLog. Le 2024-04-22 à 09 h 16, Guillaume Gomez a écrit : Good point! New patch attached. Le lun. 22 avr. 2024 à 15:13, Antoni Boucher a écrit : Please move the function to be on lvalue since there are no rvalue types that are not lvalues that

Re: Frontend access to target features (was Re: [PATCH] libgccjit: Add ability to get CPU features)

2024-04-26 Thread Antoni Boucher
gcc_jit_target_info_supports_128bit_int from this patch, or change it to include the more general way. David, what are your thoughts on this? Le 2024-04-19 à 08 h 34, Antoni Boucher a écrit : David: Ping. Le 2024-04-09 à 09 h 21, Antoni Boucher a écrit : David: Ping. Le 2024-04-01 à 08 h 20, Antoni

Re: Frontend access to target features (was Re: [PATCH] libgccjit: Add ability to get CPU features)

2024-06-12 Thread Antoni Boucher
David: Ping. Le 2024-04-26 à 09 h 51, Antoni Boucher a écrit : Now that we have a more general way to check if target-dependent types are supported (see this commit: https://github.com/rust-lang/gcc/commit/1c9a9b2f1fd914cad911467ec1d29f158643c2ce#diff

Re: [PATCH] libgccjit: Make new_array_type take unsigned long

2024-06-27 Thread Antoni Boucher
Thanks for the review. I'm a bit concerned about using unsigned long. Would it be OK if I change the type to uint64_t? I could rename the function to gcc_jit_context_new_array_type_u64. Regards. Le 2024-06-26 à 11 h 34, David Malcolm a écrit : On Fri, 2024-02-23 at 09:55 -0500, Antoni Bo

Re: [PATCH] libgccjit: Fix get_size of size_t

2024-06-27 Thread Antoni Boucher
Le 2024-06-26 à 18 h 01, David Malcolm a écrit : On Wed, 2024-02-21 at 14:16 -0500, Antoni Boucher wrote: On Thu, 2023-12-07 at 19:57 -0500, David Malcolm wrote: On Thu, 2023-12-07 at 17:26 -0500, Antoni Boucher wrote: Hi. This patch fixes getting the size of size_t (bug 112910). There&#

Re: [PATCH] libgccjit: Fix get_size of size_t

2024-07-18 Thread Antoni Boucher
David: Ping Le 2024-06-27 à 20 h 49, Antoni Boucher a écrit : Le 2024-06-26 à 18 h 01, David Malcolm a écrit : On Wed, 2024-02-21 at 14:16 -0500, Antoni Boucher wrote: On Thu, 2023-12-07 at 19:57 -0500, David Malcolm wrote: On Thu, 2023-12-07 at 17:26 -0500, Antoni Boucher wrote: Hi. This

Re: Frontend access to target features (was Re: [PATCH] libgccjit: Add ability to get CPU features)

2024-07-18 Thread Antoni Boucher
David: Ping. Le 2024-06-12 à 08 h 21, Antoni Boucher a écrit : David: Ping. Le 2024-04-26 à 09 h 51, Antoni Boucher a écrit : Now that we have a more general way to check if target-dependent types are supported (see this commit: https://github.com/rust-lang/gcc/commit

Re: [PATCH] libgccjit: Allow sending a const pointer as argument

2024-10-15 Thread Antoni Boucher
David: Ping. Le 2024-02-17 à 11 h 55, Antoni Boucher a écrit : David: Ping. On Fri, 2024-01-19 at 15:59 -0500, Antoni Boucher wrote: David: Ping. On Thu, 2023-12-21 at 11:59 -0500, Antoni Boucher wrote: Hi. This patch adds the ability to send const pointer as argument to a function. Thanks

Re: [PATCH] libgccjit: Add support for creating temporary variables

2024-10-11 Thread Antoni Boucher
Hi, David. Can you please review the updated patch? Can I merge it? Thanks. Le 2024-02-29 à 16 h 11, Antoni Boucher a écrit : Hi and thanks for the review! Here's the updated patch. Le 2024-01-24 à 09 h 54, David Malcolm a écrit : On Fri, 2024-01-19 at 16:54 -0500, Antoni Boucher wrote

Re: Frontend access to target features (was Re: [PATCH] libgccjit: Add ability to get CPU features)

2024-10-29 Thread Antoni Boucher
David: Arthur reviewed the gccrs patch and would be OK with it. Could you please take a look and review it? Le 2024-10-17 à 11 h 38, Antoni Boucher a écrit : Hi. Thanks for the review, David! I talked to Arthur and he's OK with having a file to include in both gccrs and libgccjit. I

Re: Frontend access to target features (was Re: [PATCH] libgccjit: Add ability to get CPU features)

2024-10-29 Thread Antoni Boucher
Thanks, David! Did you review the updated patch that depends on this gccrs patch? Is it also OK to merge when the PR in gccrs is merged? Le 2024-10-29 à 17 h 04, David Malcolm a écrit : On Tue, 2024-10-29 at 07:59 -0400, Antoni Boucher wrote: David: Arthur reviewed the gccrs patch and would

Re: [PATCH v3] [GCCJIT] support dynamic alloca stub

2024-11-11 Thread Antoni Boucher
Hi and thanks for the patch. I would rather avoid having to hard-code the types of built-in functions, especially since we can already access them via the function gcc_jit_context_get_target_builtin_function that is available in this patch: https://gcc.gnu.org/pipermail/jit/2023q4/001725.html

Re: Frontend access to target features (was Re: [PATCH] libgccjit: Add ability to get CPU features)

2024-10-17 Thread Antoni Boucher
55, David Malcolm a écrit : On Sun, 2024-03-10 at 12:05 +0100, Iain Buclaw wrote: Excerpts from David Malcolm's message of März 5, 2024 4:09 pm: On Thu, 2023-11-09 at 19:33 -0500, Antoni Boucher wrote: Hi. See answers below. On Thu, 2023-11-09 at 18:04 -0500, David Malcolm wrote: On Thu, 2023

Re: [PATCH] libgccjit: Add support for machine-dependent builtins

2024-11-29 Thread Antoni Boucher
Oh, nice. I'll send my future patches on the forgejo instance, then. Le 2024-11-20 à 17 h 35, Mark Wielaard a écrit : Hi Antoni, On Wed, Nov 20, 2024 at 11:11:01AM -0500, Antoni Boucher wrote: From what I understand, pull requests on forge.sourceware.org can be removed at any time,

Re: [PATCH] libgccjit: Add support for machine-dependent builtins

2024-11-20 Thread Antoni Boucher
Hi Mark. I've been following this forge experiment with great interest; thanks for doing this. I first created this GitHub repo as a way to keep track of the different status of my patches. From what I understand, pull requests on forge.sourceware.org can be removed at any time, so I could l

Re: [PATCH] libgccjit: Add support for machine-dependent builtins

2024-11-14 Thread Antoni Boucher
ew: https://github.com/antoyo/libgccjit/pull/5) Thanks. Le 2024-06-26 à 18 h 49, David Malcolm a écrit : On Thu, 2023-11-23 at 17:17 -0500, Antoni Boucher wrote: Hi. I did split the patch and sent one for the bfloat16 support and another one for the vector support. Here's the updated patch

Re: [PATCH] libgccjit: Fix crash on some targets

2024-12-05 Thread Antoni Boucher
Thanks for the review. See explanations and questions below. Le 2024-12-05 à 17 h 03, Andrew Pinski a écrit : On Thu, Dec 5, 2024 at 1:46 PM Antoni Boucher wrote: Hi. This is a patch for the bug 117886. I ran the jit tests on x86-64 and there are as much failures as on the master branch (4

[PATCH] aarch64: Fix ICE happening in SET_TYPE_VECTOR_SUBPARTS with libgccjit

2024-12-05 Thread Antoni Boucher
the review.From 9769e3749cf742b033ad26fd0869d136912d8758 Mon Sep 17 00:00:00 2001 From: Antoni Boucher Date: Wed, 4 Dec 2024 20:59:53 -0500 Subject: [PATCH] aarch64: Fix ICE happening in SET_TYPE_VECTOR_SUBPARTS with libgccjit The structure aarch64_simd_type_info was split in 2 because we do not wa

Re: [PATCH] aarch64: Fix ICE happening in SET_TYPE_VECTOR_SUBPARTS with libgccjit

2024-12-07 Thread Antoni Boucher
The patch was approved by Richard Sandiford on the forge (https://forge.sourceware.org/gcc/gcc-TEST/pulls/29#issuecomment-490). Le 2024-12-05 à 21 h 35, Antoni Boucher a écrit : Hi. This is a patch for the bug 117923. I'd like to know if there's a simpler fix for this. I tried keepi

[PATCH] libgccjit: Fix crash on some targets

2024-12-05 Thread Antoni Boucher
of a bunch of tests. Thanks for the review.From 4ea0377444f476f4cb1b5f07a3f92cf99d7e5af4 Mon Sep 17 00:00:00 2001 From: Antoni Boucher Date: Wed, 4 Dec 2024 19:38:38 -0500 Subject: [PATCH] libgccjit: Fix crash on some targets gcc/jit/ChangeLog: PR jit/117886 * dummy-frontend.cc: Return NULL_TREE

Re: [pushed: r15-7126] jit: fix startup on aarch64

2025-01-22 Thread Antoni Boucher
Hi David. I had a patch for this here: https://github.com/antoyo/libgccjit/pull/20 The fact that you removed the debug_tree (and abort) will make it harder to figure out what the missing types to handle are. This will also probably make it hard for people to understand why they get a type error

Re: [pushed: r15-7126] jit: fix startup on aarch64

2025-01-23 Thread Antoni Boucher
Le 2025-01-23 à 13 h 13, David Malcolm a écrit : On Wed, 2025-01-22 at 08:47 -0500, Antoni Boucher wrote: Hi David. Hi Antoni I went ahead and pushed this patch since without it even simple unit tests like test-factorial.c were failing for me on aarch64; in particular, the build of emacs

Re: Frontend access to target features (was Re: [PATCH] libgccjit: Add ability to get CPU features)

2025-03-21 Thread Antoni Boucher
Hi David. My gccrs patch was merged, so I was wondering if you could please review this patch again. It was also posted here on GitHub: https://github.com/antoyo/libgccjit/pull/6 Thanks. Le 29/10/2024 à 17:04, David Malcolm a écrit : On Tue, 2024-10-29 at 07:59 -0400, Antoni Boucher wrote

Re: [pushed: r15-7126] jit: fix startup on aarch64

2025-04-04 Thread Antoni Boucher
builtin functions. What are your thoughts on this? Regards. Le 23/01/2025 à 14:01, Antoni Boucher a écrit : Le 2025-01-23 à 13 h 13, David Malcolm a écrit : On Wed, 2025-01-22 at 08:47 -0500, Antoni Boucher wrote: Hi David. Hi Antoni I went ahead and pushed this patch since without it

Re: Unable to build libgccjit

2025-04-08 Thread Antoni Boucher
Hi. You're missing the flag --enable-host-shared. Also, it looks like you already do it, but make sure you build libgccjit out-of-tree (gcc cannot be build inside its source directory). Regards. Le 08/04/2025 à 06:18, Egor Sozonov a écrit : Hello, I'm having trouble building libgccjit from sou