Hi,
Random request...
On Tue, Nov 19, 2024 at 11:14:38AM -0500, David Malcolm wrote:
> > Here's the updated patch and answers below.
> >
> > (GitHub link if you find it easier for review:
> > https://github.com/antoyo/libgccjit/pull/5)
> >
> > Thanks.
>
> Thanks; I looked over the patch via t
On Thu, 2023-12-21 at 08:36 -0500, Antoni Boucher wrote:
> Hi.
> Here's the updated patch.
> Thanks.
Sorry for the delay in responding.
The updated patch is good for trunk - thanks!
Dave
>
> On Thu, 2023-12-07 at 20:15 -0500, David Malcolm wrote:
> > On Thu, 2023-12-07 at 17:34 -0500, Antoni B
On Thu, 2024-01-25 at 16:04 -0500, Antoni Boucher wrote:
> Thanks for the review!
> On Wed, 2024-01-24 at 13:10 -0500, David Malcolm wrote:
> > On Thu, 2024-01-11 at 18:42 -0500, Antoni Boucher wrote:
> > > Hi.
> > > This patch fixes the bug 113343.
> > > I'm wondering if there's a better solution
On Thu, 2023-11-30 at 17:16 -0500, Antoni Boucher wrote:
> All of these are fixed in this new patch.
> Thanks for the review.
Thanks for the updated patch.
I had said "OK with those fixed" on the older version and it looks like
you have indeed fixed the issues I noticed, so this updated patch is
On Thu, 2024-02-22 at 15:29 -0500, Antoni Boucher wrote:
> Thanks for the review and idea.
Thanks for the updated patch; sorry about the delay in reviewing.
>
> Here's the updated patch. I added a test, but I could not set -
> fsigned-
> char as this is not an option accepted by the jit frontend
On Thu, 2024-11-14 at 15:27 -0500, Antoni Boucher wrote:
> It seems we don't need to do the cleanup in i386-builtins.cc anymore,
> so
> I removed it.
> David: Is it possible that your recent fixes for the GC within
> libgccjit
> also fixed the issue here?
>
> Here's the updated patch and answers
