[GitHub] [kafka] brary commented on a change in pull request #9120: KAFKA-10316: Consider renaming getter method for Interactive Queries

brary commented on a change in pull request #9120: URL: https://github.com/apache/kafka/pull/9120#discussion_r465464182 ## File path: streams/src/main/java/org/apache/kafka/streams/KeyQueryMetadata.java ## @@ -50,32 +50,65 @@ public KeyQueryMetadata(final HostInfo activeHost, f

[GitHub] [kafka] brary commented on pull request #9120: KAFKA-10316: Consider renaming getter method for Interactive Queries

brary commented on pull request #9120: URL: https://github.com/apache/kafka/pull/9120#issuecomment-668972844 Thanks @johnthotekat for the PR. LGTM! This is an automated message from the Apache Git Service. To respond to the m

[GitHub] [kafka] abbccdda merged pull request #9124: MINOR: add additional shutdown log info

abbccdda merged pull request #9124: URL: https://github.com/apache/kafka/pull/9124 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [kafka] chia7712 opened a new pull request #9128: KAFKA-7540 reduce session timeout to evict dead member in time and so…

chia7712 opened a new pull request #9128: URL: https://github.com/apache/kafka/pull/9128 issue: https://issues.apache.org/jira/browse/KAFKA-7540 In short, the LEAVE_GROUP is sent to a shutdown broker so the dead member which is left in the group obstructs broker from completing rebal

[GitHub] [kafka] chia7712 commented on pull request #9128: KAFKA-7540 reduce session timeout to evict dead member in time and so…

chia7712 commented on pull request #9128: URL: https://github.com/apache/kafka/pull/9128#issuecomment-669020702 I have looped the test 40 times. all pass This is an automated message from the Apache Git Service. To respond to

[GitHub] [kafka] omkreddy commented on pull request #9050: KAFKA-10193: Add preemption for controller events that have callbacks

omkreddy commented on pull request #9050: URL: https://github.com/apache/kafka/pull/9050#issuecomment-669040004 ok to test This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [kafka] kowshik commented on a change in pull request #9001: KAFKA-10028: Implement write path for feature versioning system (KIP-584)

kowshik commented on a change in pull request #9001: URL: https://github.com/apache/kafka/pull/9001#discussion_r465565925 ## File path: core/src/main/scala/kafka/controller/KafkaController.scala ## @@ -266,6 +275,178 @@ class KafkaController(val config: KafkaConfig, } }

[GitHub] [kafka] kowshik commented on a change in pull request #9001: KAFKA-10028: Implement write path for feature versioning system (KIP-584)

kowshik commented on a change in pull request #9001: URL: https://github.com/apache/kafka/pull/9001#discussion_r463934710 ## File path: core/src/main/scala/kafka/controller/KafkaController.scala ## @@ -266,6 +275,179 @@ class KafkaController(val config: KafkaConfig, } }

[GitHub] [kafka] kowshik commented on a change in pull request #9001: KAFKA-10028: Implement write path for feature versioning system (KIP-584)

kowshik commented on a change in pull request #9001: URL: https://github.com/apache/kafka/pull/9001#discussion_r465570359 ## File path: core/src/main/scala/kafka/server/KafkaApis.scala ## @@ -2945,6 +2948,130 @@ class KafkaApis(val requestChannel: RequestChannel, } }

[GitHub] [kafka] kowshik commented on a change in pull request #9001: KAFKA-10028: Implement write path for feature versioning system (KIP-584)

kowshik commented on a change in pull request #9001: URL: https://github.com/apache/kafka/pull/9001#discussion_r465572011 ## File path: clients/src/main/resources/common/message/UpdateFeaturesResponse.json ## @@ -0,0 +1,33 @@ +// Licensed to the Apache Software Foundation (ASF)

[GitHub] [kafka] kowshik commented on a change in pull request #9001: KAFKA-10028: Implement write path for feature versioning system (KIP-584)

kowshik commented on a change in pull request #9001: URL: https://github.com/apache/kafka/pull/9001#discussion_r465572011 ## File path: clients/src/main/resources/common/message/UpdateFeaturesResponse.json ## @@ -0,0 +1,33 @@ +// Licensed to the Apache Software Foundation (ASF)

[GitHub] [kafka] kowshik commented on a change in pull request #9001: KAFKA-10028: Implement write path for feature versioning system (KIP-584)

kowshik commented on a change in pull request #9001: URL: https://github.com/apache/kafka/pull/9001#discussion_r465572011 ## File path: clients/src/main/resources/common/message/UpdateFeaturesResponse.json ## @@ -0,0 +1,33 @@ +// Licensed to the Apache Software Foundation (ASF)

[GitHub] [kafka] cmccabe commented on a change in pull request #9100: Add AlterISR RPC and use it for ISR modifications

cmccabe commented on a change in pull request #9100: URL: https://github.com/apache/kafka/pull/9100#discussion_r465708837 ## File path: core/src/main/scala/kafka/cluster/Partition.scala ## @@ -1212,17 +1221,32 @@ class Partition(val topicPartition: TopicPartition, private

[GitHub] [kafka] cmccabe commented on a change in pull request #9100: Add AlterISR RPC and use it for ISR modifications

cmccabe commented on a change in pull request #9100: URL: https://github.com/apache/kafka/pull/9100#discussion_r465711962 ## File path: core/src/main/scala/kafka/controller/KafkaController.scala ## @@ -1771,6 +1775,127 @@ class KafkaController(val config: KafkaConfig, }

[GitHub] [kafka] dongjinleekr commented on pull request #8117: KAFKA-8403: Suppress needs a Materialized variant

dongjinleekr commented on pull request #8117: URL: https://github.com/apache/kafka/pull/8117#issuecomment-669182284 Hello. I updated the [KIP](https://cwiki.apache.org/confluence/display/KAFKA/KIP-508%3A+Make+Suppression+State+Queriable) and rebased the PR onto the latest trunk. Please hav

[GitHub] [kafka] cmccabe commented on a change in pull request #9100: Add AlterISR RPC and use it for ISR modifications

cmccabe commented on a change in pull request #9100: URL: https://github.com/apache/kafka/pull/9100#discussion_r465712943 ## File path: core/src/main/scala/kafka/server/BrokerToControllerChannelManager.scala ## @@ -113,8 +113,8 @@ class BrokerToControllerChannelManager(metadat

[GitHub] [kafka] cmccabe commented on a change in pull request #9100: Add AlterISR RPC and use it for ISR modifications

cmccabe commented on a change in pull request #9100: URL: https://github.com/apache/kafka/pull/9100#discussion_r465715770 ## File path: core/src/main/scala/kafka/server/AlterIsrChannelManager.scala ## @@ -0,0 +1,121 @@ +package kafka.server Review comment: It would be g

[GitHub] [kafka] dongjinleekr commented on pull request #7898: KAFKA-9366: Change log4j dependency into log4j2

dongjinleekr commented on pull request #7898: URL: https://github.com/apache/kafka/pull/7898#issuecomment-669229785 Here is the KIP - [KIP-653: Upgrade log4j to log4j2](https://cwiki.apache.org/confluence/display/KAFKA/KIP-653%3A+Upgrade+log4j+to+log4j2) @omkreddy Could you have a lo

[GitHub] [kafka] lct45 commented on a change in pull request #9039: KAFKA-5636: SlidingWindows (KIP-450)

lct45 commented on a change in pull request #9039: URL: https://github.com/apache/kafka/pull/9039#discussion_r465756356 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamSlidingWindowAggregate.java ## @@ -0,0 +1,391 @@ +/* + * Licensed to th

[GitHub] [kafka] ijuma commented on pull request #9129: MINOR: Update jmh to 1.24 for async profiler support

ijuma commented on pull request #9129: URL: https://github.com/apache/kafka/pull/9129#issuecomment-669221375 Actually, it looks like I need to improve the jmh script to make this easier to use. Will also update the README. So, please don't review it yet. --

[GitHub] [kafka] mumrah commented on a change in pull request #9100: Add AlterISR RPC and use it for ISR modifications

mumrah commented on a change in pull request #9100: URL: https://github.com/apache/kafka/pull/9100#discussion_r465743922 ## File path: core/src/main/scala/kafka/controller/KafkaController.scala ## @@ -1771,6 +1775,127 @@ class KafkaController(val config: KafkaConfig, }

[GitHub] [kafka] rondagostino commented on a change in pull request #9032: KAFKA-10259: KIP-554 Broker-side SCRAM Config API

rondagostino commented on a change in pull request #9032: URL: https://github.com/apache/kafka/pull/9032#discussion_r465744271 ## File path: clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java ## @@ -4071,6 +4081,168 @@ void handleFailure(Throwable throw

[GitHub] [kafka] johnthotekat commented on pull request #9120: KAFKA-10316: Consider renaming getter method for Interactive Queries

johnthotekat commented on pull request #9120: URL: https://github.com/apache/kafka/pull/9120#issuecomment-669241684 @mjsax One of the test failed for me in local, This one - KafkaAdminClientTest#testMetadataRetries. It's unrelated to the changes in this PR. Rest of the tests PASSED

[GitHub] [kafka] johnthotekat edited a comment on pull request #9120: KAFKA-10316: Consider renaming getter method for Interactive Queries

johnthotekat edited a comment on pull request #9120: URL: https://github.com/apache/kafka/pull/9120#issuecomment-669241684 @mjsax One of the test failed for me in local, This one - KafkaAdminClientTest#testMetadataRetries. It's unrelated to the changes in this PR. Rest of the tests

[GitHub] [kafka] mumrah commented on a change in pull request #9100: Add AlterISR RPC and use it for ISR modifications

mumrah commented on a change in pull request #9100: URL: https://github.com/apache/kafka/pull/9100#discussion_r465746162 ## File path: core/src/main/scala/kafka/controller/KafkaController.scala ## @@ -1771,6 +1776,141 @@ class KafkaController(val config: KafkaConfig, }

[GitHub] [kafka] ijuma opened a new pull request #9129: MINOR: Update jmh to 1.24 for async profiler support

ijuma opened a new pull request #9129: URL: https://github.com/apache/kafka/pull/9129 Highlights: * async-profiler integration. Can be used with -prof async, pass -prof async:help to look for the accepted options. * perf c2c [2] integration. Can be used with -prof perfc2c, if

[GitHub] [kafka] johnthotekat edited a comment on pull request #9120: KAFKA-10316: Consider renaming getter method for Interactive Queries

johnthotekat edited a comment on pull request #9120: URL: https://github.com/apache/kafka/pull/9120#issuecomment-669241684 @mjsax One of the test failed for me in local, This one - KafkaAdminClientTest#testMetadataRetries. It's unrelated to the changes in this PR. Rest of the tests

[GitHub] [kafka] mumrah commented on a change in pull request #9100: Add AlterISR RPC and use it for ISR modifications

mumrah commented on a change in pull request #9100: URL: https://github.com/apache/kafka/pull/9100#discussion_r465748504 ## File path: core/src/main/scala/kafka/server/AlterIsrChannelManager.scala ## @@ -0,0 +1,121 @@ +package kafka.server Review comment: Yea, maybe jus

[GitHub] [kafka] mumrah commented on a change in pull request #9100: Add AlterISR RPC and use it for ISR modifications

mumrah commented on a change in pull request #9100: URL: https://github.com/apache/kafka/pull/9100#discussion_r465748120 ## File path: core/src/main/scala/kafka/controller/KafkaController.scala ## @@ -1771,6 +1776,141 @@ class KafkaController(val config: KafkaConfig, }

[GitHub] [kafka] mumrah commented on a change in pull request #9100: Add AlterISR RPC and use it for ISR modifications

mumrah commented on a change in pull request #9100: URL: https://github.com/apache/kafka/pull/9100#discussion_r465749546 ## File path: core/src/main/scala/kafka/server/AlterIsrChannelManager.scala ## @@ -0,0 +1,132 @@ +package kafka.server + +import java.util +import java.util.

[GitHub] [kafka] mumrah commented on a change in pull request #9100: Add AlterISR RPC and use it for ISR modifications

mumrah commented on a change in pull request #9100: URL: https://github.com/apache/kafka/pull/9100#discussion_r465749546 ## File path: core/src/main/scala/kafka/server/AlterIsrChannelManager.scala ## @@ -0,0 +1,132 @@ +package kafka.server + +import java.util +import java.util.

[GitHub] [kafka] mumrah commented on a change in pull request #9100: Add AlterISR RPC and use it for ISR modifications

mumrah commented on a change in pull request #9100: URL: https://github.com/apache/kafka/pull/9100#discussion_r465750445 ## File path: core/src/main/scala/kafka/server/AlterIsrChannelManager.scala ## @@ -0,0 +1,132 @@ +package kafka.server + +import java.util +import java.util.

[GitHub] [kafka] mumrah commented on a change in pull request #9100: Add AlterISR RPC and use it for ISR modifications

mumrah commented on a change in pull request #9100: URL: https://github.com/apache/kafka/pull/9100#discussion_r465750632 ## File path: core/src/main/scala/kafka/server/AlterIsrChannelManager.scala ## @@ -0,0 +1,132 @@ +package kafka.server + +import java.util +import java.util.

[GitHub] [kafka] rondagostino commented on a change in pull request #9032: KAFKA-10259: KIP-554 Broker-side SCRAM Config API

rondagostino commented on a change in pull request #9032: URL: https://github.com/apache/kafka/pull/9032#discussion_r465751005 ## File path: clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java ## @@ -4071,6 +4081,168 @@ void handleFailure(Throwable throw

[GitHub] [kafka] lct45 commented on a change in pull request #9039: KAFKA-5636: SlidingWindows (KIP-450)

lct45 commented on a change in pull request #9039: URL: https://github.com/apache/kafka/pull/9039#discussion_r465751597 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamSlidingWindowAggregate.java ## @@ -0,0 +1,391 @@ +/* + * Licensed to th

[GitHub] [kafka] hachikuji opened a new pull request #9130: [DRAFT] Kafka Raft Implementation (KIP-595)

hachikuji opened a new pull request #9130: URL: https://github.com/apache/kafka/pull/9130 This is a draft of the changes needed for KIP-595. The draft tag will be removed in the upcoming weeks if/when the KIP is adopted. Note that there are still a few significant protocol differences from

[GitHub] [kafka] mumrah commented on pull request #7222: KAFKA-8806 Reduce calls to validateOffsetsIfNeeded

mumrah commented on pull request #7222: URL: https://github.com/apache/kafka/pull/7222#issuecomment-669259920 Reviving this PR cc @hachikuji @ijuma @andrewchoi5 This is an automated message from the Apache Git Service. To re

[GitHub] [kafka] junrao commented on a change in pull request #8657: KAFKA-8334 Make sure the thread which tries to complete delayed reque…

junrao commented on a change in pull request #8657: URL: https://github.com/apache/kafka/pull/8657#discussion_r465867406 ## File path: core/src/main/scala/kafka/coordinator/group/GroupCoordinator.scala ## @@ -369,6 +370,32 @@ class GroupCoordinator(val brokerId: Int, }

[GitHub] [kafka] guozhangwang commented on pull request #8964: KAFKA-9450: Decouple flushing state from commiting

guozhangwang commented on pull request #8964: URL: https://github.com/apache/kafka/pull/8964#issuecomment-669308138 System test green: https://jenkins.confluent.io/job/system-test-kafka-branch-builder/4093/ Ready for a final review and merge cc @mjsax -

[GitHub] [kafka] dielhennr commented on a change in pull request #9101: KAFKA-10325: KIP-649 implementation

dielhennr commented on a change in pull request #9101: URL: https://github.com/apache/kafka/pull/9101#discussion_r465867372 ## File path: clients/src/main/java/org/apache/kafka/clients/consumer/internals/DynamicConsumerConfig.java ## @@ -0,0 +1,168 @@ +/* + * Licensed to the A

[GitHub] [kafka] guozhangwang commented on pull request #9127: MINOR: fix HTML

guozhangwang commented on pull request #9127: URL: https://github.com/apache/kafka/pull/9127#issuecomment-669320718 LGTM! This is an automated message from the Apache Git Service. To respond to the message, please log on to G

[GitHub] [kafka] guozhangwang commented on pull request #9127: MINOR: fix HTML

guozhangwang commented on pull request #9127: URL: https://github.com/apache/kafka/pull/9127#issuecomment-669320891 The kafka-site has already been updated, so yes you do need to have a separate PR for it :P This is an autom

[GitHub] [kafka] dajac commented on a change in pull request #9114: KAFKA-10162; Use Token Bucket algorithm for controller mutation quota (KIP-599, Part III)

dajac commented on a change in pull request #9114: URL: https://github.com/apache/kafka/pull/9114#discussion_r465886919 ## File path: clients/src/test/java/org/apache/kafka/common/metrics/SensorTest.java ## @@ -209,4 +212,95 @@ public void shouldReturnPresenceOfMetrics() {

[GitHub] [kafka] dajac commented on a change in pull request #9114: KAFKA-10162; Use Token Bucket algorithm for controller mutation quota (KIP-599, Part III)

dajac commented on a change in pull request #9114: URL: https://github.com/apache/kafka/pull/9114#discussion_r46517 ## File path: clients/src/test/java/org/apache/kafka/common/metrics/SensorTest.java ## @@ -209,4 +212,95 @@ public void shouldReturnPresenceOfMetrics() {

[GitHub] [kafka] dajac commented on a change in pull request #9114: KAFKA-10162; Use Token Bucket algorithm for controller mutation quota (KIP-599, Part III)

dajac commented on a change in pull request #9114: URL: https://github.com/apache/kafka/pull/9114#discussion_r465889286 ## File path: core/src/main/scala/kafka/server/ControllerMutationQuotaManager.scala ## @@ -156,6 +174,24 @@ class ControllerMutationQuotaManager(private val c

[GitHub] [kafka] dajac commented on a change in pull request #9114: KAFKA-10162; Use Token Bucket algorithm for controller mutation quota (KIP-599, Part III)

dajac commented on a change in pull request #9114: URL: https://github.com/apache/kafka/pull/9114#discussion_r465889447 ## File path: clients/src/main/java/org/apache/kafka/common/metrics/stats/TokenBucket.java ## @@ -0,0 +1,87 @@ +/* + * Licensed to the Apache Software Founda

[GitHub] [kafka] dajac commented on a change in pull request #9114: KAFKA-10162; Use Token Bucket algorithm for controller mutation quota (KIP-599, Part III)

dajac commented on a change in pull request #9114: URL: https://github.com/apache/kafka/pull/9114#discussion_r465889824 ## File path: clients/src/main/java/org/apache/kafka/common/metrics/stats/TokenBucket.java ## @@ -0,0 +1,87 @@ +/* + * Licensed to the Apache Software Founda

[GitHub] [kafka] kkonstantine closed pull request #8513: MINOR: jackson 2.10.3

kkonstantine closed pull request #8513: URL: https://github.com/apache/kafka/pull/8513 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [kafka] kkonstantine commented on pull request #8513: MINOR: jackson 2.10.3

kkonstantine commented on pull request #8513: URL: https://github.com/apache/kafka/pull/8513#issuecomment-669328325 Closing here in favor of https://github.com/apache/kafka/pull/9058 Thanks for suggesting the version upgrade @sullis -

[GitHub] [kafka] junrao commented on pull request #8657: KAFKA-8334 Make sure the thread which tries to complete delayed reque…

junrao commented on pull request #8657: URL: https://github.com/apache/kafka/pull/8657#issuecomment-669330984 @chia7712 : The following is my thought after thinking about this a bit more. The changes that we made in DelayedJoin is complicated and it still doesn't completely solve the deadl

[GitHub] [kafka] dajac commented on pull request #9114: KAFKA-10162; Use Token Bucket algorithm for controller mutation quota (KIP-599, Part III)

dajac commented on pull request #9114: URL: https://github.com/apache/kafka/pull/9114#issuecomment-669343564 @junrao Thanks for your comments. I just pushed an update which addressed them. This is an automated message from t

[GitHub] [kafka] mumrah edited a comment on pull request #7222: KAFKA-8806 Reduce calls to validateOffsetsIfNeeded

mumrah edited a comment on pull request #7222: URL: https://github.com/apache/kafka/pull/7222#issuecomment-669345762  Failed run https://builds.apache.org/job/kafka-pr-jdk14-sca

[GitHub] [kafka] mumrah commented on pull request #7222: KAFKA-8806 Reduce calls to validateOffsetsIfNeeded

mumrah commented on pull request #7222: URL: https://github.com/apache/kafka/pull/7222#issuecomment-669345762  Th

[GitHub] [kafka] mumrah commented on pull request #7222: KAFKA-8806 Reduce calls to validateOffsetsIfNeeded

mumrah commented on pull request #7222: URL: https://github.com/apache/kafka/pull/7222#issuecomment-669345934 retest this please This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [kafka] dielhennr commented on a change in pull request #9101: KAFKA-10325: KIP-649 implementation

dielhennr commented on a change in pull request #9101: URL: https://github.com/apache/kafka/pull/9101#discussion_r465907401 ## File path: clients/src/main/java/org/apache/kafka/clients/consumer/internals/DynamicConsumerConfig.java ## @@ -0,0 +1,168 @@ +/* + * Licensed to the A

[GitHub] [kafka] dajac commented on a change in pull request #9103: Add redirection for (Incremental)AlterConfig

dajac commented on a change in pull request #9103: URL: https://github.com/apache/kafka/pull/9103#discussion_r465908873 ## File path: core/src/main/scala/kafka/server/KafkaApis.scala ## @@ -2982,12 +3089,33 @@ class KafkaApis(val requestChannel: RequestChannel,

[GitHub] [kafka] junrao commented on a change in pull request #9114: KAFKA-10162; Use Token Bucket algorithm for controller mutation quota (KIP-599, Part III)

junrao commented on a change in pull request #9114: URL: https://github.com/apache/kafka/pull/9114#discussion_r465921001 ## File path: clients/src/test/java/org/apache/kafka/common/metrics/TokenBucketTest.java ## @@ -0,0 +1,93 @@ +/* + * Licensed to the Apache Software Foundat

[GitHub] [kafka] junrao commented on pull request #9114: KAFKA-10162; Use Token Bucket algorithm for controller mutation quota (KIP-599, Part III)

junrao commented on pull request #9114: URL: https://github.com/apache/kafka/pull/9114#issuecomment-669378432 ok to test This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

[GitHub] [kafka] dhruvilshah3 commented on a change in pull request #9110: MINOR: Ensure a reason is logged for all segment deletion operations

dhruvilshah3 commented on a change in pull request #9110: URL: https://github.com/apache/kafka/pull/9110#discussion_r465939741 ## File path: core/src/main/scala/kafka/log/Log.scala ## @@ -2227,14 +2210,17 @@ class Log(@volatile private var _dir: File, * @param segments The

[GitHub] [kafka] dielhennr commented on a change in pull request #9101: KAFKA-10325: KIP-649 implementation

dielhennr commented on a change in pull request #9101: URL: https://github.com/apache/kafka/pull/9101#discussion_r465907401 ## File path: clients/src/main/java/org/apache/kafka/clients/consumer/internals/DynamicConsumerConfig.java ## @@ -0,0 +1,168 @@ +/* + * Licensed to the A

[GitHub] [kafka] rajinisivaram commented on a change in pull request #9032: KAFKA-10259: KIP-554 Broker-side SCRAM Config API

rajinisivaram commented on a change in pull request #9032: URL: https://github.com/apache/kafka/pull/9032#discussion_r465952166 ## File path: core/src/main/scala/kafka/admin/ConfigCommand.scala ## @@ -508,7 +563,15 @@ object ConfigCommand extends Config { val entityStr

[GitHub] [kafka] dajac commented on a change in pull request #9114: KAFKA-10162; Use Token Bucket algorithm for controller mutation quota (KIP-599, Part III)

dajac commented on a change in pull request #9114: URL: https://github.com/apache/kafka/pull/9114#discussion_r465968369 ## File path: clients/src/test/java/org/apache/kafka/common/metrics/SensorTest.java ## @@ -209,4 +212,95 @@ public void shouldReturnPresenceOfMetrics() {

[GitHub] [kafka] dajac commented on pull request #9114: KAFKA-10162; Use Token Bucket algorithm for controller mutation quota (KIP-599, Part III)

dajac commented on pull request #9114: URL: https://github.com/apache/kafka/pull/9114#issuecomment-669465274 @junrao Thanks. I have updated the PR. This is an automated message from the Apache Git Service. To respond to the m

[GitHub] [kafka] guozhangwang commented on a change in pull request #9047: KAFKA-9274: Remove `retries` for global task

guozhangwang commented on a change in pull request #9047: URL: https://github.com/apache/kafka/pull/9047#discussion_r465923769 ## File path: docs/streams/developer-guide/config-streams.html ## @@ -326,13 +321,18 @@ bootstrap.serversstate.cleanup.delay.ms Low

[GitHub] [kafka] mjsax merged pull request #9126: MINOR: Code cleanup in StreamsResetter

mjsax merged pull request #9126: URL: https://github.com/apache/kafka/pull/9126 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [kafka] junrao commented on a change in pull request #9114: KAFKA-10162; Use Token Bucket algorithm for controller mutation quota (KIP-599, Part III)

junrao commented on a change in pull request #9114: URL: https://github.com/apache/kafka/pull/9114#discussion_r465989800 ## File path: clients/src/main/java/org/apache/kafka/common/metrics/stats/TokenBucket.java ## @@ -0,0 +1,101 @@ +/* + * Licensed to the Apache Software Foun

[GitHub] [kafka] mjsax commented on pull request #9127: MINOR: fix HTML

mjsax commented on pull request #9127: URL: https://github.com/apache/kafka/pull/9127#issuecomment-669498317 Found one more tiny issue. Will merge if no objections raise. kafka-site PR: https://github.com/apache/kafka-site/pull/283 ---

[GitHub] [kafka] junrao commented on pull request #9114: KAFKA-10162; Use Token Bucket algorithm for controller mutation quota (KIP-599, Part III)

junrao commented on pull request #9114: URL: https://github.com/apache/kafka/pull/9114#issuecomment-669499409 ok to test This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

[GitHub] [kafka] junrao commented on pull request #9114: KAFKA-10162; Use Token Bucket algorithm for controller mutation quota (KIP-599, Part III)

junrao commented on pull request #9114: URL: https://github.com/apache/kafka/pull/9114#issuecomment-669499767 retest this please This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [kafka] junrao commented on pull request #9114: KAFKA-10162; Use Token Bucket algorithm for controller mutation quota (KIP-599, Part III)

junrao commented on pull request #9114: URL: https://github.com/apache/kafka/pull/9114#issuecomment-669500012 test this please This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [kafka] mjsax merged pull request #9067: MINOR: Streams integration tests should not call exit

mjsax merged pull request #9067: URL: https://github.com/apache/kafka/pull/9067 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [kafka] dajac commented on a change in pull request #9114: KAFKA-10162; Use Token Bucket algorithm for controller mutation quota (KIP-599, Part III)

dajac commented on a change in pull request #9114: URL: https://github.com/apache/kafka/pull/9114#discussion_r465997810 ## File path: clients/src/main/java/org/apache/kafka/common/metrics/stats/TokenBucket.java ## @@ -0,0 +1,101 @@ +/* + * Licensed to the Apache Software Found

[GitHub] [kafka] dajac commented on a change in pull request #9114: KAFKA-10162; Use Token Bucket algorithm for controller mutation quota (KIP-599, Part III)

dajac commented on a change in pull request #9114: URL: https://github.com/apache/kafka/pull/9114#discussion_r465997624 ## File path: clients/src/main/java/org/apache/kafka/common/metrics/stats/TokenBucket.java ## @@ -0,0 +1,101 @@ +/* + * Licensed to the Apache Software Found

[GitHub] [kafka] abbccdda commented on a change in pull request #9060: KAFKA-9274: Remove `retries` from InternalTopicManager

abbccdda commented on a change in pull request #9060: URL: https://github.com/apache/kafka/pull/9060#discussion_r465999685 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamsPartitionAssignor.java ## @@ -373,8 +373,15 @@ public GroupAssignm

[GitHub] [kafka] mjsax commented on pull request #9067: MINOR: Streams integration tests should not call exit

mjsax commented on pull request #9067: URL: https://github.com/apache/kafka/pull/9067#issuecomment-669509500 Merged to `trunk` and cherry-picked to `2.6` branch. This is an automated message from the Apache Git Service. To re

[GitHub] [kafka] junrao commented on pull request #9114: KAFKA-10162; Use Token Bucket algorithm for controller mutation quota (KIP-599, Part III)

junrao commented on pull request #9114: URL: https://github.com/apache/kafka/pull/9114#issuecomment-669510023 test this please This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [kafka] junrao commented on pull request #9114: KAFKA-10162; Use Token Bucket algorithm for controller mutation quota (KIP-599, Part III)

junrao commented on pull request #9114: URL: https://github.com/apache/kafka/pull/9114#issuecomment-669509903 retest this please This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [kafka] dajac commented on pull request #9114: KAFKA-10162; Use Token Bucket algorithm for controller mutation quota (KIP-599, Part III)

dajac commented on pull request #9114: URL: https://github.com/apache/kafka/pull/9114#issuecomment-669512698 Sure. I will update the KIP and the mailing list tomorrow. Thanks, Jun! This is an automated message from the Apache

[GitHub] [kafka] mjsax commented on a change in pull request #9060: KAFKA-9274: Remove `retries` from InternalTopicManager

mjsax commented on a change in pull request #9060: URL: https://github.com/apache/kafka/pull/9060#discussion_r466006589 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamsPartitionAssignor.java ## @@ -373,8 +373,15 @@ public GroupAssignment

[GitHub] [kafka] mjsax merged pull request #9047: KAFKA-9274: Remove `retries` for global task

mjsax merged pull request #9047: URL: https://github.com/apache/kafka/pull/9047 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [kafka] mjsax commented on pull request #9120: KAFKA-10316: Consider renaming getter method for Interactive Queries

mjsax commented on pull request #9120: URL: https://github.com/apache/kafka/pull/9120#issuecomment-669529543 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [kafka] mjsax commented on pull request #9120: KAFKA-10316: Consider renaming getter method for Interactive Queries

mjsax commented on pull request #9120: URL: https://github.com/apache/kafka/pull/9120#issuecomment-669530846 Retest this please. This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [kafka] mjsax edited a comment on pull request #9120: KAFKA-10316: Consider renaming getter method for Interactive Queries

mjsax edited a comment on pull request #9120: URL: https://github.com/apache/kafka/pull/9120#issuecomment-669529543 @johnthotekat Some testa are know to be flaky and we try to work on them to avoid those build issues. It's constant effort to keep the build stable. Will trigger a new Jenkin

[GitHub] [kafka] mjsax edited a comment on pull request #9120: KAFKA-10316: Consider renaming getter method for Interactive Queries

mjsax edited a comment on pull request #9120: URL: https://github.com/apache/kafka/pull/9120#issuecomment-669529543 @johnthotekat Some testa are know to be flaky and we try to work on them to avoid those build issues. It's constant effort to keep the build stable. Will trigger a new Jenkin

[GitHub] [kafka] mjsax commented on pull request #9120: KAFKA-10316: Consider renaming getter method for Interactive Queries

mjsax commented on pull request #9120: URL: https://github.com/apache/kafka/pull/9120#issuecomment-669531291 Retest this please. This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [kafka] mjsax commented on pull request #9120: KAFKA-10316: Consider renaming getter method for Interactive Queries

mjsax commented on pull request #9120: URL: https://github.com/apache/kafka/pull/9120#issuecomment-669531898 I'll try again later... Jenkins seems to be on holidays... This is an automated message from the Apache Git Service.

[GitHub] [kafka] mjsax commented on pull request #9120: KAFKA-10316: Consider renaming getter method for Interactive Queries

mjsax commented on pull request #9120: URL: https://github.com/apache/kafka/pull/9120#issuecomment-669531710 Ok to test. This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

[GitHub] [kafka] mjsax commented on a change in pull request #9039: KAFKA-5636: SlidingWindows (KIP-450)

mjsax commented on a change in pull request #9039: URL: https://github.com/apache/kafka/pull/9039#discussion_r466026007 ## File path: streams/src/test/java/org/apache/kafka/streams/integration/KStreamAggregationIntegrationTest.java ## @@ -459,6 +460,95 @@ public void shouldGro

[GitHub] [kafka] mjsax commented on a change in pull request #9039: KAFKA-5636: SlidingWindows (KIP-450)

mjsax commented on a change in pull request #9039: URL: https://github.com/apache/kafka/pull/9039#discussion_r466029116 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/CogroupedKStream.java ## @@ -275,6 +275,15 @@ */ TimeWindowedCogroupedKStrea

[GitHub] [kafka] mjsax commented on a change in pull request #9039: KAFKA-5636: SlidingWindows (KIP-450)

mjsax commented on a change in pull request #9039: URL: https://github.com/apache/kafka/pull/9039#discussion_r466028866 ## File path: streams/src/test/java/org/apache/kafka/streams/integration/KStreamAggregationIntegrationTest.java ## @@ -459,6 +460,95 @@ public void shouldGro

[GitHub] [kafka] abbccdda commented on a change in pull request #9060: KAFKA-9274: Remove `retries` from InternalTopicManager

abbccdda commented on a change in pull request #9060: URL: https://github.com/apache/kafka/pull/9060#discussion_r466031487 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamsPartitionAssignor.java ## @@ -373,8 +373,15 @@ public GroupAssignm

[GitHub] [kafka] mjsax commented on a change in pull request #9039: KAFKA-5636: SlidingWindows (KIP-450)

mjsax commented on a change in pull request #9039: URL: https://github.com/apache/kafka/pull/9039#discussion_r466032331 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/CogroupedStreamAggregateBuilder.java ## @@ -132,16 +135,19 @@

[GitHub] [kafka] mjsax commented on a change in pull request #9039: KAFKA-5636: SlidingWindows (KIP-450)

mjsax commented on a change in pull request #9039: URL: https://github.com/apache/kafka/pull/9039#discussion_r466032804 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamSlidingWindowAggregate.java ## @@ -0,0 +1,389 @@ +/* + * Licensed to th

[GitHub] [kafka] mjsax commented on a change in pull request #9039: KAFKA-5636: SlidingWindows (KIP-450)

mjsax commented on a change in pull request #9039: URL: https://github.com/apache/kafka/pull/9039#discussion_r466033381 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/SlidingWindows.java ## @@ -0,0 +1,141 @@ +/* + * Licensed to the Apache Software Foundat

[GitHub] [kafka] abbccdda commented on a change in pull request #9102: KAFKA-10326 Both serializer and deserializer should be able to see th…

abbccdda commented on a change in pull request #9102: URL: https://github.com/apache/kafka/pull/9102#discussion_r466034541 ## File path: clients/src/test/java/org/apache/kafka/clients/consumer/KafkaConsumerTest.java ## @@ -2511,4 +2511,39 @@ public void testEnforceRebalanceTr

[GitHub] [kafka] hachikuji commented on pull request #9110: MINOR: Ensure a reason is logged for all segment deletion operations

hachikuji commented on pull request #9110: URL: https://github.com/apache/kafka/pull/9110#issuecomment-669552517 retest this please This is an automated message from the Apache Git Service. To respond to the message, please l

[GitHub] [kafka] hachikuji commented on pull request #9110: MINOR: Ensure a reason is logged for all segment deletion operations

hachikuji commented on pull request #9110: URL: https://github.com/apache/kafka/pull/9110#issuecomment-669552682 retest this please This is an automated message from the Apache Git Service. To respond to the message, please l

[GitHub] [kafka] lct45 commented on a change in pull request #9039: KAFKA-5636: SlidingWindows (KIP-450)

lct45 commented on a change in pull request #9039: URL: https://github.com/apache/kafka/pull/9039#discussion_r466042505 ## File path: streams/src/test/java/org/apache/kafka/streams/integration/KStreamAggregationIntegrationTest.java ## @@ -459,6 +460,95 @@ public void shouldGro

[GitHub] [kafka] ableegoldman commented on a change in pull request #9039: KAFKA-5636: SlidingWindows (KIP-450)

ableegoldman commented on a change in pull request #9039: URL: https://github.com/apache/kafka/pull/9039#discussion_r466050097 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamSlidingWindowAggregate.java ## @@ -0,0 +1,428 @@ +/* + * License

[GitHub] [kafka] ableegoldman commented on a change in pull request #9039: KAFKA-5636: SlidingWindows (KIP-450)

ableegoldman commented on a change in pull request #9039: URL: https://github.com/apache/kafka/pull/9039#discussion_r466051779 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamSlidingWindowAggregate.java ## @@ -0,0 +1,391 @@ +/* + * License

<    2   3   4   5   6   7   8   9   10   11   >