cadonna opened a new pull request #9098:
URL: https://github.com/apache/kafka/pull/9098
This PR refactors the RocksDB store and the metrics infrastructure in
Streams
in preparation of the recordings of the RocksDB properties specified in
KIP-607.
The refactoring includes:
- w
chia7712 commented on pull request #9097:
URL: https://github.com/apache/kafka/pull/9097#issuecomment-665504521
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and u
cmccabe commented on a change in pull request #9012:
URL: https://github.com/apache/kafka/pull/9012#discussion_r462385360
##
File path:
core/src/main/scala/kafka/server/BrokerToControllerChannelManager.scala
##
@@ -0,0 +1,188 @@
+/*
+ * Licensed to the Apache Software Foundati
ijuma commented on pull request #9008:
URL: https://github.com/apache/kafka/pull/9008#issuecomment-665828744
What were the throughput numbers? I assume you meant the connsumer perf
test, not console consumer.
This is an auto
abbccdda merged pull request #9081:
URL: https://github.com/apache/kafka/pull/9081
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to t
mumrah commented on pull request #9008:
URL: https://github.com/apache/kafka/pull/9008#issuecomment-665845747
@ijuma you're right, i meant the consumer perf test. I updated my comment to
clarify
This is an automated message
abbccdda commented on a change in pull request #9001:
URL: https://github.com/apache/kafka/pull/9001#discussion_r462453975
##
File path: clients/src/main/java/org/apache/kafka/clients/admin/Admin.java
##
@@ -1214,6 +1215,71 @@ default AlterClientQuotasResult
alterClientQuotas(
abbccdda closed pull request #8940:
URL: https://github.com/apache/kafka/pull/8940
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to t
hachikuji commented on pull request #9008:
URL: https://github.com/apache/kafka/pull/9008#issuecomment-665938546
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
showuon opened a new pull request #9104:
URL: https://github.com/apache/kafka/pull/9104
After my update, the original wrong statement will be removed.
> By default, the SimpleHeaderConverter is used to .
And it'll be replaced with the following, with hyperlink to the worker
c
jsancio commented on a change in pull request #9050:
URL: https://github.com/apache/kafka/pull/9050#discussion_r462489390
##
File path: core/src/main/scala/kafka/controller/KafkaController.scala
##
@@ -2090,6 +2093,12 @@ case class ReplicaLeaderElection(
callback: ElectLeade
apovzner commented on a change in pull request #9072:
URL: https://github.com/apache/kafka/pull/9072#discussion_r462645570
##
File path:
clients/src/main/java/org/apache/kafka/common/metrics/stats/TokenBucket.java
##
@@ -0,0 +1,179 @@
+/*
+ * Licensed to the Apache Software Fo
guozhangwang commented on pull request #9095:
URL: https://github.com/apache/kafka/pull/9095#issuecomment-665967044
LGTM. Please feel free to merge and cherry-pick.
This is an automated message from the Apache Git Service.
To
showuon commented on pull request #9104:
URL: https://github.com/apache/kafka/pull/9104#issuecomment-666170759
@kkonstantine , could you help review this PR to correct the documentation.
Thanks.
This is an automated message
abbccdda merged pull request #9095:
URL: https://github.com/apache/kafka/pull/9095
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to t
mumrah edited a comment on pull request #9008:
URL: https://github.com/apache/kafka/pull/9008#issuecomment-665795947
I ran the consumer perf test (at @hachikuji's suggestion) and took a
profile. Throughput was around 500MB/s on trunk and on this branch
which implements dyn
guozhangwang commented on a change in pull request #9095:
URL: https://github.com/apache/kafka/pull/9095#discussion_r462589015
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/GlobalStreamThread.java
##
@@ -173,6 +178,18 @@ public boolean stillR
cadonna commented on pull request #9087:
URL: https://github.com/apache/kafka/pull/9087#issuecomment-666202514
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and us
chia7712 commented on pull request #9087:
URL: https://github.com/apache/kafka/pull/9087#issuecomment-666205937
retest this please
This is an automated message from the Apache Git Service.
To respond to the message, please lo
dajac commented on a change in pull request #9072:
URL: https://github.com/apache/kafka/pull/9072#discussion_r462846252
##
File path:
clients/src/main/java/org/apache/kafka/common/metrics/stats/TokenBucket.java
##
@@ -0,0 +1,179 @@
+/*
+ * Licensed to the Apache Software Found
mimaison commented on pull request #9007:
URL: https://github.com/apache/kafka/pull/9007#issuecomment-666239450
retest this please
This is an automated message from the Apache Git Service.
To respond to the message, please lo
mimaison commented on pull request #9007:
URL: https://github.com/apache/kafka/pull/9007#issuecomment-666256788
ok to test
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
cadonna commented on a change in pull request #9094:
URL: https://github.com/apache/kafka/pull/9094#discussion_r462881933
##
File path:
streams/src/test/java/org/apache/kafka/streams/integration/MetricsIntegrationTest.java
##
@@ -668,6 +671,9 @@ private void checkKeyValueStore
cadonna commented on a change in pull request #9094:
URL: https://github.com/apache/kafka/pull/9094#discussion_r462882926
##
File path:
streams/src/main/java/org/apache/kafka/streams/state/internals/metrics/StateStoreMetrics.java
##
@@ -443,6 +447,25 @@ public static Sensor su
cadonna commented on a change in pull request #9094:
URL: https://github.com/apache/kafka/pull/9094#discussion_r462883347
##
File path:
streams/src/test/java/org/apache/kafka/streams/state/internals/metrics/StateStoreMetricsTest.java
##
@@ -327,6 +327,38 @@ public void shouldG
mimaison commented on pull request #8295:
URL: https://github.com/apache/kafka/pull/8295#issuecomment-666310163
@dajac Ok, I've removed the `Optional` to `Option` changes
This is an automated message from the Apache Git Servi
cadonna commented on pull request #9087:
URL: https://github.com/apache/kafka/pull/9087#issuecomment-666311943
Java 14 failed due to the following failing test:
```
org.apache.kafka.streams.integration.EosBetaUpgradeIntegrationTest >
shouldUpgradeFromEosAlphaToEosBeta[true]
```
chia7712 commented on pull request #9087:
URL: https://github.com/apache/kafka/pull/9087#issuecomment-666325276
```EosBetaUpgradeIntegrationTest``` pass on my local. retest this please
This is an automated message from the Ap
chia7712 commented on pull request #9102:
URL: https://github.com/apache/kafka/pull/9102#issuecomment-666325552
```EosBetaUpgradeIntegrationTest``` is flaky... retest this please
This is an automated message from the Apache G
mimaison commented on pull request #9007:
URL: https://github.com/apache/kafka/pull/9007#issuecomment-666353178
Failures look unrelated:
- org.apache.kafka.streams.integration.EosBetaUpgradeIntegrationTest >
shouldUpgradeFromEosAlphaToEosBeta[true] FAILED
- org.apache.kafka.connect.mi
mimaison merged pull request #9007:
URL: https://github.com/apache/kafka/pull/9007
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to t
mimaison commented on a change in pull request #9029:
URL: https://github.com/apache/kafka/pull/9029#discussion_r462989546
##
File path:
connect/mirror/src/test/java/org/apache/kafka/connect/mirror/MirrorConnectorsIntegrationTest.java
##
@@ -345,15 +342,24 @@ private void
wai
mumrah commented on pull request #9008:
URL: https://github.com/apache/kafka/pull/9008#issuecomment-666374043
retest this please
This is an automated message from the Apache Git Service.
To respond to the message, please log
lct45 commented on a change in pull request #9039:
URL: https://github.com/apache/kafka/pull/9039#discussion_r463026843
##
File path:
streams/src/main/java/org/apache/kafka/streams/kstream/internals/CogroupedStreamAggregateBuilder.java
##
@@ -132,16 +135,19 @@
showuon commented on a change in pull request #9029:
URL: https://github.com/apache/kafka/pull/9029#discussion_r463028636
##
File path:
connect/mirror/src/test/java/org/apache/kafka/connect/mirror/MirrorConnectorsIntegrationTest.java
##
@@ -345,15 +342,24 @@ private void
wait
showuon commented on pull request #9029:
URL: https://github.com/apache/kafka/pull/9029#issuecomment-666395292
@mimaison , thanks for your good suggestion! I've updated in this commit:
https://github.com/apache/kafka/pull/9029/commits/8bc4a543dda6ddd90d752f7e6a64c63d85a1de3f.
Thanks.
---
lct45 commented on a change in pull request #9039:
URL: https://github.com/apache/kafka/pull/9039#discussion_r463036048
##
File path:
streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamSlidingWindowAggregate.java
##
@@ -0,0 +1,428 @@
+/*
+ * Licensed to th
chia7712 commented on pull request #8657:
URL: https://github.com/apache/kafka/pull/8657#issuecomment-666398632
> 2 system test failures in the latest PR
those 2 failed tests are flaky on my local and there are issue/PR related to
them.
@junrao @ijuma @hachikuji @rajinisivaram
lct45 commented on a change in pull request #9039:
URL: https://github.com/apache/kafka/pull/9039#discussion_r463039985
##
File path:
streams/src/main/java/org/apache/kafka/streams/kstream/internals/SlidingWindowedKStreamImpl.java
##
@@ -0,0 +1,254 @@
+/*
+ * Licensed to the A
dajac commented on pull request #9091:
URL: https://github.com/apache/kafka/pull/9091#issuecomment-666402566
rebased to fix conflicts.
This is an automated message from the Apache Git Service.
To respond to the message, pleas
ijuma commented on pull request #8657:
URL: https://github.com/apache/kafka/pull/8657#issuecomment-666403581
@junrao Thanks for the summary. With regards to the thread pool option,
would this be used for completion of delayed operations for the group
coordinator only? When it comes to tuni
ijuma commented on a change in pull request #8657:
URL: https://github.com/apache/kafka/pull/8657#discussion_r463044371
##
File path:
core/src/main/scala/kafka/coordinator/group/GroupMetadataManager.scala
##
@@ -239,9 +239,13 @@ class GroupMetadataManager(brokerId: Int,
}
lct45 commented on a change in pull request #9039:
URL: https://github.com/apache/kafka/pull/9039#discussion_r463046306
##
File path:
streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamSlidingWindowAggregate.java
##
@@ -0,0 +1,428 @@
+/*
+ * Licensed to th
lct45 commented on a change in pull request #9039:
URL: https://github.com/apache/kafka/pull/9039#discussion_r463047237
##
File path:
streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamSlidingWindowAggregate.java
##
@@ -0,0 +1,428 @@
+/*
+ * Licensed to th
lct45 commented on a change in pull request #9039:
URL: https://github.com/apache/kafka/pull/9039#discussion_r463056420
##
File path:
streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamSlidingWindowAggregate.java
##
@@ -0,0 +1,428 @@
+/*
+ * Licensed to th
dajac commented on a change in pull request #9092:
URL: https://github.com/apache/kafka/pull/9092#discussion_r463056307
##
File path: core/src/main/scala/kafka/server/DynamicConfig.scala
##
@@ -103,7 +103,7 @@ object DynamicConfig {
.define(ProducerByteRateOverrideProp,
vvcephei merged pull request #9097:
URL: https://github.com/apache/kafka/pull/9097
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to t
rajinisivaram commented on pull request #9092:
URL: https://github.com/apache/kafka/pull/9092#issuecomment-666428695
ok to test
This is an automated message from the Apache Git Service.
To respond to the message, please log o
rajinisivaram commented on pull request #9092:
URL: https://github.com/apache/kafka/pull/9092#issuecomment-666429262
retest this please
This is an automated message from the Apache Git Service.
To respond to the message, plea
lct45 commented on a change in pull request #9039:
URL: https://github.com/apache/kafka/pull/9039#discussion_r463063406
##
File path:
streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamSlidingWindowAggregate.java
##
@@ -0,0 +1,428 @@
+/*
+ * Licensed to th
chia7712 commented on a change in pull request #8657:
URL: https://github.com/apache/kafka/pull/8657#discussion_r463066191
##
File path:
core/src/main/scala/kafka/coordinator/group/GroupMetadataManager.scala
##
@@ -239,9 +239,13 @@ class GroupMetadataManager(brokerId: Int,
chia7712 commented on a change in pull request #8657:
URL: https://github.com/apache/kafka/pull/8657#discussion_r463066323
##
File path: core/src/main/scala/kafka/coordinator/group/GroupCoordinator.scala
##
@@ -369,6 +370,32 @@ class GroupCoordinator(val brokerId: Int,
}
lct45 commented on a change in pull request #9039:
URL: https://github.com/apache/kafka/pull/9039#discussion_r463073842
##
File path:
streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamSlidingWindowAggregate.java
##
@@ -0,0 +1,428 @@
+/*
+ * Licensed to th
lct45 commented on a change in pull request #9039:
URL: https://github.com/apache/kafka/pull/9039#discussion_r463076565
##
File path:
streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamSlidingWindowAggregate.java
##
@@ -0,0 +1,428 @@
+/*
+ * Licensed to th
lct45 commented on a change in pull request #9039:
URL: https://github.com/apache/kafka/pull/9039#discussion_r463077196
##
File path:
streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamSlidingWindowAggregate.java
##
@@ -0,0 +1,428 @@
+/*
+ * Licensed to th
lct45 commented on a change in pull request #9039:
URL: https://github.com/apache/kafka/pull/9039#discussion_r463078058
##
File path:
streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamSlidingWindowAggregate.java
##
@@ -0,0 +1,428 @@
+/*
+ * Licensed to th
lct45 commented on a change in pull request #9039:
URL: https://github.com/apache/kafka/pull/9039#discussion_r463083346
##
File path:
streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamSlidingWindowAggregate.java
##
@@ -0,0 +1,428 @@
+/*
+ * Licensed to th
lct45 commented on a change in pull request #9039:
URL: https://github.com/apache/kafka/pull/9039#discussion_r463083821
##
File path:
streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamSlidingWindowAggregate.java
##
@@ -0,0 +1,428 @@
+/*
+ * Licensed to th
lct45 commented on a change in pull request #9039:
URL: https://github.com/apache/kafka/pull/9039#discussion_r463088582
##
File path:
streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamSlidingWindowAggregate.java
##
@@ -0,0 +1,428 @@
+/*
+ * Licensed to th
lct45 commented on a change in pull request #9039:
URL: https://github.com/apache/kafka/pull/9039#discussion_r463088582
##
File path:
streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamSlidingWindowAggregate.java
##
@@ -0,0 +1,428 @@
+/*
+ * Licensed to th
lct45 commented on a change in pull request #9039:
URL: https://github.com/apache/kafka/pull/9039#discussion_r463091437
##
File path:
streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamSlidingWindowAggregate.java
##
@@ -0,0 +1,428 @@
+/*
+ * Licensed to th
lct45 commented on a change in pull request #9039:
URL: https://github.com/apache/kafka/pull/9039#discussion_r463092579
##
File path:
streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamSlidingWindowAggregate.java
##
@@ -0,0 +1,428 @@
+/*
+ * Licensed to th
mimaison commented on pull request #9029:
URL: https://github.com/apache/kafka/pull/9029#issuecomment-666512651
ok to test
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
vvcephei commented on a change in pull request #9098:
URL: https://github.com/apache/kafka/pull/9098#discussion_r463128398
##
File path:
streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBStore.java
##
@@ -181,23 +181,39 @@ void openDB(final ProcessorContext
vvcephei commented on a change in pull request #9098:
URL: https://github.com/apache/kafka/pull/9098#discussion_r463128398
##
File path:
streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBStore.java
##
@@ -181,23 +181,39 @@ void openDB(final ProcessorContext
mimaison commented on a change in pull request #8730:
URL: https://github.com/apache/kafka/pull/8730#discussion_r463097918
##
File path:
connect/mirror/src/test/java/org/apache/kafka/connect/mirror/MirrorConnectorsIntegrationTest.java
##
@@ -367,14 +406,37 @@ public void testO
mimaison commented on pull request #9029:
URL: https://github.com/apache/kafka/pull/9029#issuecomment-666526465
retest this please
This is an automated message from the Apache Git Service.
To respond to the message, please lo
mumrah commented on pull request #9008:
URL: https://github.com/apache/kafka/pull/9008#issuecomment-666531948
These test failures are known flaky tests which already have jira tickets
This is an automated message from the Apa
highluck opened a new pull request #9105:
URL: https://github.com/apache/kafka/pull/9105
closable object Memory leak prevention
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ]
mumrah merged pull request #9008:
URL: https://github.com/apache/kafka/pull/9008
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
abbccdda commented on pull request #8295:
URL: https://github.com/apache/kafka/pull/8295#issuecomment-666590526
@mimaison Could you rebase?
This is an automated message from the Apache Git Service.
To respond to the message,
rhauch opened a new pull request #9106:
URL: https://github.com/apache/kafka/pull/9106
Targets the `2.4` branch. See #8854 for the similar PR for the `2.5` branch,
which is currently blocked by the 2.5.1 release effort.
This backports the KAFKA-9066 / #8502 changes to retain metrics
rhauch commented on pull request #9106:
URL: https://github.com/apache/kafka/pull/9106#issuecomment-11491
@kkonstantine, here is a PR for the `2.4` branch that is a cherry-pick of
the same one commit from #8854 that you've already approved.
abbccdda commented on a change in pull request #9096:
URL: https://github.com/apache/kafka/pull/9096#discussion_r463260878
##
File path:
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractStickyAssignor.java
##
@@ -163,6 +183,7 @@ private boolean allSubs
mimaison merged pull request #9029:
URL: https://github.com/apache/kafka/pull/9029
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to t
mimaison commented on pull request #8295:
URL: https://github.com/apache/kafka/pull/8295#issuecomment-666701712
@abbccdda Done!
This is an automated message from the Apache Git Service.
To respond to the message, please log o
ableegoldman commented on a change in pull request #9094:
URL: https://github.com/apache/kafka/pull/9094#discussion_r463283004
##
File path:
streams/src/main/java/org/apache/kafka/streams/state/internals/MeteredKeyValueStore.java
##
@@ -227,6 +234,14 @@ protected Bytes keyByte
ableegoldman commented on a change in pull request #9094:
URL: https://github.com/apache/kafka/pull/9094#discussion_r463291268
##
File path:
streams/src/test/java/org/apache/kafka/streams/integration/MetricsIntegrationTest.java
##
@@ -668,6 +671,9 @@ private void checkKeyValue
inponomarev opened a new pull request #9107:
URL: https://github.com/apache/kafka/pull/9107
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade
inponomarev commented on pull request #9107:
URL: https://github.com/apache/kafka/pull/9107#issuecomment-666749809
⚠️ Two differences with KIP specification⚠️
1. Instead of multiple overloaded variants of `Branched.with` we now have
`Branched.withFunction` and `Branched.withConsumer
ableegoldman commented on a change in pull request #9094:
URL: https://github.com/apache/kafka/pull/9094#discussion_r463312310
##
File path:
streams/src/test/java/org/apache/kafka/streams/processor/internals/StreamTaskTest.java
##
@@ -468,38 +468,44 @@ public void
shouldRecor
rhauch merged pull request #9106:
URL: https://github.com/apache/kafka/pull/9106
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
junrao commented on pull request #8657:
URL: https://github.com/apache/kafka/pull/8657#issuecomment-666753554
@ijuma : I think the proposal is to complete all delayed operations in a
separate thread pool. My concerns for that approach are the following: (1)
Configuration: How many threads
ableegoldman commented on pull request #9094:
URL: https://github.com/apache/kafka/pull/9094#issuecomment-666757275
Addressed all your comments @cadonna, ready for another pass. One open
question about the MetricsIntegrationTest
ijuma commented on a change in pull request #8657:
URL: https://github.com/apache/kafka/pull/8657#discussion_r463318346
##
File path:
core/src/main/scala/kafka/coordinator/group/GroupMetadataManager.scala
##
@@ -239,9 +239,13 @@ class GroupMetadataManager(brokerId: Int,
}
junrao commented on a change in pull request #9072:
URL: https://github.com/apache/kafka/pull/9072#discussion_r463336327
##
File path:
clients/src/main/java/org/apache/kafka/common/metrics/stats/TokenBucket.java
##
@@ -0,0 +1,179 @@
+/*
+ * Licensed to the Apache Software Foun
gwenshap commented on pull request #9054:
URL: https://github.com/apache/kafka/pull/9054#issuecomment-666857962
Test failures:
org.apache.kafka.connect.mirror.MirrorConnectorsIntegrationTest.testOneWayReplicationWithAutorOffsetSync1
in both JDK 11 and JDK 14. My understanding is that
bob-barrett commented on pull request #9054:
URL: https://github.com/apache/kafka/pull/9054#issuecomment-666862523
Test failure looks unrelated and passes locally, probably a flak
This is an automated message from the Apache
bob-barrett edited a comment on pull request #9054:
URL: https://github.com/apache/kafka/pull/9054#issuecomment-666862523
Test failure looks unrelated and passes locally, probably a flake
This is an automated message from the
gwenshap closed pull request #9054:
URL: https://github.com/apache/kafka/pull/9054
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to t
showuon commented on a change in pull request #9096:
URL: https://github.com/apache/kafka/pull/9096#discussion_r463371979
##
File path:
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractStickyAssignor.java
##
@@ -163,6 +183,7 @@ private boolean allSubsc
abbccdda commented on pull request #9094:
URL: https://github.com/apache/kafka/pull/9094#issuecomment-666877540
retest this please
This is an automated message from the Apache Git Service.
To respond to the message, please lo
201 - 300 of 51557 matches
Mail list logo
