vvcephei merged pull request #9174:
URL: https://github.com/apache/kafka/pull/9174
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to t
vvcephei commented on a change in pull request #9177:
URL: https://github.com/apache/kafka/pull/9177#discussion_r472250612
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/metrics/StreamsMetricsImpl.java
##
@@ -415,9 +416,40 @@ public final Sens
vvcephei commented on pull request #9177:
URL: https://github.com/apache/kafka/pull/9177#issuecomment-675521788
Thanks for the update, @cadonna . Just one reply above.
This is an automated message from the Apache Git Service.
vvcephei commented on pull request #9177:
URL: https://github.com/apache/kafka/pull/9177#issuecomment-675522188
Retest this please
This is an automated message from the Apache Git Service.
To respond to the message, please lo
vvcephei edited a comment on pull request #9177:
URL: https://github.com/apache/kafka/pull/9177#issuecomment-675522188
Looks like Jenkins shut down during the run last time or something.
Retest this please
This is an a
cadonna commented on a change in pull request #9177:
URL: https://github.com/apache/kafka/pull/9177#discussion_r472276615
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/metrics/StreamsMetricsImpl.java
##
@@ -415,9 +416,40 @@ public final Senso
cadonna commented on a change in pull request #9177:
URL: https://github.com/apache/kafka/pull/9177#discussion_r472276615
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/metrics/StreamsMetricsImpl.java
##
@@ -415,9 +416,40 @@ public final Senso
rondagostino commented on a change in pull request #9142:
URL: https://github.com/apache/kafka/pull/9142#discussion_r472279480
##
File path: tests/kafkatest/services/kafka/kafka.py
##
@@ -503,7 +503,7 @@ def create_topic(self, topic_cfg, node=None,
use_zk_to_create_topic=True)
vvcephei commented on a change in pull request #9148:
URL: https://github.com/apache/kafka/pull/9148#discussion_r472327085
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/InternalTopologyBuilder.java
##
@@ -667,7 +674,7 @@ public void validateC
vvcephei commented on a change in pull request #9148:
URL: https://github.com/apache/kafka/pull/9148#discussion_r472348482
##
File path: streams/src/test/java/org/apache/kafka/test/MockApiProcessor.java
##
@@ -0,0 +1,174 @@
+/*
+ * Licensed to the Apache Software Foundation (AS
wcarlson5 closed pull request #7492:
URL: https://github.com/apache/kafka/pull/7492
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
vvcephei commented on a change in pull request #9148:
URL: https://github.com/apache/kafka/pull/9148#discussion_r472368613
##
File path:
streams/src/test/java/org/apache/kafka/test/MockApiProcessorSupplier.java
##
@@ -0,0 +1,69 @@
+/*
+ * Licensed to the Apache Software Founda
guozhangwang commented on a change in pull request #9191:
URL: https://github.com/apache/kafka/pull/9191#discussion_r472368768
##
File path:
streams/src/main/java/org/apache/kafka/streams/errors/MissingSourceTopicException.java
##
@@ -0,0 +1,26 @@
+/*
+ * Licensed to the Apach
abbccdda commented on pull request #8846:
URL: https://github.com/apache/kafka/pull/8846#issuecomment-675647225
retest this please
This is an automated message from the Apache Git Service.
To respond to the message, please lo
guozhangwang commented on pull request #9177:
URL: https://github.com/apache/kafka/pull/9177#issuecomment-675651901
test this please
This is an automated message from the Apache Git Service.
To respond to the message, please
guozhangwang commented on a change in pull request #9177:
URL: https://github.com/apache/kafka/pull/9177#discussion_r472429141
##
File path:
streams/src/main/java/org/apache/kafka/streams/state/internals/metrics/RocksDBMetrics.java
##
@@ -33,7 +35,7 @@
import static
org.apac
lct45 commented on a change in pull request #9039:
URL: https://github.com/apache/kafka/pull/9039#discussion_r472436400
##
File path: checkstyle/suppressions.xml
##
@@ -167,6 +167,9 @@
+
Review comment:
We don't!
-
abbccdda commented on pull request #8846:
URL: https://github.com/apache/kafka/pull/8846#issuecomment-675675970
Some compilation errors:
```
11:41:23
/home/jenkins/jenkins-slave/workspace/kafka-pr-jdk15-scala2.13/clients/src/main/java/org/apache/kafka/clients/Metadata.java:474:
error
cmccabe opened a new pull request #9197:
URL: https://github.com/apache/kafka/pull/9197
This reverts commit bf6dffe93bbe0fe33ad076ebccebb840d66b936d
This is an automated message from the Apache Git Service.
To respond to the
lct45 commented on a change in pull request #9039:
URL: https://github.com/apache/kafka/pull/9039#discussion_r472440045
##
File path:
streams/src/test/java/org/apache/kafka/streams/kstream/internals/SlidingWindowedKStreamImplTest.java
##
@@ -0,0 +1,438 @@
+/*
+ * Licensed to t
ableegoldman commented on a change in pull request #9039:
URL: https://github.com/apache/kafka/pull/9039#discussion_r472441802
##
File path:
streams/src/test/java/org/apache/kafka/streams/kstream/internals/SlidingWindowedKStreamImplTest.java
##
@@ -0,0 +1,438 @@
+/*
+ * Licens
mimaison commented on pull request #8295:
URL: https://github.com/apache/kafka/pull/8295#issuecomment-675697535
@abbccdda Thanks for the reviews, can you take another look?
This is an automated message from the Apache Git Ser
cmccabe commented on pull request #9144:
URL: https://github.com/apache/kafka/pull/9144#issuecomment-675703162
LGTM
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
cmccabe commented on a change in pull request #9144:
URL: https://github.com/apache/kafka/pull/9144#discussion_r472477998
##
File path: clients/src/main/java/org/apache/kafka/clients/KafkaClient.java
##
@@ -189,16 +189,18 @@ ClientRequest newClientRequest(String nodeId,
Abstra
cmccabe merged pull request #9144:
URL: https://github.com/apache/kafka/pull/9144
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to th
cmccabe commented on pull request #9197:
URL: https://github.com/apache/kafka/pull/9197#issuecomment-675711065
Looks like there is a checkstyle issue upstream:
```
12:59:42 > Task :streams:upgrade-system-tests-22:checkstyleTest FAILED
12:59:42 [ant:checkstyle] [ERROR]
/home/jenkins
mimaison commented on pull request #9131:
URL: https://github.com/apache/kafka/pull/9131#issuecomment-675713485
@mjsax Can you take another look? Thanks
This is an automated message from the Apache Git Service.
To respond to
cmccabe commented on pull request #9194:
URL: https://github.com/apache/kafka/pull/9194#issuecomment-675714307
JDK8 test failure looks like a Jenkins issue.
```
13:29:01 Fetching upstream changes from git://github.com/apache/kafka.git
13:29:01 > git fetch --tags --progress -- g
mimaison commented on pull request #8050:
URL: https://github.com/apache/kafka/pull/8050#issuecomment-675714697
@omkreddy @hachikuji Can you take a look? Thanks
This is an automated message from the Apache Git Service.
To res
cmccabe commented on a change in pull request #9032:
URL: https://github.com/apache/kafka/pull/9032#discussion_r472494891
##
File path: clients/src/main/java/org/apache/kafka/clients/admin/Admin.java
##
@@ -1214,6 +1215,64 @@ default AlterClientQuotasResult
alterClientQuotas(C
cmccabe commented on a change in pull request #9032:
URL: https://github.com/apache/kafka/pull/9032#discussion_r472496932
##
File path:
clients/src/main/java/org/apache/kafka/clients/admin/UserScramCredentialsDescription.java
##
@@ -0,0 +1,89 @@
+/*
+ * Licensed to the Apache
cmccabe commented on a change in pull request #9032:
URL: https://github.com/apache/kafka/pull/9032#discussion_r472498809
##
File path:
clients/src/test/java/org/apache/kafka/common/protocol/ProtoUtilsTest.java
##
@@ -26,11 +26,18 @@
public void testDelayedAllocationSchem
cmccabe commented on a change in pull request #9032:
URL: https://github.com/apache/kafka/pull/9032#discussion_r472501147
##
File path: core/src/test/scala/unit/kafka/admin/ConfigCommandTest.scala
##
@@ -486,7 +486,9 @@ class ConfigCommandTest extends ZooKeeperTestHarness with
mjsax opened a new pull request #9198:
URL: https://github.com/apache/kafka/pull/9198
Follow up to #9067 -- seems I made an error resolving the unclean
cherry-pick from `trunk` to `2.6`.
Call for review @vvcephei @ijuma
-
rondagostino opened a new pull request #9199:
URL: https://github.com/apache/kafka/pull/9199
Changing a topic config with the `kafka-topics` command while connecting to
Kafka via `--bootstrap-server` (rather than connecting to ZooKeeper via
`--zookeeper`) is not supported. The desired func
rondagostino commented on pull request #9199:
URL: https://github.com/apache/kafka/pull/9199#issuecomment-675731352
@cmccabe Can you take a look?
This is an automated message from the Apache Git Service.
To respond to the mes
mjsax commented on pull request #9067:
URL: https://github.com/apache/kafka/pull/9067#issuecomment-675733090
Seems I made a mistake cherry-picking to `2.6` -- I remember that there was
a conflict; guess I resolved it incorrectly. Did a HOTFIX PR: #9198
cmccabe commented on a change in pull request #9032:
URL: https://github.com/apache/kafka/pull/9032#discussion_r472507947
##
File path:
clients/src/main/java/org/apache/kafka/clients/admin/DescribeUserScramCredentialsResult.java
##
@@ -0,0 +1,50 @@
+/*
+ * Licensed to the Apac
cmccabe commented on pull request #9199:
URL: https://github.com/apache/kafka/pull/9199#issuecomment-675734800
LGTM
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
rondagostino commented on a change in pull request #9032:
URL: https://github.com/apache/kafka/pull/9032#discussion_r472530253
##
File path: core/src/test/scala/unit/kafka/admin/ConfigCommandTest.scala
##
@@ -486,7 +486,9 @@ class ConfigCommandTest extends ZooKeeperTestHarness
cmccabe commented on pull request #9198:
URL: https://github.com/apache/kafka/pull/9198#issuecomment-675755685
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and us
vvcephei commented on a change in pull request #9137:
URL: https://github.com/apache/kafka/pull/9137#discussion_r472531237
##
File path:
streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBPrefixIterator.java
##
@@ -1,54 +0,0 @@
-/*
- * Licensed to the Apache
lbradstreet opened a new pull request #9200:
URL: https://github.com/apache/kafka/pull/9200
406635bcc9f2a4c439d198ea0549170de331323c switched System.exit to using
Exit.exit, however the integration tests did not choose to override the exit
procedure.
This can cause invalid test runs
rondagostino commented on a change in pull request #9032:
URL: https://github.com/apache/kafka/pull/9032#discussion_r472570823
##
File path:
clients/src/main/java/org/apache/kafka/clients/admin/DescribeUserScramCredentialsResult.java
##
@@ -0,0 +1,50 @@
+/*
+ * Licensed to the
rondagostino commented on a change in pull request #9032:
URL: https://github.com/apache/kafka/pull/9032#discussion_r472570823
##
File path:
clients/src/main/java/org/apache/kafka/clients/admin/DescribeUserScramCredentialsResult.java
##
@@ -0,0 +1,50 @@
+/*
+ * Licensed to the
mjsax merged pull request #9198:
URL: https://github.com/apache/kafka/pull/9198
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
rondagostino commented on a change in pull request #9032:
URL: https://github.com/apache/kafka/pull/9032#discussion_r472574569
##
File path:
clients/src/main/java/org/apache/kafka/clients/admin/DescribeUserScramCredentialsResult.java
##
@@ -0,0 +1,50 @@
+/*
+ * Licensed to the
rondagostino commented on a change in pull request #9032:
URL: https://github.com/apache/kafka/pull/9032#discussion_r472570823
##
File path:
clients/src/main/java/org/apache/kafka/clients/admin/DescribeUserScramCredentialsResult.java
##
@@ -0,0 +1,50 @@
+/*
+ * Licensed to the
rondagostino commented on a change in pull request #9032:
URL: https://github.com/apache/kafka/pull/9032#discussion_r472575326
##
File path:
clients/src/main/java/org/apache/kafka/clients/admin/DescribeUserScramCredentialsResult.java
##
@@ -0,0 +1,50 @@
+/*
+ * Licensed to the
LMnet commented on pull request #8955:
URL: https://github.com/apache/kafka/pull/8955#issuecomment-675817076
Voting for the KIP successfully finished and this pull request could be
merged now.
This is an automated message fr
showuon commented on pull request #9121:
URL: https://github.com/apache/kafka/pull/9121#issuecomment-675828368
@mjsax , could you review this small PR? Thanks.
This is an automated message from the Apache Git Service.
To resp
showuon commented on pull request #9062:
URL: https://github.com/apache/kafka/pull/9062#issuecomment-675828534
@abbccdda @omkreddy , could you review this PR? Thanks.
This is an automated message from the Apache Git Service.
rondagostino commented on a change in pull request #9200:
URL: https://github.com/apache/kafka/pull/9200#discussion_r472636924
##
File path:
connect/mirror/src/test/java/org/apache/kafka/connect/mirror/MirrorConnectorsIntegrationTest.java
##
@@ -185,10 +192,9 @@ public void cl
cmccabe commented on a change in pull request #9032:
URL: https://github.com/apache/kafka/pull/9032#discussion_r472688926
##
File path:
clients/src/main/java/org/apache/kafka/clients/admin/DescribeUserScramCredentialsResult.java
##
@@ -0,0 +1,50 @@
+/*
+ * Licensed to the Apac
cmccabe commented on pull request #9197:
URL: https://github.com/apache/kafka/pull/9197#issuecomment-675850067
retest this please
This is an automated message from the Apache Git Service.
To respond to the message, please log
cmccabe commented on a change in pull request #9032:
URL: https://github.com/apache/kafka/pull/9032#discussion_r472693268
##
File path: core/src/test/scala/unit/kafka/admin/ConfigCommandTest.scala
##
@@ -486,7 +486,9 @@ class ConfigCommandTest extends ZooKeeperTestHarness with
cmccabe commented on pull request #9197:
URL: https://github.com/apache/kafka/pull/9197#issuecomment-675851293
There seems to be a Jenkins issue here:
```
21:54:39 Fetching upstream changes from git://github.com/apache/kafka.git
21:54:39 > git fetch --tags --progress -- git://githu
showuon commented on pull request #9149:
URL: https://github.com/apache/kafka/pull/9149#issuecomment-675858452
@kkonstantine , could you help review this PR to improve logging? Thanks.
This is an automated message from the A
cmccabe commented on pull request #9197:
URL: https://github.com/apache/kafka/pull/9197#issuecomment-675859396
retest this please
This is an automated message from the Apache Git Service.
To respond to the message, please log
lbradstreet commented on a change in pull request #9200:
URL: https://github.com/apache/kafka/pull/9200#discussion_r472723313
##
File path:
connect/mirror/src/test/java/org/apache/kafka/connect/mirror/MirrorConnectorsIntegrationTest.java
##
@@ -185,10 +192,9 @@ public void clo
lbradstreet commented on a change in pull request #9200:
URL: https://github.com/apache/kafka/pull/9200#discussion_r472723414
##
File path:
core/src/test/scala/integration/kafka/tools/MirrorMakerIntegrationTest.scala
##
@@ -29,14 +29,31 @@ import org.apache.kafka.clients.produ
omkreddy commented on pull request #9200:
URL: https://github.com/apache/kafka/pull/9200#issuecomment-675864751
ok to test
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
aurlien closed pull request #7444:
URL: https://github.com/apache/kafka/pull/7444
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to th
aurlien commented on pull request #7444:
URL: https://github.com/apache/kafka/pull/7444#issuecomment-675876949
Sorry, I completely forgot about this. Closing the PR.
This is an automated message from the Apache Git Service.
mjsax commented on pull request #8955:
URL: https://github.com/apache/kafka/pull/8955#issuecomment-675900333
Retest this please.
This is an automated message from the Apache Git Service.
To respond to the message, please log
cadonna commented on pull request #9177:
URL: https://github.com/apache/kafka/pull/9177#issuecomment-675909416
If we assume, that the same thread adds and removes the state store level
metrics (which is currently the case), we just need thread-safe maps
`storeLevelSensors` and `storeLevelM
cadonna edited a comment on pull request #9177:
URL: https://github.com/apache/kafka/pull/9177#issuecomment-675909416
If we assume, that the same thread adds and removes the state store level
metrics (which is currently the case), we just need thread-safe maps
`storeLevelSensors` and `stor
cadonna commented on pull request #9177:
URL: https://github.com/apache/kafka/pull/9177#issuecomment-676001391
I removed `synchronized` during adding and removing store level sensors and
metrics. Let me know what you think. If you do not like it, we can revert the
last commit.
-
rajinisivaram commented on a change in pull request #9200:
URL: https://github.com/apache/kafka/pull/9200#discussion_r472885774
##
File path:
connect/mirror/src/test/java/org/apache/kafka/connect/mirror/MirrorConnectorsIntegrationTest.java
##
@@ -185,10 +192,10 @@ public void
carlos-verdes commented on pull request #9176:
URL: https://github.com/apache/kafka/pull/9176#issuecomment-676156385
I will be happy to do but I may need help about the KIP.
Do you need me to open a Jira ticket to move forward?
---
rondagostino commented on a change in pull request #9032:
URL: https://github.com/apache/kafka/pull/9032#discussion_r472947852
##
File path:
clients/src/main/java/org/apache/kafka/clients/admin/DescribeUserScramCredentialsResult.java
##
@@ -0,0 +1,50 @@
+/*
+ * Licensed to the
rajinisivaram commented on pull request #9142:
URL: https://github.com/apache/kafka/pull/9142#issuecomment-676279828
@skaundinya15 Thanks for the PR, merging to trunk
This is an automated message from the Apache Git Service.
rajinisivaram merged pull request #9142:
URL: https://github.com/apache/kafka/pull/9142
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
rhauch commented on pull request #9176:
URL: https://github.com/apache/kafka/pull/9176#issuecomment-676385111
Yes, please create an issue as described above.
This is an automated message from the Apache Git Service.
To respo
ijuma commented on pull request #9197:
URL: https://github.com/apache/kafka/pull/9197#issuecomment-676427721
@cmccabe There's a checkstyle error, it seems.
This is an automated message from the Apache Git Service.
To respond
vvcephei commented on a change in pull request #9137:
URL: https://github.com/apache/kafka/pull/9137#discussion_r473068515
##
File path:
streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBPrefixIterator.java
##
@@ -1,54 +0,0 @@
-/*
- * Licensed to the Apache
lbradstreet commented on a change in pull request #9200:
URL: https://github.com/apache/kafka/pull/9200#discussion_r473075940
##
File path:
connect/mirror/src/test/java/org/apache/kafka/connect/mirror/MirrorConnectorsIntegrationTest.java
##
@@ -185,10 +192,10 @@ public void cl
vvcephei commented on pull request #9148:
URL: https://github.com/apache/kafka/pull/9148#issuecomment-676482308
Retest this please
This is an automated message from the Apache Git Service.
To respond to the message, please lo
lbradstreet commented on a change in pull request #9200:
URL: https://github.com/apache/kafka/pull/9200#discussion_r473110543
##
File path:
connect/mirror/src/test/java/org/apache/kafka/connect/mirror/MirrorConnectorsIntegrationTest.java
##
@@ -185,10 +192,10 @@ public void cl
rondagostino commented on pull request #9199:
URL: https://github.com/apache/kafka/pull/9199#issuecomment-676491706
Note that KIP-377 landed in 2.2 and explicitly stated in the new code that
altering topic configurations via `kafka-topics` was deprecated – even using
the `--zookeeper` flag
rondagostino commented on pull request #9199:
URL: https://github.com/apache/kafka/pull/9199#issuecomment-676492765
JDK 11 build failure was a n infrastructure issue. JDK 8 test failure is an
unrelated flaky test
(`org.apache.kafka.streams.integration.EosIntegrationTest.shouldNotViolateEo
cmccabe commented on pull request #9197:
URL: https://github.com/apache/kafka/pull/9197#issuecomment-676507610
Another Jenkins problem.
```
08:36:34 > git fetch --tags --progress -- git://github.com/apache/kafka.git
+refs/heads/*:refs/remotes/origin/* +refs/pull/*:refs/remotes/origin
cmccabe commented on pull request #9197:
URL: https://github.com/apache/kafka/pull/9197#issuecomment-676507773
retest this please
This is an automated message from the Apache Git Service.
To respond to the message, please log
vvcephei commented on a change in pull request #9137:
URL: https://github.com/apache/kafka/pull/9137#discussion_r473071200
##
File path:
streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDbIterator.java
##
@@ -58,7 +62,7 @@ public synchronized boolean hasNext
abbccdda commented on a change in pull request #9103:
URL: https://github.com/apache/kafka/pull/9103#discussion_r473158779
##
File path:
clients/src/main/java/org/apache/kafka/common/requests/AlterClientQuotasRequest.java
##
@@ -76,6 +77,16 @@ public AlterClientQuotasRequest b
gardnervickers opened a new pull request #9201:
URL: https://github.com/apache/kafka/pull/9201
Increase the amount of time available to the `test_verifiable_producer` test
to login and get the process name for the verifiable producer from 5 seconds to
10 seconds.
We were seeing some
cmccabe commented on pull request #9197:
URL: https://github.com/apache/kafka/pull/9197#issuecomment-676589017
I verified that this removed the dependency by doing this:
```
./gradlew install -x check -x test
find | grep jackson | grep jar$ | xargs -l rm
```
And then testing t
cmccabe commented on pull request #9197:
URL: https://github.com/apache/kafka/pull/9197#issuecomment-676589352
The failed test is flaky. Committing now. Thanks for the review
This is an automated message from the Apache Git
cmccabe merged pull request #9197:
URL: https://github.com/apache/kafka/pull/9197
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to th
ijuma commented on pull request #9197:
URL: https://github.com/apache/kafka/pull/9197#issuecomment-676594223
Sounds great, thanks!
This is an automated message from the Apache Git Service.
To respond to the message, please lo
cmccabe commented on pull request #9194:
URL: https://github.com/apache/kafka/pull/9194#issuecomment-676596370
I tested that this works to allow console consumer to run without a jackson
dependency.
This is an automated mess
cmccabe commented on a change in pull request #9032:
URL: https://github.com/apache/kafka/pull/9032#discussion_r473276446
##
File path:
clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java
##
@@ -4071,6 +4081,168 @@ void handleFailure(Throwable throwable)
abbccdda commented on pull request #8846:
URL: https://github.com/apache/kafka/pull/8846#issuecomment-676628747
retest this please
This is an automated message from the Apache Git Service.
To respond to the message, please lo
abbccdda commented on pull request #8846:
URL: https://github.com/apache/kafka/pull/8846#issuecomment-676632413
retest this please
This is an automated message from the Apache Git Service.
To respond to the message, p
huxihx commented on pull request #9189:
URL: https://github.com/apache/kafka/pull/9189#issuecomment-676840253
@omkreddy Thanks for the review, merging to trunk. @dongjinleekr Thanks for
the comments again.
This is an automat
huxihx merged pull request #9189:
URL: https://github.com/apache/kafka/pull/9189
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
abbccdda commented on a change in pull request #9100:
URL: https://github.com/apache/kafka/pull/9100#discussion_r473515635
##
File path: core/src/main/scala/kafka/server/AlterIsrManager.scala
##
@@ -0,0 +1,149 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under o
LMnet commented on pull request #8955:
URL: https://github.com/apache/kafka/pull/8955#issuecomment-676950368
There were some failed style checks. I fixed them.
This is an automated message from the Apache Git Service.
To resp
showuon opened a new pull request #9202:
URL: https://github.com/apache/kafka/pull/9202
Fix the `currentStateTimeStamp` doesn't get set in
`GROUP_METADATA_VALUE_SCHEMA_V3`, and did a small refactor to use the
`GROUP_VALUE_SCHEMAS.size - 1` replace the default hard-coded max version
number
showuon commented on pull request #9202:
URL: https://github.com/apache/kafka/pull/9202#issuecomment-677036776
@abbccdda @vahidhashemian @hachikuji , could you help review this PR? Thanks.
This is an automated message from th
1301 - 1400 of 51557 matches
Mail list logo
