chia7712 merged PR #19753:
URL: https://github.com/apache/kafka/pull/19753
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
[
https://issues.apache.org/jira/browse/KAFKA-18903?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai resolved KAFKA-18903.
Fix Version/s: 4.2.0
Resolution: Fixed
> Use curl + jq in update-cache.sh
> ---
github-actions[bot] commented on PR #19236:
URL: https://github.com/apache/kafka/pull/19236#issuecomment-2989693963
A label of 'needs-attention' was automatically added to this PR in order to
raise the
attention of the committers. Once this issue has been triaged, the `triage`
label
s
github-actions[bot] commented on PR #19955:
URL: https://github.com/apache/kafka/pull/19955#issuecomment-2989693563
A label of 'needs-attention' was automatically added to this PR in order to
raise the
attention of the committers. Once this issue has been triaged, the `triage`
label
s
github-actions[bot] commented on PR #19231:
URL: https://github.com/apache/kafka/pull/19231#issuecomment-2989693985
A label of 'needs-attention' was automatically added to this PR in order to
raise the
attention of the committers. Once this issue has been triaged, the `triage`
label
s
github-actions[bot] commented on PR #19245:
URL: https://github.com/apache/kafka/pull/19245#issuecomment-2989714997
This PR is being marked as stale since it has not had any activity in 90
days. If you
would like to keep this PR alive, please leave a comment asking for a
review. If the P
github-actions[bot] commented on PR #19079:
URL: https://github.com/apache/kafka/pull/19079#issuecomment-2989714906
This PR is being marked as stale since it has not had any activity in 90
days. If you
would like to keep this PR alive, please leave a comment asking for a
review. If the P
github-actions[bot] commented on PR #17987:
URL: https://github.com/apache/kafka/pull/17987#issuecomment-2989714754
This PR is being marked as stale since it has not had any activity in 90
days. If you
would like to keep this PR alive, please leave a comment asking for a
review. If the P
TaiJuWu commented on code in PR #19822:
URL: https://github.com/apache/kafka/pull/19822#discussion_r2157889011
##
core/src/test/scala/integration/kafka/api/ConsumerBounceTest.scala:
##
@@ -98,230 +90,6 @@ class ConsumerBounceTest extends AbstractConsumerTest with
Logging {
chia7712 commented on code in PR #19807:
URL: https://github.com/apache/kafka/pull/19807#discussion_r2157515448
##
core/src/main/scala/kafka/server/metadata/ClientQuotaMetadataManager.scala:
##
@@ -154,9 +154,9 @@ class ClientQuotaMetadataManager(private[metadata] val
quotaMana
chia7712 merged PR #19776:
URL: https://github.com/apache/kafka/pull/19776
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
chia7712 commented on code in PR #19867:
URL: https://github.com/apache/kafka/pull/19867#discussion_r2157488290
##
core/src/main/scala/kafka/server/ConfigHelper.scala:
##
@@ -86,19 +81,34 @@ class ConfigHelper(metadataCache: MetadataCache, config:
KafkaConfig, configRepo
YutaLin commented on code in PR #19807:
URL: https://github.com/apache/kafka/pull/19807#discussion_r2157612407
##
server/src/main/java/org/apache/kafka/server/ClientQuotaManager.java:
##
@@ -0,0 +1,883 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
apoorvmittal10 commented on PR #19997:
URL: https://github.com/apache/kafka/pull/19997#issuecomment-2989075050
Seems good, after addressing @AndrewJSchofield's comments.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
chia7712 merged PR #19476:
URL: https://github.com/apache/kafka/pull/19476
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
[
https://issues.apache.org/jira/browse/KAFKA-19140?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai resolved KAFKA-19140.
Fix Version/s: 4.2.0
Resolution: Fixed
> ConnectAssignor#performAssignment second p
chia7712 commented on PR #19349:
URL: https://github.com/apache/kafka/pull/19349#issuecomment-2988945048
@FrankYang0529 please fix conflicts
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the sp
chia7712 commented on PR #19993:
URL: https://github.com/apache/kafka/pull/19993#issuecomment-2988949369
@DL1231 could you please also fix the wrong order of arguments used by
`assertEquals`? line#605, line#606, line#616, line#617, and line#622
--
This is an automated message from the Apa
apoorvmittal10 commented on code in PR #19977:
URL: https://github.com/apache/kafka/pull/19977#discussion_r2155592583
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/SimpleHomogeneousAssignmentBuilder.java:
##
@@ -196,10 +196,10 @@ public GroupAssi
AndrewJSchofield merged PR #19963:
URL: https://github.com/apache/kafka/pull/19963
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafk
[
https://issues.apache.org/jira/browse/KAFKA-19239?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai resolved KAFKA-19239.
Fix Version/s: 4.2.0
Resolution: Fixed
> Rewrite IntegrationTestUtils by java
> ---
chia7712 commented on code in PR #19920:
URL: https://github.com/apache/kafka/pull/19920#discussion_r2157497344
##
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/LoggersTest.java:
##
@@ -47,6 +49,11 @@ public void setup() {
time = new MockTime(0, INITIAL
smjn commented on code in PR #19998:
URL: https://github.com/apache/kafka/pull/19998#discussion_r2158120067
##
core/src/main/java/kafka/server/share/SharePartition.java:
##
@@ -2324,8 +2328,12 @@ CompletableFuture
writeShareGroupState(List stateBatc
PartitionEr
masonyc commented on PR #19951:
URL: https://github.com/apache/kafka/pull/19951#issuecomment-2989919270
Hi @Yunyung , thanks for reviewing, can this pr be merged?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
smjn commented on PR #19998:
URL: https://github.com/apache/kafka/pull/19998#issuecomment-2989925253
@apoorvmittal10 Thanks for the review, incorporated comments.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
Copilot commented on code in PR #1:
URL: https://github.com/apache/kafka/pull/1#discussion_r2156902776
##
tests/kafkatest/tests/streams/streams_broker_down_resilience_test.py:
##
@@ -129,10 +129,12 @@ def test_streams_runs_with_broker_down_initially(self,
metadata_quoru
AndrewJSchofield merged PR #19992:
URL: https://github.com/apache/kafka/pull/19992
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafk
[
https://issues.apache.org/jira/browse/KAFKA-19416?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andrew Schofield resolved KAFKA-19416.
--
Fix Version/s: 4.2.0
Resolution: Fixed
> Reduce running time of ShareConsumerTe
Lucas Brutschy created KAFKA-19421:
--
Summary: Deflake streams_broker_down_resilience_test
Key: KAFKA-19421
URL: https://issues.apache.org/jira/browse/KAFKA-19421
Project: Kafka
Issue Type: B
AndrewJSchofield commented on code in PR #19820:
URL: https://github.com/apache/kafka/pull/19820#discussion_r2156911513
##
tools/src/main/java/org/apache/kafka/tools/consumer/group/ShareGroupCommand.java:
##
@@ -366,6 +428,70 @@ Entry>
sendDeleteShareGroupOffsetsRequest(Stri
lucasbru opened a new pull request, #1:
URL: https://github.com/apache/kafka/pull/1
`streams_broker_down_resilience_test` produce messages with `null` key to a
topic with three partitions and expect each partition to be non-empty
afterward. But I don't think this is a correct assump
lucasbru commented on code in PR #19646:
URL: https://github.com/apache/kafka/pull/19646#discussion_r2157280851
##
tools/src/main/java/org/apache/kafka/tools/streams/StreamsGroupCommand.java:
##
@@ -678,29 +692,7 @@ Map deleteGroups() {
});
//
frankvicky merged PR #19989:
URL: https://github.com/apache/kafka/pull/19989
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apac
chia7712 commented on code in PR #19776:
URL: https://github.com/apache/kafka/pull/19776#discussion_r2156544696
##
core/src/test/scala/unit/kafka/server/DescribeQuorumRequestTest.scala:
##
@@ -91,11 +92,8 @@ class DescribeQuorumRequestTest(cluster: ClusterInstance) {
)(
Revi
[
https://issues.apache.org/jira/browse/KAFKA-19406?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai resolved KAFKA-19406.
Fix Version/s: 4.2.0
Resolution: Fixed
> Remove BrokerTopicStats#removeOldFollowerM
apoorvmittal10 commented on PR #19997:
URL: https://github.com/apache/kafka/pull/19997#issuecomment-2987489495
> The test testShareFetchRequestSuccessfulSharingBetweenMultipleConsumers
was recently found to be flaky. Making the following small change that could
potentially resolve the issue
chirag-wadhwa5 commented on PR #19997:
URL: https://github.com/apache/kafka/pull/19997#issuecomment-2987501311
Yes, but we do have many other tests for concurrent fetches in
ShareConsumerTest. This test, as the name suggest, only checks for multiple
share consumers are able to share the sam
AndrewJSchofield commented on code in PR #19997:
URL: https://github.com/apache/kafka/pull/19997#discussion_r2156800313
##
core/src/test/scala/unit/kafka/server/ShareFetchAcknowledgeRequestTest.scala:
##
@@ -1367,55 +1367,50 @@ class ShareFetchAcknowledgeRequestTest(cluster:
Cl
FrankYang0529 opened a new pull request, #2:
URL: https://github.com/apache/kafka/pull/2
Delete this text and replace it with a detailed description of your change.
The
PR title and body will become the squashed commit message.
If you would like to tag individuals, add som
apoorvmittal10 commented on code in PR #19998:
URL: https://github.com/apache/kafka/pull/19998#discussion_r2157024298
##
core/src/main/java/kafka/server/share/SharePartition.java:
##
@@ -501,8 +501,12 @@ public CompletableFuture maybeInitialize() {
if (partiti
lianetm opened a new pull request, #20001:
URL: https://github.com/apache/kafka/pull/20001
Fix to avoid flakiness in verifiable producer system test. The test lists
running processes and greps to find the VerifiableProducer one, but wasn't
providing an specific pattern to grep (so flaky if
lianetm commented on PR #20001:
URL: https://github.com/apache/kafka/pull/20001#issuecomment-2988635221
Here's the system test run for this change, all tests pass
https://confluent-open-source-kafka-branch-builder-system-test-results.s3-us-west-2.amazonaws.com/trunk/2025-06-18--001.dca32b
chirag-wadhwa5 opened a new pull request, #19997:
URL: https://github.com/apache/kafka/pull/19997
The test testShareFetchRequestSuccessfulSharingBetweenMultipleConsumers was
recently found to be flaky. Making the following small change that could
potentially resolve the issue.
--
This is
frankvicky merged PR #19996:
URL: https://github.com/apache/kafka/pull/19996
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apac
chia7712 merged PR #19962:
URL: https://github.com/apache/kafka/pull/19962
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
chia7712 merged PR #19994:
URL: https://github.com/apache/kafka/pull/19994
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
Chia-Ping Tsai created KAFKA-19420:
--
Summary: Don't export SocketServer from ClusterInstance
Key: KAFKA-19420
URL: https://issues.apache.org/jira/browse/KAFKA-19420
Project: Kafka
Issue Type
[
https://issues.apache.org/jira/browse/KAFKA-13077?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17983641#comment-17983641
]
Graeme McRobert commented on KAFKA-13077:
-
The problem has nothing to do with Zo
[
https://issues.apache.org/jira/browse/KAFKA-19420?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
xuanzhang gong reassigned KAFKA-19420:
--
Assignee: xuanzhang gong (was: Chia-Ping Tsai)
> Don't export SocketServer from Clus
gongxuanzhang commented on PR #19962:
URL: https://github.com/apache/kafka/pull/19962#issuecomment-2987022356
@chia7712 PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
chia7712 commented on code in PR #19884:
URL: https://github.com/apache/kafka/pull/19884#discussion_r2156633321
##
clients/src/test/java/org/apache/kafka/test/TestUtils.java:
##
@@ -319,6 +321,18 @@ public static File randomPartitionLogDir(File parentDir) {
throw new Ru
chia7712 commented on code in PR #19776:
URL: https://github.com/apache/kafka/pull/19776#discussion_r2156558942
##
core/src/test/scala/unit/kafka/server/GroupCoordinatorBaseRequestTest.scala:
##
@@ -900,42 +901,32 @@ class GroupCoordinatorBaseRequestTest(cluster:
ClusterInstanc
smjn opened a new pull request, #19998:
URL: https://github.com/apache/kafka/pull/19998
* Few logs in `PersisterStateManager` were noisy and not adding much value.
* For the sake of reducing pollution, they have been moved to debug level.
* Additional debug log in `DefaultStatePersister
AndrewJSchofield commented on PR #19820:
URL: https://github.com/apache/kafka/pull/19820#issuecomment-2987824602
@JimmyWang6 There's a build failure due to spotless check. Please resolve it
and merge latest changes.
--
This is an automated message from the Apache Git Service.
To respond t
AndrewJSchofield merged PR #19986:
URL: https://github.com/apache/kafka/pull/19986
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafk
m1a2st commented on code in PR #19993:
URL: https://github.com/apache/kafka/pull/19993#discussion_r2156301058
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/SubscriptionStateTest.java:
##
@@ -200,7 +200,7 @@ public void verifyAssignmentId() {
asser
kumarpritam863 commented on PR #19341:
URL: https://github.com/apache/kafka/pull/19341#issuecomment-2987117286
Hi @mimaison ,
Thanks for the input — I completely agree it's worth discussing this
carefully.
That said, I'm a bit unsure how this would break existing deployments, since
junrao commented on code in PR #19964:
URL: https://github.com/apache/kafka/pull/19964#discussion_r2156322849
##
clients/src/main/java/org/apache/kafka/common/TopicIdPartition.java:
##
@@ -78,6 +80,21 @@ public TopicPartition topicPartition() {
return topicPartition;
58 matches
Mail list logo
