Re: [PR] KAFKA-18462: Upgrade RocksDB dependency from 9.7.3 to 10.1.3 [kafka]

2025-06-16 Thread via GitHub
cadonna commented on PR #19880: URL: https://github.com/apache/kafka/pull/19880#issuecomment-2975408545 I would not open a PR against 1.4. The release branch is cut and it does not seem that this change is critical to the release. I will set the `Fixed Version` field for this ticket to `4.2

Re: [PR] MINOR: add lower case lister name integration test [kafka]

2025-06-16 Thread via GitHub
FrankYang0529 commented on PR #19932: URL: https://github.com/apache/kafka/pull/19932#issuecomment-2976195389 @chia7712 I add a unit test `testLowercaseControllerListenerNames` for it. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please l

Re: [PR] KAFKA-19397: Not relaying on metadata to map between topic id and name. [kafka]

2025-06-16 Thread via GitHub
lucasbru commented on PR #19964: URL: https://github.com/apache/kafka/pull/19964#issuecomment-2975852521 @junrao I redeployed the soak with the fix. I will report back if the problem reoccurs -- This is an automated message from the Apache Git Service. To respond to the message, please lo

[PR] KAFKA-19042 Move ProducerSendWhileDeletionTest to client-integration-tests module [kafka]

2025-06-16 Thread via GitHub
m1a2st opened a new pull request, #19971: URL: https://github.com/apache/kafka/pull/19971 Use Java to rewrite ProducerSendWhileDeletionTest by new test infra and move it to client-integration-tests module. -- This is an automated message from the Apache Git Service. To respond to the mess

[jira] [Resolved] (KAFKA-16906) Add consistent error handling for Transactions

2025-06-16 Thread Kaushik Raina (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16906?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kaushik Raina resolved KAFKA-16906. --- Resolution: Fixed > Add consistent error handling for Transactions > ---

Re: [PR] HOTFIX: Correcting build after cherry-pick [kafka]

2025-06-16 Thread via GitHub
apoorvmittal10 merged PR #19969: URL: https://github.com/apache/kafka/pull/19969 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.

[PR] HOTFIX: Correcting build after cherry-pick [kafka]

2025-06-16 Thread via GitHub
apoorvmittal10 opened a new pull request, #19969: URL: https://github.com/apache/kafka/pull/19969 Fixing build after cherrypicking: ``` commit 254c1fa519b37bddc2488e80979406129fd56808 Author: Apoorv Mittal Date: Thu Jun 12 22:52:50 2025 +0100 MINOR: Fixing clien

Re: [PR] KAFKA-19283: Update transaction exception handling documentation [kafka]

2025-06-16 Thread via GitHub
k-raina commented on PR #19931: URL: https://github.com/apache/kafka/pull/19931#issuecomment-2975598598 @mimaison Sorry missed your ping on PR. I have closed respective JIRAs -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[PR] KAFKA-19408 : Add check for compression type mismatch for push telemetry requests [kafka]

2025-06-16 Thread via GitHub
k-raina opened a new pull request, #19970: URL: https://github.com/apache/kafka/pull/19970 ## Problem The current issue is that when a client sends a push telemetry request with a compression type different from the broker's preferred compression type (the first in the list of supported

[jira] [Resolved] (KAFKA-19283) Update Apache kafka public documentation

2025-06-16 Thread Kaushik Raina (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19283?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kaushik Raina resolved KAFKA-19283. --- Resolution: Fixed > Update Apache kafka public documentation > -

[PR] Minor: Restore original behavior of GroupAuthorizerIntegrationTest [kafka]

2025-06-16 Thread via GitHub
Rancho-7 opened a new pull request, #19968: URL: https://github.com/apache/kafka/pull/19968 this is a follow-up for https://github.com/apache/kafka/pull/19685 The timeout issue in `AsyncConsumer#unsubscribe` was fixed by https://github.com/apache/kafka/pull/19779. As a result, the tes

[jira] [Resolved] (KAFKA-18462) Upgrade RocksDB dependency from 9.7.3 to something newer

2025-06-16 Thread Bruno Cadonna (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18462?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Cadonna resolved KAFKA-18462. --- Resolution: Fixed > Upgrade RocksDB dependency from 9.7.3 to something newer > -

[jira] [Updated] (KAFKA-18462) Upgrade RocksDB dependency from 9.7.3 to something newer

2025-06-16 Thread Bruno Cadonna (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18462?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Cadonna updated KAFKA-18462: -- Fix Version/s: 4.2.0 (was: 4.1.0) > Upgrade RocksDB dependency from 9.7

[jira] [Assigned] (KAFKA-19409) CLONE - Upgrade RocksDB dependency from 10.1.3 to something newer

2025-06-16 Thread Bruno Cadonna (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19409?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Cadonna reassigned KAFKA-19409: - Assignee: (was: Kuan Po Tseng) > CLONE - Upgrade RocksDB dependency from 10.1.3 to

[jira] [Updated] (KAFKA-19409) CLONE - Upgrade RocksDB dependency from 10.1.3 to something newer

2025-06-16 Thread Bruno Cadonna (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19409?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Cadonna updated KAFKA-19409: -- Affects Version/s: 4.2.0 (was: 4.0.0) > CLONE - Upgrade RocksDB dep

[jira] [Created] (KAFKA-19409) CLONE - Upgrade RocksDB dependency from 10.1.3 to something newer

2025-06-16 Thread Bruno Cadonna (Jira)
Bruno Cadonna created KAFKA-19409: - Summary: CLONE - Upgrade RocksDB dependency from 10.1.3 to something newer Key: KAFKA-19409 URL: https://issues.apache.org/jira/browse/KAFKA-19409 Project: Kafka

[jira] [Updated] (KAFKA-19409) CLONE - Upgrade RocksDB dependency from 10.1.3 to something newer

2025-06-16 Thread Bruno Cadonna (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19409?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Cadonna updated KAFKA-19409: -- Description: We will upgrade RocksDB to 10.1.3 with 4.2 release. We should evaluate if we ca

[jira] [Updated] (KAFKA-19409) CLONE - Upgrade RocksDB dependency from 10.1.3 to something newer

2025-06-16 Thread Bruno Cadonna (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19409?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Cadonna updated KAFKA-19409: -- Fix Version/s: 4.3.0 (was: 4.2.0) > CLONE - Upgrade RocksDB dependency

[jira] [Updated] (KAFKA-19409) Upgrade RocksDB dependency from 10.1.3 to something newer

2025-06-16 Thread Bruno Cadonna (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19409?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Cadonna updated KAFKA-19409: -- Summary: Upgrade RocksDB dependency from 10.1.3 to something newer (was: CLONE - Upgrade Rock

Re: [PR] KAFKA-19239 Rewrite IntegrationTestUtils by java [kafka]

2025-06-16 Thread via GitHub
jim0987795064 commented on PR #19776: URL: https://github.com/apache/kafka/pull/19776#issuecomment-2976377683 Hello, @chia7712 @m1a2st I've addressed the issues mentioned above. Could you please review these? Many Thanks! -- This is an automated message from the Apache Git Service. To r

[jira] [Commented] (KAFKA-19409) Upgrade RocksDB dependency from 10.1.3 to something newer

2025-06-16 Thread Bruno Cadonna (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17979229#comment-17979229 ] Bruno Cadonna commented on KAFKA-19409: --- [~maheshsambaram] Thank you for your inte

Re: [PR] KAFKA-18486: Remove ReplicaManager#becomeLeaderOrFollower [kafka]

2025-06-16 Thread via GitHub
chia7712 merged PR #19966: URL: https://github.com/apache/kafka/pull/19966 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

[jira] [Comment Edited] (KAFKA-19409) Upgrade RocksDB dependency from 10.1.3 to something newer

2025-06-16 Thread Mahesh Sambaram (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17979236#comment-17979236 ] Mahesh Sambaram edited comment on KAFKA-19409 at 6/16/25 1:47 PM:

Re: [PR] MINOR: add lower case lister name integration test [kafka]

2025-06-16 Thread via GitHub
chia7712 commented on code in PR #19932: URL: https://github.com/apache/kafka/pull/19932#discussion_r2150304329 ## test-common/test-common-runtime/src/main/java/org/apache/kafka/common/test/KafkaClusterTestKit.java: ## @@ -556,7 +556,7 @@ public String bootstrapServers() {

Re: [PR] KAFKA-1940: Remove BrokerTopicStats#removeOldFollowerMetrics [kafka]

2025-06-16 Thread via GitHub
Yunyung commented on PR #19962: URL: https://github.com/apache/kafka/pull/19962#issuecomment-2977114376 LGTM, please correct the Jira number in PR title. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[jira] [Created] (KAFKA-19410) Validate alignment of subscribed topics and assigned partitions in share consumer

2025-06-16 Thread Andrew Schofield (Jira)
Andrew Schofield created KAFKA-19410: Summary: Validate alignment of subscribed topics and assigned partitions in share consumer Key: KAFKA-19410 URL: https://issues.apache.org/jira/browse/KAFKA-19410

Re: [PR] MINOR: add lower case lister name integration test [kafka]

2025-06-16 Thread via GitHub
chia7712 commented on code in PR #19932: URL: https://github.com/apache/kafka/pull/19932#discussion_r2150303430 ## test-common/test-common-runtime/src/main/java/org/apache/kafka/common/test/KafkaClusterTestKit.java: ## @@ -556,7 +556,7 @@ public String bootstrapServers() {

[jira] [Resolved] (KAFKA-16778) AsyncKafkaConsumer fetcher might occasionally try to fetch to a revoked partition

2025-06-16 Thread Lianet Magrans (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16778?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lianet Magrans resolved KAFKA-16778. Resolution: Fixed This was fixed by moving all subscription state changes to the backgroun

Re: [PR] KAFKA-14145; Faster KRaft HWM replication [kafka]

2025-06-16 Thread via GitHub
jsancio commented on code in PR #19800: URL: https://github.com/apache/kafka/pull/19800#discussion_r2150825590 ## raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java: ## @@ -2882,6 +2908,7 @@ private FetchRequestData buildFetchRequest() { .setLastFetch

[jira] [Assigned] (KAFKA-19406) Remove BrokerTopicStats#removeOldFollowerMetrics

2025-06-16 Thread xuanzhang gong (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19406?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] xuanzhang gong reassigned KAFKA-19406: -- Assignee: xuanzhang gong (was: Chia-Ping Tsai) > Remove BrokerTopicStats#removeOldFo

[jira] [Commented] (KAFKA-19406) Remove BrokerTopicStats#removeOldFollowerMetrics

2025-06-16 Thread xuanzhang gong (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17979552#comment-17979552 ] xuanzhang gong commented on KAFKA-19406: hi [~chia7712]  I have fixed it. plz a

Re: [PR] MINOR: replace test "catch exception" by assertThrows [kafka]

2025-06-16 Thread via GitHub
FrankYang0529 commented on code in PR #19975: URL: https://github.com/apache/kafka/pull/19975#discussion_r2151426572 ## clients/src/test/java/org/apache/kafka/common/metrics/MetricsTest.java: ## @@ -700,24 +681,15 @@ public void testMetricInstances() { assertEquals(

[jira] [Commented] (KAFKA-19409) Upgrade RocksDB dependency from 10.1.3 to something newer

2025-06-16 Thread Mahesh Sambaram (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17978631#comment-17978631 ] Mahesh Sambaram commented on KAFKA-19409: - Hi[~mjsax] , I would like to contribu

Re: [PR] MINOR: Restore original behavior of GroupAuthorizerIntegrationTest [kafka]

2025-06-16 Thread via GitHub
chia7712 commented on PR #19968: URL: https://github.com/apache/kafka/pull/19968#issuecomment-2975690837 @Rancho-7 could you please loop the test to ensure it is stable? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[jira] [Updated] (KAFKA-19042) Move kafka.api test cases to clients-integration-tests module

2025-06-16 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-19042?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] 黃竣陽 updated KAFKA-19042: Description: This is an umbrella Jira about moving integration tests from kafka.api module to clients-integration

[jira] [Commented] (KAFKA-19368) DescribeLogDirs API should include the partition size in the remote storage

2025-06-16 Thread PoAn Yang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19368?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17979258#comment-17979258 ] PoAn Yang commented on KAFKA-19368: --- Discussion thread: [https://lists.apache.org/thr

Re: [PR] KAFKA-19239 Rewrite IntegrationTestUtils by java [kafka]

2025-06-16 Thread via GitHub
chia7712 commented on code in PR #19776: URL: https://github.com/apache/kafka/pull/19776#discussion_r2150020977 ## server-common/src/test/java/org/apache/kafka/server/IntegrationTestUtils.java: ## @@ -0,0 +1,87 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under on

[jira] [Updated] (KAFKA-19407) OffsetsOutOfOrderException on followers due to the race condition in the leader

2025-06-16 Thread Haruki Okada (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19407?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Haruki Okada updated KAFKA-19407: - Description: h2. Environment * Kafka version: 3.3.2 (But we suppose this issue still exists in

Re: [PR] [WIP]KAFKA-18896 add KIP-877 support for Login [kafka]

2025-06-16 Thread via GitHub
m1a2st commented on code in PR #19527: URL: https://github.com/apache/kafka/pull/19527#discussion_r2150148047 ## clients/src/main/java/org/apache/kafka/common/security/authenticator/LoginManager.java: ## @@ -53,20 +56,30 @@ public class LoginManager { // dynamic configs (br

Re: [PR] MINOR: rename exception `e` to `swallow` where appropriate [kafka]

2025-06-16 Thread via GitHub
ijuma commented on code in PR #19948: URL: https://github.com/apache/kafka/pull/19948#discussion_r2150617216 ## clients/src/test/java/org/apache/kafka/clients/consumer/KafkaConsumerTest.java: ## @@ -1977,7 +1977,7 @@ public void testOperationsBySubscribingConsumerWithDefaultGro

Re: [PR] KAFKA-14145; Faster KRaft HWM replication [kafka]

2025-06-16 Thread via GitHub
mumrah commented on code in PR #19800: URL: https://github.com/apache/kafka/pull/19800#discussion_r2150719050 ## raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java: ## @@ -1514,19 +1527,22 @@ private CompletableFuture handleFetchRequest( || FetchResponse

Re: [PR] MINOR: rename exception `e` to `swallow` where appropriate [kafka]

2025-06-16 Thread via GitHub
ijuma commented on code in PR #19948: URL: https://github.com/apache/kafka/pull/19948#discussion_r2150617216 ## clients/src/test/java/org/apache/kafka/clients/consumer/KafkaConsumerTest.java: ## @@ -1977,7 +1977,7 @@ public void testOperationsBySubscribingConsumerWithDefaultGro

[jira] [Commented] (KAFKA-19409) Upgrade RocksDB dependency from 10.1.3 to something newer

2025-06-16 Thread Bruno Cadonna (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17979262#comment-17979262 ] Bruno Cadonna commented on KAFKA-19409: --- Look into these tickets: https://issues.

[jira] [Resolved] (KAFKA-15282) Implement client support for KIP-848 client-side assignors

2025-06-16 Thread Lianet Magrans (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15282?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lianet Magrans resolved KAFKA-15282. Resolution: Won't Fix Closing as won't do as client-side assignors are not in scope for no

[jira] [Updated] (KAFKA-19393) Consolidate consumer assignment state views

2025-06-16 Thread Lianet Magrans (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19393?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lianet Magrans updated KAFKA-19393: --- Labels: kip-848-client-support (was: ) > Consolidate consumer assignment state views >

[jira] [Resolved] (KAFKA-15279) Implement client support for KIP-848 client-side assigner RPCs

2025-06-16 Thread Lianet Magrans (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15279?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lianet Magrans resolved KAFKA-15279. Resolution: Won't Fix Closing as won't do as client-side assignors are not in scope for no

[jira] [Updated] (KAFKA-19259) Async consumer fetch intermittent delays on console consumer

2025-06-16 Thread Lianet Magrans (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19259?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lianet Magrans updated KAFKA-19259: --- Labels: consumer-threading-refactor (was: ) > Async consumer fetch intermittent delays on c

[jira] [Commented] (KAFKA-15307) Kafka Streams configuration docs outdated

2025-06-16 Thread Mahesh Sambaram (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17979278#comment-17979278 ] Mahesh Sambaram commented on KAFKA-15307: - Hi [~mjsax] , can i work on this > K

[jira] [Updated] (KAFKA-18812) Improve new consumer API errors upon background thread failures

2025-06-16 Thread Lianet Magrans (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18812?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lianet Magrans updated KAFKA-18812: --- Fix Version/s: 4.2.0 > Improve new consumer API errors upon background thread failures > ---

[jira] [Commented] (KAFKA-18812) Improve new consumer API errors upon background thread failures

2025-06-16 Thread Lianet Magrans (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18812?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17979279#comment-17979279 ] Lianet Magrans commented on KAFKA-18812: Hey [~frankvicky], is this something yo

Re: [PR] MINOR: add lower case lister name integration test [kafka]

2025-06-16 Thread via GitHub
FrankYang0529 commented on code in PR #19932: URL: https://github.com/apache/kafka/pull/19932#discussion_r2150342733 ## test-common/test-common-runtime/src/main/java/org/apache/kafka/common/test/KafkaClusterTestKit.java: ## @@ -556,7 +556,7 @@ public String bootstrapServers() {

Re: [PR] KAFKA-14145; Faster KRaft HWM replication [kafka]

2025-06-16 Thread via GitHub
jsancio commented on code in PR #19800: URL: https://github.com/apache/kafka/pull/19800#discussion_r2150840804 ## raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java: ## @@ -1514,19 +1527,22 @@ private CompletableFuture handleFetchRequest( || FetchRespons

Re: [PR] KAFKA-14145; Faster KRaft HWM replication [kafka]

2025-06-16 Thread via GitHub
jsancio commented on code in PR #19800: URL: https://github.com/apache/kafka/pull/19800#discussion_r2150833728 ## raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java: ## @@ -386,6 +385,11 @@ private void onUpdateLeaderHighWatermark( // records still held i

Re: [PR] KAFKA-19297: Refactor AsyncKafkaConsumer's use of Java Streams APIs in critical sections [kafka]

2025-06-16 Thread via GitHub
kirktrue commented on code in PR #19917: URL: https://github.com/apache/kafka/pull/19917#discussion_r2150887174 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractFetch.java: ## @@ -470,7 +475,19 @@ protected Map prepareFetchRequests() }

Re: [PR] KAFKA-14830: Illegal state error in transactional producer [kafka]

2025-06-16 Thread via GitHub
kirktrue commented on PR #17022: URL: https://github.com/apache/kafka/pull/17022#issuecomment-2978134097 @jolshan @mjsax—Another ping to check if we can merge... Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[jira] [Commented] (KAFKA-19331) No error handling for leader not appeared in applyLocalFollowersDelta

2025-06-16 Thread Naman Kumar Singh (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17979315#comment-17979315 ] Naman Kumar Singh commented on KAFKA-19331: --- [~mingyen066]  if you are not wor

[PR] MINOR: in min.insync.replicas config doc, explicitly state that all ISR must ack when acks=all [kafka]

2025-06-16 Thread via GitHub
davetroiano opened a new pull request, #19973: URL: https://github.com/apache/kafka/pull/19973 PR prompted by discussion with @mjsax Prior to this change, the doc for `min.insync.replicas` could have been interpreted as being used to short-circuit in the `acks=all` case (e.g., see th

Re: [PR] MINOR: in min.insync.replicas config doc, explicitly state that all ISR must ack when acks=all [kafka]

2025-06-16 Thread via GitHub
mjsax commented on code in PR #19973: URL: https://github.com/apache/kafka/pull/19973#discussion_r2150915147 ## clients/src/main/java/org/apache/kafka/common/config/TopicConfig.java: ## @@ -169,10 +169,13 @@ public class TopicConfig { "to trigger the unclean leader ele

Re: [PR] MINOR: in min.insync.replicas config doc, explicitly state that all ISR must ack when acks=all [kafka]

2025-06-16 Thread via GitHub
davetroiano commented on code in PR #19973: URL: https://github.com/apache/kafka/pull/19973#discussion_r2150923369 ## clients/src/main/java/org/apache/kafka/common/config/TopicConfig.java: ## @@ -169,10 +169,13 @@ public class TopicConfig { "to trigger the unclean lead

Re: [PR] MINOR: in min.insync.replicas config doc, explicitly state that all ISR must ack when acks=all [kafka]

2025-06-16 Thread via GitHub
mjsax commented on code in PR #19973: URL: https://github.com/apache/kafka/pull/19973#discussion_r2150915147 ## clients/src/main/java/org/apache/kafka/common/config/TopicConfig.java: ## @@ -169,10 +169,13 @@ public class TopicConfig { "to trigger the unclean leader ele

Re: [PR] KAFKA-19297: Refactor AsyncKafkaConsumer's use of Java Streams APIs in critical sections [kafka]

2025-06-16 Thread via GitHub
kirktrue commented on code in PR #19917: URL: https://github.com/apache/kafka/pull/19917#discussion_r2150942035 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractFetch.java: ## @@ -470,7 +475,19 @@ protected Map prepareFetchRequests() }

Re: [PR] KAFKA-19297: Refactor AsyncKafkaConsumer's use of Java Streams APIs in critical sections [kafka]

2025-06-16 Thread via GitHub
kirktrue commented on code in PR #19917: URL: https://github.com/apache/kafka/pull/19917#discussion_r2150942923 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractMembershipManager.java: ## @@ -1135,7 +1134,9 @@ CompletableFuture revokePartitions(Set p

Re: [PR] KAFKA-19297: Refactor AsyncKafkaConsumer's use of Java Streams APIs in critical sections [kafka]

2025-06-16 Thread via GitHub
kirktrue commented on code in PR #19917: URL: https://github.com/apache/kafka/pull/19917#discussion_r2150944599 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/events/CompletableEventReaper.java: ## @@ -166,9 +161,48 @@ public boolean contains(CompletableEve

Re: [PR] KAFKA-19297: Refactor AsyncKafkaConsumer's use of Java Streams APIs in critical sections [kafka]

2025-06-16 Thread via GitHub
kirktrue commented on code in PR #19917: URL: https://github.com/apache/kafka/pull/19917#discussion_r2150949379 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/events/CompletableEventReaper.java: ## @@ -166,9 +161,48 @@ public boolean contains(CompletableEve

Re: [PR] KAFKA-19297: Refactor AsyncKafkaConsumer's use of Java Streams APIs in critical sections [kafka]

2025-06-16 Thread via GitHub
kirktrue commented on code in PR #19917: URL: https://github.com/apache/kafka/pull/19917#discussion_r2150944024 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/events/ApplicationEventProcessor.java: ## @@ -310,7 +311,9 @@ private void process(final Assignmen

Re: [PR] KAFKA-19297: Refactor AsyncKafkaConsumer's use of Java Streams APIs in critical sections [kafka]

2025-06-16 Thread via GitHub
kirktrue commented on code in PR #19917: URL: https://github.com/apache/kafka/pull/19917#discussion_r2150942549 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerMembershipManager.java: ## @@ -414,8 +413,8 @@ public CompletableFuture signalPartitionsR

Re: [PR] [WIP]KAFKA-18896 add KIP-877 support for Login [kafka]

2025-06-16 Thread via GitHub
m1a2st commented on code in PR #19527: URL: https://github.com/apache/kafka/pull/19527#discussion_r2150148047 ## clients/src/main/java/org/apache/kafka/common/security/authenticator/LoginManager.java: ## @@ -53,20 +56,30 @@ public class LoginManager { // dynamic configs (br

[jira] [Commented] (KAFKA-19409) Upgrade RocksDB dependency from 10.1.3 to something newer

2025-06-16 Thread Mahesh Sambaram (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17979236#comment-17979236 ] Mahesh Sambaram commented on KAFKA-19409: - [~cadonna] , thank you replying. Can

[jira] [Commented] (KAFKA-16870) Values.parseString returns objects which fail ConnectSchema.validateValue

2025-06-16 Thread Ksolves India Limited (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17979233#comment-17979233 ] Ksolves India Limited commented on KAFKA-16870: --- Hi [~gharris1727]  Can yo

Re: [PR] [WIP]KAFKA-18896 add KIP-877 support for Login [kafka]

2025-06-16 Thread via GitHub
chia7712 commented on code in PR #19527: URL: https://github.com/apache/kafka/pull/19527#discussion_r2149989221 ## clients/src/main/java/org/apache/kafka/common/security/authenticator/LoginManager.java: ## @@ -53,20 +56,30 @@ public class LoginManager { // dynamic configs (

[PR] KAFKA-19407 Fix potential IllegalStateException when appending to timeIndex [kafka]

2025-06-16 Thread via GitHub
ocadaruma opened a new pull request, #19972: URL: https://github.com/apache/kafka/pull/19972 ## Summary - Fix potential race condition in LogSegment#readMaxTimestampAndOffsetSoFar(), which may result in non-monotonic offsets and causes replication to stop. - See https://issues.apache.

[jira] [Commented] (KAFKA-19410) Validate alignment of subscribed topics and assigned partitions in share consumer

2025-06-16 Thread PoAn Yang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17979268#comment-17979268 ] PoAn Yang commented on KAFKA-19410: --- Hi Andrew, if you're not working on this, may I t

Re: [PR] MINOR: in min.insync.replicas config doc, explicitly state that all ISR must ack when acks=all [kafka]

2025-06-16 Thread via GitHub
mjsax merged PR #19973: URL: https://github.com/apache/kafka/pull/19973 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or

Re: [PR] MINOR: in min.insync.replicas config doc, explicitly state that all ISR must ack when acks=all [kafka]

2025-06-16 Thread via GitHub
mjsax commented on PR #19973: URL: https://github.com/apache/kafka/pull/19973#issuecomment-2978661257 Thanks for the PR. Merged to `trunk` and cherry-picked to `4.1.` branch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[PR] KAFKA-19367: Follow up bug fix [kafka]

2025-06-16 Thread via GitHub
rreddy-22 opened a new pull request, #19976: URL: https://github.com/apache/kafka/pull/19976 This is a follow up to [https://github.com/apache/kafka/pull/19910](url) `The coordinator failed to write an epoch fence transition for producer jt142 to the transaction log with error COORDINATOR

Re: [PR] Update EndToEndLatency.java [kafka]

2025-06-16 Thread via GitHub
github-actions[bot] commented on PR #19934: URL: https://github.com/apache/kafka/pull/19934#issuecomment-2978805650 A label of 'needs-attention' was automatically added to this PR in order to raise the attention of the committers. Once this issue has been triaged, the `triage` label s

Re: [PR] MINOR: Update Protocol Buffers documentation URLs [kafka]

2025-06-16 Thread via GitHub
github-actions[bot] commented on PR #19930: URL: https://github.com/apache/kafka/pull/19930#issuecomment-2978805674 A label of 'needs-attention' was automatically added to this PR in order to raise the attention of the committers. Once this issue has been triaged, the `triage` label s

[jira] [Commented] (KAFKA-19407) OffsetsOutOfOrderException on followers due to the race condition in the leader

2025-06-16 Thread Haruki Okada (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17979322#comment-17979322 ] Haruki Okada commented on KAFKA-19407: -- [~ijuma] [~chia7712]  Hi, I submitted [the

Re: [PR] MINOR: in min.insync.replicas config doc, explicitly state that all ISR must ack when acks=all [kafka]

2025-06-16 Thread via GitHub
mjsax commented on code in PR #19973: URL: https://github.com/apache/kafka/pull/19973#discussion_r2150929147 ## clients/src/main/java/org/apache/kafka/common/config/TopicConfig.java: ## @@ -169,10 +169,13 @@ public class TopicConfig { "to trigger the unclean leader ele

[jira] [Assigned] (KAFKA-18812) Improve new consumer API errors upon background thread failures

2025-06-16 Thread TengYao Chi (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18812?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] TengYao Chi reassigned KAFKA-18812: --- Assignee: Lianet Magrans (was: TengYao Chi) > Improve new consumer API errors upon backgro

[jira] [Commented] (KAFKA-18812) Improve new consumer API errors upon background thread failures

2025-06-16 Thread TengYao Chi (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18812?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17979347#comment-17979347 ] TengYao Chi commented on KAFKA-18812: - As offline discussion, I have assigned to you

Re: [PR] KAFKA-19411: Fix deleteAcls bug which allows more deletions than max records per user op [kafka]

2025-06-16 Thread via GitHub
cmccabe commented on PR #19974: URL: https://github.com/apache/kafka/pull/19974#issuecomment-2978488144 Thanks for this fix! One problem I see is that this will allow the deletion to partly go through, until we run out of records. It would be better for the deletion to fail completely or su

Re: [PR] KAFKA-14145; Faster KRaft HWM replication [kafka]

2025-06-16 Thread via GitHub
jsancio commented on code in PR #19800: URL: https://github.com/apache/kafka/pull/19800#discussion_r2150841657 ## clients/src/main/resources/common/message/FetchRequest.json: ## @@ -103,7 +105,10 @@ { "name": "PartitionMaxBytes", "type": "int32", "versions": "0+",

[PR] Fix deleteAcls bug which allows more deletions than max records per user op [kafka]

2025-06-16 Thread via GitHub
ahuang98 opened a new pull request, #19974: URL: https://github.com/apache/kafka/pull/19974 If there are more deletion filters after we initially hit the `MAX_RECORDS_PER_USER_OP` bound, we will add an additional deletion record ontop of that for each additional filter. -- This is an aut

[jira] [Assigned] (KAFKA-19410) Validate alignment of subscribed topics and assigned partitions in share consumer

2025-06-16 Thread PoAn Yang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19410?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] PoAn Yang reassigned KAFKA-19410: - Assignee: PoAn Yang > Validate alignment of subscribed topics and assigned partitions in share

[PR] MINOR: replace test "catch exception" by assertThrows [kafka]

2025-06-16 Thread via GitHub
DL1231 opened a new pull request, #19975: URL: https://github.com/apache/kafka/pull/19975 see https://github.com/apache/kafka/pull/19948#discussion_r2150617216, replace test "catch exception" by assertThrows. -- This is an automated message from the Apache Git Service. To respond to t

Re: [PR] KAFKA-14830: Illegal state error in transactional producer [kafka]

2025-06-16 Thread via GitHub
jolshan commented on code in PR #17022: URL: https://github.com/apache/kafka/pull/17022#discussion_r2151075013 ## clients/src/main/java/org/apache/kafka/clients/producer/internals/TransactionManager.java: ## @@ -779,14 +779,25 @@ public synchronized void maybeTransitionToErrorS

[jira] [Commented] (KAFKA-19331) No error handling for leader not appeared in applyLocalFollowersDelta

2025-06-16 Thread Ming-Yen Chung (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17979354#comment-17979354 ] Ming-Yen Chung commented on KAFKA-19331: [~naman_singh] Sorry, I’ve already revi

Re: [PR] MINOR: describeTopics should pass the timeout to the describeCluster call [kafka]

2025-06-16 Thread via GitHub
github-actions[bot] commented on PR #19203: URL: https://github.com/apache/kafka/pull/19203#issuecomment-2978828856 This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please leave a comment asking for a review. If the P

[jira] [Commented] (KAFKA-19406) Remove BrokerTopicStats#removeOldFollowerMetrics

2025-06-16 Thread Jimmy Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17979356#comment-17979356 ] Jimmy Wang commented on KAFKA-19406: Hi [~chia7712] , I could help with this issue

[jira] [Assigned] (KAFKA-19411) Delete ACLs records can exceed max records per user op

2025-06-16 Thread Alyssa Huang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19411?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alyssa Huang reassigned KAFKA-19411: Assignee: Alyssa Huang > Delete ACLs records can exceed max records per user op > ---

[jira] [Created] (KAFKA-19411) Delete ACLs records can exceed max records per user op

2025-06-16 Thread Alyssa Huang (Jira)
Alyssa Huang created KAFKA-19411: Summary: Delete ACLs records can exceed max records per user op Key: KAFKA-19411 URL: https://issues.apache.org/jira/browse/KAFKA-19411 Project: Kafka Issue

Re: [PR] KAFKA-18627: Deprecated "org.apache.kafka.disallowed.login.modules" [kafka]

2025-06-16 Thread via GitHub
gongxuanzhang commented on PR #18683: URL: https://github.com/apache/kafka/pull/18683#issuecomment-2978633312 @chia7712 PTAL -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[jira] [Commented] (KAFKA-15307) Kafka Streams configuration docs outdated

2025-06-16 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17979339#comment-17979339 ] Matthias J. Sax commented on KAFKA-15307: - Thanks for you interest. Assigned the

[jira] [Assigned] (KAFKA-15307) Kafka Streams configuration docs outdated

2025-06-16 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15307?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax reassigned KAFKA-15307: --- Assignee: Mahesh Sambaram > Kafka Streams configuration docs outdated > ---

Re: [PR] Add a SelectorProvider that reuses custom provider implementations. [kafka]

2025-06-16 Thread via GitHub
github-actions[bot] commented on PR #19186: URL: https://github.com/apache/kafka/pull/19186#issuecomment-2978828826 This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please leave a comment asking for a review. If the P

[jira] [Commented] (KAFKA-19406) Remove BrokerTopicStats#removeOldFollowerMetrics

2025-06-16 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17979551#comment-17979551 ] Chia-Ping Tsai commented on KAFKA-19406: The PR is ready :) https://github.com/