Re: [PR] KAFKA-18486: Migrate testPartitionMetadataFile to use applyDelta in place of deprecated becomeLeaderOrFollower [kafka]

2025-06-11 Thread via GitHub
chia7712 commented on PR #19947: URL: https://github.com/apache/kafka/pull/19947#issuecomment-2962192139 @jingjia88 please fix the conflicts -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

Re: [PR] KAFKA-18486 Update testClearPurgatoryOnBecomingFollower etc with KRaft mechanism in ReplicaManagerTest [kafka]

2025-06-11 Thread via GitHub
chia7712 merged PR #19924: URL: https://github.com/apache/kafka/pull/19924 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

[jira] [Commented] (KAFKA-19376) Throw an error message if any unsupported feature is used with KIP-1071

2025-06-11 Thread Lucas Brutschy (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17959709#comment-17959709 ] Lucas Brutschy commented on KAFKA-19376: * Online migration there is no explicit

Re: [PR] MINOR: Cleanup simplify set initialization with Set.of [kafka]

2025-06-11 Thread via GitHub
chia7712 merged PR #19925: URL: https://github.com/apache/kafka/pull/19925 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

[PR] MINOR: Bump commons beanutils39 [kafka]

2025-06-11 Thread via GitHub
showuon opened a new pull request, #19949: URL: https://github.com/apache/kafka/pull/19949 trunk PR: https://github.com/apache/kafka/pull/19939 Bump the commons-beanutils for https://github.com/advisories/GHSA-wxr5-93ph-8wr9. Since commons-validator hasn't had new release with newe

[jira] [Commented] (KAFKA-9060) Publish BOMs for Kafka

2025-06-11 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-9060?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17959668#comment-17959668 ] Marcel Stör commented on KAFKA-9060: This would be most welcome! Particularly so in s

Re: [PR] KAFKA-18486:Remove ReplicaManager#becomeLeaderOrFollower in `testVerificationErrorConversions` [kafka]

2025-06-11 Thread via GitHub
chia7712 merged PR #19923: URL: https://github.com/apache/kafka/pull/19923 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

Re: [PR] KAFKA-10551: Add topic id support to produce request and response [kafka]

2025-06-11 Thread via GitHub
lucasbru commented on PR #15968: URL: https://github.com/apache/kafka/pull/15968#issuecomment-2962350719 @OmniaGM I don't think the test recreates topics. What I have seen is that sometimes a rebootstrap of the producer happened around the same time. But indeed, if we can avoid the addition

Re: [PR] KAFKA-18961: Time-based refresh for server-side RE2J regex [kafka]

2025-06-11 Thread via GitHub
dajac commented on code in PR #19904: URL: https://github.com/apache/kafka/pull/19904#discussion_r2139938164 ## core/src/test/scala/integration/kafka/api/AuthorizerIntegrationTest.scala: ## @@ -3076,6 +3076,29 @@ class AuthorizerIntegrationTest extends AbstractAuthorizerIntegra

Re: [PR] KAFKA-19237: add dynamic config remote.log.manager.follower.thread.pool.size [kafka]

2025-06-11 Thread via GitHub
chia7712 commented on PR #19809: URL: https://github.com/apache/kafka/pull/19809#issuecomment-2962457246 @brandboat could you please update docs as well? ![image](https://github.com/user-attachments/assets/6043643d-2e25-4442-9e4b-9a56ad8e575a) -- This is an automated message from t

[jira] [Updated] (KAFKA-19332) Fix flaky test : testAlterReadCommittedToReadUncommittedIsolationLevelWithReleaseAck and testAlterReadCommittedToReadUncommittedIsolationLevelWithRejectAck

2025-06-11 Thread Andrew Schofield (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19332?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Schofield updated KAFKA-19332: - Fix Version/s: (was: 4.1.0) > Fix flaky test : > testAlterReadCommittedToReadUncomm

Re: [PR] KAFKA-10551: Add topic id support to produce request and response [kafka]

2025-06-11 Thread via GitHub
junrao commented on PR #15968: URL: https://github.com/apache/kafka/pull/15968#issuecomment-2963551465 @lucasbru : Thanks for the explanation. During rebootstrap, it's possible that the metadata is empty when an inflight response is being processed. So, this has the same effect of a topic b

Re: [PR] KAFKA-7699: Anchored punctuation [kafka]

2025-06-11 Thread via GitHub
hermanjakobsen commented on code in PR #19937: URL: https://github.com/apache/kafka/pull/19937#discussion_r2140731755 ## streams/src/test/java/org/apache/kafka/streams/processor/internals/StreamTaskTest.java: ## @@ -1680,6 +1747,35 @@ public void shouldPunctuateOnceSystemTimeAft

Re: [PR] KAFKA-19297: Refactor AsyncKafkaConsumer's use of Java Streams APIs in critical sections [kafka]

2025-06-11 Thread via GitHub
kirktrue commented on PR #19917: URL: https://github.com/apache/kafka/pull/19917#issuecomment-2963869852 @AndrewJSchofield @lianetm—Anything else I need to fix before we can merge? Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log o

Re: [PR] KAFKA-18884: Move TransactionMetadata to transaction-coordinator module [kafka]

2025-06-11 Thread via GitHub
artemlivshits commented on code in PR #19699: URL: https://github.com/apache/kafka/pull/19699#discussion_r2140891089 ## transaction-coordinator/src/main/java/org/apache/kafka/coordinator/transaction/TransactionMetadata.java: ## @@ -0,0 +1,723 @@ +/* + * Licensed to the Apache So

Re: [PR] KAFKA-7699: Anchored punctuation [kafka]

2025-06-11 Thread via GitHub
hermanjakobsen commented on code in PR #19937: URL: https://github.com/apache/kafka/pull/19937#discussion_r2140731755 ## streams/src/test/java/org/apache/kafka/streams/processor/internals/StreamTaskTest.java: ## @@ -1680,6 +1747,35 @@ public void shouldPunctuateOnceSystemTimeAft

Re: [PR] KAFKA-19367: Fix InitProducerId with TV2 double-increments epoch if ongoing transaction is aborted [kafka]

2025-06-11 Thread via GitHub
jolshan commented on code in PR #19910: URL: https://github.com/apache/kafka/pull/19910#discussion_r214180 ## core/src/test/scala/unit/kafka/coordinator/transaction/TransactionCoordinatorTest.scala: ## @@ -1327,6 +1327,72 @@ class TransactionCoordinatorTest { any())

Re: [PR] KAFKA-14830: Illegal state error in transactional producer [kafka]

2025-06-11 Thread via GitHub
kirktrue commented on PR #17022: URL: https://github.com/apache/kafka/pull/17022#issuecomment-2963868532 @jolshan @mjsax—Anything else we need to check before we can merge? Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitH

Re: [PR] [Don't Merge] Test [kafka]

2025-06-11 Thread via GitHub
mjsax commented on PR #16463: URL: https://github.com/apache/kafka/pull/16463#issuecomment-2964337949 Not sure what this PR is about, but it seems abandoned. Closing for now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [PR] [Don't Merge] Test [kafka]

2025-06-11 Thread via GitHub
mjsax closed pull request #16463: [Don't Merge] Test URL: https://github.com/apache/kafka/pull/16463 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: ji

[jira] [Commented] (KAFKA-16123) KStreamKStreamJoinProcessor does not drop late records.

2025-06-11 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17959819#comment-17959819 ] Matthias J. Sax commented on KAFKA-16123: - [~aki] – I just stumble across this t

Re: [PR] Kafka-16355: Fix ConcurrentModificationException in evictWhile Method [kafka]

2025-06-11 Thread via GitHub
mjsax commented on PR #16554: URL: https://github.com/apache/kafka/pull/16554#issuecomment-2964329042 @abhi-ksolves -- Any updates? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

[jira] [Assigned] (KAFKA-15307) Kafka Streams configuration docs outdated

2025-06-11 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15307?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax reassigned KAFKA-15307: --- Assignee: (was: PoAn Yang) > Kafka Streams configuration docs outdated > --

Re: [PR] Add an option for ignoring tombstone records while a get on VersionedKeyValueStore [kafka]

2025-06-11 Thread via GitHub
mjsax commented on PR #18398: URL: https://github.com/apache/kafka/pull/18398#issuecomment-2964340406 We never received a KIP proposal. Closing this PR for now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

Re: [PR] Add an option for ignoring tombstone records while a get on VersionedKeyValueStore [kafka]

2025-06-11 Thread via GitHub
mjsax closed pull request #18398: Add an option for ignoring tombstone records while a get on VersionedKeyValueStore URL: https://github.com/apache/kafka/pull/18398 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] DRAFT KAFKA-18692: Consider to unify KStreamImpl "repartitionRequired" with GraphNode "keyChangingOperation" [kafka]

2025-06-11 Thread via GitHub
mjsax commented on PR #18800: URL: https://github.com/apache/kafka/pull/18800#issuecomment-2964344987 @appchemist -- Sorry for dropping the ball on this work. -- I would have time now, to support you with with PR, if you are still interested. -- This is an automated message from the Apach

Re: [PR] MINOR: Fix typo to actually use rocksdb setOptimizeFiltersForHits [kafka]

2025-06-11 Thread via GitHub
mjsax commented on PR #19837: URL: https://github.com/apache/kafka/pull/19837#issuecomment-2964364758 Oh dear. How embarrassing... Thanks for the PR! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] KAFKA-7699: Anchored punctuation [kafka]

2025-06-11 Thread via GitHub
hermanjakobsen commented on code in PR #19937: URL: https://github.com/apache/kafka/pull/19937#discussion_r2140731755 ## streams/src/test/java/org/apache/kafka/streams/processor/internals/StreamTaskTest.java: ## @@ -1680,6 +1747,35 @@ public void shouldPunctuateOnceSystemTimeAft

Re: [PR] KAFKA-17853: Fix termination issue in ConsoleConsumer and ConsoleShareConsumer [kafka]

2025-06-11 Thread via GitHub
ShivsundarR commented on PR #19886: URL: https://github.com/apache/kafka/pull/19886#issuecomment-2963857193 Hi @lianetm, thanks for the review. 1. So here the abort of the `FindCoordinator` will only happen when the network thread closes, i.e after all the pending async commits/acknowledg

Re: [PR] KAFKA-19244: Add support for kafka-streams-groups.sh options (reset-offsets) [1/N] [kafka]

2025-06-11 Thread via GitHub
aliehsaeedii commented on code in PR #19646: URL: https://github.com/apache/kafka/pull/19646#discussion_r2141088818 ## clients/src/main/java/org/apache/kafka/clients/admin/ListStreamsGroupOffsetsSpec.java: ## @@ -35,15 +35,15 @@ public class ListStreamsGroupOffsetsSpec { /*

Re: [PR] KAFKA-19383: Handle the deleted topics when applying ClearElrRecord [kafka]

2025-06-11 Thread via GitHub
ahuang98 commented on code in PR #19916: URL: https://github.com/apache/kafka/pull/19916#discussion_r2141096329 ## metadata/src/test/java/org/apache/kafka/image/TopicsImageTest.java: ## @@ -428,6 +428,231 @@ public void testClearElrRecords() { assertEquals(0, image.get

Re: [PR] KAFKA-10789: Streamlining Tests in ChangeLoggingKeyValueBytesStoreTest [kafka]

2025-06-11 Thread via GitHub
mjsax commented on PR #18816: URL: https://github.com/apache/kafka/pull/18816#issuecomment-2964298496 @leaf-soba -- Are you still interested to complete this PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[jira] [Assigned] (KAFKA-14405) Log a warning when users attempt to set a config controlled by Streams

2025-06-11 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14405?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax reassigned KAFKA-14405: --- Assignee: (was: Ashmeet Lamba) > Log a warning when users attempt to set a conf

Re: [PR] KAFKA-17089: Incorrect JWT parsing in OAuthBearerUnsecuredJws [kafka]

2025-06-11 Thread via GitHub
lianetm commented on code in PR #19946: URL: https://github.com/apache/kafka/pull/19946#discussion_r2141010345 ## clients/src/test/java/org/apache/kafka/common/security/oauthbearer/ClientJwtValidatorTest.java: ## @@ -26,4 +35,21 @@ protected JwtValidator createJwtValidator(Acces

Re: [PR] KAFKA-19244: Add support for kafka-streams-groups.sh options (reset-offsets) [1/N] [kafka]

2025-06-11 Thread via GitHub
aliehsaeedii commented on code in PR #19646: URL: https://github.com/apache/kafka/pull/19646#discussion_r2141033584 ## tools/src/main/java/org/apache/kafka/tools/streams/StreamsGroupCommandOptions.java: ## @@ -33,13 +33,18 @@ import static org.apache.kafka.tools.ToolsUtils.minu

Re: [PR] KAFKA-19244: Add support for kafka-streams-groups.sh options (reset-offsets) [1/N] [kafka]

2025-06-11 Thread via GitHub
aliehsaeedii commented on code in PR #19646: URL: https://github.com/apache/kafka/pull/19646#discussion_r2141038665 ## tools/src/main/java/org/apache/kafka/tools/OffsetsUtils.java: ## @@ -0,0 +1,474 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more +

Re: [PR] KAFKA-18024 ConcurrentModificationException in Kafka OffsetFetcher - Proposal for Thread-Safety Fix - Update OffsetFetcher.java [kafka]

2025-06-11 Thread via GitHub
kirktrue commented on PR #17826: URL: https://github.com/apache/kafka/pull/17826#issuecomment-2964485010 @kamil-adam-nowak—The fix seems fine, but the lack of understanding of the exact cause as well as the (understandable) lack of tests lowers the confidence of the reviewers. I don't think

[jira] [Updated] (KAFKA-19385) Unexpectedly stuck consumption on tiered storage enabled topics

2025-06-11 Thread Hasil Sharma (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19385?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hasil Sharma updated KAFKA-19385: - Labels: KIP-405 (was: ) > Unexpectedly stuck consumption on tiered storage enabled topics > ---

Re: [PR] KAFKA-10357 accidental repartition handling [kafka]

2025-06-11 Thread via GitHub
mjsax commented on PR #19913: URL: https://github.com/apache/kafka/pull/19913#issuecomment-2964504609 Seems there is some style errors: `Execution failed for task ':streams:spotlessJavaCheck'.` -- This is an automated message from the Apache Git Service. To respond to the message, please

Re: [PR] MINOR: rename exception `e` to `swallow` where appropriate [kafka]

2025-06-11 Thread via GitHub
kirktrue commented on code in PR #19948: URL: https://github.com/apache/kafka/pull/19948#discussion_r2141239123 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumerTest.java: ## @@ -182,7 +182,7 @@ public void resetAll() { if (consumer

Re: [PR] KAFKA-17089: Incorrect JWT parsing in OAuthBearerUnsecuredJws [kafka]

2025-06-11 Thread via GitHub
kirktrue commented on code in PR #19946: URL: https://github.com/apache/kafka/pull/19946#discussion_r2141198529 ## clients/src/test/java/org/apache/kafka/common/security/oauthbearer/ClientJwtValidatorTest.java: ## @@ -26,4 +35,21 @@ protected JwtValidator createJwtValidator(Acce

Re: [PR] MINOR: rename exception `e` to `swallow` where appropriate [kafka]

2025-06-11 Thread via GitHub
kirktrue commented on code in PR #19948: URL: https://github.com/apache/kafka/pull/19948#discussion_r2141239509 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumerTest.java: ## @@ -182,7 +182,7 @@ public void resetAll() { if (consumer

Re: [PR] KAFKA-15599: Move KafkaMetadataLog to the raft module [kafka]

2025-06-11 Thread via GitHub
mimaison commented on code in PR #19762: URL: https://github.com/apache/kafka/pull/19762#discussion_r2140112064 ## raft/src/main/java/org/apache/kafka/raft/KafkaRaftLog.java: ## @@ -0,0 +1,843 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * cont

Re: [PR] KAFKA-15599: Move KafkaMetadataLog to the raft module [kafka]

2025-06-11 Thread via GitHub
mimaison commented on code in PR #19762: URL: https://github.com/apache/kafka/pull/19762#discussion_r2140110837 ## raft/src/main/java/org/apache/kafka/raft/KafkaRaftLog.java: ## @@ -0,0 +1,843 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * cont

Re: [PR] KAFKA-15599: Move KafkaMetadataLog to the raft module [kafka]

2025-06-11 Thread via GitHub
mimaison commented on code in PR #19762: URL: https://github.com/apache/kafka/pull/19762#discussion_r2140129567 ## raft/src/main/java/org/apache/kafka/raft/KafkaRaftLog.java: ## @@ -0,0 +1,843 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * cont

Re: [PR] KAFKA-15599: Move KafkaMetadataLog to the raft module [kafka]

2025-06-11 Thread via GitHub
mimaison commented on code in PR #19762: URL: https://github.com/apache/kafka/pull/19762#discussion_r2140130098 ## raft/src/main/java/org/apache/kafka/raft/KafkaRaftLog.java: ## @@ -0,0 +1,843 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * cont

Re: [PR] KAFKA-18961: Time-based refresh for server-side RE2J regex [kafka]

2025-06-11 Thread via GitHub
dajac commented on code in PR #19904: URL: https://github.com/apache/kafka/pull/19904#discussion_r2140324934 ## core/src/test/scala/integration/kafka/api/AuthorizerIntegrationTest.scala: ## @@ -3076,6 +3076,29 @@ class AuthorizerIntegrationTest extends AbstractAuthorizerIntegra

Re: [PR] KAFKA-18486: Migrate testPartitionMetadataFile to use applyDelta in place of deprecated becomeLeaderOrFollower [kafka]

2025-06-11 Thread via GitHub
jingjia88 commented on code in PR #19947: URL: https://github.com/apache/kafka/pull/19947#discussion_r2140329843 ## core/src/test/scala/unit/kafka/server/ReplicaManagerTest.scala: ## @@ -4302,7 +4239,6 @@ class ReplicaManagerTest { val replicaManager = setupReplicaManagerWi

Re: [PR] When a broker restarts, it should not attempt to create the __remote_log_metadata topic if it already exists. [kafka]

2025-06-11 Thread via GitHub
jiafu1115 commented on PR #19899: URL: https://github.com/apache/kafka/pull/19899#issuecomment-2962944786 can anybody help to take a look? thanks. @chia7712 @satishd @kamalcph -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

Re: [PR] KAFKA-17662: config.providers configuration missing from the docs [kafka]

2025-06-11 Thread via GitHub
mimaison commented on code in PR #18930: URL: https://github.com/apache/kafka/pull/18930#discussion_r2140310506 ## clients/src/main/java/org/apache/kafka/common/config/AbstractConfig.java: ## @@ -65,6 +65,11 @@ public class AbstractConfig { public static final String AUTOMA

Re: [PR] KAFKA-17853: Fix termination issue in ConsoleConsumer and ConsoleShareConsumer [kafka]

2025-06-11 Thread via GitHub
lianetm commented on PR #19886: URL: https://github.com/apache/kafka/pull/19886#issuecomment-2962993263 Hey, thanks for looking into this! Sorry I haven't had the time to look in detail, but just couple of high level comments: - we need to be careful with aborting the find coord on cl

Re: [PR] KAFKA-15599: Move KafkaMetadataLog to the raft module [kafka]

2025-06-11 Thread via GitHub
mimaison commented on code in PR #19762: URL: https://github.com/apache/kafka/pull/19762#discussion_r214004 ## raft/src/main/java/org/apache/kafka/raft/KafkaRaftLog.java: ## @@ -0,0 +1,843 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * cont

Re: [PR] KAFKA-15599: Move KafkaMetadataLog to the raft module [kafka]

2025-06-11 Thread via GitHub
mimaison commented on code in PR #19762: URL: https://github.com/apache/kafka/pull/19762#discussion_r2140047143 ## raft/src/main/java/org/apache/kafka/raft/KafkaRaftLog.java: ## @@ -0,0 +1,843 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * cont

[jira] [Created] (KAFKA-19400) Update AddRaftVoterRPC to support controller auto-joining

2025-06-11 Thread Kevin Wu (Jira)
Kevin Wu created KAFKA-19400: Summary: Update AddRaftVoterRPC to support controller auto-joining Key: KAFKA-19400 URL: https://issues.apache.org/jira/browse/KAFKA-19400 Project: Kafka Issue Type:

Re: [PR] KAFKA-19283: Update transaction exception handling documentation [kafka]

2025-06-11 Thread via GitHub
mimaison commented on PR #19931: URL: https://github.com/apache/kafka/pull/19931#issuecomment-2963150916 Can we now close https://issues.apache.org/jira/browse/KAFKA-19283 and https://issues.apache.org/jira/browse/KAFKA-16906? And mark KIP-1050 as complete? -- This is an automated mess

[jira] [Commented] (KAFKA-18666) Controller-side monitoring for broker shutdown and startup

2025-06-11 Thread Mickael Maison (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17959755#comment-17959755 ] Mickael Maison commented on KAFKA-18666: The PR has been merged, can we now clos

[jira] [Commented] (KAFKA-17411) StateStore managed changelog offsets

2025-06-11 Thread Mickael Maison (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17959757#comment-17959757 ] Mickael Maison commented on KAFKA-17411: It seems the implementation of KIP-1035

[jira] [Commented] (KAFKA-15433) Follower fetch from tiered offset

2025-06-11 Thread Mickael Maison (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17959758#comment-17959758 ] Mickael Maison commented on KAFKA-15433: It seems the implementation of KIP-1023

[jira] [Commented] (KAFKA-18666) Controller-side monitoring for broker shutdown and startup

2025-06-11 Thread Kevin Wu (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17959761#comment-17959761 ] Kevin Wu commented on KAFKA-18666: -- Yeah, thanks for the reminder. > Controller-side m

[jira] [Commented] (KAFKA-17125) Streams Rebalance Protocol

2025-06-11 Thread Mickael Maison (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17959760#comment-17959760 ] Mickael Maison commented on KAFKA-17125: We have passed feature freeze for 4.1.0

[jira] [Resolved] (KAFKA-18666) Controller-side monitoring for broker shutdown and startup

2025-06-11 Thread Kevin Wu (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18666?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Wu resolved KAFKA-18666. -- Resolution: Fixed > Controller-side monitoring for broker shutdown and startup > -

Re: [PR] KAFKA-17662: config.providers configuration missing from the docs [kafka]

2025-06-11 Thread via GitHub
m1a2st commented on code in PR #18930: URL: https://github.com/apache/kafka/pull/18930#discussion_r2140464320 ## clients/src/main/java/org/apache/kafka/common/config/AbstractConfig.java: ## @@ -65,6 +65,11 @@ public class AbstractConfig { public static final String AUTOMATI

[PR] :wrench: Add Gradle option to start broker outside CLI [kafka]

2025-06-11 Thread via GitHub
StefanPitur opened a new pull request, #19950: URL: https://github.com/apache/kafka/pull/19950 The only way to start a broker was to run `./bin/kafka-server-start.sh config/server.properties`. However, this would require the code to be compiled, making it very difficult to attach a debugger

Re: [PR] :wrench: Add Gradle option to start broker outside CLI [kafka]

2025-06-11 Thread via GitHub
StefanPitur closed pull request #19950: :wrench: Add Gradle option to start broker outside CLI URL: https://github.com/apache/kafka/pull/19950 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spe

Re: [PR] KAFKA-18961: Time-based refresh for server-side RE2J regex [kafka]

2025-06-11 Thread via GitHub
dongnuo123 commented on code in PR #19904: URL: https://github.com/apache/kafka/pull/19904#discussion_r2140187447 ## core/src/test/scala/integration/kafka/api/AuthorizerIntegrationTest.scala: ## @@ -3076,6 +3076,29 @@ class AuthorizerIntegrationTest extends AbstractAuthorizerIn

Re: [PR] [WIP]KAFKA-18896 add KIP-877 support for Login [kafka]

2025-06-11 Thread via GitHub
mimaison commented on code in PR #19527: URL: https://github.com/apache/kafka/pull/19527#discussion_r2140347189 ## clients/src/main/java/org/apache/kafka/common/security/authenticator/LoginManager.java: ## @@ -53,20 +56,30 @@ public class LoginManager { // dynamic configs (

Re: [PR] KAFKA-19070:: Adding task number to user provided client id to ensure each consumer has a unique client ID to avoid metric registration conflicts. [kafka]

2025-06-11 Thread via GitHub
mimaison commented on PR #19341: URL: https://github.com/apache/kafka/pull/19341#issuecomment-2963083096 Thanks for the PR! Overall I agree that we should ensure metrics don't collide so operators can rely on them to be accurate. On the other hand the cliend Id can be used for author

Re: [PR] [WIP]KAFKA-18896 add KIP-877 support for Login [kafka]

2025-06-11 Thread via GitHub
mimaison commented on code in PR #19527: URL: https://github.com/apache/kafka/pull/19527#discussion_r2140491345 ## clients/src/main/java/org/apache/kafka/common/security/authenticator/LoginManager.java: ## @@ -53,20 +56,30 @@ public class LoginManager { // dynamic configs (

[jira] [Commented] (KAFKA-17125) Streams Rebalance Protocol

2025-06-11 Thread Lucas Brutschy (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17959765#comment-17959765 ] Lucas Brutschy commented on KAFKA-17125: [~mimaison] Yes, we are still targeting

Re: [PR] [WIP]KAFKA-18896 add KIP-877 support for Login [kafka]

2025-06-11 Thread via GitHub
m1a2st commented on code in PR #19527: URL: https://github.com/apache/kafka/pull/19527#discussion_r2140475453 ## clients/src/main/java/org/apache/kafka/common/security/authenticator/LoginManager.java: ## @@ -53,20 +56,30 @@ public class LoginManager { // dynamic configs (br

Re: [PR] KAFKA-19237: add dynamic config remote.log.manager.follower.thread.pool.size [kafka]

2025-06-11 Thread via GitHub
brandboat commented on PR #19809: URL: https://github.com/apache/kafka/pull/19809#issuecomment-2963268948 > @brandboat could you please update docs as well? Updated! Thanks for the heads-up! -- This is an automated message from the Apache Git Service. To respond to the message, plea

Re: [PR] KAFKA-17662: config.providers configuration missing from the docs [kafka]

2025-06-11 Thread via GitHub
mimaison commented on code in PR #18930: URL: https://github.com/apache/kafka/pull/18930#discussion_r2140495418 ## clients/src/main/java/org/apache/kafka/common/config/AbstractConfig.java: ## @@ -65,6 +65,11 @@ public class AbstractConfig { public static final String AUTOMA

[jira] [Commented] (KAFKA-19223) Explicit HWM replication

2025-06-11 Thread Mickael Maison (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17959767#comment-17959767 ] Mickael Maison commented on KAFKA-19223: We have passed feature freeze for 4.1.0

[jira] [Commented] (KAFKA-19259) Async consumer fetch intermittent delays on console consumer

2025-06-11 Thread Arpit Goyal (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17959773#comment-17959773 ] Arpit Goyal commented on KAFKA-19259: - [~kirktrue]  [~lianetm]  I was trying to high

Re: [PR] KAFKA-19395 - Updated Junit version and license information in NOTICE-binary for Jakarta RESTful Web Services Project [kafka]

2025-06-11 Thread via GitHub
kapoorpalak21999 commented on PR #19943: URL: https://github.com/apache/kafka/pull/19943#issuecomment-2961457939 @chia7712 Sure. I will update the versions in the same PR itself. Thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[jira] [Commented] (KAFKA-19399) The version and source link in the `NOTICE-binary` file for `Mockito` are inconsistent

2025-06-11 Thread Palak Kapoor (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17959659#comment-17959659 ] Palak Kapoor commented on KAFKA-19399: -- GitHub PR for the fix - [https://github.com

Re: [PR] KAFKA-15599: Move KafkaMetadataLog to the raft module [kafka]

2025-06-11 Thread via GitHub
mimaison commented on code in PR #19762: URL: https://github.com/apache/kafka/pull/19762#discussion_r2139520463 ## raft/src/main/java/org/apache/kafka/raft/KafkaRaftLog.java: ## @@ -0,0 +1,843 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * cont

Re: [PR] KAFKA-15599: Move KafkaMetadataLog to the raft module [kafka]

2025-06-11 Thread via GitHub
mimaison commented on code in PR #19762: URL: https://github.com/apache/kafka/pull/19762#discussion_r2139512929 ## raft/src/main/java/org/apache/kafka/raft/KafkaRaftLog.java: ## @@ -0,0 +1,843 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * cont

Re: [PR] KAFKA-18760: Deprecate Optional and return String from public Endpoint#listener [kafka]

2025-06-11 Thread via GitHub
chia7712 commented on PR #19191: URL: https://github.com/apache/kafka/pull/19191#issuecomment-2962062111 > Since certain parts of the code depend on listener name normalization, having a test would help to catch any regressions. @omkreddy Do you mean the listener name SHOULD be normal

Re: [PR] MINOR: Bump trunk to 4.2.0-SNAPSHOT [kafka]

2025-06-11 Thread via GitHub
mimaison merged PR #19944: URL: https://github.com/apache/kafka/pull/19944 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

Re: [PR] KAFKA-18462: Upgrade RocksDB dependency from 9.7.3 to 10.2.1 [kafka]

2025-06-11 Thread via GitHub
cadonna commented on code in PR #19880: URL: https://github.com/apache/kafka/pull/19880#discussion_r2139416341 ## streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBGenericOptionsToDbOptionsColumnFamilyOptionsAdapter.java: ## @@ -1230,17 +1219,6 @@ public bool

Re: [PR] KAFKA-15665: Enforce partition reassignment should complete when all target replicas are in ISR [kafka]

2025-06-11 Thread via GitHub
dgoyal-confluent commented on code in PR #15359: URL: https://github.com/apache/kafka/pull/15359#discussion_r2139483544 ## metadata/src/main/java/org/apache/kafka/controller/PartitionReassignmentReplicas.java: ## @@ -120,9 +120,7 @@ Optional maybeCompleteReassignment(List targe

Re: [PR] KAFKA-15665: Enforce partition reassignment should complete when all target replicas are in ISR [kafka]

2025-06-11 Thread via GitHub
dgoyal-confluent commented on code in PR #15359: URL: https://github.com/apache/kafka/pull/15359#discussion_r2139483544 ## metadata/src/main/java/org/apache/kafka/controller/PartitionReassignmentReplicas.java: ## @@ -120,9 +120,7 @@ Optional maybeCompleteReassignment(List targe

Re: [PR] KAFKA-19359: force bump commons-beanutils for CVE-2025-48734 [kafka]

2025-06-11 Thread via GitHub
showuon merged PR #19939: URL: https://github.com/apache/kafka/pull/19939 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.

Re: [PR] MINOR: add lower case lister name integration test [kafka]

2025-06-11 Thread via GitHub
chia7712 commented on code in PR #19932: URL: https://github.com/apache/kafka/pull/19932#discussion_r2139776351 ## core/src/test/scala/integration/kafka/server/KRaftClusterTest.scala: ## @@ -130,6 +130,27 @@ class KRaftClusterTest { } } + @Test + def testClusterWithL

[jira] [Reopened] (KAFKA-19332) Fix flaky test : testAlterReadCommittedToReadUncommittedIsolationLevelWithReleaseAck and testAlterReadCommittedToReadUncommittedIsolationLevelWithRejectAck

2025-06-11 Thread Shivsundar R (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19332?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shivsundar R reopened KAFKA-19332: -- > Fix flaky test : > testAlterReadCommittedToReadUncommittedIsolationLevelWithReleaseAck and > t

[jira] [Commented] (KAFKA-19332) Fix flaky test : testAlterReadCommittedToReadUncommittedIsolationLevelWithReleaseAck and testAlterReadCommittedToReadUncommittedIsolationLevelWithRejectAck

2025-06-11 Thread Shivsundar R (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17959692#comment-17959692 ] Shivsundar R commented on KAFKA-19332: -- Re-opening the issue as there were a few fl

Re: [PR] KAFKA-17853: Fix termination issue in ConsoleConsumer and ConsoleShareConsumer [kafka]

2025-06-11 Thread via GitHub
ShivsundarR commented on PR #19886: URL: https://github.com/apache/kafka/pull/19886#issuecomment-2962293582 Another edge case here: If the broker never started, and we attempt a ctrl-c to close the consumer, then still took 30 seconds for the `ConsoleShareConsumer` to close. The problem

Re: [PR] KAFKA-7699: Anchored punctuation [kafka]

2025-06-11 Thread via GitHub
hermanjakobsen commented on code in PR #19937: URL: https://github.com/apache/kafka/pull/19937#discussion_r2140731755 ## streams/src/test/java/org/apache/kafka/streams/processor/internals/StreamTaskTest.java: ## @@ -1680,6 +1747,35 @@ public void shouldPunctuateOnceSystemTimeAft

Re: [PR] KAFKA-7699: Anchored punctuation [kafka]

2025-06-11 Thread via GitHub
hermanjakobsen commented on code in PR #19937: URL: https://github.com/apache/kafka/pull/19937#discussion_r2140731755 ## streams/src/test/java/org/apache/kafka/streams/processor/internals/StreamTaskTest.java: ## @@ -1680,6 +1747,35 @@ public void shouldPunctuateOnceSystemTimeAft

[jira] [Commented] (KAFKA-19223) Explicit HWM replication

2025-06-11 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-19223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17959787#comment-17959787 ] José Armando García Sancio commented on KAFKA-19223: [~mimaison] , i

Re: [PR] KAFKA-7699: Anchored punctuation [kafka]

2025-06-11 Thread via GitHub
hermanjakobsen commented on code in PR #19937: URL: https://github.com/apache/kafka/pull/19937#discussion_r2140731755 ## streams/src/test/java/org/apache/kafka/streams/processor/internals/StreamTaskTest.java: ## @@ -1680,6 +1747,35 @@ public void shouldPunctuateOnceSystemTimeAft

Re: [PR] KAFKA-19324: Make org.apache.kafka.common.test.TestUtils package-private to prevent cross-module access [kafka]

2025-06-11 Thread via GitHub
chia7712 commented on code in PR #19884: URL: https://github.com/apache/kafka/pull/19884#discussion_r2141350957 ## test-common/test-common-runtime/src/main/java/org/apache/kafka/common/test/junit/RaftClusterInvocationContext.java: ## @@ -71,6 +70,48 @@ public class RaftClusterIn

[jira] [Commented] (KAFKA-19359) [8.8] [CVE-2025-48734] [commons-beanutils] [1.9.4]

2025-06-11 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17965208#comment-17965208 ] Luke Chen commented on KAFKA-19359: --- This PR: [https://github.com/apache/kafka/pull/19

[jira] [Resolved] (KAFKA-19359) [8.8] [CVE-2025-48734] [commons-beanutils] [1.9.4]

2025-06-11 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19359?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Luke Chen resolved KAFKA-19359. --- Fix Version/s: 3.9.2 4.0.1 4.1.0 Resolution: Fixed > [8

Re: [PR] KAFKA-18166: Indefinite timeout when publishing events to RLMM (RemoteLogMetadataManager) [kafka]

2025-06-11 Thread via GitHub
github-actions[bot] commented on PR #18097: URL: https://github.com/apache/kafka/pull/18097#issuecomment-2964999022 This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please leave a comment asking for a review. If the P

[jira] [Created] (KAFKA-19401) Consider keeping/removing the internal wrappers from streams module

2025-06-11 Thread Chia-Ping Tsai (Jira)
Chia-Ping Tsai created KAFKA-19401: -- Summary: Consider keeping/removing the internal wrappers from streams module Key: KAFKA-19401 URL: https://issues.apache.org/jira/browse/KAFKA-19401 Project: Kafk

[PR] KAFKA-19402 Typo in EventAccumulator.java [kafka]

2025-06-11 Thread via GitHub
masonyc opened a new pull request, #19951: URL: https://github.com/apache/kafka/pull/19951 Current comment on that class: A concurrent event accumulator which group events per key and ensure that only one event with a given key **can't** be processed concurrently. To my understanding

Re: [PR] MINOR: Bump commons beanutils39 [kafka]

2025-06-11 Thread via GitHub
showuon merged PR #19949: URL: https://github.com/apache/kafka/pull/19949 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.