Re: [PR] KAFKA-19389: Fix memory consumption for completed share fetch requests [kafka]

2025-06-09 Thread via GitHub
apoorvmittal10 commented on PR #19928: URL: https://github.com/apache/kafka/pull/19928#issuecomment-2956996007 @junrao Thanks for reviewing, I have addressed the comments. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

[jira] [Commented] (KAFKA-19012) Messages ending up on the wrong topic

2025-06-09 Thread Donny Nadolny (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17957050#comment-17957050 ] Donny Nadolny commented on KAFKA-19012: --- [~junrao] the earliest producer where we

Re: [PR] KAFKA-19367: Fix InitProducerId with TV2 double-increments epoch if ongoing transaction is aborted [kafka]

2025-06-09 Thread via GitHub
rreddy-22 commented on code in PR #19910: URL: https://github.com/apache/kafka/pull/19910#discussion_r2136535090 ## core/src/main/scala/kafka/coordinator/transaction/TransactionCoordinator.scala: ## @@ -819,11 +819,14 @@ class TransactionCoordinator(txnConfig: TransactionConfig,

Re: [PR] MINOR: ELR release note for 4.1 [kafka]

2025-06-09 Thread via GitHub
jolshan merged PR #19909: URL: https://github.com/apache/kafka/pull/19909 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.

Re: [PR] KAFKA-19283: Update transaction exception handling documentation [kafka]

2025-06-09 Thread via GitHub
jolshan merged PR #19931: URL: https://github.com/apache/kafka/pull/19931 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.

Re: [PR] KAFKA-18967: Added additional MetadataSchemaCheckerTool tests [kafka]

2025-06-09 Thread via GitHub
github-actions[bot] commented on PR #19882: URL: https://github.com/apache/kafka/pull/19882#issuecomment-2957575136 A label of 'needs-attention' was automatically added to this PR in order to raise the attention of the committers. Once this issue has been triaged, the `triage` label s

Re: [PR] KAFKA-19392: Fix metadata.log.segment.ms not being applied [kafka]

2025-06-09 Thread via GitHub
frankvicky commented on PR #19936: URL: https://github.com/apache/kafka/pull/19936#issuecomment-2957609016 @mingyen066: Please merge trunk to re-trigger CI. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [PR] KAFKA-17688 Move TransactionsTest to storage module [kafka]

2025-06-09 Thread via GitHub
github-actions[bot] commented on PR #17732: URL: https://github.com/apache/kafka/pull/17732#issuecomment-2957594315 This PR has been closed since it has not had any activity in 120 days. If you feel like this was a mistake, or you would like to continue working on it, please feel free to

[PR] KAFKA-19359: force bump commons-beanutils for CVE-2025-48734 [kafka]

2025-06-09 Thread via GitHub
showuon opened a new pull request, #19939: URL: https://github.com/apache/kafka/pull/19939 WIP, make sure it won't break anything -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comm

[jira] [Updated] (KAFKA-19394) Failure in ConsumerNetworkThread.initializeResources() can cause hangs on AsyncKafkaConsumer.close()

2025-06-09 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19394?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-19394: -- Summary: Failure in ConsumerNetworkThread.initializeResources() can cause hangs on AsyncKafkaConsumer.

[jira] [Updated] (KAFKA-19390) AbstractIndex#resize() does not release old mmap on Linux

2025-06-09 Thread Masahiro Mori (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19390?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Masahiro Mori updated KAFKA-19390: -- Description: Our kafka broker crashed with the following error: {code:java} [2025-03-29 09:37:

Re: [PR] KAFKA-19382:Upgrade junit from 5.10 to 5.13 [kafka]

2025-06-09 Thread via GitHub
frankvicky commented on PR #19919: URL: https://github.com/apache/kafka/pull/19919#issuecomment-2957631945 @Rancho-7 There are some issue that needs to be clarified before modifying NOTICE-binary. Could you please revert the change of NOTICE-binary and open a jira ticket for it? --

[PR] Bump requests from 2.31.0 to 2.32.4 in /tests [kafka]

2025-06-09 Thread via GitHub
dependabot[bot] opened a new pull request, #19940: URL: https://github.com/apache/kafka/pull/19940 Bumps [requests](https://github.com/psf/requests) from 2.31.0 to 2.32.4. Release notes Sourced from https://github.com/psf/requests/releases";>requests's releases. v2.32.4 2

Re: [PR] KAFKA-19340: Move DelayedRemoteFetch to the storage module [kafka]

2025-06-09 Thread via GitHub
github-actions[bot] commented on PR #19876: URL: https://github.com/apache/kafka/pull/19876#issuecomment-2957575162 A label of 'needs-attention' was automatically added to this PR in order to raise the attention of the committers. Once this issue has been triaged, the `triage` label s

Re: [PR] KAFKA-18486 Remove becomeLeaderOrFollower from readFromLogWithOffsetOutOfRange and other related methods. [kafka]

2025-06-09 Thread via GitHub
frankvicky merged PR #19929: URL: https://github.com/apache/kafka/pull/19929 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apac

Re: [PR] KAFKA-19382:Upgrade junit from 5.10 to 5.13 [kafka]

2025-06-09 Thread via GitHub
Rancho-7 commented on PR #19919: URL: https://github.com/apache/kafka/pull/19919#issuecomment-2957676135 > @Rancho-7 There are some issue that needs to be clarified before modifying NOTICE-binary. Could you please revert the change of NOTICE-binary and open a jira ticket for it? Reve

[jira] [Updated] (KAFKA-19395) The version and license information in the `NOTICE-binary` file for `JUnit` are inconsistent

2025-06-09 Thread Nick Guo (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19395?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nick Guo updated KAFKA-19395: - Summary: The version and license information in the `NOTICE-binary` file for `JUnit` are inconsistent (

[jira] [Created] (KAFKA-19394) Failure in ConsumerNetworkThread.initializeResources() can cause hangs on close

2025-06-09 Thread Kirk True (Jira)
Kirk True created KAFKA-19394: - Summary: Failure in ConsumerNetworkThread.initializeResources() can cause hangs on close Key: KAFKA-19394 URL: https://issues.apache.org/jira/browse/KAFKA-19394 Project: Ka

Re: [PR] KAFKA-14830: Illegal state error in transactional producer [kafka]

2025-06-09 Thread via GitHub
kirktrue commented on code in PR #17022: URL: https://github.com/apache/kafka/pull/17022#discussion_r2136374381 ## clients/src/main/java/org/apache/kafka/clients/producer/internals/TransactionManager.java: ## @@ -779,14 +779,25 @@ public synchronized void maybeTransitionToError

Re: [PR] KAFKA-19297: Refactor AsyncKafkaConsumer's use of Java Streams APIs in critical sections [kafka]

2025-06-09 Thread via GitHub
kirktrue commented on code in PR #19917: URL: https://github.com/apache/kafka/pull/19917#discussion_r2136356737 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/Utils.java: ## @@ -20,12 +20,41 @@ import org.apache.kafka.common.TopicPartition; import java.

Re: [PR] KAFKA-19325 improve forceComplete() in DelayedOperation [kafka]

2025-06-09 Thread via GitHub
junrao commented on code in PR #19862: URL: https://github.com/apache/kafka/pull/19862#discussion_r2136586587 ## server-common/src/main/java/org/apache/kafka/server/purgatory/DelayedOperation.java: ## @@ -58,26 +58,15 @@ public DelayedOperation(long delayMs) { * true, othe

Re: [PR] KAFKA-19367: Fix InitProducerId with TV2 double-increments epoch if ongoing transaction is aborted [kafka]

2025-06-09 Thread via GitHub
jolshan commented on code in PR #19910: URL: https://github.com/apache/kafka/pull/19910#discussion_r2136822173 ## core/src/main/scala/kafka/coordinator/transaction/TransactionCoordinator.scala: ## @@ -819,11 +819,14 @@ class TransactionCoordinator(txnConfig: TransactionConfig,

[jira] [Commented] (KAFKA-19359) [8.8] [CVE-2025-48734] [commons-beanutils] [1.9.4]

2025-06-09 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17957422#comment-17957422 ] Luke Chen commented on KAFKA-19359: --- I've requested for a release in `commons-validato

[jira] [Commented] (KAFKA-19012) Messages ending up on the wrong topic

2025-06-09 Thread Jun Rao (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17957364#comment-17957364 ] Jun Rao commented on KAFKA-19012: - Thanks for the info, [~dnadolny]. > Messages ending

Re: [PR] KAFKA-19389: Fix memory consumption for completed share fetch requests [kafka]

2025-06-09 Thread via GitHub
junrao commented on PR #19928: URL: https://github.com/apache/kafka/pull/19928#issuecomment-2957209914 @apoorvmittal10 : Thanks for the experimental results. For Local log fetch, could you run multiple groups on the same topic? Could you also measure the CPU usage on the broker? -- This

Re: [PR] KAFKA-19389: Fix memory consumption for completed share fetch requests [kafka]

2025-06-09 Thread via GitHub
apoorvmittal10 commented on PR #19928: URL: https://github.com/apache/kafka/pull/19928#issuecomment-2957325074 @junrao The importance of the fix is more evident when messages are larger in size. I produced messages of size 102400 Bytes hence a single share fetch should have 500 (default) *

Re: [PR] KAFKA-19389: Fix memory consumption for completed share fetch requests [kafka]

2025-06-09 Thread via GitHub
apoorvmittal10 commented on PR #19928: URL: https://github.com/apache/kafka/pull/19928#issuecomment-2957255489 > @apoorvmittal10 : Thanks for the experimental results. For Local log fetch, could you run multiple groups on the same topic? Could you also measure the CPU usage on the broker?

Re: [PR] KAFKA-19389: Fix memory consumption for completed share fetch requests [kafka]

2025-06-09 Thread via GitHub
apoorvmittal10 commented on PR #19928: URL: https://github.com/apache/kafka/pull/19928#issuecomment-2957260554 Total 5 * 2GB = 10 GB data read by 5 share groups on 1GB Kafka server in ~130 secs. -- This is an automated message from the Apache Git Service. To respond to the message, please

[jira] [Created] (KAFKA-19393) Consolidate consumer assignment state views

2025-06-09 Thread Lianet Magrans (Jira)
Lianet Magrans created KAFKA-19393: -- Summary: Consolidate consumer assignment state views Key: KAFKA-19393 URL: https://issues.apache.org/jira/browse/KAFKA-19393 Project: Kafka Issue Type: I

Re: [PR] KAFKA-19297: Refactor AsyncKafkaConsumer's use of Java Streams APIs in critical sections [kafka]

2025-06-09 Thread via GitHub
kirktrue commented on code in PR #19917: URL: https://github.com/apache/kafka/pull/19917#discussion_r2136340952 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/TopicMetadataRequestManager.java: ## @@ -84,16 +84,21 @@ public TopicMetadataRequestManager(final

Re: [PR] KAFKA-14895: [2/N] Move AddPartitionsToTxnManager files to java [kafka]

2025-06-09 Thread via GitHub
brandboat commented on PR #19933: URL: https://github.com/apache/kafka/pull/19933#issuecomment-2957377963 AC, gentle ping @chia7712, @jolshan, could you please take a look when you are available? Thank you! -- This is an automated message from the Apache Git Service. To respond to the mes

[PR] KAFKA-19153: Add OAuth integration tests [kafka]

2025-06-09 Thread via GitHub
kirktrue opened a new pull request, #19938: URL: https://github.com/apache/kafka/pull/19938 Adds a test dependency on [mock-oauth2-server](https://github.com/navikt/mock-oauth2-server/) for integration tests for OAuth layer. -- This is an automated message from the Apache Git Service. To

[jira] [Created] (KAFKA-19395) The version and license information in the `NOTICE-binary` file for `JUnit` are inconsistent/

2025-06-09 Thread Nick Guo (Jira)
Nick Guo created KAFKA-19395: Summary: The version and license information in the `NOTICE-binary` file for `JUnit` are inconsistent/ Key: KAFKA-19395 URL: https://issues.apache.org/jira/browse/KAFKA-19395

Re: [PR] KAFKA-17688 Move TransactionsTest to storage module [kafka]

2025-06-09 Thread via GitHub
github-actions[bot] closed pull request #17732: KAFKA-17688 Move TransactionsTest to storage module URL: https://github.com/apache/kafka/pull/17732 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[jira] [Updated] (KAFKA-17541) Improve handling of delivery count

2025-06-09 Thread Lan Ding (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17541?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lan Ding updated KAFKA-17541: - Fix Version/s: 4.2.0 > Improve handling of delivery count > -- > >

Re: [PR] KAFKA-19271: allow intercepting internal method call [kafka]

2025-06-09 Thread via GitHub
mjsax merged PR #19832: URL: https://github.com/apache/kafka/pull/19832 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or

Re: [PR] KAFKA-18185: remove internal.leave.group.on.close config [kafka]

2025-06-09 Thread via GitHub
chia7712 commented on code in PR #19400: URL: https://github.com/apache/kafka/pull/19400#discussion_r2135830769 ## streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java: ## @@ -1205,45 +1200,9 @@ private Optional removeStreamThread(final long timeoutMs) throws Timeou

[PR] MINOR: add lower case lister name integration test [kafka]

2025-06-09 Thread via GitHub
FrankYang0529 opened a new pull request, #19932: URL: https://github.com/apache/kafka/pull/19932 In [KIP-1143](https://cwiki.apache.org/confluence/x/LwqWF), it deprecated Endpoint#listenerName and removed org.apache.kafka.network.EndPoint. Certain parts of the code depend on listener name n

Re: [PR] KAFKA-19354: KRaft observer should fetch from leader after rediscovery [kafka]

2025-06-09 Thread via GitHub
ahuang98 commented on code in PR #19854: URL: https://github.com/apache/kafka/pull/19854#discussion_r2136234763 ## raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java: ## @@ -2543,13 +2543,16 @@ private void maybeTransition( } else { trans

Re: [PR] KAFKA-19392: Fix metadata.log.segment.ms not being applied [kafka]

2025-06-09 Thread via GitHub
mingyen066 commented on PR #19936: URL: https://github.com/apache/kafka/pull/19936#issuecomment-2956583980 Thanks @chia7712 I ran the e2e test on my mac and all passed ``` $ TC_PATHS="tests/kafkatest/tests/core/snapshot_test.py::TestSnapshots.test_controller" bash tests/docke

Re: [PR] KAFKA-19389: Fix memory consumption for completed share fetch requests [kafka]

2025-06-09 Thread via GitHub
apoorvmittal10 commented on code in PR #19928: URL: https://github.com/apache/kafka/pull/19928#discussion_r2136306887 ## core/src/main/java/kafka/server/share/DelayedShareFetch.java: ## @@ -808,9 +809,18 @@ private void releasePartitionLocksAndAddToActionQueue(Set topi

Re: [PR] KAFKA-19389: Fix memory consumption for completed share fetch requests [kafka]

2025-06-09 Thread via GitHub
apoorvmittal10 commented on PR #19928: URL: https://github.com/apache/kafka/pull/19928#issuecomment-2956678794 ## Test results for performance: Setup share groups to read from earliest: ``` bin/kafka-configs.sh --bootstrap-server localhost:9092 --entity-type groups --entity-name

Re: [PR] KAFKA-19389: Fix memory consumption for completed share fetch requests [kafka]

2025-06-09 Thread via GitHub
apoorvmittal10 commented on code in PR #19928: URL: https://github.com/apache/kafka/pull/19928#discussion_r2136268973 ## core/src/main/java/kafka/server/share/DelayedShareFetch.java: ## @@ -808,9 +809,18 @@ private void releasePartitionLocksAndAddToActionQueue(Set topi

Re: [PR] KAFKA-19389: Fix memory consumption for completed share fetch requests [kafka]

2025-06-09 Thread via GitHub
apoorvmittal10 commented on code in PR #19928: URL: https://github.com/apache/kafka/pull/19928#discussion_r2136306887 ## core/src/main/java/kafka/server/share/DelayedShareFetch.java: ## @@ -808,9 +809,18 @@ private void releasePartitionLocksAndAddToActionQueue(Set topi

Re: [PR] KAFKA-19297: Refactor AsyncKafkaConsumer's use of Java Streams APIs in critical sections [kafka]

2025-06-09 Thread via GitHub
kirktrue commented on code in PR #19917: URL: https://github.com/apache/kafka/pull/19917#discussion_r2136329921 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractMembershipManager.java: ## @@ -1135,7 +1134,9 @@ CompletableFuture revokePartitions(Set p

Re: [PR] KAFKA-18117; KAFKA-18729: Use assigned topic IDs to avoid full metadata requests on broker-side regex [kafka]

2025-06-09 Thread via GitHub
lianetm commented on code in PR #19814: URL: https://github.com/apache/kafka/pull/19814#discussion_r2132881121 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/SubscriptionState.java: ## @@ -91,6 +92,13 @@ private enum SubscriptionType { /* the list of t

Re: [PR] KAFKA-19297: Refactor AsyncKafkaConsumer's use of Java Streams APIs in critical sections [kafka]

2025-06-09 Thread via GitHub
kirktrue commented on code in PR #19917: URL: https://github.com/apache/kafka/pull/19917#discussion_r2136340952 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/TopicMetadataRequestManager.java: ## @@ -84,16 +84,21 @@ public TopicMetadataRequestManager(final

Re: [PR] KAFKA-19354: KRaft observer should fetch from leader after rediscovery [kafka]

2025-06-09 Thread via GitHub
ahuang98 commented on code in PR #19854: URL: https://github.com/apache/kafka/pull/19854#discussion_r2136234763 ## raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java: ## @@ -2543,13 +2543,16 @@ private void maybeTransition( } else { trans

Re: [PR] KAFKA-19297: Refactor AsyncKafkaConsumer's use of Java Streams APIs in critical sections [kafka]

2025-06-09 Thread via GitHub
kirktrue commented on code in PR #19917: URL: https://github.com/apache/kafka/pull/19917#discussion_r2136357518 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/TopicMetadataRequestManager.java: ## @@ -84,16 +84,21 @@ public TopicMetadataRequestManager(final

Re: [PR] KAFKA-19297: Refactor AsyncKafkaConsumer's use of Java Streams APIs in critical sections [kafka]

2025-06-09 Thread via GitHub
kirktrue commented on code in PR #19917: URL: https://github.com/apache/kafka/pull/19917#discussion_r2136355942 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractMembershipManager.java: ## @@ -1135,7 +1134,9 @@ CompletableFuture revokePartitions(Set p

[jira] [Created] (KAFKA-19392) `metadata.log.segment.ms` is not applied

2025-06-09 Thread Chia-Ping Tsai (Jira)
Chia-Ping Tsai created KAFKA-19392: -- Summary: `metadata.log.segment.ms` is not applied Key: KAFKA-19392 URL: https://issues.apache.org/jira/browse/KAFKA-19392 Project: Kafka Issue Type: Bug

Re: [PR] KAFKA-19283: Update transaction exception handling documentation [kafka]

2025-06-09 Thread via GitHub
jolshan commented on code in PR #19931: URL: https://github.com/apache/kafka/pull/19931#discussion_r2135997432 ## docs/design.html: ## @@ -340,6 +340,18 @@ +The error handling for transactional producer has been standardized which ensures consistent behavior and clearer er

Re: [PR] KAFKA-19283: Update transaction exception handling documentation [kafka]

2025-06-09 Thread via GitHub
jolshan commented on code in PR #19931: URL: https://github.com/apache/kafka/pull/19931#discussion_r2135998371 ## docs/design.html: ## @@ -340,6 +340,18 @@ +The error handling for transactional producer has been standardized which ensures consistent behavior and clearer er

[PR] Feat/issues 208 [kafka]

2025-06-09 Thread via GitHub
nookyo opened a new pull request, #19935: URL: https://github.com/apache/kafka/pull/19935 Delete this text and replace it with a detailed description of your change. The PR title and body will become the squashed commit message. If you would like to tag individuals, add some comme

Re: [PR] Feat/issues 208 [kafka]

2025-06-09 Thread via GitHub
nookyo closed pull request #19935: Feat/issues 208 URL: https://github.com/apache/kafka/pull/19935 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-

Re: [PR] KAFKA-19389: Fix memory consumption for completed share fetch requests [kafka]

2025-06-09 Thread via GitHub
junrao commented on code in PR #19928: URL: https://github.com/apache/kafka/pull/19928#discussion_r2136178608 ## core/src/main/java/kafka/server/share/DelayedShareFetch.java: ## @@ -808,9 +809,18 @@ private void releasePartitionLocksAndAddToActionQueue(Set topi // then

[jira] [Commented] (KAFKA-19299) Fix flaky RemoteIndexCacheTest#testCacheEntryIsDeletedOnRemoval

2025-06-09 Thread Uladzislau Blok (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17957043#comment-17957043 ] Uladzislau Blok commented on KAFKA-19299: - https://github.com/apache/kafka/pull/

[jira] [Updated] (KAFKA-19299) Fix flaky RemoteIndexCacheTest#testCacheEntryIsDeletedOnRemoval

2025-06-09 Thread Uladzislau Blok (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19299?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Uladzislau Blok updated KAFKA-19299: Description: [https://github.com/apache/kafka/actions/runs/15082423973/job/42401003258?pr=

Re: [PR] KAFKA-19297: Refactor AsyncKafkaConsumer's use of Java Streams APIs in critical sections [kafka]

2025-06-09 Thread via GitHub
lianetm commented on code in PR #19917: URL: https://github.com/apache/kafka/pull/19917#discussion_r2136213734 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractMembershipManager.java: ## @@ -1135,7 +1134,9 @@ CompletableFuture revokePartitions(Set pa

Re: [PR] KAFKA-19283: Update transaction exception handling documentation [kafka]

2025-06-09 Thread via GitHub
k-raina commented on code in PR #19931: URL: https://github.com/apache/kafka/pull/19931#discussion_r2136215946 ## docs/design.html: ## @@ -340,6 +340,18 @@ +The error handling for transactional producer has been standardized which ensures consistent behavior and clearer er

[jira] [Updated] (KAFKA-19080) The constraint on segment.bytes is not enforced at topic level

2025-06-09 Thread Jun Rao (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19080?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao updated KAFKA-19080: Summary: The constraint on segment.bytes is not enforced at topic level (was: The constraint on segment.m

[jira] [Comment Edited] (KAFKA-19080) The constraint on segment.bytes is not enforced at topic level

2025-06-09 Thread Jun Rao (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17940821#comment-17940821 ] Jun Rao edited comment on KAFKA-19080 at 6/9/25 8:35 PM: - [~iamo

Re: [PR] KAFKA-19297: Refactor AsyncKafkaConsumer's use of Java Streams APIs in critical sections [kafka]

2025-06-09 Thread via GitHub
kirktrue commented on code in PR #19917: URL: https://github.com/apache/kafka/pull/19917#discussion_r2136347808 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/TopicMetadataRequestManager.java: ## @@ -84,16 +84,21 @@ public TopicMetadataRequestManager(final

Re: [PR] KAFKA-18024 ConcurrentModificationException in Kafka OffsetFetcher - Proposal for Thread-Safety Fix - Update OffsetFetcher.java [kafka]

2025-06-09 Thread via GitHub
kamil-adam-nowak commented on PR #17826: URL: https://github.com/apache/kafka/pull/17826#issuecomment-2955958378 @lianetm @mimaison @frankvicky @FrankYang0529 @gongxuanzhang @chia7712 Can you please take a second look? @kamalcph wrote it looked good to him. The problem still exists. The b

Re: [PR] KAFKA-19080 The constraint on segment.ms is not enforced at topic level [kafka]

2025-06-09 Thread via GitHub
chia7712 commented on code in PR #19371: URL: https://github.com/apache/kafka/pull/19371#discussion_r2135853739 ## core/src/main/scala/kafka/raft/KafkaMetadataLog.scala: ## @@ -588,9 +588,11 @@ object KafkaMetadataLog extends Logging { nodeId: Int ): KafkaMetadataLog = {

[jira] [Updated] (KAFKA-19271) Private interface for injecting test wrappers for KIP-1071 enabled consumers

2025-06-09 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19271?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax updated KAFKA-19271: Fix Version/s: 4.1.0 > Private interface for injecting test wrappers for KIP-1071 enabled

[jira] [Updated] (KAFKA-19392) `metadata.log.segment.ms` is not applied

2025-06-09 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19392?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai updated KAFKA-19392: --- Fix Version/s: 4.1.0 > `metadata.log.segment.ms` is not applied > --

[jira] [Comment Edited] (KAFKA-1983) TestEndToEndLatency can be unreliable after hard kill

2025-06-09 Thread vinupreethi93 (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-1983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17957018#comment-17957018 ] vinupreethi93 edited comment on KAFKA-1983 at 6/9/25 3:23 PM: -

[PR] KAFKA-14895: [2/N] Move AddPartitionsToTxnManager files to java [kafka]

2025-06-09 Thread via GitHub
brandboat opened a new pull request, #19933: URL: https://github.com/apache/kafka/pull/19933 Move AddPartitionsToTxnManagerTest to java -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

Re: [PR] KAFKA-14895: [2/N] Move AddPartitionsToTxnManager files to java [kafka]

2025-06-09 Thread via GitHub
brandboat commented on PR #19933: URL: https://github.com/apache/kafka/pull/19933#issuecomment-2956070664 This is the final piece of [KAFKA-14895](https://issues.apache.org/jira/browse/KAFKA-14895) -- This is an automated message from the Apache Git Service. To respond to the message, ple

[jira] (KAFKA-1983) TestEndToEndLatency can be unreliable after hard kill

2025-06-09 Thread vinupreethi93 (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-1983 ] vinupreethi93 deleted comment on KAFKA-1983: -- was (Author: JIRAUSER309961): Hi If i hard kill another process is coming > TestEndToEndLatency can be unreliable after hard kill >

[jira] [Commented] (KAFKA-1983) TestEndToEndLatency can be unreliable after hard kill

2025-06-09 Thread vinupreethi93 (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-1983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17957018#comment-17957018 ] vinupreethi93 commented on KAFKA-1983: -- Hi, [~junrao]  How to reproduce this issue,

[PR] Update EndToEndLatency.java [kafka]

2025-06-09 Thread via GitHub
vinupreethi opened a new pull request, #19934: URL: https://github.com/apache/kafka/pull/19934 Delete this text and replace it with a detailed description of your change. The PR title and body will become the squashed commit message. If you would like to tag individuals, add some

[PR] KAFKA-19392: Fix metadata.log.segment.ms not being applied [kafka]

2025-06-09 Thread via GitHub
mingyen066 opened a new pull request, #19936: URL: https://github.com/apache/kafka/pull/19936 The original props.setProperty(TopicConfig.SEGMENT_MS_CONFIG, config.logSegmentMillis.toString) in the KafkaMetadataLog constructor was accidentally removed. Add a test to ensure this property is p

[PR] KAFKA-7699: Anchored punctuation [kafka]

2025-06-09 Thread via GitHub
hermanjakobsen opened a new pull request, #19937: URL: https://github.com/apache/kafka/pull/19937 This PR implements Processor API interfaces for using Anchored punctuation. As described in https://cwiki.apache.org/confluence/display/KAFKA/KIP-1146%3A+Anchored+punctuation, anchored punctua

Re: [PR] KAFKA-7699: Anchored punctuation [kafka]

2025-06-09 Thread via GitHub
hermanjakobsen commented on PR #19937: URL: https://github.com/apache/kafka/pull/19937#issuecomment-2956489125 Would really appreciate input from @mjsax, @ableegoldman or @bbejeck as this is my first PR to the Kafka project :) -- This is an automated message from the Apache Git Service. T

Re: [PR] KAFKA-19354: KRaft observer should fetch from leader after rediscovery [kafka]

2025-06-09 Thread via GitHub
ahuang98 commented on code in PR #19854: URL: https://github.com/apache/kafka/pull/19854#discussion_r2114996046 ## raft/src/test/java/org/apache/kafka/raft/KafkaRaftClientTest.java: ## @@ -2145,7 +2186,19 @@ public void testObserverSendDiscoveryFetchAfterFetchTimeout(boolean wi

Re: [PR] KAFKA-19283: Update transaction exception handling documentation [kafka]

2025-06-09 Thread via GitHub
k-raina commented on code in PR #19931: URL: https://github.com/apache/kafka/pull/19931#discussion_r2136066260 ## docs/design.html: ## @@ -340,6 +340,18 @@ +The error handling for transactional producer has been standardized which ensures consistent behavior and clearer er

Re: [PR] KAFKA-19283: Update transaction exception handling documentation [kafka]

2025-06-09 Thread via GitHub
jolshan commented on code in PR #19931: URL: https://github.com/apache/kafka/pull/19931#discussion_r2136074359 ## docs/design.html: ## @@ -340,6 +340,18 @@ +The error handling for transactional producer has been standardized which ensures consistent behavior and clearer er

Re: [PR] MINOR: add lower case lister name integration test [kafka]

2025-06-09 Thread via GitHub
FrankYang0529 commented on code in PR #19932: URL: https://github.com/apache/kafka/pull/19932#discussion_r2135889969 ## test-common/test-common-runtime/src/main/java/org/apache/kafka/common/test/KafkaClusterTestKit.java: ## @@ -556,7 +556,7 @@ public String bootstrapServers() {

Re: [PR] KAFKA-18760: Deprecate Optional and return String from public Endpoint#listener [kafka]

2025-06-09 Thread via GitHub
FrankYang0529 commented on PR #19191: URL: https://github.com/apache/kafka/pull/19191#issuecomment-2956009055 Created a followup PR: https://github.com/apache/kafka/pull/19932 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub an

Re: [PR] MINOR: Cleanup simplify set initialization with Set.of [kafka]

2025-06-09 Thread via GitHub
Yunyung commented on PR #19925: URL: https://github.com/apache/kafka/pull/19925#issuecomment-2955984206 Thanks @FrankYang0529 and @m1a2st for the review. Update according to the comments. -- This is an automated message from the Apache Git Service. To respond to the message, please log o

[jira] [Commented] (KAFKA-19392) `metadata.log.segment.ms` is not applied

2025-06-09 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17957016#comment-17957016 ] Chia-Ping Tsai commented on KAFKA-19392: see https://github.com/apache/kafka/pul

Re: [PR] MINOR: add lower case lister name integration test [kafka]

2025-06-09 Thread via GitHub
chia7712 commented on code in PR #19932: URL: https://github.com/apache/kafka/pull/19932#discussion_r2135875059 ## test-common/test-common-runtime/src/main/java/org/apache/kafka/common/test/KafkaClusterTestKit.java: ## @@ -556,7 +556,7 @@ public String bootstrapServers() {

Re: [PR] KAFKA-19297: Refactor AsyncKafkaConsumer's use of Java Streams APIs in critical sections [kafka]

2025-06-09 Thread via GitHub
AndrewJSchofield commented on code in PR #19917: URL: https://github.com/apache/kafka/pull/19917#discussion_r2135851674 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractMembershipManager.java: ## @@ -1135,7 +1134,9 @@ CompletableFuture revokePartitio

Re: [PR] KAFKA-18961: Time-based refresh for server-side RE2J regex [kafka]

2025-06-09 Thread via GitHub
dongnuo123 commented on code in PR #19904: URL: https://github.com/apache/kafka/pull/19904#discussion_r2135951958 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorConfig.java: ## @@ -204,6 +205,11 @@ public class GroupCoordinatorConfig {

Re: [PR] KAFKA-18834: Fix LoggingResourceTest#testSetLevelDefaultScope [kafka]

2025-06-09 Thread via GitHub
apalan60 commented on PR #19920: URL: https://github.com/apache/kafka/pull/19920#issuecomment-2956146626 I ran a few more test classes that use logging with the command below. They all passed successfully when executed in the same JVM. ``` /gradlew cleanTest \ -- :connect:ru

Re: [PR] KAFKA-19389: Fix memory consumption for completed share fetch requests [kafka]

2025-06-09 Thread via GitHub
apoorvmittal10 commented on code in PR #19928: URL: https://github.com/apache/kafka/pull/19928#discussion_r2136268973 ## core/src/main/java/kafka/server/share/DelayedShareFetch.java: ## @@ -808,9 +809,18 @@ private void releasePartitionLocksAndAddToActionQueue(Set topi

Re: [PR] KAFKA-15615: Improve handling of fetching during metadata updates [kafka]

2025-06-09 Thread via GitHub
github-actions[bot] commented on PR #15647: URL: https://github.com/apache/kafka/pull/15647#issuecomment-2957594233 This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please leave a comment asking for a review. If the P

Re: [PR] MINOR: Use `pollUntilTrue` instead of `waitForCondition` [kafka]

2025-06-09 Thread via GitHub
frankvicky merged PR #19911: URL: https://github.com/apache/kafka/pull/19911 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apac

Re: [PR] KAFKA-19144 Move DelayedProduce to server module [kafka]

2025-06-09 Thread via GitHub
johnny94 commented on code in PR #19793: URL: https://github.com/apache/kafka/pull/19793#discussion_r2135206260 ## core/src/main/scala/kafka/server/ReplicaManager.scala: ## @@ -909,12 +911,33 @@ class ReplicaManager(val config: KafkaConfig, entriesPerPartition: Map[TopicIdP

Re: [PR] MINOR: Remove unused code from storage classes [kafka]

2025-06-09 Thread via GitHub
frankvicky commented on code in PR #19853: URL: https://github.com/apache/kafka/pull/19853#discussion_r2135208762 ## storage/src/main/java/org/apache/kafka/server/log/remote/storage/RemoteLogManagerConfig.java: ## @@ -407,18 +407,6 @@ public long remoteLogManagerTaskIntervalMs()

[jira] [Updated] (KAFKA-19386) Incorrect ExpirationReaper thread names from DelayedOperationPurgatory

2025-06-09 Thread Apoorv Mittal (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19386?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Apoorv Mittal updated KAFKA-19386: -- Fix Version/s: 4.1.0 > Incorrect ExpirationReaper thread names from DelayedOperationPurgatory

[jira] [Resolved] (KAFKA-19386) Incorrect ExpirationReaper thread names from DelayedOperationPurgatory

2025-06-09 Thread Apoorv Mittal (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19386?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Apoorv Mittal resolved KAFKA-19386. --- Resolution: Fixed > Incorrect ExpirationReaper thread names from DelayedOperationPurgatory >

Re: [PR] KAFKA-19386: Correcting ExpirationReaper thread names from Purgatory [kafka]

2025-06-09 Thread via GitHub
apoorvmittal10 merged PR #19918: URL: https://github.com/apache/kafka/pull/19918 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.

Re: [PR] MINOR: Fix duplicate IPv6 entries in ducker-ak [kafka]

2025-06-09 Thread via GitHub
DL1231 commented on code in PR #19926: URL: https://github.com/apache/kafka/pull/19926#discussion_r2135577426 ## tests/docker/ducker-ak: ## @@ -431,15 +431,15 @@ attempting to start new ones." exec 3>&- for n in $(seq -f %02g 1 ${num_nodes}); do local node="du

Re: [PR] MINOR: Fix duplicate IPv6 entries in ducker-ak [kafka]

2025-06-09 Thread via GitHub
Yunyung commented on code in PR #19926: URL: https://github.com/apache/kafka/pull/19926#discussion_r2135597580 ## tests/docker/ducker-ak: ## @@ -431,15 +431,15 @@ attempting to start new ones." exec 3>&- for n in $(seq -f %02g 1 ${num_nodes}); do local node="d

Re: [PR] KAFKA-18486 Update testClearPurgatoryOnBecomingFollower etc with KRaft mechanism in ReplicaManagerTest [kafka]

2025-06-09 Thread via GitHub
m1a2st commented on code in PR #19924: URL: https://github.com/apache/kafka/pull/19924#discussion_r2135620371 ## core/src/test/scala/unit/kafka/server/ReplicaManagerTest.scala: ## @@ -451,20 +451,21 @@ class ReplicaManagerTest { partition.createLogIfNotExists(isNew = fals

Re: [PR] KAFKA-18486:Remove ReplicaManager#becomeLeaderOrFollower in `testVerificationErrorConversions` [kafka]

2025-06-09 Thread via GitHub
Rancho-7 commented on code in PR #19923: URL: https://github.com/apache/kafka/pull/19923#discussion_r2135630377 ## core/src/test/scala/unit/kafka/server/ReplicaManagerTest.scala: ## @@ -2702,9 +2703,9 @@ class ReplicaManagerTest { val replicaManager = setUpReplicaManager

Re: [PR] KAFKA-19382:Upgrade junit from 5.10 to 5.13 [kafka]

2025-06-09 Thread via GitHub
Rancho-7 commented on PR #19919: URL: https://github.com/apache/kafka/pull/19919#issuecomment-2955634717 > Could you also update the version of JUnit in NOTICE-binary ? @frankvicky Thanks for catching this.Updated. -- This is an automated message from the Apache Git Service. To resp

  1   2   >