Re: [PR] KAFKA-18913: State Updater thread not shutting down during teardown i… [kafka]

2025-06-05 Thread via GitHub
cadonna commented on code in PR #19889: URL: https://github.com/apache/kafka/pull/19889#discussion_r2128074684 ## streams/src/test/java/org/apache/kafka/streams/processor/internals/TaskManagerTest.java: ## @@ -4837,6 +4841,44 @@ public void shouldUseStartupTasksFromStateDirecto

Re: [PR] KAFKA-16505: Add source raw key and value [kafka]

2025-06-05 Thread via GitHub
cadonna commented on PR #18739: URL: https://github.com/apache/kafka/pull/18739#issuecomment-2942996619 @loicgreffier Could you please a description to the PR and remove the template text? -- This is an automated message from the Apache Git Service. To respond to the message, please log o

Re: [PR] KAFKA-19369: Add group.share.assignors config and integration test [kafka]

2025-06-05 Thread via GitHub
FrankYang0529 commented on PR #19900: URL: https://github.com/apache/kafka/pull/19900#issuecomment-2943027971 The flaky test `PlaintextConsumerTest#testCloseLeavesGroupOnInterrupt` is not related to this PR. https://issues.apache.org/jira/browse/KAFKA-18031 -- This is an automated

Re: [PR] MINOR: Refactor brokerContactTimesMs and brokerRegistrationStates to use Long and Integer [kafka]

2025-06-05 Thread via GitHub
m1a2st commented on code in PR #19888: URL: https://github.com/apache/kafka/pull/19888#discussion_r2128126026 ## metadata/src/main/java/org/apache/kafka/controller/metrics/QuorumControllerMetrics.java: ## @@ -267,19 +267,15 @@ public long newActiveControllers() { } p

[PR] KAFKA-19370: Create JMH benchmark for share group assignor [kafka]

2025-06-05 Thread via GitHub
AndrewJSchofield opened a new pull request, #19907: URL: https://github.com/apache/kafka/pull/19907 As part of readying share groups for production, we want to ensure that the performance of the server-side assignor is optimal. In common with consumer group assignors, a JMH benchmark is use

Re: [PR] MINOR: Refactor brokerContactTimesMs and brokerRegistrationStates to use Long and Integer [kafka]

2025-06-05 Thread via GitHub
apalan60 commented on code in PR #19888: URL: https://github.com/apache/kafka/pull/19888#discussion_r2128497097 ## metadata/src/main/java/org/apache/kafka/controller/metrics/QuorumControllerMetrics.java: ## @@ -267,19 +267,15 @@ public long newActiveControllers() { }

Re: [PR] MINOR: Refactor brokerContactTimesMs and brokerRegistrationStates to use Long and Integer [kafka]

2025-06-05 Thread via GitHub
apalan60 commented on code in PR #19888: URL: https://github.com/apache/kafka/pull/19888#discussion_r2128416052 ## metadata/src/main/java/org/apache/kafka/controller/metrics/QuorumControllerMetrics.java: ## @@ -267,19 +267,15 @@ public long newActiveControllers() { }

Re: [PR] KAFKA-14895: [1/N] Move AddPartitionsToTxnManager files to java [kafka]

2025-06-05 Thread via GitHub
chia7712 commented on PR #19879: URL: https://github.com/apache/kafka/pull/19879#issuecomment-2943742176 ``` > Task :core:compileTestScala [Error] /home/chia7712/project/kafka/core/src/test/scala/unit/kafka/server/ReplicaManagerTest.scala:2450:32: type mismatch; found : scala.co

Re: [PR] KAFKA-19221: Propagate IOException on LogSegment#close [kafka]

2025-06-05 Thread via GitHub
chia7712 commented on PR #19607: URL: https://github.com/apache/kafka/pull/19607#issuecomment-2943645837 ``` * What went wrong: Execution failed for task ':storage:spotlessJavaCheck'. > The following files had format violations: src/test/java/org/apache/kafka/storage/intern

Re: [PR] KAFKA-19239 Rewrite IntegrationTestUtils by java [kafka]

2025-06-05 Thread via GitHub
chia7712 commented on PR #19776: URL: https://github.com/apache/kafka/pull/19776#issuecomment-2943635600 @jim0987795064 please check the failed tests or sync the trunk to trigger QA again -- This is an automated message from the Apache Git Service. To respond to the message, please log on

Re: [PR] KAFKA-19144 Move DelayedProduce to server module [kafka]

2025-06-05 Thread via GitHub
chia7712 commented on code in PR #19793: URL: https://github.com/apache/kafka/pull/19793#discussion_r2128531545 ## core/src/main/scala/kafka/server/ReplicaManager.scala: ## @@ -909,12 +911,33 @@ class ReplicaManager(val config: KafkaConfig, entriesPerPartition: Map[TopicIdP

Re: [PR] KAFKA-19042: [12/N] Move PlaintextConsumerSubscriptionTest to client-integration-tests module [kafka]

2025-06-05 Thread via GitHub
chia7712 commented on PR #19827: URL: https://github.com/apache/kafka/pull/19827#issuecomment-2943768892 @m1a2st please fix the conflicts -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

Re: [PR] MINOR: Update stream RPCs security guide in developer documentation [kafka]

2025-06-05 Thread via GitHub
kumarlokesh commented on PR #19799: URL: https://github.com/apache/kafka/pull/19799#issuecomment-2943861487 @lucasbru thanks for the feedback! Updated documentation here https://github.com/apache/kafka/pull/19799/commits/3415d7ebe2042c9a990b10e0b774aa9bb8c2c9ab -- This is an automated mes

Re: [PR] KAFKA-14895: [1/N] Move AddPartitionsToTxnManager files to java [kafka]

2025-06-05 Thread via GitHub
jolshan commented on code in PR #19879: URL: https://github.com/apache/kafka/pull/19879#discussion_r2129218499 ## server/src/main/java/org/apache/kafka/server/transaction/AddPartitionsToTxnManager.java: ## @@ -0,0 +1,352 @@ +/* + * Licensed to the Apache Software Foundation (ASF

Re: [PR] KAFKA-19244: Add support for kafka-streams-groups.sh options (delete internal topics) [3/N] [kafka]

2025-06-05 Thread via GitHub
aliehsaeedii commented on code in PR #19893: URL: https://github.com/apache/kafka/pull/19893#discussion_r2129227851 ## tools/src/test/java/org/apache/kafka/tools/streams/DeleteStreamsInternalTopicsTest.java: ## @@ -0,0 +1,392 @@ +/* + * Licensed to the Apache Software Foundation

Re: [PR] KAFKA-19315: Move ControllerMutationQuotaManager to server module [kafka]

2025-06-05 Thread via GitHub
chia7712 commented on code in PR #19807: URL: https://github.com/apache/kafka/pull/19807#discussion_r2129670800 ## server/src/main/java/org/apache/kafka/server/PermissiveControllerMutationQuota.java: ## @@ -0,0 +1,59 @@ +/* + * Licensed to the Apache Software Foundation (ASF) un

Re: [PR] KAFKA-19369: Add group.share.assignors config and integration test [kafka]

2025-06-05 Thread via GitHub
DL1231 commented on code in PR #19900: URL: https://github.com/apache/kafka/pull/19900#discussion_r2131283934 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorConfig.java: ## @@ -550,6 +565,43 @@ protected List consumerGroupAssignors(

[jira] [Updated] (KAFKA-19377) Update /streams/developer-guide/security.html

2025-06-05 Thread Lucas Brutschy (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19377?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lucas Brutschy updated KAFKA-19377: --- Description: KIP-1071 needs DESCRIBE GROUP / READ GROUP permissions. to describe required A

[jira] [Created] (KAFKA-19379) Update /streams/upgrade-guide for KIP-1071

2025-06-05 Thread Lucas Brutschy (Jira)
Lucas Brutschy created KAFKA-19379: -- Summary: Update /streams/upgrade-guide for KIP-1071 Key: KAFKA-19379 URL: https://issues.apache.org/jira/browse/KAFKA-19379 Project: Kafka Issue Type: Su

[jira] [Updated] (KAFKA-19378) Update /streams/developer-guide/config-streams.html for KIP-1071

2025-06-05 Thread Lucas Brutschy (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19378?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lucas Brutschy updated KAFKA-19378: --- Summary: Update /streams/developer-guide/config-streams.html for KIP-1071 (was: Update deve

[jira] [Updated] (KAFKA-19377) Update /streams/developer-guide/security.html for KIP-1071

2025-06-05 Thread Lucas Brutschy (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19377?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lucas Brutschy updated KAFKA-19377: --- Summary: Update /streams/developer-guide/security.html for KIP-1071 (was: Update /streams/d

[jira] [Updated] (KAFKA-19377) Update /streams/developer-guide/security.html

2025-06-05 Thread Lucas Brutschy (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19377?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lucas Brutschy updated KAFKA-19377: --- Summary: Update /streams/developer-guide/security.html (was: Update /streams/developer-gui

[jira] [Created] (KAFKA-19380) Update streams/developer-guide/app-reset-tool.html

2025-06-05 Thread Lucas Brutschy (Jira)
Lucas Brutschy created KAFKA-19380: -- Summary: Update streams/developer-guide/app-reset-tool.html Key: KAFKA-19380 URL: https://issues.apache.org/jira/browse/KAFKA-19380 Project: Kafka Issue

Re: [PR] MINOR: Refactor brokerContactTimesMs and brokerRegistrationStates to use Long and Integer [kafka]

2025-06-05 Thread via GitHub
apalan60 commented on code in PR #19888: URL: https://github.com/apache/kafka/pull/19888#discussion_r2129142061 ## metadata/src/main/java/org/apache/kafka/controller/metrics/QuorumControllerMetrics.java: ## @@ -267,19 +267,15 @@ public long newActiveControllers() { }

Re: [PR] KAFKA-19376: Throw an error message if any unsupported feature is used with KIP-1071 [kafka]

2025-06-05 Thread via GitHub
Copilot commented on code in PR #19908: URL: https://github.com/apache/kafka/pull/19908#discussion_r2128937509 ## streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java: ## @@ -1047,6 +1051,21 @@ private KafkaStreams(final TopologyMetadata topologyMetadata, r

Re: [PR] KAFKA-19244: Add support for kafka-streams-groups.sh options (delete internal topics) [3/N] [kafka]

2025-06-05 Thread via GitHub
aliehsaeedii commented on code in PR #19893: URL: https://github.com/apache/kafka/pull/19893#discussion_r2129169801 ## tools/src/test/java/org/apache/kafka/tools/streams/DeleteStreamsInternalTopicsTest.java: ## @@ -0,0 +1,392 @@ +/* + * Licensed to the Apache Software Foundation

[jira] [Commented] (KAFKA-19012) Messages ending up on the wrong topic

2025-06-05 Thread Jun Rao (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17956484#comment-17956484 ] Jun Rao commented on KAFKA-19012: - [~dnadolny] : Thanks for the reporting this issue. Co

Re: [PR] KAFKA-19369: Add group.share.assignors config and integration test [kafka]

2025-06-05 Thread via GitHub
FrankYang0529 commented on code in PR #19900: URL: https://github.com/apache/kafka/pull/19900#discussion_r2131486262 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorConfig.java: ## @@ -550,6 +565,43 @@ protected List consumerGroupAssignors(

Re: [PR] KAFKA-3987: Replace MD5 for FIPS 140-3 compliance in Log Cleaner. [kafka]

2025-06-05 Thread via GitHub
github-actions[bot] commented on PR #19035: URL: https://github.com/apache/kafka/pull/19035#issuecomment-2947966820 A label of 'needs-attention' was automatically added to this PR in order to raise the attention of the committers. Once this issue has been triaged, the `triage` label s

Re: [PR] KAFKA-19193 Support rack-aware partitioning for Kafka producer [kafka]

2025-06-05 Thread via GitHub
github-actions[bot] commented on PR #19850: URL: https://github.com/apache/kafka/pull/19850#issuecomment-2947966525 A label of 'needs-attention' was automatically added to this PR in order to raise the attention of the committers. Once this issue has been triaged, the `triage` label s

Re: [PR] KAFKA-18024 ConcurrentModificationException in Kafka OffsetFetcher - Proposal for Thread-Safety Fix - Update OffsetFetcher.java [kafka]

2025-06-05 Thread via GitHub
github-actions[bot] commented on PR #17826: URL: https://github.com/apache/kafka/pull/17826#issuecomment-2947988798 This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please leave a comment asking for a review. If the P

Re: [PR] MINOR: Cleanup Core Module- Scala Modules (4/n) [kafka]

2025-06-05 Thread via GitHub
frankvicky merged PR #19805: URL: https://github.com/apache/kafka/pull/19805 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apac

Re: [PR] MINOR: Cleanup KafkaApisTest `asJava` conversions [kafka]

2025-06-05 Thread via GitHub
github-actions[bot] commented on PR #19851: URL: https://github.com/apache/kafka/pull/19851#issuecomment-2947966504 A label of 'needs-attention' was automatically added to this PR in order to raise the attention of the committers. Once this issue has been triaged, the `triage` label s

Re: [PR] KAFKA-19376: Throw an error message if any unsupported feature is used with KIP-1071 [kafka]

2025-06-05 Thread via GitHub
lucasbru commented on PR #19908: URL: https://github.com/apache/kafka/pull/19908#issuecomment-2944547123 @aliehsaeedii Please take a look -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

Re: [PR] MINOR: Rename ambiguous method name [kafka]

2025-06-05 Thread via GitHub
hgh1472 commented on PR #19875: URL: https://github.com/apache/kafka/pull/19875#issuecomment-2944840033 @lianetm I've completed the changes as suggested! I think `throwIfGroupIdEmpty` is the most appropriate name. -- This is an automated message from the Apache Git Service. To respo

[jira] [Updated] (KAFKA-19373) Fix consumer integration tests checks on protocol name

2025-06-05 Thread Lianet Magrans (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19373?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lianet Magrans updated KAFKA-19373: --- Labels: (was: client) > Fix consumer integration tests checks on protocol name > -

Re: [PR] MINOR: clean KafkaConsumer tests [kafka]

2025-06-05 Thread via GitHub
mjsax merged PR #19669: URL: https://github.com/apache/kafka/pull/19669 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or

[jira] [Updated] (KAFKA-19373) Fix consumer integration tests checks on protocol name

2025-06-05 Thread Lianet Magrans (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19373?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lianet Magrans updated KAFKA-19373: --- Component/s: clients > Fix consumer integration tests checks on protocol name >

Re: [PR] KAFKA-14895: [1/N] Move AddPartitionsToTxnManager files to java [kafka]

2025-06-05 Thread via GitHub
chia7712 commented on code in PR #19879: URL: https://github.com/apache/kafka/pull/19879#discussion_r2129098691 ## server/src/main/java/org/apache/kafka/server/transaction/AddPartitionsToTxnManager.java: ## @@ -0,0 +1,352 @@ +/* + * Licensed to the Apache Software Foundation (AS

Re: [PR] KAFKA-14145; Faster KRaft HWM replication [kafka]

2025-06-05 Thread via GitHub
ahuang98 commented on code in PR #19800: URL: https://github.com/apache/kafka/pull/19800#discussion_r2130040186 ## raft/src/test/java/org/apache/kafka/raft/KafkaRaftClientFetchTest.java: ## @@ -149,4 +153,327 @@ void testReplicationOfHigherPartitionLeaderEpoch() throws Exceptio

[jira] [Created] (KAFKA-19375) Some Topic partitions on one Kafka node in the cluster service cannot be automatically cleaned up, leading to disk space occupation

2025-06-05 Thread Jira
韩建东 created KAFKA-19375: --- Summary: Some Topic partitions on one Kafka node in the cluster service cannot be automatically cleaned up, leading to disk space occupation Key: KAFKA-19375 URL: https://issues.apache.org/jira/bro

Re: [PR] KAFKA-18913: State Updater thread not shutting down during teardown i… [kafka]

2025-06-05 Thread via GitHub
janchilling commented on code in PR #19889: URL: https://github.com/apache/kafka/pull/19889#discussion_r2128752194 ## streams/src/test/java/org/apache/kafka/streams/processor/internals/TaskManagerTest.java: ## @@ -4837,6 +4841,44 @@ public void shouldUseStartupTasksFromStateDir

Re: [PR] MINOR: Cleanup JMH-Benchmarks Module [kafka]

2025-06-05 Thread via GitHub
sjhajharia commented on PR #19791: URL: https://github.com/apache/kafka/pull/19791#issuecomment-2944068063 Gentle reminder @frankvicky @chia7712 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] MINOR: Safe update dependencies [kafka]

2025-06-05 Thread via GitHub
m1a2st commented on code in PR #19897: URL: https://github.com/apache/kafka/pull/19897#discussion_r2129008697 ## gradle/dependencies.gradle: ## @@ -109,23 +109,23 @@ versions += [ mavenArtifact: "3.9.6", metrics: "2.2.0", mockito: "5.14.2", - opentelemetryProto: "1.0.0

Re: [PR] MINOR: Cleanup Core Module- Scala Modules (4/n) [kafka]

2025-06-05 Thread via GitHub
sjhajharia commented on PR #19805: URL: https://github.com/apache/kafka/pull/19805#issuecomment-2945178176 Gentle reminder @frankvicky -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

Re: [PR] KAFKA-18202: Add rejection for non-zero sequences in TV2 (KIP-890) [kafka]

2025-06-05 Thread via GitHub
jolshan commented on PR #19902: URL: https://github.com/apache/kafka/pull/19902#issuecomment-2945659561 @rreddy-22 looks like there are a few test failures related to this change. They may require code and/or test changes so let me know if you need assistance! -- This is an automated mess

Re: [PR] KAFKA-18961: Time-based refresh for server-side RE2J regex [kafka]

2025-06-05 Thread via GitHub
dongnuo123 commented on code in PR #19904: URL: https://github.com/apache/kafka/pull/19904#discussion_r2129826048 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/GroupMetadataManagerTest.java: ## @@ -20542,6 +20553,112 @@ barTopicName, computeTopicHash(barT

Re: [PR] KAFKA-18961: Time-based refresh for server-side RE2J regex [kafka]

2025-06-05 Thread via GitHub
dongnuo123 commented on code in PR #19904: URL: https://github.com/apache/kafka/pull/19904#discussion_r2129830186 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorConfig.java: ## @@ -204,6 +204,11 @@ public class GroupCoordinatorConfig {

[jira] [Updated] (KAFKA-19012) Messages ending up on the wrong topic

2025-06-05 Thread Ismael Juma (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19012?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ismael Juma updated KAFKA-19012: Priority: Blocker (was: Major) > Messages ending up on the wrong topic >

Re: [PR] MINOR: Cleanup KafkaApisTest `asJava` conversions [kafka]

2025-06-05 Thread via GitHub
dajac commented on PR #19851: URL: https://github.com/apache/kafka/pull/19851#issuecomment-2946544689 For my understanding, what’s wrong with using asJava conversion? It feels more natural to use Scala collections in Scala rather than using Java collections. -- This is an automated messa

Re: [PR] KAFKA-19309 : Add transaction client template code in kafka examples [kafka]

2025-06-05 Thread via GitHub
jolshan commented on PR #15913: URL: https://github.com/apache/kafka/pull/15913#issuecomment-2946838324 flaky tests don't usually block the build, I think it exited with a failure. will try one more time. -- This is an automated message from the Apache Git Service. To respond to the messa

[PR] KAFKA-19367: Fix InitProducerId with TV2 double-increments epoch if ongoing transaction is aborted [kafka]

2025-06-05 Thread via GitHub
rreddy-22 opened a new pull request, #19910: URL: https://github.com/apache/kafka/pull/19910 When InitProducerId is handled on the transaction coordinator, the producer epoch is incremented (so that we fence stale requests), then if a transaction was ongoing during this time, it's aborted.

Re: [PR] KAFKA-19244: Add support for kafka-streams-groups.sh options (reset-offsets) [1/N] [kafka]

2025-06-05 Thread via GitHub
aliehsaeedii commented on code in PR #19646: URL: https://github.com/apache/kafka/pull/19646#discussion_r2131061495 ## tools/src/main/java/org/apache/kafka/tools/streams/StreamsGroupCommand.java: ## @@ -330,13 +405,549 @@ Map getOffsets(StreamsGroupDescription description)

Re: [PR] MINOR: Rename ambiguous method name [kafka]

2025-06-05 Thread via GitHub
hgh1472 commented on PR #19875: URL: https://github.com/apache/kafka/pull/19875#issuecomment-2947193386 @lianetm Would it be correct to understand your point as saying that `throwIfGroupIdEmpty` could be confusing because the term “empty” overlaps with both Optional.empty() and an empty

Re: [PR] KAFKA-19367: Fix InitProducerId with TV2 double-increments epoch if ongoing transaction is aborted [kafka]

2025-06-05 Thread via GitHub
artemlivshits commented on code in PR #19910: URL: https://github.com/apache/kafka/pull/19910#discussion_r2131102531 ## core/src/main/scala/kafka/coordinator/transaction/TransactionCoordinator.scala: ## @@ -828,7 +828,16 @@ class TransactionCoordinator(txnConfig: TransactionConf

[jira] [Assigned] (KAFKA-19376) Throw an error message if any unsupported feature is used with KIP-1071

2025-06-05 Thread Lucas Brutschy (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19376?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lucas Brutschy reassigned KAFKA-19376: -- Assignee: Lucas Brutschy > Throw an error message if any unsupported feature is used

Re: [PR] MINOR: Safe update dependencies [kafka]

2025-06-05 Thread via GitHub
m1a2st commented on code in PR #19897: URL: https://github.com/apache/kafka/pull/19897#discussion_r2129030196 ## gradle/dependencies.gradle: ## @@ -53,33 +53,33 @@ versions += [ apacheda: "1.0.2", apacheds: "2.0.0-M24", argparse4j: "0.7.0", - bcpkix: "1.78.1", - caffe

Re: [PR] MINOR: Rename ambiguous method name [kafka]

2025-06-05 Thread via GitHub
lianetm commented on PR #19875: URL: https://github.com/apache/kafka/pull/19875#issuecomment-2945108957 Thanks for the update! Just a nit, `throwIfGroupIdNotDefined` or similar is probably the accurate one. The validation for empty group ID happens first, at a higher level in the constructo

Re: [PR] KAFKA-19309 : Add transaction client template code in kafka examples [kafka]

2025-06-05 Thread via GitHub
k-raina commented on PR #15913: URL: https://github.com/apache/kafka/pull/15913#issuecomment-2945726110 Changes in PR are related to docs and failures in pipeline are related to code: ``` FLAKY ⚠️ CustomQuotaCallbackTest > testCustomQuotaCallback(String).groupProtocol=consumer FLA

[PR] MINOR: ELR release note for 4.1 [kafka]

2025-06-05 Thread via GitHub
CalvinConfluent opened a new pull request, #19909: URL: https://github.com/apache/kafka/pull/19909 Mention that ELR will be enabled by default on new clusters in 4.1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

Re: [PR] KAFKA-19315: Move ControllerMutationQuotaManager to server module [kafka]

2025-06-05 Thread via GitHub
YutaLin commented on code in PR #19807: URL: https://github.com/apache/kafka/pull/19807#discussion_r2131182767 ## server/src/main/java/org/apache/kafka/server/ControllerMutationQuotaManager.java: ## @@ -0,0 +1,194 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[jira] [Updated] (KAFKA-19375) Some Topic partitions on one Kafka node in the cluster service cannot be automatically cleaned up, leading to disk space occupation

2025-06-05 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-19375?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] 韩建东 updated KAFKA-19375: Description: we are unable to determine the cause of this situation, but the error logs from the faulty node proc

[jira] [Created] (KAFKA-19376) Throw an error message if any unsupported feature is used with KIP-1071

2025-06-05 Thread Lucas Brutschy (Jira)
Lucas Brutschy created KAFKA-19376: -- Summary: Throw an error message if any unsupported feature is used with KIP-1071 Key: KAFKA-19376 URL: https://issues.apache.org/jira/browse/KAFKA-19376 Project:

[jira] [Updated] (KAFKA-19375) Some Topic partitions on one Kafka node in the cluster service cannot be automatically cleaned up, leading to disk space occupation

2025-06-05 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-19375?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] 韩建东 updated KAFKA-19375: Remaining Estimate: (was: 720h) Original Estimate: (was: 720h) > Some Topic partitions on one Kafka n

Re: [PR] KAFKA-19325 improve forceComplete() in DelayedOperation [kafka]

2025-06-05 Thread via GitHub
m1a2st commented on PR #19862: URL: https://github.com/apache/kafka/pull/19862#issuecomment-2944555265 Thanks for @apoorvmittal10 comments, addressed it :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[PR] KAFKA-19376: Throw an error message if any unsupported feature is used with KIP-1071 [kafka]

2025-06-05 Thread via GitHub
lucasbru opened a new pull request, #19908: URL: https://github.com/apache/kafka/pull/19908 We should be mindful of ours users and let them know early if they are using an unsupported feature in 4.1. Unsupported features: - Regular expressions - Warm-up replicas (high availa

Re: [PR] KAFKA-19042: [10/N] Move PlaintextConsumerAssignTest to clients-integration-tests module [kafka]

2025-06-05 Thread via GitHub
chia7712 merged PR #19773: URL: https://github.com/apache/kafka/pull/19773 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

Re: [PR] MINOR: Safe update dependencies [kafka]

2025-06-05 Thread via GitHub
Mirai1129 commented on PR #19897: URL: https://github.com/apache/kafka/pull/19897#issuecomment-2945393365 Thanks for the suggestion @m1a2st . I've updated the dependencies with safe version bumps in the latest commit. -- This is an automated message from the Apache Git Service. To respond

Re: [PR] KAFKA-19376: Throw an error message if any unsupported feature is used with KIP-1071 [kafka]

2025-06-05 Thread via GitHub
chia7712 commented on code in PR #19908: URL: https://github.com/apache/kafka/pull/19908#discussion_r2129236431 ## streams/src/main/java/org/apache/kafka/streams/StreamsConfig.java: ## @@ -1525,10 +1525,27 @@ protected StreamsConfig(final Map props, } verifyTo

Re: [PR] KAFKA-19324: org.apache.kafka.common.test.TestUtils should be package-private [kafka]

2025-06-05 Thread via GitHub
chia7712 commented on PR #19884: URL: https://github.com/apache/kafka/pull/19884#issuecomment-2945263770 @YutaLin please fix the conflicts and update the title -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

Re: [PR] MINOR: Follow up KAFKA-19080 MetadataLogConfig [kafka]

2025-06-05 Thread via GitHub
chia7712 commented on code in PR #19842: URL: https://github.com/apache/kafka/pull/19842#discussion_r2129340580 ## core/src/main/scala/kafka/raft/KafkaMetadataLog.scala: ## @@ -637,6 +637,12 @@ object KafkaMetadataLog extends Logging { nodeId ) +// Print a warn

Re: [PR] KAFKA-19370: Create JMH benchmark for share group assignor [kafka]

2025-06-05 Thread via GitHub
apoorvmittal10 commented on code in PR #19907: URL: https://github.com/apache/kafka/pull/19907#discussion_r2129549852 ## jmh-benchmarks/src/main/java/org/apache/kafka/jmh/assignor/ShareGroupAssignorBenchmark.java: ## @@ -0,0 +1,221 @@ +/* + * Licensed to the Apache Software Foun

Re: [PR] KAFKA-19244: Add support for kafka-streams-groups.sh options (delete internal topics) [3/N] [kafka]

2025-06-05 Thread via GitHub
lucasbru commented on code in PR #19893: URL: https://github.com/apache/kafka/pull/19893#discussion_r2128204458 ## tools/src/test/java/org/apache/kafka/tools/streams/DeleteStreamsInternalTopicsTest.java: ## @@ -0,0 +1,392 @@ +/* + * Licensed to the Apache Software Foundation (AS

Re: [PR] KAFKA-19244: Add support for kafka-streams-groups.sh options (delete offsets) [4/N] [kafka]

2025-06-05 Thread via GitHub
Copilot commented on code in PR #19895: URL: https://github.com/apache/kafka/pull/19895#discussion_r2128310086 ## tools/src/main/java/org/apache/kafka/tools/streams/StreamsGroupCommand.java: ## @@ -77,6 +89,8 @@ public static void run(StreamsGroupCommandOptions opts) {

Re: [PR] KAFKA-16505: Add source raw key and value [kafka]

2025-06-05 Thread via GitHub
loicgreffier commented on PR #18739: URL: https://github.com/apache/kafka/pull/18739#issuecomment-2943224576 @cadonna Done. I've updated the description. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] KAFKA-16505: Add source raw key and value [kafka]

2025-06-05 Thread via GitHub
cadonna merged PR #18739: URL: https://github.com/apache/kafka/pull/18739 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.

Re: [PR] KAFKA-18961: Time-based refresh for server-side RE2J regex [kafka]

2025-06-05 Thread via GitHub
dajac commented on PR #19904: URL: https://github.com/apache/kafka/pull/19904#issuecomment-2943063987 @dongnuo123 Thanks for the patch. I have a general comment on the approach. Have you considered adding a new time based condition to [maybeUpdateRegularExpressions](https://github.com/apach

[jira] [Updated] (KAFKA-19378) Update developer-guide/config-streams.html for KIP-1071

2025-06-05 Thread Lucas Brutschy (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19378?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lucas Brutschy updated KAFKA-19378: --- Summary: Update developer-guide/config-streams.html for KIP-1071 (was: Add group protocol c

Re: [PR] MINOR: Refactor brokerContactTimesMs and brokerRegistrationStates to use Long and Integer [kafka]

2025-06-05 Thread via GitHub
chia7712 commented on code in PR #19888: URL: https://github.com/apache/kafka/pull/19888#discussion_r2129117111 ## metadata/src/main/java/org/apache/kafka/controller/metrics/QuorumControllerMetrics.java: ## @@ -267,19 +267,15 @@ public long newActiveControllers() { }

[jira] [Created] (KAFKA-19377) Update /streams/developer-guide/security.html to describe required ACLs for streams groups

2025-06-05 Thread Lucas Brutschy (Jira)
Lucas Brutschy created KAFKA-19377: -- Summary: Update /streams/developer-guide/security.html to describe required ACLs for streams groups Key: KAFKA-19377 URL: https://issues.apache.org/jira/browse/KAFKA-19377

[jira] [Created] (KAFKA-19378) Add group protocol config to developer-guide/config-streams.html

2025-06-05 Thread Lucas Brutschy (Jira)
Lucas Brutschy created KAFKA-19378: -- Summary: Add group protocol config to developer-guide/config-streams.html Key: KAFKA-19378 URL: https://issues.apache.org/jira/browse/KAFKA-19378 Project: Kafka

[jira] [Updated] (KAFKA-19378) Update developer-guide/config-streams.html for KIP-1071

2025-06-05 Thread Lucas Brutschy (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19378?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lucas Brutschy updated KAFKA-19378: --- Description: * Add group.protocol * State that num.standby will be ignored * Possibly add

Re: [PR] MINOR: Cleanup Core Module- Scala Modules (3/n) [kafka]

2025-06-05 Thread via GitHub
sjhajharia commented on PR #19804: URL: https://github.com/apache/kafka/pull/19804#issuecomment-2944071940 Gentle reminder @frankvicky -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

Re: [PR] MINOR: Cleanup Connect Module (1/n) [kafka]

2025-06-05 Thread via GitHub
sjhajharia commented on PR #19869: URL: https://github.com/apache/kafka/pull/19869#issuecomment-2944074797 Thanks for the review @m1a2st cc: @frankvicky -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

Re: [PR] KAFKA-13881: Add Clients package description javadocs [kafka]

2025-06-05 Thread via GitHub
chia7712 commented on code in PR #12895: URL: https://github.com/apache/kafka/pull/12895#discussion_r2128812664 ## clients/src/main/java/org/apache/kafka/common/replica/package-info.java: ## @@ -0,0 +1,21 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or m