github-actions[bot] commented on PR #19799:
URL: https://github.com/apache/kafka/pull/19799#issuecomment-2924119324
A label of 'needs-attention' was automatically added to this PR in order to
raise the
attention of the committers. Once this issue has been triaged, the `triage`
label
s
johnny94 commented on PR #19793:
URL: https://github.com/apache/kafka/pull/19793#issuecomment-2924392895
Fixed. Thanks. @chia7712
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific com
github-actions[bot] commented on PR #19034:
URL: https://github.com/apache/kafka/pull/19034#issuecomment-2924139646
This PR is being marked as stale since it has not had any activity in 90
days. If you
would like to keep this PR alive, please leave a comment asking for a
review. If the P
DL1231 commented on PR #19866:
URL: https://github.com/apache/kafka/pull/19866#issuecomment-2923983711
Thanks for the PR, LGTM.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific commen
[
https://issues.apache.org/jira/browse/KAFKA-19351?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True updated KAFKA-19351:
--
Component/s: clients
consumer
> AsyncConsumer#commitAsync should copy the input offse
github-actions[bot] commented on PR #19015:
URL: https://github.com/apache/kafka/pull/19015#issuecomment-2924139628
This PR is being marked as stale since it has not had any activity in 90
days. If you
would like to keep this PR alive, please leave a comment asking for a
review. If the P
DL1231 commented on code in PR #19577:
URL: https://github.com/apache/kafka/pull/19577#discussion_r2117008511
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/CommitRequestManager.java:
##
@@ -698,15 +699,22 @@ class OffsetCommitRequestState extends
Retriabl
jingjia88 opened a new pull request, #19868:
URL: https://github.com/apache/kafka/pull/19868
This refactor improves the implementation of `awaitNonEmptyRecords` by:
- Removing the unreachable `throw new IllegalStateException` statement,
which was dead code due to `pollRecordsUntilTrue
sjhajharia commented on PR #19791:
URL: https://github.com/apache/kafka/pull/19791#issuecomment-2924430980
Hey @frankvicky
If you can pls have a look at this PR too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
chirag-wadhwa5 commented on code in PR #19836:
URL: https://github.com/apache/kafka/pull/19836#discussion_r2115716810
##
tests/kafkatest/benchmarks/core/benchmark_test.py:
##
@@ -273,6 +342,62 @@ def test_consumer_throughput(self,
compression_type="none", security_protocol="P
sjhajharia commented on code in PR #19805:
URL: https://github.com/apache/kafka/pull/19805#discussion_r2114385406
##
core/src/test/scala/unit/kafka/security/authorizer/AuthorizerTest.scala:
##
@@ -567,7 +567,7 @@ class AuthorizerTest extends QuorumTestHarness with
BaseAuthorize
AndrewJSchofield merged PR #19860:
URL: https://github.com/apache/kafka/pull/19860
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafk
pjl1070048431 opened a new pull request, #19858:
URL: https://github.com/apache/kafka/pull/19858
**Motivation**
Kafka clusters typically require rebalancing of topic replicas after
horizontal scaling to evenly distribute the load across new and existing
brokers. The current rebalancing a
apoorvmittal10 opened a new pull request, #19859:
URL: https://github.com/apache/kafka/pull/19859
PR streamlines the logs when delete share group or offset is triggered. Also
fixes the response when group is not found while deleting share group.
--
This is an automated message from the Ap
AndrewJSchofield commented on code in PR #19836:
URL: https://github.com/apache/kafka/pull/19836#discussion_r2115359871
##
tests/kafkatest/benchmarks/core/benchmark_test.py:
##
@@ -273,6 +342,62 @@ def test_consumer_throughput(self,
compression_type="none", security_protocol="P
AndrewJSchofield opened a new pull request, #19863:
URL: https://github.com/apache/kafka/pull/19863
This is the initial documentation for KIP-932 preview in AK 4.1. The aim is
to get very minimal docs in before the cutoff. Longer term, more comprehensive
documentation will be provided for A
smjn opened a new pull request, #19861:
URL: https://github.com/apache/kafka/pull/19861
- Currently, read and write share state requests were allowed on
uninitialized share partitions (share partitions on which initializeState has
NOT been called). This should not be allowed.
- This PR a
m1a2st commented on code in PR #19862:
URL: https://github.com/apache/kafka/pull/19862#discussion_r2116055162
##
core/src/main/java/kafka/server/share/DelayedShareFetch.java:
##
@@ -379,7 +380,12 @@ public boolean tryComplete() {
partitionsAcquired.clear();
lianetm commented on code in PR #19577:
URL: https://github.com/apache/kafka/pull/19577#discussion_r2116058907
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/CommitRequestManager.java:
##
@@ -698,15 +699,22 @@ class OffsetCommitRequestState extends
Retriab
jsancio commented on code in PR #19800:
URL: https://github.com/apache/kafka/pull/19800#discussion_r2116124510
##
clients/src/main/resources/common/message/FetchResponse.json:
##
@@ -48,7 +48,9 @@
// Version 16 adds the 'NodeEndpoints' field (KIP-951).
//
// Version 17
jsancio commented on code in PR #19800:
URL: https://github.com/apache/kafka/pull/19800#discussion_r2116128631
##
raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java:
##
@@ -386,6 +385,11 @@ private void onUpdateLeaderHighWatermark(
// records still held i
jsancio commented on code in PR #19800:
URL: https://github.com/apache/kafka/pull/19800#discussion_r2116128222
##
server-common/src/main/java/org/apache/kafka/server/common/MetadataVersion.java:
##
@@ -264,13 +267,15 @@ public short partitionRecordVersion() {
}
publi
jsancio commented on code in PR #19668:
URL: https://github.com/apache/kafka/pull/19668#discussion_r2114290405
##
raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java:
##
@@ -3301,20 +3313,23 @@ private long maybeSendFetchToBestNode(FollowerState
state, long currentTim
[
https://issues.apache.org/jira/browse/KAFKA-19251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17955150#comment-17955150
]
Shivsundar R commented on KAFKA-19251:
--
After this PR went in to AK - [https://gith
[
https://issues.apache.org/jira/browse/KAFKA-19251?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Shivsundar R updated KAFKA-19251:
-
Description:
All the flaky runs had this common error log.
{code:java}
ERROR [ShareCoordinator i
[
https://issues.apache.org/jira/browse/KAFKA-19351?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Lan Ding resolved KAFKA-19351.
--
Resolution: Fixed
> AsyncConsumer#commitAsync should copy the input offsets
>
AndrewJSchofield merged PR #19855:
URL: https://github.com/apache/kafka/pull/19855
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafk
[
https://issues.apache.org/jira/browse/KAFKA-17809?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Apoorv Mittal resolved KAFKA-17809.
---
Fix Version/s: 4.1.0
Resolution: Fixed
The issue has been fixed as part of other test
johnny94 opened a new pull request, #19857:
URL: https://github.com/apache/kafka/pull/19857
…FatalFaultHandler
`CreateTopicPolicy#validate` may throw unexpected exception other than
`PolicyViolationException`. We should handle this case as well.
--
This is an automated message fro
pjl1070048431 closed pull request #19297: KAFKA-19048: Minimal movement replica
balancing algorithm for reassignment
URL: https://github.com/apache/kafka/pull/19297
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
[
https://issues.apache.org/jira/browse/KAFKA-19251?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Shivsundar R resolved KAFKA-19251.
--
Fix Version/s: 4.1.0
Resolution: Fixed
> Resolve the flaky test
> ShareConsumerTest.te
apoorvmittal10 merged PR #19846:
URL: https://github.com/apache/kafka/pull/19846
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.
sjhajharia opened a new pull request, #19860:
URL: https://github.com/apache/kafka/pull/19860
The commit 57ae6d6706ef3e68953e19c7960ceb76adc9 had mistakenly removed
the `@Test` tag from a test. Adding it back.
--
This is an automated message from the Apache Git Service.
To respond to
sjhajharia commented on code in PR #19633:
URL: https://github.com/apache/kafka/pull/19633#discussion_r2115597886
##
core/src/test/scala/integration/kafka/api/PlaintextAdminIntegrationTest.scala:
##
@@ -2643,9 +2642,7 @@ class PlaintextAdminIntegrationTest extends
BaseAdminInte
ShivsundarR commented on PR #19789:
URL: https://github.com/apache/kafka/pull/19789#issuecomment-2922863013
Closing this PR as we are observing stable builds in AK for the past couple
of days after https://github.com/apache/kafka/pull/19824 was merged.
--
This is an automated message fro
kirktrue commented on code in PR #17022:
URL: https://github.com/apache/kafka/pull/17022#discussion_r2116240713
##
clients/src/main/java/org/apache/kafka/clients/producer/internals/TransactionManager.java:
##
@@ -779,14 +779,25 @@ public synchronized void
maybeTransitionToError
ShivsundarR closed pull request #19789: KAFKA-19317 : Refactor
ShareConsumerTest::waitedPoll to work with multiple records.
URL: https://github.com/apache/kafka/pull/19789
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use t
kevin-wu24 commented on code in PR #19668:
URL: https://github.com/apache/kafka/pull/19668#discussion_r2116237129
##
raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java:
##
@@ -3301,20 +3313,23 @@ private long maybeSendFetchToBestNode(FollowerState
state, long current
jolshan commented on code in PR #17022:
URL: https://github.com/apache/kafka/pull/17022#discussion_r2116253121
##
clients/src/main/java/org/apache/kafka/clients/producer/internals/TransactionManager.java:
##
@@ -779,14 +779,25 @@ public synchronized void
maybeTransitionToErrorS
jsancio commented on code in PR #19668:
URL: https://github.com/apache/kafka/pull/19668#discussion_r2116144053
##
raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java:
##
@@ -3301,20 +3313,23 @@ private long maybeSendFetchToBestNode(FollowerState
state, long currentTim
jsancio commented on code in PR #19668:
URL: https://github.com/apache/kafka/pull/19668#discussion_r2114296083
##
raft/src/main/java/org/apache/kafka/raft/RequestManager.java:
##
@@ -17,23 +17,26 @@
package org.apache.kafka.raft;
import org.apache.kafka.common.Node;
+import
Justin Chen created KAFKA-19354:
---
Summary: KRaft observer unable to recover after re-bootstrapping
to follower
Key: KAFKA-19354
URL: https://issues.apache.org/jira/browse/KAFKA-19354
Project: Kafka
chia7712 commented on code in PR #19776:
URL: https://github.com/apache/kafka/pull/19776#discussion_r2116362068
##
core/src/test/scala/integration/kafka/coordinator/transaction/ProducerIntegrationTest.scala:
##
@@ -205,11 +205,12 @@ class ProducerIntegrationTest {
.setP
jsancio commented on code in PR #19668:
URL: https://github.com/apache/kafka/pull/19668#discussion_r2116216631
##
raft/src/test/java/org/apache/kafka/raft/RequestManagerTest.java:
##
@@ -256,25 +398,25 @@ public void testAnyInflightRequestWithAnyRequest() {
random
jsancio commented on code in PR #19668:
URL: https://github.com/apache/kafka/pull/19668#discussion_r2116144053
##
raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java:
##
@@ -3301,20 +3313,23 @@ private long maybeSendFetchToBestNode(FollowerState
state, long currentTim
jsancio commented on code in PR #19668:
URL: https://github.com/apache/kafka/pull/19668#discussion_r2116147585
##
raft/src/main/java/org/apache/kafka/raft/RequestManager.java:
##
@@ -62,30 +70,35 @@ public RequestManager(
}
/**
- * Returns true if there are any c
mingyen066 opened a new pull request, #19864:
URL: https://github.com/apache/kafka/pull/19864
#15613 Ensuring all callbacks are trigger before completion of `commitAsync`
for `AsyncKafkaConsumer`. However, the changes that #15693 made to
`ClassicKafkaConsumer` were not merged. I assume thi
jolshan commented on code in PR #17022:
URL: https://github.com/apache/kafka/pull/17022#discussion_r2116253746
##
clients/src/main/java/org/apache/kafka/clients/producer/internals/TransactionManager.java:
##
@@ -779,14 +779,25 @@ public synchronized void
maybeTransitionToErrorS
kirktrue opened a new pull request, #19865:
URL: https://github.com/apache/kafka/pull/19865
Three changes to the `AsyncKafkaConsumer`’s internals to reduce the CPU
usage:
1. Switching from using `Selector.wakeup()` to `Queue.poll()` as the
mechanism to alert the network thread that t
chia7712 commented on PR #19793:
URL: https://github.com/apache/kafka/pull/19793#issuecomment-2923094649
@johnny94 please fix the conflicts
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spe
chia7712 merged PR #19651:
URL: https://github.com/apache/kafka/pull/19651
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
chia7712 merged PR #19678:
URL: https://github.com/apache/kafka/pull/19678
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
chia7712 commented on code in PR #19807:
URL: https://github.com/apache/kafka/pull/19807#discussion_r2116434797
##
server/src/main/java/org/apache/kafka/server/ClientQuotaManager.java:
##
@@ -0,0 +1,942 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or mor
chia7712 merged PR #19685:
URL: https://github.com/apache/kafka/pull/19685
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
chia7712 commented on PR #19773:
URL: https://github.com/apache/kafka/pull/19773#issuecomment-2923148907
@TaiJuWu please fix the conflicts
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spec
chia7712 commented on code in PR #19864:
URL: https://github.com/apache/kafka/pull/19864#discussion_r2116440158
##
clients/src/main/java/org/apache/kafka/clients/consumer/KafkaConsumer.java:
##
@@ -1001,7 +1005,9 @@ public void commitSync(Duration timeout) {
* (in which ca
chia7712 commented on PR #19728:
URL: https://github.com/apache/kafka/pull/19728#issuecomment-2923150177
@LoganZhuZzz any updates?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific com
chia7712 commented on PR #19860:
URL: https://github.com/apache/kafka/pull/19860#issuecomment-2921967786
@sjhajharia thanks for this fix
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specif
[
https://issues.apache.org/jira/browse/KAFKA-19319?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
José Armando García Sancio reassigned KAFKA-19319:
--
Assignee: José Armando García Sancio
> Don't reset election t
Andrew Schofield created KAFKA-19353:
Summary: Preview documentation
Key: KAFKA-19353
URL: https://issues.apache.org/jira/browse/KAFKA-19353
Project: Kafka
Issue Type: Sub-task
m1a2st opened a new pull request, #19862:
URL: https://github.com/apache/kafka/pull/19862
`DelayedOperation.forceComplete()` always returns true when called inside
`tryComplete()`. Only the expiration logic checks its return value.
We can simplify this by making `forceComplete()` return v
apalan60 opened a new pull request, #19866:
URL: https://github.com/apache/kafka/pull/19866
[JIRA: KAFKA-19355](https://issues.apache.org/jira/browse/KAFKA-19355)
Following the removal of the ZK-to-KRaft migration code in commit 85bfdf4,
controller-to-broker communication is now hand
[
https://issues.apache.org/jira/browse/KAFKA-19352?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai reassigned KAFKA-19352:
--
Assignee: Chia-Ping Tsai
> PlaintextConsumerCommitTest > testCommitAsyncCompletedBefo
[
https://issues.apache.org/jira/browse/KAFKA-19355?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
HongYi Chen reassigned KAFKA-19355:
---
Assignee: HongYi Chen (was: Chia-Ping Tsai)
> Remove interBrokerListenerName from ClusterC
lianetm commented on code in PR #19754:
URL: https://github.com/apache/kafka/pull/19754#discussion_r2116573237
##
clients/src/main/java/org/apache/kafka/common/config/SaslConfigs.java:
##
@@ -129,6 +130,186 @@ public class SaslConfigs {
+ " authentication provider."
Chia-Ping Tsai created KAFKA-19355:
--
Summary: Remove interBrokerListenerName from ClusterControlManager
Key: KAFKA-19355
URL: https://issues.apache.org/jira/browse/KAFKA-19355
Project: Kafka
Lianet Magrans created KAFKA-19356:
--
Summary: AsyncConsumer should ensure consistency of assigned
partitions and subscription
Key: KAFKA-19356
URL: https://issues.apache.org/jira/browse/KAFKA-19356
P
[
https://issues.apache.org/jira/browse/KAFKA-19356?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Lianet Magrans updated KAFKA-19356:
---
Labels: consumer-threading-refactor kip-848-client-support (was: )
> AsyncConsumer should e
[
https://issues.apache.org/jira/browse/KAFKA-19356?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Lianet Magrans updated KAFKA-19356:
---
Description:
With the new AsyncConsumer, the client reconciles partitions assigned by the
c
AndrewJSchofield commented on PR #19831:
URL: https://github.com/apache/kafka/pull/19831#issuecomment-2921599058
> How about adding this change to docs (`upgrade.html`)? Users can update
the version of Share using the feature tool.
That is a good idea. I will do this shortly. I am als
[
https://issues.apache.org/jira/browse/KAFKA-19346?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Apoorv Mittal resolved KAFKA-19346.
---
Fix Version/s: 4.1.0
Resolution: Fixed
> Move LogReadResult to server module
> --
chia7712 commented on code in PR #19796:
URL: https://github.com/apache/kafka/pull/19796#discussion_r2115934867
##
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/modern/share/ShareGroupBuilder.java:
##
@@ -72,29 +70,8 @@ public List build(TopicsImage
topicsI
[
https://issues.apache.org/jira/browse/KAFKA-15449?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Justine Olshan updated KAFKA-15449:
---
Fix Version/s: 3.7.0
> Verify transactional offset commits (KIP-890 part 1)
> --
UladzislauBlok commented on PR #19517:
URL: https://github.com/apache/kafka/pull/19517#issuecomment-2923586553
@mjsax Hey. Sorry for bothering you. Could you please review it, if you have
free capacity?
--
This is an automated message from the Apache Git Service.
To respond to the message
[
https://issues.apache.org/jira/browse/KAFKA-19354?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alyssa Huang reassigned KAFKA-19354:
Assignee: Alyssa Huang
> KRaft observer unable to recover after re-bootstrapping to follo
matt-welch commented on code in PR #17340:
URL: https://github.com/apache/kafka/pull/17340#discussion_r2116773185
##
tools/src/main/java/org/apache/kafka/tools/ProducerPerformance.java:
##
@@ -471,6 +513,10 @@ public void onCompletion(RecordMetadata metadata,
Exception exceptio
matt-welch commented on code in PR #17340:
URL: https://github.com/apache/kafka/pull/17340#discussion_r2116785063
##
tools/src/main/java/org/apache/kafka/tools/ProducerPerformance.java:
##
@@ -94,7 +98,11 @@ void start(String[] args) throws IOException {
record
matt-welch commented on code in PR #17340:
URL: https://github.com/apache/kafka/pull/17340#discussion_r2116789860
##
tools/src/main/java/org/apache/kafka/tools/ProducerPerformance.java:
##
@@ -94,7 +98,11 @@ void start(String[] args) throws IOException {
record
matt-welch commented on PR #17340:
URL: https://github.com/apache/kafka/pull/17340#issuecomment-2923630408
Hi @chia7712. I've updated my latest commit with your suggestions and I
think it's a bit more readable now.
Let me know if anyone has any more feedback.
--
This is an automated
[
https://issues.apache.org/jira/browse/KAFKA-19356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17955340#comment-17955340
]
Kirk True commented on KAFKA-19356:
---
[~lianetm]—The link to {{FetchCollector.fetchReco
yunchipang opened a new pull request, #19867:
URL: https://github.com/apache/kafka/pull/19867
parent: https://github.com/apache/kafka/pull/19687/files#r2094574178
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
[
https://issues.apache.org/jira/browse/KAFKA-19356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17955340#comment-17955340
]
Kirk True edited comment on KAFKA-19356 at 5/30/25 10:40 PM:
-
82 matches
Mail list logo
