[jira] [Assigned] (KAFKA-19331) No error handling for leader not appeared in applyLocalFollowersDelta

2025-05-26 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19331?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Luke Chen reassigned KAFKA-19331: - Assignee: Ming-Yen Chung > No error handling for leader not appeared in applyLocalFollowersDelt

Re: [PR] KAFKA-18687: Setting the subscriptionMetadata during conversion to consumer group [kafka]

2025-05-26 Thread via GitHub
dajac commented on code in PR #19790: URL: https://github.com/apache/kafka/pull/19790#discussion_r2106896835 ## core/src/test/scala/integration/kafka/api/PlaintextAdminIntegrationTest.scala: ## @@ -2485,8 +2485,6 @@ class PlaintextAdminIntegrationTest extends BaseAdminIntegrati

[jira] [Created] (KAFKA-19331) No error handling for leader unregistered in applyLocalFollowersDelta

2025-05-26 Thread Luke Chen (Jira)
Luke Chen created KAFKA-19331: - Summary: No error handling for leader unregistered in applyLocalFollowersDelta Key: KAFKA-19331 URL: https://issues.apache.org/jira/browse/KAFKA-19331 Project: Kafka

[jira] [Updated] (KAFKA-19331) No error handling for leader unregistered in applyLocalFollowersDelta

2025-05-26 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19331?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Luke Chen updated KAFKA-19331: -- Labels: newbie (was: ) > No error handling for leader unregistered in applyLocalFollowersDelta > ---

[jira] [Commented] (KAFKA-19331) No error handling for leader not appeared in applyLocalFollowersDelta

2025-05-26 Thread Ming-Yen Chung (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17954040#comment-17954040 ] Ming-Yen Chung commented on KAFKA-19331: Hi [~showuon] , could you assign this t

[PR] KAFKA-19330: Change MockSerializer/Deserializer to use String serializer instead of byte[] [kafka]

2025-05-26 Thread via GitHub
mingyen066 opened a new pull request, #19812: URL: https://github.com/apache/kafka/pull/19812 While rewriting `EndToEndClusterIdTest` in Java (#19741 ), I found that the test uses `MockInterceptor` and `MockSerializer `together. However, `MockSerializer` was using a `byte[]` serializer, whi

Re: [PR] KAFKA-17747: [5/N] Replace subscription metadata with metadata hash in stream group (wip) [kafka]

2025-05-26 Thread via GitHub
lucasbru commented on code in PR #19802: URL: https://github.com/apache/kafka/pull/19802#discussion_r2106715246 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/streams/StreamsGroup.java: ## @@ -582,54 +592,44 @@ public Set currentWarmupTaskProcessIds(

Re: [PR] KAFKA-17747: [4/N] Replace subscription metadata with metadata hash in consumer group [kafka]

2025-05-26 Thread via GitHub
dajac commented on code in PR #19761: URL: https://github.com/apache/kafka/pull/19761#discussion_r2106927220 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -550,6 +556,7 @@ private GroupMetadataManager( this.shareG

Re: [PR] KAFKA-18904: kafka-configs.sh return resource doesn't exist message [3/N] [kafka]

2025-05-26 Thread via GitHub
DL1231 commented on code in PR #19808: URL: https://github.com/apache/kafka/pull/19808#discussion_r2106900047 ## clients/src/test/java/org/apache/kafka/clients/admin/AdminClientTestUtils.java: ## @@ -163,6 +164,15 @@ public static ListConsumerGroupOffsetsResult listConsumerGrou

Re: [PR] KAFKA-19268 Missing mocks for SharePartitionManagerTest tests [kafka]

2025-05-26 Thread via GitHub
adixitconfluent commented on PR #19786: URL: https://github.com/apache/kafka/pull/19786#issuecomment-2909105133 @AndrewJSchofield can you please review this PR as well? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use t

[jira] [Comment Edited] (KAFKA-19259) Async consumer fetch intermittent delays on console consumer

2025-05-26 Thread Arpit Goyal (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17953933#comment-17953933 ] Arpit Goyal edited comment on KAFKA-19259 at 5/26/25 8:20 AM:

[jira] [Commented] (KAFKA-19331) No error handling for leader not appeared in applyLocalFollowersDelta

2025-05-26 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17954042#comment-17954042 ] Luke Chen commented on KAFKA-19331: --- Assigned to you. Thanks [~mingyen066] ! > No err

Re: [PR] KAFKA-17747: [6/N] Replace subscription metadata with metadata hash in share group [kafka]

2025-05-26 Thread via GitHub
dajac commented on PR #19796: URL: https://github.com/apache/kafka/pull/19796#issuecomment-2909150320 This one should basically be a copy of https://github.com/apache/kafka/pull/19761. Let's merge that one first and then we can review this one. -- This is an automated message from the Ap

Re: [PR] KAFKA-19042: [11/N] move ConsumerWithLegacyMessageFormatIntegrationTest to clients-integration-tests module [kafka]

2025-05-26 Thread via GitHub
m1a2st commented on code in PR #19810: URL: https://github.com/apache/kafka/pull/19810#discussion_r2107996769 ## clients/clients-integration-tests/src/test/java/org/apache/kafka/clients/consumer/ConsumerWithLegacyMessageFormatIntegrationTest.java: ## @@ -0,0 +1,226 @@ +/* + * Li

[jira] [Commented] (KAFKA-19336) Upgrade jackson libs since v2.16 is not maintained anymore

2025-05-26 Thread Szu-Yung Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17954207#comment-17954207 ] Szu-Yung Wang commented on KAFKA-19336: --- Hi, May I take this? > Upgrade jackson l

[PR] KAFKA-19310: (MINOR) Missing mocks for DelayedShareFetchTest tests related to Memory Records slicing [kafka]

2025-05-26 Thread via GitHub
adixitconfluent opened a new pull request, #19823: URL: https://github.com/apache/kafka/pull/19823 ### About Added test memory records to avoid the silent exception thrown during slicing. ### Testing Ran the tests of `DelayedShareFetchTest` to make sure that there is no silent

Re: [PR] KAFKA-19335: Membership managers send negative epoch in JOINING [kafka]

2025-05-26 Thread via GitHub
ShivsundarR commented on code in PR #19818: URL: https://github.com/apache/kafka/pull/19818#discussion_r2108331701 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/ShareMembershipManagerTest.java: ## @@ -561,10 +568,42 @@ public void testIgnoreHeartbeatRespo

Re: [PR] KAFKA-18687: Setting the subscriptionMetadata during conversion to consumer group [kafka]

2025-05-26 Thread via GitHub
dajac commented on code in PR #19790: URL: https://github.com/apache/kafka/pull/19790#discussion_r2108336679 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/modern/consumer/ConsumerGroupTest.java: ## @@ -1576,6 +1581,7 @@ public void testFromClassicGroup()

Re: [PR] KAFKA-19335: Membership managers send negative epoch in JOINING [kafka]

2025-05-26 Thread via GitHub
ShivsundarR commented on code in PR #19818: URL: https://github.com/apache/kafka/pull/19818#discussion_r2108331701 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/ShareMembershipManagerTest.java: ## @@ -561,10 +568,42 @@ public void testIgnoreHeartbeatRespo

Re: [PR] KAFKA-19334 MetadataShell execution unintentionally deletes lock file [kafka]

2025-05-26 Thread via GitHub
frankvicky commented on PR #19817: URL: https://github.com/apache/kafka/pull/19817#issuecomment-2911237948 @cmccabe: Could you please take a look when you have a free moment? Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] KAFKA-19042: [10/N] Move PlaintextConsumerAssignTest to clients-integration-tests module [kafka]

2025-05-26 Thread via GitHub
brandboat commented on code in PR #19773: URL: https://github.com/apache/kafka/pull/19773#discussion_r2108051296 ## clients/clients-integration-tests/src/test/java/org/apache/kafka/clients/consumer/PlaintextConsumerAssignTest.java: ## @@ -0,0 +1,314 @@ +/* + * Licensed to the Ap

Re: [PR] KAFKA-19042: [10/N] Move PlaintextConsumerAssignTest to clients-integration-tests module [kafka]

2025-05-26 Thread via GitHub
TaiJuWu commented on code in PR #19773: URL: https://github.com/apache/kafka/pull/19773#discussion_r2108058182 ## clients/clients-integration-tests/src/test/java/org/apache/kafka/clients/consumer/PlaintextConsumerAssignTest.java: ## @@ -0,0 +1,314 @@ +/* + * Licensed to the Apac

Re: [PR] KAFKA-19042: [10/N] Move PlaintextConsumerAssignTest to clients-integration-tests module [kafka]

2025-05-26 Thread via GitHub
TaiJuWu commented on PR #19773: URL: https://github.com/apache/kafka/pull/19773#issuecomment-2910955102 Hi @brandboat , thanks for your detailed review and point out my mistakes, all comments are addressed, PTAL. -- This is an automated message from the Apache Git Service. To respond to t

Re: [PR] KAFKA-7516: Attempt to dynamically load ManagementFactory [kafka]

2025-05-26 Thread via GitHub
github-actions[bot] commented on PR #19764: URL: https://github.com/apache/kafka/pull/19764#issuecomment-2910989098 A label of 'needs-attention' was automatically added to this PR in order to raise the attention of the committers. Once this issue has been triaged, the `triage` label s

Re: [PR] MINOR: Improve the `KAFKA_HEAP_OPTS` definition while run `kafka-server-start.bat` Batch [kafka]

2025-05-26 Thread via GitHub
github-actions[bot] commented on PR #19703: URL: https://github.com/apache/kafka/pull/19703#issuecomment-2910989162 A label of 'needs-attention' was automatically added to this PR in order to raise the attention of the committers. Once this issue has been triaged, the `triage` label s

Re: [PR] Kafka 18913/cleanup state updater on failure [kafka]

2025-05-26 Thread via GitHub
github-actions[bot] commented on PR #19750: URL: https://github.com/apache/kafka/pull/19750#issuecomment-2910989126 A label of 'needs-attention' was automatically added to this PR in order to raise the attention of the committers. Once this issue has been triaged, the `triage` label s

Re: [PR] KAFKA-17747: [4/N] Replace subscription metadata with metadata hash in consumer group [kafka]

2025-05-26 Thread via GitHub
FrankYang0529 commented on code in PR #19761: URL: https://github.com/apache/kafka/pull/19761#discussion_r2107945239 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/GroupMetadataManagerTest.java: ## @@ -20635,12 +21067,10 @@ barTopicName, new TopicMetadata(

Re: [PR] KAFKA-17747: [4/N] Replace subscription metadata with metadata hash in consumer group [kafka]

2025-05-26 Thread via GitHub
FrankYang0529 commented on code in PR #19761: URL: https://github.com/apache/kafka/pull/19761#discussion_r2107946290 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/modern/ModernGroup.java: ## @@ -398,6 +423,21 @@ public Map computeSubscriptionMetadata(

Re: [PR] KAFKA-17747: [4/N] Replace subscription metadata with metadata hash in consumer group [kafka]

2025-05-26 Thread via GitHub
FrankYang0529 commented on code in PR #19761: URL: https://github.com/apache/kafka/pull/19761#discussion_r2107946911 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/Utils.java: ## @@ -349,12 +349,19 @@ static void throwIfRegularExpressionIsInvalid( *

Re: [PR] KAFKA-18379: Enforce resigned cannot transition to any other state in same epoch [kafka]

2025-05-26 Thread via GitHub
github-actions[bot] commented on PR #19236: URL: https://github.com/apache/kafka/pull/19236#issuecomment-2910989346 A label of 'needs-attention' was automatically added to this PR in order to raise the attention of the committers. Once this issue has been triaged, the `triage` label s

[PR] WIP: 4.0 Markdown docs [kafka]

2025-05-26 Thread via GitHub
hvishwanath opened a new pull request, #19821: URL: https://github.com/apache/kafka/pull/19821 4.0 Markdown docs -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

Re: [PR] [WIP] KAFKA-18877: Add an mechanism to find cases where we accessed variables from the wrong thread. [kafka]

2025-05-26 Thread via GitHub
github-actions[bot] commented on PR #19231: URL: https://github.com/apache/kafka/pull/19231#issuecomment-2910989370 A label of 'needs-attention' was automatically added to this PR in order to raise the attention of the committers. Once this issue has been triaged, the `triage` label s

[PR] (wip )KAFKA-19042 consumer bounce test [kafka]

2025-05-26 Thread via GitHub
TaiJuWu opened a new pull request, #19822: URL: https://github.com/apache/kafka/pull/19822 Delete this text and replace it with a detailed description of your change. The PR title and body will become the squashed commit message. If you would like to tag individuals, add some comm

Re: [PR] KAFKA-1792: change behavior of --generate to produce assignment config with fair replica distribution and minimal number of reassignments [kafka]

2025-05-26 Thread via GitHub
github-actions[bot] commented on PR #18903: URL: https://github.com/apache/kafka/pull/18903#issuecomment-2911010127 This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please leave a comment asking for a review. If the P

Re: [PR] KAFKA-19144 Move DelayedProduce to server module [kafka]

2025-05-26 Thread via GitHub
frankvicky commented on code in PR #19793: URL: https://github.com/apache/kafka/pull/19793#discussion_r2108058643 ## core/src/test/scala/kafka/server/LocalLeaderEndPointTest.scala: ## @@ -271,9 +271,10 @@ class LocalLeaderEndPointTest extends Logging {

Re: [PR] [WIP] KAFKA-18562: standardize election/fetch timeout between Unattached and Followers [kafka]

2025-05-26 Thread via GitHub
github-actions[bot] commented on PR #18921: URL: https://github.com/apache/kafka/pull/18921#issuecomment-2911010160 This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please leave a comment asking for a review. If the P

Re: [PR] KAFKA-18157:Consider UnsupportedVersionException child class to represent the case of unsupported fields [kafka]

2025-05-26 Thread via GitHub
github-actions[bot] commented on PR #18072: URL: https://github.com/apache/kafka/pull/18072#issuecomment-2911010040 This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please leave a comment asking for a review. If the P

[jira] [Created] (KAFKA-19336) Upgrade jackson libs since v2.16 is not maintained anymore

2025-05-26 Thread Luke Chen (Jira)
Luke Chen created KAFKA-19336: - Summary: Upgrade jackson libs since v2.16 is not maintained anymore Key: KAFKA-19336 URL: https://issues.apache.org/jira/browse/KAFKA-19336 Project: Kafka Issue Ty

Re: [PR] KAFKA-19042: [9/N] Move GroupAuthorizerIntegrationTest to clients-integration-tests module [kafka]

2025-05-26 Thread via GitHub
nick-zh commented on PR #19685: URL: https://github.com/apache/kafka/pull/19685#issuecomment-2911205618 While I would love to help, I think you meant a different Nick @chia7712 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

Re: [PR] KAFKA-19315: Move ControllerMutationQuotaManager to server module [kafka]

2025-05-26 Thread via GitHub
m1a2st commented on code in PR #19807: URL: https://github.com/apache/kafka/pull/19807#discussion_r2107979149 ## server/src/main/java/org/apache/kafka/server/ClientQuotaManager.java: ## @@ -0,0 +1,938 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more

[PR] KAFKA-16717 [3/N]: Add AdminClient.alterShareGroupOffsets [kafka]

2025-05-26 Thread via GitHub
JimmyWang6 opened a new pull request, #19820: URL: https://github.com/apache/kafka/pull/19820 [KAFKA-16720](https://issues.apache.org/jira/browse/KAFKA-16720) aims to finish the AlterShareGroupOffsets for ShareGroupCommand part. -- This is an automated message from the Apache Git Servi

[jira] [Assigned] (KAFKA-19336) Upgrade jackson libs since v2.16 is not maintained anymore

2025-05-26 Thread Szu-Yung Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19336?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Szu-Yung Wang reassigned KAFKA-19336: - Assignee: Szu-Yung Wang > Upgrade jackson libs since v2.16 is not maintained anymore >

[jira] [Updated] (KAFKA-19334) MetadataShell bypasses file lock unexpectedly due to lock file deletion

2025-05-26 Thread TengYao Chi (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19334?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] TengYao Chi updated KAFKA-19334: Fix Version/s: 3.9.2 4.0.1 4.1.0 > MetadataShell bypasses fi

[jira] [Commented] (KAFKA-19334) MetadataShell bypasses file lock unexpectedly due to lock file deletion

2025-05-26 Thread Haruki Okada (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17954105#comment-17954105 ] Haruki Okada commented on KAFKA-19334: -- [~cmccabe] Submitted a patch for this. Coul

[jira] [Commented] (KAFKA-19333) Inconsistent behavior between `ConsumerMembershipManager` and `StreamsMembershipManager` on `onAllTasksLost` execution

2025-05-26 Thread Nick Guo (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17954108#comment-17954108 ] Nick Guo commented on KAFKA-19333: -- Hi [~lianetm] ! Thanks for taking time to explain t

Re: [PR] KAFKA-19056: Rewrite EndToEndClusterIdTest in Java and move it to the server module [kafka]

2025-05-26 Thread via GitHub
mingyen066 commented on code in PR #19741: URL: https://github.com/apache/kafka/pull/19741#discussion_r2107586894 ## server/src/test/java/org/apache/kafka/api/EndToEndClusterIdTest.java: ## @@ -0,0 +1,230 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or m

[jira] [Created] (KAFKA-19335) Streams group heartbeat sometimes fails with INVALID_REQUEST

2025-05-26 Thread Lucas Brutschy (Jira)
Lucas Brutschy created KAFKA-19335: -- Summary: Streams group heartbeat sometimes fails with INVALID_REQUEST Key: KAFKA-19335 URL: https://issues.apache.org/jira/browse/KAFKA-19335 Project: Kafka

[jira] [Assigned] (KAFKA-19335) Streams group heartbeat sometimes fails with INVALID_REQUEST

2025-05-26 Thread Lucas Brutschy (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19335?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lucas Brutschy reassigned KAFKA-19335: -- Assignee: Lucas Brutschy > Streams group heartbeat sometimes fails with INVALID_REQUE

[PR] KAFKA-19335: Membership Managers end negative epoch in JOINING [kafka]

2025-05-26 Thread via GitHub
lucasbru opened a new pull request, #19818: URL: https://github.com/apache/kafka/pull/19818 There is a sequence of interactions with the membership managers of KIP-848, KIP-932, KIP-1071 that can put the member ship manager into JOINING state, but where member epoch is set to -1. This can r

[jira] [Assigned] (KAFKA-19288) Ensure new consumer joining attempt not overwritten on delayed HB response to previous leave

2025-05-26 Thread Lucas Brutschy (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19288?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lucas Brutschy reassigned KAFKA-19288: -- Assignee: Lucas Brutschy (was: Lianet Magrans) > Ensure new consumer joining attempt

[jira] [Commented] (KAFKA-19288) Ensure new consumer joining attempt not overwritten on delayed HB response to previous leave

2025-05-26 Thread Lucas Brutschy (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17954114#comment-17954114 ] Lucas Brutschy commented on KAFKA-19288: https://github.com/apache/kafka/pull/19

Re: [PR] KAFKA-19330: Change MockSerializer/Deserializer to use String serializer instead of byte[] [kafka]

2025-05-26 Thread via GitHub
chia7712 commented on code in PR #19812: URL: https://github.com/apache/kafka/pull/19812#discussion_r2107630603 ## clients/src/test/java/org/apache/kafka/test/MockDeserializer.java: ## @@ -52,11 +53,14 @@ public void configure(Map configs, boolean isKey) { } @Overri

[jira] [Commented] (KAFKA-19288) Ensure new consumer joining attempt not overwritten on delayed HB response to previous leave

2025-05-26 Thread Lucas Brutschy (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17954116#comment-17954116 ] Lucas Brutschy commented on KAFKA-19288: The sequence is slightly different from

Re: [PR] KAFKA-19330: Change MockSerializer/Deserializer to use String serializer instead of byte[] [kafka]

2025-05-26 Thread via GitHub
mingyen066 commented on PR #19812: URL: https://github.com/apache/kafka/pull/19812#issuecomment-2910251765 @chia7712 Thanks for the review. I've addressed the comments. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

Re: [PR] KAFKA-19300: AsyncConsumer#unsubscribe always timeout due to GroupAuthorizationException [kafka]

2025-05-26 Thread via GitHub
chia7712 merged PR #19779: URL: https://github.com/apache/kafka/pull/19779 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

[jira] [Resolved] (KAFKA-19300) AsyncConsumer#unsubscribe always timeout due to GroupAuthorizationException

2025-05-26 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19300?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai resolved KAFKA-19300. Resolution: Fixed > AsyncConsumer#unsubscribe always timeout due to GroupAuthorizationExce

Re: [PR] KAFKA-19322: Remove the DelayedOperation constructor that accepts an external lock [kafka]

2025-05-26 Thread via GitHub
chia7712 merged PR #19798: URL: https://github.com/apache/kafka/pull/19798 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

[jira] [Resolved] (KAFKA-19322) Remove the DelayedOperation constructor that accepts an external lock

2025-05-26 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19322?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai resolved KAFKA-19322. Fix Version/s: 4.1.0 Resolution: Fixed > Remove the DelayedOperation constructor th

Re: [PR] KAFKA-19144 Move DelayedProduce to server module [kafka]

2025-05-26 Thread via GitHub
chia7712 commented on PR #19793: URL: https://github.com/apache/kafka/pull/19793#issuecomment-2910286667 @johnny94 please fix the conflicts -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spe

Re: [PR] KAFK1-19315: Move ControllerMutationQuotaManager to server module [kafka]

2025-05-26 Thread via GitHub
chia7712 commented on code in PR #19807: URL: https://github.com/apache/kafka/pull/19807#discussion_r2107643996 ## server/src/main/java/org/apache/kafka/server/PermissiveControllerMutationQuota.java: ## @@ -0,0 +1,53 @@ +/* + * Licensed to the Apache Software Foundation (ASF) un

Re: [PR] KAFKA-17747: [5/N] Replace subscription metadata with metadata hash in stream group (wip) [kafka]

2025-05-26 Thread via GitHub
FrankYang0529 commented on code in PR #19802: URL: https://github.com/apache/kafka/pull/19802#discussion_r2107522589 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/streams/StreamsGroup.java: ## @@ -582,54 +592,44 @@ public Set currentWarmupTaskProcessIds(

Re: [PR] KAFKA-19335: Membership managers send negative epoch in JOINING [kafka]

2025-05-26 Thread via GitHub
lianetm commented on PR #19818: URL: https://github.com/apache/kafka/pull/19818#issuecomment-2910378099 Hey @lucasbru, thanks for taking on this one. Agree with the gap on leave HB responses received in unexpected order. And the fix makes sense to me (only complete the leave if the HB respo

Re: [PR] KAFKA-17747: [5/N] Replace subscription metadata with metadata hash in stream group (wip) [kafka]

2025-05-26 Thread via GitHub
lucasbru commented on code in PR #19802: URL: https://github.com/apache/kafka/pull/19802#discussion_r2107633695 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/streams/StreamsGroup.java: ## @@ -582,54 +592,44 @@ public Set currentWarmupTaskProcessIds(

Re: [PR] KAFKA-19335: Membership managers send negative epoch in JOINING [kafka]

2025-05-26 Thread via GitHub
lucasbru commented on PR #19818: URL: https://github.com/apache/kafka/pull/19818#issuecomment-2910391860 > Thoughts? not sure if I'm missing something here Thanks for taking a look, @lianetm ! You are right, consumer groups and share groups should fail with `UNKNOWN_MEMBER`. In stream

Re: [PR] KAFKA-17747: [4/N] Replace subscription metadata with metadata hash in consumer group [kafka]

2025-05-26 Thread via GitHub
dajac commented on PR #19761: URL: https://github.com/apache/kafka/pull/19761#issuecomment-2909780629 I would like to merge https://github.com/apache/kafka/pull/19790 before merging this one because we need to cherry-pick it to 4.0. -- This is an automated message from the Apache Git Serv

Re: [PR] KAFKA-19282: Update quotaTypesEnabled on quota removal in ClientQuotaManager [kafka]

2025-05-26 Thread via GitHub
ahuang98 commented on code in PR #19742: URL: https://github.com/apache/kafka/pull/19742#discussion_r2107750048 ## core/src/main/scala/kafka/server/ClientQuotaManager.scala: ## @@ -453,40 +452,34 @@ class ClientQuotaManager(private val config: ClientQuotaManagerConfig, }

Re: [PR] KAFKA-19282: Update quotaTypesEnabled on quota removal in ClientQuotaManager [kafka]

2025-05-26 Thread via GitHub
ahuang98 commented on code in PR #19742: URL: https://github.com/apache/kafka/pull/19742#discussion_r2107754429 ## core/src/main/scala/kafka/server/ClientQuotaManager.scala: ## @@ -428,18 +427,19 @@ class ClientQuotaManager(private val config: ClientQuotaManagerConfig, try

Re: [PR] KAFKA-19042: [9/N] Move GroupAuthorizerIntegrationTest to clients-integration-tests module [kafka]

2025-05-26 Thread via GitHub
chia7712 commented on PR #19685: URL: https://github.com/apache/kafka/pull/19685#issuecomment-2910266692 @nick-zh please fix the conflicts -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

Re: [PR] KAFKA-19282: Update quotaTypesEnabled on quota removal in ClientQuotaManager [kafka]

2025-05-26 Thread via GitHub
MahsaSeifikar commented on code in PR #19742: URL: https://github.com/apache/kafka/pull/19742#discussion_r2107803984 ## core/src/main/scala/kafka/server/ClientQuotaManager.scala: ## @@ -428,18 +427,19 @@ class ClientQuotaManager(private val config: ClientQuotaManagerConfig,

Re: [PR] KAFKA-19154; Offset Fetch API should return INVALID_OFFSET if requested topic id does not match persisted one [kafka]

2025-05-26 Thread via GitHub
lianetm commented on code in PR #19744: URL: https://github.com/apache/kafka/pull/19744#discussion_r2107800303 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/OffsetMetadataManager.java: ## @@ -859,6 +859,7 @@ boolean hasCommittedOffset( * * @re

Re: [PR] KAFKA-18687: Setting the subscriptionMetadata during conversion to consumer group [kafka]

2025-05-26 Thread via GitHub
dongnuo123 commented on code in PR #19790: URL: https://github.com/apache/kafka/pull/19790#discussion_r210783 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/modern/consumer/ConsumerGroupTest.java: ## @@ -1576,6 +1581,7 @@ public void testFromClassicGro

Re: [PR] KAFKA-18687: Setting the subscriptionMetadata during conversion to consumer group [kafka]

2025-05-26 Thread via GitHub
dongnuo123 commented on code in PR #19790: URL: https://github.com/apache/kafka/pull/19790#discussion_r2107834673 ## core/src/test/scala/integration/kafka/api/PlaintextAdminIntegrationTest.scala: ## @@ -2485,8 +2485,6 @@ class PlaintextAdminIntegrationTest extends BaseAdminInte

Re: [PR] KAFKA-18913: Removing _state.updater.enabled_ flag through the Stream… [kafka]

2025-05-26 Thread via GitHub
cadonna commented on code in PR #19275: URL: https://github.com/apache/kafka/pull/19275#discussion_r2107363103 ## streams/integration-tests/src/test/java/org/apache/kafka/streams/integration/KafkaStreamsTelemetryIntegrationTest.java: ## @@ -446,29 +446,15 @@ private List getTask

Re: [PR] KAFKA-19282: Update quotaTypesEnabled on quota removal in ClientQuotaManager [kafka]

2025-05-26 Thread via GitHub
MahsaSeifikar commented on code in PR #19742: URL: https://github.com/apache/kafka/pull/19742#discussion_r2107840373 ## core/src/main/scala/kafka/server/ClientQuotaManager.scala: ## @@ -155,6 +155,7 @@ class ClientQuotaManager(private val config: ClientQuotaManagerConfig,

[PR] Update README.md [kafka]

2025-05-26 Thread via GitHub
whybeeh1 opened a new pull request, #19819: URL: https://github.com/apache/kafka/pull/19819 Better readability -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscrib

Re: [PR] Update README.md [kafka]

2025-05-26 Thread via GitHub
whybeeh1 closed pull request #19819: Update README.md URL: https://github.com/apache/kafka/pull/19819 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: ji

Re: [PR] Update README.md [kafka]

2025-05-26 Thread via GitHub
whybeeh1 commented on PR #19819: URL: https://github.com/apache/kafka/pull/19819#issuecomment-2910613900 cl -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

Re: [PR] Update README.md [kafka]

2025-05-26 Thread via GitHub
whybeeh1 commented on PR #19819: URL: https://github.com/apache/kafka/pull/19819#issuecomment-2910631422 l -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e

Re: [PR] KAFKA-19268 Missing mocks for SharePartitionManagerTest tests [kafka]

2025-05-26 Thread via GitHub
AndrewJSchofield merged PR #19786: URL: https://github.com/apache/kafka/pull/19786 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafk

[jira] [Resolved] (KAFKA-19268) Missing mocks for SharePartitionManagerTest tests

2025-05-26 Thread Andrew Schofield (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19268?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Schofield resolved KAFKA-19268. -- Fix Version/s: 4.1.0 Resolution: Fixed > Missing mocks for SharePartitionManage

Re: [PR] KAFKA-19285: Added more tests in SharePartitionManagerTest [kafka]

2025-05-26 Thread via GitHub
AndrewJSchofield commented on PR #19778: URL: https://github.com/apache/kafka/pull/19778#issuecomment-2910658074 @chirag-wadhwa5 Please merge latest changes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

[jira] [Updated] (KAFKA-19292) Introduce soft state for StreamsGroup

2025-05-26 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19292?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax updated KAFKA-19292: Component/s: streams > Introduce soft state for StreamsGroup > ---

Re: [PR] KAFKA-19244: Add support for kafka-streams-groups.sh options (delete group, offset-related APIs) [1/N] [kafka]

2025-05-26 Thread via GitHub
aliehsaeedii commented on code in PR #19646: URL: https://github.com/apache/kafka/pull/19646#discussion_r2107042451 ## tools/src/main/java/org/apache/kafka/tools/streams/StreamsGroupCommand.java: ## @@ -330,13 +400,433 @@ Map getOffsets(StreamsGroupDescription description)

Re: [PR] KAFKA-17747: [5/N] Replace subscription metadata with metadata hash in stream group (wip) [kafka]

2025-05-26 Thread via GitHub
lucasbru commented on code in PR #19802: URL: https://github.com/apache/kafka/pull/19802#discussion_r2106982543 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/streams/StreamsGroup.java: ## @@ -582,54 +592,44 @@ public Set currentWarmupTaskProcessIds(

[jira] [Updated] (KAFKA-19331) No error handling for leader not appeared in applyLocalFollowersDelta

2025-05-26 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19331?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Luke Chen updated KAFKA-19331: -- Summary: No error handling for leader not appeared in applyLocalFollowersDelta (was: No error handli

Re: [PR] MINOR: Change `Streams group` to `streams group` [kafka]

2025-05-26 Thread via GitHub
lucasbru commented on code in PR #19813: URL: https://github.com/apache/kafka/pull/19813#discussion_r2107119425 ## streams/src/main/java/org/apache/kafka/streams/kstream/internals/InternalStreamsBuilder.java: ## @@ -346,18 +346,18 @@ private void optimizeTopology(final Propertie

Re: [PR] MINOR: Cleanup JMH-Benchmarks Module [kafka]

2025-05-26 Thread via GitHub
sjhajharia commented on PR #19791: URL: https://github.com/apache/kafka/pull/19791#issuecomment-2909416974 Hey @m1a2st I have updated the PR -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

Re: [PR] KAFKA-17747: [4/N] Replace subscription metadata with metadata hash in consumer group [kafka]

2025-05-26 Thread via GitHub
FrankYang0529 commented on code in PR #19761: URL: https://github.com/apache/kafka/pull/19761#discussion_r2107245093 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/modern/consumer/ConsumerGroup.java: ## @@ -151,6 +152,8 @@ public String toLowerCaseString()

Re: [PR] KAFKA-17747: [4/N] Replace subscription metadata with metadata hash in consumer group [kafka]

2025-05-26 Thread via GitHub
FrankYang0529 commented on code in PR #19761: URL: https://github.com/apache/kafka/pull/19761#discussion_r2107242601 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -2220,6 +2227,11 @@ private CoordinatorResult int

Re: [PR] KAFKA-18904: kafka-configs.sh return resource doesn't exist message [3/N] [kafka]

2025-05-26 Thread via GitHub
FrankYang0529 commented on code in PR #19808: URL: https://github.com/apache/kafka/pull/19808#discussion_r2107254802 ## core/src/main/scala/kafka/admin/ConfigCommand.scala: ## @@ -342,6 +342,42 @@ object ConfigCommand extends Logging { } private def describeResourceConfi

Re: [PR] KAFKA-15283:[1/N] Client support for OffsetCommit with topic ID [kafka]

2025-05-26 Thread via GitHub
DL1231 commented on PR #19577: URL: https://github.com/apache/kafka/pull/19577#issuecomment-2909614033 @lianetm @dajac, PTAL when you get a chance. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[jira] [Created] (KAFKA-19332) Fix flaky test : testAlterReadCommittedToReadUncommittedIsolationLevelWithReleaseAck

2025-05-26 Thread Shivsundar R (Jira)
Shivsundar R created KAFKA-19332: Summary: Fix flaky test : testAlterReadCommittedToReadUncommittedIsolationLevelWithReleaseAck Key: KAFKA-19332 URL: https://issues.apache.org/jira/browse/KAFKA-19332

[jira] [Created] (KAFKA-19333) Inconsistent behavior between `ConsumerMembershipManager` and `StreamsMembershipManager` on `onAllTasksLost` execution

2025-05-26 Thread Nick Guo (Jira)
Nick Guo created KAFKA-19333: Summary: Inconsistent behavior between `ConsumerMembershipManager` and `StreamsMembershipManager` on `onAllTasksLost` execution Key: KAFKA-19333 URL: https://issues.apache.org/jira/browse

[PR] KAFKA-19290: Exploit mapKey optimisation in protocol requests and responses (wip) [kafka]

2025-05-26 Thread via GitHub
FrankYang0529 opened a new pull request, #19815: URL: https://github.com/apache/kafka/pull/19815 The mapKey optimisation can be used in some KIP-932 RPC schemas to improve efficiency of some key-based accesses. For ShareFetch, ShareAcknowledge, ShareGroupHeartbeat and ShareGroupDescr

Re: [PR] KAFKA-19300: AsyncConsumer#unsubscribe always timeout due to GroupAuthorizationException [kafka]

2025-05-26 Thread via GitHub
Rancho-7 commented on code in PR #19779: URL: https://github.com/apache/kafka/pull/19779#discussion_r2107277009 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractMembershipManager.java: ## @@ -443,7 +443,7 @@ public void transitionToFatal() {

[jira] [Updated] (KAFKA-19332) Fix flaky test : testAlterReadCommittedToReadUncommittedIsolationLevelWithReleaseAck and testAlterReadCommittedToReadUncommittedIsolationLevelWithRejectAck

2025-05-26 Thread Abhinav Dixit (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19332?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Abhinav Dixit updated KAFKA-19332: -- Summary: Fix flaky test : testAlterReadCommittedToReadUncommittedIsolationLevelWithReleaseAck

[PR] KAFKA-18117; KAFKA-18729: Use assigned topic IDs to avoid full metadata requests on broker-side regex [kafka]

2025-05-26 Thread via GitHub
lianetm opened a new pull request, #19814: URL: https://github.com/apache/kafka/pull/19814 This PR uses topic IDs received in assignment (under new protocol) to ensure that only these assigned topics are included in the consumer metadata requests performed when the user subscribes to broker

Re: [PR] KAFKA-17747: [4/N] Replace subscription metadata with metadata hash in consumer group [kafka]

2025-05-26 Thread via GitHub
FrankYang0529 commented on code in PR #19761: URL: https://github.com/apache/kafka/pull/19761#discussion_r2107213749 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/Utils.java: ## @@ -349,12 +349,19 @@ static void throwIfRegularExpressionIsInvalid( *

Re: [PR] KAFKA-17747: [4/N] Replace subscription metadata with metadata hash in consumer group [kafka]

2025-05-26 Thread via GitHub
dajac commented on code in PR #19761: URL: https://github.com/apache/kafka/pull/19761#discussion_r2107327586 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -3624,24 +3629,28 @@ private UpdateSubscriptionMetadataResult upda

Re: [PR] KAFKA-2526: command line --producer-property wins [kafka]

2025-05-26 Thread via GitHub
jkt628 commented on PR #16492: URL: https://github.com/apache/kafka/pull/16492#issuecomment-2909788972 note `test for client.id` moved to https://github.com/apache/kafka/blob/trunk/tools/src/test/java/org/apache/kafka/tools/ConsoleProducerTest.java -- This is an automated message from the

  1   2   >