ji-seung-ryu commented on code in PR #19786:
URL: https://github.com/apache/kafka/pull/19786#discussion_r2105831583
##
core/src/test/java/kafka/server/share/SharePartitionManagerTest.java:
##
@@ -3158,6 +3180,26 @@ static Seq>
buildLogReadResult(List>
buildLogReadResultWithFak
chia7712 commented on code in PR #19371:
URL: https://github.com/apache/kafka/pull/19371#discussion_r2105869770
##
storage/src/test/java/org/apache/kafka/storage/internals/log/LocalLogTest.java:
##
@@ -198,7 +197,7 @@ public void testUpdateConfig() {
assertEquals(oldCon
[
https://issues.apache.org/jira/browse/KAFKA-19268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17953860#comment-17953860
]
Abhinav Dixit commented on KAFKA-19268:
---
Hi [~jasonryu] , thanks for the changes.
m1a2st commented on code in PR #19791:
URL: https://github.com/apache/kafka/pull/19791#discussion_r2106058418
##
jmh-benchmarks/src/main/java/org/apache/kafka/jmh/assignor/ServerSideAssignorBenchmark.java:
##
@@ -189,7 +187,7 @@ private Optional rackId(int memberIndex) {
pr
m1a2st commented on code in PR #19371:
URL: https://github.com/apache/kafka/pull/19371#discussion_r2106061094
##
core/src/test/scala/kafka/raft/KafkaMetadataLogTest.scala:
##
@@ -1166,4 +1161,25 @@ object KafkaMetadataLogTest {
}
dir
}
+
+ private def createMetad
github-actions[bot] commented on PR #19236:
URL: https://github.com/apache/kafka/pull/19236#issuecomment-2907584521
A label of 'needs-attention' was automatically added to this PR in order to
raise the
attention of the committers. Once this issue has been triaged, the `triage`
label
s
github-actions[bot] commented on PR #19750:
URL: https://github.com/apache/kafka/pull/19750#issuecomment-2907584425
A label of 'needs-attention' was automatically added to this PR in order to
raise the
attention of the committers. Once this issue has been triaged, the `triage`
label
s
github-actions[bot] commented on PR #19607:
URL: https://github.com/apache/kafka/pull/19607#issuecomment-2907584455
A label of 'needs-attention' was automatically added to this PR in order to
raise the
attention of the committers. Once this issue has been triaged, the `triage`
label
s
github-actions[bot] commented on PR #19231:
URL: https://github.com/apache/kafka/pull/19231#issuecomment-2907584528
A label of 'needs-attention' was automatically added to this PR in order to
raise the
attention of the committers. Once this issue has been triaged, the `triage`
label
s
[
https://issues.apache.org/jira/browse/KAFKA-19328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17953879#comment-17953879
]
jiseung commented on KAFKA-19328:
-
May I take this one?
> SharePartitionManagerTest te
github-actions[bot] commented on PR #17565:
URL: https://github.com/apache/kafka/pull/17565#issuecomment-2907589249
This PR has been closed since it has not had any activity in 120 days. If
you feel like this
was a mistake, or you would like to continue working on it, please feel free
to
github-actions[bot] closed pull request #17565: KAFKA-17798 : Adding
forbiddenApi check
URL: https://github.com/apache/kafka/pull/17565
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific c
github-actions[bot] commented on PR #18957:
URL: https://github.com/apache/kafka/pull/18957#issuecomment-2907589280
This PR is being marked as stale since it has not had any activity in 90
days. If you
would like to keep this PR alive, please leave a comment asking for a
review. If the P
github-actions[bot] commented on PR #16418:
URL: https://github.com/apache/kafka/pull/16418#issuecomment-2907589228
This PR has been closed since it has not had any activity in 120 days. If
you feel like this
was a mistake, or you would like to continue working on it, please feel free
to
github-actions[bot] closed pull request #16729: KAFKA-13154 : Changes for the
OffsetSpec.latest() to correctly represent the latest offset per partition
URL: https://github.com/apache/kafka/pull/16729
--
This is an automated message from the Apache Git Service.
To respond to the message, plea
github-actions[bot] commented on PR #11052:
URL: https://github.com/apache/kafka/pull/11052#issuecomment-2907589180
This PR has been closed since it has not had any activity in 120 days. If
you feel like this
was a mistake, or you would like to continue working on it, please feel free
to
github-actions[bot] closed pull request #11052: Use ByteBuffers for LZ4
OutputStream
URL: https://github.com/apache/kafka/pull/11052
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comm
github-actions[bot] closed pull request #11193: MINOR: Delete temporary
directories after using them in RaftManagerTest
URL: https://github.com/apache/kafka/pull/11193
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
U
github-actions[bot] closed pull request #14783: KAFKA-15845: Detect leaked
Kafka clients and servers with LeakTestingExtension
URL: https://github.com/apache/kafka/pull/14783
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and us
github-actions[bot] commented on PR #11193:
URL: https://github.com/apache/kafka/pull/11193#issuecomment-2907589190
This PR has been closed since it has not had any activity in 120 days. If
you feel like this
was a mistake, or you would like to continue working on it, please feel free
to
github-actions[bot] commented on PR #14783:
URL: https://github.com/apache/kafka/pull/14783#issuecomment-2907589211
This PR has been closed since it has not had any activity in 120 days. If
you feel like this
was a mistake, or you would like to continue working on it, please feel free
to
github-actions[bot] closed pull request #16418: KAFKA-10840: Propagating
Authentication errors when client setup fails with AuthenticationException
URL: https://github.com/apache/kafka/pull/16418
--
This is an automated message from the Apache Git Service.
To respond to the message, please lo
github-actions[bot] commented on PR #16729:
URL: https://github.com/apache/kafka/pull/16729#issuecomment-2907589242
This PR has been closed since it has not had any activity in 120 days. If
you feel like this
was a mistake, or you would like to continue working on it, please feel free
to
github-actions[bot] commented on PR #12305:
URL: https://github.com/apache/kafka/pull/12305#issuecomment-2907589199
This PR has been closed since it has not had any activity in 120 days. If
you feel like this
was a mistake, or you would like to continue working on it, please feel free
to
github-actions[bot] closed pull request #12305: MINOR: Add __cluster_metadata
topic to list of internal topics
URL: https://github.com/apache/kafka/pull/12305
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
ji-seung-ryu commented on PR #19786:
URL: https://github.com/apache/kafka/pull/19786#issuecomment-2907597412
> @ji-seung-ryu Thanks for the changes. As I mentioned in this
[comment](https://github.com/apache/kafka/pull/19786#pullrequestreview-2863310322),
we also need to change `testRelease
chia7712 commented on PR #19798:
URL: https://github.com/apache/kafka/pull/19798#issuecomment-2907644914
@Mirai1129 please rebase the code to include #19759
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
[
https://issues.apache.org/jira/browse/KAFKA-19312?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai resolved KAFKA-19312.
Fix Version/s: 4.1.0
Resolution: Fixed
> Share partition fetch locks concurrent thr
chia7712 merged PR #19759:
URL: https://github.com/apache/kafka/pull/19759
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
Mirai1129 commented on PR #19798:
URL: https://github.com/apache/kafka/pull/19798#issuecomment-2907651728
Done!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscri
chia7712 commented on PR #18957:
URL: https://github.com/apache/kafka/pull/18957#issuecomment-2907640003
@nihyxx could you please fix the conflicts?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go t
chia7712 commented on PR #19793:
URL: https://github.com/apache/kafka/pull/19793#issuecomment-2907649089
I will review this PR after #19798 gets merged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
chia7712 merged PR #19681:
URL: https://github.com/apache/kafka/pull/19681
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
[
https://issues.apache.org/jira/browse/KAFKA-14449?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17953813#comment-17953813
]
Zhou Shihuan commented on KAFKA-14449:
--
I encountered a similar issue, the upgraded
ji-seung-ryu commented on code in PR #19786:
URL: https://github.com/apache/kafka/pull/19786#discussion_r2105835927
##
core/src/test/java/kafka/server/share/SharePartitionManagerTest.java:
##
@@ -1723,7 +1743,9 @@ public void
testAcknowledgeCompletesDelayedShareFetchRequest() {
sjhajharia opened a new pull request, #19805:
URL: https://github.com/apache/kafka/pull/19805
Now that Kafka Brokers support Java 17, this PR makes some changes in
core module. The changes in this PR are limited to only some Scala files
in the Core module's tests. The changes mostly inc
ji-seung-ryu commented on code in PR #19786:
URL: https://github.com/apache/kafka/pull/19786#discussion_r2105832275
##
core/src/test/java/kafka/server/share/SharePartitionManagerTest.java:
##
@@ -790,6 +789,27 @@ public void
testCachedTopicPartitionsForValidShareSessions() {
ji-seung-ryu commented on code in PR #19786:
URL: https://github.com/apache/kafka/pull/19786#discussion_r2105831583
##
core/src/test/java/kafka/server/share/SharePartitionManagerTest.java:
##
@@ -3158,6 +3180,26 @@ static Seq>
buildLogReadResult(List>
buildLogReadResultWithFak
ji-seung-ryu commented on code in PR #19786:
URL: https://github.com/apache/kafka/pull/19786#discussion_r2106079556
##
core/src/test/java/kafka/server/share/SharePartitionManagerTest.java:
##
@@ -3167,7 +3162,7 @@ private void validateBrokerTopicStatsMetrics(
static Seq>
b
FrankYang0529 commented on PR #19699:
URL: https://github.com/apache/kafka/pull/19699#issuecomment-2906717913
@chia7712 Thanks for the suggestion. I address all comments.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
[
https://issues.apache.org/jira/browse/KAFKA-19268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17953829#comment-17953829
]
jiseung commented on KAFKA-19268:
-
[~adixitconfluent] Thank you for your review. I pushe
brandboat opened a new pull request, #19803:
URL: https://github.com/apache/kafka/pull/19803
This patch resolves the following issues in MetadataCache#toCluster:
- Avoids duplicate Node entries when a broker has multiple endpoints.
- Fixes a bug where fenced brokers result in NPE.
-
ahuang98 commented on code in PR #19742:
URL: https://github.com/apache/kafka/pull/19742#discussion_r2105874739
##
core/src/main/scala/kafka/server/ClientQuotaManager.scala:
##
@@ -453,40 +452,34 @@ class ClientQuotaManager(private val config:
ClientQuotaManagerConfig,
}
sjhajharia opened a new pull request, #19804:
URL: https://github.com/apache/kafka/pull/19804
Now that Kafka Brokers support Java 17, this PR makes some changes in
core module. The changes in this PR are limited to only some Scala files
in the Core module's tests. The changes mostly inc
ji-seung-ryu commented on PR #19786:
URL: https://github.com/apache/kafka/pull/19786#issuecomment-2906860818
Thank you for kind code review. Also, I want you to see if
testMultipleConcurrentShareFetches works as it is intended. I don't think
doAnswer chaning (line 1072 ~ 1101 in sharePartit
chia7712 merged PR #19767:
URL: https://github.com/apache/kafka/pull/19767
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
[
https://issues.apache.org/jira/browse/KAFKA-19313?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai resolved KAFKA-19313.
Fix Version/s: 4.1.0
Resolution: Fixed
> Replace LogOffsetMetadata#UNIFIED_LOG_UNKN
apalan60 opened a new pull request, #19806:
URL: https://github.com/apache/kafka/pull/19806
[JIRA:
KAFKA-19167](https://issues.apache.org/jira/projects/KAFKA/issues/KAFKA-19167?filter=allissues)
As part of refactoring `KafkaConfig` to reduce its responsibilities, this PR
removes the
adixitconfluent commented on code in PR #19786:
URL: https://github.com/apache/kafka/pull/19786#discussion_r2105902573
##
core/src/test/java/kafka/server/share/SharePartitionManagerTest.java:
##
@@ -3167,7 +3162,7 @@ private void validateBrokerTopicStatsMetrics(
static Seq>
adixitconfluent commented on PR #19786:
URL: https://github.com/apache/kafka/pull/19786#issuecomment-2906971134
@ji-seung-ryu Thanks for the changes. As I mentioned in this
[comment](https://github.com/apache/kafka/pull/19786#pullrequestreview-2863310322),
we also need to change `testReleas
adixitconfluent commented on PR #19786:
URL: https://github.com/apache/kafka/pull/19786#issuecomment-2906974603
> Thank you for kind code review. I resolved all you mentioned. Also, I want
you to see if testMultipleConcurrentShareFetches works as it is intended. I
don't think doAnswer chani
Abhinav Dixit created KAFKA-19328:
-
Summary: SharePartitionManagerTest
testMultipleConcurrentShareFetches doAnswer chaining needs verification
Key: KAFKA-19328
URL: https://issues.apache.org/jira/browse/KAFKA-1932
YutaLin opened a new pull request, #19807:
URL: https://github.com/apache/kafka/pull/19807
Migrate ControllerMutationQuotaManager to Java implementation and move to
server module, including ClientQuotaManager and associated files.
Reviewers:
PoAn Yang [pay...@apache.org](mailto:pay
FrankYang0529 opened a new pull request, #19808:
URL: https://github.com/apache/kafka/pull/19808
* Return resource doesn't exist message when users try to describe a
non-existent resource in kafka-configs.sh and kafka-client-metrics.sh.
* For groups type, the command checks both existent
jim0987795064 commented on code in PR #19776:
URL: https://github.com/apache/kafka/pull/19776#discussion_r2105787616
##
clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java:
##
@@ -2494,8 +2494,7 @@ void handleResponse(AbstractResponse abstractResponse) {
[
https://issues.apache.org/jira/browse/KAFKA-14449?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17953813#comment-17953813
]
Zhou Shihuan edited comment on KAFKA-14449 at 5/24/25 10:13 AM:
--
[
https://issues.apache.org/jira/browse/KAFKA-14449?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17953813#comment-17953813
]
Zhou Shihuan edited comment on KAFKA-14449 at 5/24/25 10:15 AM:
--
[
https://issues.apache.org/jira/browse/KAFKA-14449?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17953813#comment-17953813
]
Zhou Shihuan edited comment on KAFKA-14449 at 5/24/25 10:02 AM:
--
[
https://issues.apache.org/jira/browse/KAFKA-14449?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17953813#comment-17953813
]
Zhou Shihuan edited comment on KAFKA-14449 at 5/24/25 10:20 AM:
--
[
https://issues.apache.org/jira/browse/KAFKA-14449?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17953813#comment-17953813
]
Zhou Shihuan edited comment on KAFKA-14449 at 5/24/25 10:20 AM:
--
[
https://issues.apache.org/jira/browse/KAFKA-14449?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17953813#comment-17953813
]
Zhou Shihuan edited comment on KAFKA-14449 at 5/24/25 10:20 AM:
--
squah-confluent commented on code in PR #19790:
URL: https://github.com/apache/kafka/pull/19790#discussion_r2105890201
##
core/src/test/scala/integration/kafka/api/PlaintextAdminIntegrationTest.scala:
##
@@ -2485,8 +2485,6 @@ class PlaintextAdminIntegrationTest extends
BaseAdmi
showuon commented on PR #19772:
URL: https://github.com/apache/kafka/pull/19772#issuecomment-2906539615
@chia7712 , thanks for the reminder!
@mjsax @dajac , could you (or your colleagues) help upload the 3.9.1
artifacts to the AWS? Thank you.
--
This is an automated message from the A
m1a2st commented on code in PR #19798:
URL: https://github.com/apache/kafka/pull/19798#discussion_r2105753702
##
core/src/main/scala/kafka/server/DelayedProduce.scala:
##
@@ -17,20 +17,18 @@
package kafka.server
-import java.util.concurrent.{ConcurrentHashMap, TimeUnit}
-im
m1a2st commented on code in PR #19776:
URL: https://github.com/apache/kafka/pull/19776#discussion_r2105755254
##
core/src/test/java/integration/kafka/server/IntegrationTestUtils.java:
##
@@ -0,0 +1,125 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
Mirai1129 commented on code in PR #19798:
URL: https://github.com/apache/kafka/pull/19798#discussion_r2105768557
##
core/src/main/scala/kafka/server/DelayedProduce.scala:
##
@@ -17,20 +17,18 @@
package kafka.server
-import java.util.concurrent.{ConcurrentHashMap, TimeUnit}
66 matches
Mail list logo
