AndrewJSchofield commented on code in PR #19759:
URL: https://github.com/apache/kafka/pull/19759#discussion_r2097405538
##
core/src/main/java/kafka/server/share/DelayedShareFetch.java:
##
@@ -191,26 +191,23 @@ public void onExpiration() {
* Complete the share fetch operati
chia7712 commented on PR #19759:
URL: https://github.com/apache/kafka/pull/19759#issuecomment-2893580009
@apoorvmittal10 It is too cool to add response in comment, so I don't notice
your response :)
> For 2) tryComplete invocation is in lock itself and there is also a checck
for isCo
jingjia88 commented on PR #19763:
URL: https://github.com/apache/kafka/pull/19763#issuecomment-2893558162
> Looks good. Please update the PR title, Kafka -> KAFKA.
Thanks, updated the PR title as suggested. PTAL.
--
This is an automated message from the Apache Git Service.
To respon
andy1li commented on PR #19769:
URL: https://github.com/apache/kafka/pull/19769#issuecomment-2894167620
@dengziming @Yunyung CI failed, but it does not look like related to my
change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
AndrewJSchofield merged PR #19770:
URL: https://github.com/apache/kafka/pull/19770
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafk
AndrewJSchofield commented on code in PR #19758:
URL: https://github.com/apache/kafka/pull/19758#discussion_r2097734386
##
tools/src/main/java/org/apache/kafka/tools/streams/StreamsGroupCommandOptions.java:
##
@@ -23,18 +23,25 @@
import org.slf4j.LoggerFactory;
import java.u
k-raina commented on code in PR #19731:
URL: https://github.com/apache/kafka/pull/19731#discussion_r2096948718
##
core/src/main/scala/kafka/admin/ConfigCommand.scala:
##
@@ -86,13 +86,13 @@ object ConfigCommand extends Logging {
opts.checkArgs()
processCommand(opts
apoorvmittal10 commented on PR #19759:
URL: https://github.com/apache/kafka/pull/19759#issuecomment-2893712701
> @apoorvmittal10 It is too cool to add response in comment, so I don't
notice your response :)
>
> > For 2) tryComplete invocation is in lock itself and there is also a
che
chirag-wadhwa5 opened a new pull request, #19774:
URL: https://github.com/apache/kafka/pull/19774
This PR include system tests in the file share_group_command_test.py. These
tests test the functionality of kafka-share-groups.sh tool
--
This is an automated message from the Apache Git Serv
dennis lucero created KAFKA-19318:
-
Summary: Zookeeper-Kraft failing migration - RPC got timed out
before it could be sent
Key: KAFKA-19318
URL: https://issues.apache.org/jira/browse/KAFKA-19318
Proje
TaiJuWu opened a new pull request, #19773:
URL: https://github.com/apache/kafka/pull/19773
The PR do following:
1. rewrite to new test infra
2. rewrite to java
3. move to clients-integration-tests
--
This is an automated message from the Apache Git Service.
To respond to the messa
chia7712 commented on code in PR #19371:
URL: https://github.com/apache/kafka/pull/19371#discussion_r2097986937
##
server-common/src/main/java/org/apache/kafka/server/config/ServerTopicConfigSynonyms.java:
##
@@ -47,9 +48,11 @@ public final class ServerTopicConfigSynonyms {
m1a2st commented on code in PR #19371:
URL: https://github.com/apache/kafka/pull/19371#discussion_r2097948691
##
server-common/src/main/java/org/apache/kafka/server/config/ServerTopicConfigSynonyms.java:
##
@@ -47,9 +48,11 @@ public final class ServerTopicConfigSynonyms {
FrankYang0529 commented on PR #19232:
URL: https://github.com/apache/kafka/pull/19232#issuecomment-2894738172
Hi @chia7712, I addressed all comments. Could you review again when you have
time? Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message,
m1a2st commented on code in PR #19371:
URL: https://github.com/apache/kafka/pull/19371#discussion_r2098206077
##
server-common/src/main/java/org/apache/kafka/server/config/ServerTopicConfigSynonyms.java:
##
@@ -47,9 +48,11 @@ public final class ServerTopicConfigSynonyms {
FrankYang0529 commented on PR #19699:
URL: https://github.com/apache/kafka/pull/19699#issuecomment-2894763539
@chia7712, I addressed all comments. Could you review again when you have
time? Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, ple
[
https://issues.apache.org/jira/browse/KAFKA-19318?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
dennis lucero updated KAFKA-19318:
--
Fix Version/s: (was: 3.7.1)
Affects Version/s: 3.9.0
(wa
[
https://issues.apache.org/jira/browse/KAFKA-19318?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
dennis lucero updated KAFKA-19318:
--
Description:
Despite several attempts to migrate from Zookeeper cluster to Kraft, it failed
t
chia7712 commented on PR #19769:
URL: https://github.com/apache/kafka/pull/19769#issuecomment-2895129726
backport to 4.0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
chia7712 commented on PR #19769:
URL: https://github.com/apache/kafka/pull/19769#issuecomment-2895130291
@andy1li thanks for your contribution
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
k-raina commented on PR #19522:
URL: https://github.com/apache/kafka/pull/19522#issuecomment-2895330441
@jolshan Thanks for review
Added https://issues.apache.org/jira/browse/KAFKA-19177 with this PR
--
This is an automated message from the Apache Git Service.
To respond to the message,
jim0987795064 opened a new pull request, #19776:
URL: https://github.com/apache/kafka/pull/19776
This PR rewrites the IntegrationTestUtils from Scala to Java.
Changes:
Converted all the existing Scala code in IntegrationTestUtils.scala into
Java in IntegrationTestUtils.java.
ahuang98 commented on code in PR #19747:
URL: https://github.com/apache/kafka/pull/19747#discussion_r2098754577
##
raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java:
##
@@ -3149,17 +3139,12 @@ private long pollCandidate(long currentTimeMs) {
// 3) the s
jsancio commented on code in PR #19745:
URL: https://github.com/apache/kafka/pull/19745#discussion_r2098749462
##
core/src/main/scala/kafka/server/BrokerServer.scala:
##
@@ -411,7 +411,7 @@ class BrokerServer(
config,
"heartbeat",
s"broker-${config.nod
ahuang98 commented on code in PR #19747:
URL: https://github.com/apache/kafka/pull/19747#discussion_r2098773109
##
raft/src/main/java/org/apache/kafka/raft/QuorumState.java:
##
@@ -505,7 +505,6 @@ public void prospectiveAddVotedState(
);
}
-Prospe
frankvicky commented on code in PR #19772:
URL: https://github.com/apache/kafka/pull/19772#discussion_r2099167797
##
tests/docker/Dockerfile:
##
@@ -117,7 +117,7 @@ RUN curl -s "$KAFKA_MIRROR/kafka-streams-3.5.2-test.jar" -o
/opt/kafka-3.5.2/lib
RUN curl -s "$KAFKA_MIRROR/kafk
TaiJuWu commented on code in PR #19776:
URL: https://github.com/apache/kafka/pull/19776#discussion_r2099019147
##
core/src/test/java/integration/kafka/server/IntegrationTestUtils.java:
##
@@ -0,0 +1,125 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or mor
TaiJuWu commented on code in PR #19776:
URL: https://github.com/apache/kafka/pull/19776#discussion_r2099019147
##
core/src/test/java/integration/kafka/server/IntegrationTestUtils.java:
##
@@ -0,0 +1,125 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or mor
Rancho-7 commented on code in PR #19728:
URL: https://github.com/apache/kafka/pull/19728#discussion_r2099014700
##
clients/src/main/java/org/apache/kafka/clients/admin/ListConsumerGroupOffsetsResult.java:
##
@@ -60,9 +58,6 @@ public KafkaFuture>
partitionsToOffsetAnd
* Re
jolshan merged PR #19731:
URL: https://github.com/apache/kafka/pull/19731
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.
dengziming commented on PR #19762:
URL: https://github.com/apache/kafka/pull/19762#issuecomment-2896341933
There are some concerns regarding this change, though we haven't made
`kraft` a public API, we are trying to keep it dependency-free to be used as a
raft-sdk anywhere. For example, if
showuon commented on code in PR #19772:
URL: https://github.com/apache/kafka/pull/19772#discussion_r2099183575
##
tests/docker/Dockerfile:
##
@@ -117,7 +117,7 @@ RUN curl -s "$KAFKA_MIRROR/kafka-streams-3.5.2-test.jar" -o
/opt/kafka-3.5.2/lib
RUN curl -s "$KAFKA_MIRROR/kafka-s
showuon merged PR #19756:
URL: https://github.com/apache/kafka/pull/19756
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.
github-actions[bot] commented on PR #19703:
URL: https://github.com/apache/kafka/pull/19703#issuecomment-2896449712
A label of 'needs-attention' was automatically added to this PR in order to
raise the
attention of the committers. Once this issue has been triaged, the `triage`
label
s
[
https://issues.apache.org/jira/browse/KAFKA-18783?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kaushik Raina resolved KAFKA-18783.
---
Resolution: Fixed
> Extend InvalidConfigurationException related exceptions
> --
chenshi5012 opened a new pull request, #19777:
URL: https://github.com/apache/kafka/pull/19777
fix separator for different systems
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific com
sjhajharia commented on PR #19380:
URL: https://github.com/apache/kafka/pull/19380#issuecomment-2896563569
Hey @frankvicky Adding you as a reviewer too here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abov
frankvicky merged PR #19771:
URL: https://github.com/apache/kafka/pull/19771
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apac
Yunyung commented on PR #19763:
URL: https://github.com/apache/kafka/pull/19763#issuecomment-2893402985
Looks good. Please update the PR title, Kafka -> KAFKA.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL ab
sjhajharia commented on PR #19380:
URL: https://github.com/apache/kafka/pull/19380#issuecomment-2893387038
Hey @chia7712
gentle Reminder
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the sp
chia7712 commented on code in PR #19759:
URL: https://github.com/apache/kafka/pull/19759#discussion_r2097557356
##
server-common/src/main/java/org/apache/kafka/server/purgatory/DelayedOperation.java:
##
@@ -68,24 +67,36 @@ public DelayedOperation(long delayMs, Lock lock) {
apoorvmittal10 commented on code in PR #19759:
URL: https://github.com/apache/kafka/pull/19759#discussion_r2097549218
##
core/src/main/java/kafka/server/share/DelayedShareFetch.java:
##
@@ -349,7 +346,7 @@ public boolean tryComplete() {
releasePartitionLocks
chia7712 commented on code in PR #19371:
URL: https://github.com/apache/kafka/pull/19371#discussion_r2097427388
##
server-common/src/main/java/org/apache/kafka/server/config/ServerTopicConfigSynonyms.java:
##
@@ -47,9 +48,11 @@ public final class ServerTopicConfigSynonyms {
apoorvmittal10 commented on PR #19759:
URL: https://github.com/apache/kafka/pull/19759#issuecomment-2893719889
> > The onComplete method in DelayedOperation is guaranteed to run only
> > once, either by tryComplete or onExpiration.
>
> `onExpiration`? or `forceComplete`?
>
>
jsancio commented on code in PR #19747:
URL: https://github.com/apache/kafka/pull/19747#discussion_r2098319932
##
raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java:
##
@@ -1020,24 +1020,14 @@ private void maybeHandleElectionLoss(NomineeState
state, long currentTimeM
jsancio commented on code in PR #19668:
URL: https://github.com/apache/kafka/pull/19668#discussion_r2098376753
##
raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java:
##
@@ -2771,16 +2776,17 @@ private RequestSendResult maybeSendRequest(
Supplier requestSuppli
ahuang98 commented on code in PR #19747:
URL: https://github.com/apache/kafka/pull/19747#discussion_r2098643293
##
raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java:
##
@@ -1020,24 +1020,14 @@ private void maybeHandleElectionLoss(NomineeState
state, long currentTime
kevin-wu24 commented on code in PR #19668:
URL: https://github.com/apache/kafka/pull/19668#discussion_r2098713276
##
raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java:
##
@@ -2762,25 +2767,27 @@ private void handleInboundMessage(RaftMessage message,
long currentTime
kevin-wu24 commented on code in PR #19668:
URL: https://github.com/apache/kafka/pull/19668#discussion_r2098729321
##
raft/src/main/java/org/apache/kafka/raft/RequestManager.java:
##
@@ -62,21 +67,28 @@ public RequestManager(
}
/**
- * Returns true if there are an
jsancio commented on code in PR #19745:
URL: https://github.com/apache/kafka/pull/19745#discussion_r2098749462
##
core/src/main/scala/kafka/server/BrokerServer.scala:
##
@@ -411,7 +411,7 @@ class BrokerServer(
config,
"heartbeat",
s"broker-${config.nod
ahuang98 commented on code in PR #19747:
URL: https://github.com/apache/kafka/pull/19747#discussion_r2098773109
##
raft/src/main/java/org/apache/kafka/raft/QuorumState.java:
##
@@ -505,7 +505,6 @@ public void prospectiveAddVotedState(
);
}
-Prospe
ahuang98 commented on code in PR #19747:
URL: https://github.com/apache/kafka/pull/19747#discussion_r2098785217
##
raft/src/main/java/org/apache/kafka/raft/QuorumState.java:
##
@@ -505,7 +505,6 @@ public void prospectiveAddVotedState(
);
}
-Prospe
Alyssa Huang created KAFKA-19319:
Summary: Don't reset election timeout for prospective on
transition to prospectiveVoted
Key: KAFKA-19319
URL: https://issues.apache.org/jira/browse/KAFKA-19319
Projec
cmccabe commented on code in PR #19745:
URL: https://github.com/apache/kafka/pull/19745#discussion_r2098839394
##
core/src/main/scala/kafka/server/BrokerServer.scala:
##
@@ -411,7 +411,7 @@ class BrokerServer(
config,
"heartbeat",
s"broker-${config.nod
jsancio commented on code in PR #19745:
URL: https://github.com/apache/kafka/pull/19745#discussion_r2098863446
##
core/src/main/scala/kafka/server/BrokerServer.scala:
##
@@ -411,7 +411,7 @@ class BrokerServer(
config,
"heartbeat",
s"broker-${config.nod
junrao commented on PR #19759:
URL: https://github.com/apache/kafka/pull/19759#issuecomment-2895167769
> This was a tricky bug to find, so nice catch.
@apoorvmittal10 : My understanding is that this PR is not fixing a bug.
Without the PR, we still guarantee that onComplete() will be c
kevin-wu24 commented on code in PR #19668:
URL: https://github.com/apache/kafka/pull/19668#discussion_r2098713276
##
raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java:
##
@@ -2762,25 +2767,27 @@ private void handleInboundMessage(RaftMessage message,
long currentTime
chia7712 merged PR #19769:
URL: https://github.com/apache/kafka/pull/19769
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
sjhajharia opened a new pull request, #19775:
URL: https://github.com/apache/kafka/pull/19775
Now that Kafka Brokers support Java 17, this PR makes some changes in
test-common module. The changes mostly include:
- Collections.emptyList(), Collections.singletonList() and Arrays.asList()
a
jolshan merged PR #19746:
URL: https://github.com/apache/kafka/pull/19746
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.
jsancio commented on code in PR #19668:
URL: https://github.com/apache/kafka/pull/19668#discussion_r2098412030
##
raft/src/main/java/org/apache/kafka/raft/RequestManager.java:
##
@@ -42,7 +42,12 @@
* {@code retryBackoffMs}.
*/
public class RequestManager {
-private fina
apoorvmittal10 commented on PR #19739:
URL: https://github.com/apache/kafka/pull/19739#issuecomment-2896720259
@smjn Do we need this PR now or is the issue fixed by
[other](https://github.com/apache/kafka/pull/19611) recently merged changes?
--
This is an automated message from the Apache
JimmyWang6 commented on PR #18929:
URL: https://github.com/apache/kafka/pull/18929#issuecomment-2896800553
@apoorvmittal10
Yes，I am handling it now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
chia7712 merged PR #19768:
URL: https://github.com/apache/kafka/pull/19768
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
[
https://issues.apache.org/jira/browse/KAFKA-19266?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Apoorv Mittal reassigned KAFKA-19266:
-
Assignee: Chirag Wadhwa
> Eliminate flakiness in test
> SharePartitionTest.testAcquisi
65 matches
Mail list logo
