Re: [PR] KAFKA-17747: [3/N] Get rid of TopicMetadata in SubscribedTopicDescriberImpl [kafka]

2025-05-13 Thread via GitHub
FrankYang0529 commented on PR #19611: URL: https://github.com/apache/kafka/pull/19611#issuecomment-2876171380 > Out of curiosity, have you tried to run the benchmarks before and after the change to see the impact? Since previous `SubscribedTopicDescriberImpl` only supports `numOfPart

Re: [PR] KAFKA-18688: Fix uniform homogeneous assignor stability [kafka]

2025-05-13 Thread via GitHub
squah-confluent commented on code in PR #19677: URL: https://github.com/apache/kafka/pull/19677#discussion_r2086619092 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/UniformHomogeneousAssignmentBuilder.java: ## @@ -218,6 +234,15 @@ private void ma

Re: [PR] MINOR: Minor updates to RangeSet [kafka]

2025-05-13 Thread via GitHub
FrankYang0529 commented on code in PR #19678: URL: https://github.com/apache/kafka/pull/19678#discussion_r2086665383 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/RangeSet.java: ## @@ -163,6 +171,7 @@ public boolean equals(Object o) { if

Re: [PR] MINOR: Minor updates to RangeSet [kafka]

2025-05-13 Thread via GitHub
squah-confluent commented on code in PR #19678: URL: https://github.com/apache/kafka/pull/19678#discussion_r2086677598 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/RangeSet.java: ## @@ -176,8 +185,18 @@ public boolean equals(Object o) { @

Re: [PR] MINOR: clean KafkaConsumer tests [kafka]

2025-05-13 Thread via GitHub
m1a2st commented on code in PR #19669: URL: https://github.com/apache/kafka/pull/19669#discussion_r2086701640 ## clients/src/test/java/org/apache/kafka/clients/consumer/KafkaConsumerTest.java: ## @@ -913,16 +914,16 @@ public void verifyNoCoordinatorLookupForManualAssignmentWith

Re: [PR] KAFKA-17747: [2/N] Add compute topic and group hash [kafka]

2025-05-13 Thread via GitHub
dajac commented on code in PR #19523: URL: https://github.com/apache/kafka/pull/19523#discussion_r2086685337 ## build.gradle: ## @@ -1414,10 +1414,12 @@ project(':group-coordinator') { implementation project(':coordinator-common') implementation libs.jacksonDatabind

Re: [PR] changed the default value of metadata_quorum in test methods to quorum.isolted_kraft where quorum.zk was used [kafka]

2025-05-13 Thread via GitHub
AndrewJSchofield commented on code in PR #19707: URL: https://github.com/apache/kafka/pull/19707#discussion_r2086697553 ## tests/kafkatest/tests/client/share_consumer_test.py: ## @@ -248,7 +248,7 @@ def test_broker_failure(self, clean_shutdown, metadata_quorum=quorum.isolated_k

Re: [PR] KAFKA-19253: Improve metadata handling for share version using feature listeners (1/N) [kafka]

2025-05-13 Thread via GitHub
AndrewJSchofield merged PR #19659: URL: https://github.com/apache/kafka/pull/19659 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafk

Re: [PR] KAFKA-17747: [2/N] Add compute topic and group hash [kafka]

2025-05-13 Thread via GitHub
FrankYang0529 commented on code in PR #19523: URL: https://github.com/apache/kafka/pull/19523#discussion_r2087026067 ## build.gradle: ## @@ -1414,10 +1414,12 @@ project(':group-coordinator') { implementation project(':coordinator-common') implementation libs.jacksonDat

Re: [PR] KAFKA-17747: [2/N] Add compute topic and group hash [kafka]

2025-05-13 Thread via GitHub
FrankYang0529 commented on code in PR #19523: URL: https://github.com/apache/kafka/pull/19523#discussion_r2087027573 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/Utils.java: ## @@ -324,4 +329,84 @@ static void throwIfRegularExpressionIsInvalid(

Re: [PR] MINOR: Improve docs for retries & cleanup [kafka]

2025-05-13 Thread via GitHub
lianetm merged PR #19595: URL: https://github.com/apache/kafka/pull/19595 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.

Re: [PR] KAFKA-19206: ConsumerNetworkThread.cleanup() throws NullPointerException if initializeResources() previously failed [kafka]

2025-05-13 Thread via GitHub
kirktrue commented on code in PR #19569: URL: https://github.com/apache/kafka/pull/19569#discussion_r2086890019 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerNetworkThread.java: ## @@ -339,11 +339,20 @@ void cleanup() { log.trace("Closing

Re: [PR] KAFKA-19116, KAFKA-19258: Handling share group member change events [kafka]

2025-05-13 Thread via GitHub
AndrewJSchofield commented on code in PR #19666: URL: https://github.com/apache/kafka/pull/19666#discussion_r2086868597 ## server/src/main/java/org/apache/kafka/server/share/session/ShareSessionCache.java: ## @@ -143,6 +191,7 @@ public synchronized ShareSessionKey maybeCreateSes

Re: [PR] KAFKA-18847: Refactor OAuth layer to improve reusability 1/N [kafka]

2025-05-13 Thread via GitHub
kirktrue commented on code in PR #19622: URL: https://github.com/apache/kafka/pull/19622#discussion_r2086875757 ## clients/src/test/java/org/apache/kafka/common/security/oauthbearer/OAuthBearerValidatorCallbackHandlerTest.java: ## @@ -106,11 +109,13 @@ public OAuthBearerToken va

Re: [PR] KAFKA-18847: Refactor OAuth layer to improve reusability 1/N [kafka]

2025-05-13 Thread via GitHub
kirktrue commented on code in PR #19622: URL: https://github.com/apache/kafka/pull/19622#discussion_r2086872075 ## clients/src/main/java/org/apache/kafka/common/security/oauthbearer/internals/secured/DefaultJwtValidator.java: ## @@ -0,0 +1,106 @@ +/* + * Licensed to the Apache S

Re: [PR] KAFKA-18904: [1/N] Change ListClientMetricsResources API to ListConfigResources [kafka]

2025-05-13 Thread via GitHub
FrankYang0529 commented on code in PR #19493: URL: https://github.com/apache/kafka/pull/19493#discussion_r2086921570 ## core/src/main/scala/kafka/server/KafkaApis.scala: ## @@ -2874,16 +2874,55 @@ class KafkaApis(val requestChannel: RequestChannel, } } - def handleLis

Re: [PR] KAFKA-18904: [1/N] Change ListClientMetricsResources API to ListConfigResources [kafka]

2025-05-13 Thread via GitHub
FrankYang0529 commented on code in PR #19493: URL: https://github.com/apache/kafka/pull/19493#discussion_r2086922412 ## core/src/test/scala/unit/kafka/server/KafkaApisTest.scala: ## @@ -10929,47 +10928,231 @@ class KafkaApisTest extends Logging { } @Test - def testListC

Re: [PR] KAFKA-18847: Refactor OAuth layer to improve reusability 1/N [kafka]

2025-05-13 Thread via GitHub
kirktrue commented on code in PR #19622: URL: https://github.com/apache/kafka/pull/19622#discussion_r2086871765 ## clients/src/main/java/org/apache/kafka/common/security/oauthbearer/internals/secured/DefaultJwtRetriever.java: ## @@ -86,6 +90,18 @@ public static AccessTokenRetrie

Re: [PR] MINOR: Improve the `KAFKA_HEAP_OPTS` definition while run `kafka-server-start.bat` Batch [kafka]

2025-05-13 Thread via GitHub
realFranco commented on PR #19703: URL: https://github.com/apache/kafka/pull/19703#issuecomment-2875642047 "The Windows Management Instrumentation Command line (WMIC) was deprecated in 2016." > See: https://techcommunity.microsoft.com/blog/windows-itpro-blog/wmi-command-line-wmic-uti

[jira] [Assigned] (KAFKA-19044) Handle tasks that are not present in the current topology

2025-05-13 Thread Lucas Brutschy (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19044?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lucas Brutschy reassigned KAFKA-19044: -- Assignee: (was: Lucas Brutschy) > Handle tasks that are not present in the curren

Re: [PR] KAFKA-19273:Ensure the delete policy is configured when the tiered storage is enabled [kafka]

2025-05-13 Thread via GitHub
gongxuanzhang commented on code in PR #19702: URL: https://github.com/apache/kafka/pull/19702#discussion_r2086325914 ## core/src/test/scala/unit/kafka/log/LogConfigTest.scala: ## @@ -297,25 +297,23 @@ class LogConfigTest { } @Test - def testEnableRemoteLogStorageOnCompa

[jira] [Resolved] (KAFKA-19245) Update defaults for preview of queues configurations

2025-05-13 Thread Andrew Schofield (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19245?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Schofield resolved KAFKA-19245. -- Resolution: Fixed > Update defaults for preview of queues configurations > ---

[jira] [Commented] (KAFKA-17541) Improve handling of delivery count

2025-05-13 Thread Andrew Schofield (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17951186#comment-17951186 ] Andrew Schofield commented on KAFKA-17541: -- [~isding_l] I agree that case 2 wil

Re: [PR] KAFKA-19042: [8/N] Move BaseConsumerTest, SaslPlainPlaintextConsumerTest to client-integration-tests module [kafka]

2025-05-13 Thread via GitHub
m1a2st commented on code in PR #19651: URL: https://github.com/apache/kafka/pull/19651#discussion_r2086737025 ## clients/clients-integration-tests/src/test/java/org/apache/kafka/clients/consumer/ShareConsumerTest.java: ## @@ -2994,35 +2992,4 @@ private void waitForAssignment(Str

Re: [PR] MINOR: Minor updates to RangeSet [kafka]

2025-05-13 Thread via GitHub
squah-confluent commented on code in PR #19678: URL: https://github.com/apache/kafka/pull/19678#discussion_r2086677598 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/RangeSet.java: ## @@ -176,8 +185,18 @@ public boolean equals(Object o) { @

Re: [PR] changed the default value of metadata_quorum in test methods to quorum.isolted_kraft where quorum.zk was used [kafka]

2025-05-13 Thread via GitHub
AndrewJSchofield commented on code in PR #19707: URL: https://github.com/apache/kafka/pull/19707#discussion_r2086734036 ## tests/kafkatest/tests/client/share_consumer_test.py: ## @@ -248,7 +248,7 @@ def test_broker_failure(self, clean_shutdown, metadata_quorum=quorum.isolated_k

Re: [PR] KAFKA-19245: Updated default locks config for share group [kafka]

2025-05-13 Thread via GitHub
AndrewJSchofield merged PR #19705: URL: https://github.com/apache/kafka/pull/19705 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafk

Re: [PR] KAFKA-19269: `Unexpected error ..` should not happen when the delete.topic.enable is false [kafka]

2025-05-13 Thread via GitHub
xijiu commented on PR #19698: URL: https://github.com/apache/kafka/pull/19698#issuecomment-2876427443 @chia7712 Yeah, it's more appropriate to do it this way. I have fixed it, PTAL -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] MINOR: Move logDirs config out of KafkaConfig [kafka]

2025-05-13 Thread via GitHub
chia7712 commented on PR #19579: URL: https://github.com/apache/kafka/pull/19579#issuecomment-2875378086 @Yunyung please fix the conflicts -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

Re: [PR] KAFKA-19080 The constraint on segment.ms is not enforced at topic level [kafka]

2025-05-13 Thread via GitHub
chia7712 commented on code in PR #19371: URL: https://github.com/apache/kafka/pull/19371#discussion_r2086165049 ## raft/src/main/java/org/apache/kafka/raft/MetadataLogConfig.java: ## @@ -85,14 +82,13 @@ public class MetadataLogConfig { .define(METADATA_SNAPSHOT_MAX_

[jira] [Created] (KAFKA-19275) client-state and thread-state metrics are always ""Unavailable"

2025-05-13 Thread Luke Chen (Jira)
Luke Chen created KAFKA-19275: - Summary: client-state and thread-state metrics are always ""Unavailable" Key: KAFKA-19275 URL: https://issues.apache.org/jira/browse/KAFKA-19275 Project: Kafka Is

Re: [PR] MINOR: Add deprecation warning for `log.cleaner.enable` when disabled [kafka]

2025-05-13 Thread via GitHub
Mirai1129 commented on PR #19674: URL: https://github.com/apache/kafka/pull/19674#issuecomment-2875325167 @chia7712 Thanks for the suggestion! I've added the warning for new limit. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitH

Re: [PR] KAFKA-19202: Enable KIP-1071 in streams_eos_test [kafka]

2025-05-13 Thread via GitHub
lucasbru commented on PR #19700: URL: https://github.com/apache/kafka/pull/19700#issuecomment-2875447773 PTAL @aliehsaeedii -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[jira] [Commented] (KAFKA-19275) client-state and thread-state metrics are always ""Unavailable"

2025-05-13 Thread Kuan Po Tseng (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17951121#comment-17951121 ] Kuan Po Tseng commented on KAFKA-19275: --- Hi [~showuon] , I'm willing to take over

[jira] [Commented] (KAFKA-19275) client-state and thread-state metrics are always ""Unavailable"

2025-05-13 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17951122#comment-17951122 ] Luke Chen commented on KAFKA-19275: --- Setting it as a 4.0.1/4.1.0 blocker since these m

[jira] [Assigned] (KAFKA-19275) client-state and thread-state metrics are always ""Unavailable"

2025-05-13 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19275?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Luke Chen reassigned KAFKA-19275: - Assignee: Kuan Po Tseng (was: Luke Chen) > client-state and thread-state metrics are always ""

[jira] [Updated] (KAFKA-19275) client-state and thread-state metrics are always ""Unavailable"

2025-05-13 Thread Luke Chen (Jira)

[jira] [Updated] (KAFKA-19275) client-state and thread-state metrics are always ""Unavailable"

2025-05-13 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19275?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Luke Chen updated KAFKA-19275: -- Priority: Blocker (was: Major) > client-state and thread-state metrics are always ""Unavailable" > --

Re: [PR] MINOR: Minor updates to RangeSet [kafka]

2025-05-13 Thread via GitHub
squah-confluent commented on code in PR #19678: URL: https://github.com/apache/kafka/pull/19678#discussion_r2086650043 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/assignor/RangeSetTest.java: ## @@ -32,16 +32,30 @@ public class RangeSetTest { +@

Re: [PR] MINOR: Minor updates to RangeSet [kafka]

2025-05-13 Thread via GitHub
squah-confluent commented on PR #19678: URL: https://github.com/apache/kafka/pull/19678#issuecomment-2876233084 @FrankYang0529 We don't create ranges like that anywhere right now. I think it's easy to do by accident when working with ranges in general. I had a look around at what other rang

Re: [PR] KAFKA-18688: Fix uniform homogeneous assignor stability [kafka]

2025-05-13 Thread via GitHub
dajac commented on code in PR #19677: URL: https://github.com/apache/kafka/pull/19677#discussion_r2086645708 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/UniformHomogeneousAssignmentBuilder.java: ## @@ -152,8 +152,13 @@ public GroupAssignment bu

Re: [PR] KAFKA-18688: Fix uniform homogeneous assignor stability [kafka]

2025-05-13 Thread via GitHub
squah-confluent commented on code in PR #19677: URL: https://github.com/apache/kafka/pull/19677#discussion_r2086658896 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/UniformHomogeneousAssignmentBuilder.java: ## @@ -152,8 +152,13 @@ public GroupAss

Re: [PR] KAFKA-18688: Fix uniform homogeneous assignor stability [kafka]

2025-05-13 Thread via GitHub
squah-confluent commented on code in PR #19677: URL: https://github.com/apache/kafka/pull/19677#discussion_r2086658896 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/UniformHomogeneousAssignmentBuilder.java: ## @@ -152,8 +152,13 @@ public GroupAss

Re: [PR] MINOR: Minor updates to RangeSet [kafka]

2025-05-13 Thread via GitHub
FrankYang0529 commented on code in PR #19678: URL: https://github.com/apache/kafka/pull/19678#discussion_r2086663038 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/RangeSet.java: ## @@ -163,6 +171,7 @@ public boolean equals(Object o) { if

Re: [PR] KAFKA-18688: Fix uniform homogeneous assignor stability [kafka]

2025-05-13 Thread via GitHub
dajac commented on code in PR #19677: URL: https://github.com/apache/kafka/pull/19677#discussion_r2086647061 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/UniformHomogeneousAssignmentBuilder.java: ## @@ -218,6 +234,15 @@ private void maybeRevokeP

Re: [PR] KAFKA-19141; Persist topic id in OffsetCommit record [kafka]

2025-05-13 Thread via GitHub
dajac commented on code in PR #19683: URL: https://github.com/apache/kafka/pull/19683#discussion_r2086668181 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/OffsetAndMetadataTest.java: ## @@ -16,52 +16,69 @@ */ package org.apache.kafka.coordinator.group;

Re: [PR] KAFKA-19271: Add internal ConsumerWrapper [kafka]

2025-05-13 Thread via GitHub
lucasbru commented on PR #19697: URL: https://github.com/apache/kafka/pull/19697#issuecomment-2876257325 You could consider enabling `KafkaStreamsTelemetryIntegrationTest` with the new wrapper for the new protocol to actually test that your changes work. Wdyt? -- This is an automated mess

Re: [PR] KAFKA-19163: Avoid deleting groups with pending transactional offsets [kafka]

2025-05-13 Thread via GitHub
dajac commented on PR #19496: URL: https://github.com/apache/kafka/pull/19496#issuecomment-2876257768 Merged to trunk and 4.0. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

Re: [PR] KAFKA-19163: Avoid deleting groups with pending transactional offsets [kafka]

2025-05-13 Thread via GitHub
dajac merged PR #19496: URL: https://github.com/apache/kafka/pull/19496 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or

[jira] [Resolved] (KAFKA-19163) New group coordinator can incorrectly delete groups with pending transactional offsets

2025-05-13 Thread David Jacot (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19163?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Jacot resolved KAFKA-19163. - Fix Version/s: 4.0.1 4.1.0 Resolution: Fixed > New group coordinator c

[PR] changed the default value of metadata_quorum in test methods to quorum.isolted_kraft where quorum.zk was used [kafka]

2025-05-13 Thread via GitHub
chirag-wadhwa5 opened a new pull request, #19707: URL: https://github.com/apache/kafka/pull/19707 There were some tests in share_consumer_test, where the default value of metadata_quorum was quorum.zk. That is change to quorum.isolted_kraft in this PR -- This is an automated message from

[jira] [Commented] (KAFKA-19273) Ensure the delete policy is configured when the tiered storage is enabled

2025-05-13 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17951117#comment-17951117 ] Chia-Ping Tsai commented on KAFKA-19273: code: https://github.com/apache/kafka/

Re: [PR] KAFKA-19253: Improve metadata handling for share version using feature listeners (1/N) [kafka]

2025-05-13 Thread via GitHub
adixitconfluent commented on code in PR #19659: URL: https://github.com/apache/kafka/pull/19659#discussion_r2086477440 ## core/src/main/java/kafka/server/share/SharePartitionManager.java: ## @@ -455,9 +468,12 @@ public ShareFetchContext newContext( Impli

[jira] [Assigned] (KAFKA-17853) Console share consumer is not terminated immediately

2025-05-13 Thread Apoorv Mittal (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17853?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Apoorv Mittal reassigned KAFKA-17853: - Assignee: Shivsundar R (was: Jimmy Wang) > Console share consumer is not terminated im

Re: [PR] KAFKA-19141; Persist topic id in OffsetCommit record [kafka]

2025-05-13 Thread via GitHub
squah-confluent commented on code in PR #19683: URL: https://github.com/apache/kafka/pull/19683#discussion_r2086490152 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/OffsetAndMetadataTest.java: ## @@ -16,52 +16,69 @@ */ package org.apache.kafka.coordina

Re: [PR] KAFKA-19253: Improve metadata handling for share version using feature listeners (1/N) [kafka]

2025-05-13 Thread via GitHub
AndrewJSchofield commented on code in PR #19659: URL: https://github.com/apache/kafka/pull/19659#discussion_r2086341822 ## core/src/main/java/kafka/server/share/SharePartitionManager.java: ## @@ -144,6 +146,11 @@ public class SharePartitionManager implements AutoCloseable {

[jira] [Created] (KAFKA-19276) Trigger rebalance when assignment related configurations are updated

2025-05-13 Thread Lucas Brutschy (Jira)
Lucas Brutschy created KAFKA-19276: -- Summary: Trigger rebalance when assignment related configurations are updated Key: KAFKA-19276 URL: https://issues.apache.org/jira/browse/KAFKA-19276 Project: Kaf

Re: [PR] KAFKA-19253: Improve metadata handling for share version using feature listeners (1/N) [kafka]

2025-05-13 Thread via GitHub
adixitconfluent commented on code in PR #19659: URL: https://github.com/apache/kafka/pull/19659#discussion_r2086372007 ## server/src/main/java/org/apache/kafka/server/share/session/ShareSessionCache.java: ## @@ -90,6 +90,14 @@ public synchronized int size() { return ses

[PR] KAFKA-19246; OffsetFetch API does not return group level errors correctly with version 1 [kafka]

2025-05-13 Thread via GitHub
dajac opened a new pull request, #19704: URL: https://github.com/apache/kafka/pull/19704 The OffsetFetch API does not support top level errors in version 1. Hence, the top level error must be returned at the partition level. Side note: It is a tad annoying that we create error respons

Re: [PR] KAFKA-18688: Fix uniform homogeneous assignor stability [kafka]

2025-05-13 Thread via GitHub
squah-confluent commented on code in PR #19677: URL: https://github.com/apache/kafka/pull/19677#discussion_r2086378831 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/UniformHomogeneousAssignmentBuilder.java: ## @@ -218,6 +234,15 @@ private void ma

Re: [PR] KAFKA-19163: Avoid deleting groups with pending transactional offsets [kafka]

2025-05-13 Thread via GitHub
squah-confluent commented on code in PR #19496: URL: https://github.com/apache/kafka/pull/19496#discussion_r2086375860 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/OffsetMetadataManager.java: ## @@ -1006,7 +1006,7 @@ public boolean cleanupExpiredOffsets(

Re: [PR] MINOR: Add JmxReporter note to metric.reporters [kafka]

2025-05-13 Thread via GitHub
fvaleri commented on PR #19706: URL: https://github.com/apache/kafka/pull/19706#issuecomment-2875838111 cc @mimaison -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

[PR] MINOR: Add JmxReporter note to metric.reporters [kafka]

2025-05-13 Thread via GitHub
fvaleri opened a new pull request, #19706: URL: https://github.com/apache/kafka/pull/19706 According to KIP-830, in Kafka 4 users currently relying on JmxReporter and that are using additional reporters via metric.reporters will have to include org.apache.kafka.common.metrics.JmxReporter in

[jira] [Commented] (KAFKA-17541) Improve handling of delivery count

2025-05-13 Thread Apoorv Mittal (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17951151#comment-17951151 ] Apoorv Mittal commented on KAFKA-17541: --- [~isding_l] May be KAFKA-19020 can be hel

Re: [PR] KAFKA-17747: [2/N] Add compute topic and group hash [kafka]

2025-05-13 Thread via GitHub
FrankYang0529 commented on code in PR #19523: URL: https://github.com/apache/kafka/pull/19523#discussion_r2087037433 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/UtilsTest.java: ## @@ -0,0 +1,207 @@ +/* + * Licensed to the Apache Software Foundation (ASF

Re: [PR] KAFKA-17747: [2/N] Add compute topic and group hash [kafka]

2025-05-13 Thread via GitHub
FrankYang0529 commented on code in PR #19523: URL: https://github.com/apache/kafka/pull/19523#discussion_r2087031341 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/Utils.java: ## @@ -324,4 +329,84 @@ static void throwIfRegularExpressionIsInvalid(

Re: [PR] KAFKA-18688: Fix uniform homogeneous assignor stability [kafka]

2025-05-13 Thread via GitHub
dajac merged PR #19677: URL: https://github.com/apache/kafka/pull/19677 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or

[jira] [Resolved] (KAFKA-18688) Uniform homogeneous assignment is not always stable

2025-05-13 Thread David Jacot (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18688?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Jacot resolved KAFKA-18688. - Fix Version/s: 4.0.1 4.1.0 Resolution: Fixed > Uniform homogeneous ass

Re: [PR] KAFKA-17747: [2/N] Add compute topic and group hash [kafka]

2025-05-13 Thread via GitHub
FrankYang0529 commented on code in PR #19523: URL: https://github.com/apache/kafka/pull/19523#discussion_r2087024185 ## build.gradle: ## @@ -1414,10 +1414,12 @@ project(':group-coordinator') { implementation project(':coordinator-common') implementation libs.jacksonDat

Re: [PR] KAFKA-18688: Fix uniform homogeneous assignor stability [kafka]

2025-05-13 Thread via GitHub
dajac commented on PR #19677: URL: https://github.com/apache/kafka/pull/19677#issuecomment-2876898370 Merged to trunk and 4.0. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

Re: [PR] MINOR: Improve client error messages for share groups not enabled [kafka]

2025-05-13 Thread via GitHub
AndrewJSchofield merged PR #19688: URL: https://github.com/apache/kafka/pull/19688 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafk

[PR] KAFKA-19245: Updated default locks config for share group [kafka]

2025-05-13 Thread via GitHub
apoorvmittal10 opened a new pull request, #19705: URL: https://github.com/apache/kafka/pull/19705 Updated default locks config for share groups from 200 to 2000. The increase in the limit is a result from tests which showed that with default maxFetchRecords of 500 from client and 200 as loc

Re: [PR] KAFKA-19231-1: Handle fetch request when share session cache is full [kafka]

2025-05-13 Thread via GitHub
AndrewJSchofield commented on code in PR #19701: URL: https://github.com/apache/kafka/pull/19701#discussion_r2086392228 ## core/src/main/java/kafka/server/share/IdleShareFetchTimeTask.java: ## @@ -0,0 +1,39 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or

Re: [PR] KAFKA-19163: Avoid deleting groups with pending transactional offsets [kafka]

2025-05-13 Thread via GitHub
dajac commented on code in PR #19496: URL: https://github.com/apache/kafka/pull/19496#discussion_r2086237767 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/OffsetMetadataManager.java: ## @@ -1006,7 +1006,7 @@ public boolean cleanupExpiredOffsets(String gro

Re: [PR] KAFKA-19273:Ensure the delete policy is configured when the tiered storage is enabled [kafka]

2025-05-13 Thread via GitHub
gongxuanzhang commented on code in PR #19702: URL: https://github.com/apache/kafka/pull/19702#discussion_r2086284493 ## storage/src/main/java/org/apache/kafka/storage/internals/log/LogConfig.java: ## @@ -561,10 +561,11 @@ public static void validateRemoteStorageOnlyIfSystemEnab

[PR] MINOR: Improve the `KAFKA_HEAP_OPTS` definition while run `kafka-server-start.bat` Batch [kafka]

2025-05-13 Thread via GitHub
realFranco opened a new pull request, #19703: URL: https://github.com/apache/kafka/pull/19703 ## Info - Remove the `wmic` dependency while run `kafka-server-start.bat` script in order to defined the `KAFKA_HEAP_OPTS` if is not previously defined. ## Why - If the host mac

Re: [PR] KAFKA-19273:Ensure the delete policy is configured when the tiered storage is enabled [kafka]

2025-05-13 Thread via GitHub
FrankYang0529 commented on code in PR #19702: URL: https://github.com/apache/kafka/pull/19702#discussion_r2086303900 ## core/src/test/scala/unit/kafka/log/LogConfigTest.scala: ## @@ -297,25 +297,23 @@ class LogConfigTest { } @Test - def testEnableRemoteLogStorageOnCompa

[jira] [Resolved] (KAFKA-14691) Add TopicId to OffsetFetch API

2025-05-13 Thread David Jacot (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14691?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Jacot resolved KAFKA-14691. - Fix Version/s: 4.1.0 Resolution: Fixed > Add TopicId to OffsetFetch API > ---

Re: [PR] KAFKA-18847: Refactor OAuth layer to improve reusability 1/N [kafka]

2025-05-13 Thread via GitHub
lianetm commented on code in PR #19622: URL: https://github.com/apache/kafka/pull/19622#discussion_r2086793268 ## clients/src/test/java/org/apache/kafka/common/security/oauthbearer/OAuthBearerValidatorCallbackHandlerTest.java: ## @@ -106,11 +109,13 @@ public OAuthBearerToken val

Re: [PR] KAFKA-14691; Add TopicId to OffsetFetch API [kafka]

2025-05-13 Thread via GitHub
dajac merged PR #19515: URL: https://github.com/apache/kafka/pull/19515 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or

Re: [PR] MINOR: Minor updates to RangeSet [kafka]

2025-05-13 Thread via GitHub
squah-confluent commented on code in PR #19678: URL: https://github.com/apache/kafka/pull/19678#discussion_r2086649161 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/RangeSet.java: ## @@ -44,6 +44,7 @@ public RangeSet(int from, int to) { @O

Re: [PR] KAFKA-17747: [3/N] Get rid of TopicMetadata in SubscribedTopicDescriberImpl [kafka]

2025-05-13 Thread via GitHub
dajac commented on PR #19611: URL: https://github.com/apache/kafka/pull/19611#issuecomment-2876345298 @FrankYang0529 Thanks for the results. Have you also tried to run `ServerSideAssignorBenchmark`? -- This is an automated message from the Apache Git Service. To respond to the message, pl

Re: [PR] KAFKA-19201: Handle deletion of user topics part of share partitions. [kafka]

2025-05-13 Thread via GitHub
AndrewJSchofield merged PR #19559: URL: https://github.com/apache/kafka/pull/19559 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafk

Re: [PR] KAFKA-19201: Handle deletion of user topics part of share partitions. [kafka]

2025-05-13 Thread via GitHub
AndrewJSchofield commented on code in PR #19559: URL: https://github.com/apache/kafka/pull/19559#discussion_r2086801802 ## share-coordinator/src/main/java/org/apache/kafka/coordinator/share/ShareCoordinator.java: ## @@ -120,6 +124,14 @@ public interface ShareCoordinator {

[jira] [Resolved] (KAFKA-19201) Handle deletion of a topic which has initialised share-group state

2025-05-13 Thread Andrew Schofield (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19201?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Schofield resolved KAFKA-19201. -- Fix Version/s: 4.1.0 Resolution: Fixed > Handle deletion of a topic which has i

[jira] [Assigned] (KAFKA-15603) kafka-dump-log --offsets-decoder should handle parsing errors

2025-05-13 Thread David Jacot (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15603?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Jacot reassigned KAFKA-15603: --- Assignee: David Jacot > kafka-dump-log --offsets-decoder should handle parsing errors > ---

[PR] KAFKA-19273:Ensure the delete policy is configured when the tiered storage is enabled [kafka]

2025-05-13 Thread via GitHub
gongxuanzhang opened a new pull request, #19702: URL: https://github.com/apache/kafka/pull/19702 We updated the validation rule for cleanup.policy in remote storage mode. If remote log storage is enabled, only cleanup.policy=delete is allowed. Any other value (e.g. compact, compact,

[PR] KAFKA-19231-1: Handle fetch request when share session cache is full [kafka]

2025-05-13 Thread via GitHub
chirag-wadhwa5 opened a new pull request, #19701: URL: https://github.com/apache/kafka/pull/19701 According to the recent changes in KIP-932, when the share session cache is full and a broker receives a Share Fetch request with Initial Share Session Epoch (0), then the error code `SHARE_SES

Re: [PR] KAFKA-18688: Fix uniform homogeneous assignor stability [kafka]

2025-05-13 Thread via GitHub
dajac commented on code in PR #19677: URL: https://github.com/apache/kafka/pull/19677#discussion_r2086234212 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/UniformHomogeneousAssignmentBuilder.java: ## @@ -218,6 +234,15 @@ private void maybeRevokeP

Re: [PR] KAFKA-19273:Ensure the delete policy is configured when the tiered storage is enabled [kafka]

2025-05-13 Thread via GitHub
m1a2st commented on code in PR #19702: URL: https://github.com/apache/kafka/pull/19702#discussion_r2086240542 ## storage/src/main/java/org/apache/kafka/storage/internals/log/LogConfig.java: ## @@ -561,10 +561,11 @@ public static void validateRemoteStorageOnlyIfSystemEnabled(Map

[jira] [Updated] (KAFKA-19274) Group Coordinator Shards are not unloaded when __consumer_offsets topic is deleted

2025-05-13 Thread David Jacot (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19274?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Jacot updated KAFKA-19274: Description: Group Coordinator Shards are not unloaded when __consumer_offsets topic is deleted.

Re: [PR] KAFKA-19202: Enable KIP-1071 in streams_eos_test [kafka]

2025-05-13 Thread via GitHub
lucasbru commented on PR #19700: URL: https://github.com/apache/kafka/pull/19700#issuecomment-2875378248 https://confluent-open-source-kafka-branch-builder-system-test-results.s3-us-west-2.amazonaws.com/trunk/2025-05-13--001.379bfb45-6a61-474b-b813-9e1dcda4af95--1747120811--lucasbru--system_

Re: [PR] KAFKA-19202: Enable KIP-1071 in streams_eos_test [kafka]

2025-05-13 Thread via GitHub
lucasbru commented on code in PR #19700: URL: https://github.com/apache/kafka/pull/19700#discussion_r2086136979 ## tests/kafkatest/tests/streams/streams_eos_test.py: ## @@ -149,15 +160,26 @@ def stop_streams2(self, keep_alive_processor, processor_to_be_stopped): def stop

Re: [PR] KAFKA-19145: Move LeaderEndPoint to Server module [kafka]

2025-05-13 Thread via GitHub
chia7712 commented on code in PR #19630: URL: https://github.com/apache/kafka/pull/19630#discussion_r2086120127 ## core/src/test/scala/unit/kafka/server/MockLeaderEndPoint.scala: ## @@ -136,39 +135,41 @@ class MockLeaderEndPoint(sourceBroker: BrokerEndPoint = new BrokerEndPoint

Re: [PR] KAFKA-19202: Enable KIP-1071 in streams_eos_test [kafka]

2025-05-13 Thread via GitHub
lucasbru commented on code in PR #19700: URL: https://github.com/apache/kafka/pull/19700#discussion_r2086131418 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/streams/topics/ConfiguredSubtopology.java: ## @@ -53,9 +54,11 @@ public StreamsGroupDescribeRespo

Re: [PR] KAFKA-19271: Add internal ConsumerWrapper [kafka]

2025-05-13 Thread via GitHub
lucasbru commented on code in PR #19697: URL: https://github.com/apache/kafka/pull/19697#discussion_r2086150911 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamThread.java: ## @@ -550,12 +551,16 @@ private static MainConsumerSetup setupMainConsumer(fi

Re: [PR] KAFKA-19246; OffsetFetch API does not return group level errors correctly with version 1 [kafka]

2025-05-13 Thread via GitHub
squah-confluent commented on code in PR #19704: URL: https://github.com/apache/kafka/pull/19704#discussion_r2086497841 ## clients/src/main/java/org/apache/kafka/common/requests/OffsetFetchResponse.java: ## @@ -239,4 +240,31 @@ public OffsetFetchResponseData data() { public

Re: [PR] MINOR: Fix some Request toString methods (#19655) [kafka]

2025-05-13 Thread via GitHub
ahuang98 commented on PR #19692: URL: https://github.com/apache/kafka/pull/19692#issuecomment-2877132412 hm, build was "successful" but still marked unstable ``` BUILD SUCCESSFUL in 3h 42m 34s ``` -- This is an automated message from the Apache Git Service. To respond to the messa

Re: [PR] KAFKA-19234: broker should return UNAUTHORIZATION error for non-existing topic in produce request [kafka]

2025-05-13 Thread via GitHub
junrao commented on code in PR #19635: URL: https://github.com/apache/kafka/pull/19635#discussion_r2087319995 ## core/src/test/scala/integration/kafka/api/AuthorizerIntegrationTest.scala: ## @@ -921,8 +923,76 @@ class AuthorizerIntegrationTest extends AbstractAuthorizerIntegrat

[jira] [Assigned] (KAFKA-15891) Flaky test: testResetSinkConnectorOffsetsOverriddenConsumerGroupId – org.apache.kafka.connect.integration.OffsetsApiIntegrationTest

2025-05-13 Thread Will Perlichek (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15891?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Will Perlichek reassigned KAFKA-15891: -- Assignee: (was: Will Perlichek) > Flaky test: testResetSinkConnectorOffsetsOverri

  1   2   >