Re: [PR] KAFKA-18877: Add an mechanism to find cases where we accessed variables from the wrong thread. [kafka]

2025-05-04 Thread via GitHub
github-actions[bot] commented on PR #19231: URL: https://github.com/apache/kafka/pull/19231#issuecomment-2849816968 A label of 'needs-attention' was automatically added to this PR in order to raise the attention of the committers. Once this issue has been triaged, the `triage` label s

Re: [PR] KAFKA-18379: Enforce resigned cannot transition to any other state in same epoch [kafka]

2025-05-04 Thread via GitHub
github-actions[bot] commented on PR #19236: URL: https://github.com/apache/kafka/pull/19236#issuecomment-2849816937 A label of 'needs-attention' was automatically added to this PR in order to raise the attention of the committers. Once this issue has been triaged, the `triage` label s

Re: [PR] KAFKA-15283:[1/N] Client support for OffsetCommit with topic ID [kafka]

2025-05-04 Thread via GitHub
github-actions[bot] commented on PR #19577: URL: https://github.com/apache/kafka/pull/19577#issuecomment-2849816747 A label of 'needs-attention' was automatically added to this PR in order to raise the attention of the committers. Once this issue has been triaged, the `triage` label s

Re: [PR] KAFKA-18171: Unexpected Change in bootstrap.servers Behavior After Upgrade to 3.8.0 [kafka]

2025-05-04 Thread via GitHub
github-actions[bot] commented on PR #18706: URL: https://github.com/apache/kafka/pull/18706#issuecomment-2849817080 A label of 'needs-attention' was automatically added to this PR in order to raise the attention of the committers. Once this issue has been triaged, the `triage` label s

Re: [PR] KAFKA-19170 Move MetricsDuringTopicCreationDeletionTest to client-integration-tests module [kafka]

2025-05-04 Thread via GitHub
chia7712 commented on code in PR #19528: URL: https://github.com/apache/kafka/pull/19528#discussion_r2072809651 ## clients/clients-integration-tests/src/test/java/org/apache/kafka/clients/MetricsDuringTopicCreationDeletionTest.java: ## @@ -0,0 +1,144 @@ +/* + * Licensed to the A

Re: [PR] KAFKA-15556: Remove NetworkClientDelegate methods isUnavailable, maybeThrowAuthFailure, and tryConnect [kafka]

2025-05-04 Thread via GitHub
github-actions[bot] commented on PR #15020: URL: https://github.com/apache/kafka/pull/15020#issuecomment-2849834994 This PR has been closed since it has not had any activity in 120 days. If you feel like this was a mistake, or you would like to continue working on it, please feel free to

Re: [PR] [DO NOT MERGE] KAFKA-14419: limit time spent processing during ongoing rebalance and delay followup rebalance trigger [kafka]

2025-05-04 Thread via GitHub
github-actions[bot] commented on PR #15009: URL: https://github.com/apache/kafka/pull/15009#issuecomment-2849834960 This PR has been closed since it has not had any activity in 120 days. If you feel like this was a mistake, or you would like to continue working on it, please feel free to

Re: [PR] KAFKA-16599: LegacyConsumer should always await pending async commits on commitSync and close [kafka]

2025-05-04 Thread via GitHub
github-actions[bot] commented on PR #15693: URL: https://github.com/apache/kafka/pull/15693#issuecomment-2849835037 This PR has been closed since it has not had any activity in 120 days. If you feel like this was a mistake, or you would like to continue working on it, please feel free to

Re: [PR] KAFKA-16599: LegacyConsumer should always await pending async commits on commitSync and close [kafka]

2025-05-04 Thread via GitHub
github-actions[bot] closed pull request #15693: KAFKA-16599: LegacyConsumer should always await pending async commits on commitSync and close URL: https://github.com/apache/kafka/pull/15693 -- This is an automated message from the Apache Git Service. To respond to the message, please log on t

Re: [PR] KAFKA-16710:Continuously `makeFollower` may cause the replica fetcher thread to encounter an offset mismatch exception [kafka]

2025-05-04 Thread via GitHub
github-actions[bot] closed pull request #15929: KAFKA-16710:Continuously `makeFollower` may cause the replica fetcher thread to encounter an offset mismatch exception URL: https://github.com/apache/kafka/pull/15929 -- This is an automated message from the Apache Git Service. To respond to th

Re: [PR] KAFKA-16902: Consider socket timeout in blocking Sender waits [kafka]

2025-05-04 Thread via GitHub
github-actions[bot] commented on PR #16220: URL: https://github.com/apache/kafka/pull/16220#issuecomment-2849835136 This PR has been closed since it has not had any activity in 120 days. If you feel like this was a mistake, or you would like to continue working on it, please feel free to

Re: [PR] KAFKA-18299: Move connect data classes into a dedicated module [kafka]

2025-05-04 Thread via GitHub
github-actions[bot] commented on PR #18256: URL: https://github.com/apache/kafka/pull/18256#issuecomment-2849835238 This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please leave a comment asking for a review. If the P

Re: [PR] KIP-966 unclean recovery elect leader request [kafka]

2025-05-04 Thread via GitHub
github-actions[bot] commented on PR #15876: URL: https://github.com/apache/kafka/pull/15876#issuecomment-2849835065 This PR has been closed since it has not had any activity in 120 days. If you feel like this was a mistake, or you would like to continue working on it, please feel free to

Re: [PR] Code optimization: Supplement the missing Override tag on the override method [kafka]

2025-05-04 Thread via GitHub
github-actions[bot] commented on PR #11399: URL: https://github.com/apache/kafka/pull/11399#issuecomment-2849834922 This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please leave a comment asking for a review. If the P

Re: [PR] KIP-966 unclean recovery elect leader request [kafka]

2025-05-04 Thread via GitHub
github-actions[bot] closed pull request #15876: KIP-966 unclean recovery elect leader request URL: https://github.com/apache/kafka/pull/15876 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

Re: [PR] [DO NOT MERGE] KAFKA-14419: limit time spent processing during ongoing rebalance and delay followup rebalance trigger [kafka]

2025-05-04 Thread via GitHub
github-actions[bot] closed pull request #15009: [DO NOT MERGE] KAFKA-14419: limit time spent processing during ongoing rebalance and delay followup rebalance trigger URL: https://github.com/apache/kafka/pull/15009 -- This is an automated message from the Apache Git Service. To respond to the

Re: [PR] KAFKA-15556: Remove NetworkClientDelegate methods isUnavailable, maybeThrowAuthFailure, and tryConnect [kafka]

2025-05-04 Thread via GitHub
github-actions[bot] closed pull request #15020: KAFKA-15556: Remove NetworkClientDelegate methods isUnavailable, maybeThrowAuthFailure, and tryConnect URL: https://github.com/apache/kafka/pull/15020 -- This is an automated message from the Apache Git Service. To respond to the message, pleas

Re: [PR] KAFKA-14588 ConfigCommand rewritten to java [kafka]

2025-05-04 Thread via GitHub
github-actions[bot] commented on PR #15417: URL: https://github.com/apache/kafka/pull/15417#issuecomment-2849835009 This PR has been closed since it has not had any activity in 120 days. If you feel like this was a mistake, or you would like to continue working on it, please feel free to

Re: [PR] KAFKA-14588 ConfigCommand rewritten to java [kafka]

2025-05-04 Thread via GitHub
github-actions[bot] closed pull request #15417: KAFKA-14588 ConfigCommand rewritten to java URL: https://github.com/apache/kafka/pull/15417 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

Re: [PR] KAFKA-16902: Consider socket timeout in blocking Sender waits [kafka]

2025-05-04 Thread via GitHub
github-actions[bot] closed pull request #16220: KAFKA-16902: Consider socket timeout in blocking Sender waits URL: https://github.com/apache/kafka/pull/16220 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

Re: [PR] KAFKA-16710:Continuously `makeFollower` may cause the replica fetcher thread to encounter an offset mismatch exception [kafka]

2025-05-04 Thread via GitHub
github-actions[bot] commented on PR #15929: URL: https://github.com/apache/kafka/pull/15929#issuecomment-2849835096 This PR has been closed since it has not had any activity in 120 days. If you feel like this was a mistake, or you would like to continue working on it, please feel free to

[jira] [Commented] (KAFKA-19236) Auto.offset.reset "by-duration" should reset a single time

2025-05-04 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17949302#comment-17949302 ] Matthias J. Sax commented on KAFKA-19236: - Don't think it's very common. Still w

[jira] [Comment Edited] (KAFKA-19236) Auto.offset.reset "by-duration" should reset a single time

2025-05-04 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17949302#comment-17949302 ] Matthias J. Sax edited comment on KAFKA-19236 at 5/4/25 5:24 PM: -

Re: [PR] KAFKA-19201: Handle deletion of user topics part of share partitions. [kafka]

2025-05-04 Thread via GitHub
smjn commented on PR #19559: URL: https://github.com/apache/kafka/pull/19559#issuecomment-2849331314 ## Sample o/p ### Before delete GC ``` ... {"key":{"type":15,"data":{"groupId":"gs1"}},"value":{"version":0,"data":{"initializingTopics":[{"topicId":"JODDF-6xQUKfY9Xvw

[jira] [Commented] (KAFKA-15335) Support custom SSL configuration for Kafka Connect RestServer

2025-05-04 Thread Kunal Sevkani (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17949307#comment-17949307 ] Kunal Sevkani commented on KAFKA-15335: --- Hi [~tledkov]  Are you working on this? I

Re: [PR] KAFKA-19170 Move MetricsDuringTopicCreationDeletionTest to client-integration-tests module [kafka]

2025-05-04 Thread via GitHub
m1a2st commented on code in PR #19528: URL: https://github.com/apache/kafka/pull/19528#discussion_r2072756852 ## clients/clients-integration-tests/src/test/java/org/apache/kafka/clients/MetricsDuringTopicCreationDeletionTest.java: ## @@ -0,0 +1,148 @@ +/* + * Licensed to the Apa

Re: [PR] KAFKA-19170 Move MetricsDuringTopicCreationDeletionTest to client-integration-tests module [kafka]

2025-05-04 Thread via GitHub
yunchipang commented on code in PR #19528: URL: https://github.com/apache/kafka/pull/19528#discussion_r2072759555 ## clients/clients-integration-tests/src/test/java/org/apache/kafka/clients/MetricsDuringTopicCreationDeletionTest.java: ## @@ -0,0 +1,148 @@ +/* + * Licensed to the

Re: [PR] KAFKA-19170 Move MetricsDuringTopicCreationDeletionTest to client-integration-tests module [kafka]

2025-05-04 Thread via GitHub
m1a2st commented on code in PR #19528: URL: https://github.com/apache/kafka/pull/19528#discussion_r2072760301 ## clients/clients-integration-tests/src/test/java/org/apache/kafka/clients/MetricsDuringTopicCreationDeletionTest.java: ## @@ -0,0 +1,148 @@ +/* + * Licensed to the Apa

[jira] [Commented] (KAFKA-17019) Producer TimeoutException should include root cause

2025-05-04 Thread sanghyeok An (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17019?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17949362#comment-17949362 ] sanghyeok An commented on KAFKA-17019: -- Hi, [~mjsax] ! I take a look into producer

Re: [PR] MINOR: Fix commit bugs caused by race condition during rebalancing. [kafka]

2025-05-04 Thread via GitHub
chickenchickenlove commented on PR #19631: URL: https://github.com/apache/kafka/pull/19631#issuecomment-2849683316 Hi, @m1a2st sorry to bother you. I reverted previous commit and made an new one. Because I felt the previous commit wasn’t effective. Currently, I just added only `

[jira] [Commented] (KAFKA-17019) Producer TimeoutException should include root cause

2025-05-04 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17019?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17949363#comment-17949363 ] Matthias J. Sax commented on KAFKA-17019: - {quote}I take a look into producer co

Re: [PR] MINOR: Small cleanups in clients tests [kafka]

2025-05-04 Thread via GitHub
wernerdv commented on code in PR #19634: URL: https://github.com/apache/kafka/pull/19634#discussion_r2072915155 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumerTest.java: ## @@ -1185,14 +1174,14 @@ public void testNoInterceptorCommitAsyncFa

Re: [PR] KAFKA-19234: broker should return UNAUTHORIZATION error for non-exist… [kafka]

2025-05-04 Thread via GitHub
FrankYang0529 commented on PR #19632: URL: https://github.com/apache/kafka/pull/19632#issuecomment-2849214015 @frankvicky I have created a PR for this, could you help me review it? Thanks. https://github.com/apache/kafka/pull/19635 -- This is an automated message from the Apache Gi

[PR] KAFKA-19234: broker should return UNAUTHORIZATION error for non-existing topic in produce request [kafka]

2025-05-04 Thread via GitHub
FrankYang0529 opened a new pull request, #19635: URL: https://github.com/apache/kafka/pull/19635 Since topic name is sensitive information, it should return a TOPIC_AUTHORIZATION_FAILED error for non-existing topic. The Fetch request also follows this pattern. -- This is an automated mes

Re: [PR] KAFKA-19234: broker should return UNAUTHORIZATION error for non-existing topic in produce request [kafka]

2025-05-04 Thread via GitHub
m1a2st commented on code in PR #19635: URL: https://github.com/apache/kafka/pull/19635#discussion_r2072616754 ## core/src/test/scala/unit/kafka/server/KafkaApisTest.scala: ## @@ -2354,6 +2354,65 @@ class KafkaApisTest extends Logging { } } + @Test + def shouldReturnU

Re: [PR] KAFKA-19060 Documented null edge cases in the Clients API JavaDoc [kafka]

2025-05-04 Thread via GitHub
chia7712 merged PR #19393: URL: https://github.com/apache/kafka/pull/19393 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

[jira] [Resolved] (KAFKA-19060) Documented null edge cases in the Clients API JavaDoc

2025-05-04 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19060?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai resolved KAFKA-19060. Fix Version/s: 4.1.0 Resolution: Fixed > Documented null edge cases in the Clients

Re: [PR] KAFKA-19131: Adjust remote storage reader thread maximum pool size to avoid illegal argument [kafka]

2025-05-04 Thread via GitHub
kamalcph merged PR #19629: URL: https://github.com/apache/kafka/pull/19629 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

Re: [PR] MINOR: Fix commit bugs caused by race condition during rebalancing. [kafka]

2025-05-04 Thread via GitHub
chickenchickenlove commented on PR #19631: URL: https://github.com/apache/kafka/pull/19631#issuecomment-2849263268 Hey, @mjsax , @m1a2st . I dug into this problem more deeply. The issue became clearer, so I reverted the previous commit and added a new commit that introduces wider

[PR] Refactored DescribeTopicPartitionsRequestHandler: Improve readability and add code documentation [kafka]

2025-05-04 Thread via GitHub
keemsisi opened a new pull request, #19636: URL: https://github.com/apache/kafka/pull/19636 Refactor DescribeTopicPartitionsRequestHandler: Improve readability and add code documentation ### Changes: * Improved variable naming for better clarity. * Added detailed inline comments

Re: [PR] KAFKA-19234: broker should return UNAUTHORIZATION error for non-exist… [kafka]

2025-05-04 Thread via GitHub
Joker-5 commented on PR #19632: URL: https://github.com/apache/kafka/pull/19632#issuecomment-2849242649 > @frankvicky I have created a PR for this, could you help me review it? Thanks. > > #19635 @FrankYang0529 Sorry, after I created this PR, I noticed you reassign this jira t

Re: [PR] KAFKA - 19145: Move LeaderEndPoint to Server module [kafka]

2025-05-04 Thread via GitHub
YutaLin commented on code in PR #19630: URL: https://github.com/apache/kafka/pull/19630#discussion_r2072663697 ## core/src/test/scala/unit/kafka/server/ReplicaFetcherThreadTest.scala: ## @@ -169,7 +169,7 @@ class ReplicaFetcherThreadTest { .setLeaderEpoch(0), t1p

Re: [PR] KAFKA-19232: Handle Share session limit reached exception in clients. [kafka]

2025-05-04 Thread via GitHub
AndrewJSchofield merged PR #19619: URL: https://github.com/apache/kafka/pull/19619 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafk

Re: [PR] KAFKA-19170 Move MetricsDuringTopicCreationDeletionTest to client-integration-tests module [kafka]

2025-05-04 Thread via GitHub
Yunyung commented on code in PR #19528: URL: https://github.com/apache/kafka/pull/19528#discussion_r2072674264 ## build.gradle: ## @@ -1971,6 +1971,7 @@ project(':clients:clients-integration-tests') { } dependencies { +testImplementation 'com.yammer.metrics:metrics-c

Re: [PR] MINOR: Small cleanups in clients tests [kafka]

2025-05-04 Thread via GitHub
AndrewJSchofield commented on code in PR #19634: URL: https://github.com/apache/kafka/pull/19634#discussion_r2072688367 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumerTest.java: ## @@ -1185,14 +1174,14 @@ public void testNoInterceptorCommi

Re: [PR] MINOR: replace .stream().forEach() with .forEach() [kafka]

2025-05-04 Thread via GitHub
chia7712 merged PR #19626: URL: https://github.com/apache/kafka/pull/19626 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

Re: [PR] KAFKA-19133: Support fetching for multiple remote fetch topic partitions in a single share fetch request [kafka]

2025-05-04 Thread via GitHub
apoorvmittal10 commented on code in PR #19592: URL: https://github.com/apache/kafka/pull/19592#discussion_r2072696298 ## core/src/main/java/kafka/server/share/DelayedShareFetch.java: ## @@ -248,14 +250,18 @@ private void processAcquiredTopicPartitionsForLocalLogFetch(LinkedHash

[jira] [Resolved] (KAFKA-19232) Handle share session limit reached error in clients

2025-05-04 Thread Shivsundar R (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19232?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shivsundar R resolved KAFKA-19232. -- Fix Version/s: 4.1.0 Resolution: Fixed > Handle share session limit reached error in cl

Re: [PR] KAFKA-18537: Fix flaky RemoteIndexCacheTest#testCleanerThreadShutdown [kafka]

2025-05-04 Thread via GitHub
apalan60 commented on code in PR #19628: URL: https://github.com/apache/kafka/pull/19628#discussion_r2072612894 ## storage/src/test/java/org/apache/kafka/storage/internals/log/RemoteIndexCacheTest.java: ## @@ -376,6 +376,8 @@ public void testCleanerThreadShutdown() throws IOExce

Re: [PR] MINOR: Small cleanups in clients tests [kafka]

2025-05-04 Thread via GitHub
wernerdv commented on PR #19634: URL: https://github.com/apache/kafka/pull/19634#issuecomment-2849202838 @AndrewJSchofield @chia7712 Hello, please take a look. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

[jira] [Updated] (KAFKA-19131) Exception thrown while updating the RemoteLogReader threads

2025-05-04 Thread Kamal Chandraprakash (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19131?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kamal Chandraprakash updated KAFKA-19131: - Fix Version/s: 4.0.1 > Exception thrown while updating the RemoteLogReader threa

Re: [PR] KAFKA-19234: broker should return UNAUTHORIZATION error for non-existing topic in produce request [kafka]

2025-05-04 Thread via GitHub
Yunyung commented on code in PR #19635: URL: https://github.com/apache/kafka/pull/19635#discussion_r2072640806 ## core/src/main/scala/kafka/server/KafkaApis.scala: ## @@ -429,6 +427,8 @@ class KafkaApis(val requestChannel: RequestChannel, val memoryRecords = partition.rec

Re: [PR] KAFKA-19170 Move MetricsDuringTopicCreationDeletionTest to client-integration-tests module [kafka]

2025-05-04 Thread via GitHub
Yunyung commented on code in PR #19528: URL: https://github.com/apache/kafka/pull/19528#discussion_r2072678216 ## clients/clients-integration-tests/src/test/java/org/apache/kafka/clients/MetricsDuringTopicCreationDeletionTest.java: ## @@ -0,0 +1,150 @@ +/* + * Licensed to the Ap

Re: [PR] KAFKA-19133: Support fetching for multiple remote fetch topic partitions in a single share fetch request [kafka]

2025-05-04 Thread via GitHub
adixitconfluent commented on code in PR #19592: URL: https://github.com/apache/kafka/pull/19592#discussion_r2072854744 ## core/src/main/java/kafka/server/share/DelayedShareFetch.java: ## @@ -248,14 +250,18 @@ private void processAcquiredTopicPartitionsForLocalLogFetch(LinkedHas

[jira] [Created] (KAFKA-19238) We're facing issue in Kafka while reading data from Azure event hubs through Azure Databricks

2025-05-04 Thread karthickthavasiraj09 (Jira)
karthickthavasiraj09 created KAFKA-19238: Summary: We're facing issue in Kafka while reading data from Azure event hubs through Azure Databricks Key: KAFKA-19238 URL: https://issues.apache.org/jira/browse/

Re: [PR] KAFKA-19133: Support fetching for multiple remote fetch topic partitions in a single share fetch request [kafka]

2025-05-04 Thread via GitHub
adixitconfluent commented on code in PR #19592: URL: https://github.com/apache/kafka/pull/19592#discussion_r2072857215 ## core/src/main/java/kafka/server/share/DelayedShareFetch.java: ## @@ -248,14 +250,18 @@ private void processAcquiredTopicPartitionsForLocalLogFetch(LinkedHas

Re: [PR] KAFKA-19133: Support fetching for multiple remote fetch topic partitions in a single share fetch request [kafka]

2025-05-04 Thread via GitHub
adixitconfluent commented on code in PR #19592: URL: https://github.com/apache/kafka/pull/19592#discussion_r2072857215 ## core/src/main/java/kafka/server/share/DelayedShareFetch.java: ## @@ -248,14 +250,18 @@ private void processAcquiredTopicPartitionsForLocalLogFetch(LinkedHas

[jira] [Commented] (KAFKA-17019) Producer TimeoutException should include root cause

2025-05-04 Thread sanghyeok An (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17019?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17949373#comment-17949373 ] sanghyeok An commented on KAFKA-17019: -- [~mjsax] Thanks for your comments!  Woul

Re: [PR] KAFKA-19133: Support fetching for multiple remote fetch topic partitions in a single share fetch request [kafka]

2025-05-04 Thread via GitHub
adixitconfluent commented on code in PR #19592: URL: https://github.com/apache/kafka/pull/19592#discussion_r2072857215 ## core/src/main/java/kafka/server/share/DelayedShareFetch.java: ## @@ -248,14 +250,18 @@ private void processAcquiredTopicPartitionsForLocalLogFetch(LinkedHas

Re: [PR] KAFKA-19234: broker should return UNAUTHORIZATION error for non-exist… [kafka]

2025-05-04 Thread via GitHub
chia7712 closed pull request #19632: KAFKA-19234: broker should return UNAUTHORIZATION error for non-exist… URL: https://github.com/apache/kafka/pull/19632 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] KAFKA-19234: broker should return UNAUTHORIZATION error for non-exist… [kafka]

2025-05-04 Thread via GitHub
chia7712 commented on PR #19632: URL: https://github.com/apache/kafka/pull/19632#issuecomment-2850023469 @Joker-5 I've added you as a co-author to #19635 (see the description). This will be included when merging the code. Therefore, I'm closing this PR as a duplicate. Thanks! -- This is

Re: [PR] MINOR: improve AdjustStreamThreadCountTest [kafka]

2025-05-04 Thread via GitHub
lucasbru commented on code in PR #19617: URL: https://github.com/apache/kafka/pull/19617#discussion_r2072902337 ## streams/integration-tests/src/test/java/org/apache/kafka/streams/integration/AdjustStreamThreadCountTest.java: ## @@ -239,10 +241,30 @@ public void shouldAddAndRemo

Re: [PR] KAFKA-19234: broker should return UNAUTHORIZATION error for non-existing topic in produce request [kafka]

2025-05-04 Thread via GitHub
chia7712 commented on code in PR #19635: URL: https://github.com/apache/kafka/pull/19635#discussion_r2072903093 ## core/src/test/scala/unit/kafka/server/KafkaApisTest.scala: ## @@ -2354,6 +2354,65 @@ class KafkaApisTest extends Logging { } } + @Test + def shouldRetur

Re: [PR] KAFKA-19232: Handle Share session limit reached exception in clients. [kafka]

2025-05-04 Thread via GitHub
ShivsundarR commented on code in PR #19619: URL: https://github.com/apache/kafka/pull/19619#discussion_r2072539685 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/ShareSessionHandler.java: ## @@ -219,7 +219,8 @@ private String topicIdPartitionsToLogString(C

[jira] [Commented] (KAFKA-19234) broker should return UNAUTHORIZATION error for non-existing topic in produce request

2025-05-04 Thread PoAn Yang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17949252#comment-17949252 ] PoAn Yang commented on KAFKA-19234: --- [~johndoe], I have leaved message and I will hand

[jira] [Assigned] (KAFKA-19234) broker should return UNAUTHORIZATION error for non-existing topic in produce request

2025-05-04 Thread PoAn Yang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19234?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] PoAn Yang reassigned KAFKA-19234: - Assignee: PoAn Yang (was: johndoe) > broker should return UNAUTHORIZATION error for non-existi

[jira] [Assigned] (KAFKA-19234) broker should return UNAUTHORIZATION error for non-existing topic in produce request

2025-05-04 Thread johndoe (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19234?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] johndoe reassigned KAFKA-19234: --- Assignee: johndoe > broker should return UNAUTHORIZATION error for non-existing topic in produce >

[PR] KAFKA-19234: broker should return UNAUTHORIZATION error for non-exist… [kafka]

2025-05-04 Thread via GitHub
Joker-5 opened a new pull request, #19632: URL: https://github.com/apache/kafka/pull/19632 In https://github.com/apache/kafka/pull/15968/files, we changed the authorization logic slightly. If a produce request includes a topic name that doesn't exist and is not authorized, it now returns an

Re: [PR] KAFKA - 19145: Move LeaderEndPoint to Server module [kafka]

2025-05-04 Thread via GitHub
frankvicky commented on code in PR #19630: URL: https://github.com/apache/kafka/pull/19630#discussion_r2072583427 ## core/src/test/scala/unit/kafka/server/ReplicaFetcherThreadTest.scala: ## @@ -169,7 +169,7 @@ class ReplicaFetcherThreadTest { .setLeaderEpoch(0),

Re: [PR] KAFKA-19234: broker should return UNAUTHORIZATION error for non-exist… [kafka]

2025-05-04 Thread via GitHub
frankvicky commented on PR #19632: URL: https://github.com/apache/kafka/pull/19632#issuecomment-2849142905 Hi @Joker-5 I have checked the jira. It seems that you are not the assignee of this ticket. Do you discuss with @FrankYang0529 ? -- This is an automated message from the Apach

[PR] (WIP) KAFKA-18695: Remove quorum=kraft from all integration tests [kafka]

2025-05-04 Thread via GitHub
mingyen066 opened a new pull request, #19633: URL: https://github.com/apache/kafka/pull/19633 Currently, the quorum uses kraft by default, so there's no need to specify it explicitly. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[jira] [Assigned] (KAFKA-19236) Auto.offset.reset "by-duration" should reset a single time

2025-05-04 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19236?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai reassigned KAFKA-19236: -- Assignee: Chia-Ping Tsai > Auto.offset.reset "by-duration" should reset a single time

[jira] [Updated] (KAFKA-19237) add dynamic config remote.log.manager.follower.thread.pool.size

2025-05-04 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19237?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai updated KAFKA-19237: --- Labels: need-kip (was: ) > add dynamic config remote.log.manager.follower.thread.pool.size

[jira] [Created] (KAFKA-19237) add dynamic config remote.log.manager.follower.thread.pool.size

2025-05-04 Thread Chia-Ping Tsai (Jira)
Chia-Ping Tsai created KAFKA-19237: -- Summary: add dynamic config remote.log.manager.follower.thread.pool.size Key: KAFKA-19237 URL: https://issues.apache.org/jira/browse/KAFKA-19237 Project: Kafka

Re: [PR] KAFKA-19060 Documented null edge cases in the Clients API JavaDoc [kafka]

2025-05-04 Thread via GitHub
chia7712 commented on PR #19393: URL: https://github.com/apache/kafka/pull/19393#issuecomment-2849178967 @m1a2st please update PR according to the fix of #19578 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a