Re: [PR] [WIP] KAFKA-19145: Move Leader Endpoint [kafka]

2025-05-03 Thread via GitHub
YutaLin closed pull request #19591: [WIP] KAFKA-19145: Move Leader Endpoint URL: https://github.com/apache/kafka/pull/19591 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To u

[PR] Kafka 19145 [kafka]

2025-05-03 Thread via GitHub
YutaLin opened a new pull request, #19630: URL: https://github.com/apache/kafka/pull/19630 Move LeaderEndPoint to Server module Reviewers: Chia-Ping Tsai [chia7...@gmail.com](mailto:chia7...@gmail.com) -- This is an automated message from the Apache Git Service. To respond to the me

Re: [PR] KAFKA-18185: remove internal.leave.group.on.close config [kafka]

2025-05-03 Thread via GitHub
frankvicky commented on code in PR #19400: URL: https://github.com/apache/kafka/pull/19400#discussion_r2072336376 ## streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java: ## @@ -1645,6 +1606,7 @@ private Consumer streamThreadLeaveConsumerGroup(final long remaini

[jira] [Commented] (KAFKA-19234) broker should return UNAUTHORIZATION error for non-existing topic in produce request

2025-05-03 Thread PoAn Yang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17949155#comment-17949155 ] PoAn Yang commented on KAFKA-19234: --- Hi [~junrao], if you're not working on this, may

Re: [PR] MINOR: Add documentation about KIP-405 remote reads serving just one partition per FetchRequest [kafka]

2025-05-03 Thread via GitHub
kamalcph commented on PR #19336: URL: https://github.com/apache/kafka/pull/19336#issuecomment-2848665989 @stanislavkozlovski Could you address the pending comments in the PR? Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [PR] KAFKA-19131: Adjust remote storage reader thread maximum pool size to avoid illegal argument [kafka]

2025-05-03 Thread via GitHub
kamalcph commented on PR #19629: URL: https://github.com/apache/kafka/pull/19629#issuecomment-2848661760 @chia7712 @satishd Could you review and approve the PR? Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

Re: [PR] KAFKA-6629: parameterise SegmentedCacheFunctionTest for session key schemas [kafka]

2025-05-03 Thread via GitHub
bbejeck commented on code in PR #19404: URL: https://github.com/apache/kafka/pull/19404#discussion_r2072456537 ## streams/src/main/java/org/apache/kafka/streams/state/internals/SessionKeySchema.java: ## @@ -196,4 +196,15 @@ public static void writeBinary(final ByteBuffer buf,

[jira] [Updated] (KAFKA-19174) Gradle version upgrade 8 -->> 9

2025-05-03 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-19174?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dejan Stojadinović updated KAFKA-19174: --- Description: *_Note:_* at the moment Gradle 9 is available as a milestone version on

[jira] [Commented] (KAFKA-19234) broker should return UNAUTHORIZATION error for non-existing topic in produce request

2025-05-03 Thread Jun Rao (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17949165#comment-17949165 ] Jun Rao commented on KAFKA-19234: - [~yangpoan] : Thanks for your interest. Feel free to

[jira] [Resolved] (KAFKA-18267) Add test for CloseOption

2025-05-03 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18267?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai resolved KAFKA-18267. Resolution: Fixed > Add test for CloseOption > > >

Re: [PR] KAFKA-18267: Add unit tests for CloseOptions [kafka]

2025-05-03 Thread via GitHub
chia7712 merged PR #19571: URL: https://github.com/apache/kafka/pull/19571 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

Re: [PR] MINOR: replace .stream().forEach() with .forEach() [kafka]

2025-05-03 Thread via GitHub
chia7712 commented on PR #19626: URL: https://github.com/apache/kafka/pull/19626#issuecomment-2848658620 > Could you please also clean this one? yes, that is a good idea. @yunchipang please fix the pattern `entrySet().forEach` by `forEach` -- This is an automated message from the A

Re: [PR] KAFKA - 19145: Move LeaderEndPoint to Server module [kafka]

2025-05-03 Thread via GitHub
m1a2st commented on code in PR #19630: URL: https://github.com/apache/kafka/pull/19630#discussion_r2072411401 ## server/src/main/java/org/apache/kafka/server/PartitionFetchState.java: ## @@ -0,0 +1,131 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more

Re: [PR] KAFKA-19205: inconsistent result of beginningOffsets/endoffset between classic and async consumer with 0 timeout [kafka]

2025-05-03 Thread via GitHub
lianetm merged PR #19578: URL: https://github.com/apache/kafka/pull/19578 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.

Re: [PR] MINOR: Cleanup Core Module- Scala Modules (1/n) [kafka]

2025-05-03 Thread via GitHub
sjhajharia commented on PR #19380: URL: https://github.com/apache/kafka/pull/19380#issuecomment-2849021834 hey @chia7712 another reminder -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

Re: [PR] KAFKA-19070:: Adding task number to user provided client id to ensure each consumer has a unique client ID to avoid metric registration conflicts. [kafka]

2025-05-03 Thread via GitHub
kumarpritam863 commented on PR #19341: URL: https://github.com/apache/kafka/pull/19341#issuecomment-2849025200 @C0urante can you please review this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

Re: [PR] KAFKA-17218: kafka-consumer-groups should handle describe groups with deleted topics [kafka]

2025-05-03 Thread via GitHub
mingyen066 closed pull request #19029: KAFKA-17218: kafka-consumer-groups should handle describe groups with deleted topics URL: https://github.com/apache/kafka/pull/19029 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use t

[PR] KAFKA-17218: kafka-consumer-groups should handle describe groups with deleted topics [kafka]

2025-05-03 Thread via GitHub
mingyen066 opened a new pull request, #19029: URL: https://github.com/apache/kafka/pull/19029 Modify from https://github.com/apache/kafka/pull/16766 For now protocolConsumerGroupExecutor.close(); take too much which will cause timeout. Still need to be fixed -- This is an a

Re: [PR] KAFKA-18537: Fix flaky RemoteIndexCacheTest#testCleanerThreadShutdown [kafka]

2025-05-03 Thread via GitHub
frankvicky commented on code in PR #19628: URL: https://github.com/apache/kafka/pull/19628#discussion_r2072535264 ## storage/src/test/java/org/apache/kafka/storage/internals/log/RemoteIndexCacheTest.java: ## @@ -376,6 +376,8 @@ public void testCleanerThreadShutdown() throws IOEx

[PR] NO-ISSUE: Fix commit bugs caused by race condition during rebalancing. [kafka]

2025-05-03 Thread via GitHub
chickenchickenlove opened a new pull request, #19631: URL: https://github.com/apache/kafka/pull/19631 ### Background There has been the issue that events skipped in group rebalancing (https://github.com/spring-projects/spring-kafka/issues/3703) . At the first, I thought it was caused

Re: [PR] MINOR: fix bug in MockConsumer [kafka]

2025-05-03 Thread via GitHub
mjsax commented on PR #19627: URL: https://github.com/apache/kafka/pull/19627#issuecomment-2848881213 Wasn't me. Thanks you, co-pilote! (I actually reviewed the PR that introduced it, and missed during review 😞) -- This is an automated message from the Apache Git Service. To respond

[jira] [Created] (KAFKA-19236) Auto.offset.reset "by-duration" should reset a single time

2025-05-03 Thread Matthias J. Sax (Jira)
Matthias J. Sax created KAFKA-19236: --- Summary: Auto.offset.reset "by-duration" should reset a single time Key: KAFKA-19236 URL: https://issues.apache.org/jira/browse/KAFKA-19236 Project: Kafka

Re: [PR] MINOR: Fix commit bugs caused by race condition during rebalancing. [kafka]

2025-05-03 Thread via GitHub
chickenchickenlove commented on PR #19631: URL: https://github.com/apache/kafka/pull/19631#issuecomment-2848905178 @m1a2st Thanks for your comments. I have a question. This is an extremely rare case, so writing test code won’t be easy. Nevertheless, I’ll give it a try. Even if I

Re: [PR] MINOR: Fix commit bugs caused by race condition during rebalancing. [kafka]

2025-05-03 Thread via GitHub
m1a2st commented on PR #19631: URL: https://github.com/apache/kafka/pull/19631#issuecomment-2848914593 Thanks for the reply. I’ll try to reproduce the issue on my local machine by following the steps in [spring-projects/spring-kafka#3703](https://github.com/spring-projects/spring-kafka/issu

Re: [PR] [WIP]KAFKA-17826 Consumer#offsetsForTimes should not return null value [kafka]

2025-05-03 Thread via GitHub
github-actions[bot] commented on PR #19575: URL: https://github.com/apache/kafka/pull/19575#issuecomment-2848980056 A label of 'needs-attention' was automatically added to this PR in order to raise the attention of the committers. Once this issue has been triaged, the `triage` label s

Re: [PR] KAFKA-19168: MirrorMaker kafka_metrics_count metric is always incorrect [kafka]

2025-05-03 Thread via GitHub
github-actions[bot] commented on PR #19573: URL: https://github.com/apache/kafka/pull/19573#issuecomment-2848980064 A label of 'needs-attention' was automatically added to this PR in order to raise the attention of the committers. Once this issue has been triaged, the `triage` label s

Re: [PR] KAFKA-14725: Interrupt source task poll thread when cancelled [kafka]

2025-05-03 Thread via GitHub
github-actions[bot] commented on PR #14316: URL: https://github.com/apache/kafka/pull/14316#issuecomment-2848985315 This PR has been closed since it has not had any activity in 120 days. If you feel like this was a mistake, or you would like to continue working on it, please feel free to

Re: [PR] MINOR: Improve Javadoc for OffsetCommitCallback-consuming commitAsync… [kafka]

2025-05-03 Thread via GitHub
github-actions[bot] closed pull request #12364: MINOR: Improve Javadoc for OffsetCommitCallback-consuming commitAsync… URL: https://github.com/apache/kafka/pull/12364 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

Re: [PR] MINOR: Improve Javadoc for OffsetCommitCallback-consuming commitAsync… [kafka]

2025-05-03 Thread via GitHub
github-actions[bot] commented on PR #12364: URL: https://github.com/apache/kafka/pull/12364#issuecomment-2848985305 This PR has been closed since it has not had any activity in 120 days. If you feel like this was a mistake, or you would like to continue working on it, please feel free to

Re: [PR] Kafka 8850: Updated documentation to clarify fetch.min.bytes behaviour. [kafka]

2025-05-03 Thread via GitHub
github-actions[bot] commented on PR #16749: URL: https://github.com/apache/kafka/pull/16749#issuecomment-2848985361 This PR has been closed since it has not had any activity in 120 days. If you feel like this was a mistake, or you would like to continue working on it, please feel free to

Re: [PR] Kafka 8850: Updated documentation to clarify fetch.min.bytes behaviour. [kafka]

2025-05-03 Thread via GitHub
github-actions[bot] closed pull request #16749: Kafka 8850: Updated documentation to clarify fetch.min.bytes behaviour. URL: https://github.com/apache/kafka/pull/16749 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the U

Re: [PR] KAFKA-14725: Interrupt source task poll thread when cancelled [kafka]

2025-05-03 Thread via GitHub
github-actions[bot] closed pull request #14316: KAFKA-14725: Interrupt source task poll thread when cancelled URL: https://github.com/apache/kafka/pull/14316 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

Re: [PR] KAFKA-16505: Add source raw bytes in processorContex [kafka]

2025-05-03 Thread via GitHub
github-actions[bot] commented on PR #17960: URL: https://github.com/apache/kafka/pull/17960#issuecomment-2848985380 This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please leave a comment asking for a review. If the P

Re: [PR] KAFKA-15992 Make MM2 heartbeats topic name configurable [kafka]

2025-05-03 Thread via GitHub
github-actions[bot] commented on PR #15200: URL: https://github.com/apache/kafka/pull/15200#issuecomment-2848985330 This PR has been closed since it has not had any activity in 120 days. If you feel like this was a mistake, or you would like to continue working on it, please feel free to

Re: [PR] KAFKA-15992 Make MM2 heartbeats topic name configurable [kafka]

2025-05-03 Thread via GitHub
github-actions[bot] closed pull request #15200: KAFKA-15992 Make MM2 heartbeats topic name configurable URL: https://github.com/apache/kafka/pull/15200 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

Re: [PR] MINOR: fix bug in MockConsumer [kafka]

2025-05-03 Thread via GitHub
chia7712 commented on PR #19627: URL: https://github.com/apache/kafka/pull/19627#issuecomment-2848993598 > Thanks you, co-pilote! I love copilot too, so please don't replace programmers 😢 -- This is an automated message from the Apache Git Service. To respond to the message, please

Re: [PR] MINOR: Fix commit bugs caused by race condition during rebalancing. [kafka]

2025-05-03 Thread via GitHub
chickenchickenlove commented on PR #19631: URL: https://github.com/apache/kafka/pull/19631#issuecomment-2848925224 @mjsax I think especially `CoperativeStikcy` strategy will be affected. Because there’s a high probability that the consumer still owns the previous partition, calling Fetch

Re: [PR] MINOR: Fix commit bugs caused by race condition during rebalancing. [kafka]

2025-05-03 Thread via GitHub
chickenchickenlove commented on PR #19631: URL: https://github.com/apache/kafka/pull/19631#issuecomment-2848923726 @m1a2st thanks for your answer! There is no example to reliably reproduce that situation. I was able to reproduce it once again on my local by using two IDE and debug mo

Re: [PR] MINOR: Fix commit bugs caused by race condition during rebalancing. [kafka]

2025-05-03 Thread via GitHub
mjsax commented on PR #19631: URL: https://github.com/apache/kafka/pull/19631#issuecomment-2848922863 > There has been the issue that events skipped in group rebalancing If this is correct, it's a serious bug, and we should not just fix it as MINOR, but file a Jira ticket. \cc @dajac

Re: [PR] KAFKA - 19145: Move LeaderEndPoint to Server module [kafka]

2025-05-03 Thread via GitHub
YutaLin commented on code in PR #19630: URL: https://github.com/apache/kafka/pull/19630#discussion_r2072493323 ## server/src/main/java/org/apache/kafka/server/ResultWithPartitions.java: ## @@ -0,0 +1,40 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or mor

Re: [PR] KAFKA - 19145: Move LeaderEndPoint to Server module [kafka]

2025-05-03 Thread via GitHub
YutaLin commented on PR #19630: URL: https://github.com/apache/kafka/pull/19630#issuecomment-2848891934 Hi @m1a2st , I've already updated the part you suggested - much appreciated! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitH

Re: [PR] KAFKA - 19145: Move LeaderEndPoint to Server module [kafka]

2025-05-03 Thread via GitHub
YutaLin commented on code in PR #19630: URL: https://github.com/apache/kafka/pull/19630#discussion_r2072494463 ## server/src/main/java/org/apache/kafka/server/ReplicaState.java: ## @@ -0,0 +1,63 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * co