chirag-wadhwa5 commented on code in PR #19329:
URL: https://github.com/apache/kafka/pull/19329#discussion_r2063040650
##
core/src/test/scala/unit/kafka/server/ShareGroupHeartbeatRequestTest.scala:
##
@@ -592,6 +592,81 @@ class ShareGroupHeartbeatRequestTest(cluster:
ClusterInst
apoorvmittal10 commented on code in PR #19329:
URL: https://github.com/apache/kafka/pull/19329#discussion_r2063055068
##
core/src/test/scala/unit/kafka/server/ShareGroupHeartbeatRequestTest.scala:
##
@@ -592,6 +592,81 @@ class ShareGroupHeartbeatRequestTest(cluster:
ClusterInst
cadonna commented on code in PR #19507:
URL: https://github.com/apache/kafka/pull/19507#discussion_r2063474629
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java:
##
@@ -552,8 +552,14 @@ private void handleTasksWithStateUpdater(final Map>
jolshan commented on code in PR #19509:
URL: https://github.com/apache/kafka/pull/19509#discussion_r2064057006
##
server-common/src/main/java/org/apache/kafka/server/common/MetadataVersion.java:
##
@@ -147,7 +158,7 @@ public enum MetadataVersion {
* Think carefully before
jolshan commented on code in PR #19509:
URL: https://github.com/apache/kafka/pull/19509#discussion_r2064056448
##
server-common/src/main/java/org/apache/kafka/server/common/MetadataVersion.java:
##
@@ -117,6 +117,9 @@ public enum MetadataVersion {
// Enables share groups. N
jolshan commented on code in PR #19509:
URL: https://github.com/apache/kafka/pull/19509#discussion_r2064059380
##
server-common/src/main/java/org/apache/kafka/server/common/StreamsVersion.java:
##
@@ -0,0 +1,83 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under on
ijuma commented on code in PR #19523:
URL: https://github.com/apache/kafka/pull/19523#discussion_r2064071619
##
gradle/dependencies.gradle:
##
@@ -147,6 +148,7 @@ libs += [
caffeine: "com.github.ben-manes.caffeine:caffeine:$versions.caffeine",
classgraph: "io.github.classg
AndrewJSchofield merged PR #19585:
URL: https://github.com/apache/kafka/pull/19585
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafk
AndrewJSchofield opened a new pull request, #19585:
URL: https://github.com/apache/kafka/pull/19585
This PR removes a small piece of unused code which is also not correct.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and us
chia7712 commented on code in PR #19523:
URL: https://github.com/apache/kafka/pull/19523#discussion_r2064046103
##
gradle/dependencies.gradle:
##
@@ -147,6 +148,7 @@ libs += [
caffeine: "com.github.ben-manes.caffeine:caffeine:$versions.caffeine",
classgraph: "io.github.cla
jolshan commented on code in PR #19509:
URL: https://github.com/apache/kafka/pull/19509#discussion_r2064055740
##
server-common/src/main/java/org/apache/kafka/server/common/MetadataVersion.java:
##
@@ -117,6 +117,9 @@ public enum MetadataVersion {
// Enables share groups. N
chirag-wadhwa5 opened a new pull request, #19587:
URL: https://github.com/apache/kafka/pull/19587
This PR is the last in series to implement the DeleteShareGroupOffsets
request. This PR includes the changes in ShareGroupCommand which internally
calls the admin api to delete the offsets. Now
CalvinConfluent commented on PR #19355:
URL: https://github.com/apache/kafka/pull/19355#issuecomment-2835689257
@chia7712 @m1a2st The KIP-1152 has been accepted! Can you help take another
look? Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message,
[
https://issues.apache.org/jira/browse/KAFKA-19034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17947902#comment-17947902
]
Uladzislau Blok commented on KAFKA-19034:
-
I'll re-assign due to the lack of pro
[
https://issues.apache.org/jira/browse/KAFKA-19034?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Uladzislau Blok reassigned KAFKA-19034:
---
Assignee: Uladzislau Blok (was: HongYi Chen)
> Rewrite RemoteTopicCrudTest by Clus
AndrewJSchofield commented on code in PR #19542:
URL: https://github.com/apache/kafka/pull/19542#discussion_r2064192112
##
core/src/main/scala/kafka/server/BrokerServer.scala:
##
@@ -629,49 +629,43 @@ class BrokerServer(
.build()
}
- private def createShareCoordinat
[
https://issues.apache.org/jira/browse/KAFKA-19034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17947903#comment-17947903
]
HongYi Chen commented on KAFKA-19034:
-
[~bloku] Apologies for overlooking the JIRA n
[
https://issues.apache.org/jira/browse/KAFKA-19034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17947904#comment-17947904
]
Uladzislau Blok commented on KAFKA-19034:
-
[~apalan60] Sure. If you're working o
AndrewJSchofield commented on code in PR #19542:
URL: https://github.com/apache/kafka/pull/19542#discussion_r2064199957
##
core/src/main/scala/kafka/server/KafkaApis.scala:
##
@@ -3940,8 +3905,12 @@ class KafkaApis(val requestChannel: RequestChannel,
.setCurrentLeader(par
artemlivshits commented on code in PR #19470:
URL: https://github.com/apache/kafka/pull/19470#discussion_r2064255756
##
clients/src/test/java/org/apache/kafka/clients/producer/PreparedTxnStateTest.java:
##
@@ -167,7 +167,6 @@ public void testInvalidProducerIdEpochCombinations()
mjsax commented on code in PR #19560:
URL: https://github.com/apache/kafka/pull/19560#discussion_r2064260309
##
tests/kafkatest/tests/streams/base_streams_test.py:
##
@@ -13,22 +13,40 @@
# See the License for the specific language governing permissions and
# limitations under
edoardocomar commented on PR #19263:
URL: https://github.com/apache/kafka/pull/19263#issuecomment-2834508843
@showuon @frankvicky can we get this in 3.9.2 at least ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
apoorvmittal10 opened a new pull request, #19581:
URL: https://github.com/apache/kafka/pull/19581
The PR adds `slice` API in `Records.java` and further implementation in
`MemoryRecords`. With the addition of ShareFetch and it's support to read from
TieredStorage, where ShareFetch might acqu
AndrewJSchofield commented on code in PR #19508:
URL: https://github.com/apache/kafka/pull/19508#discussion_r2063299867
##
clients/src/main/java/org/apache/kafka/common/requests/ListGroupsRequest.java:
##
@@ -50,8 +53,18 @@ public ListGroupsRequest build(short version) {
lucasbru commented on code in PR #19560:
URL: https://github.com/apache/kafka/pull/19560#discussion_r2063298187
##
tests/kafkatest/tests/streams/base_streams_test.py:
##
@@ -13,22 +13,40 @@
# See the License for the specific language governing permissions and
# limitations und
[
https://issues.apache.org/jira/browse/KAFKA-19091?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17947825#comment-17947825
]
Uladzislau Blok commented on KAFKA-19091:
-
[~yangpoan] Hello, sorry for botherin
lucasbru merged PR #19555:
URL: https://github.com/apache/kafka/pull/19555
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
AndrewJSchofield commented on code in PR #19329:
URL: https://github.com/apache/kafka/pull/19329#discussion_r2063614759
##
clients/clients-integration-tests/src/test/java/org/apache/kafka/clients/consumer/ShareConsumerTest.java:
##
@@ -2065,6 +2066,67 @@ public void testComplexS
m1a2st closed pull request #19375: MINOR cleanup log related test
URL: https://github.com/apache/kafka/pull/19375
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe
mumrah commented on PR #19555:
URL: https://github.com/apache/kafka/pull/19555#issuecomment-2835256484
The build scan failures are because 4.0 is missing #18770 and many other CI
changes from trunk
--
This is an automated message from the Apache Git Service.
To respond to the message, ple
Pritam Kumar created KAFKA-19211:
Summary: Connect Storage Topics Sharing Across Clusters
Key: KAFKA-19211
URL: https://issues.apache.org/jira/browse/KAFKA-19211
Project: Kafka
Issue Type: Im
lucasbru commented on code in PR #19560:
URL: https://github.com/apache/kafka/pull/19560#discussion_r2063009976
##
tests/kafkatest/tests/streams/base_streams_test.py:
##
@@ -13,22 +13,40 @@
# See the License for the specific language governing permissions and
# limitations und
lucasbru merged PR #19561:
URL: https://github.com/apache/kafka/pull/19561
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
junrao commented on code in PR #19509:
URL: https://github.com/apache/kafka/pull/19509#discussion_r2064901409
##
server-common/src/main/java/org/apache/kafka/server/common/MetadataVersion.java:
##
@@ -147,7 +158,7 @@ public enum MetadataVersion {
* Think carefully before y
mjsax commented on code in PR #19509:
URL: https://github.com/apache/kafka/pull/19509#discussion_r2064979446
##
server-common/src/main/java/org/apache/kafka/server/common/MetadataVersion.java:
##
@@ -127,7 +127,15 @@ public enum MetadataVersion {
// *** SHARE GROUPS BECOME
mjsax commented on code in PR #19509:
URL: https://github.com/apache/kafka/pull/19509#discussion_r2064983262
##
server-common/src/main/java/org/apache/kafka/server/common/MetadataVersion.java:
##
@@ -147,7 +158,7 @@ public enum MetadataVersion {
* Think carefully before yo
jolshan commented on code in PR #19509:
URL: https://github.com/apache/kafka/pull/19509#discussion_r2065016060
##
server-common/src/main/java/org/apache/kafka/server/common/MetadataVersion.java:
##
@@ -127,7 +127,15 @@ public enum MetadataVersion {
// *** SHARE GROUPS BECOM
junrao commented on code in PR #19509:
URL: https://github.com/apache/kafka/pull/19509#discussion_r2065030149
##
server-common/src/main/java/org/apache/kafka/server/common/MetadataVersion.java:
##
@@ -127,7 +127,15 @@ public enum MetadataVersion {
// *** SHARE GROUPS BECOME
junrao commented on code in PR #19509:
URL: https://github.com/apache/kafka/pull/19509#discussion_r2064973836
##
server-common/src/main/java/org/apache/kafka/server/common/MetadataVersion.java:
##
@@ -117,6 +117,9 @@ public enum MetadataVersion {
// Enables share groups. No
Calvin Liu created KAFKA-19212:
--
Summary: Fix ElectionWasClean method bug when partition
reassignment completes
Key: KAFKA-19212
URL: https://issues.apache.org/jira/browse/KAFKA-19212
Project: Kafka
junrao commented on code in PR #19293:
URL: https://github.com/apache/kafka/pull/19293#discussion_r2064970001
##
server-common/src/main/java/org/apache/kafka/server/common/MetadataVersion.java:
##
@@ -112,7 +112,22 @@ public enum MetadataVersion {
//
// Enables ELR b
CalvinConfluent opened a new pull request, #19590:
URL: https://github.com/apache/kafka/pull/19590
https://issues.apache.org/jira/browse/KAFKA-19212
The current ElectionWasClean checks if the new leader is in the previous
ISR. However, there is a corner case in the partition reassignm
[
https://issues.apache.org/jira/browse/KAFKA-19212?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Calvin Liu updated KAFKA-19212:
---
Summary: Fix ElectionWasClean bug when partition reassignment completes
(was: Fix ElectionWasClean
jolshan commented on code in PR #19509:
URL: https://github.com/apache/kafka/pull/19509#discussion_r2065108844
##
server-common/src/main/java/org/apache/kafka/server/common/MetadataVersion.java:
##
@@ -147,7 +158,7 @@ public enum MetadataVersion {
* Think carefully before
xijiu commented on code in PR #19578:
URL: https://github.com/apache/kafka/pull/19578#discussion_r2065106164
##
core/src/test/scala/integration/kafka/api/PlaintextConsumerTest.scala:
##
@@ -873,4 +873,17 @@ class PlaintextConsumerTest extends BaseConsumerTest {
waitTimeMs
jolshan commented on code in PR #19509:
URL: https://github.com/apache/kafka/pull/19509#discussion_r2065108844
##
server-common/src/main/java/org/apache/kafka/server/common/MetadataVersion.java:
##
@@ -147,7 +158,7 @@ public enum MetadataVersion {
* Think carefully before
squah-confluent commented on PR #19497:
URL: https://github.com/apache/kafka/pull/19497#issuecomment-2837195035
> @squah-confluent Thanks for the patch. Could we write a micro benchmark to
demonstrate the gain?
Added a benchmark.
Before:
```
Benchmark
mjsax commented on code in PR #19546:
URL: https://github.com/apache/kafka/pull/19546#discussion_r2065201574
##
clients/src/main/java/org/apache/kafka/clients/consumer/KafkaConsumer.java:
##
@@ -1797,31 +1801,48 @@ public void close() {
* @throws InterruptException If the
mjsax commented on code in PR #19570:
URL: https://github.com/apache/kafka/pull/19570#discussion_r2065192641
##
streams/src/test/java/org/apache/kafka/streams/kstream/TimeWindowedDeserializerTest.java:
##
@@ -97,34 +104,41 @@ public void
shouldThrowErrorIfWindowSizeSetInConstru
mjsax commented on PR #18297:
URL: https://github.com/apache/kafka/pull/18297#issuecomment-2837186932
No worries. All good. -- Just sharing to general awareness. Not meant as
critique.
> Do you want to add verification about error message in
https://github.com/apache/kafka/pull/19570
squah-confluent commented on code in PR #19497:
URL: https://github.com/apache/kafka/pull/19497#discussion_r2065195975
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/OffsetMetadataManager.java:
##
@@ -194,9 +194,16 @@ public OffsetMetadataManager build() {
YutaLin opened a new pull request, #19591:
URL: https://github.com/apache/kafka/pull/19591
Move LeaderEndPoint to Server module
Reviewers: Chia-Ping Tsai [chia7...@gmail.com](mailto:chia7...@gmail.com)
--
This is an automated message from the Apache Git Service.
To respond to the m
AndrewJSchofield commented on code in PR #19508:
URL: https://github.com/apache/kafka/pull/19508#discussion_r2063140276
##
core/src/main/scala/kafka/admin/ConfigCommand.scala:
##
@@ -350,7 +350,7 @@ object ConfigCommand extends Logging {
case ClientMetricsType =>
AndrewJSchofield commented on code in PR #19508:
URL: https://github.com/apache/kafka/pull/19508#discussion_r2063142470
##
clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java:
##
@@ -3541,27 +3541,29 @@ ListGroupsRequest.Builder createRequest(int timeoutMs
apoorvmittal10 commented on code in PR #19329:
URL: https://github.com/apache/kafka/pull/19329#discussion_r2063144141
##
core/src/test/scala/unit/kafka/server/ShareFetchAcknowledgeRequestTest.scala:
##
@@ -54,7 +55,7 @@ class ShareFetchAcknowledgeRequestTest(cluster:
ClusterIns
lucasbru commented on code in PR #19560:
URL: https://github.com/apache/kafka/pull/19560#discussion_r2063092912
##
tests/kafkatest/services/kafka/kafka.py:
##
@@ -778,7 +781,14 @@ def prop_file(self, node):
if self.use_share_groups is not None and self.use_share_group
[
https://issues.apache.org/jira/browse/KAFKA-19209?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ShihYuanLin reassigned KAFKA-19209:
---
Assignee: ShihYuanLin
> "index.interval.bytes" config doc should also mention time index
>
[
https://issues.apache.org/jira/browse/KAFKA-19210?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chirag Wadhwa reassigned KAFKA-19210:
-
Assignee: Chirag Wadhwa
> investigate flakiness in
> GroupMetadataManagerTest.testShar
Chirag Wadhwa created KAFKA-19210:
-
Summary: investigate flakiness in
GroupMetadataManagerTest.testShareGroupHeartbeatInitializeOnPartitionUpdate
Key: KAFKA-19210
URL: https://issues.apache.org/jira/browse/KAFKA-1
xijiu commented on code in PR #19578:
URL: https://github.com/apache/kafka/pull/19578#discussion_r2063586929
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/events/ListOffsetsEvent.java:
##
@@ -47,13 +46,10 @@ public ListOffsetsEvent(Map
timestampToSearch,
apoorvmittal10 commented on code in PR #19430:
URL: https://github.com/apache/kafka/pull/19430#discussion_r2063589486
##
core/src/main/java/kafka/server/share/SharePartition.java:
##
@@ -2999,23 +3010,32 @@ private boolean hasOngoingStateTransition() {
/**
*
xijiu closed pull request #19578: KAFKA-19205: inconsistent result of
beginningOffsets/endoffset between classic consumer and async consumer with
zero timeout
URL: https://github.com/apache/kafka/pull/19578
--
This is an automated message from the Apache Git Service.
To respond to the messag
[
https://issues.apache.org/jira/browse/KAFKA-19209?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Luke Chen updated KAFKA-19209:
--
Labels: newbie (was: )
> "index.interval.bytes" config doc should also mention time index
> -
Luke Chen created KAFKA-19209:
-
Summary: "index.interval.bytes" config doc should also mention
time index
Key: KAFKA-19209
URL: https://issues.apache.org/jira/browse/KAFKA-19209
Project: Kafka
I
m1a2st opened a new pull request, #19582:
URL: https://github.com/apache/kafka/pull/19582
Use Java to rewrite PlaintextConsumerPollTest by new test infra and move it
to client-integration-tests module.
--
This is an automated message from the Apache Git Service.
To respond to the message,
FrankYang0529 commented on code in PR #19523:
URL: https://github.com/apache/kafka/pull/19523#discussion_r2063434753
##
gradle/dependencies.gradle:
##
@@ -147,6 +148,7 @@ libs += [
caffeine: "com.github.ben-manes.caffeine:caffeine:$versions.caffeine",
classgraph: "io.githu
FrankYang0529 commented on code in PR #19523:
URL: https://github.com/apache/kafka/pull/19523#discussion_r2063438718
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/Group.java:
##
@@ -209,4 +219,50 @@ void validateOffsetFetch(
default boolean shouldExp
FrankYang0529 commented on code in PR #19523:
URL: https://github.com/apache/kafka/pull/19523#discussion_r2063438718
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/Group.java:
##
@@ -209,4 +219,50 @@ void validateOffsetFetch(
default boolean shouldExp
FrankYang0529 commented on code in PR #19523:
URL: https://github.com/apache/kafka/pull/19523#discussion_r2063440444
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/Group.java:
##
@@ -209,4 +219,50 @@ void validateOffsetFetch(
default boolean shouldExp
FrankYang0529 commented on code in PR #19523:
URL: https://github.com/apache/kafka/pull/19523#discussion_r2063441134
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/Group.java:
##
@@ -209,4 +219,50 @@ void validateOffsetFetch(
default boolean shouldExp
FrankYang0529 commented on code in PR #19523:
URL: https://github.com/apache/kafka/pull/19523#discussion_r2063441471
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/Group.java:
##
@@ -209,4 +219,50 @@ void validateOffsetFetch(
default boolean shouldExp
dajac merged PR #19576:
URL: https://github.com/apache/kafka/pull/19576
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or
aliehsaeedii opened a new pull request, #19583:
URL: https://github.com/apache/kafka/pull/19583
This PR is fixing the issue introduced in #19120
The input `StreamsGroup`-options must not be ignored, but it must be
converted to `ConsumerGroup`-options.
--
This is an automated message fr
dajac commented on code in PR #19523:
URL: https://github.com/apache/kafka/pull/19523#discussion_r2063449780
##
gradle/dependencies.gradle:
##
@@ -147,6 +148,7 @@ libs += [
caffeine: "com.github.ben-manes.caffeine:caffeine:$versions.caffeine",
classgraph: "io.github.classg
lucasbru opened a new pull request, #19584:
URL: https://github.com/apache/kafka/pull/19584
Stacked
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-ma
AndrewJSchofield commented on code in PR #19581:
URL: https://github.com/apache/kafka/pull/19581#discussion_r2063755306
##
clients/src/main/java/org/apache/kafka/common/record/Records.java:
##
@@ -90,4 +91,18 @@ public interface Records extends TransferableRecords {
* @ret
AndrewJSchofield commented on PR #19540:
URL: https://github.com/apache/kafka/pull/19540#issuecomment-2835429693
>
https://github.com/apache/kafka/blob/b97a130c0874bae0ad47a903921074405ac3c4df/core/src/main/scala/kafka/server/KafkaApis.scala#L3667C1-L3670C6
If the `authorizedTopics` is empt
lucasbru commented on PR #19560:
URL: https://github.com/apache/kafka/pull/19560#issuecomment-2835429985
@mjsax This is ready for re-review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spe
FrankYang0529 commented on code in PR #19579:
URL: https://github.com/apache/kafka/pull/19579#discussion_r2063791648
##
core/src/main/scala/kafka/server/BrokerServer.scala:
##
@@ -709,7 +709,7 @@ class BrokerServer(
None
}
- val rlm = new RemoteLogManager(
AndrewJSchofield commented on code in PR #19540:
URL: https://github.com/apache/kafka/pull/19540#discussion_r2063830503
##
core/src/test/scala/integration/kafka/api/AuthorizerIntegrationTest.scala:
##
@@ -2609,6 +2777,475 @@ class AuthorizerIntegrationTest extends
AbstractAutho
FrankYang0529 commented on code in PR #19582:
URL: https://github.com/apache/kafka/pull/19582#discussion_r2063882027
##
clients/clients-integration-tests/src/test/java/org/apache/kafka/clients/consumer/ConsumerAssignmentPoller.java:
##
@@ -0,0 +1,151 @@
+/*
+ * Licensed to the A
squah-confluent commented on PR #19497:
URL: https://github.com/apache/kafka/pull/19497#issuecomment-2837236914
@shaan150 I decided to do something a little different and factored out the
code into `Map` interface-like operations.
--
This is an automated message from the Apache Git Servic
frankvicky commented on code in PR #19446:
URL: https://github.com/apache/kafka/pull/19446#discussion_r2065252762
##
streams/src/test/java/org/apache/kafka/streams/processor/internals/CopartitionedTopicsEnforcerTest.java:
##
@@ -124,8 +124,8 @@ public void
shouldThrowAnExceptio
squah-confluent commented on code in PR #19497:
URL: https://github.com/apache/kafka/pull/19497#discussion_r2065220453
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/OffsetMetadataManager.java:
##
@@ -650,24 +658,18 @@ public int deleteAllOffsets(
github-actions[bot] commented on PR #19236:
URL: https://github.com/apache/kafka/pull/19236#issuecomment-2837333188
A label of 'needs-attention' was automatically added to this PR in order to
raise the
attention of the committers. Once this issue has been triaged, the `triage`
label
s
github-actions[bot] commented on PR #19231:
URL: https://github.com/apache/kafka/pull/19231#issuecomment-2837333208
A label of 'needs-attention' was automatically added to this PR in order to
raise the
attention of the committers. Once this issue has been triaged, the `triage`
label
s
github-actions[bot] commented on PR #19531:
URL: https://github.com/apache/kafka/pull/19531#issuecomment-2837333043
A label of 'needs-attention' was automatically added to this PR in order to
raise the
attention of the committers. Once this issue has been triaged, the `triage`
label
s
github-actions[bot] commented on PR #18828:
URL: https://github.com/apache/kafka/pull/18828#issuecomment-283702
A label of 'needs-attention' was automatically added to this PR in order to
raise the
attention of the committers. Once this issue has been triaged, the `triage`
label
s
github-actions[bot] commented on PR #19489:
URL: https://github.com/apache/kafka/pull/19489#issuecomment-2837333081
A label of 'needs-attention' was automatically added to this PR in order to
raise the
attention of the committers. Once this issue has been triaged, the `triage`
label
s
lucasbru commented on code in PR #19588:
URL: https://github.com/apache/kafka/pull/19588#discussion_r2065636976
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/streams/topics/EndpointToPartitionsManager.java:
##
@@ -0,0 +1,86 @@
+/*
+ * Licensed to the Apac
squah-confluent commented on code in PR #19497:
URL: https://github.com/apache/kafka/pull/19497#discussion_r2065224650
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/OffsetMetadataManager.java:
##
@@ -650,24 +658,18 @@ public int deleteAllOffsets(
adixitconfluent opened a new pull request, #19592:
URL: https://github.com/apache/kafka/pull/19592
### About
This PR removes the limitation in remote storage fetch for share groups of
only performing remote fetch for a single topic partition in a share fetch
request. With this PR, share
[
https://issues.apache.org/jira/browse/KAFKA-19182?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai reassigned KAFKA-19182:
--
Assignee: Uladzislau Blok (was: Chia-Ping Tsai)
> Move SchedulerTest to server modul
[
https://issues.apache.org/jira/browse/KAFKA-19182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17948021#comment-17948021
]
Chia-Ping Tsai commented on KAFKA-19182:
[~bloku] I have assigned it to you. Tha
AndrewJSchofield commented on code in PR #19509:
URL: https://github.com/apache/kafka/pull/19509#discussion_r2064374018
##
server-common/src/main/java/org/apache/kafka/server/common/MetadataVersion.java:
##
@@ -117,6 +117,9 @@ public enum MetadataVersion {
// Enables share
mjsax commented on code in PR #19446:
URL: https://github.com/apache/kafka/pull/19446#discussion_r2064426826
##
streams/src/test/java/org/apache/kafka/streams/processor/internals/metrics/StreamsMetricsImplTest.java:
##
@@ -509,24 +507,30 @@ public void shouldReturnSameMetricIfAl
mjsax commented on PR #18816:
URL: https://github.com/apache/kafka/pull/18816#issuecomment-2836336370
@leaf-soba -- Any updates?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comme
mjsax commented on code in PR #19446:
URL: https://github.com/apache/kafka/pull/19446#discussion_r2064413275
##
streams/src/test/java/org/apache/kafka/streams/processor/internals/CopartitionedTopicsEnforcerTest.java:
##
@@ -124,8 +124,8 @@ public void
shouldThrowAnExceptionIfRe
apoorvmittal10 commented on code in PR #19542:
URL: https://github.com/apache/kafka/pull/19542#discussion_r2064436921
##
core/src/main/scala/kafka/server/KafkaApis.scala:
##
@@ -3940,8 +3905,12 @@ class KafkaApis(val requestChannel: RequestChannel,
.setCurrentLeader(parti
mjsax commented on code in PR #19446:
URL: https://github.com/apache/kafka/pull/19446#discussion_r2064434824
##
streams/src/test/java/org/apache/kafka/streams/tests/StreamsNamedRepartitionTest.java:
##
@@ -55,7 +55,7 @@ public static void main(final String[] args) throws Excepti
1 - 100 of 120 matches
Mail list logo
