Re: [PR] KAFKA-16729: Support isolation level for share consumer [kafka]

2025-04-05 Thread via GitHub
apoorvmittal10 commented on code in PR #19261: URL: https://github.com/apache/kafka/pull/19261#discussion_r2013454652 ## core/src/main/java/kafka/server/share/SharePartition.java: ## @@ -2484,6 +2497,259 @@ private long startOffsetDuringInitialization(long partitionDataStartOff

Re: [PR] MINOR: Some cleanups in group coordinator's intergration tests [kafka]

2025-04-05 Thread via GitHub
lianetm commented on code in PR #19281: URL: https://github.com/apache/kafka/pull/19281#discussion_r2016344814 ## core/src/test/scala/unit/kafka/server/ConsumerGroupDescribeRequestTest.scala: ## @@ -37,15 +37,17 @@ import java.lang.{Byte => JByte} import java.util.Collections

Re: [PR] KAFKA-10551: Add topic id support to produce request and response [kafka]

2025-04-05 Thread via GitHub
ijuma commented on PR #15968: URL: https://github.com/apache/kafka/pull/15968#issuecomment-2743945863 @OmniaGM Would you like someone to help get this over the finish line? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

Re: [PR] KAFKA-18713: Fix FK Left-Join result race condition [kafka]

2025-04-05 Thread via GitHub
nilmadhab commented on PR #19005: URL: https://github.com/apache/kafka/pull/19005#issuecomment-2774512670 @mjsax LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

Re: [PR] KAFKA-19053: Remove FetchResponse#of which is not used in production … [kafka]

2025-04-05 Thread via GitHub
chia7712 commented on PR #19327: URL: https://github.com/apache/kafka/pull/19327#issuecomment-2781010552 @ijuma thanks for your explanation. I do agree that there is no strict requirement of removing a test-only method. However, `nodeEndpoints` is crucial for handling specific errors like `

[PR] MINOR: Update Mockito on 3.9 for Java 23 support [kafka]

2025-04-05 Thread via GitHub
srdo opened a new pull request, #19367: URL: https://github.com/apache/kafka/pull/19367 This was done on trunk in 6a37d5ccebaa6bbfc1d1b943f0ff761cf978da7d -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

[PR] Mar 18 Testing [kafka-merge-queue-sandbox]

2025-04-05 Thread via GitHub
mumrah opened a new pull request, #63: URL: https://github.com/apache/kafka-merge-queue-sandbox/pull/63 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

Re: [PR] KAFKA-16580: Enable dynamic quorum reconfiguration for raft simulation tests [kafka]

2025-04-05 Thread via GitHub
jsancio commented on code in PR #18987: URL: https://github.com/apache/kafka/pull/18987#discussion_r2004145500 ## raft/src/test/java/org/apache/kafka/raft/RaftEventSimulationTest.java: ## @@ -475,6 +563,99 @@ void canRecoverFromSingleNodeCommittedDataLoss( scheduler.run

Re: [PR] KAFKA-19025: Reuse LZ4 buffers for compression [kafka]

2025-04-05 Thread via GitHub
squah-confluent closed pull request #19260: KAFKA-19025: Reuse LZ4 buffers for compression URL: https://github.com/apache/kafka/pull/19260 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

[jira] [Updated] (KAFKA-19026) AlterConfigPolicy incompatibility between ZK mode and KRaft mode when using AlterConfigOp.OpType.SUBTRACT

2025-04-05 Thread Edoardo Comar (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19026?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Edoardo Comar updated KAFKA-19026: -- Attachment: KAFKA19026Test.java > AlterConfigPolicy incompatibility between ZK mode and KRaft

Re: [PR] MINOR: migrate BrokerCompressionTest to storage module [kafka]

2025-04-05 Thread via GitHub
frankvicky commented on code in PR #19277: URL: https://github.com/apache/kafka/pull/19277#discussion_r2011287595 ## storage/src/test/java/org/apache/kafka/storage/internals/log/BrokerCompressionTest.java: ## @@ -0,0 +1,117 @@ +/* + * Licensed to the Apache Software Foundation (

[jira] [Commented] (KAFKA-19079) KIP-890 Cleanups

2025-04-05 Thread oshione gabriel esiemokhai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19079?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17940811#comment-17940811 ] oshione gabriel esiemokhai commented on KAFKA-19079: hello ,what doe

Re: [PR] KAFKA-19062: Port changes from KAFKA-18645 to share-consumers [kafka]

2025-04-05 Thread via GitHub
ShivsundarR commented on code in PR #19335: URL: https://github.com/apache/kafka/pull/19335#discussion_r2022361659 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/ShareConsumerImpl.java: ## @@ -250,6 +251,7 @@ private enum AcknowledgementMode {

[jira] [Created] (KAFKA-19051) Fix implicit acknowledgement cannot be override when RecordDeserializationException occurs

2025-04-05 Thread Jira
Frédérik ROULEAU created KAFKA-19051: Summary: Fix implicit acknowledgement cannot be override when RecordDeserializationException occurs Key: KAFKA-19051 URL: https://issues.apache.org/jira/browse/KAFKA-19051

Re: [PR] KAFKA-14523: Move DelayedRemoteListOffsets to the storage module [kafka]

2025-04-05 Thread via GitHub
chia7712 merged PR #19285: URL: https://github.com/apache/kafka/pull/19285 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

[jira] [Commented] (KAFKA-14485) Move LogCleaner to storage module

2025-04-05 Thread Dmitry Werner (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17941241#comment-17941241 ] Dmitry Werner commented on KAFKA-14485: --- [~chia7712] Thank you for your guidance -

[jira] [Created] (KAFKA-19093) Change the "Handler on Broker" to "Handler on Controller" for controller server

2025-04-05 Thread Chia-Ping Tsai (Jira)
Chia-Ping Tsai created KAFKA-19093: -- Summary: Change the "Handler on Broker" to "Handler on Controller" for controller server Key: KAFKA-19093 URL: https://issues.apache.org/jira/browse/KAFKA-19093

[jira] [Commented] (KAFKA-19093) Change the "Handler on Broker" to "Handler on Controller" for controller server

2025-04-05 Thread Nick Guo (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17941243#comment-17941243 ] Nick Guo commented on KAFKA-19093: -- Hi [~chia7712] ,I would like to handle this.Thanks!

[jira] [Assigned] (KAFKA-19093) Change the "Handler on Broker" to "Handler on Controller" for controller server

2025-04-05 Thread Nick Guo (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19093?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nick Guo reassigned KAFKA-19093: Assignee: Nick Guo (was: Chia-Ping Tsai) > Change the "Handler on Broker" to "Handler on Control

[jira] [Created] (KAFKA-19096) Skipped Records in FK join should not be marked as dropped

2025-04-05 Thread Ayoub Omari (Jira)
Ayoub Omari created KAFKA-19096: --- Summary: Skipped Records in FK join should not be marked as dropped Key: KAFKA-19096 URL: https://issues.apache.org/jira/browse/KAFKA-19096 Project: Kafka Issu

[jira] [Updated] (KAFKA-19096) Skipped Records in FK join should not be marked as dropped

2025-04-05 Thread Ayoub Omari (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19096?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ayoub Omari updated KAFKA-19096: Description: Currently, we are logging all skipped records in FK join as dropped. This seems inco

Re: [PR] KAFKA-16407: Fix foreign key INNER join on change of FK from/to a null value [kafka]

2025-04-05 Thread via GitHub
AyoubOm commented on code in PR #19303: URL: https://github.com/apache/kafka/pull/19303#discussion_r2029961920 ## streams/src/test/java/org/apache/kafka/streams/kstream/internals/foreignkeyjoin/SubscriptionSendProcessorSupplierTest.java: ## @@ -316,6 +367,21 @@ public void inner

[PR] KAFKA-14485: Move LogCleaner to storage module [kafka]

2025-04-05 Thread via GitHub
wernerdv opened a new pull request, #19387: URL: https://github.com/apache/kafka/pull/19387 Move LogCleaner and related classes to storage module and rewrite in Java. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[jira] [Commented] (KAFKA-14485) Move LogCleaner to storage module

2025-04-05 Thread Dmitry Werner (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17941300#comment-17941300 ] Dmitry Werner commented on KAFKA-14485: --- [~chia7712] [~mimaison] I've opened the P

Re: [PR] KAFKA-18959: increase the num_workers from 9 to 12 [kafka]

2025-04-05 Thread via GitHub
apalan60 commented on PR #19274: URL: https://github.com/apache/kafka/pull/19274#issuecomment-2759098547 I ran a few tests, and so far I have successfully invoked 14 nodes, with the tests remaining stable. ![image](https://github.com/user-attachments/assets/99c63aeb-c04c-4fe3-9be5-10

Re: [PR] MINOR: Cleanup metadata module [kafka]

2025-04-05 Thread via GitHub
chia7712 commented on code in PR #18937: URL: https://github.com/apache/kafka/pull/18937#discussion_r2020616189 ## metadata/src/main/java/org/apache/kafka/metadata/util/SnapshotFileReader.java: ## @@ -208,8 +208,4 @@ public void close() throws Exception { beginShutdown(

Re: [PR] MINOR: Unnecessary changeCapacity in ImplicitLinkedHashCollection [kafka]

2025-04-05 Thread via GitHub
github-actions[bot] commented on PR #17893: URL: https://github.com/apache/kafka/pull/17893#issuecomment-2749985982 This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please leave a comment asking for a review. If the P

[jira] [Created] (KAFKA-19019) Verify Share Fetch with Tiered Storage

2025-04-05 Thread Apoorv Mittal (Jira)
Apoorv Mittal created KAFKA-19019: - Summary: Verify Share Fetch with Tiered Storage Key: KAFKA-19019 URL: https://issues.apache.org/jira/browse/KAFKA-19019 Project: Kafka Issue Type: Sub-task

Re: [PR] KAFKA-18984: Reset interval.ms By Using kafka-client-metrics.sh [kafka]

2025-04-05 Thread via GitHub
Parkerhiphop commented on PR #19213: URL: https://github.com/apache/kafka/pull/19213#issuecomment-2741254322 Since the reset behavior has changed, it now resets the configs to their default values instead of leaving them empty as before. Here’s a screenshot of the reset behavior—inter

Re: [PR] KAFKA-18329; [2/3] Delete old group coordinator (KIP-848) [kafka]

2025-04-05 Thread via GitHub
dajac commented on code in PR #19251: URL: https://github.com/apache/kafka/pull/19251#discussion_r2005969287 ## core/src/main/scala/kafka/server/KafkaApis.scala: ## @@ -1635,40 +1635,8 @@ class KafkaApis(val requestChannel: RequestChannel, trace(s"End transaction marker a

Re: [PR] [KAFKA-18713] Left join bug integration test [kafka]

2025-04-05 Thread via GitHub
mjsax commented on code in PR #19005: URL: https://github.com/apache/kafka/pull/19005#discussion_r2026065811 ## streams/integration-tests/src/test/java/org/apache/kafka/streams/integration/KTableKTableForeignKeyJoinIntegrationTest.java: ## @@ -232,57 +236,134 @@ public void doJo

Re: [PR] KAFKA-19027: Replace ConsumerGroupCommandTestUtils#generator by ClusterTestDefaults [kafka]

2025-04-05 Thread via GitHub
Rancho-7 commented on PR #19347: URL: https://github.com/apache/kafka/pull/19347#issuecomment-2772098768 To verify the behavior, I ran the tests locally using the following command,and the output is also shown below. ``` (base) lansg:kafka/ (KAFKA-19027✗) $ N=100; I=0; while [ $I -

Re: [PR] KAFKA-18891: KIP-877 add support for RemoteLogMetadataManager and RemoteStorageManager [kafka]

2025-04-05 Thread via GitHub
TaiJuWu commented on code in PR #19286: URL: https://github.com/apache/kafka/pull/19286#discussion_r2022583314 ## core/src/test/java/kafka/log/remote/RemoteLogManagerTest.java: ## @@ -413,24 +418,19 @@ void testRemoteLogMetadataManagerWithEndpointConfigOverridden() throws IOExc

Re: [PR] MINOR: small optimization by judgment [kafka]

2025-04-05 Thread via GitHub
gongxuanzhang commented on PR #19386: URL: https://github.com/apache/kafka/pull/19386#issuecomment-2781166844 @chia7712 PTAL -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] MINOR: Move BrokerReconfigurable to the sever-common module [kafka]

2025-04-05 Thread via GitHub
frankvicky commented on code in PR #19383: URL: https://github.com/apache/kafka/pull/19383#discussion_r2030020799 ## server-common/src/main/java/org/apache/kafka/config/BrokerReconfigurable.java: ## @@ -27,13 +29,10 @@ * The reconfiguration process follows three steps: *

Re: [PR] KAFKA-16407: Fix foreign key INNER join on change of FK from/to a null value [kafka]

2025-04-05 Thread via GitHub
mjsax merged PR #19303: URL: https://github.com/apache/kafka/pull/19303 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or

[jira] [Updated] (KAFKA-18073) Data loss when exception is raised from Kafka Connect record conversion call

2025-04-05 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18073?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax updated KAFKA-18073: Fix Version/s: (was: 4.1.0) > Data loss when exception is raised from Kafka Connect re

Re: [PR] [WIP]KAFKA-19000 Flaky test report should use absolute time for links [kafka]

2025-04-05 Thread via GitHub
github-actions[bot] commented on PR #19228: URL: https://github.com/apache/kafka/pull/19228#issuecomment-2781197134 A label of 'needs-attention' was automatically added to this PR in order to raise the attention of the committers. Once this issue has been triaged, the `triage` label s

Re: [PR] KAFKA 18238 - fIdentify the first commit where a test became flaky [kafka]

2025-04-05 Thread via GitHub
github-actions[bot] commented on PR #18334: URL: https://github.com/apache/kafka/pull/18334#issuecomment-2781197176 A label of 'needs-attention' was automatically added to this PR in order to raise the attention of the committers. Once this issue has been triaged, the `triage` label s

[jira] [Updated] (KAFKA-19042) Move kafka.api test cases to clients-integration-tests module

2025-04-05 Thread PoAn Yang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19042?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] PoAn Yang updated KAFKA-19042: -- Description: This is an umbrella Jira about moving integration tests from kafka.api module to clients

[jira] [Updated] (KAFKA-19042) Move kafka.api test cases to clients-integration-tests module

2025-04-05 Thread PoAn Yang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19042?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] PoAn Yang updated KAFKA-19042: -- Summary: Move kafka.api test cases to clients-integration-tests module (was: Move kafka.api test case

[jira] [Commented] (KAFKA-19042) Move kafka.api test cases to clients-integration-tests module

2025-04-05 Thread PoAn Yang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19042?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17941311#comment-17941311 ] PoAn Yang commented on KAFKA-19042: --- Thanks. Updated it. > Move kafka.api test cases

Re: [PR] KAFKA-10640: Add recursive support to Connect Cast and ReplaceField transforms, and support for casting complex types to either a native or JSON string. [kafka]

2025-04-05 Thread via GitHub
github-actions[bot] commented on PR #9493: URL: https://github.com/apache/kafka/pull/9493#issuecomment-2781201685 This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please leave a comment asking for a review. If the PR

Re: [PR] KAFKA-19017: Changed consumer.config to command-config in verifiable_share_consumer.py [kafka]

2025-04-05 Thread via GitHub
AndrewJSchofield merged PR #19254: URL: https://github.com/apache/kafka/pull/19254 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafk

Re: [PR] MINOR: Update .asf.yaml collaborators [kafka]

2025-04-05 Thread via GitHub
mimaison commented on PR #19280: URL: https://github.com/apache/kafka/pull/19280#issuecomment-2750753505 > Somehow, I was convinced that it was executed automatically now every quarter. Me too! But it does not seem to be the case. -- This is an automated message from the Apache Git

Re: [PR] KAFKA-19001: Use streams group-level configurations in heartbeat [kafka]

2025-04-05 Thread via GitHub
lucasbru commented on code in PR #19219: URL: https://github.com/apache/kafka/pull/19219#discussion_r2028473669 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -8148,7 +8174,10 @@ private TaskAssignor streamsGroupAssignor(St

[jira] [Commented] (KAFKA-18713) Kafka Streams Left-Join not always emitting the last value

2025-04-05 Thread Stanislav Spiridonov (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17939766#comment-17939766 ] Stanislav Spiridonov commented on KAFKA-18713: -- # 4.0.0 is released, but th

Re: [PR] KAFKA-19053: Remove FetchResponse#of which is not used in production … [kafka]

2025-04-05 Thread via GitHub
ijuma commented on PR #19327: URL: https://github.com/apache/kafka/pull/19327#issuecomment-2781041904 OK, if the concern is that this method is unsafe in prod, it's reasonable to replace it with a test utility method. -- This is an automated message from the Apache Git Service. To respond

[jira] [Commented] (KAFKA-19050) kafka-streams-integration-tests artifact is empty

2025-04-05 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17938882#comment-17938882 ] Chia-Ping Tsai commented on KAFKA-19050: [~utkuaydin] do you mean we should move

Re: [PR] KAFKA-18613: Unit tests for usage of incorrect RPCs [kafka]

2025-04-05 Thread via GitHub
lucasbru merged PR #18383: URL: https://github.com/apache/kafka/pull/18383 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

Re: [PR] MINOR Mar 19 flaky tests [kafka]

2025-04-05 Thread via GitHub
mumrah merged PR #19248: URL: https://github.com/apache/kafka/pull/19248 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.o

[jira] [Assigned] (KAFKA-19096) Skipped Records in FK join should not be marked as dropped

2025-04-05 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19096?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax reassigned KAFKA-19096: --- Assignee: Matthias J. Sax > Skipped Records in FK join should not be marked as drop

<    1   2   3