[
https://issues.apache.org/jira/browse/KAFKA-18930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17932938#comment-17932938
]
Luke Chen commented on KAFKA-18930:
---
[~davidarthur] [~mumrah] , I'd like to hear your
mjsax commented on code in PR #19164:
URL: https://github.com/apache/kafka/pull/19164#discussion_r1986158617
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java:
##
@@ -1163,10 +1166,12 @@ void handleRevocation(final Collection
revokedPartitio
mumrah commented on PR #19159:
URL: https://github.com/apache/kafka/pull/19159#issuecomment-2707179546
Example step summary:
Commit will look like:
```
MINOR: Disallow unused local variables
Recently, we found a regression that could have been detected by static
analy
[
https://issues.apache.org/jira/browse/KAFKA-18942?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17933576#comment-17933576
]
Chia-Ping Tsai commented on KAFKA-18942:
+1 to this idea. [~mingyen066] will tak
m1a2st commented on PR #19153:
URL: https://github.com/apache/kafka/pull/19153#issuecomment-2708602615
```
https://cwiki.apache.org/confluence/display/KAFKA/KIP-714%3A+Client+metrics+and+observability#KIP714:Clientmetricsandobservability-＝
```
Keep only this URL, as it will redir
chia7712 commented on PR #19153:
URL: https://github.com/apache/kafka/pull/19153#issuecomment-2708606376
> Keep only this URL, as it will redirect to the specific section.
how about
https://cwiki.apache.org/confluence/x/2xRRCg#KIP714:Clientmetricsandobservability-Clientidentificationa
chia7712 merged PR #19062:
URL: https://github.com/apache/kafka/pull/19062
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
[
https://issues.apache.org/jira/browse/KAFKA-18700?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai updated KAFKA-18700:
---
Summary: Migrate SnapshotPath, Entry, OffsetAndEpoch, LogFetchInfo, and
LogAppendInfo to rec
chia7712 commented on code in PR #19071:
URL: https://github.com/apache/kafka/pull/19071#discussion_r1986194037
##
streams/src/test/java/org/apache/kafka/streams/kstream/internals/KTableImplTest.java:
##
@@ -391,24 +386,20 @@ public void testStateStore() {
public void
shou
[
https://issues.apache.org/jira/browse/KAFKA-18942?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai reassigned KAFKA-18942:
--
Assignee: Ming-Yen Chung
> Add reviewers to PR body with committer-tools
> --
[
https://issues.apache.org/jira/browse/KAFKA-18700?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai resolved KAFKA-18700.
Fix Version/s: 4.1.0
Resolution: Fixed
> Migrate SnapshotPath, Entry, OffsetAndEpoc
Chia-Ping Tsai created KAFKA-18944:
--
Summary: Remove unused setters from ClusterConfig
Key: KAFKA-18944
URL: https://issues.apache.org/jira/browse/KAFKA-18944
Project: Kafka
Issue Type: Impr
github-actions[bot] commented on PR #17987:
URL: https://github.com/apache/kafka/pull/17987#issuecomment-2708651331
This PR is being marked as stale since it has not had any activity in 90
days. If you
would like to keep this PR alive, please leave a comment asking for a
review. If the P
[
https://issues.apache.org/jira/browse/KAFKA-18420?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17933584#comment-17933584
]
kangning.li commented on KAFKA-18420:
-
file: [https://github.com/apache/kafka/pull/1
chia7712 commented on PR #19153:
URL: https://github.com/apache/kafka/pull/19153#issuecomment-2708599138
@m1a2st could you please fix above links as well?
--
This is an auto
chia7712 commented on code in PR #19094:
URL: https://github.com/apache/kafka/pull/19094#discussion_r1986207973
##
core/src/test/java/kafka/test/api/AdminClientRebootstrapTest.java:
##
@@ -0,0 +1,111 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+
[
https://issues.apache.org/jira/browse/KAFKA-18944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17933582#comment-17933582
]
Chia-Ping Tsai commented on KAFKA-18944:
a example of misusing:
https://github.
chia7712 commented on code in PR #19144:
URL: https://github.com/apache/kafka/pull/19144#discussion_r1986210326
##
clients/integration-tests/src/test/java/org/apache/kafka/clients/admin/AdminClientRebootstrapTest.java:
##
@@ -33,6 +32,9 @@
import java.util.concurrent.TimeUnit;
chia7712 commented on PR #19081:
URL: https://github.com/apache/kafka/pull/19081#issuecomment-2708604833
@clarkwtc could you please merge trunk to run CI again?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL a
wernerdv commented on code in PR #18074:
URL: https://github.com/apache/kafka/pull/18074#discussion_r1986122644
##
connect/runtime/src/main/java/org/apache/kafka/connect/util/KafkaBasedLog.java:
##
@@ -466,16 +466,16 @@ protected boolean readPartition(TopicPartition
topicPartit
mimaison commented on PR #19030:
URL: https://github.com/apache/kafka/pull/19030#issuecomment-2708369200
Rebased on trunk and ported
https://github.com/apache/kafka/commit/40db001588047201a406ebe969d1d7d2d5eefd57
--
This is an automated message from the Apache Git Service.
To respond to t
ashrivastava88 commented on code in PR #18074:
URL: https://github.com/apache/kafka/pull/18074#discussion_r1986112509
##
connect/runtime/src/main/java/org/apache/kafka/connect/util/KafkaBasedLog.java:
##
@@ -466,16 +466,16 @@ protected boolean readPartition(TopicPartition
topic
chia7712 merged PR #19146:
URL: https://github.com/apache/kafka/pull/19146
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
ijuma commented on PR #19131:
URL: https://github.com/apache/kafka/pull/19131#issuecomment-2704563232
Cherry-picked to 4.0.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
mjsax commented on code in PR #19164:
URL: https://github.com/apache/kafka/pull/19164#discussion_r1986165537
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java:
##
@@ -1153,8 +1157,7 @@ void handleRevocation(final Collection
revokedPartitions
[
https://issues.apache.org/jira/browse/KAFKA-2939?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias J. Sax updated KAFKA-2939:
---
Labels: (was: newbie)
> Make AbstractConfig.logUnused() tunable for clients
> -
mjsax commented on code in PR #19164:
URL: https://github.com/apache/kafka/pull/19164#discussion_r1986165537
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java:
##
@@ -1153,8 +1157,7 @@ void handleRevocation(final Collection
revokedPartitions
clarkwtc opened a new pull request, #19166:
URL: https://github.com/apache/kafka/pull/19166
Remove unused `saslServerProperties`, `saslClientProperties`,
`adminClientProperties`, `producerProperties`, and `consumerProperties` in
ClusterConfig.
First, I quickly fixed the unused adminC
[
https://issues.apache.org/jira/browse/KAFKA-18944?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Wei-Ting Chen reassigned KAFKA-18944:
-
Assignee: Wei-Ting Chen (was: Chia-Ping Tsai)
> Remove unused setters from ClusterConf
clarkwtc commented on PR #19081:
URL: https://github.com/apache/kafka/pull/19081#issuecomment-2708609581
@chia7712
No problem.
I've merged it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
[
https://issues.apache.org/jira/browse/KAFKA-18422?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Jacot updated KAFKA-18422:
Fix Version/s: 4.0.0
> add Kafka client upgrade path
> -
>
>
frankvicky commented on code in PR #17614:
URL: https://github.com/apache/kafka/pull/17614#discussion_r1986090241
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java:
##
@@ -427,7 +428,7 @@ public void onGroupAssignmentUpdated(Set
partit
mimaison commented on code in PR #19030:
URL: https://github.com/apache/kafka/pull/19030#discussion_r1986107143
##
storage/src/main/java/org/apache/kafka/storage/internals/log/UnifiedLog.java:
##
@@ -55,6 +113,2289 @@ public class UnifiedLog {
public static final String STR
chia7712 commented on code in PR #18685:
URL: https://github.com/apache/kafka/pull/18685#discussion_r1986118137
##
core/src/main/scala/kafka/server/metadata/KRaftMetadataCache.scala:
##
@@ -522,10 +522,14 @@ class KRaftMetadataCache(
if (kraftVersionLevel > 0) {
fina
mumrah commented on PR #19069:
URL: https://github.com/apache/kafka/pull/19069#issuecomment-2708307265
@sjhajharia can you merge trunk into this branch? There are some recent CI
changes that are needed. I will try to review this over the weekend.
--
This is an automated message from the A
Chirag Wadhwa created KAFKA-18931:
-
Summary: Debug the case where kafka-share-groups.sh --describe
--members does not match with the reality when share consumer is closed during
broker outage
Key: KAFKA-18931
URL
mumrah opened a new pull request, #19144:
URL: https://github.com/apache/kafka/pull/19144
Adds a new ":clients:integration-test" Gradle module with one example test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
mjsax commented on code in PR #18258:
URL: https://github.com/apache/kafka/pull/18258#discussion_r1984230751
##
docs/streams/upgrade-guide.html:
##
@@ -1735,73 +1735,38 @@
Streams API broker
compatibility
-The following table shows which versions of the Kafka Stre
lucasbru commented on code in PR #19121:
URL: https://github.com/apache/kafka/pull/19121#discussion_r1983675477
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/StreamsGroupHeartbeatRequestManager.java:
##
@@ -254,34 +284,131 @@ public StreamsGroupHeartbeatRe
lucasbru commented on code in PR #19164:
URL: https://github.com/apache/kafka/pull/19164#discussion_r1986031099
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java:
##
@@ -1153,8 +1157,7 @@ void handleRevocation(final Collection
revokedPartiti
[
https://issues.apache.org/jira/browse/KAFKA-18074?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Jacot updated KAFKA-18074:
Fix Version/s: (was: 4.0.0)
> Add kafka client compatibility matrix
>
cadonna commented on code in PR #19164:
URL: https://github.com/apache/kafka/pull/19164#discussion_r1986072577
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java:
##
@@ -1163,10 +1166,12 @@ void handleRevocation(final Collection
revokedPartit
[
https://issues.apache.org/jira/browse/KAFKA-18074?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Jacot updated KAFKA-18074:
Fix Version/s: 4.0.0
> Add kafka client compatibility matrix
> ---
sjhajharia commented on PR #19069:
URL: https://github.com/apache/kafka/pull/19069#issuecomment-2708215564
cc: @m1a2st / @mumrah for a final review
Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abov
[
https://issues.apache.org/jira/browse/KAFKA-18422?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Jacot updated KAFKA-18422:
Fix Version/s: (was: 4.0.0)
> add Kafka client upgrade path
> -
>
FrankYang0529 commented on code in PR #18685:
URL: https://github.com/apache/kafka/pull/18685#discussion_r1986040272
##
core/src/main/scala/kafka/server/metadata/KRaftMetadataCache.scala:
##
@@ -522,10 +522,14 @@ class KRaftMetadataCache(
if (kraftVersionLevel > 0) {
EsMoX commented on PR #19041:
URL: https://github.com/apache/kafka/pull/19041#issuecomment-2708346593
> @EsMoX I just noticed there's a superfluous newline in the error message
in the PR, can you remove it please? Thanks!
@kirktrue Done, Thank you!
--
This is an automated message
Parkerhiphop commented on PR #19134:
URL: https://github.com/apache/kafka/pull/19134#issuecomment-2708352912
Thanks for the testing and information provided.
I will take a look at these failed tests.
--
This is an automated message from the Apache Git Service.
To respond to the message,
cadonna commented on code in PR #19121:
URL: https://github.com/apache/kafka/pull/19121#discussion_r1982894114
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/StreamsGroupHeartbeatRequestManager.java:
##
@@ -254,34 +284,131 @@ public StreamsGroupHeartbeatReq
49 matches
Mail list logo
