LoganZhuZzz commented on code in PR #19087:
URL: https://github.com/apache/kafka/pull/19087#discussion_r1978857543
##
server-common/src/main/java/org/apache/kafka/server/config/ServerLogConfigs.java:
##
@@ -139,10 +139,12 @@ public class ServerLogConfigs {
public static f
LoganZhuZzz commented on code in PR #19087:
URL: https://github.com/apache/kafka/pull/19087#discussion_r1978861220
##
server-common/src/main/java/org/apache/kafka/server/config/ServerLogConfigs.java:
##
@@ -139,10 +139,12 @@ public class ServerLogConfigs {
public static f
LoganZhuZzz commented on code in PR #19087:
URL: https://github.com/apache/kafka/pull/19087#discussion_r1978871517
##
docs/zk2kraft.html:
##
@@ -241,6 +241,13 @@ Behavioral Change Reference
Configuration Value Size Limitation: KRaft mode
restricts configuration val
chia7712 commented on code in PR #18801:
URL: https://github.com/apache/kafka/pull/18801#discussion_r197530
##
metadata/src/main/java/org/apache/kafka/metadata/MetadataCache.java:
##
@@ -0,0 +1,237 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
frankvicky commented on code in PR #19087:
URL: https://github.com/apache/kafka/pull/19087#discussion_r1978893811
##
server-common/src/main/java/org/apache/kafka/server/config/ServerLogConfigs.java:
##
@@ -139,10 +139,12 @@ public class ServerLogConfigs {
public static fi
dengziming commented on code in PR #9766:
URL: https://github.com/apache/kafka/pull/9766#discussion_r1979277342
##
clients/src/main/java/org/apache/kafka/common/record/EndTransactionMarker.java:
##
@@ -95,32 +76,35 @@ public int hashCode() {
private static void ensureTran
[
https://issues.apache.org/jira/browse/KAFKA-17826?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
黃竣陽 updated KAFKA-17826:
External issue URL:
https://cwiki.apache.org/confluence/display/KAFKA/KIP-1140%3A+Avoid+to+return+null+value+in+Ma
[
https://issues.apache.org/jira/browse/KAFKA-17826?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
黃竣陽 updated KAFKA-17826:
External issue URL: (was:
https://cwiki.apache.org/confluence/display/KAFKA/KIP-1140%3A+Avoid+to+return+null+val
apoorvmittal10 opened a new pull request, #19091:
URL: https://github.com/apache/kafka/pull/19091
The PR corrects the way the locks are released on exception. As
`partitionsAcquired` can be a reference to `topicPartitionData`, hence the
locks should released prior clearing `partitionsAcquir
chirag-wadhwa5 commented on code in PR #18976:
URL: https://github.com/apache/kafka/pull/18976#discussion_r1979419763
##
clients/src/main/java/org/apache/kafka/clients/admin/internals/DeleteShareGroupOffsetsHandler.java:
##
@@ -0,0 +1,175 @@
+/*
+ * Licensed to the Apache Softwa
lucasbru commented on code in PR #19088:
URL: https://github.com/apache/kafka/pull/19088#discussion_r1979479030
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##
@@ -4308,9 +4308,18 @@ public void replay(
String groupId
AndrewJSchofield commented on PR #19057:
URL: https://github.com/apache/kafka/pull/19057#issuecomment-2697565099
> Could we use "composite" instead of "inheritance"?
>
> 1. move `DeleteGroupsResult` into internal package
> 2. add `delegate: DeleteGroupsResult` to `DeleteConsumerGrou
chia7712 commented on PR #19057:
URL: https://github.com/apache/kafka/pull/19057#issuecomment-2698014961
> I would rather go with copying the methods over this and eliminate
DeleteGroupsResult.
that is totally fine to me.
Furthermore, `DeleteConsumerGroupsResult` is now a stabl
chia7712 commented on PR #19065:
URL: https://github.com/apache/kafka/pull/19065#issuecomment-2697965375
the comments
https://github.com/apache/kafka/pull/19065#discussion_r1978828577 and
https://github.com/apache/kafka/pull/19065#discussion_r1979015629 are addressed
by the commit
https:/
clarkwtc commented on code in PR #19081:
URL: https://github.com/apache/kafka/pull/19081#discussion_r1979707246
##
server/src/main/java/org/apache/kafka/server/DynamicThreadPool.java:
##
@@ -0,0 +1,65 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
brandboat commented on PR #19097:
URL: https://github.com/apache/kafka/pull/19097#issuecomment-2698061552
Preview:
https://github.com/user-attachments/assets/0ff25869-78a2-4ae0-b971-39c4a6efe1a8";
/>
As the discussion on KIP-1124 is still ongoing and the content is quite
extensive
mumrah commented on code in PR #19094:
URL: https://github.com/apache/kafka/pull/19094#discussion_r1979713671
##
core/src/test/java/kafka/test/api/AdminClientRebootstrapTest.java:
##
@@ -0,0 +1,106 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ *
mumrah opened a new pull request, #19098:
URL: https://github.com/apache/kafka/pull/19098
The "pull_request_review" event has similar permissions to "pull_request".
Due to our repo config, we require approvals for non-committer PRs. This patch
allows the `ci-approved` label to approve the "
Lucas Brutschy created KAFKA-18917:
--
Summary: TransformValues with unnamed Materialized instance throws
NPE
Key: KAFKA-18917
URL: https://issues.apache.org/jira/browse/KAFKA-18917
Project: Kafka
smjn commented on PR #19057:
URL: https://github.com/apache/kafka/pull/19057#issuecomment-2697630616
> > Could we use "composite" instead of "inheritance"?
> >
> > 1. move `DeleteGroupsResult` into internal package
> > 2. add `delegate: DeleteGroupsResult` to `DeleteConsumerGroupsRe
leaf-soba commented on code in PR #18684:
URL: https://github.com/apache/kafka/pull/18684#discussion_r1979375219
##
server-common/src/main/java/org/apache/kafka/timeline/Snapshot.java:
##
@@ -47,7 +47,9 @@ T getDelta(Revertable owner) {
}
void setDelta(Revertable ow
dajac opened a new pull request, #19092:
URL: https://github.com/apache/kafka/pull/19092
We defined multiple `ConfigDef`s in `GroupCoordinatorConfig` in then we
merge them in a few places because we always use them together. Having multiple
`ConfigDef`s does not seem necessary to me. This p
chia7712 commented on code in PR #19065:
URL: https://github.com/apache/kafka/pull/19065#discussion_r1979644433
##
docs/ops.html:
##
@@ -4187,7 +4187,7 @@ org.apache.kafka.coordinator.group.api.assignor.ConsumerGroupPartitionAssignor
interface and specifying the full class name
dajac merged PR #19090:
URL: https://github.com/apache/kafka/pull/19090
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or
frankvicky opened a new pull request, #19095:
URL: https://github.com/apache/kafka/pull/19095
Some subpackages have already gone, so we don't need the import rule for
these non-exist modules.
--
This is an automated message from the Apache Git Service.
To respond to the message, please lo
chia7712 commented on PR #19065:
URL: https://github.com/apache/kafka/pull/19065#issuecomment-2697953108
@mingdaoy Sorry that I update your PR as we need to run RC1 for 4.0.0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
chia7712 commented on code in PR #19065:
URL: https://github.com/apache/kafka/pull/19065#discussion_r1979650916
##
docs/ops.html:
##
@@ -3920,7 +3920,7 @@ $ bin/kafka-metadata-quorum.sh
--command-config controller.properties --bootstrap-server localhost:9092
add-controller
ijuma commented on PR #19052:
URL: https://github.com/apache/kafka/pull/19052#issuecomment-2697980385
Hmm, is this the right thing to do? Removing examples doesn't seem like a
good thing. It's ok to say "X example requires Java 17 due to y dependency". We
want to allow users stuck on Java 1
MahsaSeifikar opened a new pull request, #19096:
URL: https://github.com/apache/kafka/pull/19096
This PR addresses minor grammar and clarity issues in zk2kraft.html doc.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
mumrah commented on code in PR #18684:
URL: https://github.com/apache/kafka/pull/18684#discussion_r1979666856
##
server-common/src/main/java/org/apache/kafka/timeline/Snapshot.java:
##
@@ -47,6 +48,7 @@ T getDelta(Revertable owner) {
}
void setDelta(Revertable owner
cadonna commented on code in PR #19089:
URL: https://github.com/apache/kafka/pull/19089#discussion_r1979473224
##
streams/src/main/java/org/apache/kafka/streams/kstream/internals/KTableImpl.java:
##
@@ -448,8 +448,12 @@ private KTable doTransformValues(final
ValueTransformerWi
[
https://issues.apache.org/jira/browse/KAFKA-18917?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Jacot updated KAFKA-18917:
Fix Version/s: 4.0.0
> TransformValues with unnamed Materialized instance throws NPE
> ---
mumrah commented on PR #18560:
URL: https://github.com/apache/kafka/pull/18560#issuecomment-2697456721
maxParallelForks 2
https://develocity.apache.org/s/x65mt52zf2o3o/timeline
https://github.com/user-attachments/assets/c879cec6-8d90-494a-85d7-3e4caa26db0d";
/>
Better th
dajac opened a new pull request, #19090:
URL: https://github.com/apache/kafka/pull/19090
The code in GroupMetadataManager to request metadata refresh got pretty ugly
with the addition of share and stream groups. It seems preferable to put the
method in the base class.
--
This is an
Apoorv Mittal created KAFKA-18918:
-
Summary: Share partition lock held for onComplete exception
Key: KAFKA-18918
URL: https://issues.apache.org/jira/browse/KAFKA-18918
Project: Kafka
Issue Ty
clarkwtc opened a new pull request, #19094:
URL: https://github.com/apache/kafka/pull/19094
Migrate AdminClientRebootstrapTest to the new test infra and remove the old
Scala test.
The test results
https://github.com/user-attachments/assets/ff4d21f4-561d-483e-8e7b-3de82ddacd2b";
/>
m1a2st commented on code in PR #19054:
URL: https://github.com/apache/kafka/pull/19054#discussion_r1979382072
##
core/src/test/scala/unit/kafka/coordinator/transaction/TransactionStateManagerTest.scala:
##
@@ -889,10 +889,13 @@ class TransactionStateManagerTest {
appendedRe
m1a2st commented on code in PR #18091:
URL: https://github.com/apache/kafka/pull/18091#discussion_r1979444016
##
docs/compatibility.html:
##
@@ -0,0 +1,206 @@
+
+
+
+
+
+
+
+
+
+With the release of Kafka 4.0, significant chang
[
https://issues.apache.org/jira/browse/KAFKA-18871?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17932325#comment-17932325
]
David Arthur commented on KAFKA-18871:
--
> the brokers in migration mode still want
[
https://issues.apache.org/jira/browse/KAFKA-18917?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Lucas Brutschy updated KAFKA-18917:
---
Priority: Blocker (was: Critical)
> TransformValues with unnamed Materialized instance thro
lucasbru opened a new pull request, #19089:
URL: https://github.com/apache/kafka/pull/19089
When `transformValues` is used with a `Materialized` instance, but without a
queryable name, a `NullPointerException` is thrown. To preserve the semantics
present in 3.9, we need to avoid materializa
cadonna commented on PR #18739:
URL: https://github.com/apache/kafka/pull/18739#issuecomment-2697493506
@loicgreffier
The first question we need to answer is the following:
Should the raw input record be (a) the record from which the defective
record that triggered the handler was
LoganZhuZzz commented on PR #19087:
URL: https://github.com/apache/kafka/pull/19087#issuecomment-2697426687
> @LoganZhuZzz If users configure the policy and the process role is broker,
we can log warning messages for them. What do you think? These changes can be
added to `KafkaConfig#valida
brandboat commented on PR #19097:
URL: https://github.com/apache/kafka/pull/19097#issuecomment-2698117087
> Not sure if KIP-1124 should also be linked in zk2kraft.html.
WDYT?
Thanks for the comment @frankvicky. Perhaps not? zk2kraft.html focuses on ZK
migration to KRaft, which seem
AndrewJSchofield merged PR #19091:
URL: https://github.com/apache/kafka/pull/19091
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafk
AndrewJSchofield merged PR #19086:
URL: https://github.com/apache/kafka/pull/19086
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafk
clarkwtc commented on code in PR #19094:
URL: https://github.com/apache/kafka/pull/19094#discussion_r1979844548
##
core/src/test/java/kafka/test/api/AdminClientRebootstrapTest.java:
##
@@ -0,0 +1,106 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+
cadonna commented on PR #19052:
URL: https://github.com/apache/kafka/pull/19052#issuecomment-2698239465
The plan is to remove it now for 4.0, get rid of the dependency to
connect-json, and re-add the example on trunk before 4.1.
--
This is an automated message from the Apache Git Service.
lucasbru merged PR #19089:
URL: https://github.com/apache/kafka/pull/19089
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
Mickael Maison created KAFKA-18919:
--
Summary: Clarify that KafkaPrincipalBuilder classes must also
implement KafkaPrincipalSerde
Key: KAFKA-18919
URL: https://issues.apache.org/jira/browse/KAFKA-18919
chia7712 commented on PR #19097:
URL: https://github.com/apache/kafka/pull/19097#issuecomment-2698376447
I'm going to merge this PR for 4.0 RC1, and we will keep tweaking the docs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitH
chia7712 merged PR #19097:
URL: https://github.com/apache/kafka/pull/19097
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
LoganZhuZzz commented on code in PR #19087:
URL: https://github.com/apache/kafka/pull/19087#discussion_r1979888458
##
core/src/main/scala/kafka/server/KafkaConfig.scala:
##
@@ -689,6 +692,9 @@ class KafkaConfig private(doLog: Boolean, val props:
util.Map[_, _])
if (contr
José Armando García Sancio created KAFKA-18920:
--
Summary: kafka-feature doesn't report the correct kraft.version
Key: KAFKA-18920
URL: https://issues.apache.org/jira/browse/KAFKA-18920
Pro
azhar2407 opened a new pull request, #19099:
URL: https://github.com/apache/kafka/pull/19099
After dynamically modifying the max.connections.per.ip configuration from
1000 to 1, the update initially worked as expected. However, after multiple
broker restarts, the value reverted
Wadimz commented on code in PR #19073:
URL: https://github.com/apache/kafka/pull/19073#discussion_r1979998192
##
.github/workflows/build.yml:
##
@@ -60,6 +60,7 @@ jobs:
load-catalog:
needs: [configure]
runs-on: ubuntu-latest
+if: ${{ !github.event.repository.for
mumrah commented on PR #18560:
URL: https://github.com/apache/kafka/pull/18560#issuecomment-2698591377
maxParallelForks 4
https://github.com/user-attachments/assets/8cb255c6-7b1a-40c2-9d3b-c3bdbf54941c";
/>
Interestingly, for this run, `:core:test` was a good bit faster, but ot
kevin-wu24 commented on code in PR #18949:
URL: https://github.com/apache/kafka/pull/18949#discussion_r1980252103
##
core/src/main/scala/kafka/server/DynamicBrokerConfig.scala:
##
@@ -192,6 +197,37 @@ object DynamicBrokerConfig {
}
props
}
+
+ private[server] def r
[
https://issues.apache.org/jira/browse/KAFKA-18477?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17932421#comment-17932421
]
Jun Rao commented on KAFKA-18477:
-
So, to summarize, we can remove the usage of OffsetFo
kevin-wu24 commented on code in PR #18949:
URL: https://github.com/apache/kafka/pull/18949#discussion_r1980252103
##
core/src/main/scala/kafka/server/DynamicBrokerConfig.scala:
##
@@ -192,6 +197,37 @@ object DynamicBrokerConfig {
}
props
}
+
+ private[server] def r
mumrah commented on PR #18560:
URL: https://github.com/apache/kafka/pull/18560#issuecomment-2698997750
With 6 workers and 4 max forks
https://develocity.apache.org/s/zwzovvnv5zjaw/timeline?sort=longest
https://github.com/user-attachments/assets/c57e7e75-0bb5-4359-9b64-9ce6e445fa
David Arthur created KAFKA-18921:
Summary: Low CPU utilization during streams integration tests
Key: KAFKA-18921
URL: https://issues.apache.org/jira/browse/KAFKA-18921
Project: Kafka
Issue Ty
kevin-wu24 commented on code in PR #18949:
URL: https://github.com/apache/kafka/pull/18949#discussion_r1980343813
##
core/src/main/scala/kafka/server/DynamicBrokerConfig.scala:
##
@@ -192,6 +197,37 @@ object DynamicBrokerConfig {
}
props
}
+
+ private[server] def r
mumrah commented on code in PR #19094:
URL: https://github.com/apache/kafka/pull/19094#discussion_r1980052523
##
core/src/test/java/kafka/test/api/AdminClientRebootstrapTest.java:
##
@@ -84,7 +85,8 @@ public void testRebootstrap(ClusterInstance clusterInstance)
throws Execution
[
https://issues.apache.org/jira/browse/KAFKA-18916?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Jacot resolved KAFKA-18916.
-
Resolution: Fixed
> Resolved regular expressions must update the group by topics data structure
dajac commented on PR #19065:
URL: https://github.com/apache/kafka/pull/19065#issuecomment-2697847100
@mingdaoy Would you have time for addressing the remaining open comment?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
frankvicky opened a new pull request, #19093:
URL: https://github.com/apache/kafka/pull/19093
JIRA: KAFKA-18424
PlaintextAdminIntegrationTest#testConsumerGroups test too many things. We
should split it into smaller units.
--
This is an automated message from the Apache Git
frankvicky commented on code in PR #19094:
URL: https://github.com/apache/kafka/pull/19094#discussion_r1979621457
##
core/src/test/java/kafka/test/api/AdminClientRebootstrapTest.java:
##
@@ -0,0 +1,106 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
dajac merged PR #19088:
URL: https://github.com/apache/kafka/pull/19088
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or
brandboat commented on PR #18983:
URL: https://github.com/apache/kafka/pull/18983#issuecomment-2697870661
> Could you just reduce the length of the PR title because a linter is
complaining? I will also leave this open for another day in case any of the
other reviewers have blocking comments
mumrah commented on PR #18560:
URL: https://github.com/apache/kafka/pull/18560#issuecomment-2697926936
maxParallelForks 3
https://develocity.apache.org/s/j5rg72fru7uky/timeline
https://github.com/user-attachments/assets/024c4477-8803-4c9f-a897-1c9a4a5b3160";
/>
Good util
[
https://issues.apache.org/jira/browse/KAFKA-17808?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jhen-Yung Hsu reassigned KAFKA-17808:
-
Assignee: Jhen-Yung Hsu (was: Greg Harris)
> InstanceAlreadyExistsException:
> kafka.
brandboat opened a new pull request, #19097:
URL: https://github.com/apache/kafka/pull/19097
Add client upgrade documentation, for more information, please refer to
https://cwiki.apache.org/confluence/display/KAFKA/KIP-1124%3A+Providing+a+clear+Kafka+Client+upgrade+path+for+4.x
--
This is
clarkwtc commented on code in PR #19081:
URL: https://github.com/apache/kafka/pull/19081#discussion_r1979704994
##
server/src/main/java/org/apache/kafka/server/DynamicThreadPool.java:
##
@@ -0,0 +1,65 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
ukpagrace commented on PR #18673:
URL: https://github.com/apache/kafka/pull/18673#issuecomment-2698478874
hey @bbejeck yes i am still able to work on it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
chia7712 merged PR #19065:
URL: https://github.com/apache/kafka/pull/19065
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
junrao commented on PR #19065:
URL: https://github.com/apache/kafka/pull/19065#issuecomment-2698449640
@mingdaoy : Thanks for the PR. The three links to `here` below in
upgrade.html didn't work. Not sure if they are fixed by this PR or not.
```
The Next Gene
clarkwtc commented on code in PR #19094:
URL: https://github.com/apache/kafka/pull/19094#discussion_r1979838553
##
core/src/test/java/kafka/test/api/AdminClientRebootstrapTest.java:
##
@@ -0,0 +1,106 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+
[
https://issues.apache.org/jira/browse/KAFKA-18651?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Lucas Brutschy reassigned KAFKA-18651:
--
Assignee: Alieh Saeedi (was: Lucas Brutschy)
> Core streams-specific broker configur
[
https://issues.apache.org/jira/browse/KAFKA-18919?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Szu-Yung Wang reassigned KAFKA-18919:
-
Assignee: Szu-Yung Wang
> Clarify that KafkaPrincipalBuilder classes must also implemen
chia7712 commented on code in PR #19087:
URL: https://github.com/apache/kafka/pull/19087#discussion_r1979811935
##
core/src/main/scala/kafka/server/KafkaConfig.scala:
##
@@ -689,6 +692,9 @@ class KafkaConfig private(doLog: Boolean, val props:
util.Map[_, _])
if (controll
cmccabe merged PR #19096:
URL: https://github.com/apache/kafka/pull/19096
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.
azhar2407 closed pull request #19084: KAFKA-18637: Fix max connections per ip
and override reconfiguration
URL: https://github.com/apache/kafka/pull/19084
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to g
kevin-wu24 commented on code in PR #18949:
URL: https://github.com/apache/kafka/pull/18949#discussion_r1980228836
##
core/src/main/scala/kafka/server/BrokerServer.scala:
##
@@ -194,6 +194,7 @@ class BrokerServer(
val clientMetricsReceiverPlugin = new ClientMetricsReceiv
mimaison commented on PR #19068:
URL: https://github.com/apache/kafka/pull/19068#issuecomment-2698282975
While reviewing KIP-877 I found there's an issue with the tags for some
server side plugins. This is the case for ClientQuotaCallback.
When running in combined mode, 2 instances of
[
https://issues.apache.org/jira/browse/KAFKA-18652?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Lucas Brutschy reassigned KAFKA-18652:
--
Assignee: Alieh Saeedi (was: Bill Bejeck)
> Extended set of streams-specific broker
[
https://issues.apache.org/jira/browse/KAFKA-18876?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai resolved KAFKA-18876.
Resolution: Fixed
trunk:
https://github.com/apache/kafka/commit/8533c43c9d10c3c591e2dfadb
mimaison commented on PR #19068:
URL: https://github.com/apache/kafka/pull/19068#issuecomment-2698284605
I converted the PR to draft while I update the KIP.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
chia7712 commented on PR #19065:
URL: https://github.com/apache/kafka/pull/19065#issuecomment-2698227274
cherry-pick to 4.0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
cmccabe commented on code in PR #18949:
URL: https://github.com/apache/kafka/pull/18949#discussion_r1980164851
##
core/src/main/scala/kafka/server/BrokerServer.scala:
##
@@ -194,6 +194,7 @@ class BrokerServer(
val clientMetricsReceiverPlugin = new ClientMetricsReceiverP
cmccabe commented on code in PR #18949:
URL: https://github.com/apache/kafka/pull/18949#discussion_r1980168540
##
core/src/main/scala/kafka/server/DynamicBrokerConfig.scala:
##
@@ -192,6 +197,37 @@ object DynamicBrokerConfig {
}
props
}
+
+ private[server] def read
kevin-wu24 commented on code in PR #18987:
URL: https://github.com/apache/kafka/pull/18987#discussion_r1980459283
##
raft/src/test/java/org/apache/kafka/raft/RaftEventSimulationTest.java:
##
@@ -117,40 +126,58 @@ public class RaftEventSimulationTest {
void canElectInitialLe
kevin-wu24 commented on code in PR #18987:
URL: https://github.com/apache/kafka/pull/18987#discussion_r1980465079
##
raft/src/test/java/org/apache/kafka/raft/RaftEventSimulationTest.java:
##
@@ -297,18 +309,83 @@ void canMakeProgressIfMajorityIsReachable(
scheduler.runU
kevin-wu24 commented on code in PR #18987:
URL: https://github.com/apache/kafka/pull/18987#discussion_r1980466623
##
raft/src/test/java/org/apache/kafka/raft/RaftEventSimulationTest.java:
##
@@ -475,6 +537,104 @@ void canRecoverFromSingleNodeCommittedDataLoss(
scheduler
ahuang98 commented on code in PR #18987:
URL: https://github.com/apache/kafka/pull/18987#discussion_r1980498577
##
raft/src/test/java/org/apache/kafka/raft/RaftEventSimulationTest.java:
##
@@ -297,18 +309,83 @@ void canMakeProgressIfMajorityIsReachable(
scheduler.runUnt
ahuang98 commented on code in PR #18987:
URL: https://github.com/apache/kafka/pull/18987#discussion_r1980497653
##
raft/src/test/java/org/apache/kafka/raft/RaftEventSimulationTest.java:
##
@@ -297,18 +309,83 @@ void canMakeProgressIfMajorityIsReachable(
scheduler.runUnt
ahuang98 commented on code in PR #18987:
URL: https://github.com/apache/kafka/pull/18987#discussion_r1980496555
##
raft/src/test/java/org/apache/kafka/raft/RaftEventSimulationTest.java:
##
@@ -117,40 +126,58 @@ public class RaftEventSimulationTest {
void canElectInitialLead
[
https://issues.apache.org/jira/browse/KAFKA-14190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17932472#comment-17932472
]
Bingkun commented on KAFKA-14190:
-
I know what is causing the issue(using the AdminZkCli
ahuang98 commented on code in PR #18987:
URL: https://github.com/apache/kafka/pull/18987#discussion_r1980500044
##
raft/src/test/java/org/apache/kafka/raft/RaftEventSimulationTest.java:
##
@@ -297,18 +309,83 @@ void canMakeProgressIfMajorityIsReachable(
scheduler.runUnt
[
https://issues.apache.org/jira/browse/KAFKA-18477?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17932499#comment-17932499
]
Chia-Ping Tsai commented on KAFKA-18477:
[~junrao] thanks for your patience!.
{q
1 - 100 of 182 matches
Mail list logo
