Re: [PR] KAFKA-18706: Move AclPublisher to metadata module [kafka]

2025-02-27 Thread via GitHub
FrankYang0529 commented on code in PR #18802: URL: https://github.com/apache/kafka/pull/18802#discussion_r1973058360 ## metadata/src/main/java/org/apache/kafka/metadata/publisher/AclPublisher.java: ## @@ -0,0 +1,108 @@ +/* + * Licensed to the Apache Software Foundation (ASF) und

Re: [PR] KAFKA-18868: add the "default value" explanation to the docs of num.replica.alter.log.dirs.threads [kafka]

2025-02-27 Thread via GitHub
chia7712 commented on code in PR #19038: URL: https://github.com/apache/kafka/pull/19038#discussion_r1973070151 ## server/src/main/java/org/apache/kafka/server/config/ServerConfigs.java: ## @@ -52,7 +52,8 @@ public class ServerConfigs { public static final String BACKGROUND

Re: [PR] KAFKA-18706: Move AclPublisher to metadata module [kafka]

2025-02-27 Thread via GitHub
FrankYang0529 commented on code in PR #18802: URL: https://github.com/apache/kafka/pull/18802#discussion_r1973100776 ## metadata/src/main/java/org/apache/kafka/metadata/publisher/AclPublisher.java: ## @@ -0,0 +1,108 @@ +/* + * Licensed to the Apache Software Foundation (ASF) und

Re: [PR] KAFKA-18849: Add "strict min ISR" to the docs of "min.insync.replicas" [kafka]

2025-02-27 Thread via GitHub
chia7712 commented on PR #19016: URL: https://github.com/apache/kafka/pull/19016#issuecomment-2687190842 cherry-pick to 4.0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] KAFKA-18849: Add "strict min ISR" to the docs of "min.insync.replicas" [kafka]

2025-02-27 Thread via GitHub
chia7712 merged PR #19016: URL: https://github.com/apache/kafka/pull/19016 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

[jira] [Resolved] (KAFKA-18849) add "strict min ISR" to the docs of "min.insync.replicas"

2025-02-27 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18849?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai resolved KAFKA-18849. Resolution: Fixed trunk: [https://github.com/apache/kafka/commit/269e2d898b76b5c9c58232c3

Re: [PR] KAFKA-18706: Move AclPublisher to metadata module [kafka]

2025-02-27 Thread via GitHub
chia7712 commented on code in PR #18802: URL: https://github.com/apache/kafka/pull/18802#discussion_r1973092684 ## metadata/src/main/java/org/apache/kafka/metadata/publisher/AclPublisher.java: ## @@ -0,0 +1,108 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under on

[jira] [Assigned] (KAFKA-18870) implement describeDelegationToken for controller

2025-02-27 Thread Szu-Yung Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18870?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Szu-Yung Wang reassigned KAFKA-18870: - Assignee: Szu-Yung Wang (was: TaiJuWu) > implement describeDelegationToken for control

Re: [PR] KAFKA-18276 Migrate RebootstrapTest to new test infra [kafka]

2025-02-27 Thread via GitHub
m1a2st commented on code in PR #19046: URL: https://github.com/apache/kafka/pull/19046#discussion_r1973122449 ## core/src/test/java/kafka/test/api/ProducerRebootstrapTest.java: ## @@ -0,0 +1,121 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * co

Re: [PR] [MINOR] Clean up coordinator-common and server modules [kafka]

2025-02-27 Thread via GitHub
chia7712 merged PR #19009: URL: https://github.com/apache/kafka/pull/19009 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

Re: [PR] KAFKA-17565: Move MetadataCache interface to metadata module [kafka]

2025-02-27 Thread via GitHub
chia7712 commented on code in PR #18801: URL: https://github.com/apache/kafka/pull/18801#discussion_r1973109296 ## core/src/main/scala/kafka/server/metadata/KRaftMetadataCache.scala: ## @@ -345,68 +352,75 @@ class KRaftMetadataCache( Option(_currentImage.cluster.broker(bro

[jira] [Created] (KAFKA-18880) Remove kafka.cluster.Broker and BrokerEndPointNotAvailableException

2025-02-27 Thread Chia-Ping Tsai (Jira)
Chia-Ping Tsai created KAFKA-18880: -- Summary: Remove kafka.cluster.Broker and BrokerEndPointNotAvailableException Key: KAFKA-18880 URL: https://issues.apache.org/jira/browse/KAFKA-18880 Project: Kafk

[jira] [Created] (KAFKA-18886) add behavior change of CreateTopicPolicy and AlterConfigPolicy to zk2kraft

2025-02-27 Thread Chia-Ping Tsai (Jira)
Chia-Ping Tsai created KAFKA-18886: -- Summary: add behavior change of CreateTopicPolicy and AlterConfigPolicy to zk2kraft Key: KAFKA-18886 URL: https://issues.apache.org/jira/browse/KAFKA-18886 Projec

[jira] [Commented] (KAFKA-18882) Move BaseKey, TxnKey, and UnknownKey to transaction-coordinator module

2025-02-27 Thread Dmitry Werner (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17931118#comment-17931118 ] Dmitry Werner commented on KAFKA-18882: --- [~chia7712] Hello, can I work on this tas

[jira] [Updated] (KAFKA-18871) KRaft migration rollback causes downtime

2025-02-27 Thread Daniel Urban (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18871?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Urban updated KAFKA-18871: - Attachment: kraft-rollback-bug.zip > KRaft migration rollback causes downtime >

[PR] KAFKA-18860: Remove Missing Features [kafka]

2025-02-27 Thread via GitHub
frankvicky opened a new pull request, #19048: URL: https://github.com/apache/kafka/pull/19048 JIRA: KAFKA-18860 The content of Missing Features has been documented in zk2kraft.html. Hence, we could remove it Reviewers: -- This is an automated message from the Apache Git

[jira] [Commented] (KAFKA-18860) Clarify the KRaft missing feature

2025-02-27 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18860?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17931107#comment-17931107 ] Chia-Ping Tsai commented on KAFKA-18860: in the zk2kraft, we have write down the

[jira] [Updated] (KAFKA-18860) Clarify the KRaft missing feature

2025-02-27 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18860?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai updated KAFKA-18860: --- Fix Version/s: 4.0.0 > Clarify the KRaft missing feature > -

[jira] [Created] (KAFKA-18885) document the behavioral differences between ZooKeeper and KRaft

2025-02-27 Thread Chia-Ping Tsai (Jira)
Chia-Ping Tsai created KAFKA-18885: -- Summary: document the behavioral differences between ZooKeeper and KRaft Key: KAFKA-18885 URL: https://issues.apache.org/jira/browse/KAFKA-18885 Project: Kafka

[jira] [Updated] (KAFKA-18860) Clarify the KRaft missing feature

2025-02-27 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18860?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai updated KAFKA-18860: --- Parent: KAFKA-18885 Issue Type: Sub-task (was: Bug) > Clarify the KRaft missing fea

[jira] [Commented] (KAFKA-18886) add behavior change of CreateTopicPolicy and AlterConfigPolicy to zk2kraft

2025-02-27 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18886?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17931109#comment-17931109 ] Chia-Ping Tsai commented on KAFKA-18886: Additionally, we should update the docu

[jira] [Commented] (KAFKA-18871) KRaft migration rollback causes downtime

2025-02-27 Thread Daniel Urban (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18871?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17931121#comment-17931121 ] Daniel Urban commented on KAFKA-18871: -- [~showuon] Thank you for checking this! I

Re: [PR] KAFKA-18734: Implemented share partition metrics (KIP-1103) [kafka]

2025-02-27 Thread via GitHub
AndrewJSchofield commented on code in PR #19045: URL: https://github.com/apache/kafka/pull/19045#discussion_r1973396006 ## core/src/main/java/kafka/server/share/SharePartition.java: ## @@ -1265,19 +1289,7 @@ boolean canAcquireRecords() { if (nextFetchOffset() != endOffs

Re: [PR] KAFKA-16718-2/n: KafkaAdminClient and GroupCoordinator implementation for DeleteShareGroupOffsets RPC [kafka]

2025-02-27 Thread via GitHub
AndrewJSchofield commented on code in PR #18976: URL: https://github.com/apache/kafka/pull/18976#discussion_r1973409686 ## clients/src/main/java/org/apache/kafka/clients/admin/DeleteShareGroupOffsetsResult.java: ## @@ -0,0 +1,97 @@ +/* + * Licensed to the Apache Software Foundat

Re: [PR] KAFKA-18617 Allow use of ClusterInstance inside BeforeEach [kafka]

2025-02-27 Thread via GitHub
chia7712 commented on code in PR #18662: URL: https://github.com/apache/kafka/pull/18662#discussion_r1973443282 ## test-common/test-common-runtime/src/test/java/org/apache/kafka/common/test/junit/ClusterTestBeforeEachTest.java: ## @@ -0,0 +1,59 @@ +/* + * Licensed to the Apache

Re: [PR] KAFKA-18804: Remove slf4j warning when using tool script [kafka]

2025-02-27 Thread via GitHub
Yunyung commented on code in PR #18918: URL: https://github.com/apache/kafka/pull/18918#discussion_r1973445909 ## build.gradle: ## @@ -2485,7 +2485,9 @@ project(':tools') { from (configurations.runtimeClasspath) { exclude('kafka-clients*') } -from (configura

[jira] [Commented] (KAFKA-18871) KRaft migration rollback causes downtime

2025-02-27 Thread Daniel Urban (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18871?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17931133#comment-17931133 ] Daniel Urban commented on KAFKA-18871: -- [~ppatierno] Thanks for checking the logs.

[jira] [Created] (KAFKA-18887) Implement Admin API extensions beyond list/describe group (delete group, offset-related APIs)

2025-02-27 Thread Alieh Saeedi (Jira)
Alieh Saeedi created KAFKA-18887: Summary: Implement Admin API extensions beyond list/describe group (delete group, offset-related APIs) Key: KAFKA-18887 URL: https://issues.apache.org/jira/browse/KAFKA-18887

[jira] [Updated] (KAFKA-18887) Implement Admin API extensions beyond list/describe group (delete group, offset-related APIs)

2025-02-27 Thread Alieh Saeedi (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18887?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alieh Saeedi updated KAFKA-18887: - Description: * add methods for describing and manipulating offsets as described in KIP-1071 *

[jira] [Assigned] (KAFKA-18887) Implement Admin API extensions beyond list/describe group (delete group, offset-related APIs)

2025-02-27 Thread Alieh Saeedi (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18887?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alieh Saeedi reassigned KAFKA-18887: Assignee: Alieh Saeedi > Implement Admin API extensions beyond list/describe group (delet

[PR] KAFKA-18887 Implement Streams Admin APIs [kafka]

2025-02-27 Thread via GitHub
aliehsaeedii opened a new pull request, #19049: URL: https://github.com/apache/kafka/pull/19049 https://issues.apache.org/jira/browse/KAFKA-18887 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] MINOR: Remove unused system test code and avoid misleading `quorum.zk` references [kafka]

2025-02-27 Thread via GitHub
m1a2st commented on code in PR #19034: URL: https://github.com/apache/kafka/pull/19034#discussion_r1973418908 ## tests/kafkatest/services/kafka/quorum.py: ## @@ -14,14 +14,10 @@ # limitations under the License. # the types of metadata quorums we support -zk = 'ZK' # ZooKeepe

[jira] [Created] (KAFKA-18888) Add support for Authorizer

2025-02-27 Thread Mickael Maison (Jira)
Mickael Maison created KAFKA-1: -- Summary: Add support for Authorizer Key: KAFKA-1 URL: https://issues.apache.org/jira/browse/KAFKA-1 Project: Kafka Issue Type: Sub-task

[jira] [Commented] (KAFKA-18871) KRaft migration rollback causes downtime

2025-02-27 Thread Paolo Patierno (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18871?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17931126#comment-17931126 ] Paolo Patierno commented on KAFKA-18871: I had a look at the operator log and it

[jira] [Created] (KAFKA-18889) Make records in ShareFetchResponse non-nullable

2025-02-27 Thread Apoorv Mittal (Jira)
Apoorv Mittal created KAFKA-18889: - Summary: Make records in ShareFetchResponse non-nullable Key: KAFKA-18889 URL: https://issues.apache.org/jira/browse/KAFKA-18889 Project: Kafka Issue Type:

[jira] [Assigned] (KAFKA-18886) add behavior change of CreateTopicPolicy and AlterConfigPolicy to zk2kraft

2025-02-27 Thread Logan Zhu (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18886?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Logan Zhu reassigned KAFKA-18886: - Assignee: Logan Zhu (was: Chia-Ping Tsai) > add behavior change of CreateTopicPolicy and Alter

Re: [PR] KAFKA-18827: Initialize share group state group coordinator impl. [3/N] [kafka]

2025-02-27 Thread via GitHub
AndrewJSchofield commented on code in PR #19026: URL: https://github.com/apache/kafka/pull/19026#discussion_r1973313677 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -463,6 +472,19 @@ GroupMetadataManager build() { *

Re: [PR] KAFKA-18860: Remove Missing Features [kafka]

2025-02-27 Thread via GitHub
frankvicky commented on PR #19048: URL: https://github.com/apache/kafka/pull/19048#issuecomment-2687668866 It was between "Deploying Considerations" and "ZooKeeper to KRaft Migration". Now it's gone. Preview: ![未命名設計](https://github.com/user-attachments/assets/1ecdf6a6-204c-48a1-9d24-

[jira] [Assigned] (KAFKA-18882) Move BaseKey, TxnKey, and UnknownKey to transaction-coordinator module

2025-02-27 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18882?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai reassigned KAFKA-18882: -- Assignee: xuanzhang gong (was: Chia-Ping Tsai) > Move BaseKey, TxnKey, and UnknownKe

[jira] [Commented] (KAFKA-18882) Move BaseKey, TxnKey, and UnknownKey to transaction-coordinator module

2025-02-27 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17931130#comment-17931130 ] Chia-Ping Tsai commented on KAFKA-18882: [~javakillah] sorry that we are working

Re: [PR] KAFKA-18734: Implemented share partition metrics (KIP-1103) [kafka]

2025-02-27 Thread via GitHub
apoorvmittal10 commented on code in PR #19045: URL: https://github.com/apache/kafka/pull/19045#discussion_r1973509905 ## server/src/main/java/org/apache/kafka/server/share/metrics/SharePartitionMetrics.java: ## @@ -0,0 +1,166 @@ +/* + * Licensed to the Apache Software Foundation

Re: [PR] KAFKA-18371 TopicBasedRemoteLogMetadataManagerConfig exposes sensitive configuration data in logs [kafka]

2025-02-27 Thread via GitHub
Wadimz commented on PR #18349: URL: https://github.com/apache/kafka/pull/18349#issuecomment-2687852370 thanks for reminder! I've updated the branch from trunk. @chia7712 could you please check when have time? thanks! -- This is an automated message from the Apache Git Service. To respond

Re: [PR] KAFKA-18734: Implemented share partition metrics (KIP-1103) [kafka]

2025-02-27 Thread via GitHub
apoorvmittal10 commented on code in PR #19045: URL: https://github.com/apache/kafka/pull/19045#discussion_r1973510264 ## server/src/main/java/org/apache/kafka/server/share/metrics/SharePartitionMetrics.java: ## @@ -0,0 +1,166 @@ +/* + * Licensed to the Apache Software Foundation

Re: [PR] KAFKA-18827: Initialize share group state group coordinator impl. [3/N] [kafka]

2025-02-27 Thread via GitHub
smjn commented on PR #19026: URL: https://github.com/apache/kafka/pull/19026#issuecomment-2687877409 @AndrewJSchofield Thanks for the review, incorporated changes -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] WIP Investigate OOM [kafka]

2025-02-27 Thread via GitHub
ijuma commented on code in PR #19031: URL: https://github.com/apache/kafka/pull/19031#discussion_r1973623540 ## build.gradle: ## @@ -54,7 +54,7 @@ ext { buildVersionFileName = "kafka-version.properties" defaultMaxHeapSize = "2g" - defaultJvmArgs = ["-Xss4m", "-XX:+UsePa

[jira] [Commented] (KAFKA-18871) KRaft migration rollback causes downtime

2025-02-27 Thread Daniel Urban (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18871?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17931172#comment-17931172 ] Daniel Urban commented on KAFKA-18871: -- [~ppatierno] I agree that this issue does n

Re: [PR] KAFKA-6829: Retry commits on unknown topic or partition [kafka]

2025-02-27 Thread via GitHub
aminaaddd commented on PR #4948: URL: https://github.com/apache/kafka/pull/4948#issuecomment-2689167200 | ERROR:root:Error: KafkaError{code=UNKNOWN_TOPIC_OR_PART,val=3,str="Subscribed topic not available: housing_topic: Broker: Unknown topic or partition"} i have this problem and i d

[jira] [Assigned] (KAFKA-18894) Add support for ConfigProvider

2025-02-27 Thread Jhen-Yung Hsu (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18894?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jhen-Yung Hsu reassigned KAFKA-18894: - Assignee: Jhen-Yung Hsu > Add support for ConfigProvider >

Re: [PR] KAFKA-18864:remove the Evolving tag from stable public interfaces [kafka]

2025-02-27 Thread via GitHub
junrao commented on code in PR #19036: URL: https://github.com/apache/kafka/pull/19036#discussion_r1974060328 ## clients/src/main/java/org/apache/kafka/clients/admin/AbortTransactionOptions.java: ## @@ -16,9 +16,7 @@ */ package org.apache.kafka.clients.admin; -import org.ap

[jira] [Assigned] (KAFKA-18891) Add support for RemoteLogMetadataManager and RemoteStorageManager

2025-02-27 Thread TaiJuWu (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18891?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] TaiJuWu reassigned KAFKA-18891: --- Assignee: TaiJuWu > Add support for RemoteLogMetadataManager and RemoteStorageManager > ---

Re: [PR] HOTFIX: remove PageView example to support Java11 for :streams:examples module [kafka]

2025-02-27 Thread via GitHub
gharris1727 commented on code in PR #19052: URL: https://github.com/apache/kafka/pull/19052#discussion_r1974314924 ## docs/streams/developer-guide/datatypes.html: ## @@ -156,11 +156,9 @@ Primitive and basic types JSON -The Kafka Streams code examples also includ

[jira] [Assigned] (KAFKA-14488) Move log layer tests to storage module

2025-02-27 Thread TaiJuWu (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14488?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] TaiJuWu reassigned KAFKA-14488: --- Assignee: TaiJuWu > Move log layer tests to storage module > --

Re: [PR] MINOR: Add README.md test command [kafka]

2025-02-27 Thread via GitHub
chia7712 commented on code in PR #19025: URL: https://github.com/apache/kafka/pull/19025#discussion_r1974442226 ## README.md: ## @@ -75,6 +76,7 @@ Retries are disabled by default, but you can set maxTestRetryFailures and maxTes The following example declares -PmaxTestRetries=1

[jira] [Commented] (KAFKA-18891) Add support for RemoteLogMetadataManager and RemoteStorageManager

2025-02-27 Thread Mickael Maison (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17931280#comment-17931280 ] Mickael Maison commented on KAFKA-18891: Sure, it's unassigned so feel free to g

[PR] HOTFIX: remove PageView example to support Java11 for :streams:examples module [kafka]

2025-02-27 Thread via GitHub
mjsax opened a new pull request, #19052: URL: https://github.com/apache/kafka/pull/19052 The PageView example depends on Connect to pull in Json (de)serializers, but Connect does not support Java11 any longer. To allow supporting Java11 for the Kafka Streams examples, this PR removes

[jira] [Assigned] (KAFKA-18892) Add support for ClientQuotaCallback

2025-02-27 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-18892?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] 黃竣陽 reassigned KAFKA-18892: --- Assignee: 黃竣陽 > Add support for ClientQuotaCallback > --- > >

[jira] [Assigned] (KAFKA-18896) Add support for Login

2025-02-27 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-18896?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] 黃竣陽 reassigned KAFKA-18896: --- Assignee: 黃竣陽 > Add support for Login > - > > Key: KAFKA-18896 >

Re: [PR] MINOR: Extract HeartbeatRequestState from heartbeat request managers [kafka]

2025-02-27 Thread via GitHub
cadonna commented on code in PR #19043: URL: https://github.com/apache/kafka/pull/19043#discussion_r1974015099 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestState.java: ## @@ -0,0 +1,107 @@ +/* + * Licensed to the Apache Software Foundation

[jira] [Commented] (KAFKA-18898) 4.0 Upgrade docs rendering below other versions

2025-02-27 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-18898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17931318#comment-17931318 ] 黃竣陽 commented on KAFKA-18898: - Hello [~davidarthur] ,The {{zk2kraft}} page has been moved to

Re: [PR] KAFKA-18860: Remove Missing Features section [kafka]

2025-02-27 Thread via GitHub
chia7712 commented on PR #19048: URL: https://github.com/apache/kafka/pull/19048#issuecomment-2689265249 cherry-pick to 4.0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific commen

Re: [PR] KAFKA-18860: Remove Missing Features section [kafka]

2025-02-27 Thread via GitHub
chia7712 merged PR #19048: URL: https://github.com/apache/kafka/pull/19048 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

[jira] [Updated] (KAFKA-18371) TopicBasedRemoteLogMetadataManagerConfig exposes sensitive configuration data in logs

2025-02-27 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18371?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai updated KAFKA-18371: --- Fix Version/s: 4.1.0 (was: 4.1) > TopicBasedRemoteLogMetadataManagerC

Re: [PR] KAFKA-18371 TopicBasedRemoteLogMetadataManagerConfig exposes sensitive configuration data in logs [kafka]

2025-02-27 Thread via GitHub
chia7712 merged PR #18349: URL: https://github.com/apache/kafka/pull/18349 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

Re: [PR] KAFKA-18860: Remove Missing Features section [kafka]

2025-02-27 Thread via GitHub
chia7712 commented on PR #19048: URL: https://github.com/apache/kafka/pull/19048#issuecomment-2689263012 for future reviewers, I have opened https://issues.apache.org/jira/browse/KAFKA-18885 to add the "behavioral differences between ZooKeeper and KRaft" - that will include the missing fea

[jira] [Resolved] (KAFKA-18860) Clarify the KRaft missing feature

2025-02-27 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18860?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai resolved KAFKA-18860. Resolution: Fixed trunk: [https://github.com/apache/kafka/commit/e2d9ced098c35068900746af

Re: [PR] MINOR: correct an ELR test name in ActivationRecordsGeneratorTest [kafka]

2025-02-27 Thread via GitHub
junrao merged PR #19044: URL: https://github.com/apache/kafka/pull/19044 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.o

[jira] [Assigned] (KAFKA-18817) ShareGroupHeartbeat and ShareGroupDescribe API must check topic describe

2025-02-27 Thread Lan Ding (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18817?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lan Ding reassigned KAFKA-18817: Assignee: Lan Ding (was: Shivsundar R) > ShareGroupHeartbeat and ShareGroupDescribe API must che

[PR] MINOR: Removing share partition manager flaky annotation [kafka]

2025-02-27 Thread via GitHub
apoorvmittal10 opened a new pull request, #19053: URL: https://github.com/apache/kafka/pull/19053 There isn't any flaky test for SharePartitionManager in last 7 days, removing flaky annotation. https://develocity.apache.org/scans/tests?search.timeZoneId=Europe%2FLondon&tests.containe

[jira] [Assigned] (KAFKA-18883) Move TransactionLog to transaction-coordinator module

2025-02-27 Thread PoAn Yang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18883?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] PoAn Yang reassigned KAFKA-18883: - Assignee: TaiJuWu (was: PoAn Yang) > Move TransactionLog to transaction-coordinator module > -

[jira] [Created] (KAFKA-18898) 4.0 Upgrade docs rendering below other versions

2025-02-27 Thread David Arthur (Jira)
David Arthur created KAFKA-18898: Summary: 4.0 Upgrade docs rendering below other versions Key: KAFKA-18898 URL: https://issues.apache.org/jira/browse/KAFKA-18898 Project: Kafka Issue Type: B

Re: [PR] KAFKA-18734: Implemented share partition metrics (KIP-1103) [kafka]

2025-02-27 Thread via GitHub
apoorvmittal10 commented on code in PR #19045: URL: https://github.com/apache/kafka/pull/19045#discussion_r1974546851 ## core/src/main/java/kafka/server/share/SharePartition.java: ## @@ -1326,6 +1355,42 @@ int leaderEpoch() { return leaderEpoch; } +// Visible

Re: [PR] KAFKA-18734: Implemented share partition metrics (KIP-1103) [kafka]

2025-02-27 Thread via GitHub
apoorvmittal10 commented on code in PR #19045: URL: https://github.com/apache/kafka/pull/19045#discussion_r1974552557 ## core/src/main/java/kafka/server/share/SharePartition.java: ## @@ -1291,13 +1303,30 @@ public boolean maybeAcquireFetchLock() { if (stateNotActive())

[jira] [Assigned] (KAFKA-18897) Add support for SslEngineFactory

2025-02-27 Thread Mingdao Yang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18897?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mingdao Yang reassigned KAFKA-18897: Assignee: Mingdao Yang > Add support for SslEngineFactory > -

[jira] [Commented] (KAFKA-18894) Add support for ConfigProvider

2025-02-27 Thread Jhen-Yung Hsu (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18894?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17931297#comment-17931297 ] Jhen-Yung Hsu commented on KAFKA-18894: --- I'm working on this, thanks :) > Add sup

[jira] [Assigned] (KAFKA-18890) Add support for CreateTopicPolicy and AlterConfigPolicy

2025-02-27 Thread Jhen-Yung Hsu (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18890?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jhen-Yung Hsu reassigned KAFKA-18890: - Assignee: Jhen-Yung Hsu > Add support for CreateTopicPolicy and AlterConfigPolicy > ---

[jira] [Assigned] (KAFKA-18895) Add support for AuthenticateCallbackHandler

2025-02-27 Thread Mingdao Yang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18895?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mingdao Yang reassigned KAFKA-18895: Assignee: Mingdao Yang > Add support for AuthenticateCallbackHandler > --

[jira] [Commented] (KAFKA-18890) Add support for CreateTopicPolicy and AlterConfigPolicy

2025-02-27 Thread Jhen-Yung Hsu (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17931296#comment-17931296 ] Jhen-Yung Hsu commented on KAFKA-18890: --- I'm working on this, thanks :) > Add sup

[jira] [Commented] (KAFKA-18898) 4.0 Upgrade docs rendering below other versions

2025-02-27 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17931317#comment-17931317 ] Chia-Ping Tsai commented on KAFKA-18898: [~davidarthur] Are you testing the 4.0

[jira] [Updated] (KAFKA-18898) 4.0 Upgrade docs rendering below other versions

2025-02-27 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-18898?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] 黃竣陽 updated KAFKA-18898: Attachment: image-2025-02-28-06-28-28-356.png > 4.0 Upgrade docs rendering below other versions >

[jira] [Updated] (KAFKA-18898) 4.0 Upgrade docs rendering below other versions

2025-02-27 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-18898?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] 黃竣陽 updated KAFKA-18898: Attachment: image-2025-02-28-06-29-11-204.png > 4.0 Upgrade docs rendering below other versions >

[jira] [Created] (KAFKA-18890) Add support for CreateTopicPolicy and AlterConfigPolicy

2025-02-27 Thread Mickael Maison (Jira)
Mickael Maison created KAFKA-18890: -- Summary: Add support for CreateTopicPolicy and AlterConfigPolicy Key: KAFKA-18890 URL: https://issues.apache.org/jira/browse/KAFKA-18890 Project: Kafka I

Re: [PR] KAFKA-16580: Enable dynamic quorum reconfiguration for raft simulation tests pt 1 [kafka]

2025-02-27 Thread via GitHub
kevin-wu24 commented on PR #18987: URL: https://github.com/apache/kafka/pull/18987#issuecomment-2688961782 https://github.com/apache/kafka/pull/18987#discussion_r1971722138 contains the most recent observation on what is going on when we're checking the `MajorityReachedHighWatermark` invari

[jira] [Commented] (KAFKA-18891) Add support for RemoteLogMetadataManager and RemoteStorageManager

2025-02-27 Thread TaiJuWu (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17931278#comment-17931278 ] TaiJuWu commented on KAFKA-18891: - Hi[~mimaison] , may I take this over if you are not w

Re: [PR] KAFKA-18864:remove the Evolving tag from stable public interfaces [kafka]

2025-02-27 Thread via GitHub
gongxuanzhang commented on code in PR #19036: URL: https://github.com/apache/kafka/pull/19036#discussion_r1974595611 ## clients/src/main/java/org/apache/kafka/clients/admin/AbortTransactionOptions.java: ## @@ -16,9 +16,7 @@ */ package org.apache.kafka.clients.admin; -import

Re: [PR] MINOR: Extract HeartbeatRequestState from heartbeat request managers [kafka]

2025-02-27 Thread via GitHub
cadonna commented on PR #19043: URL: https://github.com/apache/kafka/pull/19043#issuecomment-2687387498 Call for review: @aliehsaeedii -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

[jira] [Created] (KAFKA-18881) Document the ConsumerRecord as non-thread safe

2025-02-27 Thread Chia-Ping Tsai (Jira)
Chia-Ping Tsai created KAFKA-18881: -- Summary: Document the ConsumerRecord as non-thread safe Key: KAFKA-18881 URL: https://issues.apache.org/jira/browse/KAFKA-18881 Project: Kafka Issue Type

[jira] [Resolved] (KAFKA-18471) Race conditions when accessing RecordHeader data

2025-02-27 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18471?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai resolved KAFKA-18471. Resolution: Duplicate duplicate to KAFKA-18470 > Race conditions when accessing RecordHe

[jira] [Comment Edited] (KAFKA-18871) KRaft migration rollback causes downtime

2025-02-27 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18871?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17931070#comment-17931070 ] Luke Chen edited comment on KAFKA-18871 at 2/27/25 9:34 AM:

Re: [PR] [MINOR] Clean up group-coordinator [kafka]

2025-02-27 Thread via GitHub
sjhajharia commented on PR #19008: URL: https://github.com/apache/kafka/pull/19008#issuecomment-2687360738 hey @chia7712 Can you please take a look at this PR too. TIA -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

[jira] [Assigned] (KAFKA-18880) Remove kafka.cluster.Broker and BrokerEndPointNotAvailableException

2025-02-27 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18880?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai reassigned KAFKA-18880: -- Assignee: xuanzhang gong (was: Lan Ding) > Remove kafka.cluster.Broker and BrokerEnd

[jira] [Commented] (KAFKA-18880) Remove kafka.cluster.Broker and BrokerEndPointNotAvailableException

2025-02-27 Thread xuanzhang gong (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18880?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17931066#comment-17931066 ] xuanzhang gong commented on KAFKA-18880: Hello, I have sent PR to solve this iss

[jira] [Commented] (KAFKA-18880) Remove kafka.cluster.Broker and BrokerEndPointNotAvailableException

2025-02-27 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18880?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17931067#comment-17931067 ] Chia-Ping Tsai commented on KAFKA-18880: [~isding_l] sorry that it seems [~gongx

[jira] [Assigned] (KAFKA-18880) Remove kafka.cluster.Broker and BrokerEndPointNotAvailableException

2025-02-27 Thread Lan Ding (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18880?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lan Ding reassigned KAFKA-18880: Assignee: Lan Ding > Remove kafka.cluster.Broker and BrokerEndPointNotAvailableException > --

[PR] KAFKA-18880:Remove kafka.cluster.Broker and BrokerEndPointNotAvailableException [kafka]

2025-02-27 Thread via GitHub
gongxuanzhang opened a new pull request, #19047: URL: https://github.com/apache/kafka/pull/19047 Remove kafka.cluster.Broker and BrokerEndPointNotAvailableException -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the U

Re: [PR] MINOR: Disallow unused local variables [kafka]

2025-02-27 Thread via GitHub
AndrewJSchofield commented on code in PR #18963: URL: https://github.com/apache/kafka/pull/18963#discussion_r1973200080 ## tools/src/main/java/org/apache/kafka/tools/ShareConsumerPerformance.java: ## @@ -79,7 +79,8 @@ public static void main(String[] args) { sha

[jira] [Assigned] (KAFKA-18881) Document the ConsumerRecord as non-thread safe

2025-02-27 Thread Logan Zhu (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18881?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Logan Zhu reassigned KAFKA-18881: - Assignee: Logan Zhu (was: Chia-Ping Tsai) > Document the ConsumerRecord as non-thread safe > -

[jira] [Commented] (KAFKA-18871) KRaft migration rollback causes downtime

2025-02-27 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18871?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17931070#comment-17931070 ] Luke Chen commented on KAFKA-18871: --- [~durban] , thanks for reporting. Could you share

[jira] [Created] (KAFKA-18882) Move BaseKey, TxnKey, and UnknownKey to transaction-coordinator module

2025-02-27 Thread Chia-Ping Tsai (Jira)
Chia-Ping Tsai created KAFKA-18882: -- Summary: Move BaseKey, TxnKey, and UnknownKey to transaction-coordinator module Key: KAFKA-18882 URL: https://issues.apache.org/jira/browse/KAFKA-18882 Project: K

[jira] [Created] (KAFKA-18884) Move TransactionMetadata to transaction-coordinator module

2025-02-27 Thread PoAn Yang (Jira)
PoAn Yang created KAFKA-18884: - Summary: Move TransactionMetadata to transaction-coordinator module Key: KAFKA-18884 URL: https://issues.apache.org/jira/browse/KAFKA-18884 Project: Kafka Issue Ty

Re: [PR] KAFKA-18854:Move DynamicConfig to server module [kafka]

2025-02-27 Thread via GitHub
chia7712 commented on code in PR #19019: URL: https://github.com/apache/kafka/pull/19019#discussion_r1973272253 ## core/src/main/scala/kafka/server/DynamicBrokerConfig.scala: ## @@ -82,16 +83,6 @@ object DynamicBrokerConfig { private[server] val DynamicSecurityConfigs = SslC

  1   2   >