Re: [PR] KAFKA-10789: Streamlining Tests in ChangeLoggingKeyValueBytesStoreTest [kafka]

2025-02-16 Thread via GitHub
leaf-soba commented on PR #18816: URL: https://github.com/apache/kafka/pull/18816#issuecomment-2661797786 Hi @chia7712, in the CI process, there are three flaky tests that are unrelated to this PR. Could you let me know how to re-run the CI process to get them to pass? -- This is an auto

[jira] [Commented] (KAFKA-18332) Fix KafkaRaftClient complexity

2025-02-16 Thread Ryan Ye (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17927585#comment-17927585 ] Ryan Ye commented on KAFKA-18332: - Hi can I take this issue? > Fix KafkaRaftClient comp

[PR] KAFKA-18332: fix ClassDataAbstractionCoupling problem in KafkaRaftClientTest [kafka]

2025-02-16 Thread via GitHub
leaf-soba opened a new pull request, #18926: URL: https://github.com/apache/kafka/pull/18926 - extract a unit test named `KafkaRaftClientClusterAuthTest` to reduce the number of imported class -- This is an automated message from the Apache Git Service. To respond to the message, plea

Re: [PR] KAFKA-18461: Fix potential NPE in setDelta after map is erased [kafka]

2025-02-16 Thread via GitHub
leaf-soba commented on PR #18684: URL: https://github.com/apache/kafka/pull/18684#issuecomment-2661834192 Hi @ijuma, could you please take a look? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[jira] [Created] (KAFKA-18810) Flaky test: ClientIdQuotaTest.testQuotaOverrideDelete

2025-02-16 Thread Andrew Schofield (Jira)
Andrew Schofield created KAFKA-18810: Summary: Flaky test: ClientIdQuotaTest.testQuotaOverrideDelete Key: KAFKA-18810 URL: https://issues.apache.org/jira/browse/KAFKA-18810 Project: Kafka

[PR] Mark testQuotaOverrideDelete as flaky [kafka]

2025-02-16 Thread via GitHub
AndrewJSchofield opened a new pull request, #18925: URL: https://github.com/apache/kafka/pull/18925 ClientIdQuotaTest.testQuotaOverrideDelete is flaky. Marking this test as flaky. ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [

Re: [PR] KAFKA-18757: Create full-function SimpleAssignor to match KIP-932 description [kafka]

2025-02-16 Thread via GitHub
apoorvmittal10 commented on code in PR #18864: URL: https://github.com/apache/kafka/pull/18864#discussion_r1957418602 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/SimpleAssignor.java: ## @@ -72,36 +77,178 @@ private GroupAssignment assignHomogen

Re: [PR] KAFKA-18757: Create full-function SimpleAssignor to match KIP-932 description [kafka]

2025-02-16 Thread via GitHub
apoorvmittal10 commented on code in PR #18864: URL: https://github.com/apache/kafka/pull/18864#discussion_r1954315981 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/SimpleAssignor.java: ## @@ -111,12 +292,41 @@ private Map> computeTargetPartitions

[jira] [Assigned] (KAFKA-18673) Provide means to gracefully update Producer transational id mapping state in case of lasting inactivity

2025-02-16 Thread Alex Tran (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18673?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alex Tran reassigned KAFKA-18673: - Assignee: Alex Tran > Provide means to gracefully update Producer transational id mapping state

[jira] [Assigned] (KAFKA-7952) Consider to switch to in-memory stores in test whenever possible

2025-02-16 Thread Alex Tran (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-7952?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alex Tran reassigned KAFKA-7952: Assignee: (was: Alex Tran) > Consider to switch to in-memory stores in test whenever possible

Re: [PR] KAFKA-18784: Fix ConsumerWithLegacyMessageFormatIntegrationTest [kafka]

2025-02-16 Thread via GitHub
chia7712 commented on code in PR #18889: URL: https://github.com/apache/kafka/pull/18889#discussion_r1957459755 ## core/src/test/scala/integration/kafka/api/ConsumerWithLegacyMessageFormatIntegrationTest.scala: ## @@ -18,16 +18,43 @@ package kafka.api import kafka.utils.TestI

Re: [PR] Update streams compat table 3.8 [kafka]

2025-02-16 Thread via GitHub
github-actions[bot] commented on PR #17850: URL: https://github.com/apache/kafka/pull/17850#issuecomment-2661892400 This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please leave a comment asking for a review. If the P

Re: [PR] KAFKA-18767: Add client side config check for shareConsumer [kafka]

2025-02-16 Thread via GitHub
TaiJuWu commented on code in PR #18850: URL: https://github.com/apache/kafka/pull/18850#discussion_r1957292877 ## clients/src/main/java/org/apache/kafka/clients/consumer/GroupProtocol.java: ## @@ -23,7 +23,10 @@ public enum GroupProtocol { CLASSIC("CLASSIC"), /** Con

Re: [PR] KAFKA-18767: Add client side config check for shareConsumer [kafka]

2025-02-16 Thread via GitHub
TaiJuWu commented on code in PR #18850: URL: https://github.com/apache/kafka/pull/18850#discussion_r1957292877 ## clients/src/main/java/org/apache/kafka/clients/consumer/GroupProtocol.java: ## @@ -23,7 +23,10 @@ public enum GroupProtocol { CLASSIC("CLASSIC"), /** Con

[jira] [Commented] (KAFKA-15332) Eligible Leader Replicas

2025-02-16 Thread Stanislav Kozlovski (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17927535#comment-17927535 ] Stanislav Kozlovski commented on KAFKA-15332: - [~calvinliu] [~dajac] [~jhoop

[jira] [Commented] (KAFKA-18735) the zk-related path `` is still existent in quota system, such as `ConfigEntity#name` and metrics tags

2025-02-16 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17927504#comment-17927504 ] Chia-Ping Tsai commented on KAFKA-18735: {quote} If there is some API that is se

[jira] [Commented] (KAFKA-18808) add test to ensure the name= is not equal to default quota

2025-02-16 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18808?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17927505#comment-17927505 ] Chia-Ping Tsai commented on KAFKA-18808: {code:java} Map entries = new

[jira] [Updated] (KAFKA-18735) the zk-related path `` is still used by quota callback

2025-02-16 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18735?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai updated KAFKA-18735: --- Summary: the zk-related path `` is still used by quota callback (was: the zk-related path `

Re: [PR] KAFKA-14484: Decouple UnifiedLog and RemoteLogManager [kafka]

2025-02-16 Thread via GitHub
kamalcph commented on code in PR #18460: URL: https://github.com/apache/kafka/pull/18460#discussion_r1957373391 ## storage/src/main/java/org/apache/kafka/storage/internals/log/AsyncOffsetReader.java: ## @@ -0,0 +1,47 @@ +/* + * Licensed to the Apache Software Foundation (ASF) un

Re: [PR] KAFKA-14484: Decouple UnifiedLog and RemoteLogManager [kafka]

2025-02-16 Thread via GitHub
kamalcph commented on code in PR #18460: URL: https://github.com/apache/kafka/pull/18460#discussion_r1957373391 ## storage/src/main/java/org/apache/kafka/storage/internals/log/AsyncOffsetReader.java: ## @@ -0,0 +1,47 @@ +/* + * Licensed to the Apache Software Foundation (ASF) un

Re: [PR] KAFKA-18641: AsyncKafkaConsumer could lose records with auto offset commit [kafka]

2025-02-16 Thread via GitHub
junrao commented on code in PR #18737: URL: https://github.com/apache/kafka/pull/18737#discussion_r1957375625 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/events/ApplicationEventProcessor.java: ## @@ -206,13 +206,25 @@ public void process(ApplicationEvent

Re: [PR] KAFKA-18806: Resource leak in MemoryRecordsBuilder in RecordsUtil [kafka]

2025-02-16 Thread via GitHub
xelathan commented on PR #18919: URL: https://github.com/apache/kafka/pull/18919#issuecomment-2661578406 Build finished with unrelated test failure in `ConsumerCoordinatorTest > testOutdatedCoordinatorAssignment ` Issue is tracked with [KAFKA-15900](https://issues.apache.org/jira/browse/

Re: [PR] KAFKA-18757: Create full-function SimpleAssignor to match KIP-932 description [kafka]

2025-02-16 Thread via GitHub
AndrewJSchofield commented on code in PR #18864: URL: https://github.com/apache/kafka/pull/18864#discussion_r1957425369 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/SimpleAssignor.java: ## @@ -72,36 +77,178 @@ private GroupAssignment assignHomog

Re: [PR] KAFKA-18757: Create full-function SimpleAssignor to match KIP-932 description [kafka]

2025-02-16 Thread via GitHub
apoorvmittal10 commented on code in PR #18864: URL: https://github.com/apache/kafka/pull/18864#discussion_r1957427989 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/SimpleAssignor.java: ## @@ -72,36 +77,178 @@ private GroupAssignment assignHomogen

Re: [PR] KAFKA-18757: Create full-function SimpleAssignor to match KIP-932 description [kafka]

2025-02-16 Thread via GitHub
AndrewJSchofield commented on PR #18864: URL: https://github.com/apache/kafka/pull/18864#issuecomment-2661633762 Marked failed test as flaky in https://github.com/apache/kafka/pull/18925. -- This is an automated message from the Apache Git Service. To respond to the message, please log on

Re: [PR] KAFKA-18804: Remove slf4j warning when using tool script [kafka]

2025-02-16 Thread via GitHub
frankvicky commented on PR #18918: URL: https://github.com/apache/kafka/pull/18918#issuecomment-2661387467 Hi @m1a2st You should see the warning of slf4j, but it is different from this one. ``` > Task :core:genProtocolErrorDocs SLF4J: Failed to load class "org.slf4j.impl.StaticLo

Re: [PR] KAFKA-18767: Add client side config check for shareConsumer [kafka]

2025-02-16 Thread via GitHub
TaiJuWu commented on code in PR #18850: URL: https://github.com/apache/kafka/pull/18850#discussion_r1957292877 ## clients/src/main/java/org/apache/kafka/clients/consumer/GroupProtocol.java: ## @@ -23,7 +23,10 @@ public enum GroupProtocol { CLASSIC("CLASSIC"), /** Con

Re: [PR] KAFKA-18804: Remove slf4j warning when using tool script [kafka]

2025-02-16 Thread via GitHub
m1a2st commented on PR #18918: URL: https://github.com/apache/kafka/pull/18918#issuecomment-2661393738 > The above warning is handled by [KAFKA-18752](https://issues.apache.org/jira/browse/KAFKA-18752) I'm not referring to this warning. I tested the steps below, and no warning messag

Re: [PR] KAFKA-18804: Remove slf4j warning when using tool script [kafka]

2025-02-16 Thread via GitHub
frankvicky commented on PR #18918: URL: https://github.com/apache/kafka/pull/18918#issuecomment-2661398712 At the source code root, you need to complete the `build` or `releaseTarGz` at least first. This will generate a `dependant-libs-2.13.15` directory. Currently, only `core` and `tool

Re: [PR] KAFKA-18767: Add client side config check for shareConsumer [kafka]

2025-02-16 Thread via GitHub
TaiJuWu commented on PR #18850: URL: https://github.com/apache/kafka/pull/18850#issuecomment-2661404879 > Thanks for the PR. Just one overall comment about why `GroupProtocol.SHARE` was defined. The `GROUP_PROTOCOL_CONFIG` is used to choose between which group protocol is used for the regul

Re: [PR] KAFKA-18767: Add client side config check for shareConsumer [kafka]

2025-02-16 Thread via GitHub
TaiJuWu commented on code in PR #18850: URL: https://github.com/apache/kafka/pull/18850#discussion_r1957242661 ## clients/src/main/java/org/apache/kafka/clients/consumer/GroupProtocol.java: ## @@ -23,7 +23,10 @@ public enum GroupProtocol { CLASSIC("CLASSIC"), /** Con

Re: [PR] KAFKA-18767: Add client side config check for shareConsumer [kafka]

2025-02-16 Thread via GitHub
TaiJuWu commented on code in PR #18850: URL: https://github.com/apache/kafka/pull/18850#discussion_r1957292877 ## clients/src/main/java/org/apache/kafka/clients/consumer/GroupProtocol.java: ## @@ -23,7 +23,10 @@ public enum GroupProtocol { CLASSIC("CLASSIC"), /** Con

[jira] [Commented] (KAFKA-18805) Consumer Heartbeat closed change should be locked

2025-02-16 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-18805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17927473#comment-17927473 ] 黃竣陽 commented on KAFKA-18805: - Hello [~showuon], if you won't work on this, may I take this?

[jira] [Commented] (KAFKA-18806) Resource leak in MemoryRecordsBuilder in RecordsUtil

2025-02-16 Thread TengYao Chi (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18806?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17927474#comment-17927474 ] TengYao Chi commented on KAFKA-18806: - Hi [~showuon]  May I take over this one ? >

[jira] [Created] (KAFKA-18806) Resource leak in MemoryRecordsBuilder in RecordsUtil

2025-02-16 Thread Luke Chen (Jira)
Luke Chen created KAFKA-18806: - Summary: Resource leak in MemoryRecordsBuilder in RecordsUtil Key: KAFKA-18806 URL: https://issues.apache.org/jira/browse/KAFKA-18806 Project: Kafka Issue Type: Bu

[jira] [Assigned] (KAFKA-18806) Resource leak in MemoryRecordsBuilder in RecordsUtil

2025-02-16 Thread Alex Tran (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18806?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alex Tran reassigned KAFKA-18806: - Assignee: Alex Tran > Resource leak in MemoryRecordsBuilder in RecordsUtil > --

Re: [PR] KAFKA-18804: Remove slf4j warning when using tool script [kafka]

2025-02-16 Thread via GitHub
Yunyung commented on PR #18918: URL: https://github.com/apache/kafka/pull/18918#issuecomment-2661333030 This should be backported to 4.0, as the same issue happens in 4.0. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

[jira] [Commented] (KAFKA-18805) Consumer Heartbeat closed change should be locked

2025-02-16 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17927477#comment-17927477 ] Luke Chen commented on KAFKA-18805: --- [~m1a2st] , assigned to you. Thanks. > Consumer

[jira] [Commented] (KAFKA-18806) Resource leak in MemoryRecordsBuilder in RecordsUtil

2025-02-16 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18806?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17927478#comment-17927478 ] Luke Chen commented on KAFKA-18806: --- [~frankvicky] , it looks like [~alectric] is pick

[jira] [Assigned] (KAFKA-18805) Consumer Heartbeat closed change should be locked

2025-02-16 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18805?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Luke Chen reassigned KAFKA-18805: - Assignee: 黃竣陽 > Consumer Heartbeat closed change should be locked > ---

[jira] [Created] (KAFKA-18807) Group coordinator under-reports thread idle time

2025-02-16 Thread Sean Quah (Jira)
Sean Quah created KAFKA-18807: - Summary: Group coordinator under-reports thread idle time Key: KAFKA-18807 URL: https://issues.apache.org/jira/browse/KAFKA-18807 Project: Kafka Issue Type: Bug

[PR] KAFKA-18806: Resource leak in MemoryRecordsBuilder in RecordsUtil [kafka]

2025-02-16 Thread via GitHub
xelathan opened a new pull request, #18919: URL: https://github.com/apache/kafka/pull/18919 MemoryRecordsBuilder not closed in RecordsUtil. Closed implicitly with `try` https://issues.apache.org/jira/browse/KAFKA-18806 ### Committer Checklist (excluded from commit message)

[jira] [Commented] (KAFKA-18806) Resource leak in MemoryRecordsBuilder in RecordsUtil

2025-02-16 Thread Alex Tran (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18806?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17927481#comment-17927481 ] Alex Tran commented on KAFKA-18806: --- [~showuon] , yes I am working on it. > Resource

[jira] [Commented] (KAFKA-18806) Resource leak in MemoryRecordsBuilder in RecordsUtil

2025-02-16 Thread TengYao Chi (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18806?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17927484#comment-17927484 ] TengYao Chi commented on KAFKA-18806: - No worried I will help review this one > Re

[PR] KAFKA-18805: Consumer Heartbeat closed change should be locked [kafka]

2025-02-16 Thread via GitHub
m1a2st opened a new pull request, #18920: URL: https://github.com/apache/kafka/pull/18920 Jira: https://issues.apache.org/jira/browse/KAFKA-18805 Using synchronized block to avoid the locked ### Committer Checklist (excluded from commit message) - [ ] Verify design and implem

[jira] [Resolved] (KAFKA-18805) Consumer Heartbeat closed change should be locked

2025-02-16 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18805?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Luke Chen resolved KAFKA-18805. --- Fix Version/s: 4.1.0 Resolution: Fixed > Consumer Heartbeat closed change should be locked >

Re: [PR] KAFKA-16918: TestUtils#assertFutureThrows should use future.get with timeout [kafka]

2025-02-16 Thread via GitHub
chia7712 commented on code in PR #18891: URL: https://github.com/apache/kafka/pull/18891#discussion_r1957734129 ## clients/src/test/java/org/apache/kafka/test/TestUtils.java: ## @@ -580,21 +583,28 @@ public static Set generateRandomTopicPartitions(int numTopic, in }

[jira] [Assigned] (KAFKA-18810) Flaky test: ClientIdQuotaTest.testQuotaOverrideDelete

2025-02-16 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18810?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai reassigned KAFKA-18810: -- Assignee: Chia-Ping Tsai > Flaky test: ClientIdQuotaTest.testQuotaOverrideDelete > --

Re: [PR] Mark testQuotaOverrideDelete as flaky [kafka]

2025-02-16 Thread via GitHub
chia7712 merged PR #18925: URL: https://github.com/apache/kafka/pull/18925 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

Re: [PR] KAFKA-18784: Fix ConsumerWithLegacyMessageFormatIntegrationTest [kafka]

2025-02-16 Thread via GitHub
chia7712 commented on code in PR #18889: URL: https://github.com/apache/kafka/pull/18889#discussion_r1957730744 ## core/src/test/scala/integration/kafka/api/ConsumerWithLegacyMessageFormatIntegrationTest.scala: ## @@ -18,16 +18,43 @@ package kafka.api import kafka.utils.TestI

Re: [PR] KAFKA-18712: Move Endpoint to server module [kafka]

2025-02-16 Thread via GitHub
chia7712 commented on PR #18803: URL: https://github.com/apache/kafka/pull/18803#issuecomment-2662303442 @TaiJuWu could you please rebase code? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] KAFKA-18805: Consumer Heartbeat closed change should be locked [kafka]

2025-02-16 Thread via GitHub
showuon merged PR #18920: URL: https://github.com/apache/kafka/pull/18920 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.

Re: [PR] KAFKA-18213: Convert CustomQuotaCallbackTest to KRaft [kafka]

2025-02-16 Thread via GitHub
chia7712 closed pull request #18126: KAFKA-18213: Convert CustomQuotaCallbackTest to KRaft URL: https://github.com/apache/kafka/pull/18126 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

Re: [PR] KAFKA-18213: Convert CustomQuotaCallbackTest to KRaft [kafka]

2025-02-16 Thread via GitHub
chia7712 commented on PR #18126: URL: https://github.com/apache/kafka/pull/18126#issuecomment-2662245203 close as duplicate to #18196 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[jira] [Created] (KAFKA-18808) add test to ensure the name= is not equal to default quota

2025-02-16 Thread Chia-Ping Tsai (Jira)
Chia-Ping Tsai created KAFKA-18808: -- Summary: add test to ensure the name= is not equal to default quota Key: KAFKA-18808 URL: https://issues.apache.org/jira/browse/KAFKA-18808 Project: Kafka

Re: [PR] KAFKA-18803: The acls would appear at the wrong level of the metadata shell "tree" [kafka]

2025-02-16 Thread via GitHub
Yunyung commented on PR #18916: URL: https://github.com/apache/kafka/pull/18916#issuecomment-2661447763 > 1. Manually test this patch by creating some ACLs and showing the output from metadata shell Before: ``` $ ./bin/kafka-metadata-shell.sh --snapshot /tmp/kraft-combined-logs

[jira] [Commented] (KAFKA-18808) add test to ensure the name= is not equal to default quota

2025-02-16 Thread Nick Guo (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18808?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17927508#comment-17927508 ] Nick Guo commented on KAFKA-18808: -- Hi [~chia7712] ,may I take this issue? Thanks! :)

[PR] KAFKA-18809: Set min in sync replicas for __share_group_state. [kafka]

2025-02-16 Thread via GitHub
smjn opened a new pull request, #18922: URL: https://github.com/apache/kafka/pull/18922 * The `share.coordinator.state.topic.min.isr` config defined in `ShareCoordinatorConfig` was not being used in the `AutoTopicCreationManager`. * The `AutoTopicCreationManager` calls the `ShareCoordin

[jira] [Commented] (KAFKA-18809) share.coordinator.state.topic.min.isr is not applied

2025-02-16 Thread Sushant Mahajan (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18809?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17927537#comment-17927537 ] Sushant Mahajan commented on KAFKA-18809: - [~chia7712]  Raised a fix https://gi

[PR] MINOR: deflake EligibleLeaderReplicasIntegrationTest [kafka]

2025-02-16 Thread via GitHub
CalvinConfluent opened a new pull request, #18923: URL: https://github.com/apache/kafka/pull/18923 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscri

Re: [PR] KAFKA-18801 Remove ClusterGenerator and revise docs of ClusterTemplate [kafka]

2025-02-16 Thread via GitHub
JimmyWang6 commented on code in PR #18907: URL: https://github.com/apache/kafka/pull/18907#discussion_r1957392043 ## test-common/test-common-internal-api/src/main/java/org/apache/kafka/common/test/api/ClusterTemplate.java: ## @@ -30,9 +30,9 @@ /** * Used to indicate that a

[jira] [Commented] (KAFKA-15900) Flaky test: testOutdatedCoordinatorAssignment() – org.apache.kafka.clients.consumer.internals.EagerConsumerCoordinatorTest

2025-02-16 Thread Alex Tran (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15900?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17927555#comment-17927555 ] Alex Tran commented on KAFKA-15900: --- I am also seeing it fail in unrelated [PR|https:

[jira] [Created] (KAFKA-18809) share.coordinator.state.topic.min.isr is not applied

2025-02-16 Thread Chia-Ping Tsai (Jira)
Chia-Ping Tsai created KAFKA-18809: -- Summary: share.coordinator.state.topic.min.isr is not applied Key: KAFKA-18809 URL: https://issues.apache.org/jira/browse/KAFKA-18809 Project: Kafka Iss

[jira] [Commented] (KAFKA-18809) share.coordinator.state.topic.min.isr is not applied

2025-02-16 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18809?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17927518#comment-17927518 ] Chia-Ping Tsai commented on KAFKA-18809: [~apoorvmittal10] [~schofielaj] [~sushm

[jira] [Assigned] (KAFKA-18808) add test to ensure the name= is not equal to default quota

2025-02-16 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18808?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai reassigned KAFKA-18808: -- Assignee: Nick Guo (was: Chia-Ping Tsai) > add test to ensure the name= is not equal

Re: [PR] KAFKA-18801 Remove ClusterGenerator and revise docs of ClusterTemplate [kafka]

2025-02-16 Thread via GitHub
JimmyWang6 commented on code in PR #18907: URL: https://github.com/apache/kafka/pull/18907#discussion_r1957377060 ## test-common/test-common-internal-api/src/main/java/org/apache/kafka/common/test/api/ClusterTemplate.java: ## @@ -30,9 +30,9 @@ /** * Used to indicate that a

[jira] [Commented] (KAFKA-15332) Eligible Leader Replicas

2025-02-16 Thread Calvin Liu (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17927543#comment-17927543 ] Calvin Liu commented on KAFKA-15332: [~stanislavkozlovski] 4.0 only carries part 1 w

[PR] [WIP] KAFKA-18562: standardize election/fetch timeout between Unattached and Followers [kafka]

2025-02-16 Thread via GitHub
frankvicky opened a new pull request, #18921: URL: https://github.com/apache/kafka/pull/18921 JIRA: KAFKA-18562 ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status - [ ] Verify documentat

[jira] [Updated] (KAFKA-18803) The acls would appear at the wrong level of the metadata shell "tree"

2025-02-16 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18803?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai updated KAFKA-18803: --- Fix Version/s: 3.9.1 3.8.2 > The acls would appear at the wrong level of

Re: [PR] KAFKA-18803: The acls would appear at the wrong level of the metadata shell "tree" [kafka]

2025-02-16 Thread via GitHub
chia7712 merged PR #18916: URL: https://github.com/apache/kafka/pull/18916 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

[jira] [Resolved] (KAFKA-18803) The acls would appear at the wrong level of the metadata shell "tree"

2025-02-16 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18803?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai resolved KAFKA-18803. Resolution: Fixed trunk: https://github.com/apache/kafka/commit/d0e516a87207b04f6266c5971

[jira] [Resolved] (KAFKA-18809) share.coordinator.state.topic.min.isr is not applied

2025-02-16 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18809?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai resolved KAFKA-18809. Resolution: Fixed I keep this fix in 4.1, as shared consumer is not in production to 4.0

[jira] [Updated] (KAFKA-18809) share.coordinator.state.topic.min.isr is not applied

2025-02-16 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18809?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai updated KAFKA-18809: --- Fix Version/s: 4.1.0 (was: 4.0.0) > share.coordinator.state.topic.min

[jira] [Resolved] (KAFKA-17682) Refactor RaftClusterInvocationContext to eliminate test-common-api dependencies

2025-02-16 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17682?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai resolved KAFKA-17682. Resolution: Duplicate resolved by https://github.com/apache/kafka/commit/8c0a0e07ced06241

Re: [PR] KAFKA-18809: Set min in sync replicas for __share_group_state. [kafka]

2025-02-16 Thread via GitHub
chia7712 merged PR #18922: URL: https://github.com/apache/kafka/pull/18922 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

[jira] [Updated] (KAFKA-18809) share.coordinator.state.topic.min.isr is not applied

2025-02-16 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18809?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai updated KAFKA-18809: --- Fix Version/s: 4.0.0 (was: 4.1.0) > share.coordinator.state.topic.min

Re: [PR] KAFKA-18803: The acls would appear at the wrong level of the metadata shell "tree" [kafka]

2025-02-16 Thread via GitHub
chia7712 commented on PR #18916: URL: https://github.com/apache/kafka/pull/18916#issuecomment-2661601777 cherry-pick to 4.0, 3.9 and 3.8 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

[jira] [Assigned] (KAFKA-18809) share.coordinator.state.topic.min.isr is not applied

2025-02-16 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18809?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai reassigned KAFKA-18809: -- Assignee: Sushant Mahajan (was: Chia-Ping Tsai) > share.coordinator.state.topic.min.

[PR] KAFKA-18733: Updating share group record acks metric (2/N) [kafka]

2025-02-16 Thread via GitHub
apoorvmittal10 opened a new pull request, #18924: URL: https://github.com/apache/kafka/pull/18924 The PR corrects the record acks rate for number of records acknowledged. Also corrects the behaviour when multiple acks type exists in a single acknowledgement batch. -- This is an automated

Re: [PR] KAFKA-18806: Resource leak in MemoryRecordsBuilder in RecordsUtil [kafka]

2025-02-16 Thread via GitHub
chia7712 commented on code in PR #18919: URL: https://github.com/apache/kafka/pull/18919#discussion_r1957408912 ## clients/src/main/java/org/apache/kafka/common/record/RecordsUtil.java: ## @@ -89,10 +89,11 @@ protected static ConvertedRecords downConvert(Iterablehttps://github.

Re: [PR] MINOR: Remove unused member in DynamicBrokerConfig [kafka]

2025-02-16 Thread via GitHub
chia7712 commented on PR #18915: URL: https://github.com/apache/kafka/pull/18915#issuecomment-2661609606 the failed test is traced by https://issues.apache.org/jira/browse/KAFKA-15474 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] KAFKA-18806: Resource leak in MemoryRecordsBuilder in RecordsUtil [kafka]

2025-02-16 Thread via GitHub
xelathan commented on code in PR #18919: URL: https://github.com/apache/kafka/pull/18919#discussion_r1957411153 ## clients/src/main/java/org/apache/kafka/common/record/RecordsUtil.java: ## @@ -89,10 +89,11 @@ protected static ConvertedRecords downConvert(Iterablehttps://github.

Re: [PR] KAFKA-18806: Resource leak in MemoryRecordsBuilder in RecordsUtil [kafka]

2025-02-16 Thread via GitHub
xelathan closed pull request #18919: KAFKA-18806: Resource leak in MemoryRecordsBuilder in RecordsUtil URL: https://github.com/apache/kafka/pull/18919 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] MINOR: Remove unused member in DynamicBrokerConfig [kafka]

2025-02-16 Thread via GitHub
chia7712 merged PR #18915: URL: https://github.com/apache/kafka/pull/18915 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

[jira] [Resolved] (KAFKA-18755) Align timeout in kafka-share-groups.sh with other group-related tools

2025-02-16 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18755?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai resolved KAFKA-18755. Resolution: Fixed > Align timeout in kafka-share-groups.sh with other group-related tools

Re: [PR] KAFKA-18806: Resource leak in MemoryRecordsBuilder in RecordsUtil [kafka]

2025-02-16 Thread via GitHub
chia7712 commented on code in PR #18919: URL: https://github.com/apache/kafka/pull/18919#discussion_r1957411650 ## clients/src/main/java/org/apache/kafka/common/record/RecordsUtil.java: ## @@ -89,10 +89,11 @@ protected static ConvertedRecords downConvert(Iterable I'll go ahead

[jira] [Resolved] (KAFKA-18806) Resource leak in MemoryRecordsBuilder in RecordsUtil

2025-02-16 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18806?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai resolved KAFKA-18806. Resolution: Won't Fix see https://github.com/apache/kafka/pull/18919#discussion_r195740891

Re: [PR] KAFKA-18755 Align timeout in kafka-share-groups.sh [kafka]

2025-02-16 Thread via GitHub
chia7712 merged PR #18908: URL: https://github.com/apache/kafka/pull/18908 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache