[jira] [Commented] (KAFKA-18762) 'Acks=all' not working correctly in Kafka Kraft mode.

2025-02-10 Thread PoAn Yang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17925507#comment-17925507 ] PoAn Yang commented on KAFKA-18762: --- Hi [~shubhamraj], if you're not working on this,

[jira] [Commented] (KAFKA-18762) 'Acks=all' not working correctly in Kafka Kraft mode.

2025-02-10 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17925508#comment-17925508 ] Luke Chen commented on KAFKA-18762: --- [~dajac] , I think this should be the block for v

[jira] [Comment Edited] (KAFKA-18762) 'Acks=all' not working correctly in Kafka Kraft mode.

2025-02-10 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17925508#comment-17925508 ] Luke Chen edited comment on KAFKA-18762 at 2/10/25 8:27 AM:

[jira] [Assigned] (KAFKA-18534) docker build fail because log4j

2025-02-10 Thread TaiJuWu (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18534?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] TaiJuWu reassigned KAFKA-18534: --- Assignee: (was: TaiJuWu) > docker build fail because log4j > --- >

[jira] [Commented] (KAFKA-18762) 'Acks=all' not working correctly in Kafka Kraft mode.

2025-02-10 Thread David Jacot (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17925518#comment-17925518 ] David Jacot commented on KAFKA-18762: - [~shubhamraj] Thanks for the bug report. I th

Re: [PR] KAFKA-18225: ClientQuotaCallback#updateClusterMetadata is unsupported by kraft [kafka]

2025-02-10 Thread via GitHub
dajac commented on PR #18196: URL: https://github.com/apache/kafka/pull/18196#issuecomment-2647409588 @chia7712 Thanks for the review. Can we merge it? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[jira] [Created] (KAFKA-18762) 'Acks=all' not working correctly in Kafka Kraft mode.

2025-02-10 Thread Shubham Raj (Jira)
Shubham Raj created KAFKA-18762: --- Summary: 'Acks=all' not working correctly in Kafka Kraft mode. Key: KAFKA-18762 URL: https://issues.apache.org/jira/browse/KAFKA-18762 Project: Kafka Issue Typ

[jira] [Created] (KAFKA-18765) Custom StreamsPartitioner for auto-repartitioning

2025-02-10 Thread Nicholas Telford (Jira)
Nicholas Telford created KAFKA-18765: Summary: Custom StreamsPartitioner for auto-repartitioning Key: KAFKA-18765 URL: https://issues.apache.org/jira/browse/KAFKA-18765 Project: Kafka Iss

[jira] [Commented] (KAFKA-18765) Custom StreamsPartitioner for auto-repartitioning

2025-02-10 Thread Nicholas Telford (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18765?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17925539#comment-17925539 ] Nicholas Telford commented on KAFKA-18765: -- A simple solution might be to add a

[jira] [Comment Edited] (KAFKA-18765) Custom StreamsPartitioner for auto-repartitioning

2025-02-10 Thread Nicholas Telford (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18765?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17925539#comment-17925539 ] Nicholas Telford edited comment on KAFKA-18765 at 2/10/25 10:50 AM: --

Re: [PR] KAFKA-18023: Enforcing Explicit Naming for Kafka Streams Internal Topics [kafka]

2025-02-10 Thread via GitHub
sebastienviale commented on code in PR #18233: URL: https://github.com/apache/kafka/pull/18233#discussion_r1948836873 ## streams/src/test/java/org/apache/kafka/streams/StreamsBuilderTest.java: ## @@ -2354,6 +2363,418 @@ public void shouldNowAllowStreamAndTableFromSameTopic() {

Re: [PR] KAFKA-18023: Enforcing Explicit Naming for Kafka Streams Internal Topics [kafka]

2025-02-10 Thread via GitHub
sebastienviale commented on code in PR #18233: URL: https://github.com/apache/kafka/pull/18233#discussion_r1948837239 ## streams/src/test/java/org/apache/kafka/streams/StreamsBuilderTest.java: ## @@ -2354,6 +2363,418 @@ public void shouldNowAllowStreamAndTableFromSameTopic() {

Re: [PR] MINOR: Accept specifying consumer group assignors by their short names [kafka]

2025-02-10 Thread via GitHub
dajac merged PR #18832: URL: https://github.com/apache/kafka/pull/18832 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or

[jira] [Created] (KAFKA-18764) Cluster-authorized share-state RPCs should throttle when not authorized

2025-02-10 Thread Andrew Schofield (Jira)
Andrew Schofield created KAFKA-18764: Summary: Cluster-authorized share-state RPCs should throttle when not authorized Key: KAFKA-18764 URL: https://issues.apache.org/jira/browse/KAFKA-18764 Proje

[jira] [Created] (KAFKA-18763) Resolve the flakiness in test_share_single_topic_partition system test

2025-02-10 Thread Chirag Wadhwa (Jira)
Chirag Wadhwa created KAFKA-18763: - Summary: Resolve the flakiness in test_share_single_topic_partition system test Key: KAFKA-18763 URL: https://issues.apache.org/jira/browse/KAFKA-18763 Project: Kaf

[PR] KAFKA-18763: Resolved the flakiness in test_share_single_topic_partition system test [kafka]

2025-02-10 Thread via GitHub
chirag-wadhwa5 opened a new pull request, #18846: URL: https://github.com/apache/kafka/pull/18846 This PR resolves the flakiness in the system test test_share_single_topic_partition. The assertion statement for records acknowledged checked for the equality of acked records and produced reco

Re: [PR] KAFKA-18396: Migrate log4j1 configuration to log4j2 in KafkaDockerWrapper [kafka]

2025-02-10 Thread via GitHub
frankvicky commented on code in PR #18394: URL: https://github.com/apache/kafka/pull/18394#discussion_r1948749017 ## core/src/main/java/kafka/docker/Log4jConfiguration.java: ## @@ -0,0 +1,221 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contr

Re: [PR] KAFKA-18396: Migrate log4j1 configuration to log4j2 in KafkaDockerWrapper [kafka]

2025-02-10 Thread via GitHub
frankvicky commented on PR #18394: URL: https://github.com/apache/kafka/pull/18394#issuecomment-2647646366 Hi @omkreddy, Thanks for your help. I noticed you've made some changes based on my previous version. In the earlier versions, we serialized several properties that we didn't

[PR] KAFKA-18441: Remove flaky tag on KafkaAdminClientTest#testAdminClientApisAuthenticationFailure [kafka]

2025-02-10 Thread via GitHub
FrankYang0529 opened a new pull request, #18847: URL: https://github.com/apache/kafka/pull/18847 The PR https://github.com/apache/kafka/pull/18735 was merged on Jan 30. After that, we don't see any flaky for ten days. I think we can remove `@Flaky` for `KafkaAdminClientTest#testAdminClientA

Re: [PR] MINOR: Accept specifying consumer group assignors by their short names [kafka]

2025-02-10 Thread via GitHub
dajac commented on PR #18832: URL: https://github.com/apache/kafka/pull/18832#issuecomment-2647642422 Merged to trunk and 4.0. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

[jira] [Commented] (KAFKA-18762) 'Acks=all' not working correctly in Kafka Kraft mode.

2025-02-10 Thread Shubham Raj (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17925544#comment-17925544 ] Shubham Raj commented on KAFKA-18762: - But in my opinion, we should also consider th

Re: [PR] KAFKA-18396: Migrate log4j1 configuration to log4j2 in KafkaDockerWrapper [kafka]

2025-02-10 Thread via GitHub
omkreddy commented on PR #18394: URL: https://github.com/apache/kafka/pull/18394#issuecomment-2647695006 @frankvicky Sorry, my bad. I might have overwritten your changes. Yes, the changes look good to me. Please reapply these changes to this patch. -- This is an automated message from the

[jira] [Commented] (KAFKA-18735) the zk-related path `` is still existent in quota system, such as `ConfigEntity#name` and metrics tags

2025-02-10 Thread David Jacot (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17925575#comment-17925575 ] David Jacot commented on KAFKA-18735: - Do we have an ETA for this issue? > the zk-r

Re: [PR] KAFKA-18756: Enabled share group configs for queues related system tests [kafka]

2025-02-10 Thread via GitHub
AndrewJSchofield commented on code in PR #18829: URL: https://github.com/apache/kafka/pull/18829#discussion_r1949060513 ## tests/kafkatest/services/kafka/kafka.py: ## @@ -292,10 +292,18 @@ def __init__(self, context, num_nodes, zk, security_protocol=SecurityConfig.PLAI

[jira] [Commented] (KAFKA-18762) 'Acks=all' not working correctly in Kafka Kraft mode.

2025-02-10 Thread Ismael Juma (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17925592#comment-17925592 ] Ismael Juma commented on KAFKA-18762: - We should not allow min insync replicas to be

[jira] [Commented] (KAFKA-18477) remove usage of OffsetForLeaderEpochRequest in AbstractFetcherThread

2025-02-10 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-18477?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17925595#comment-17925595 ] 黃竣陽 commented on KAFKA-18477: - {quote}leader.isTruncationOnFetchSupported is always true in

[jira] [Updated] (KAFKA-18766) Docs: Make usage of allow.everyone.if.no.acl.found config clearer

2025-02-10 Thread Divij Vaidya (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18766?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Divij Vaidya updated KAFKA-18766: - Description: h2. *Motivation* In the documentation today, we have the following sentence: {quot

[jira] [Updated] (KAFKA-18766) Docs: Make usage of allow.everyone.if.no.acl.found config clearer

2025-02-10 Thread Divij Vaidya (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18766?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Divij Vaidya updated KAFKA-18766: - Description: h2. *Motivation* In the documentation today, we have the following sentence: {quot

[jira] [Updated] (KAFKA-18766) Docs: Make usage of allow.everyone.if.no.acl.found config clearer

2025-02-10 Thread Divij Vaidya (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18766?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Divij Vaidya updated KAFKA-18766: - Description: h2. *Motivation* In the documentation today, we have the following sentence: {quot

Re: [PR] KAFKA-15995: Adding KIP-877 support to Connect [kafka]

2025-02-10 Thread via GitHub
mimaison commented on PR #17804: URL: https://github.com/apache/kafka/pull/17804#issuecomment-2648434157 This is now ready to review. The CI failures seem unrelated, I reran it and got a different set of failing tests. -- This is an automated message from the Apache Git Service. To re

[jira] [Commented] (KAFKA-18766) Docs: Make usage of allow.everyone.if.no.acl.found config clearer

2025-02-10 Thread Mingdao Yang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17925613#comment-17925613 ] Mingdao Yang commented on KAFKA-18766: -- Hi [~divijvaidya] I'd be interested in work

[jira] [Created] (KAFKA-18766) Docs: Make usage of allow.everyone.if.no.acl.found config clearer

2025-02-10 Thread Divij Vaidya (Jira)
Divij Vaidya created KAFKA-18766: Summary: Docs: Make usage of allow.everyone.if.no.acl.found config clearer Key: KAFKA-18766 URL: https://issues.apache.org/jira/browse/KAFKA-18766 Project: Kafka

[jira] [Updated] (KAFKA-18766) Docs: Make usage of allow.everyone.if.no.acl.found config clearer

2025-02-10 Thread Divij Vaidya (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18766?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Divij Vaidya updated KAFKA-18766: - Description: h2. *Motivation* In the documentation today, we have the following sentence: {quot

[jira] [Updated] (KAFKA-17942) Fix testAcknowledgementCommitCallbackInvalidRecordStateException

2025-02-10 Thread Jimmy Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17942?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jimmy Wang updated KAFKA-17942: --- Attachment: image-2025-02-10-19-58-17-946.png > Fix testAcknowledgementCommitCallbackInvalidRecordSt

[PR] KAFKA-18629: Delete share group state RPC group coordinator impl. [3/N] [kafka]

2025-02-10 Thread via GitHub
smjn opened a new pull request, #18848: URL: https://github.com/apache/kafka/pull/18848 * In this PR, we have added GC side impl to call the delete state share coord RPC using the persister. -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [PR] KAFKA-16717 [1/2]: Add AdminClient.alterShareGroupOffsets [kafka]

2025-02-10 Thread via GitHub
apoorvmittal10 commented on code in PR #18819: URL: https://github.com/apache/kafka/pull/18819#discussion_r1949027495 ## docs/security.html: ## @@ -2271,6 +2271,12 @@ http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, so

Re: [PR] MINOR: cleanup KStream JavaDocs (7/N) - repartition/to/toTable [kafka]

2025-02-10 Thread via GitHub
chia7712 commented on PR #18760: URL: https://github.com/apache/kafka/pull/18760#issuecomment-2648206457 This PR is great and has given me an idea for improving our CI process. This PR introduce a java doc error, and hence QA does not run `streams:test`. ``` 2025-02-05T05:09:25.4

[jira] [Commented] (KAFKA-18766) Docs: Make usage of allow.everyone.if.no.acl.found config clearer

2025-02-10 Thread Divij Vaidya (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17925614#comment-17925614 ] Divij Vaidya commented on KAFKA-18766: -- [~mingdaoy] of course. In general, you don'

[jira] [Assigned] (KAFKA-18766) Docs: Make usage of allow.everyone.if.no.acl.found config clearer

2025-02-10 Thread Divij Vaidya (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18766?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Divij Vaidya reassigned KAFKA-18766: Assignee: Mingdao Yang > Docs: Make usage of allow.everyone.if.no.acl.found config cleare

Re: [PR] KAFKA-18758: NullPointerException in shutdown following InvalidConfigurationException [kafka]

2025-02-10 Thread via GitHub
edoardocomar commented on PR #18833: URL: https://github.com/apache/kafka/pull/18833#issuecomment-2648500129 thank you @gaurav-narula - I am retrying the failed flaky tests -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

[jira] [Commented] (KAFKA-15529) Flaky test ReassignReplicaShrinkTest.executeTieredStorageTest

2025-02-10 Thread R Dheeraj (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15529?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17925638#comment-17925638 ] R Dheeraj commented on KAFKA-15529: --- [~divijvaidya] Hi, I'm new to Kafka. I would like

Re: [PR] KAFKA-18225: ClientQuotaCallback#updateClusterMetadata is unsupported by kraft [kafka]

2025-02-10 Thread via GitHub
chia7712 merged PR #18196: URL: https://github.com/apache/kafka/pull/18196 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

Re: [PR] KAFKA-18366 Remove KafkaConfig.interBrokerProtocolVersion [kafka]

2025-02-10 Thread via GitHub
ijuma commented on code in PR #18820: URL: https://github.com/apache/kafka/pull/18820#discussion_r1949458417 ## core/src/test/scala/unit/kafka/server/ReplicaFetcherThreadTest.scala: ## @@ -90,7 +90,7 @@ class ReplicaFetcherThreadTest { val logContext = new LogContext(s"[Rep

Re: [PR] KAFKA-18758: NullPointerException in shutdown following InvalidConfigurationException [kafka]

2025-02-10 Thread via GitHub
edoardocomar commented on PR #18833: URL: https://github.com/apache/kafka/pull/18833#issuecomment-2648554344 ``` ./gradlew client:test --tests AbstractCoordinatorTest ./gradlew core:test --tests ReplicationQuotasTest ./gradlew core:test --tests RequestQuotaTest ``` all pass f

[jira] [Assigned] (KAFKA-18764) Cluster-authorized share-state RPCs should throttle when not authorized

2025-02-10 Thread Sushant Mahajan (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18764?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sushant Mahajan reassigned KAFKA-18764: --- Assignee: Sushant Mahajan (was: Sushant Mahajan) > Cluster-authorized share-state

Re: [PR] KAFKA-18601: Assume a baseline of 3.3 for server protocol versions [kafka]

2025-02-10 Thread via GitHub
ijuma commented on code in PR #18845: URL: https://github.com/apache/kafka/pull/18845#discussion_r1949489365 ## tools/src/test/java/org/apache/kafka/tools/reassign/ReassignPartitionsCommandTest.java: ## @@ -128,18 +126,6 @@ public void testReassignment() throws Exception {

[jira] [Commented] (KAFKA-18767) Add client side config check

2025-02-10 Thread Lianet Magrans (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17925641#comment-17925641 ] Lianet Magrans commented on KAFKA-18767: I think you have a good point! I was ju

Re: [PR] KAFKA-18601: Assume a baseline of 3.3 for server protocol versions [kafka]

2025-02-10 Thread via GitHub
ijuma commented on code in PR #18845: URL: https://github.com/apache/kafka/pull/18845#discussion_r1949581070 ## core/src/main/scala/kafka/cluster/Partition.scala: ## @@ -1813,7 +1813,7 @@ class Partition(val topicPartition: TopicPartition, private def submitAlterPartition(pro

Re: [PR] KAFKA-18758: NullPointerException in shutdown following InvalidConfigurationException [kafka]

2025-02-10 Thread via GitHub
apoorvmittal10 commented on code in PR #18833: URL: https://github.com/apache/kafka/pull/18833#discussion_r1949584155 ## core/src/main/scala/kafka/server/BrokerServer.scala: ## @@ -803,7 +807,7 @@ class BrokerServer( if (clientToControllerChannelManager != null)

Re: [PR] KAFKA-18601: Assume a baseline of 3.3 for server protocol versions [kafka]

2025-02-10 Thread via GitHub
ijuma commented on code in PR #18845: URL: https://github.com/apache/kafka/pull/18845#discussion_r1949583609 ## core/src/main/scala/kafka/cluster/Partition.scala: ## @@ -1813,7 +1813,7 @@ class Partition(val topicPartition: TopicPartition, private def submitAlterPartition(pro

Re: [PR] KAFKA-18758: NullPointerException in shutdown following InvalidConfigurationException [kafka]

2025-02-10 Thread via GitHub
edoardocomar commented on PR #18833: URL: https://github.com/apache/kafka/pull/18833#issuecomment-2648750784 ``` ./gradlew core:test --tests DynamicBrokerReconfigurationTest ./gradlew storage:test --tests DeleteSegmentsByRetentionTimeTest ``` also pass for me locally with java 23

Re: [PR] KAFKA-18758: NullPointerException in shutdown following InvalidConfigurationException [kafka]

2025-02-10 Thread via GitHub
apoorvmittal10 commented on code in PR #18833: URL: https://github.com/apache/kafka/pull/18833#discussion_r1949587802 ## core/src/main/scala/kafka/server/BrokerServer.scala: ## @@ -803,7 +807,7 @@ class BrokerServer( if (clientToControllerChannelManager != null)

Re: [PR] KAFKA-18758: NullPointerException in shutdown following InvalidConfigurationException [kafka]

2025-02-10 Thread via GitHub
apoorvmittal10 commented on code in PR #18833: URL: https://github.com/apache/kafka/pull/18833#discussion_r1949587802 ## core/src/main/scala/kafka/server/BrokerServer.scala: ## @@ -803,7 +807,7 @@ class BrokerServer( if (clientToControllerChannelManager != null)

Re: [PR] KAFKA-17182: Consumer fetch sessions are evicted too quickly with AsyncKafkaConsumer [kafka]

2025-02-10 Thread via GitHub
junrao commented on PR #18795: URL: https://github.com/apache/kafka/pull/18795#issuecomment-2648761490 @kirktrue : It seems the tests still failed? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[jira] [Updated] (KAFKA-18770) Fix flaky initializationError in ReplicationQuotasTest/RequestQuotaTest (thread leak)

2025-02-10 Thread Yu-Lin Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18770?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yu-Lin Chen updated KAFKA-18770: Labels: flaky-test (was: ) > Fix flaky initializationError in ReplicationQuotasTest/RequestQuotaT

[jira] [Created] (KAFKA-18770) Fix flaky initializationError in ReplicationQuotasTest/RequestQuotaTest (thread leak)

2025-02-10 Thread Yu-Lin Chen (Jira)
Yu-Lin Chen created KAFKA-18770: --- Summary: Fix flaky initializationError in ReplicationQuotasTest/RequestQuotaTest (thread leak) Key: KAFKA-18770 URL: https://issues.apache.org/jira/browse/KAFKA-18770 P

[PR] KAFKA-18769: Improve leadership changes handling in ShareConsumeRequestManager. [kafka]

2025-02-10 Thread via GitHub
ShivsundarR opened a new pull request, #18851: URL: https://github.com/apache/kafka/pull/18851 *What* Currently when we fetch records from a node and then there is a leadership change before we acknowledge, we attempt to send the acknowledgements to the old leader. This was just the

[jira] [Commented] (KAFKA-18735) the zk-related path `` is still existent in quota system, such as `ConfigEntity#name` and metrics tags

2025-02-10 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17925659#comment-17925659 ] Chia-Ping Tsai commented on KAFKA-18735: {quote} Do we have an ETA for this issu

[jira] [Updated] (KAFKA-18735) the zk-related path `` is still existent in quota system, such as `ConfigEntity#name` and metrics tags

2025-02-10 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18735?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai updated KAFKA-18735: --- Fix Version/s: 4.1.0 4.0.1 (was: 4.0.0) > the zk-r

[jira] [Updated] (KAFKA-18735) the zk-related path `` is still existent in quota system, such as `ConfigEntity#name` and metrics tags

2025-02-10 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18735?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai updated KAFKA-18735: --- Priority: Minor (was: Blocker) > the zk-related path `` is still existent in quota system,

[jira] [Updated] (KAFKA-18735) the zk-related path `` is still existent in quota system, such as `ConfigEntity#name` and metrics tags

2025-02-10 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18735?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai updated KAFKA-18735: --- Description: the `` is a specific "flag" used by zk path to represent the "default" quota.

[jira] [Reopened] (KAFKA-806) Index may not always observe log.index.interval.bytes

2025-02-10 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-806?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai reopened KAFKA-806: -- > Index may not always observe log.index.interval.bytes > --

[jira] [Resolved] (KAFKA-806) Index may not always observe log.index.interval.bytes

2025-02-10 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-806?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai resolved KAFKA-806. -- Fix Version/s: 3.9.1 3.8.2 Resolution: Fixed trunk: https://github.co

[jira] [Commented] (KAFKA-18762) 'Acks=all' not working correctly in Kafka Kraft mode.

2025-02-10 Thread PoAn Yang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17925619#comment-17925619 ] PoAn Yang commented on KAFKA-18762: --- > How can we stop a Kafka user to not create a to

Re: [PR] KAFKA-18298;KAFKA-18297: Fix flaky testConsumerGroupsDeprecatedConsumerGroupState and testConsumerGroups in PlaintextAdminIntegrationTest [kafka]

2025-02-10 Thread via GitHub
chenyulin0719 commented on PR #18513: URL: https://github.com/apache/kafka/pull/18513#issuecomment-2648540299 The flaky tests seems unrelated: in JAVA 17 - TransactionsTest.testBumpTransactionalEpochWithTV2Disabled (KAFKA-18035) - TransactionsTest.testFencingOnTransactionExpiration

Re: [PR] KAFKA-18767: Add client side config check [kafka]

2025-02-10 Thread via GitHub
TaiJuWu commented on code in PR #18850: URL: https://github.com/apache/kafka/pull/18850#discussion_r1949481278 ## clients/src/test/java/org/apache/kafka/clients/consumer/ConsumerConfigTest.java: ## @@ -240,20 +240,33 @@ public void testProtocolConfigValidation(String protocol,

Re: [PR] KAFKA-18441: Remove flaky tag on KafkaAdminClientTest#testAdminClientApisAuthenticationFailure [kafka]

2025-02-10 Thread via GitHub
AndrewJSchofield merged PR #18847: URL: https://github.com/apache/kafka/pull/18847 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafk

[jira] [Created] (KAFKA-18767) Add client side config check

2025-02-10 Thread TaiJuWu (Jira)
TaiJuWu created KAFKA-18767: --- Summary: Add client side config check Key: KAFKA-18767 URL: https://issues.apache.org/jira/browse/KAFKA-18767 Project: Kafka Issue Type: Sub-task Reporter:

[jira] [Commented] (KAFKA-18767) Add client side config check

2025-02-10 Thread TaiJuWu (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17925627#comment-17925627 ] TaiJuWu commented on KAFKA-18767: - If this is not legal, feel free to close this. > Add

Re: [PR] KAFKA-18366 Remove KafkaConfig.interBrokerProtocolVersion [kafka]

2025-02-10 Thread via GitHub
m1a2st commented on code in PR #18820: URL: https://github.com/apache/kafka/pull/18820#discussion_r1949472749 ## core/src/test/scala/unit/kafka/server/ReplicaFetcherThreadTest.scala: ## @@ -90,7 +90,7 @@ class ReplicaFetcherThreadTest { val logContext = new LogContext(s"[Re

Re: [PR] KAFKA-18366 Remove KafkaConfig.interBrokerProtocolVersion [kafka]

2025-02-10 Thread via GitHub
ijuma commented on code in PR #18820: URL: https://github.com/apache/kafka/pull/18820#discussion_r1949454294 ## core/src/main/scala/kafka/log/LogManager.scala: ## @@ -810,7 +808,7 @@ class LogManager(logDirs: Seq[File], /** * Checkpoint recovery offsets for all the logs i

[PR] KAFKA-18767: Add client side config check [kafka]

2025-02-10 Thread via GitHub
TaiJuWu opened a new pull request, #18850: URL: https://github.com/apache/kafka/pull/18850 Base on description from https://cwiki.apache.org/confluence/display/KAFKA/KIP-932%3A+Queues+for+Kafka#KIP932:QueuesforKafka-Configuration The existing consumer configurations apply for share gr

Re: [PR] KAFKA-18601: Assume a baseline of 3.3 for server protocol versions [kafka]

2025-02-10 Thread via GitHub
jolshan commented on code in PR #18845: URL: https://github.com/apache/kafka/pull/18845#discussion_r1949554971 ## core/src/main/scala/kafka/cluster/Partition.scala: ## @@ -1813,7 +1813,7 @@ class Partition(val topicPartition: TopicPartition, private def submitAlterPartition(p

[jira] [Resolved] (KAFKA-18759) The replicas followers may create mismatches indexes

2025-02-10 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18759?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai resolved KAFKA-18759. Fix Version/s: (was: 3.9.1) (was: 3.8.2) Resolution: Dupl

Re: [PR] KAFKA-18758: NullPointerException in shutdown following InvalidConfigurationException [kafka]

2025-02-10 Thread via GitHub
apoorvmittal10 commented on code in PR #18833: URL: https://github.com/apache/kafka/pull/18833#discussion_r1949535276 ## core/src/main/scala/kafka/server/BrokerServer.scala: ## @@ -803,7 +807,7 @@ class BrokerServer( if (clientToControllerChannelManager != null)

[jira] [Resolved] (KAFKA-18225) ClientQuotaCallback#updateClusterMetadata is unsupported by kraft

2025-02-10 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18225?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai resolved KAFKA-18225. Resolution: Fixed trunk: https://github.com/apache/kafka/commit/70adf746c472f9136a6e7b7bc

Re: [PR] KAFKA-806: Index may not always observe log.index.interval.bytes (#18012) [kafka]

2025-02-10 Thread via GitHub
chia7712 commented on PR #18842: URL: https://github.com/apache/kafka/pull/18842#issuecomment-2648713870 I will backport it to 4.0 after 4.0.0 gets released. open https://issues.apache.org/jira/browse/KAFKA-18768 to trace it -- This is an automated message from the Apache Git Service. To

[jira] [Created] (KAFKA-18768) Backport KAFKA-806 to 4.0

2025-02-10 Thread Chia-Ping Tsai (Jira)
Chia-Ping Tsai created KAFKA-18768: -- Summary: Backport KAFKA-806 to 4.0 Key: KAFKA-18768 URL: https://issues.apache.org/jira/browse/KAFKA-18768 Project: Kafka Issue Type: Sub-task

[jira] [Assigned] (KAFKA-18769) Handle leader changes in client to ensure we do not send requests to the previous leader

2025-02-10 Thread Shivsundar R (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18769?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shivsundar R reassigned KAFKA-18769: Assignee: Shivsundar R > Handle leader changes in client to ensure we do not send request

[jira] [Created] (KAFKA-18769) Handle leader changes in client to ensure we do not send requests to the previous leader

2025-02-10 Thread Shivsundar R (Jira)
Shivsundar R created KAFKA-18769: Summary: Handle leader changes in client to ensure we do not send requests to the previous leader Key: KAFKA-18769 URL: https://issues.apache.org/jira/browse/KAFKA-18769

[jira] [Updated] (KAFKA-18769) Handle leader changes in client to ensure we do not send requests to the previous leader

2025-02-10 Thread Shivsundar R (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18769?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shivsundar R updated KAFKA-18769: - Description: Handle leader changes in client to ensure we do not send requests to the previous

Re: [PR] KAFKA-18601: Assume a baseline of 3.3 for server protocol versions [kafka]

2025-02-10 Thread via GitHub
dajac commented on code in PR #18845: URL: https://github.com/apache/kafka/pull/18845#discussion_r1949569316 ## core/src/main/scala/kafka/cluster/Partition.scala: ## @@ -1813,7 +1813,7 @@ class Partition(val topicPartition: TopicPartition, private def submitAlterPartition(pro

Re: [PR] KAFKA-18758: NullPointerException in shutdown following InvalidConfigurationException [kafka]

2025-02-10 Thread via GitHub
edoardocomar commented on code in PR #18833: URL: https://github.com/apache/kafka/pull/18833#discussion_r1949573689 ## core/src/main/scala/kafka/server/BrokerServer.scala: ## @@ -803,7 +807,7 @@ class BrokerServer( if (clientToControllerChannelManager != null) Co

Re: [PR] KAFKA-806: Index may not always observe log.index.interval.bytes (#18012) [kafka]

2025-02-10 Thread via GitHub
chia7712 merged PR #18843: URL: https://github.com/apache/kafka/pull/18843 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

[jira] [Commented] (KAFKA-18762) 'Acks=all' not working correctly in Kafka Kraft mode.

2025-02-10 Thread Jun Rao (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17925654#comment-17925654 ] Jun Rao commented on KAFKA-18762: - It's possible to change the replication factor throug

Re: [PR] KAFKA-18601: Assume a baseline of 3.3 for server protocol versions [kafka]

2025-02-10 Thread via GitHub
ijuma commented on code in PR #18845: URL: https://github.com/apache/kafka/pull/18845#discussion_r1949577245 ## core/src/main/scala/kafka/cluster/Partition.scala: ## @@ -1813,7 +1813,7 @@ class Partition(val topicPartition: TopicPartition, private def submitAlterPartition(pro

Re: [PR] KAFKA-18396: Migrate log4j1 configuration to log4j2 in KafkaDockerWrapper [kafka]

2025-02-10 Thread via GitHub
frankvicky commented on PR #18394: URL: https://github.com/apache/kafka/pull/18394#issuecomment-2647732888 No worries. I very much appreciate your review. 🙇🏼 Just reapply the changes as mentioned. -- This is an automated message from the Apache Git Service. To respond to the message, p

[PR] HOTFIX: KStream java doc build error [kafka]

2025-02-10 Thread via GitHub
m1a2st opened a new pull request, #18849: URL: https://github.com/apache/kafka/pull/18849 I use `./gradlew :streams:javadoc`, it will have an error ``` > Configure project : Starting build with version 4.1.0-SNAPSHOT (commit id 7fef5b86) using Gradle 8.10.2, Java 17 and Scala 2.13.

Re: [PR] HOTFIX: KStream java doc build error [kafka]

2025-02-10 Thread via GitHub
m1a2st commented on PR #18849: URL: https://github.com/apache/kafka/pull/18849#issuecomment-2648104120 Its dulpicate with https://github.com/apache/kafka/pull/18838 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the U

Re: [PR] MINOR: fix KStream#to incorrect javadoc [kafka]

2025-02-10 Thread via GitHub
chia7712 merged PR #18838: URL: https://github.com/apache/kafka/pull/18838 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

Re: [PR] HOTFIX: KStream java doc build error [kafka]

2025-02-10 Thread via GitHub
m1a2st closed pull request #18849: HOTFIX: KStream java doc build error URL: https://github.com/apache/kafka/pull/18849 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsub

Re: [PR] KAFKA-18730: Add replaying streams group state from offset topic [kafka]

2025-02-10 Thread via GitHub
lucasbru commented on code in PR #18809: URL: https://github.com/apache/kafka/pull/18809#discussion_r1949131601 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -3405,6 +3616,49 @@ private void scheduleConsumerGroupRebalanceT

Re: [PR] KAFKA-18763: Resolved the flakiness in test_share_single_topic_partition system test [kafka]

2025-02-10 Thread via GitHub
AndrewJSchofield merged PR #18846: URL: https://github.com/apache/kafka/pull/18846 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafk

Re: [PR] KAFKA-16720: Support multiple groups in DescribeShareGroupOffsets RPC [kafka]

2025-02-10 Thread via GitHub
Copilot commented on code in PR #18834: URL: https://github.com/apache/kafka/pull/18834#discussion_r1949034856 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinator.java: ## @@ -259,15 +259,17 @@ CompletableFuture fetchAllOffs ); /**

[jira] [Updated] (KAFKA-17611) Remove ZK from Kafka 4.0

2025-02-10 Thread David Jacot (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17611?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Jacot updated KAFKA-17611: Priority: Major (was: Blocker) > Remove ZK from Kafka 4.0 > > >

[jira] [Commented] (KAFKA-17611) Remove ZK from Kafka 4.0

2025-02-10 Thread David Jacot (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17925573#comment-17925573 ] David Jacot commented on KAFKA-17611: - Reduced the priority. Let's mark tasks as blo

[jira] [Commented] (KAFKA-18762) 'Acks=all' not working correctly in Kafka Kraft mode.

2025-02-10 Thread Shubham Raj (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17925600#comment-17925600 ] Shubham Raj commented on KAFKA-18762: - [~dajac] , We tried keeping replication fact

Re: [PR] KAFKA-18758: NullPointerException in shutdown following InvalidConfigurationException [kafka]

2025-02-10 Thread via GitHub
edoardocomar commented on PR #18833: URL: https://github.com/apache/kafka/pull/18833#issuecomment-2648839225 CI rerun - only flaky failures again -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

Re: [PR] KAFKA-18641: AsyncKafkaConsumer could lose records with auto offset commit [kafka]

2025-02-10 Thread via GitHub
lianetm commented on code in PR #18737: URL: https://github.com/apache/kafka/pull/18737#discussion_r1949460839 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java: ## @@ -846,9 +845,18 @@ private CompletableFuture> commit(final C

Re: [PR] KAFKA-18601: Assume a baseline of 3.3 for server protocol versions [kafka]

2025-02-10 Thread via GitHub
jolshan commented on code in PR #18845: URL: https://github.com/apache/kafka/pull/18845#discussion_r1949680492 ## core/src/main/scala/kafka/cluster/Partition.scala: ## @@ -1813,7 +1813,7 @@ class Partition(val topicPartition: TopicPartition, private def submitAlterPartition(p

  1   2   3   >