chenyulin0719 commented on code in PR #18513:
URL: https://github.com/apache/kafka/pull/18513#discussion_r1948483601
##
core/src/test/scala/integration/kafka/api/PlaintextAdminIntegrationTest.scala:
##
@@ -1838,250 +1838,218 @@ class PlaintextAdminIntegrationTest extends
BaseAd
chenyulin0719 commented on code in PR #18513:
URL: https://github.com/apache/kafka/pull/18513#discussion_r1948486105
##
core/src/test/scala/integration/kafka/api/PlaintextAdminIntegrationTest.scala:
##
@@ -4003,6 +3939,72 @@ class PlaintextAdminIntegrationTest extends
BaseAdmin
urbandan commented on PR #17593:
URL: https://github.com/apache/kafka/pull/17593#issuecomment-2647185376
@sgn2607 The KIP is under discussion, but it is not really getting any
traction. I opened this PR to demonstrate the design in the KIP. If the KIP
gets accepted, I'll get back to this, a
chenyulin0719 commented on code in PR #18513:
URL: https://github.com/apache/kafka/pull/18513#discussion_r1948486105
##
core/src/test/scala/integration/kafka/api/PlaintextAdminIntegrationTest.scala:
##
@@ -4003,6 +3939,72 @@ class PlaintextAdminIntegrationTest extends
BaseAdmin
github-actions[bot] commented on PR #18711:
URL: https://github.com/apache/kafka/pull/18711#issuecomment-2646823752
A label of 'needs-attention' was automatically added to this PR in order to
raise the
attention of the committers. Once this issue has been triaged, the `triage`
label
s
github-actions[bot] commented on PR #18673:
URL: https://github.com/apache/kafka/pull/18673#issuecomment-2646823782
A label of 'needs-attention' was automatically added to this PR in order to
raise the
attention of the committers. Once this issue has been triaged, the `triage`
label
s
github-actions[bot] commented on PR #18463:
URL: https://github.com/apache/kafka/pull/18463#issuecomment-2646823810
A label of 'needs-attention' was automatically added to this PR in order to
raise the
attention of the committers. Once this issue has been triaged, the `triage`
label
s
[
https://issues.apache.org/jira/browse/KAFKA-18713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17925431#comment-17925431
]
Matthias J. Sax commented on KAFKA-18713:
-
{quote}Can I pick this up or is it bi
[
https://issues.apache.org/jira/browse/KAFKA-18697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17925433#comment-17925433
]
Chia-Ping Tsai commented on KAFKA-18697:
{quote}
We should probably not do this
github-actions[bot] commented on PR #6296:
URL: https://github.com/apache/kafka/pull/6296#issuecomment-2646846163
This PR has been closed since it has not had any activity in 120 days. If
you feel like this
was a mistake, or you would like to continue working on it, please feel free
to r
github-actions[bot] closed pull request #6296: Enable pending reassignments
cancellation/rollback
URL: https://github.com/apache/kafka/pull/6296
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the s
[
https://issues.apache.org/jira/browse/KAFKA-15895?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
TengYao Chi reassigned KAFKA-15895:
---
Assignee: TengYao Chi (was: Nikolay Izhikov)
> Move DynamicBrokerConfig to server module
>
kamalcph commented on PR #18807:
URL: https://github.com/apache/kafka/pull/18807#issuecomment-2646890135
Rerunning the Java 17 junit tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spec
github-actions[bot] commented on PR #15241:
URL: https://github.com/apache/kafka/pull/15241#issuecomment-2646846194
This PR is being marked as stale since it has not had any activity in 90
days. If you
would like to keep this PR alive, please leave a comment asking for a
review. If the P
github-actions[bot] commented on PR #17748:
URL: https://github.com/apache/kafka/pull/17748#issuecomment-2646846308
This PR is being marked as stale since it has not had any activity in 90
days. If you
would like to keep this PR alive, please leave a comment asking for a
review. If the P
github-actions[bot] commented on PR #17752:
URL: https://github.com/apache/kafka/pull/17752#issuecomment-2646846328
This PR is being marked as stale since it has not had any activity in 90
days. If you
would like to keep this PR alive, please leave a comment asking for a
review. If the P
[
https://issues.apache.org/jira/browse/KAFKA-18713?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Nil Madhab updated KAFKA-18713:
---
Attachment: Screenshot 2025-02-10 at 12.06.38.png
> Kafka Streams Left-Join not always emitting the
[
https://issues.apache.org/jira/browse/KAFKA-18713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17925469#comment-17925469
]
Nil Madhab commented on KAFKA-18713:
Thanks [~mjsax] , with 3 partition, I was able
[ https://issues.apache.org/jira/browse/KAFKA-18713 ]
Nil Madhab deleted comment on KAFKA-18713:
was (Author: nilmadhab):
[https://github.com/nilmadhab/kafka-examples/blob/main/src/main/java/com/java/demospring/config/KafkaStreamsConfig.java]
h
chenyulin0719 commented on code in PR #18513:
URL: https://github.com/apache/kafka/pull/18513#discussion_r1948486888
##
core/src/test/scala/integration/kafka/api/PlaintextAdminIntegrationTest.scala:
##
@@ -4003,6 +3939,72 @@ class PlaintextAdminIntegrationTest extends
BaseAdmin
chenyulin0719 commented on code in PR #18513:
URL: https://github.com/apache/kafka/pull/18513#discussion_r1948490066
##
core/src/test/scala/integration/kafka/api/PlaintextAdminIntegrationTest.scala:
##
@@ -4003,6 +3939,72 @@ class PlaintextAdminIntegrationTest extends
BaseAdmin
chenyulin0719 commented on code in PR #18513:
URL: https://github.com/apache/kafka/pull/18513#discussion_r1948481083
##
core/src/test/scala/integration/kafka/api/PlaintextAdminIntegrationTest.scala:
##
@@ -4004,6 +3922,82 @@ class PlaintextAdminIntegrationTest extends
BaseAdmin
chenyulin0719 commented on code in PR #18513:
URL: https://github.com/apache/kafka/pull/18513#discussion_r1948490509
##
core/src/test/scala/integration/kafka/api/PlaintextAdminIntegrationTest.scala:
##
@@ -4003,6 +3939,72 @@ class PlaintextAdminIntegrationTest extends
BaseAdmin
chenyulin0719 commented on code in PR #18513:
URL: https://github.com/apache/kafka/pull/18513#discussion_r1948486105
##
core/src/test/scala/integration/kafka/api/PlaintextAdminIntegrationTest.scala:
##
@@ -4003,6 +3939,72 @@ class PlaintextAdminIntegrationTest extends
BaseAdmin
chenyulin0719 commented on code in PR #18513:
URL: https://github.com/apache/kafka/pull/18513#discussion_r1948486105
##
core/src/test/scala/integration/kafka/api/PlaintextAdminIntegrationTest.scala:
##
@@ -4003,6 +3939,72 @@ class PlaintextAdminIntegrationTest extends
BaseAdmin
chenyulin0719 commented on code in PR #18513:
URL: https://github.com/apache/kafka/pull/18513#discussion_r1948486888
##
core/src/test/scala/integration/kafka/api/PlaintextAdminIntegrationTest.scala:
##
@@ -4003,6 +3939,72 @@ class PlaintextAdminIntegrationTest extends
BaseAdmin
chenyulin0719 commented on code in PR #18513:
URL: https://github.com/apache/kafka/pull/18513#discussion_r1948493346
##
core/src/test/scala/integration/kafka/api/PlaintextAdminIntegrationTest.scala:
##
@@ -4003,6 +3939,72 @@ class PlaintextAdminIntegrationTest extends
BaseAdmin
chenyulin0719 commented on PR #18513:
URL: https://github.com/apache/kafka/pull/18513#issuecomment-2647140935
Hi @dajac, @chia7712 ,
Sorry for the late update. I've done the investigations and update a newer
version. Also added my feedback under each discussion.
The latest cha
mjsax commented on PR #18106:
URL: https://github.com/apache/kafka/pull/18106#issuecomment-2646612800
No worries. Just highlighting this so we can (maybe?) do better going
forward.
> I am sorry to hear that people had to spend multiple hours trying to fix
this.
and
> S
FrankYang0529 commented on code in PR #18802:
URL: https://github.com/apache/kafka/pull/18802#discussion_r1948343182
##
core/src/main/scala/kafka/server/metadata/AclPublisher.scala:
##
@@ -1,102 +0,0 @@
-/**
- * Licensed to the Apache Software Foundation (ASF) under one or more
FrankYang0529 commented on code in PR #18387:
URL: https://github.com/apache/kafka/pull/18387#discussion_r1948343697
##
core/src/main/scala/kafka/server/KafkaConfig.scala:
##
@@ -575,7 +585,8 @@ class KafkaConfig private(doLog: Boolean, val props:
util.Map[_, _])
if (adver
ijuma commented on PR #18822:
URL: https://github.com/apache/kafka/pull/18822#issuecomment-2646955507
@mjsax Are you comfortable reviewing the rest as well?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
[
https://issues.apache.org/jira/browse/KAFKA-18755?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17925475#comment-17925475
]
Sanskar Jhajharia edited comment on KAFKA-18755 at 2/10/25 5:33 AM:
--
[
https://issues.apache.org/jira/browse/KAFKA-18755?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17925475#comment-17925475
]
Sanskar Jhajharia commented on KAFKA-18755:
---
Similar to the {{--list}} option
ijuma commented on code in PR #18845:
URL: https://github.com/apache/kafka/pull/18845#discussion_r1948421007
##
core/src/main/scala/kafka/cluster/Partition.scala:
##
@@ -1813,7 +1813,7 @@ class Partition(val topicPartition: TopicPartition,
private def submitAlterPartition(pro
ijuma commented on code in PR #18845:
URL: https://github.com/apache/kafka/pull/18845#discussion_r1948437894
##
metadata/src/main/java/org/apache/kafka/image/node/MetadataNode.java:
##
@@ -53,7 +53,8 @@ default void print(MetadataNodePrinter printer) {
for (String name
ijuma commented on code in PR #18845:
URL: https://github.com/apache/kafka/pull/18845#discussion_r1948439556
##
metadata/src/test/java/org/apache/kafka/image/ImageDowngradeTest.java:
##
@@ -77,59 +77,6 @@ static ApiMessageAndVersion
metadataVersionRecord(MetadataVersion metadat
ijuma commented on code in PR #18845:
URL: https://github.com/apache/kafka/pull/18845#discussion_r1948438967
##
metadata/src/main/java/org/apache/kafka/metadata/bootstrap/BootstrapDirectory.java:
##
@@ -86,12 +84,7 @@ BootstrapMetadata readFromConfiguration() {
retu
ijuma commented on code in PR #18845:
URL: https://github.com/apache/kafka/pull/18845#discussion_r1948439772
##
metadata/src/test/java/org/apache/kafka/image/ImageDowngradeTest.java:
##
@@ -77,59 +77,6 @@ static ApiMessageAndVersion
metadataVersionRecord(MetadataVersion metadat
gongxuanzhang commented on PR #18812:
URL: https://github.com/apache/kafka/pull/18812#issuecomment-2647067277
@chia7712 PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
ijuma opened a new pull request, #18845:
URL: https://github.com/apache/kafka/pull/18845
TODO:
1. Review the PR carefully
2. Update upgrade notes
3. Explain the changes in more detail
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementat
ijuma commented on code in PR #18845:
URL: https://github.com/apache/kafka/pull/18845#discussion_r1948187511
##
tools/src/test/java/org/apache/kafka/tools/reassign/ReassignPartitionsCommandTest.java:
##
@@ -128,18 +126,6 @@ public void testReassignment() throws Exception {
42 matches
Mail list logo
