Re: [PR] MINOR: Remove javadoc of non-exist parameter. [kafka]

2025-01-13 Thread via GitHub
frankvicky commented on code in PR #18493: URL: https://github.com/apache/kafka/pull/18493#discussion_r1913049034 ## core/src/main/scala/kafka/server/metadata/KRaftMetadataCache.scala: ## @@ -151,9 +151,7 @@ class KRaftMetadataCache( * @param topicName The

Re: [PR] KAFKA-18399 Remove ZooKeeper from KafkaApis (3/N): ALTER_CONFIG, INCREMENETAL_ALTER_CONFIG [kafka]

2025-01-13 Thread via GitHub
TaiJuWu commented on code in PR #18432: URL: https://github.com/apache/kafka/pull/18432#discussion_r1913106963 ## core/src/test/scala/unit/kafka/server/KafkaApisTest.scala: ## @@ -485,44 +412,6 @@ class KafkaApisTest extends Logging { } } - @Test - def testAlterConfi

Re: [PR] KAFKA-18399 Remove ZooKeeper from KafkaApis (3/N): ALTER_CONFIG, INCREMENETAL_ALTER_CONFIG [kafka]

2025-01-13 Thread via GitHub
TaiJuWu commented on code in PR #18432: URL: https://github.com/apache/kafka/pull/18432#discussion_r1913106963 ## core/src/test/scala/unit/kafka/server/KafkaApisTest.scala: ## @@ -485,44 +412,6 @@ class KafkaApisTest extends Logging { } } - @Test - def testAlterConfi

Re: [PR] KAFKA-18399 Remove ZooKeeper from KafkaApis (3/N): ALTER_CONFIG, INCREMENETAL_ALTER_CONFIG [kafka]

2025-01-13 Thread via GitHub
TaiJuWu commented on code in PR #18432: URL: https://github.com/apache/kafka/pull/18432#discussion_r1913119176 ## core/src/test/scala/unit/kafka/server/KafkaApisTest.scala: ## @@ -485,44 +412,6 @@ class KafkaApisTest extends Logging { } } - @Test - def testAlterConfi

Re: [PR] Add DescribeShareGroupOffsets API [KIP-932] [kafka]

2025-01-13 Thread via GitHub
sjhajharia commented on code in PR #18500: URL: https://github.com/apache/kafka/pull/18500#discussion_r1912897983 ## clients/src/main/resources/common/message/DescribeShareGroupOffsetsRequest.json: ## @@ -0,0 +1,34 @@ +// Licensed to the Apache Software Foundation (ASF) under on

Re: [PR] KAFKA-18457; Update DumpLogSegments to use coordinator record json converters [kafka]

2025-01-13 Thread via GitHub
dajac commented on code in PR #18480: URL: https://github.com/apache/kafka/pull/18480#discussion_r1912971085 ## core/src/main/scala/kafka/tools/DumpLogSegments.scala: ## @@ -519,41 +483,11 @@ object DumpLogSegments { json } -private def prepareValue(message: Me

Re: [PR] KAFKA-18457; Update DumpLogSegments to use coordinator record json converters [kafka]

2025-01-13 Thread via GitHub
dajac merged PR #18480: URL: https://github.com/apache/kafka/pull/18480 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or

Re: [PR] KAFKA-18399 Remove ZooKeeper from KafkaApis (3/N): ALTER_CONFIG, INCREMENETAL_ALTER_CONFIG [kafka]

2025-01-13 Thread via GitHub
TaiJuWu commented on code in PR #18432: URL: https://github.com/apache/kafka/pull/18432#discussion_r1913065969 ## core/src/test/scala/unit/kafka/server/KafkaApisTest.scala: ## @@ -485,44 +412,6 @@ class KafkaApisTest extends Logging { } } - @Test - def testAlterConfi

Re: [PR] KAFKA-18404: Remove partitionMaxBytes usage from DelayedShareFetch [kafka]

2025-01-13 Thread via GitHub
apoorvmittal10 commented on code in PR #17870: URL: https://github.com/apache/kafka/pull/17870#discussion_r1913035425 ## core/src/test/java/kafka/server/share/DelayedShareFetchTest.java: ## @@ -758,6 +765,285 @@ public void testTryCompleteWhenPartitionMaxBytesStrategyThrowsExce

Re: [PR] KAFKA-18404: Remove partitionMaxBytes usage from DelayedShareFetch [kafka]

2025-01-13 Thread via GitHub
apoorvmittal10 commented on code in PR #17870: URL: https://github.com/apache/kafka/pull/17870#discussion_r1913066020 ## core/src/test/java/kafka/server/share/DelayedShareFetchTest.java: ## @@ -758,6 +765,285 @@ public void testTryCompleteWhenPartitionMaxBytesStrategyThrowsExce

Re: [PR] KAFKA-18399 Remove ZooKeeper from KafkaApis (3/N): ALTER_CONFIG, INCREMENETAL_ALTER_CONFIG [kafka]

2025-01-13 Thread via GitHub
TaiJuWu commented on code in PR #18432: URL: https://github.com/apache/kafka/pull/18432#discussion_r1913106963 ## core/src/test/scala/unit/kafka/server/KafkaApisTest.scala: ## @@ -485,44 +412,6 @@ class KafkaApisTest extends Logging { } } - @Test - def testAlterConfi

Re: [PR] KAFKA-18399 Remove ZooKeeper from KafkaApis (3/N): ALTER_CONFIG, INCREMENETAL_ALTER_CONFIG [kafka]

2025-01-13 Thread via GitHub
TaiJuWu commented on code in PR #18432: URL: https://github.com/apache/kafka/pull/18432#discussion_r1913134917 ## core/src/test/scala/unit/kafka/server/KafkaApisTest.scala: ## @@ -485,44 +412,6 @@ class KafkaApisTest extends Logging { } } - @Test - def testAlterConfi

Re: [PR] KAFKA-806: Index may not always observe log.index.interval.bytes [kafka]

2025-01-13 Thread via GitHub
FrankYang0529 commented on code in PR #18012: URL: https://github.com/apache/kafka/pull/18012#discussion_r1913145038 ## core/src/main/scala/kafka/log/UnifiedLog.scala: ## @@ -1180,9 +1179,7 @@ class UnifiedLog(@volatile var logStartOffset: Long, else OptionalInt.empt

Re: [PR] KAFKA-806: Index may not always observe log.index.interval.bytes [kafka]

2025-01-13 Thread via GitHub
FrankYang0529 commented on code in PR #18012: URL: https://github.com/apache/kafka/pull/18012#discussion_r1913144684 ## storage/src/main/java/org/apache/kafka/storage/internals/log/LogSegment.java: ## @@ -232,38 +232,48 @@ private boolean canConvertToRelativeOffset(long offset)

Re: [PR] KAFKA-18399 Remove ZooKeeper from KafkaApis (3/N): ALTER_CONFIG, INCREMENETAL_ALTER_CONFIG [kafka]

2025-01-13 Thread via GitHub
TaiJuWu commented on code in PR #18432: URL: https://github.com/apache/kafka/pull/18432#discussion_r1913134917 ## core/src/test/scala/unit/kafka/server/KafkaApisTest.scala: ## @@ -485,44 +412,6 @@ class KafkaApisTest extends Logging { } } - @Test - def testAlterConfi

Re: [PR] KAFKA-18399 Remove ZooKeeper from KafkaApis (3/N): ALTER_CONFIG, INCREMENETAL_ALTER_CONFIG [kafka]

2025-01-13 Thread via GitHub
TaiJuWu commented on code in PR #18432: URL: https://github.com/apache/kafka/pull/18432#discussion_r1913119176 ## core/src/test/scala/unit/kafka/server/KafkaApisTest.scala: ## @@ -485,44 +412,6 @@ class KafkaApisTest extends Logging { } } - @Test - def testAlterConfi

Re: [PR] First draft of system tests for the new share consumer client [kafka]

2025-01-13 Thread via GitHub
apoorvmittal10 commented on code in PR #18209: URL: https://github.com/apache/kafka/pull/18209#discussion_r1913136314 ## tests/kafkatest/services/verifiable_share_consumer.py: ## @@ -0,0 +1,337 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +# contribut

Re: [PR] KAFKA-806: Index may not always observe log.index.interval.bytes [kafka]

2025-01-13 Thread via GitHub
FrankYang0529 commented on code in PR #18012: URL: https://github.com/apache/kafka/pull/18012#discussion_r1913157006 ## storage/src/main/java/org/apache/kafka/storage/internals/log/LogSegment.java: ## @@ -232,38 +232,48 @@ private boolean canConvertToRelativeOffset(long offset)

Re: [PR] MINOR: Update 4.0.0 documentation for Kafka Streams [kafka]

2025-01-13 Thread via GitHub
aliehsaeedii commented on code in PR #18124: URL: https://github.com/apache/kafka/pull/18124#discussion_r1913157735 ## docs/streams/upgrade-guide.html: ## @@ -141,6 +141,22 @@ < Streams API changes in 4.0.0 + +In this release, eos-v1 (Exactly Once Semantics

[jira] [Resolved] (KAFKA-18213) Convert CustomQuotaCallbackTest to KRaft

2025-01-13 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-18213?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] 黃竣陽 resolved KAFKA-18213. - Resolution: Duplicate > Convert CustomQuotaCallbackTest to KRaft > > >

Re: [PR] MINOR: Update 4.0.0 documentation for Kafka Streams [kafka]

2025-01-13 Thread via GitHub
aliehsaeedii commented on PR #18124: URL: https://github.com/apache/kafka/pull/18124#issuecomment-2587368110 @mjsax Final question: I assume KIP-1106 should not be listed here. Right? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to G

Re: [PR] KAFKA-806: Index may not always observe log.index.interval.bytes [kafka]

2025-01-13 Thread via GitHub
FrankYang0529 commented on code in PR #18012: URL: https://github.com/apache/kafka/pull/18012#discussion_r1914017810 ## storage/src/test/java/org/apache/kafka/storage/internals/log/LogSegmentTest.java: ## @@ -342,7 +344,9 @@ public void testTruncateFull() throws IOException {

Re: [PR] KAFKA-18399 Remove ZooKeeper from KafkaApis (5/N): ELECT_LEADERS , ALTER_PARTITION, UPDATE_FEATURES [kafka]

2025-01-13 Thread via GitHub
TaiJuWu commented on code in PR #18453: URL: https://github.com/apache/kafka/pull/18453#discussion_r1914021095 ## core/src/main/scala/kafka/server/KafkaApis.scala: ## @@ -217,7 +216,7 @@ class KafkaApis(val requestChannel: RequestChannel, case ApiKeys.ALTER_CLIENT_QUOTA

Re: [PR] KAFKA-18399 Remove ZooKeeper from KafkaApis (5/N): ELECT_LEADERS , ALTER_PARTITION, UPDATE_FEATURES [kafka]

2025-01-13 Thread via GitHub
TaiJuWu commented on code in PR #18453: URL: https://github.com/apache/kafka/pull/18453#discussion_r1914021095 ## core/src/main/scala/kafka/server/KafkaApis.scala: ## @@ -217,7 +216,7 @@ class KafkaApis(val requestChannel: RequestChannel, case ApiKeys.ALTER_CLIENT_QUOTA

Re: [PR] KAFKA-18399 Remove ZooKeeper from KafkaApis (6/N): CREATE_ACLS, DELETE_ACLS [kafka]

2025-01-13 Thread via GitHub
tedyyan commented on PR #18454: URL: https://github.com/apache/kafka/pull/18454#issuecomment-2588604820 It looks like this has been fixed by ![image](https://github.com/user-attachments/assets/8cd435be-876d-4ad5-a025-b590c3d5f319) -- This is an automated message from the Apache Gi

[jira] [Comment Edited] (KAFKA-18493) Fix configure :streams:integration-tests project error

2025-01-13 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-18493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17912685#comment-17912685 ] 黃竣陽 edited comment on KAFKA-18493 at 1/14/25 12:48 AM: --- I use the

Re: [PR] KAFKA-16907: Fix RaftUtil's type complexity [kafka]

2025-01-13 Thread via GitHub
frankvicky commented on code in PR #16831: URL: https://github.com/apache/kafka/pull/16831#discussion_r1913976839 ## raft/src/main/java/org/apache/kafka/raft/utils/BeginQuorumEpochRpc.java: ## @@ -0,0 +1,132 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one o

Re: [PR] KAFKA-18493: Fix configure :streams:integration-tests project error [kafka]

2025-01-13 Thread via GitHub
m1a2st commented on code in PR #18511: URL: https://github.com/apache/kafka/pull/18511#discussion_r1914004855 ## build.gradle: ## @@ -2861,6 +2861,7 @@ project(':streams:integration-tests') { dependencies { implementation libs.slf4jApi +api libs.scalaLibrary Revie

Re: [PR] KAFKA-18409: ShareGroupStateMessageFormatter should use ApiMessageFormatter [kafka]

2025-01-13 Thread via GitHub
brandboat commented on code in PR #18510: URL: https://github.com/apache/kafka/pull/18510#discussion_r1914032613 ## tools/src/main/java/org/apache/kafka/tools/consumer/ApiMessageFormatter.java: ## @@ -38,7 +38,7 @@ public abstract class ApiMessageFormatter implements MessageFor

[jira] [Assigned] (KAFKA-18497) Remove config/kraft/server.properties

2025-01-13 Thread TengYao Chi (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18497?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] TengYao Chi reassigned KAFKA-18497: --- Assignee: TengYao Chi > Remove config/kraft/server.properties > ---

[jira] [Commented] (KAFKA-17644) TLA+ spec modifications

2025-01-13 Thread Alyssa Huang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17912684#comment-17912684 ] Alyssa Huang commented on KAFKA-17644: -- for some reason I can't find your name in t

Re: [PR] KAFKA-18405: Remove ZooKeeper logic from DynamicBrokerConfig [kafka]

2025-01-13 Thread via GitHub
FrankYang0529 commented on PR #18508: URL: https://github.com/apache/kafka/pull/18508#issuecomment-2588526940 Hi @chia7712, I will handle it in this PR because this PR is created by that thread. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message

Re: [PR] KAFKA-806: Index may not always observe log.index.interval.bytes [kafka]

2025-01-13 Thread via GitHub
junrao commented on code in PR #18012: URL: https://github.com/apache/kafka/pull/18012#discussion_r1913991060 ## storage/src/test/java/org/apache/kafka/storage/internals/log/LogSegmentTest.java: ## @@ -779,6 +784,75 @@ public void testDeleteIfExistsWithGetParentIsNull() throws

Re: [PR] KAFKA-18318: Add logs for online/offline migration indication [kafka]

2025-01-13 Thread via GitHub
github-actions[bot] commented on PR #18406: URL: https://github.com/apache/kafka/pull/18406#issuecomment-2588820087 A label of 'needs-attention' was automatically added to this PR in order to raise the attention of the committers. Once this issue has been triaged, the `triage` label s

Re: [PR] KAFKA-18396: Migrate log4j1 configuration to log4j2 in KafkaDockerWrapper [kafka]

2025-01-13 Thread via GitHub
github-actions[bot] commented on PR #18394: URL: https://github.com/apache/kafka/pull/18394#issuecomment-2588820131 A label of 'needs-attention' was automatically added to this PR in order to raise the attention of the committers. Once this issue has been triaged, the `triage` label s

Re: [PR] Add an option for ignoring tombstone records while a get on VersionedKeyValueStore [kafka]

2025-01-13 Thread via GitHub
github-actions[bot] commented on PR #18398: URL: https://github.com/apache/kafka/pull/18398#issuecomment-2588820112 A label of 'needs-attention' was automatically added to this PR in order to raise the attention of the committers. Once this issue has been triaged, the `triage` label s

Re: [PR] KAFKA-18211: Override class loaders for class graph scanning in connect. [kafka]

2025-01-13 Thread via GitHub
snehashisp commented on PR #18403: URL: https://github.com/apache/kafka/pull/18403#issuecomment-2588822883 Hi @gharris1727, shouldn't we merge this before the 15th and port it to 4.0. TIA -- This is an automated message from the Apache Git Service. To respond to the message, please log on

Re: [PR] Add DescribeShareGroupOffsets API [KIP-932] [kafka]

2025-01-13 Thread via GitHub
AndrewJSchofield commented on code in PR #18500: URL: https://github.com/apache/kafka/pull/18500#discussion_r1913816942 ## core/src/test/scala/unit/kafka/server/RequestQuotaTest.scala: ## @@ -868,7 +871,7 @@ object RequestQuotaTest { val SaslActions = Set(ApiKeys.SASL_HANDSHA

Re: [PR] KAFKA-9914: Fix replication cycle detection [kafka]

2025-01-13 Thread via GitHub
MANOJGHOSH commented on PR #10277: URL: https://github.com/apache/kafka/pull/10277#issuecomment-2588247600 Not sure, If this is fixed. I am still getting this issue with MM2 on kafka-connect 7.6.4-ce. Why don't we define heartbeats as .heartbeats or heartbeats.internal -- This is an auto

[jira] [Commented] (KAFKA-9914) Mirror Maker 2 creates heartbeats kafka topics recursively

2025-01-13 Thread MANOJ KUMAR GHOSH (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17912667#comment-17912667 ] MANOJ KUMAR GHOSH commented on KAFKA-9914: -- Not sure, If this is fixed. I am sti

Re: [PR] KAFKA-16907: Fix RaftUtil's type complexity [kafka]

2025-01-13 Thread via GitHub
ahuang98 commented on code in PR #16831: URL: https://github.com/apache/kafka/pull/16831#discussion_r1913874958 ## raft/src/main/java/org/apache/kafka/raft/utils/BeginQuorumEpochRpc.java: ## @@ -0,0 +1,132 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or

Re: [PR] KAFKA-16907: Fix RaftUtil's type complexity [kafka]

2025-01-13 Thread via GitHub
ahuang98 commented on code in PR #16831: URL: https://github.com/apache/kafka/pull/16831#discussion_r1913875681 ## raft/src/main/java/org/apache/kafka/raft/utils/DescribeQuorumRpc.java: ## @@ -0,0 +1,135 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or mo

Re: [PR] KAFKA-18493: Fix configure :streams:integration-tests project error [kafka]

2025-01-13 Thread via GitHub
m1a2st commented on code in PR #18511: URL: https://github.com/apache/kafka/pull/18511#discussion_r1913995058 ## build.gradle: ## @@ -2861,6 +2861,7 @@ project(':streams:integration-tests') { dependencies { implementation libs.slf4jApi +api libs.scalaLibrary Revie

Re: [PR] KAFKA-18229: Move configs out of "kraft" directory [kafka]

2025-01-13 Thread via GitHub
frankvicky commented on PR #18389: URL: https://github.com/apache/kafka/pull/18389#issuecomment-2588509264 Hi @jsancio, I have read the ticket description and agree it would be good to address KAFKA-18497 in this PR. I will update the patch in the next commit. 🐱 -- This is an

[jira] [Commented] (KAFKA-18493) Fix configure :streams:integration-tests project error

2025-01-13 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-18493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17912685#comment-17912685 ] 黃竣陽 commented on KAFKA-18493: - I use the intellij feature !image-2025-01-14-08-46-14-665.pn

[jira] [Updated] (KAFKA-18493) Fix configure :streams:integration-tests project error

2025-01-13 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-18493?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] 黃竣陽 updated KAFKA-18493: Attachment: image-2025-01-14-08-46-29-732.png > Fix configure :streams:integration-tests project error > -

[jira] [Updated] (KAFKA-18493) Fix configure :streams:integration-tests project error

2025-01-13 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-18493?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] 黃竣陽 updated KAFKA-18493: Attachment: image-2025-01-14-08-46-14-665.png > Fix configure :streams:integration-tests project error > -

Re: [PR] KAFKA-18229: Move configs out of "kraft" directory [kafka]

2025-01-13 Thread via GitHub
chia7712 commented on code in PR #18389: URL: https://github.com/apache/kafka/pull/18389#discussion_r1913979735 ## bin/kafka-storage.sh: ## @@ -14,4 +14,12 @@ # See the License for the specific language governing permissions and # limitations under the License. +for i in $(s

[jira] [Commented] (KAFKA-18497) Remove config/kraft/server.properties

2025-01-13 Thread TengYao Chi (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17912682#comment-17912682 ] TengYao Chi commented on KAFKA-18497: - Hi [~jsancio]  I think this ticket is relate

Re: [PR] KAFKA-17503: Fix incorrect calculation of poll-idle-ratio-avg for con… [kafka]

2025-01-13 Thread via GitHub
srdo commented on PR #17139: URL: https://github.com/apache/kafka/pull/17139#issuecomment-2588501588 > I am having a hard time following along with your example - specifically starting at this point > We can then look at the latest poll and "fill in" the interval, drawing first from

Re: [PR] KAFKA-17503: Fix incorrect calculation of poll-idle-ratio-avg for con… [kafka]

2025-01-13 Thread via GitHub
srdo commented on code in PR #17139: URL: https://github.com/apache/kafka/pull/17139#discussion_r1913965526 ## clients/src/test/java/org/apache/kafka/clients/consumer/KafkaConsumerTest.java: ## @@ -3098,31 +3098,53 @@ public void testPollIdleRatio(GroupProtocol groupProtocol) {

Re: [PR] KAFKA-18493: Fix configure :streams:integration-tests project error [kafka]

2025-01-13 Thread via GitHub
ijuma commented on code in PR #18511: URL: https://github.com/apache/kafka/pull/18511#discussion_r1914003570 ## build.gradle: ## @@ -2861,6 +2861,7 @@ project(':streams:integration-tests') { dependencies { implementation libs.slf4jApi +api libs.scalaLibrary Review

[jira] [Commented] (KAFKA-18493) Fix configure :streams:integration-tests project error

2025-01-13 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17912715#comment-17912715 ] Matthias J. Sax commented on KAFKA-18493: - Thanks! > Fix configure :streams:int

Re: [PR] KAFKA-18493: Fix configure :streams:integration-tests project error [kafka]

2025-01-13 Thread via GitHub
mjsax commented on code in PR #18511: URL: https://github.com/apache/kafka/pull/18511#discussion_r1914154646 ## build.gradle: ## @@ -2861,6 +2861,7 @@ project(':streams:integration-tests') { dependencies { implementation libs.slf4jApi +implementation libs.scalaLibr

Re: [PR] KAFKA-18409: ShareGroupStateMessageFormatter should use ApiMessageFormatter [kafka]

2025-01-13 Thread via GitHub
brandboat commented on code in PR #18510: URL: https://github.com/apache/kafka/pull/18510#discussion_r1914066204 ## tools/src/main/java/org/apache/kafka/tools/consumer/ApiMessageFormatter.java: ## @@ -79,5 +79,5 @@ public void writeTo(ConsumerRecord consumerRecord, PrintStream

[jira] [Updated] (KAFKA-18493) Fix configure :streams:integration-tests project error

2025-01-13 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-18493?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] 黃竣陽 updated KAFKA-18493: Attachment: (was: image-2025-01-14-08-46-14-665.png) > Fix configure :streams:integration-tests project error

Re: [PR] KAFKA-18399 Remove ZooKeeper from KafkaApis (6/N): CREATE_ACLS, DELETE_ACLS [kafka]

2025-01-13 Thread via GitHub
tedyyan closed pull request #18454: KAFKA-18399 Remove ZooKeeper from KafkaApis (6/N): CREATE_ACLS, DELETE_ACLS URL: https://github.com/apache/kafka/pull/18454 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [PR] KAFKA-806: Index may not always observe log.index.interval.bytes [kafka]

2025-01-13 Thread via GitHub
FrankYang0529 commented on code in PR #18012: URL: https://github.com/apache/kafka/pull/18012#discussion_r191402 ## storage/src/test/java/org/apache/kafka/storage/internals/log/LogSegmentTest.java: ## @@ -779,6 +784,75 @@ public void testDeleteIfExistsWithGetParentIsNull() t

[jira] [Resolved] (KAFKA-18036) TransactionsWithTieredStoreTest testReadCommittedConsumerShouldNotSeeUndecidedData is flaky

2025-01-13 Thread Yu-Lin Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18036?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yu-Lin Chen resolved KAFKA-18036. - Resolution: Fixed The fix for KAFKA-18469 has been mergerd, so this issue should be resolved. >

[jira] [Created] (KAFKA-18501) Fix flaky ClientQuotasRequestTest.testAlterClientQuotasInvalidRequests

2025-01-13 Thread Yu-Lin Chen (Jira)
Yu-Lin Chen created KAFKA-18501: --- Summary: Fix flaky ClientQuotasRequestTest.testAlterClientQuotasInvalidRequests Key: KAFKA-18501 URL: https://issues.apache.org/jira/browse/KAFKA-18501 Project: Kafka

Re: [PR] KAFKA-18298;KAFKA-18297: Fix flaky testConsumerGroupsDeprecatedConsumerGroupState and testConsumerGroups in PlaintextAdminIntegrationTest [kafka]

2025-01-13 Thread via GitHub
chenyulin0719 commented on PR #18513: URL: https://github.com/apache/kafka/pull/18513#issuecomment-2588907123 This PR only changed test code. The CI fail seems unrelated. JAVA23 - TransactionsWithTieredStoreTest#testReadCommittedConsumerShouldNotSeeUndecidedData (Should be fixed a

[PR] KAFKA-18440: Convert AuthorizationException to fatal error in AdminClient (#18435) [kafka]

2025-01-13 Thread via GitHub
FrankYang0529 opened a new pull request, #18502: URL: https://github.com/apache/kafka/pull/18502 Cherry-pick commit https://github.com/apache/kafka/commit/2b7c039971a37b1d568913a7ffa49d8abf50c79a. Since 3.9 branch doesn't have file `test-common/test-common-api/src/test/java/org/apach

Re: [PR] KAFKA-18404: Remove partitionMaxBytes usage from DelayedShareFetch [kafka]

2025-01-13 Thread via GitHub
adixitconfluent commented on code in PR #17870: URL: https://github.com/apache/kafka/pull/17870#discussion_r1912824457 ## core/src/test/java/kafka/server/share/DelayedShareFetchTest.java: ## @@ -559,13 +561,18 @@ public void testCombineLogReadResponse() { .withShare

[jira] [Commented] (KAFKA-18297) Fix flaky PlaintextAdminIntegrationTest.testConsumerGroups

2025-01-13 Thread Jhen-Yung Hsu (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17912404#comment-17912404 ] Jhen-Yung Hsu commented on KAFKA-18297: --- Case 1 still exists, and I found another

[PR] MINOR: Replace deprecated `Project.buildDir` property in gradle [kafka]

2025-01-13 Thread via GitHub
frankvicky opened a new pull request, #18501: URL: https://github.com/apache/kafka/pull/18501 reference: https://docs.gradle.org/8.10.2/dsl/org.gradle.api.Project.html#org.gradle.api.Project:buildDir `buidDir` is deprecated and will be removed in the next major version of Gradle. We

[PR] KAFKA-18440: Convert AuthorizationException to fatal error in AdminClient (#18435) [kafka]

2025-01-13 Thread via GitHub
FrankYang0529 opened a new pull request, #18503: URL: https://github.com/apache/kafka/pull/18503 Cherry-pick commit https://github.com/apache/kafka/commit/2b7c039971a37b1d568913a7ffa49d8abf50c79a. Since 3.8 branch doesn't have file `test-common/test-common-api/src/test/java/org/apach

Re: [PR] KAFKA-18340 Change Dockerfile to use log4j2 yaml instead log4j properties [kafka]

2025-01-13 Thread via GitHub
m1a2st commented on code in PR #18378: URL: https://github.com/apache/kafka/pull/18378#discussion_r1912475984 ## docker/jvm/Dockerfile: ## @@ -56,8 +56,9 @@ ARG build_date LABEL org.label-schema.name="kafka" \ org.label-schema.description="Apache Kafka" \ org.labe

Re: [PR] Cherrypick lock backoff retry to 3.9 [kafka]

2025-01-13 Thread via GitHub
cadonna commented on code in PR #18485: URL: https://github.com/apache/kafka/pull/18485#discussion_r1912842473 ## streams/src/test/java/org/apache/kafka/streams/processor/internals/TaskManagerTest.java: ## @@ -4578,48 +4626,6 @@ public void shouldNotFailForTimeoutExceptionOnCon

Re: [PR] Add DescribeShareGroupOffsets API [KIP-932] [kafka]

2025-01-13 Thread via GitHub
AndrewJSchofield commented on code in PR #18500: URL: https://github.com/apache/kafka/pull/18500#discussion_r1912867262 ## clients/src/main/resources/common/message/DescribeShareGroupOffsetsRequest.json: ## @@ -0,0 +1,34 @@ +// Licensed to the Apache Software Foundation (ASF) un

Re: [PR] KAFKA-18399 Remove ZooKeeper from KafkaApis (3/N): ALTER_CONFIG, INCREMENETAL_ALTER_CONFIG [kafka]

2025-01-13 Thread via GitHub
TaiJuWu commented on code in PR #18432: URL: https://github.com/apache/kafka/pull/18432#discussion_r1913065969 ## core/src/test/scala/unit/kafka/server/KafkaApisTest.scala: ## @@ -485,44 +412,6 @@ class KafkaApisTest extends Logging { } } - @Test - def testAlterConfi

Re: [PR] MINOR: Fix typo in DumpLogSegments' TransactionLogMessageParser [kafka]

2025-01-13 Thread via GitHub
clolov commented on code in PR #18505: URL: https://github.com/apache/kafka/pull/18505#discussion_r1913071846 ## core/src/main/scala/kafka/tools/DumpLogSegments.scala: ## @@ -548,7 +548,7 @@ object DumpLogSegments { } val json = new ObjectNode(JsonNodeFactory.ins

Re: [PR] KAFKA-18399 Remove ZooKeeper from KafkaApis (3/N): ALTER_CONFIG, INCREMENETAL_ALTER_CONFIG [kafka]

2025-01-13 Thread via GitHub
TaiJuWu commented on code in PR #18432: URL: https://github.com/apache/kafka/pull/18432#discussion_r1913065969 ## core/src/test/scala/unit/kafka/server/KafkaApisTest.scala: ## @@ -485,44 +412,6 @@ class KafkaApisTest extends Logging { } } - @Test - def testAlterConfi

Re: [PR] MINOR: Remove javadoc of non-exist parameter. [kafka]

2025-01-13 Thread via GitHub
mimaison commented on code in PR #18493: URL: https://github.com/apache/kafka/pull/18493#discussion_r1913099422 ## core/src/main/scala/kafka/server/metadata/KRaftMetadataCache.scala: ## @@ -269,11 +267,10 @@ class KRaftMetadataCache( * Note, the topics should be sorted in al

Re: [PR] KAFKA-18034: CommitRequestManager should fail pending requests on fatal coordinator errors [kafka]

2025-01-13 Thread via GitHub
m1a2st commented on PR #18050: URL: https://github.com/apache/kafka/pull/18050#issuecomment-2587254468 Thanks for @lianetm and @kirktrue review :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] KAFKA-18034: CommitRequestManager should fail pending requests on fatal coordinator errors [kafka]

2025-01-13 Thread via GitHub
lianetm merged PR #18050: URL: https://github.com/apache/kafka/pull/18050 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.

Re: [PR] KAFKA-18452: Implemented batch size in acquired records [kafka]

2025-01-13 Thread via GitHub
apoorvmittal10 commented on code in PR #18459: URL: https://github.com/apache/kafka/pull/18459#discussion_r1913284564 ## core/src/test/java/kafka/server/share/SharePartitionManagerTest.java: ## @@ -146,6 +146,7 @@ public class SharePartitionManagerTest { private static fina

Re: [PR] KAFKA-18452: Implemented batch size in acquired records [kafka]

2025-01-13 Thread via GitHub
apoorvmittal10 commented on code in PR #18459: URL: https://github.com/apache/kafka/pull/18459#discussion_r1913288932 ## core/src/test/java/kafka/server/share/SharePartitionTest.java: ## @@ -1104,6 +1116,109 @@ public void testAcquireWithEmptyFetchRecords() { assertEqua

Re: [PR] KAFKA-17973: Relax Restriction for Voters Set Change [kafka]

2025-01-13 Thread via GitHub
jsancio merged PR #17728: URL: https://github.com/apache/kafka/pull/17728 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.

[PR] [WIP] KAFKA-18302; Update CoordinatorRecord [kafka]

2025-01-13 Thread via GitHub
dajac opened a new pull request, #18512: URL: https://github.com/apache/kafka/pull/18512 WIP ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status - [ ] Verify documentation (including upgr

Re: [PR] KAFKA-18409: ShareGroupStateMessageFormatter should use ApiMessageFormatter [kafka]

2025-01-13 Thread via GitHub
m1a2st commented on code in PR #18510: URL: https://github.com/apache/kafka/pull/18510#discussion_r1913502873 ## tools/src/main/java/org/apache/kafka/tools/consumer/ApiMessageFormatter.java: ## @@ -38,7 +38,7 @@ public abstract class ApiMessageFormatter implements MessageFormat

[jira] [Created] (KAFKA-18494) Initialize gaps in share partition cachedState to new available batches during share partition initialization

2025-01-13 Thread Chirag Wadhwa (Jira)
Chirag Wadhwa created KAFKA-18494: - Summary: Initialize gaps in share partition cachedState to new available batches during share partition initialization Key: KAFKA-18494 URL: https://issues.apache.org/jira/brows

Re: [PR] KAFKA-18474: Remove zkBroker tag [kafka]

2025-01-13 Thread via GitHub
m1a2st commented on PR #18477: URL: https://github.com/apache/kafka/pull/18477#issuecomment-2587717544 Due to numerous test failures, We will address these failing tests in separate PRs to fix them. To keep PR manageable for review. -- This is an automated message from the Apache Git Serv

[jira] [Assigned] (KAFKA-18494) Initialize gaps in share partition cachedState to new available batches during share partition initialization

2025-01-13 Thread Chirag Wadhwa (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18494?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chirag Wadhwa reassigned KAFKA-18494: - Assignee: Chirag Wadhwa > Initialize gaps in share partition cachedState to new availab

Re: [PR] KAFKA-18401: Transaction version 2 does not support commit transaction without records [kafka]

2025-01-13 Thread via GitHub
jolshan commented on code in PR #18448: URL: https://github.com/apache/kafka/pull/18448#discussion_r1913542578 ## core/src/test/scala/integration/kafka/coordinator/transaction/ProducerIntegrationTest.scala: ## @@ -0,0 +1,185 @@ +/** + * Licensed to the Apache Software Foundation

Re: [PR] KAFKA-18229: Move configs out of "kraft" directory [kafka]

2025-01-13 Thread via GitHub
ijuma commented on code in PR #18389: URL: https://github.com/apache/kafka/pull/18389#discussion_r1913631544 ## bin/kafka-server-start.sh: ## @@ -19,6 +19,14 @@ then echo "USAGE: $0 [-daemon] server.properties [--override property=value]*" exit 1 fi + +for arg

Re: [PR] KAFKA-18298;KAFKA-18297: Fix flaky testConsumerGroupsDeprecatedConsumerGroupState and testConsumerGroups in PlaintextAdminIntegrationTest [kafka]

2025-01-13 Thread via GitHub
chenyulin0719 commented on code in PR #18513: URL: https://github.com/apache/kafka/pull/18513#discussion_r1913636428 ## core/src/test/scala/integration/kafka/api/PlaintextAdminIntegrationTest.scala: ## @@ -1883,6 +1886,9 @@ class PlaintextAdminIntegrationTest extends BaseAdminI

Re: [PR] KAFKA-16339: [Docs] Add migrating from transform to process [kafka]

2025-01-13 Thread via GitHub
mjsax commented on code in PR #18314: URL: https://github.com/apache/kafka/pull/18314#discussion_r1913737465 ## docs/streams/developer-guide/dsl-api.html: ## @@ -64,7 +64,7 @@ -Applying pro

[jira] [Commented] (KAFKA-17962) Upgrade Connect distributed system tests to handle CONSUMER group protocol

2025-01-13 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17912657#comment-17912657 ] Kirk True commented on KAFKA-17962: --- [~chia7712]—Are we considering this a blocker for

Re: [PR] KAFKA-17503: Fix incorrect calculation of poll-idle-ratio-avg for con… [kafka]

2025-01-13 Thread via GitHub
ahuang98 commented on code in PR #17139: URL: https://github.com/apache/kafka/pull/17139#discussion_r1913882149 ## clients/src/test/java/org/apache/kafka/clients/consumer/KafkaConsumerTest.java: ## @@ -3098,31 +3098,53 @@ public void testPollIdleRatio(GroupProtocol groupProtoco

Re: [PR] KAFKA-17503: Fix incorrect calculation of poll-idle-ratio-avg for con… [kafka]

2025-01-13 Thread via GitHub
ahuang98 commented on code in PR #17139: URL: https://github.com/apache/kafka/pull/17139#discussion_r1913886861 ## clients/src/test/java/org/apache/kafka/clients/consumer/KafkaConsumerTest.java: ## @@ -3098,31 +3098,53 @@ public void testPollIdleRatio(GroupProtocol groupProtoco

[jira] [Updated] (KAFKA-18495) Remove Invalid 'numberOfOpenFiles' Metric from RocksDB State Store

2025-01-13 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18495?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax updated KAFKA-18495: Labels: kip (was: ) > Remove Invalid 'numberOfOpenFiles' Metric from RocksDB State Store

Re: [PR] KAFKA-18484; Improve exception handling during coordinator unload [kafka]

2025-01-13 Thread via GitHub
squah-confluent commented on code in PR #18499: URL: https://github.com/apache/kafka/pull/18499#discussion_r1913903199 ## coordinator-common/src/test/java/org/apache/kafka/coordinator/common/runtime/CoordinatorRuntimeTest.java: ## @@ -3080,6 +3137,89 @@ public void testHighWater

Re: [PR] KAFKA-17503: Fix incorrect calculation of poll-idle-ratio-avg for con… [kafka]

2025-01-13 Thread via GitHub
ahuang98 commented on PR #17139: URL: https://github.com/apache/kafka/pull/17139#issuecomment-2588443175 > - Since the calls to measure determine when TimeRatio resets the interval it's tracking, that means poll intervals can intersect with the measurement interval boundary, which means Tim

Re: [PR] KAFKA-17503: Fix incorrect calculation of poll-idle-ratio-avg for con… [kafka]

2025-01-13 Thread via GitHub
ahuang98 commented on PR #17139: URL: https://github.com/apache/kafka/pull/17139#issuecomment-2588464833 > - It's trying to give a more accurate metric by not collapsing each poll interval into a percentage. Instead, it determines the measurement interval by resetting when measure is called

Re: [PR] KAFKA-17641, KAFKA-17642: PreVote [kafka]

2025-01-13 Thread via GitHub
ahuang98 closed pull request #18041: KAFKA-17641, KAFKA-17642: PreVote URL: https://github.com/apache/kafka/pull/18041 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubs

Re: [PR] KAFKA-17641, KAFKA-17642: PreVote [kafka]

2025-01-13 Thread via GitHub
ahuang98 commented on PR #18041: URL: https://github.com/apache/kafka/pull/18041#issuecomment-2588467861 replaced by https://github.com/apache/kafka/pull/18240 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

Re: [PR] KAFKA-18469;KAFKA-18036: AsyncConsumer should request metadata update if ListOffsetRequest encounters a retriable error [kafka]

2025-01-13 Thread via GitHub
lianetm merged PR #18475: URL: https://github.com/apache/kafka/pull/18475 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.

Re: [PR] KAFKA-18229: Move configs out of "kraft" directory [kafka]

2025-01-13 Thread via GitHub
ijuma commented on code in PR #18389: URL: https://github.com/apache/kafka/pull/18389#discussion_r1913603814 ## bin/kafka-storage.sh: ## @@ -14,4 +14,12 @@ # See the License for the specific language governing permissions and # limitations under the License. +for i in $(seq

Re: [PR] KAFKA-18229: Move configs out of "kraft" directory [kafka]

2025-01-13 Thread via GitHub
ijuma commented on code in PR #18389: URL: https://github.com/apache/kafka/pull/18389#discussion_r1913603814 ## bin/kafka-storage.sh: ## @@ -14,4 +14,12 @@ # See the License for the specific language governing permissions and # limitations under the License. +for i in $(seq

[jira] [Resolved] (KAFKA-18469) AsyncConsumer fails to retry ListOffsetRequest on ReplicaNotAvailable error without metadata update

2025-01-13 Thread Lianet Magrans (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18469?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lianet Magrans resolved KAFKA-18469. Resolution: Fixed > AsyncConsumer fails to retry ListOffsetRequest on ReplicaNotAvailable

  1   2   3   4   >