peterxcli commented on code in PR #18296:
URL: https://github.com/apache/kafka/pull/18296#discussion_r1898777862
##
clients/src/test/java/org/apache/kafka/test/TestUtils.java:
##
@@ -583,19 +583,6 @@ public static void
assertFutureThrows(
assertEquals(expectedMessage,
peterxcli commented on code in PR #18296:
URL: https://github.com/apache/kafka/pull/18296#discussion_r1898777862
##
clients/src/test/java/org/apache/kafka/test/TestUtils.java:
##
@@ -583,19 +583,6 @@ public static void
assertFutureThrows(
assertEquals(expectedMessage,
github-actions[bot] commented on PR #9117:
URL: https://github.com/apache/kafka/pull/9117#issuecomment-2564157322
This PR has been closed since it has not had any activity in 120 days. If
you feel like this
was a mistake, or you would like to continue working on it, please feel free
to r
github-actions[bot] commented on PR #9118:
URL: https://github.com/apache/kafka/pull/9118#issuecomment-2564157324
This PR has been closed since it has not had any activity in 120 days. If
you feel like this
was a mistake, or you would like to continue working on it, please feel free
to r
github-actions[bot] commented on PR #18283:
URL: https://github.com/apache/kafka/pull/18283#issuecomment-2564157319
A label of 'needs-attention' was automatically added to this PR in order to
raise the
attention of the committers. Once this issue has been triaged, the `triage`
label
s
github-actions[bot] closed pull request #9118: MINOR: Restore 2.5.0 upgrade
instructions that were added to kafka-site rather than kafka repo
URL: https://github.com/apache/kafka/pull/9118
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
github-actions[bot] commented on PR #9119:
URL: https://github.com/apache/kafka/pull/9119#issuecomment-2564157328
This PR has been closed since it has not had any activity in 120 days. If
you feel like this
was a mistake, or you would like to continue working on it, please feel free
to r
github-actions[bot] commented on PR #9154:
URL: https://github.com/apache/kafka/pull/9154#issuecomment-2564157345
This PR has been closed since it has not had any activity in 120 days. If
you feel like this
was a mistake, or you would like to continue working on it, please feel free
to r
github-actions[bot] commented on PR #9147:
URL: https://github.com/apache/kafka/pull/9147#issuecomment-2564157339
This PR has been closed since it has not had any activity in 120 days. If
you feel like this
was a mistake, or you would like to continue working on it, please feel free
to r
github-actions[bot] closed pull request #9119: MINOR: Add 2.7.0 upgrade
instructions that are needed for every release
URL: https://github.com/apache/kafka/pull/9119
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
github-actions[bot] closed pull request #9117: MINOR: Add 2.6.0 upgrade
instructions that were added to kafka-site first rather than to the kafka repo
URL: https://github.com/apache/kafka/pull/9117
--
This is an automated message from the Apache Git Service.
To respond to the message, please
github-actions[bot] closed pull request #9147: MINOR: supervise
TransactionalMessageCopier producer
URL: https://github.com/apache/kafka/pull/9147
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
github-actions[bot] closed pull request #9154: MINOR KAFKA-10382 - MockProducer
is not ThreadSafe, ideally it should be as the implementation it mocks is
URL: https://github.com/apache/kafka/pull/9154
--
This is an automated message from the Apache Git Service.
To respond to the message, plea
AndrewJSchofield commented on code in PR #18101:
URL: https://github.com/apache/kafka/pull/18101#discussion_r1898455328
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractHeartbeatRequestManager.java:
##
@@ -461,15 +434,24 @@ protected void handleFatalF
omkreddy commented on code in PR #18295:
URL: https://github.com/apache/kafka/pull/18295#discussion_r1898425642
##
clients/src/main/java/org/apache/kafka/common/security/authenticator/SaslServerAuthenticator.java:
##
@@ -503,63 +499,51 @@ private void handleSaslToken(byte[] clie
TaiJuWu commented on PR #18247:
URL: https://github.com/apache/kafka/pull/18247#issuecomment-2563814584
> @TaiJuWu have you fixed another failure?
Not yet. I am not sure this is a real issue or it needs to be improved by
production code.
In this PR, can we address this migration is
ijuma commented on code in PR #18295:
URL: https://github.com/apache/kafka/pull/18295#discussion_r1898594732
##
clients/src/main/java/org/apache/kafka/common/security/authenticator/SaslServerAuthenticator.java:
##
@@ -503,63 +499,51 @@ private void handleSaslToken(byte[] clientT
TaiJuWu opened a new pull request, #18329:
URL: https://github.com/apache/kafka/pull/18329
JIRA: https://issues.apache.org/jira/browse/KAFKA-18353
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI buil
mingdaoy commented on PR #18331:
URL: https://github.com/apache/kafka/pull/18331#issuecomment-2563779503
Hi maintainers, could you please review and approve this workflow when you
have a chance? Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message
chia7712 commented on PR #18247:
URL: https://github.com/apache/kafka/pull/18247#issuecomment-2563778493
@TaiJuWu have you fixed another failure?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to t
mingdaoy opened a new pull request, #18331:
URL: https://github.com/apache/kafka/pull/18331
[https://github.com/apache/kafka/blob/e6d242113625f20108b64bf54e796fcbcff6d8a7/clie[…]va/org/apache/kafka/clients/producer/RoundRobinPartitioner.java](https://github.com/apache/kafka/blob/e6d242113625
ijuma commented on PR #18295:
URL: https://github.com/apache/kafka/pull/18295#issuecomment-2563932378
@rajinisivaram I'll go ahead and merge this so client developers can test
their clients with all KIP-896 changes. Please take a look when you have a
chance and I'm happy to submit a follow
ijuma merged PR #18295:
URL: https://github.com/apache/kafka/pull/18295
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or
chia7712 commented on code in PR #17373:
URL: https://github.com/apache/kafka/pull/17373#discussion_r1898534270
##
build.gradle:
##
@@ -1099,15 +1103,17 @@ project(':core') {
implementation libs.dropwizardMetrics
exclude module: 'slf4j-log4j12'
exclude modul
TaiJuWu commented on PR #18247:
URL: https://github.com/apache/kafka/pull/18247#issuecomment-2563834441
> @TaiJuWu have you fixed another failure?
Hi @chia7712 , thanks for review.
Here is some update for this failure.
This case also fail in 3.9 on my environment and it
ijuma opened a new pull request, #18333:
URL: https://github.com/apache/kafka/pull/18333
This makes it possible to enable request logs for deprecated protocol api
versions without enabling it for the rest. Combined with the ability to
enable/disable dynamically, it makes it a bit easier to
ijuma commented on PR #18333:
URL: https://github.com/apache/kafka/pull/18333#issuecomment-2563850750
@chia7712 Since you reviewed the original PR, perhaps you can review this
cherry-pick. I'll also backport it to older branches in case we end up
releasing new patch releases for those. I wo
chia7712 merged PR #18282:
URL: https://github.com/apache/kafka/pull/18282
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
[
https://issues.apache.org/jira/browse/KAFKA-18278?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai resolved KAFKA-18278.
Resolution: Fixed
> the name and description of `run-gradle` is incorrect
> --
[
https://issues.apache.org/jira/browse/KAFKA-18278?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai updated KAFKA-18278:
---
Fix Version/s: 4.1.0
> the name and description of `run-gradle` is incorrect
> -
ppkarwasz commented on code in PR #17373:
URL: https://github.com/apache/kafka/pull/17373#discussion_r1898478552
##
build.gradle:
##
@@ -1099,15 +1103,17 @@ project(':core') {
implementation libs.dropwizardMetrics
exclude module: 'slf4j-log4j12'
exclude modu
chia7712 commented on PR #12462:
URL: https://github.com/apache/kafka/pull/12462#issuecomment-2563753475
onNewBatch is removed from 4.0 so I'm going to close this comment
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
omkreddy commented on code in PR #18295:
URL: https://github.com/apache/kafka/pull/18295#discussion_r1898425642
##
clients/src/main/java/org/apache/kafka/common/security/authenticator/SaslServerAuthenticator.java:
##
@@ -503,63 +499,51 @@ private void handleSaslToken(byte[] clie
AndrewJSchofield commented on code in PR #18232:
URL: https://github.com/apache/kafka/pull/18232#discussion_r1898435818
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/FetchMetricsManager.java:
##
@@ -24,15 +24,18 @@
import org.apache.kafka.common.metrics.s
[
https://issues.apache.org/jira/browse/KAFKA-18295?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai resolved KAFKA-18295.
Resolution: Fixed
trunk:https://github.com/apache/kafka/commit/e6d242113625f20108b64bf54e7
FrankYang0529 opened a new pull request, #18330:
URL: https://github.com/apache/kafka/pull/18330
We disabled `SaslApiVersionsRequestTest` when implementing KAFKA-17614.
Re-enable with a new test framework.
This PR is based on https://github.com/apache/kafka/pull/17671, so we can
just
michaldo opened a new pull request, #18335:
URL: https://github.com/apache/kafka/pull/18335
Fix Javadoc - previously method signature was wrong
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build s
santhoshct opened a new pull request, #18334:
URL: https://github.com/apache/kafka/pull/18334
Added script to find the commit that would have caused the flakiness.
### Flaky Pattern Detection:
For each test execution in chronological order:
- When a FAILED or FLAKY status
[
https://issues.apache.org/jira/browse/KAFKA-18238?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17908493#comment-17908493
]
Santhosh C T commented on KAFKA-18238:
--
I wrote the script to identify the commits
chia7712 commented on PR #11326:
URL: https://github.com/apache/kafka/pull/11326#issuecomment-2563754380
onNewBatch is removed from 4.0 so I'm going to close this PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
chia7712 closed pull request #11326: KAFKA-9965/KAFKA-13303:
RoundRobinPartitioner broken by KIP-480
URL: https://github.com/apache/kafka/pull/11326
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to t
[
https://issues.apache.org/jira/browse/KAFKA-9965?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai resolved KAFKA-9965.
---
Resolution: Won't Fix
onNewBatch is removed from 4.0 so I'm going to close this jira
> Uneve
chia7712 closed pull request #12462: [KAFKA-9965] Fix accumulator tryAppend, so
that fresh new producerBatch is created
URL: https://github.com/apache/kafka/pull/12462
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
U
[
https://issues.apache.org/jira/browse/KAFKA-18337?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
MaoWei Tian updated KAFKA-18337:
Summary: KafkaProducer Memory Leak in JmxReporter Class (was:
KafkaProducer Memory Leak in JMX R
tmw090906 opened a new pull request, #18332:
URL: https://github.com/apache/kafka/pull/18332
Add a close status in JmxReporter, that avoid re-registering metrics to jmx
after being closed, which could lead to memory leaks
relate [KAFKA-18337](https://issues.apache.org/jira/browse/KAFK
ijuma merged PR #18313:
URL: https://github.com/apache/kafka/pull/18313
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or
ppkarwasz commented on code in PR #17373:
URL: https://github.com/apache/kafka/pull/17373#discussion_r1898356316
##
build.gradle:
##
@@ -1099,15 +1103,17 @@ project(':core') {
implementation libs.dropwizardMetrics
exclude module: 'slf4j-log4j12'
exclude modu
ppkarwasz commented on code in PR #17373:
URL: https://github.com/apache/kafka/pull/17373#discussion_r1898357031
##
build.gradle:
##
@@ -1099,15 +1103,17 @@ project(':core') {
implementation libs.dropwizardMetrics
exclude module: 'slf4j-log4j12'
exclude modu
chia7712 commented on code in PR #17373:
URL: https://github.com/apache/kafka/pull/17373#discussion_r1898365578
##
build.gradle:
##
@@ -1099,15 +1103,17 @@ project(':core') {
implementation libs.dropwizardMetrics
exclude module: 'slf4j-log4j12'
exclude modul
tmw090906 opened a new pull request, #18328:
URL: https://github.com/apache/kafka/pull/18328
…ering after being closed, which could lead to memory leaks
*More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use
tmw090906 closed pull request #18328: KAFKA-18337: Add a close status for
JmxReporter, that avoid re-regist…
URL: https://github.com/apache/kafka/pull/18328
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
peterxcli opened a new pull request, #18337:
URL: https://github.com/apache/kafka/pull/18337
Enable controller to restart with the same port in ClusterTest.
## Tests
In the newly added test `testKRaftIsolatedControllerRestart`, if we don't
have the corresponding changes in `Pre
m1a2st commented on code in PR #18299:
URL: https://github.com/apache/kafka/pull/18299#discussion_r1898843091
##
.github/workflows/build.yml:
##
@@ -114,6 +114,7 @@ jobs:
# --no-scan: For public fork PRs, we won't attempt to publish the
scan
run: |
[
https://issues.apache.org/jira/browse/KAFKA-18354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17908565#comment-17908565
]
黃竣陽 commented on KAFKA-18354:
-
Hello, [~chia7712] , if you wont work on this, may I take the
Chia-Ping Tsai created KAFKA-18354:
--
Summary: Use log4j2 APIs to refactor LogCaptureAppender
Key: KAFKA-18354
URL: https://issues.apache.org/jira/browse/KAFKA-18354
Project: Kafka
Issue Type
[
https://issues.apache.org/jira/browse/KAFKA-18354?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai reassigned KAFKA-18354:
--
Assignee: 黃竣陽 (was: Chia-Ping Tsai)
> Use log4j2 APIs to refactor LogCaptureAppender
mjsax opened a new pull request, #18336:
URL: https://github.com/apache/kafka/pull/18336
The consumer/producer JavaDocs still contain instruction for naively
computing the offset to be committed.
This PR updates the JavaDocs with regard to the improvements of KIP-1094.
--
This is an au
chia7712 commented on code in PR #18185:
URL: https://github.com/apache/kafka/pull/18185#discussion_r1898188108
##
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/Loggers.java:
##
@@ -127,14 +127,23 @@ public synchronized Map allLevels() {
public synchronized
58 matches
Mail list logo
