[jira] [Created] (KAFKA-18185) Remove internal.leave.group.on.close flag

2024-12-07 Thread TengYao Chi (Jira)
TengYao Chi created KAFKA-18185: --- Summary: Remove internal.leave.group.on.close flag Key: KAFKA-18185 URL: https://issues.apache.org/jira/browse/KAFKA-18185 Project: Kafka Issue Type: Improveme

Re: [PR] KAFKA-16143: New JMX metrics for AsyncKafkaConsumer [kafka]

2024-12-07 Thread via GitHub
FrankYang0529 commented on code in PR #17199: URL: https://github.com/apache/kafka/pull/17199#discussion_r1874604929 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java: ## @@ -1893,25 +1901,30 @@ private void subscribeInternal(Collection

[jira] [Commented] (KAFKA-18183) ClusterInstance's helper should use byte array instead of Bytes in creating producer/consumer

2024-12-07 Thread Suresh Kumar (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18183?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17903851#comment-17903851 ] Suresh Kumar commented on KAFKA-18183: -- @logan zhu I would like to work on the tick

[jira] [Resolved] (KAFKA-18128) Fix failed test MetadataSchemaCheckerToolTest.testVerifyEvolutionGit in PR

2024-12-07 Thread TengYao Chi (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18128?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] TengYao Chi resolved KAFKA-18128. - Resolution: Fixed > Fix failed test MetadataSchemaCheckerToolTest.testVerifyEvolutionGit in PR >

[jira] [Commented] (KAFKA-18055) Remove TopologyConfig and clean up Topology/StreamsBuilder config APIs

2024-12-07 Thread TengYao Chi (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17903853#comment-17903853 ] TengYao Chi commented on KAFKA-18055: - Hi [~ableegoldman]  May I take over this iss

[jira] [Comment Edited] (KAFKA-18021) Disabled MirrorCheckpointConnector throws RetriableException on task config generation

2024-12-07 Thread TengYao Chi (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18021?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17898437#comment-17898437 ] TengYao Chi edited comment on KAFKA-18021 at 12/8/24 7:00 AM:

[jira] [Assigned] (KAFKA-18021) Disabled MirrorCheckpointConnector throws RetriableException on task config generation

2024-12-07 Thread TengYao Chi (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18021?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] TengYao Chi reassigned KAFKA-18021: --- Assignee: TengYao Chi > Disabled MirrorCheckpointConnector throws RetriableException on tas

[PR] KAFKA-18166: Indefinite timeout when publishing events to RLMM (RemoteLogMetadataManager) [kafka]

2024-12-07 Thread via GitHub
FrankYang0529 opened a new pull request, #18097: URL: https://github.com/apache/kafka/pull/18097 To prevent RLMM hang on `CompletableFuture.get()`, add a reasonable timeout on these functions. ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementa

Re: [PR] KAFKA-18118: Fix the incorrect soft link of results/latest [kafka]

2024-12-07 Thread via GitHub
chia7712 merged PR #17992: URL: https://github.com/apache/kafka/pull/17992 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

Re: [PR] MINOR: Perf improvement in share state batch combiner. [kafka]

2024-12-07 Thread via GitHub
AndrewJSchofield merged PR #18090: URL: https://github.com/apache/kafka/pull/18090 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafk

[jira] [Resolved] (KAFKA-17548) Improve admin client integration tests

2024-12-07 Thread Andrew Schofield (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17548?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Schofield resolved KAFKA-17548. -- Resolution: Fixed > Improve admin client integration tests > -

Re: [PR] KAFKA-17548: Improve group listing integration test [kafka]

2024-12-07 Thread via GitHub
AndrewJSchofield merged PR #18081: URL: https://github.com/apache/kafka/pull/18081 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafk

Re: [PR] KAFKA-17864: add descriptions to fields in the agreement [kafka]

2024-12-07 Thread via GitHub
AndrewJSchofield merged PR #17681: URL: https://github.com/apache/kafka/pull/17681 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafk

[jira] [Resolved] (KAFKA-17864) Ensure all fields in the protocol have a description

2024-12-07 Thread Andrew Schofield (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17864?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Schofield resolved KAFKA-17864. -- Fix Version/s: 4.0.0 Resolution: Fixed > Ensure all fields in the protocol have

Re: [PR] MINOR: Clean leaking resource in ShareConsumerTest [kafka]

2024-12-07 Thread via GitHub
frankvicky commented on PR #18073: URL: https://github.com/apache/kafka/pull/18073#issuecomment-2525191426 Hi @chia7712 https://github.com/apache/kafka/blob/9f27d997c3ef2f353e2fea3735006b1c1b677cac/core/src/test/java/kafka/test/api/ShareConsumerTest.java#L1258 Before #18053 , this

Re: [PR] KAFKA-18014: Add duration based offset reset option for ShareConsumer [kafka]

2024-12-07 Thread via GitHub
peterxcli commented on PR #18040: URL: https://github.com/apache/kafka/pull/18040#issuecomment-252526 reopen -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscr

[jira] [Resolved] (KAFKA-18118) Fix the incorrect soft link of results/latest

2024-12-07 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18118?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai resolved KAFKA-18118. Fix Version/s: 4.0.0 Resolution: Fixed > Fix the incorrect soft link of results/lat

[jira] [Created] (KAFKA-18183) ClusterInstance's helper should use byte array instead of Bytes in creating producer/consumer

2024-12-07 Thread Chia-Ping Tsai (Jira)
Chia-Ping Tsai created KAFKA-18183: -- Summary: ClusterInstance's helper should use byte array instead of Bytes in creating producer/consumer Key: KAFKA-18183 URL: https://issues.apache.org/jira/browse/KAFKA-18183

[jira] [Assigned] (KAFKA-18183) ClusterInstance's helper should use byte array instead of Bytes in creating producer/consumer

2024-12-07 Thread Logan Zhu (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18183?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Logan Zhu reassigned KAFKA-18183: - Assignee: Logan Zhu > ClusterInstance's helper should use byte array instead of Bytes in creati

[jira] [Created] (KAFKA-18184) Remove the unnecessary project path check from build.gradle

2024-12-07 Thread Chia-Ping Tsai (Jira)
Chia-Ping Tsai created KAFKA-18184: -- Summary: Remove the unnecessary project path check from build.gradle Key: KAFKA-18184 URL: https://issues.apache.org/jira/browse/KAFKA-18184 Project: Kafka

[jira] [Assigned] (KAFKA-18184) Remove the unnecessary project path check from build.gradle

2024-12-07 Thread Nick Guo (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18184?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nick Guo reassigned KAFKA-18184: Assignee: Nick Guo > Remove the unnecessary project path check from build.gradle > --

Re: [PR] KAFKA-18160: Interrupting or waking up onPartitionsAssigned in AsyncConsumer can cause the ConsumerRebalanceListenerCallbackCompletedEvent to be skipped [kafka]

2024-12-07 Thread via GitHub
chia7712 commented on PR #18089: URL: https://github.com/apache/kafka/pull/18089#issuecomment-2525265697 @brandboat there is another inconsistent behavior between classic consumer and async consumer. see following test: ```java @ClusterTest(brokers = 3) public void testFetch

Re: [PR] KAFKA-18129: Simplifying share partition maybeInitialize code [kafka]

2024-12-07 Thread via GitHub
apoorvmittal10 commented on code in PR #18093: URL: https://github.com/apache/kafka/pull/18093#discussion_r1874537000 ## core/src/main/java/kafka/server/share/SharePartition.java: ## @@ -371,52 +370,35 @@ public static RecordState forId(byte id) { */ public Completabl

[jira] [Assigned] (KAFKA-18173) Remove duplicate assertFutureError

2024-12-07 Thread Peter Lee (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18173?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Lee reassigned KAFKA-18173: - Assignee: Peter Lee (was: Chia-Ping Tsai) > Remove duplicate assertFutureError > -

Re: [PR] KAFKA-14619: KRaft validate snapshot id are at batch boundries [kafka]

2024-12-07 Thread via GitHub
jsancio commented on code in PR #17500: URL: https://github.com/apache/kafka/pull/17500#discussion_r1873873925 ## core/src/test/scala/kafka/raft/KafkaMetadataLogTest.scala: ## @@ -206,7 +217,7 @@ final class KafkaMetadataLogTest { val snapshotId = new OffsetAndEpoch(numberO

[PR] KAFKA-15599: Move SegmentPosition/TimingWheelExpirationService to raf… [kafka]

2024-12-07 Thread via GitHub
mimaison opened a new pull request, #18094: URL: https://github.com/apache/kafka/pull/18094 …t module ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status - [ ] Verify documentation (i

Re: [PR] KAFKA-17548: Improve group listing integration test [kafka]

2024-12-07 Thread via GitHub
AndrewJSchofield commented on code in PR #18081: URL: https://github.com/apache/kafka/pull/18081#discussion_r1874495627 ## core/src/test/scala/integration/kafka/api/PlaintextAdminIntegrationTest.scala: ## @@ -2147,15 +2147,17 @@ class PlaintextAdminIntegrationTest extends BaseA

Re: [PR] KAFKA-18144: Move the storage exceptions out of the core module [kafka]

2024-12-07 Thread via GitHub
chia7712 merged PR #18021: URL: https://github.com/apache/kafka/pull/18021 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

Re: [PR] KAFKA-18129: Simplifying share partition maybeInitialize code [kafka]

2024-12-07 Thread via GitHub
adixitconfluent commented on code in PR #18093: URL: https://github.com/apache/kafka/pull/18093#discussion_r1874487856 ## core/src/main/java/kafka/server/share/SharePartition.java: ## @@ -371,52 +370,35 @@ public static RecordState forId(byte id) { */ public Completab

[jira] [Commented] (KAFKA-18180) Move OffsetResultHolder to storage module

2024-12-07 Thread Peter Lee (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17903817#comment-17903817 ] Peter Lee commented on KAFKA-18180: --- Hi [~mimaison], if you are not working on this, m

Re: [PR] KAFKA-18074: Add kafka client compatibility matrix [kafka]

2024-12-07 Thread via GitHub
divijvaidya commented on code in PR #18091: URL: https://github.com/apache/kafka/pull/18091#discussion_r1874555000 ## docs/compatibility.html: ## @@ -0,0 +1,200 @@ + + + + + + + + + +With the release of Kafka 4.0, significant

Re: [PR] KAFKA-13303, KAFKA-9965: Enhancments for Roun Robing Partitioner and fix of uneven distribution [kafka]

2024-12-07 Thread via GitHub
Serwios commented on PR #17977: URL: https://github.com/apache/kafka/pull/17977#issuecomment-2525293780 Hi, request for review @lucasbru @cadonna Let me know what do you think. It's based on fast fix with decremantation but RR class in general is improved -- This is an automa

Re: [PR] [WIP] KIP-891: Connect Multiversion Support (Base PR with Plugin Loading Isolation Changes) [kafka]

2024-12-07 Thread via GitHub
snehashisp commented on PR #16984: URL: https://github.com/apache/kafka/pull/16984#issuecomment-2525200407 > Please work on getting this to compile and tests to pass. A couple of minor adjustments were needed, otherwise the runtime tests have all passed locally. Hoping that it will go

[jira] [Created] (KAFKA-18181) Refactor ShareConsumerTest

2024-12-07 Thread Chia-Ping Tsai (Jira)
Chia-Ping Tsai created KAFKA-18181: -- Summary: Refactor ShareConsumerTest Key: KAFKA-18181 URL: https://issues.apache.org/jira/browse/KAFKA-18181 Project: Kafka Issue Type: Improvement

Re: [PR] KAFKA-18156: VerifiableConsumer should ignore "--session-timeout" when using CONSUMER protocol [kafka]

2024-12-07 Thread via GitHub
chia7712 commented on code in PR #18036: URL: https://github.com/apache/kafka/pull/18036#discussion_r1874533537 ## tools/src/main/java/org/apache/kafka/tools/VerifiableConsumer.java: ## @@ -649,8 +648,12 @@ public static VerifiableConsumer createFromArgs(ArgumentParser parser,

Re: [PR] MINOR: Fix README for running a Kafka broker [kafka]

2024-12-07 Thread via GitHub
chia7712 merged PR #18030: URL: https://github.com/apache/kafka/pull/18030 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

Re: [PR] KAFKA-18014: Add duration based offset reset option for ShareConsumer [kafka]

2024-12-07 Thread via GitHub
peterxcli closed pull request #18040: KAFKA-18014: Add duration based offset reset option for ShareConsumer URL: https://github.com/apache/kafka/pull/18040 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] KAFKA-18129: Simplifying share partition maybeInitialize code [kafka]

2024-12-07 Thread via GitHub
apoorvmittal10 commented on code in PR #18093: URL: https://github.com/apache/kafka/pull/18093#discussion_r1874507257 ## core/src/main/java/kafka/server/share/SharePartition.java: ## @@ -1178,32 +1160,20 @@ private boolean stateNotActive() { return partitionState() !=

Re: [PR] KAFKA-18129: Simplifying share partition maybeInitialize code [kafka]

2024-12-07 Thread via GitHub
apoorvmittal10 commented on code in PR #18093: URL: https://github.com/apache/kafka/pull/18093#discussion_r1874535081 ## core/src/main/java/kafka/server/share/SharePartition.java: ## @@ -371,52 +370,35 @@ public static RecordState forId(byte id) { */ public Completabl

Re: [PR] KAFKA-18129: Simplifying share partition maybeInitialize code [kafka]

2024-12-07 Thread via GitHub
apoorvmittal10 commented on code in PR #18093: URL: https://github.com/apache/kafka/pull/18093#discussion_r1874535255 ## core/src/main/java/kafka/server/share/SharePartition.java: ## @@ -1178,32 +1160,20 @@ private boolean stateNotActive() { return partitionState() !=

[jira] [Created] (KAFKA-18182) Add VersionRange to Plugins and DelegatingClassLoader APIs

2024-12-07 Thread Greg Harris (Jira)
Greg Harris created KAFKA-18182: --- Summary: Add VersionRange to Plugins and DelegatingClassLoader APIs Key: KAFKA-18182 URL: https://issues.apache.org/jira/browse/KAFKA-18182 Project: Kafka Issu

Re: [PR] KAFKA-17548: Improve group listing integration test [kafka]

2024-12-07 Thread via GitHub
apoorvmittal10 commented on code in PR #18081: URL: https://github.com/apache/kafka/pull/18081#discussion_r1874516370 ## core/src/test/scala/integration/kafka/api/PlaintextAdminIntegrationTest.scala: ## @@ -2147,15 +2147,17 @@ class PlaintextAdminIntegrationTest extends BaseAdm

[PR] KAFKA-18014: Add duration based offset reset option for ShareConsumer [kafka]

2024-12-07 Thread via GitHub
peterxcli opened a new pull request, #18096: URL: https://github.com/apache/kafka/pull/18096 Kafka consumer supports auto.offset.reset config option, which is used when there is no initial offset in Kafka (or) if the current offset does not exist any more on the server. This config currentl

[jira] [Resolved] (KAFKA-18182) Add VersionRange to Plugins and DelegatingClassLoader APIs

2024-12-07 Thread Greg Harris (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18182?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Greg Harris resolved KAFKA-18182. - Fix Version/s: 4.0.0 Resolution: Fixed > Add VersionRange to Plugins and DelegatingClassL

Re: [PR] KAFKA-18014: Add duration based offset reset option for ShareConsumer [kafka]

2024-12-07 Thread via GitHub
peterxcli commented on PR #18040: URL: https://github.com/apache/kafka/pull/18040#issuecomment-2525251674 I'm sorry, closed it accidentally, will open a new PR after resolving the conflict in SharePartiton -- This is an automated message from the Apache Git Service. To respond to the mess

Re: [PR] KAFKA-18182: KIP-891 Connect Multiversion Support (Base PR with Plugin Loading Isolation Changes) [kafka]

2024-12-07 Thread via GitHub
gharris1727 merged PR #16984: URL: https://github.com/apache/kafka/pull/16984 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apa

Re: [PR] KAFKA-18129: Simplifying share partition maybeInitialize code [kafka]

2024-12-07 Thread via GitHub
apoorvmittal10 commented on code in PR #18093: URL: https://github.com/apache/kafka/pull/18093#discussion_r1874537000 ## core/src/main/java/kafka/server/share/SharePartition.java: ## @@ -371,52 +370,35 @@ public static RecordState forId(byte id) { */ public Completabl

[jira] (KAFKA-18173) Remove duplicate assertFutureError

2024-12-07 Thread Dmitry Werner (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18173 ] Dmitry Werner deleted comment on KAFKA-18173: --- was (Author: JIRAUSER300605): [~chia7712] can I take this? > Remove duplicate assertFutureError > -- > >

[jira] [Created] (KAFKA-18180) Move OffsetResultHolder to storage module

2024-12-07 Thread Mickael Maison (Jira)
Mickael Maison created KAFKA-18180: -- Summary: Move OffsetResultHolder to storage module Key: KAFKA-18180 URL: https://issues.apache.org/jira/browse/KAFKA-18180 Project: Kafka Issue Type: Sub

[jira] [Created] (KAFKA-18179) Move AsyncOffsetReadFutureHolder to storage module

2024-12-07 Thread Mickael Maison (Jira)
Mickael Maison created KAFKA-18179: -- Summary: Move AsyncOffsetReadFutureHolder to storage module Key: KAFKA-18179 URL: https://issues.apache.org/jira/browse/KAFKA-18179 Project: Kafka Issue

[jira] [Assigned] (KAFKA-18180) Move OffsetResultHolder to storage module

2024-12-07 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-18180?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] 黃竣陽 reassigned KAFKA-18180: --- Assignee: 黃竣陽 > Move OffsetResultHolder to storage module > - > >

[PR] KAFKA-18179: Move AsyncOffsetReadFutureHolder to storage module [kafka]

2024-12-07 Thread via GitHub
mimaison opened a new pull request, #18095: URL: https://github.com/apache/kafka/pull/18095 ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status - [ ] Verify documentation (including upgr

Re: [PR] KAFKA-18129: Simplifying share partition maybeInitialize code [kafka]

2024-12-07 Thread via GitHub
apoorvmittal10 commented on code in PR #18093: URL: https://github.com/apache/kafka/pull/18093#discussion_r1874507453 ## core/src/main/java/kafka/server/share/SharePartition.java: ## @@ -371,52 +370,35 @@ public static RecordState forId(byte id) { */ public Completabl

Re: [PR] MINOR: Clean leaking resource in ShareConsumerTest [kafka]

2024-12-07 Thread via GitHub
frankvicky commented on PR #18073: URL: https://github.com/apache/kafka/pull/18073#issuecomment-2525218139 To ensure that all resources are closed properly during this refactoring, adjustments to the helper method are necessary. The original logic for creating resources was encapsulated wit

[jira] [Resolved] (KAFKA-18144) Move storage exceptions out of core

2024-12-07 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18144?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai resolved KAFKA-18144. Fix Version/s: 4.0.0 Resolution: Fixed fixed by https://github.com/apache/kafka/pul

[jira] [Commented] (KAFKA-18180) Move OffsetResultHolder to storage module

2024-12-07 Thread Peter Lee (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17903816#comment-17903816 ] Peter Lee commented on KAFKA-18180: --- Hi [~mickael.magniez], If you are not working on

Re: [PR] MINOR: Clean leaking resource in ShareConsumerTest [kafka]

2024-12-07 Thread via GitHub
chia7712 commented on PR #18073: URL: https://github.com/apache/kafka/pull/18073#issuecomment-252517 @frankvicky Could you please point out where we might have forgotten to close the consumer or producer? -- This is an automated message from the Apache Git Service. To respond to the m

[jira] (KAFKA-18180) Move OffsetResultHolder to storage module

2024-12-07 Thread Peter Lee (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18180 ] Peter Lee deleted comment on KAFKA-18180: --- was (Author: JIRAUSER306303): Hi [~mickael.magniez], If you are not working on this, may I take this? Thanks! > Move OffsetResultHolder to storage m

Re: [PR] MINOR: Clean leaking resource in ShareConsumerTest [kafka]

2024-12-07 Thread via GitHub
chia7712 commented on PR #18073: URL: https://github.com/apache/kafka/pull/18073#issuecomment-2525192245 It appears that the issue is not only related to the consumer but also requires us to close the thread pool. Could you please refactor that test case to ensure all resources get closed?

Re: [PR] KAFKA-18129: Simplifying share partition maybeInitialize code [kafka]

2024-12-07 Thread via GitHub
apoorvmittal10 commented on code in PR #18093: URL: https://github.com/apache/kafka/pull/18093#discussion_r1874507257 ## core/src/main/java/kafka/server/share/SharePartition.java: ## @@ -1178,32 +1160,20 @@ private boolean stateNotActive() { return partitionState() !=

Re: [PR] KAFKA-18129: Simplifying share partition maybeInitialize code [kafka]

2024-12-07 Thread via GitHub
adixitconfluent commented on code in PR #18093: URL: https://github.com/apache/kafka/pull/18093#discussion_r1874532379 ## core/src/main/java/kafka/server/share/SharePartition.java: ## @@ -371,52 +370,35 @@ public static RecordState forId(byte id) { */ public Completab

Re: [PR] KAFKA-18129: Simplifying share partition maybeInitialize code [kafka]

2024-12-07 Thread via GitHub
adixitconfluent commented on code in PR #18093: URL: https://github.com/apache/kafka/pull/18093#discussion_r1874532507 ## core/src/main/java/kafka/server/share/SharePartition.java: ## @@ -1178,32 +1160,20 @@ private boolean stateNotActive() { return partitionState() !=

Re: [PR] KAFKA-18129: Simplifying share partition maybeInitialize code [kafka]

2024-12-07 Thread via GitHub
chia7712 commented on code in PR #18093: URL: https://github.com/apache/kafka/pull/18093#discussion_r1874548857 ## core/src/main/java/kafka/server/share/SharePartition.java: ## @@ -371,52 +370,35 @@ public static RecordState forId(byte id) { */ public CompletableFutur

Re: [PR] KAFKA-14470: Move the storage exceptions out of the core module [kafka]

2024-12-07 Thread via GitHub
mimaison commented on code in PR #18021: URL: https://github.com/apache/kafka/pull/18021#discussion_r1874392908 ## storage/src/main/java/org/apache/kafka/storage/internals/log/OffsetsOutOfOrderException.java: ## @@ -14,16 +14,14 @@ * See the License for the specific language g

[PR] KAFKA-18074: Add kafka client compatibility matrix [kafka]

2024-12-07 Thread via GitHub
m1a2st opened a new pull request, #18091: URL: https://github.com/apache/kafka/pull/18091 Jira: https://issues.apache.org/jira/browse/KAFKA-18074 we add new section for Kafka 4.0 compatibility metrics for user, so user can check server and client in this section. ### Committer

[PR] MINOR: Perf improvement in share state batch combiner. [kafka]

2024-12-07 Thread via GitHub
smjn opened a new pull request, #18090: URL: https://github.com/apache/kafka/pull/18090 * The state batch combiner algorithm prunes and merges state batches in the current state and incoming RPC requests. * During profiling a simple data structure change showed great promise. * This PR

Re: [PR] KAFKA-18174: Subsequent write event completions should be a noop [kafka]

2024-12-07 Thread via GitHub
dajac commented on code in PR #18083: URL: https://github.com/apache/kafka/pull/18083#discussion_r1874372172 ## coordinator-common/src/main/java/org/apache/kafka/coordinator/common/runtime/CoordinatorRuntime.java: ## @@ -1667,7 +1676,7 @@ public void complete(Throwable exception

Re: [PR] KAFKA-17796: Persist higher leaderEpoch in read state call. [kafka]

2024-12-07 Thread via GitHub
AndrewJSchofield merged PR #17580: URL: https://github.com/apache/kafka/pull/17580 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafk

[jira] [Resolved] (KAFKA-17796) Persist higher leaderEpoch in read state calls to the share coordinator.

2024-12-07 Thread Andrew Schofield (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17796?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Schofield resolved KAFKA-17796. -- Resolution: Fixed > Persist higher leaderEpoch in read state calls to the share coordi

[jira] [Commented] (KAFKA-16619) Unnecessary controller warning : "Loaded ZK migration state of NONE"

2024-12-07 Thread Ukpa Uchechi (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17903804#comment-17903804 ] Ukpa Uchechi commented on KAFKA-16619: -- [~davidarthur] Looks like a merge has been

[jira] [Updated] (KAFKA-17796) Persist higher leaderEpoch in read state calls to the share coordinator.

2024-12-07 Thread Andrew Schofield (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17796?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Schofield updated KAFKA-17796: - Fix Version/s: 4.0.0 > Persist higher leaderEpoch in read state calls to the share coord

Re: [PR] KAFKA-12829: Remove deprecated Topology#addProcessor of old Processor API [kafka]

2024-12-07 Thread via GitHub
pegasas commented on PR #17190: URL: https://github.com/apache/kafka/pull/17190#issuecomment-2525085771 > Your PR update does not seem to be right/complete? I am wondering if we have some communication gap and going somewhat in cycles? -- Would you mind if we close this PR and I work on a P

Re: [PR] KAFKA-12829: Remove deprecated Topology#addProcessor of old Processor API [kafka]

2024-12-07 Thread via GitHub
pegasas closed pull request #17190: KAFKA-12829: Remove deprecated Topology#addProcessor of old Processor API URL: https://github.com/apache/kafka/pull/17190 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

Re: [PR] KAFKA-18015: Add support for duration based offset reset strategy to Kafka Streams [kafka]

2024-12-07 Thread via GitHub
KApolinario1120 commented on code in PR #17973: URL: https://github.com/apache/kafka/pull/17973#discussion_r1874411414 ## streams/src/main/java/org/apache/kafka/streams/Topology.java: ## @@ -77,6 +77,166 @@ protected Topology(final InternalTopologyBuilder internalTopologyBuilde

Re: [PR] KAFKA-18015: Add support for duration based offset reset strategy to Kafka Streams [kafka]

2024-12-07 Thread via GitHub
KApolinario1120 commented on code in PR #17973: URL: https://github.com/apache/kafka/pull/17973#discussion_r1874411760 ## streams/src/main/java/org/apache/kafka/streams/kstream/Consumed.java: ## @@ -99,8 +99,8 @@ protected Consumed(final Consumed consumed) { public static

[jira] [Updated] (KAFKA-18178) Delete ZkSecurityMigrator

2024-12-07 Thread Mickael Maison (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18178?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mickael Maison updated KAFKA-18178: --- Description: Now that we deleted ZooKeeperMainWithTlsSupportForKafka in https://issues.apach

[jira] [Created] (KAFKA-18178) Delete ZkSecurityMigrator

2024-12-07 Thread Mickael Maison (Jira)
Mickael Maison created KAFKA-18178: -- Summary: Delete ZkSecurityMigrator Key: KAFKA-18178 URL: https://issues.apache.org/jira/browse/KAFKA-18178 Project: Kafka Issue Type: Sub-task

Re: [PR] KAFKA-18015: Add support for duration based offset reset strategy to Kafka Streams [kafka]

2024-12-07 Thread via GitHub
KApolinario1120 commented on PR #17973: URL: https://github.com/apache/kafka/pull/17973#issuecomment-2525122673 > Thanks for the PR. Made a pass. @mjsax I have pushed more changes based on the comments you made. I want to continue to work on this, however I do not work with Java in my

Re: [PR] KAFKA-17548: Improve group listing integration test [kafka]

2024-12-07 Thread via GitHub
apoorvmittal10 commented on code in PR #18081: URL: https://github.com/apache/kafka/pull/18081#discussion_r1874419762 ## core/src/test/scala/integration/kafka/api/PlaintextAdminIntegrationTest.scala: ## @@ -2147,15 +2147,17 @@ class PlaintextAdminIntegrationTest extends BaseAdm

[PR] KAFKA-18178: Remove ZkSecurityMigrator [kafka]

2024-12-07 Thread via GitHub
mimaison opened a new pull request, #18092: URL: https://github.com/apache/kafka/pull/18092 ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status - [ ] Verify documentation (including upgr

[PR] KAFKA-18129: Simplifying share partition maybeInitialize code [kafka]

2024-12-07 Thread via GitHub
apoorvmittal10 opened a new pull request, #18093: URL: https://github.com/apache/kafka/pull/18093 https://github.com/apache/kafka/pull/18053 added code to take future out of the write lock to stop triggerring other functions waiting on the future. This PR simplifies the code. ### Com