Re: [PR] KAFKA-17116: New consumer may not send effective leave group if member ID received after close [kafka]

2024-10-30 Thread via GitHub
frankvicky commented on code in PR #17549: URL: https://github.com/apache/kafka/pull/17549#discussion_r1822185721 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/GroupMetadataManagerTest.java: ## @@ -198,14 +209,14 @@ public void testConsumerHeartbeatReques

Re: [PR] MINOR: Update the upgrade docs to include 3.8.1 version [kafka]

2024-10-30 Thread via GitHub
jlprat merged PR #17628: URL: https://github.com/apache/kafka/pull/17628 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.o

Re: [PR] MINOR: Update the upgrade docs to include 3.8.1 version [kafka]

2024-10-30 Thread via GitHub
jlprat commented on PR #17628: URL: https://github.com/apache/kafka/pull/17628#issuecomment-2446527375 @cmccabe mind to include this in the `39` folder of the kafka-site repo before you wrap up the release. Also when you are ready with the 3.9.0 release we should port this to the `3.9` b

Re: [PR] KAFKA-17726: New consumer subscribe/subscribeFromPattern in background thread (WIP) [kafka]

2024-10-30 Thread via GitHub
FrankYang0529 commented on PR #17569: URL: https://github.com/apache/kafka/pull/17569#issuecomment-2446002041 Hi @lianetm, thanks for the review. I addressed all comments. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

Re: [PR] MINOR: Using rocksdb's prefixScan in fk joins for better performances [kafka]

2024-10-30 Thread via GitHub
aliehsaeedii commented on code in PR #16218: URL: https://github.com/apache/kafka/pull/16218#discussion_r1822267319 ## streams/src/main/java/org/apache/kafka/streams/kstream/internals/foreignkeyjoin/ForeignTableJoinProcessorSupplier.java: ## @@ -111,34 +110,26 @@ public void pro

Re: [PR] KAFKA-16339: [1/4 KStream#transform] Remove Deprecated "transformer" methods and classes [kafka]

2024-10-30 Thread via GitHub
fonsdant commented on PR #17198: URL: https://github.com/apache/kafka/pull/17198#issuecomment-2446464373 @mjsax, sorry for the delay, I am still refactoring the tests, replacing transform with process. Given the coming deadline, I agree it would be adequate someone more experienced t

Re: [PR] MINOR: Update the upgrade docs to include 3.8.1 version [kafka]

2024-10-30 Thread via GitHub
jlprat commented on PR #17628: URL: https://github.com/apache/kafka/pull/17628#issuecomment-2446466947 Tests failed but it makes no sense for this PR: > Found 3 test failures: FAILED ❌ PlaintextConsumerTest > testCoordinatorFailover(String, String).quorum=kraft.groupProtocol=classi

Re: [PR] MINOR: Add Kafka 3.8.1 to system tests [kafka]

2024-10-30 Thread via GitHub
jlprat commented on PR #17629: URL: https://github.com/apache/kafka/pull/17629#issuecomment-2446469212 This PR should only be merged once the artifacts are uploaded to Confluent's S3 bucket (iirc) -- This is an automated message from the Apache Git Service. To respond to the message, plea

[jira] [Resolved] (KAFKA-17622) Kafka Streams Timeout During Partition Rebalance

2024-10-30 Thread Alieh Saeedi (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17622?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alieh Saeedi resolved KAFKA-17622. -- Resolution: Fixed > Kafka Streams Timeout During Partition Rebalance > --

[jira] [Updated] (KAFKA-17227) Apache Kafka 3.8.0 /tmp exec permission

2024-10-30 Thread Francisco Martinez (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17227?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Francisco Martinez updated KAFKA-17227: --- Attachment: kafka_issue_3.8.1.png > Apache Kafka 3.8.0 /tmp exec permission > --

Re: [PR] KAFKA-17888: e2e should support to run <2.3 kafka under JDK 11 [kafka]

2024-10-30 Thread via GitHub
m1a2st commented on PR #17625: URL: https://github.com/apache/kafka/pull/17625#issuecomment-2446625175 My local machine can pass the test ![image](https://github.com/user-attachments/assets/ddf7a409-ab8b-4f6d-bdc9-2041f9c0c87b) -- This is an automated message from the Apache Git Se

[jira] [Resolved] (KAFKA-17867) Consider using zero-copy for PushTelemetryRequest

2024-10-30 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17867?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai resolved KAFKA-17867. Fix Version/s: 4.0.0 Resolution: Fixed > Consider using zero-copy for PushTelemetry

Re: [PR] Test minor gh review action - this is a test PR, do not review [kafka]

2024-10-30 Thread via GitHub
viktorsomogyi closed pull request #15123: Test minor gh review action - this is a test PR, do not review URL: https://github.com/apache/kafka/pull/15123 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] KAFKA-17867 Consider using zero-copy for PushTelemetryRequest [kafka]

2024-10-30 Thread via GitHub
chia7712 merged PR #17622: URL: https://github.com/apache/kafka/pull/17622 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

Re: [PR] KAFKA-17593; [1/N] Introduce re2j dependency [kafka]

2024-10-30 Thread via GitHub
lianetm commented on PR #17634: URL: https://github.com/apache/kafka/pull/17634#issuecomment-2447095849 We are just missing the lic file right? https://github.com/apache/kafka/blob/898a878c258a022a5cbf4fca5b5e5a1ce56cbc27/licenses/re2j-GO -- This is an automated message from the Apache Gi

[PR] MINOR: Fix typo in ConsumerGroupHeartbeatResponse.json [kafka]

2024-10-30 Thread via GitHub
dajac opened a new pull request, #17635: URL: https://github.com/apache/kafka/pull/17635 We forgot to change `INVALID_SUBSCRIPTION_REGEX` to `INVALID_REGULAR_EXPRESSION` in the spec. ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation -

[PR] KAFKA-17593; [1/N] Introduce re2j dependency [kafka]

2024-10-30 Thread via GitHub
dajac opened a new pull request, #17634: URL: https://github.com/apache/kafka/pull/17634 This patch is the first of a series of patches to introduce support for server side regular expression. It introduces the re2j dependency. Co-authored-by: Lianet Magrans ### Committer Chec

Re: [PR] KAFKA-17840: Move ReplicationQuotaManager, ClientRequestQuotaManager and QuotaFactory to server module [kafka]

2024-10-30 Thread via GitHub
chia7712 merged PR #17609: URL: https://github.com/apache/kafka/pull/17609 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

Re: [PR] KAFKA-17814 Use `final` declaration to replace the suppression `this-escape` [kafka]

2024-10-30 Thread via GitHub
Linsiyuan9 commented on PR #17613: URL: https://github.com/apache/kafka/pull/17613#issuecomment-2447161463 Hi @frankvicky ,Sorry for replying you so late. I have modified it -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[jira] [Commented] (KAFKA-17864) Ensure all fields in the protocol have a description

2024-10-30 Thread Xiao Yang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17894213#comment-17894213 ] Xiao Yang commented on KAFKA-17864: --- Hi @ mimaisonMickael Maison, I would like to ask,

Re: [PR] MINOR: fix code listings for ops.html [kafka]

2024-10-30 Thread via GitHub
jlprat closed pull request #10768: MINOR: fix code listings for ops.html URL: https://github.com/apache/kafka/pull/10768 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

Re: [PR] KAFKA-17767 Store the test catalog in Git [2/n] (2nd attempt) [kafka]

2024-10-30 Thread via GitHub
mumrah commented on PR #17627: URL: https://github.com/apache/kafka/pull/17627#issuecomment-2447163177 @chia7712 can you take a look? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[jira] [Commented] (KAFKA-17227) Apache Kafka 3.8.0 /tmp exec permission

2024-10-30 Thread Josep Prat (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17227?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17894198#comment-17894198 ] Josep Prat commented on KAFKA-17227: If I remember right, 3.9.0 won't have this prob

Re: [PR] KAFKA-17593; [1/N] Introduce re2j dependency [kafka]

2024-10-30 Thread via GitHub
chia7712 commented on PR #17634: URL: https://github.com/apache/kafka/pull/17634#issuecomment-2447191336 Out of curiosity, if I recall correctly, Google's RE2 is not fully compatible with Java regex. Could this cause issues if the `Consumer` accepts Java `Pattern`, allowing users to use uns

Re: [PR] KAFKA-17767 Store the test catalog in Git [2/n] (2nd attempt) [kafka]

2024-10-30 Thread via GitHub
chia7712 commented on PR #17627: URL: https://github.com/apache/kafka/pull/17627#issuecomment-2447204526 > can you take a look? sure! will take a look later; I'm heading into a meeting now. :smile: -- This is an automated message from the Apache Git Service. To respond to the messa

Re: [PR] KAFKA-17593; [1/N] Introduce re2j dependency [kafka]

2024-10-30 Thread via GitHub
dajac commented on PR #17634: URL: https://github.com/apache/kafka/pull/17634#issuecomment-2447212630 > Out of curiosity, if I recall correctly, Google's RE2 is not fully compatible with Java regex. Could this cause issues if the `Consumer` accepts Java `Pattern`, allowing users to use unsu

Re: [PR] KAFKA-17888: e2e should support to run <2.3 kafka under JDK 11 [kafka]

2024-10-30 Thread via GitHub
chia7712 commented on code in PR #17625: URL: https://github.com/apache/kafka/pull/17625#discussion_r1822556763 ## tests/docker/Dockerfile: ## @@ -13,10 +13,36 @@ # See the License for the specific language governing permissions and # limitations under the License. -# The ba

[jira] [Commented] (KAFKA-17864) Ensure all fields in the protocol have a description

2024-10-30 Thread Mickael Maison (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17894220#comment-17894220 ] Mickael Maison commented on KAFKA-17864: To be honest I was expecting this work

[jira] [Comment Edited] (KAFKA-17864) Ensure all fields in the protocol have a description

2024-10-30 Thread Xiao Yang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17894213#comment-17894213 ] Xiao Yang edited comment on KAFKA-17864 at 10/30/24 1:31 PM: -

[jira] [Commented] (KAFKA-17227) Apache Kafka 3.8.0 /tmp exec permission

2024-10-30 Thread Francisco Martinez (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17227?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17894222#comment-17894222 ] Francisco Martinez commented on KAFKA-17227: Josep, the same with 3.8.1. Wit

Re: [PR] KAFKA-17480: New consumer commit all consumed should retrieve offsets in background thread [kafka]

2024-10-30 Thread via GitHub
FrankYang0529 commented on PR #17150: URL: https://github.com/apache/kafka/pull/17150#issuecomment-2447342501 Hi @lianetm, thanks for the review. I address all comments with following update: * Move `ConsumerUtils#maybeUpdateLastSeenEpochIfNewer` to `ApplicationEventProcessor#maybeUp

Re: [PR] KAFKA-17726: New consumer subscribe/subscribeFromPattern in background thread (WIP) [kafka]

2024-10-30 Thread via GitHub
lianetm commented on code in PR #17569: URL: https://github.com/apache/kafka/pull/17569#discussion_r1822849105 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java: ## @@ -1679,7 +1658,13 @@ private void sendPrefetches(Timer timer) {

Re: [PR] KAFKA-17726: New consumer subscribe/subscribeFromPattern in background thread (WIP) [kafka]

2024-10-30 Thread via GitHub
lianetm commented on PR #17569: URL: https://github.com/apache/kafka/pull/17569#issuecomment-2447503919 Also, @FrankYang0529 could you please remove the WIP from the PR title and merge trunk latest changes? Thanks! Almost there -- This is an automated message from the Apache Git Service.

[jira] [Commented] (KAFKA-17227) Apache Kafka 3.8.0 /tmp exec permission

2024-10-30 Thread Josep Prat (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17227?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17894224#comment-17894224 ] Josep Prat commented on KAFKA-17227: Ah great, then we backported that one as well.

Re: [PR] MINOR: Correct error message in reassign_partitions_test.py [kafka]

2024-10-30 Thread via GitHub
jolshan merged PR #17632: URL: https://github.com/apache/kafka/pull/17632 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.

Re: [PR] KAFKA-17593; [1/N] Introduce re2j dependency [kafka]

2024-10-30 Thread via GitHub
dajac merged PR #17634: URL: https://github.com/apache/kafka/pull/17634 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or

Re: [PR] MINOR: Fix typo in ConsumerGroupHeartbeatResponse.json [kafka]

2024-10-30 Thread via GitHub
dajac merged PR #17635: URL: https://github.com/apache/kafka/pull/17635 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or

Re: [PR] KAFKA-17546: Admin.listGroups and kafka-groups.sh [kafka]

2024-10-30 Thread via GitHub
chia7712 commented on code in PR #17626: URL: https://github.com/apache/kafka/pull/17626#discussion_r1823307470 ## clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java: ## @@ -3490,6 +3490,138 @@ void handleFailure(Throwable throwable) { return new

Re: [PR] MINOR: Add Kafka 3.8.1 to system tests [kafka]

2024-10-30 Thread via GitHub
chia7712 merged PR #17629: URL: https://github.com/apache/kafka/pull/17629 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

[jira] [Updated] (KAFKA-17463) Flaky test: kafka.api.PlaintextAdminIntegrationTest."testShareGroups(String).quorum=kraft+kip932"

2024-10-30 Thread Apoorv Mittal (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17463?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Apoorv Mittal updated KAFKA-17463: -- Summary: Flaky test: kafka.api.PlaintextAdminIntegrationTest."testShareGroups(String).quorum=k

Re: [PR] KAFKA-17757: Remove Utils.mkEntry [kafka]

2024-10-30 Thread via GitHub
chia7712 commented on PR #17488: URL: https://github.com/apache/kafka/pull/17488#issuecomment-2447990583 @mingyen066 please fix conflicts -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

Re: [PR] KAFKA-17882: improve the document about "default value" of tagged structure field [kafka]

2024-10-30 Thread via GitHub
chia7712 commented on code in PR #17618: URL: https://github.com/apache/kafka/pull/17618#discussion_r1823170749 ## clients/src/main/resources/common/message/README.md: ## @@ -139,6 +139,20 @@ breaking compatibility. Note that tagged fields can only be added to "flexible" mess

Re: [PR] KAFKA-17002: Integrated partition leader epoch for Persister APIs (KIP-932) [kafka]

2024-10-30 Thread via GitHub
apoorvmittal10 commented on PR #16842: URL: https://github.com/apache/kafka/pull/16842#issuecomment-2447999870 Hi @junrao , thanks for the feedback. Addressed and replied. There is one test which was previously marked as flaky but I can see the failure in this PR as well. I have updated t

[jira] [Updated] (KAFKA-17463) Flaky test: kafka.api.PlaintextAdminIntegrationTest."testShareGroups(String).quorum=kraft+kip932"

2024-10-30 Thread Apoorv Mittal (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17463?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Apoorv Mittal updated KAFKA-17463: -- Description: Test has been failing for multiple runs now: [https://github.com/apache/kafka/ac

Re: [PR] KAFKA-17002: Integrated partition leader epoch for Persister APIs (KIP-932) [kafka]

2024-10-30 Thread via GitHub
apoorvmittal10 commented on code in PR #16842: URL: https://github.com/apache/kafka/pull/16842#discussion_r1823129269 ## core/src/main/java/kafka/server/share/SharePartitionManager.java: ## @@ -540,57 +571,76 @@ void processShareFetch(ShareFetchData shareFetchData) {

[jira] [Created] (KAFKA-17902) Flaky Test kafka.admin.DeleteTopicTest testAddPartitionDuringDeleteTopic

2024-10-30 Thread David Arthur (Jira)
David Arthur created KAFKA-17902: Summary: Flaky Test kafka.admin.DeleteTopicTest testAddPartitionDuringDeleteTopic Key: KAFKA-17902 URL: https://issues.apache.org/jira/browse/KAFKA-17902 Project: Kaf

[jira] [Reopened] (KAFKA-15918) Flaky test - OffsetsApiIntegrationTest.testResetSinkConnectorOffsets

2024-10-30 Thread David Arthur (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15918?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Arthur reopened KAFKA-15918: -- https://ge.apache.org/scans/tests?search.names=CI%20workflow%2CGit%20repository&search.rootProject

Re: [PR] KAFKA-14562 [2/3]: Implement epoch bump after every transaction (KIP-890) [kafka]

2024-10-30 Thread via GitHub
rreddy-22 commented on code in PR #17402: URL: https://github.com/apache/kafka/pull/17402#discussion_r1823191365 ## core/src/main/scala/kafka/coordinator/transaction/TransactionMetadata.scala: ## @@ -346,14 +346,14 @@ private[transaction] class TransactionMetadata(val transacti

[jira] [Updated] (KAFKA-17902) Flaky Test kafka.admin.DeleteTopicTest testAddPartitionDuringDeleteTopic

2024-10-30 Thread David Arthur (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17902?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Arthur updated KAFKA-17902: - Labels: flaky-test (was: ) > Flaky Test kafka.admin.DeleteTopicTest testAddPartitionDuringDelet

Re: [PR] KAFKA-14562 [2/3]: Implement epoch bump after every transaction (KIP-890) [kafka]

2024-10-30 Thread via GitHub
rreddy-22 commented on code in PR #17402: URL: https://github.com/apache/kafka/pull/17402#discussion_r1823190412 ## core/src/main/scala/kafka/coordinator/transaction/TransactionMetadata.scala: ## @@ -346,14 +346,14 @@ private[transaction] class TransactionMetadata(val transacti

Re: [PR] KAFKA-17609:[2/4]Convert system tests to kraft part 2 [kafka]

2024-10-30 Thread via GitHub
bbejeck commented on PR #17321: URL: https://github.com/apache/kafka/pull/17321#issuecomment-2447741172 Merged #17321 into trunk -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comme

Re: [PR] KAFKA-17002: Integrated partition leader epoch for Persister APIs (KIP-932) [kafka]

2024-10-30 Thread via GitHub
apoorvmittal10 commented on code in PR #16842: URL: https://github.com/apache/kafka/pull/16842#discussion_r1823126487 ## core/src/main/java/kafka/server/share/SharePartitionManager.java: ## @@ -490,6 +497,30 @@ public void acknowledgeSessionUpdate(String groupId, ShareRequestMe

Re: [PR] MINOR: Use JDK 17 in Vagrant after dropping JDK 8 [kafka]

2024-10-30 Thread via GitHub
chia7712 commented on PR #17576: URL: https://github.com/apache/kafka/pull/17576#issuecomment-2448053676 > We'll file a PR later, see #17625 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

Re: [PR] KAFKA-17880: Move integration test from streams module to streams/integration-tests module [kafka]

2024-10-30 Thread via GitHub
chia7712 commented on code in PR #17615: URL: https://github.com/apache/kafka/pull/17615#discussion_r1823191625 ## build.gradle: ## @@ -2803,6 +2793,7 @@ project(':streams:streams-scala') { testImplementation project(':server-common').sourceSets.test.output testImpleme

[PR] KAFKA-17625: Removing explicit ZK test parameterizations [kafka]

2024-10-30 Thread via GitHub
kevin-wu24 opened a new pull request, #17638: URL: https://github.com/apache/kafka/pull/17638 This PR removes ZK test parameterizations from ducktape by: * Removing `zk` from `quorum.all_non_upgrade` * Removing `quorum.zk` from `@matrix` and `@parametrize` annotations * Changing usa

Re: [PR] KAFKA-17593; [1/N] Introduce re2j dependency [kafka]

2024-10-30 Thread via GitHub
dajac commented on PR #17634: URL: https://github.com/apache/kafka/pull/17634#issuecomment-2447115423 @lianetm Good catch! Fixed! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comm

[jira] [Updated] (KAFKA-17900) Consider async resolution for client-side regex in new consumer

2024-10-30 Thread Lianet Magrans (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17900?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lianet Magrans updated KAFKA-17900: --- Description: [This concerns the regex used on consumer.subscribe(Pattern), that is computed

Re: [PR] KAFKA-17890: Move DelayedOperationPurgatory to server-common [kafka]

2024-10-30 Thread via GitHub
mimaison commented on code in PR #17636: URL: https://github.com/apache/kafka/pull/17636#discussion_r1822926022 ## core/src/main/scala/kafka/server/TopicKey.scala: ## @@ -0,0 +1,25 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor lice

Re: [PR] KAFKA-17609:[4/4]Convert system tests to kraft part 4 [kafka]

2024-10-30 Thread via GitHub
bbejeck commented on PR #17328: URL: https://github.com/apache/kafka/pull/17328#issuecomment-2447632557 [Link for passing tests](https://semaphore.ci.confluent.io/jobs/d23b0787-df34-4b40-9500-dd9eeb13eea0/summary?report_id=0356f43b-c807-318c-b61e-09e8fdd4e976) in this PR ![zk_to_kra

Re: [PR] KAFKA-17890: Move DelayedOperationPurgatory to server-common [kafka]

2024-10-30 Thread via GitHub
mimaison commented on code in PR #17636: URL: https://github.com/apache/kafka/pull/17636#discussion_r1822933178 ## core/src/main/scala/kafka/server/DelayedCreatePartitions.scala: ## @@ -49,7 +51,7 @@ class DelayedCreatePartitions(delayMs: Long, cre

[jira] [Assigned] (KAFKA-17900) Consider async resolution for client-side regex in new consumer

2024-10-30 Thread Lianet Magrans (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17900?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lianet Magrans reassigned KAFKA-17900: -- Assignee: TaiJuWu > Consider async resolution for client-side regex in new consumer >

[PR] KAFKA-17899: Add more unit tests for NetworkReceive [kafka]

2024-10-30 Thread via GitHub
frankvicky opened a new pull request, #17637: URL: https://github.com/apache/kafka/pull/17637 JIRA: KAFKA-17899 > as title, this class is widely used in Kafka, and it should have more unit tests to ensure its functionality is protected. ### Committer Checklist (excluded from co

[jira] [Commented] (KAFKA-17900) Consider async resolution for client-side regex in new consumer

2024-10-30 Thread Lianet Magrans (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17900?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17894278#comment-17894278 ] Lianet Magrans commented on KAFKA-17900: Done, thanks! Happy to help with questi

Re: [PR] KAFKA-17890: Move DelayedOperationPurgatory to server-common [kafka]

2024-10-30 Thread via GitHub
mimaison commented on code in PR #17636: URL: https://github.com/apache/kafka/pull/17636#discussion_r1822937151 ## core/src/main/scala/kafka/cluster/Partition.scala: ## @@ -93,18 +94,18 @@ class DelayedOperations(topicId: Option[Uuid], produce: DelayedOp

Re: [PR] KAFKA-17002: Integrated partition leader epoch for Persister APIs (KIP-932) [kafka]

2024-10-30 Thread via GitHub
apoorvmittal10 commented on code in PR #16842: URL: https://github.com/apache/kafka/pull/16842#discussion_r1823135757 ## core/src/main/java/kafka/server/share/SharePartition.java: ## @@ -1053,6 +1085,22 @@ void releaseFetchLock() { fetchLock.set(false); } +/*

Re: [PR] KAFKA-17002: Integrated partition leader epoch for Persister APIs (KIP-932) [kafka]

2024-10-30 Thread via GitHub
apoorvmittal10 commented on code in PR #16842: URL: https://github.com/apache/kafka/pull/16842#discussion_r1823146845 ## core/src/test/java/kafka/server/share/SharePartitionManagerTest.java: ## @@ -2157,19 +2153,203 @@ public void testShareFetchProcessingExceptions() throws Exc

Re: [PR] KAFKA-17726: New consumer subscribe/subscribeFromPattern in background thread [kafka]

2024-10-30 Thread via GitHub
lianetm commented on code in PR #17569: URL: https://github.com/apache/kafka/pull/17569#discussion_r1822954928 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java: ## @@ -1679,7 +1658,13 @@ private void sendPrefetches(Timer timer) {

Re: [PR] KAFKA-17002: Integrated partition leader epoch for Persister APIs (KIP-932) [kafka]

2024-10-30 Thread via GitHub
apoorvmittal10 commented on code in PR #16842: URL: https://github.com/apache/kafka/pull/16842#discussion_r1823155007 ## core/src/test/java/kafka/server/share/SharePartitionManagerTest.java: ## @@ -2157,19 +2153,203 @@ public void testShareFetchProcessingExceptions() throws Exc

Re: [PR] KAFKA-17002: Integrated partition leader epoch for Persister APIs (KIP-932) [kafka]

2024-10-30 Thread via GitHub
apoorvmittal10 commented on code in PR #16842: URL: https://github.com/apache/kafka/pull/16842#discussion_r1823155215 ## core/src/main/java/kafka/server/share/SharePartitionManager.java: ## @@ -617,22 +667,44 @@ private void maybeCompleteInitializationWithException(

Re: [PR] KAFKA-17609: Migrate broker compatibility test from ZK to KRaft [kafka]

2024-10-30 Thread via GitHub
bbejeck commented on PR #17603: URL: https://github.com/apache/kafka/pull/17603#issuecomment-2448263566 Confirmed 2.8.2 fails in system test per [previous comment](https://github.com/apache/kafka/pull/17603#discussion_r1818118747) ![broker_fails_at_2 8](https://github.com/user-attach

[jira] [Created] (KAFKA-17903) Remove KafkaFuture#Function and KafkaFuture#thenApply

2024-10-30 Thread Chia-Ping Tsai (Jira)
Chia-Ping Tsai created KAFKA-17903: -- Summary: Remove KafkaFuture#Function and KafkaFuture#thenApply Key: KAFKA-17903 URL: https://issues.apache.org/jira/browse/KAFKA-17903 Project: Kafka Iss

[jira] [Commented] (KAFKA-17900) Consider async resolution for client-side regex in new consumer

2024-10-30 Thread TaiJuWu (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17900?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17894266#comment-17894266 ] TaiJuWu commented on KAFKA-17900: - Hi[~lianetm] , may I have this one if you are not wor

Re: [PR] KAFKA-17726: New consumer subscribe/subscribeFromPattern in background thread (WIP) [kafka]

2024-10-30 Thread via GitHub
lianetm commented on code in PR #17569: URL: https://github.com/apache/kafka/pull/17569#discussion_r1822808489 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java: ## @@ -1679,7 +1658,13 @@ private void sendPrefetches(Timer timer) {

Re: [PR] KAFKA-17609:[3/4]Convert system tests to kraft part 3 [kafka]

2024-10-30 Thread via GitHub
bbejeck merged PR #17327: URL: https://github.com/apache/kafka/pull/17327 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.

Re: [PR] KAFKA-17609:[2/4]Convert system tests to kraft part 2 [kafka]

2024-10-30 Thread via GitHub
bbejeck commented on PR #17321: URL: https://github.com/apache/kafka/pull/17321#issuecomment-2447722430 [Link to passing tests](https://semaphore.ci.confluent.io/jobs/fa50bfdc-920b-477e-93c2-90d9d57e18ca/summary?report_id=0356f43b-c807-318c-b61e-09e8fdd4e976) ![zk_to_kraft_conversion

Re: [PR] MINOR: Various cleanups in metadata [kafka]

2024-10-30 Thread via GitHub
mimaison commented on code in PR #17633: URL: https://github.com/apache/kafka/pull/17633#discussion_r1822977144 ## metadata/src/main/java/org/apache/kafka/metadata/util/SnapshotFileReader.java: ## @@ -130,17 +131,15 @@ private void handleControlBatch(FileChannelRecordBatch batc

Re: [PR] KAFKA-17767 Store the test catalog in Git [2/n] (2nd attempt) [kafka]

2024-10-30 Thread via GitHub
mumrah commented on code in PR #17627: URL: https://github.com/apache/kafka/pull/17627#discussion_r1823120730 ## .github/workflows/build.yml: ## @@ -191,3 +191,33 @@ jobs: path: ~/.gradle/build-scan-data compression-level: 9 if-no-files-found: ig

Re: [PR] KAFKA-17767 Store the test catalog in Git [2/n] (2nd attempt) [kafka]

2024-10-30 Thread via GitHub
chia7712 commented on code in PR #17627: URL: https://github.com/apache/kafka/pull/17627#discussion_r1823041804 ## .github/workflows/build.yml: ## @@ -191,3 +191,33 @@ jobs: path: ~/.gradle/build-scan-data compression-level: 9 if-no-files-found:

Re: [PR] KAFKA-17609:[2/4]Convert system tests to kraft part 2 [kafka]

2024-10-30 Thread via GitHub
bbejeck merged PR #17321: URL: https://github.com/apache/kafka/pull/17321 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.

[jira] [Updated] (KAFKA-17463) Failing test: kafka.api.PlaintextAdminIntegrationTest."testShareGroups(String).quorum=kraft+kip932"

2024-10-30 Thread Apoorv Mittal (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17463?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Apoorv Mittal updated KAFKA-17463: -- Summary: Failing test: kafka.api.PlaintextAdminIntegrationTest."testShareGroups(String).quorum

[jira] [Updated] (KAFKA-17463) Flaky test: kafka.api.PlaintextAdminIntegrationTest."testShareGroups(String).quorum=kraft+kip932"

2024-10-30 Thread Apoorv Mittal (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17463?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Apoorv Mittal updated KAFKA-17463: -- Description: Test has been failing consistent hence moving from flaky: https://github.com/apa

Re: [PR] MINOR: Improve doc for controller membership change [kafka]

2024-10-30 Thread via GitHub
cmccabe merged PR #17598: URL: https://github.com/apache/kafka/pull/17598 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.

Re: [PR] KAFKA-17609: Migrate broker compatibility test from ZK to KRaft [kafka]

2024-10-30 Thread via GitHub
bbejeck commented on code in PR #17603: URL: https://github.com/apache/kafka/pull/17603#discussion_r1823063591 ## tests/kafkatest/tests/streams/streams_broker_compatibility_test.py: ## @@ -60,17 +53,15 @@ def __init__(self, test_context):

Re: [PR] KAFKA-17726: New consumer subscribe/subscribeFromPattern in background thread [kafka]

2024-10-30 Thread via GitHub
lianetm commented on code in PR #17569: URL: https://github.com/apache/kafka/pull/17569#discussion_r1822938162 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java: ## @@ -1679,7 +1658,13 @@ private void sendPrefetches(Timer timer) {

Re: [PR] KAFKA-17726: New consumer subscribe/subscribeFromPattern in background thread [kafka]

2024-10-30 Thread via GitHub
FrankYang0529 commented on code in PR #17569: URL: https://github.com/apache/kafka/pull/17569#discussion_r1822939447 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java: ## @@ -1679,7 +1658,13 @@ private void sendPrefetches(Timer timer) {

Re: [PR] KAFKA-17726: New consumer subscribe/subscribeFromPattern in background thread [kafka]

2024-10-30 Thread via GitHub
FrankYang0529 commented on PR #17569: URL: https://github.com/apache/kafka/pull/17569#issuecomment-2447655971 Yes, removed the WIP. Thanks for the reminder. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [PR] KAFKA-17609:[3/4]Convert system tests to kraft part 3 [kafka]

2024-10-30 Thread via GitHub
bbejeck commented on PR #17327: URL: https://github.com/apache/kafka/pull/17327#issuecomment-2447696445 [Link to passing ](https://semaphore.ci.confluent.io/jobs/9fa811f8-b6aa-4eba-a366-8def6c28f7ca/summary?report_id=0356f43b-c807-318c-b61e-09e8fdd4e976)tests. ![zk_to_kraft_conversio

[PR] KAFKA-17890: Move DelayedOperationPurgatory to server-common [kafka]

2024-10-30 Thread via GitHub
mimaison opened a new pull request, #17636: URL: https://github.com/apache/kafka/pull/17636 Moving this logic to server-common as it's used by RemoteLogManager which will end up in the storage module. ### Committer Checklist (excluded from commit message) - [ ] Verify design and im

[jira] [Created] (KAFKA-17900) Consider async resolution for client-side regex in new consumer

2024-10-30 Thread Lianet Magrans (Jira)
Lianet Magrans created KAFKA-17900: -- Summary: Consider async resolution for client-side regex in new consumer Key: KAFKA-17900 URL: https://issues.apache.org/jira/browse/KAFKA-17900 Project: Kafka

Re: [PR] MINOR: Various cleanups in metadata [kafka]

2024-10-30 Thread via GitHub
mumrah commented on code in PR #17633: URL: https://github.com/apache/kafka/pull/17633#discussion_r1822929049 ## metadata/src/main/java/org/apache/kafka/controller/PeriodicTaskControlManager.java: ## @@ -206,7 +206,7 @@ private void reschedule(PeriodicTask task, boolean immedia

Re: [PR] KAFKA-17726: New consumer subscribe/subscribeFromPattern in background thread (WIP) [kafka]

2024-10-30 Thread via GitHub
FrankYang0529 commented on code in PR #17569: URL: https://github.com/apache/kafka/pull/17569#discussion_r1822930007 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java: ## @@ -1679,7 +1658,13 @@ private void sendPrefetches(Timer timer) {

Re: [PR] KAFKA-17747: Trigger rebalance on rack topology changes [kafka]

2024-10-30 Thread via GitHub
FrankYang0529 commented on code in PR #17444: URL: https://github.com/apache/kafka/pull/17444#discussion_r1822995668 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/Utils.java: ## @@ -235,4 +238,20 @@ public static ApiMessage messageOrNull(ApiMessageAndVer

Re: [PR] KAFKA-17609:[4/4]Convert system tests to kraft part 4 [kafka]

2024-10-30 Thread via GitHub
bbejeck merged PR #17328: URL: https://github.com/apache/kafka/pull/17328 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.

Re: [PR] KAFKA-17609:[4/4]Convert system tests to kraft part 4 [kafka]

2024-10-30 Thread via GitHub
bbejeck commented on PR #17328: URL: https://github.com/apache/kafka/pull/17328#issuecomment-2447663430 Merged #17328 into trunk -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comme

Re: [PR] KAFKA-17726: New consumer subscribe/subscribeFromPattern in background thread [kafka]

2024-10-30 Thread via GitHub
FrankYang0529 commented on code in PR #17569: URL: https://github.com/apache/kafka/pull/17569#discussion_r1822943740 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java: ## @@ -1679,7 +1658,13 @@ private void sendPrefetches(Timer timer) {

Re: [PR] KAFKA-17835: Move ProducerIdManager and RPCProducerIdManager to server module [kafka]

2024-10-30 Thread via GitHub
chia7712 merged PR #17562: URL: https://github.com/apache/kafka/pull/17562 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

Re: [PR] KAFKA-17726: New consumer subscribe/subscribeFromPattern in background thread [kafka]

2024-10-30 Thread via GitHub
TaiJuWu commented on code in PR #17569: URL: https://github.com/apache/kafka/pull/17569#discussion_r1822960666 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java: ## @@ -1679,7 +1658,13 @@ private void sendPrefetches(Timer timer) {

[jira] [Updated] (KAFKA-17835) Move ProducerIdManager and RPCProducerIdManager to transaction-coordinator module

2024-10-30 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17835?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai updated KAFKA-17835: --- Summary: Move ProducerIdManager and RPCProducerIdManager to transaction-coordinator module

[PR] MINOR: Quarantine flaky tests [kafka]

2024-10-30 Thread via GitHub
mumrah opened a new pull request, #17639: URL: https://github.com/apache/kafka/pull/17639 Using the last 7 days of data, this patch marks all flaky tests with more than 10% flakiness on trunk. -- This is an automated message from the Apache Git Service. To respond to the message, please l

Re: [PR] MINOR: Various cleanups in metadata [kafka]

2024-10-30 Thread via GitHub
chia7712 merged PR #17633: URL: https://github.com/apache/kafka/pull/17633 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

  1   2   >